commit 160d2a1b15bae4df7926e998fb83e1b874ce8800
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Wed Oct 8 16:47:13 2014 +0200

    Update NEWS for 1.6.10
    
    Add the change number of the late aklog fix. Also state that we
    support Linux clients up to 3.16 only, since we already know that
    3.17 needs a few tweaks, probably to ship with 1.6.10.1 .
    
    Change-Id: I5904d366611e329dbf06e1b6f2ba3ebf366e7d05
    Reviewed-on: http://gerrit.openafs.org/11531
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 50c5f3789cc61de7ddbfe07922027b6464caa4ae
Author: Anders Kaseorg <andersk@mit.edu>
Date:   Tue Sep 30 13:52:31 2014 -0400

    aklog: Fix segfault on aklog -path
    
    Commit 2fac53522e7ef5b3a376e191bffdc1f6784e6995 “aklog: Fix improper
    use of readlink” inadvertently changed the meaning of int link from a
    boolean flag (length > 0) to just a length.  This caused ‘aklog -path
    (anything)’ to segfault.
    
    Update the type of link and the condition of the while loop to account
    for this change.
    
    FIXES 131930
    
    Reviewed-on: http://gerrit.openafs.org/11517
    Reviewed-by: Anders Kaseorg <andersk@mit.edu>
    Tested-by: Anders Kaseorg <andersk@mit.edu>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit fbea3265b3bc042b97be17229839ccf7d11a0bf9)
    
    Change-Id: I6eb0126c574665507be923102c3fa812c3716352
    Reviewed-on: http://gerrit.openafs.org/11530
    Tested-by: Anders Kaseorg <andersk@mit.edu>
    Reviewed-by: Anders Kaseorg <andersk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 38481450bba5f82b0eda072280737e438f9a11b5
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Wed Sep 24 13:48:54 2014 +0200

    Make OpenAFS 1.6.10
    
    Update version strings and NEWS for 1.6.10
    
    Change-Id: Idc59095829a7b8a1f882b46d9228d524820fc6fc
    Reviewed-on: http://gerrit.openafs.org/11486
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 871c19fc168dec5d22da764ca64decbe19f3b1e5
Author: Ben Kaduk <kaduk@mit.edu>
Date:   Fri Jul 18 15:19:24 2014 -0400

    FBSD: adhere to gop_lookupname() semantics
    
    The current semantics are that gop_lookupname() returns an unlocked
    vnode; the previous code was written to a different semantic that
    a locked vnode should be returned.
    
    This makes a disk cache more likely to work on FreeBSD, but such
    configurations remain not very tested.
    
    Reviewed-on: http://gerrit.openafs.org/11317
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 774d77e056515ae3e87c8f0be8e133c3cdb36bbb)
    
    Change-Id: I4ae9c269412c2ce6b9ec39a841ea87f27630591e
    Reviewed-on: http://gerrit.openafs.org/11448
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 396679c7cf78d0e35171d0e101c4ec17b8d6c858
Author: Garrett Wollman <wollman@csail.mit.edu>
Date:   Wed Aug 13 02:32:06 2014 -0400

    viced: time_t might not be long
    
    Fix a couple of printf format errors that bite on FreeBSD 10 for i386.
    Since time_t might be an int, it can't be printed with a long format.
    Since time_t might be a long in general, cast to it to long when
    printing.
    
    Reviewed-on: http://gerrit.openafs.org/11385
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 9dd67783bb2bd9ef8a972a1aac47b1925069a655)
    
    Change-Id: Icda432863a36169857a20300ab936a1a72de7891
    Reviewed-on: http://gerrit.openafs.org/11404
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit c5d09afecf985191050c00713d22d744dfeff401
Author: Garrett Wollman <wollman@csail.mit.edu>
Date:   Wed Aug 13 02:20:02 2014 -0400

    afsd: correct printf format mismatch in debugging printf
    
    On platforms where size_t is unsigned int, the type of
    cacheFiles * sizeof(AFSD_INO_T) is not an unsigned long as the format
    string requires.  Casting cacheFiles to unsigned long ensures that the
    result is at least unsigned long, although it will still be wrong if
    any architecture makes size_t be long long.  Fixes build for FreeBSD
    10 on i386.
    
    Reviewed-on: http://gerrit.openafs.org/11384
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit f02beb8d644ec2a52bf21737a040321905a39e20)
    
    Change-Id: I1e874f7f049e2fdfdfbe9e6413d421a5e1a5b249
    Reviewed-on: http://gerrit.openafs.org/11403
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 5b6286cdc5eadeb9575bcfb86685393b30cfa4d3
Author: Benjamin Kaduk <kaduk@mit.edu>
Date:   Thu Feb 6 16:22:49 2014 -0500

    pointers are not castable to unsigned int
    
    When printing a pointer's value for debugging purposes, use the
    dedicated printf format specifier for pointers instead of assuming
    that unsigned int ('x') is good enough.
    
    Found by clang on FreeBSD 10.0.
    
    Reviewed-on: http://gerrit.openafs.org/10820
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 758ec15f9391c296f1caa042385148f1a5e0bc84)
    
    Change-Id: Ibe88c38d0563ac125486d0ae7f16882a7989ee98
    Reviewed-on: http://gerrit.openafs.org/11402
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e125205aca8248ca7aab8d027a337abef3fc1c56
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Fri Aug 15 01:34:03 2014 -0500

    objdir build: Add objdir include paths
    
    In commits ff0644c4cf5a54747bf3af2cc9605163e1debcb7,
    3be9a451b523cd955cd5b3e68ee3a44ab083c14f, and
    7c451fab11b65dd5e2860715b939e5de33c7645e, some includes were changed
    from e.g. <afs/auth.h> to "auth.h". This means that src/auth must be
    in the include path for that file. For a file like src/auth/ktc.c,
    that's usually fine, since '.' is added to the include path.
    
    However, several of these files are also compiled from different
    directories, such as src/libafsauthent. These need to also have the
    relevant include path added, or else we cannot include the relevant
    file. So, add the needed include paths.
    
    This commit is 1.6-specific. The build system on the master branch
    differs greatly, and these files are not build separately in these
    directories.
    
    Change-Id: I502b99b9411aff9660b50f0f4d9a4fb4f6a1106a
    Reviewed-on: http://gerrit.openafs.org/11392
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit b0d95624e4790f173d40efadd3c64d58fafa0555
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Wed Aug 6 11:36:41 2014 +0200

    Make OpenAFS 1.6.10pre1
    
    prerelease for 1.6.10
    
    Change-Id: I952c26f1a211fdb3f2055eafce15d93d943e28a5
    Reviewed-on: http://gerrit.openafs.org/11354
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e67124fea4d73a72736dbb71ae37ba980a941685
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Thu Jul 31 16:45:39 2014 +0200

    Update NEWS for 1.6.10pre1
    
    Release notes for OpenAFS 1.6.10
    
    Change-Id: I1d5679e375ee442e364c7ee189a316424b7e5d1b
    Reviewed-on: http://gerrit.openafs.org/11343
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 9ed215017a7de26fff21b23c781816bed69d0ea6
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Fri Aug 8 17:13:09 2014 +0200

    redhat: package volscan
    
    Add volscan and the manual page to the files in the server package.
    
    Reviewed-on: http://gerrit.openafs.org/11370
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 80f4939a3b9e1d48c03d0797a21c9e77a844cf7f)
    
    Change-Id: I48012e78cb0155162677a44191fbc57c64b30a3c
    Reviewed-on: http://gerrit.openafs.org/11387
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit ca1efa55934ae4a3f37f69e6909df00ba748df97
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Wed Aug 6 15:08:33 2014 -0400

    volscan: fix copyright and licence notice
    
    These are new files and new content; fix the copyright notice and
    license to reflect.
    
    Reviewed-on: http://gerrit.openafs.org/11362
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 1283226ccb638be47ead6cc4d9a47381aa6b08d1)
    
    Change-Id: I4026bba6a10459ca0eb7b63666fe8e278949ca78
    Reviewed-on: http://gerrit.openafs.org/11388
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 3f31a8f12f62c855cb77bbee5c052b40b71f20e3
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Thu Mar 13 12:40:17 2014 -0400

    doc: volscan man page
    
    Provide a man page for the volscan utility
    
    Reviewed-on: http://gerrit.openafs.org/10905
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit a30b98c97d6fbf87018bcb6943e09c1c75a3918d)
    
    Change-Id: I980dd7842bd1c606cb09ee838a584b83d004ccb1
    Reviewed-on: http://gerrit.openafs.org/11280
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 22eddf1c63dea6267e8cd9ee9a0d90c5fd9978b3
Author: Benjamin Kaduk <kaduk@mit.edu>
Date:   Mon Apr 7 17:55:09 2014 -0400

    vol: Fix build with separate objdir
    
    The volscan-main and volinfo-main source files are in the source
    tree, not the object tree; refer to the objects in the Makefile
    as dependencies, so that they will be picked up properly.  The
    objects will be made just fine by the implicit .c.o rule.
    
    Reviewed-on: http://gerrit.openafs.org/10988
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Tested-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 074d745a02d80bfd2c16a4e2b7b4222022f8e641)
    
    Change-Id: I3f29fcfb0257e145e0aae62ba425ccd7df513a72
    Reviewed-on: http://gerrit.openafs.org/11279
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit d43dd100149584d5a2ae1f2d8514a917b73ebf28
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Wed Mar 12 15:15:32 2014 -0400

    volinfo: separate volscan binary
    
    Refactor vol-info.c into several files and change the makefile to
    build a separate volscan binary, instead of using the program name
    to determine if the user is running volinfo or volscan.
    
    This commit adds new source files for the volinfo and volscan main()
    function and a common header file.
    
    Reviewed-on: http://gerrit.openafs.org/10903
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit af2e3d81cff39ed06e3bfbfcbfff52163c503c54)
    
    Change-Id: Ie261ac5a8bd6baea7d5d5110248611219ee1c175
    Reviewed-on: http://gerrit.openafs.org/11278
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 5c944018cafac20f6d87b475bc239dbe5c80ddf7
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Wed Mar 12 09:37:59 2014 -0400

    volinfo: refactor global options
    
    Move the global options to a structure and pass it to the vol-info
    functions. This is a precursor for creating separate volinfo and
    volscan programs.
    
    Reviewed-on: http://gerrit.openafs.org/10902
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 77e4d2146e166c5c70d4255408bde5e6499a06bf)
    
    Change-Id: Id97ba0bfecb8104288f904b5efe693a6e652d844
    Reviewed-on: http://gerrit.openafs.org/11277
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit bbe8d75cc4ac02721dcb080170e17b7ce09ce0e9
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat Mar 15 11:04:31 2014 -0400

    volscan: hide -mask option
    
    The -mask option is unneccessary and sets a bad precedent, so
    deprecate and hide this option. The vnodes of interest can be found
    can be found easily and much more flexibly with a simple command
    pipeline.
    
    Reviewed-on: http://gerrit.openafs.org/10901
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 8119636976de651ff0b8ccdca6a1a703643f7447)
    
    Change-Id: I21519d7c0e9b3e3900cf3cd4c561d1a5aed1ef90
    Reviewed-on: http://gerrit.openafs.org/11276
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 833607e4119c308e229eb1b2735e64c82c6abd09
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Wed Sep 4 15:10:16 2013 -0400

    volscan: avoid printing null mount-point cellname
    
    The 'mcell' field is null when there is no cell set in the mount point,
    so do not try to print it.
    
    Reviewed-on: http://gerrit.openafs.org/10226
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit db2ed13359ce8e3cd6a4981f8ce8e10ba61f6463)
    
    Change-Id: I96ba7dec59cc6e0fc5663e8e037d76d1006905a7
    Reviewed-on: http://gerrit.openafs.org/11275
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 10683bed85f209dd33d9c833125050e4fd207d8b
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Wed Apr 11 15:34:29 2012 -0400

    volinfo: show header filenames even if error
    
    When invoked with -header option, print the header inode
    number, and namei filename, even if the header file cannot
    be opened.
    
    Reviewed-on: http://gerrit.openafs.org/7190
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Tom Keiser <tkeiser@sinenomine.net>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit b71f4ffa7c58ef7b27eb6e28d00892906aec49ec)
    
    Change-Id: Ibd68433ea778d5359c873e3764800d60fa7ae95d
    Reviewed-on: http://gerrit.openafs.org/11274
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit baa20f13174dd4c2081aa9d9c470b519c7efcd6d
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Tue Mar 27 00:33:26 2012 -0400

    volscan: index offset output column
    
    Add index offset as a possible volscan output column.
    
    Reviewed-on: http://gerrit.openafs.org/6980
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 03ec768fa65dc5961e161517871f3035df70b643)
    
    Change-Id: I17cede564fde259e04b7f1cb78724798808fb881
    Reviewed-on: http://gerrit.openafs.org/11273
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 4ddc47c71d342ab35dc6a5815a406f532468e07e
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon Mar 26 20:20:28 2012 -0400

    volscan: option to ignore dir vnode magic
    
    Option to ignore directory vnode magic when looking
    up the path names. Print which vnode failed when
    doing the checks.
    
    Reviewed-on: http://gerrit.openafs.org/6979
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry-picked from commit 22fbed08a6f23dbbc05fd567e6e8e21e4d1a9709)
    
    Change-Id: Ia9b61b8c0e812fbaa680f62b4b924d818135dc87
    Reviewed-on: http://gerrit.openafs.org/11272
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e7826e491d15ff334c8bb1d572a471d37d3284d2
Author: Paul Smeddle <paul.smeddle@morganstanley.com>
Date:   Mon Mar 12 19:56:11 2012 +0000

    Make volscan's column delimiter option work
    
    Currently, volscan ignores the -delim command-line option,
    using the hardcoded default. This patch adds processing
    for this option, allowing alternative characters.
    
    Corrects an error in a08c3207255756c825ab69a19e04f79dd879c646
    
    Reviewed-on: http://gerrit.openafs.org/6894
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
    Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
    (cherry picked from commit d62456255e13beef41770ad90ee6cb58068007b9)
    
    Change-Id: Ic5e253c2c1ae6fcdba79b70bf43ba16883389ccd
    Reviewed-on: http://gerrit.openafs.org/11271
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 52968010955bb7371ce43a91b5cc39872012511c
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Thu Feb 16 10:58:50 2012 -0500

    volinfo: initialize vnode details
    
    Clear the vnode details object. Fixes the path lookup in volscan.
    
    Reviewed-on: http://gerrit.openafs.org/6722
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit e5e9260c7936ce0b4d51855291421679acccaed4)
    
    Change-Id: If9848191166a774e99e68410d7891564743975e5
    Reviewed-on: http://gerrit.openafs.org/11270
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit dbe597d944716561f938906f66801dd0b8c0c2c3
Author: Derrick Brashear <shadow@dementix.org>
Date:   Tue Jan 17 16:08:56 2012 -0500

    volinfo: fix formating of placeholder printfs
    
    needed to placate gcc-llvm on lion
    
    Reviewed-on: http://gerrit.openafs.org/6565
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit 60df98806b1aaf6ea4ba8f089faf8e9247b2fba5)
    
    Change-Id: I583cc194ad81b025f925ad56a74c4acd941b7ddf
    Reviewed-on: http://gerrit.openafs.org/11269
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 0467802384c0c8bfa735e6378a9b5326048c7e05
Author: Jeffrey Altman <jaltman@your-file-system.com>
Date:   Thu Dec 15 03:28:34 2011 -0500

    vol: fix a08c3207255756c825ab69a19e04f79dd879c646
    
    Patchset a08c3207255756c825ab69a19e04f79dd879c646 broke the suse
    and windows builds by relying on C99 language syntax.  Fix it.
    
    Reviewed-on: http://gerrit.openafs.org/6337
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
    Tested-by: Jeffrey Altman <jaltman@secure-endpoints.com>
    (cherry picked from commit 37a0c3d00a6e2d072faf7c2958ef0c7224add161)
    
    Change-Id: I34963c4e941ee3d580494a87b244c67bc3806ac7
    Reviewed-on: http://gerrit.openafs.org/11268
    Tested-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 76bf8fefe21c33b14888e7999979b3b3518be943
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Tue Jul 26 09:18:44 2011 -0400

    volscan: print vnode metadata information
    
    volscan program to print vnode meta-data in a grep/awk/perl friendly
    format. Optionally, find the paths of each vnode relative to the volume
    root.  Access control list data can be reported, and are listed as one
    access entry per line. Mount point information can be shown to which
    volumes are mounted from given volumes.
    
    The path lookup code originally written by Tom Keiser.
    
    1.6 note: The 1.6 libcmd lacks parameter offsets, so this commit
    instead splits the param enums into volinfo_parm_t and volscan_parm_t,
    and just uses the regular cmd_AddParm to put the parameters in the
    same place as the enums. In addition, rx queues are used instead of
    opr queues, since opr queues do not exist in 1.6.
    
    Reviewed-on: http://gerrit.openafs.org/5102
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    Tested-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit a08c3207255756c825ab69a19e04f79dd879c646)
    
    Change-Id: Icd7c572d09fd5a5e82bd8a1d09c6fbbe229b6b1c
    Reviewed-on: http://gerrit.openafs.org/11267
    Tested-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 7f933a4584da0738aba9dff0312e719e260075ab
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon Jul 25 22:02:04 2011 -0400

    volinfo: implement -checkout option
    
    Implement the -checkout option using the FSSYNC communication
    channel with the fileserver.
    
    Reviewed-on: http://gerrit.openafs.org/5101
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit 752daf71cd75aa707fabb1b4598dd8ef1f51f973)
    
    Change-Id: Ic6614d0a28b968e261c5916e607ac8fd9d00f4d1
    Reviewed-on: http://gerrit.openafs.org/11266
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 56628f3ec8cb635c3dbd6fbbaa7a6649b6bdf5b1
Author: Derrick Brashear <shadow@dementix.org>
Date:   Mon Oct 10 16:57:35 2011 -0400

    volinfo: fix bad format string
    
    we need a format string; currently here we have none, which is no good
    
    Reviewed-on: http://gerrit.openafs.org/5591
    Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    Tested-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit 0676dc9e0c59e8aee3db5e0a7b4acf7229da7b88)
    
    Change-Id: I665eabadee79c358562b831bf15d513e4f945f75
    Reviewed-on: http://gerrit.openafs.org/11265
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 96c95dee3185915de8aacde3104a2e76cbc57747
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon Jul 25 09:21:34 2011 -0400

    volinfo: refactor vnode handling
    
    At program startup, register procedures to be called
    when scanning vnodes.
    
    Reviewed-on: http://gerrit.openafs.org/5100
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit 11f54962f638c8ae48d5193f6b695c252fbb9937)
    
    Change-Id: Iafee77acb6b175c6ba3983889c8c4adad17aaf79
    Reviewed-on: http://gerrit.openafs.org/11264
    Tested-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 7e2734c6d79ff4f9d3d4af8aa597fd37e2356d89
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat Jul 23 14:55:57 2011 -0400

    volinfo: release volume header ihandles when done
    
    After scanning the volume, release the header ihandles
    for the volume.
    
    Reviewed-on: http://gerrit.openafs.org/5099
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit 4aa72b4308bae8e1d789682e7ead83bcadded862)
    
    Change-Id: I7a24892fc5f6d77b4aaff4a280063bc13cf4d81e
    Reviewed-on: http://gerrit.openafs.org/11263
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit b5f3af865036dce44d6644aaea43c3755c769f78
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Wed Aug 10 10:23:40 2011 -0500

    volinfo: Include nfs.h
    
    nfs.h is required for various types used in vol-info.c. Include it. On
    namei this header gets pulled in indirectly via other means, but on
    inode it does not (and we shouldn't be relying on such anyway).
    
    Reviewed-on: http://gerrit.openafs.org/5185
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Tested-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 2cd9d0536b173bf8c983aecd8599de0a82610151)
    
    Change-Id: I8c4b1c096b617a3ed62b8e1c7b8677ee7de2a56e
    Reviewed-on: http://gerrit.openafs.org/11262
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 042239d03e2952fb68ed3bf89814550d5186eeb9
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Jul 22 23:38:36 2011 -0400

    volinfo: clean up headers
    
    Remove unneeded includes.
    
    Reviewed-on: http://gerrit.openafs.org/5098
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    Tested-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit be152a00a7e4043592094be30f4a811c67a4ac32)
    
    Change-Id: Ieb59affdc63f47d0adb35c89a2fc9d2ea72ba462
    Reviewed-on: http://gerrit.openafs.org/11261
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 1c739bf2986c2908a8ac674242e5ba32c3d59541
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Tue Jun 7 12:37:40 2011 -0400

    volinfo: fix false good magic line
    
    Fix false report of good magic/version numbers in volume
    header file.
    
    Reviewed-on: http://gerrit.openafs.org/4817
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 36f6eed2b458995ab973102acf74375bf0a66931)
    
    Change-Id: Id5972430ae8e2fe374a854c3c33d2837aac48185
    Reviewed-on: http://gerrit.openafs.org/11260
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 7914d83509959884d95b7a58f42fcaef965de7da
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Wed Jun 8 23:06:58 2011 -0500

    volinfo: PrintFileNames is namei-only
    
    PrintFileNames only exists on namei, so make sure it's inside a namei
    ifdef.
    
    Reviewed-on: http://gerrit.openafs.org/4830
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit fc087f187759398a2646480eca25c1195ed23d22)
    
    Change-Id: Id9cfacd35248389cb513a5470dd75ed5a2a30fb9
    Reviewed-on: http://gerrit.openafs.org/11259
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit eed61c2f865757074b55ae6ccfb91f50d7715f0e
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri May 27 18:17:44 2011 -0400

    volinfo: accept -sizeonly for -sizeOnly
    
    For consistency, allow -sizeonly (all lowercase letters) to
    request the size summary. The old option name, -sizeOnly is
    available as an alias.
    
    Define the command line option parameter positions and use
    those to set and look up the options.
    
    1.6 note: The libcmd in 1.6 lacks parameter aliases and offsets.
    Instead we create params the normal way and make the offsets enum line
    up with the default offsets. To get an alias for -sizeonly, we create
    a new parameter that just does the same thing (P_SIZEONLY_COMPAT).
    
    Reviewed-on: http://gerrit.openafs.org/4741
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 1a4262253e78aa7a4e8c58006abd3301f71bab89)
    
    Change-Id: Ic630a7c0b29bd62525dd2211a7771c647e1be8df
    Reviewed-on: http://gerrit.openafs.org/11258
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit dfaa6598236079478ac77b273aa49cacebca6029
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri May 27 12:22:34 2011 -0400

    volinfo: accept vice partition id for -part option
    
    Accept a partition id for the -part option. For example, -part a
    is the same as -part /vicepa.
    
    Reviewed-on: http://gerrit.openafs.org/4739
    Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 8fc3d6dfe196771a38f2bfe7275e90a73f742931)
    
    Change-Id: I9a52dc881e6b77526656ca94e4f175241a79551b
    Reviewed-on: http://gerrit.openafs.org/11257
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 5a1c61b955cfe295817f0033705ecc8e17a8fd86
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri May 27 11:29:33 2011 -0400

    volinfo: comments
    
    Add doxygen style comment headers.
    
    Reviewed-on: http://gerrit.openafs.org/4738
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 6b0ad5786d09446d6ecf723c892c11d6cce4493c)
    
    Change-Id: I69165f41bcfc5aa5fcb94bcaad8d31b7a0349179
    Reviewed-on: http://gerrit.openafs.org/11256
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 0db20a591a067276f49f7a3347372c875e0b898f
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri May 27 10:27:03 2011 -0400

    volinfo: fix file size data type
    
    Use afs_sfsize_t for file size instead of int.
    
    Reviewed-on: http://gerrit.openafs.org/4737
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 8eddff4b785a196b2aae8be2d3a0e75fa3b6c0cf)
    
    Change-Id: I670949abbb9ebfd652bb8baddcef47c7bad1b211
    Reviewed-on: http://gerrit.openafs.org/11255
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit a7bc83f6779989e5c4c0efbdee8b7ae4121a1fe8
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Thu May 26 21:58:11 2011 -0400

    volinfo: avoid exit on errors
    
    Instead of exiting on errors, try to carry on.
    
    Reviewed-on: http://gerrit.openafs.org/4736
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 59a1c40efbd3326a210776a0253f4f6c656a65ee)
    
    Change-Id: If5f461ac4c1d35ae27336eeab844e6706fcd5bbe
    Reviewed-on: http://gerrit.openafs.org/11254
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit d1ef6347e89d902e174a469dcb3f4f77c560c883
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Tue May 24 10:28:37 2011 -0400

    volinfo: refactor mode variables
    
    Untangle the various global mode variables, which became muddled when dsizeOnly
    and saveinodes were introduced. DumpInfo now indicates the default mode and
    DumpVnodes means print the vnode entries, not scan but sometimes print.  Remove
    unused globals.
    
    Reviewed-on: http://gerrit.openafs.org/4735
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 277a8ad658572b60e7e460c945adee78cc04038d)
    
    Change-Id: I9d5d9e9b2b65d703f5b35091f072b31072485d83
    Reviewed-on: http://gerrit.openafs.org/11253
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit df53d451cb25451245c2e0c01f191b5f0c35d71e
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sun May 22 22:53:46 2011 -0400

    volinfo: refactor volume and vnode handling code
    
    Refactor volume and vnode handling code for better
    maintainability.  Move the code invoked by -saveinodes to a new
    function. Remove an unneeded else clause in HandleVolumes.
    
    Reviewed-on: http://gerrit.openafs.org/4734
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 56714e9a4d01d1718bbca9f3930c2993e4b7d094)
    
    Change-Id: I96da8a2824af7283fa2d3fb34622d06715c058cb
    Reviewed-on: http://gerrit.openafs.org/11252
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 54c61781e2a1e59e9bfbd5cc065d9fef0c6f83a0
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Thu Jul 17 10:33:23 2014 -0500

    LINUX: Avoid premature RO volume lock error
    
    Commit 0fc27471e7da0c5de4addcdec1bfbca5208072cc avoids processing lock
    requests for RO volumes, but it did this both in afs_lockctl() and in
    the Linux-specific afs_linux_lock(). The changes in afs_linux_lock()
    are incorrect, since they also avoid F_GETLK requests (whereas
    afs_lockctl() just avoids F_SETLK* requests).
    
    Additionally, the section in afs_linux_lock() incorrectly reports an
    error, since it returns a positive EBADF error code, when we are
    supposed to return -EBADF.
    
    The result of all of this is that an F_GETLK F_WRLCK request for an RO
    volume always fails with fcntl() returning 9 (EBADF), which is an
    invalid return code for fcntl() F_GETLK (instead we should return -1
    with an errno of 9). But if there are no locks, we should return
    success anyway.
    
    Just remove this section, since afs_lockctl() handles this case itself
    anyway.
    
    Thanks to Todd Lewis for reporting this issue.
    
    Reviewed-on: http://gerrit.openafs.org/11316
    Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit e0d0e6ffdbb11d5445b129ef0bd5030aec59d333)
    
    Change-Id: Ia5d03e55f7bad9f5678cdb82808b56d975865438
    Reviewed-on: http://gerrit.openafs.org/11361
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 81f1814b566cb3b1cda97be4c48b9788cd7addd0
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Wed Jul 23 11:54:47 2014 -0500

    LINUX: Drop dentry if lookup returns new file
    
    Background: when an entry is looked up after its parent changes,
    afs_linux_dentry_revalidate re-looks-up the entry name in its parent.
    If we get an ENOENT back, we d_drop the dentry, and in any other
    situation we just d_invalidate it. As discussed in prior commits
    997f7fce437787a45ae0584beaae43affbd37cce and
    389473032cf0b200c2c39fd5ace108bdc05c9d97, we cannot simply d_drop the
    dentry in all cases, because that would cause legitimate directories
    to be reported as "deleted" if we just failed to lookup the entry due
    to e.g. transient network errors (this causes, among other things,
    'getcwd' to fail with ENOENT).
    
    However, this logic has problems if the dentry name still exists, but
    points to a different file; the case where 'tvc != vcp' in
    afs_linux_dentry_revalidate. If that case happens, and the dentry is
    still held open by some process, we will continue to try to reference
    the vcache pointed to by the 'old' dcache entry, which is incorrect.
    
    To maybe more clearly illustrate the issue, consider the following
    cases:
    
      $ sleep 9999 < /afs/localcell/testvol.ro/dir1/file1 &
      $ rm -rf /afs/localcell/testvol.rw/dir1
      $ mkdir /afs/localcell/testvol.rw/dir1
      $ vos release testvol
      $ ls -l /afs/localcell/testvol.ro
      ls: cannot access /afs/localcell/testvol.ro/dir1: No such file or directory
      total 0
      d????????? ? ? ? ?            ? dir1
    
    Here, on the last 'ls', afs_linux_dentry_revalidate will afs_lookup
    'dir1', and notice that it points to a different file (tvc != vcp),
    and will d_invalidate the dentry. But since the file is still held
    open, the dentry doesn't go away, and so we are still pointing to the
    vcache for the old, deleted 'dir1'. That file doesn't exist anymore on
    the fileserver, so we get an ENOENT when actually trying to stat() it
    (we get a VNOVNODE from the fileserver, whcih gets translated to an
    ENOENT).
    
    A possibly more serious case is when the file is just renamed:
    
      $ sleep 9999 < /afs/localcell/testvol.ro/dir1/file1 &
      $ mv /afs/localcell/testvol.rw/dir1 /afs/localcell/testvol.rw/dir1.moved
      $ mkdir /afs/localcell/testvol.rw/dir1
      $ touch /afs/localcell/testvol.rw/dir1/file2
      $ vos release testvol
      $ ls -l /afs/localcell/testvol.ro/dir1
      total 0
      -rw-rw-r--. 1 1235 adeason 0 Jul 23 11:09 file1
      $ kill %1
      $ ls -l /afs/localcell/testvol.ro/dir1
      total 0
      -rw-rw-r--. 1 1235 adeason 0 Jul 23 11:10 file2
    
    In this situation, the same code path applies, but the old file still
    exists, so we will continue to use it without error. But since we are
    still pointing at the old file, of course the results are incorrect.
    Once we kill the process holding the file open, the bad dentry finally
    goes away and the results are valid again.
    
    To fix this behavior, d_drop the dentry in all cases, except when we
    encounter an error preventing the lookup from being done. This ensures
    that the dentry is unhashed from the parent directory in the scenarios
    above, and so cannot be used for a subsequent lookup.
    
    With this change, the only afs_lookup response that causes a simple
    d_invalidate is when we encounter actual errors during the lookup
    (such as transient network failures). This is correct, since in those
    cases we don't _know_ that the dentry is wrong. For all other cases,
    we do know that the dentry is wrong and so we must force it to be
    unhashed.
    
    Reviewed-on: http://gerrit.openafs.org/11320
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit a5866b3a7c21551a8aa40fc6141cca3a65fea563)
    
    Change-Id: I5dbde974e9166d120a5040e81696adfebf94194d
    Reviewed-on: http://gerrit.openafs.org/11358
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit a4483520eab87001353c9c309c4e7d65ffe6cc9a
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Aug 1 18:27:35 2014 -0400

    libafs: fix error location code in LINUX/osi_export
    
    Fix the missing error location code introduced in commit
    40fb2650b783fbafe51aefd3d0af7a6b0536c265
    libafs: allocate vattrs in LINUX to reduce stack used
    
    Use location number 104, which is the next in the sequence.
    
    The code in this module is compiled when building the
    nfs translator, which is only built under linux when
    configure detects it is possible.
    
    Thanks to Andrew Deason for spotting this error.
    
    Reviewed-on: http://gerrit.openafs.org/11351
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 05dbea9fc4da02c6349d9e0b69656acb3254cfe8)
    
    Change-Id: I5bb69b68716f6a7147d24c0bd698c10488bca2d4
    Reviewed-on: http://gerrit.openafs.org/11366
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 0dc4722d7e86bf289f8e287a01532d90dda803a8
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sun May 18 19:28:16 2014 -0400

    libafs: allocate vattrs in LINUX to reduce stack used
    
    Allocate temporary vattrs in LINUX to reduce the amount
    of stack space used.
    
    Reviewed-on: http://gerrit.openafs.org/11170
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 40fb2650b783fbafe51aefd3d0af7a6b0536c265)
    
    Change-Id: I1f19c07a2ad0f8cdddd88e4528584caccaa403e0
    Reviewed-on: http://gerrit.openafs.org/11339
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit f1303a1f4fc710af286e12dae50ff44c93b7cb0b
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sun May 18 17:17:38 2014 -0400

    libafs: api to create and free vattrs
    
    Add a pair of functions to allocate and free struct vattrs,
    to avoid having struct vattrs on the stack.
    
    Reviewed-on: http://gerrit.openafs.org/11169
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 9630c075409a262424805411ed473178814b412c)
    
    Change-Id: I7746ee69f7fde8760c066458ecfe44da46edbf81
    Reviewed-on: http://gerrit.openafs.org/11338
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 38a4a13c32ce9373a7cbc23baa114b98e09bb42c
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon Jul 28 17:27:40 2014 -0400

    libafs: do not allow NULL creds for afs_CreateReq
    
    Do not allow callers to pass a NULL cred to afs_CreateReq.  This
    avoids setting the uid of zero in the vrequest when no cred is
    passed.  Update callers to pass afs_osi_credp for an anonymous cred
    when no cred is available.
    
    Thanks to Andrew Deason for pointing out afs_osi_credp should be
    used.
    
    Reviewed-on: http://gerrit.openafs.org/11336
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit b7f1763652fb932ca5bd3f3351a48df11e58f2dc)
    
    Change-Id: I0a7f17a05decdd0a9ef1ff72d7bf73153db95bed
    Reviewed-on: http://gerrit.openafs.org/11365
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 7426a78d1a43a33b743b4f5b47dd98f0c00b152c
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Wed Apr 9 08:40:21 2014 -0400

    libafs: reduce stack space in LINUX
    
    Allocate temporary vrequests to reduce the amount
    of stack space used.
    
    Reviewed-on: http://gerrit.openafs.org/11005
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 1ac4eb1b84db2732b9c2645492daff9e25417475)
    
    Change-Id: I5d982afce489fbcf82cbcb69bd2677fcb0236237
    Reviewed-on: http://gerrit.openafs.org/11167
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Gergely Madarasz <madaraszg@gmail.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit c87e0cd81cadd003ff84641b395092e0d28412f6
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon Jul 28 20:57:01 2014 -0400

    libafs: fix vrequest leak in afs_lookup
    
    Fix vrequest leak introduced in commit
    9930567bcf9655d3f562b210b2dc4b4a99226691.
    
    Thanks to Andrew Deason for finding this error.
    
    Reviewed-on: http://gerrit.openafs.org/11337
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 51c97beb3f3bb68704d33e126561b8c2866ddab3)
    
    Change-Id: If903c7863ac2ac6420a74e6bea1012c8cbf41913
    Reviewed-on: http://gerrit.openafs.org/11364
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 6041ddf65c5a11725b800372fb1fbec8ba079cd1
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Tue Oct 2 15:04:47 2012 -0500

    afs: Use common cleanup code for lockctl EINVAL
    
    afs_lockctl has common cleanup code in the 'done' label. Use it here,
    instead of trying to duplicate it.
    
    Currently this code path appears to not be dropping the discon lock,
    which this rectifies.
    
    Reviewed-on: http://gerrit.openafs.org/8196
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit eae608d99a5ae94624200f91af6ed818c9f6612b)
    
    This commit fixes a vrequest leak introduced by change
    I1c60701d4e4f85aedfea6be58a03468ab34edb96.  On master, the corresponding
    changes appear in the opposite order.
    
    Change-Id: I1f7a5794f19abb1495bbab6014c3ccde99cf0e1d
    Reviewed-on: http://gerrit.openafs.org/11381
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 9f692e653bdc8e93aa4b308e4c6e42d394b03fe4
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Tue Apr 8 16:10:36 2014 -0400

    libafs: reduce stack space in VNOPS
    
    Allocate temporary vrequests to reduce the amount
    of stack space used.
    
    Reviewed-on: http://gerrit.openafs.org/11004
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 9930567bcf9655d3f562b210b2dc4b4a99226691)
    
    Change-Id: I1c60701d4e4f85aedfea6be58a03468ab34edb96
    Reviewed-on: http://gerrit.openafs.org/11166
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 8b201a35c638f3abc2574539a2bd9a60e8d5af9f
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Mon Feb 21 14:56:48 2011 -0600

    budb: Fix objdir builds
    
    Reviewed-on: http://gerrit.openafs.org/4030
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    Tested-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 153cb5a3ca34c07a899841ae917b7b882e7ae433)
    
    Change-Id: I46475c58265df9ec2b43241eb244b7d1164ad182
    Reviewed-on: http://gerrit.openafs.org/11367
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 7c451fab11b65dd5e2860715b939e5de33c7645e
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat Oct 26 23:35:14 2013 -0400

    build: separate source and header compile_et rules
    
    Generate source and header files separately to support parallel make
    without contortions.
    
    Add a complete list of dependencies for each generated header file
    to avoid build errors during parallel make.
    
    Reviewed-on: http://gerrit.openafs.org/10370
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit c01236beb5a6ad55cd424f0ccc3a836d737f78f3)
    
    Change-Id: Ib0e3c3b8e0a268f7db741243ce78fed9f6c342c7
    Reviewed-on: http://gerrit.openafs.org/11242
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 73b6ed21c72d8ff218cee46d8e300f6c4b96fcd2
Author: Garrett Wollman <wollman@csail.mit.edu>
Date:   Sat Jul 26 00:43:10 2014 -0400

    FBSD: 10.1 is coming out soon
    
    The 10.1 release cycle is starting in a month, so let's get ahead of
    the curve by adding the config bits now.
    
    Reviewed-on: http://gerrit.openafs.org/11328
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 2809bae58851ce9168ca8b18c94360392b8a609f)
    
    Change-Id: I71779d247725c48ee362e4ff8e9356ce060863d4
    Reviewed-on: http://gerrit.openafs.org/11369
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 3d5eb8c4671f8c6ae86eaacc9e0fd753200feae2
Author: Garrett Wollman <wollman@csail.mit.edu>
Date:   Sat Jul 26 00:22:09 2014 -0400

    FBSD: 9.3 has been released, so add config bits and sysname
    
    Reviewed-on: http://gerrit.openafs.org/11327
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 6667399aa426009a841cdd6459dbfa498e562646)
    
    Change-Id: I5eaa9316806da60699cdb194058613ff7671cb8a
    Reviewed-on: http://gerrit.openafs.org/11368
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Garrett Wollman <wollman@csail.mit.edu>
    Tested-by: Garrett Wollman <wollman@csail.mit.edu>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 9b827a8bfac032fa284e7bb23cbed6cf00bc0d05
Author: D Brashear <shadow@your-file-system.com>
Date:   Wed Apr 16 10:35:57 2014 -0400

    auth: check for keytab before using in akimpersonate
    
    Heimdal 1.5.2 happily tries to dereference a keytab file even if
    none is there. if we have a FILE: type, stat it before use
    
    1.6 only change: master uses KeyFileExt
    
    FIXES 131852
    
    Change-Id: I939eb9e47d2dbbef75c2a64724fdb9111f600150
    Reviewed-on: http://gerrit.openafs.org/11075
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 6871d2375d4ad82372c609367b1454210841d405
Author: Chas Williams (CONTRACTOR) <chas@cmf.nrl.navy.mil>
Date:   Thu Jul 3 11:02:40 2014 -0400

    auth: Fix library dependencies so that tests build again
    
    Reviewed-on: http://gerrit.openafs.org/11311
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 668b1765478eb32b5d0895d25301773e412df7a0)
    
    Change-Id: I581a23201832bdfbe7d14eb15d09409936e91eb0
    Reviewed-on: http://gerrit.openafs.org/11350
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 3be9a451b523cd955cd5b3e68ee3a44ab083c14f
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sun Mar 2 14:54:00 2014 -0500

    rxkad: fix include quotes for generated headers
    
    Reviewed-on: http://gerrit.openafs.org/10871
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 0408718b8108882d5fb70612e7e7e5d3184fb65f)
    
    Change-Id: I880f6f6b872f913e42b370c51a0b0e92962de803
    Reviewed-on: http://gerrit.openafs.org/11241
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit ff0644c4cf5a54747bf3af2cc9605163e1debcb7
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sun Mar 2 12:26:24 2014 -0500

    auth: fix include quotes for generated headers
    
    Reviewed-on: http://gerrit.openafs.org/10870
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit d3eed1e58a7605b320ec38d48ff1c185aa2d9806)
    
    Change-Id: Iadabd45547b671e346eec262c50f2e6aef917258
    Reviewed-on: http://gerrit.openafs.org/11240
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 1c4dd27b89ad1e42234f0862abdd2e4ad35c2a3d
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sun Jan 19 17:04:08 2014 -0500

    libafs: separate source and header compile_et rules
    
    Use the new compile_et -emit flag to generate source and header
    files separately to support parallel make.
    
    Export afs_trace.h since it is required to build libafs.  Before the
    compile_et -emit flag was available, The afs_trace.h file was
    generated as a side-effect of creating afszcm.cat.
    
    Reviewed-on: http://gerrit.openafs.org/10729
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 4e6b7ab904d38d38da1b80a7342bd815668a8c09)
    
    Change-Id: Ic1474aff86e49d8df0ba151ed0e53932aa96d1ed
    Reviewed-on: http://gerrit.openafs.org/11239
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit fb3ab52be5eab9b14b50f13f9fd862340277c9bf
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Tue Jan 21 13:45:32 2014 -0500

    libadmin: separate source and header compile_et rules
    
    Use the new compile_et -emit option to generate source
    and header files separately for parallel make support.
    
    Remove unneed -h options, since there are no prolog
    files and the header names match the error table names.
    
    Reviewed-on: http://gerrit.openafs.org/10730
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit e97198372a8ddbdba4b5a58c0659f2aa5d2b2d56)
    
    Change-Id: Ic8da7c3dea7953cb7ad33120df06ec1f7399bf2d
    Reviewed-on: http://gerrit.openafs.org/11238
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 2a5cb18789c6f78d74b4ba45a267755ab9254424
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat Mar 1 14:52:48 2014 -0500

    compile_et macros to generate source and headers separately
    
    Common makefile macros to generate headers and source files
    separately using the new compile_et -emit option.
    
    Reviewed-on: http://gerrit.openafs.org/10869
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit be36376b244d1d94b24cb8fce44810fb31b7b5ce)
    
    Change-Id: Ic9cf078f6a013e7529ae8f11b0378173e64ee680
    Reviewed-on: http://gerrit.openafs.org/11237
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 1dd845f669402ec1661b1f9f4cbd27f3a33b699b
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat Jan 18 23:03:44 2014 -0500

    libadmin: add missing bubasics dependency
    
    bubasics is a dependency of libadmin. Add it to the top level
    makefile.
    
    This missing dependency was found by analyzing the libadmin header
    file includes.
    
    Reviewed-on: http://gerrit.openafs.org/10727
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit b8589f1b59e520aae8d412170b663ff3bc214667)
    
    Change-Id: Ie879c29a72bbf194bf48dea73380521dc89c4c38
    Reviewed-on: http://gerrit.openafs.org/11236
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit dd4abad371159712954c819b1032dffc03f6c276
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat Jan 18 22:40:12 2014 -0500

    libadmin: add header file deps
    
    Add the missing header file dependencies to the library targets.
    This is needed for parallel make.
    
    Reviewed-on: http://gerrit.openafs.org/10726
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit d2084563648cc1e8ec697c61f593935a0b5804a3)
    
    Change-Id: I47b3b184a3284b56c4047e27b58b6cb3a8e16cef
    Reviewed-on: http://gerrit.openafs.org/11235
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 82cf6654494b9b35ba4eac970e5f2bb466755f72
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat Jan 18 22:40:12 2014 -0500

    libadmin: rework compilation rules
    
    Change I47b3b184a3284b56c4047e27b58b6cb3a8e16cef will add
    dependencies on the header files to the library targets. Before
    this can be done, we have to avoid the use of $? in compilation
    rules because on AIX and OS X this causes the headers to be added
    to the compilation command, making builds fail.
    
    This is a 1.6-only change. The corresponding commit on the master
    branch, f22ae5f7d8b3c143de21355f819ab872a0cf76fd, is no candidate
    for a backport to 1.6.
    
    Change-Id: Iefb432555c60bcfdf51436ebe76a267969280fe0
    Reviewed-on: http://gerrit.openafs.org/11353
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e8f5739ec4f190e6044f5e72074a01cb941aac06
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Nov 22 13:36:54 2013 -0500

    libadmin: use INSTALL_DATA to export headers
    
    Use the INSTALL_DATA macro instead of cp to export
    header files.
    
    Reviewed-on: http://gerrit.openafs.org/10515
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 66093e4a2db297afea755d164cca7a6080909bda)
    
    Change-Id: Icc1fb62fd68903fcf5a1f756800b0281669f59fa
    Reviewed-on: http://gerrit.openafs.org/11234
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit a49323a5a630eacc64ca0918fb4ae05cce1fac8d
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat Jan 18 22:01:59 2014 -0500

    libadmin: makefile rule for afs_AdminError.h
    
    Add a makefile rule to export the libadmin afs_AdminErrors.h header
    file, instead of exporting afs_AdminErrors.h as a side effect of
    generating the afs_AdminBosErrors error table.
    
    Add the missing afs_AdminErrors.h dependency to the afs_utilAdmin.o
    dependency list.
    
    Reviewed-on: http://gerrit.openafs.org/10369
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 9b1ffeeeb62cd9535dc2fc1522400abb428a0ac2)
    
    Change-Id: Ib526d18227a6c37eac08def5ab88eb1717a848f1
    Reviewed-on: http://gerrit.openafs.org/11233
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit be7b6414644b2bb49598f60e822f4c73e5f0cd45
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat Jan 18 21:56:36 2014 -0500

    libadmin: remove duplicate dependency
    
    afs_AdminPtsErrors.h was listed twice in the dependency
    afs_utilAdmin.o dependency list.
    
    Reviewed-on: http://gerrit.openafs.org/10725
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 9b105c5586a2e9c5c55dce7785e681f73ea0a759)
    
    Change-Id: Ibf01dd6c67ecb6a89e30bd93eef82afae5eb84c4
    Reviewed-on: http://gerrit.openafs.org/11232
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 9e51525995ebedc000939a08bf993059618e2397
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sun Jan 19 14:15:13 2014 -0500

    tvolser: fix makefile clean target
    
    Remove generated source files with the clean makefile target.
    
    Reviewed-on: http://gerrit.openafs.org/10724
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit e39e226a13e38bfe0fb12b73633b6415c790c569)
    
    Change-Id: Ie1159d2bfb05e274623b0985660e05ed9ce78ccc
    Reviewed-on: http://gerrit.openafs.org/11231
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit b1f177a920d7f700c34bb14b5038e052803c35b7
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sun Jan 19 14:02:28 2014 -0500

    config: use the standard INSTALL_DATA makefile macro
    
    Replace the custom INST makefile macro with the standard
    INSTALL_DATA macro for installing and exporting files.
    
    Reviewed-on: http://gerrit.openafs.org/10723
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 31d6467aa058a2b49c22188dfb0ca70b766d127f)
    
    Change-Id: I7b7cc1d74c84090c9042b624af1c4e4b5c61ac6d
    Reviewed-on: http://gerrit.openafs.org/11230
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 0f33b205b5f7c9ac8fa66511ef6be329b477532b
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Nov 22 12:23:17 2013 -0500

    config: parallel-safe param.h makefile rule
    
    Generate the param.h.new temporary file in a parallel-safe
    way.  The rule to generate the three copies of param.h can
    run at the the same time under a parallel make, clobbering
    the param.h.new temporary file. Instead of creating this file
    inline, create a common rule to generate the temporary file
    once.
    
    Reviewed-on: http://gerrit.openafs.org/10516
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit c8e83f0e826bc0a56321408b1c7a2afa137bab05)
    
    Change-Id: I8a85c0e288f2231a3bf693319a8f5fcd618464e8
    Reviewed-on: http://gerrit.openafs.org/11229
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit cf4e99a3a4f1062a4bc281bf1c576652efa2fc14
Author: Benjamin Kaduk <kaduk@mit.edu>
Date:   Wed May 21 15:58:17 2014 -0400

    Install afscp.h from srcdir, not the build dir
    
    That header is not a generated file, and is not found in the
    object directory.  make install would fail from a separate objdir
    prior to this change.
    
    Reviewed-on: http://gerrit.openafs.org/11160
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 7a701239d8327ae738124edb5e11f3bcbb08a76b)
    
    Change-Id: I738adc464aa36b68403b69912253faf17cb01621
    Reviewed-on: http://gerrit.openafs.org/11342
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e7e2cff64201ece5493c8fbe421604f620daebee
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Nov 22 11:50:11 2013 -0500

    libafscp: makefile install rule update
    
    Change the makefile install rules to install the header
    file from the libafscp directory, and not the top level
    include directory to make the install rules consistent
    with the rest of the tree.
    
    Reviewed-on: http://gerrit.openafs.org/10514
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 52fe3f52de95b698c93ca5da3c1ed59447817610)
    
    Change-Id: I1ed7e92b8e27f3df8fc76ccaa6bac4199e40c180
    Reviewed-on: http://gerrit.openafs.org/11228
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 45190b44dbc6573e6175b6da682c4a528846d1a0
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Wed Aug 1 17:26:33 2012 -0400

    comerr: compile_et -emit option for parallel make
    
    Add the -emit option to the compile_et command to support parallel make.
    
    The -emit option allows make to generate the header and the source files
    independently, instead of building two files at the some time.  This
    avoids the issue where one command creates two separate files, which is
    difficult to handle correctly for parallel makes.
    
    Reviewed-on: http://gerrit.openafs.org/7921
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 9df43aacab0f311c15837b230761a11750f8b9cb)
    
    Change-Id: Id560fcec356a4b36c0e311440f74a97a670c07d1
    Reviewed-on: http://gerrit.openafs.org/11227
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 94f1d49af07a2f20b43bdc4e172e1b0aabc1b263
Author: Marc Dionne <marc.dionne@your-file-system.com>
Date:   Tue Apr 29 12:48:03 2014 -0400

    libafs: Speed up afs_CheckTokenCache
    
    On systems with a large number of PAGs and files in use, the
    periodic daemon job that checks for expired credentials and
    cleans up the axs cache can run for a very long time.  This
    can lead to kernel soft lockups and eventually hang processes
    and file access because of unavailable locks.
    
    Rework the scanning logic in afs_CheckTokenCache to make the
    scanning more efficient in most real world cases.  On a test
    system accessing ~4000 files from processes in 1000 PAGs, this
    has been observed to reduce the runtime of afs_CheckTokenCache
    from a problematic ~70s down to about 0.7s.
    
    Additionally, this changes the conditions in which an axscache is
    discarded. uid+cell (rather than just uid) must now match, and
    if no matching unixuser is found, it will also be discarded.
    
    Adapted from code from Jeffrey Altman who provided the original
    loop algorithm and code.
    
    Reviewed-on: http://gerrit.openafs.org/11123
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit de74227d9c925206cd6d46496ec4682569d3105b)
    
    Change-Id: I72e501cf1cb3e312d17a518666d2d638f1d52ead
    Reviewed-on: http://gerrit.openafs.org/11307
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit c1223f111908341b8be472fe3416fedea920613a
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Wed Jul 30 11:12:39 2014 -0500

    ptserver: Fix RemoveFromSGEntry hentry memcpy
    
    In this function, hentry is the "previous" continuation entry that we
    looked at, and centry is the "current" continuation entry. We keep
    track of the previous continuation entry in case we need to update its
    'next' pointer, which we do if we free one of the continuation entries
    because it is empty after the removal.
    
    So, this memcpy is supposed to copy the current entry to the previous
    one, but the arguments are flipped, so we just copy zeroes to centry
    (since hentry is initialized to zeroes early on in the function), and
    hentry never gets set to anything besides zeroes.
    
    The effect of this is that whenever a ptdb entry has more than one
    continuation entry, and we free up any of them after the first one via
    RemoveFromSGEntry, the previous continuation entry becomes blanked
    (though the 'next' pointer should still be correct). This means the
    membership information for that group is not recorded correctly, as it
    loses a chunk of the IDs that it is a member of. The reverse mapping
    should still be intact (the parent groups have a pointer to the
    sub-group), but the group probably doesn't function correctly.
    
    The reason this happened is because of the confusing conversion from
    bcopy to memcpy. Most of the instances of bcopy/bcmp/bzero/etc were
    converted (correctly) back in commit c5c521af, but the supergroups
    implementation was added afterwards, in 8ab7a909, and contained a
    bcopy reference. This bcopy was converted to memcpy in 58d5f38b, but
    the argument order was not corrected, causing this bug.
    
    To fix this, just flip the first two arguments of the memcpy. Just get
    rid of the casts here, too, to match the code in the non-supergroups
    RemoveFromEntry and elsewhere.
    
    Reviewed-on: http://gerrit.openafs.org/11340
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 2d89d447c8b00a40d3fc559813fe31c177da164b)
    
    Change-Id: I78b80cb7b043c9d1562b543906a593a985020b43
    Reviewed-on: http://gerrit.openafs.org/11352
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit fcbcce664025b87d81ae2b0ad8957193a3b34a38
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Mon Jul 14 10:26:02 2014 +0200

    cmd: List version in help for commands
    
    List version in help for commands using cmd library
    
    Reviewed-on: http://gerrit.openafs.org/10956
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 4b4d44b3dd62c2a36908f20eeff345b666e7858d)
    
    Change-Id: I1c4881de710f5c48af5645bce64fbee4fb4854f2
    Reviewed-on: http://gerrit.openafs.org/11214
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit fb32fcf4f711c525b0c1504b2ca831362b75f131
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Mar 28 00:36:29 2014 +0100

    libafs: reduce stack space
    
    Allocate temporary vrequests to reduce the amount
    of stack space used.
    
    Reviewed-on: http://gerrit.openafs.org/11003
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 027e2bbb1191c31dbbe968a925c192b064d52c47)
    
    Change-Id: I2dc6d49c7d3b7578359930f7fd922f177729281f
    Reviewed-on: http://gerrit.openafs.org/11165
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Gergely Madarasz <madaraszg@gmail.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 17bf59ae6e426a7fd86f7edda040edb352729d2e
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon Apr 14 16:07:53 2014 -0400

    libafs: api to create and free vrequests
    
    Add a pair of functions to allocate and free struct vrequests, which
    are to be used to avoid having struct vrequests on the stack.
    
    Reviewed-on: http://gerrit.openafs.org/11074
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 76ad941902c650a4a716168d3cbe68f62aef109f)
    
    Change-Id: I08932256af58aeba31b2d5c11008658c419cf008
    Reviewed-on: http://gerrit.openafs.org/11164
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Gergely Madarasz <madaraszg@gmail.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit d40c92509f5d91bf996039dcc5a8770141b719aa
Author: Benjamin Kaduk <kaduk@mit.edu>
Date:   Wed May 28 10:41:02 2014 -0400

    Use a separate toplevel target for venus/tests
    
    There's no particular reason to lump them in with the venus target,
    and we have reports that it causes parallel build failures on some
    systems.
    
    Just use a separate 'venustests' target akin to rxtests and ubiktests
    and the like, instead.
    
    Some of these lines are now long and should be wrapped, but leave
    that for a follow-up commit.
    
    Reviewed-on: http://gerrit.openafs.org/11177
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit f66c467bdd7182eb80ede3b9faa5f5ae5231632f)
    
    Change-Id: Ic0c1ae4d6adb265417ba726967ff02fed476da7e
    Reviewed-on: http://gerrit.openafs.org/11282
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit c2af2b7b9597b5f5ab779a092b5bf9a2d35ea746
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Apr 13 11:58:02 2012 -0400

    Build: check for gencat
    
    Check for the gencat program and give a missing warning if
    not present.
    
    Reviewed-on: http://gerrit.openafs.org/7203
    Reviewed-by: Simon Wilkinson <simonxwilkinson@gmail.com>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit dcefc4576020c2c076af1a4af07cc827bf4eea40)
    
    Change-Id: I383af43e6bb26de0095629e99d41e0e0b6bcb685
    Reviewed-on: http://gerrit.openafs.org/11158
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit cf5e18b6a5231face090d1e186946aaa18dc112a
Author: Perry Ruiter <pruiter@sinenomine.net>
Date:   Mon Mar 31 04:42:22 2014 -0700

    afs: Suppress duplicate message on Linux
    
    Update afs_util.c to call afs_warnall in places where afs_warn and
    afs_warnuser are called back to back with identical parameters.
    
    Reviewed-on: http://gerrit.openafs.org/11006
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 0287086fa78f0bc0012325c2eadb3dccb6b1f766)
    
    Change-Id: I91d13654fbedffac4b2ad7ef54a90ade245de726
    Reviewed-on: http://gerrit.openafs.org/11183
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 17d0e8c012bd2d4ad9a0004b04943525b38c6b0f
Author: Perry Ruiter <pruiter@sinenomine.net>
Date:   Sat Mar 22 00:52:32 2014 -0700

    afs: Define afs_warnall routine
    
    In a Linux environment afs_warn and afs_warnuser both go to
    the same spot, resulting in duplicated messages if both are
    invoked back to back.  Define a new function afs_warnall
    for use when identical messages are directed to both warn
    and warnuser.  In a Linux environment it will do the right
    thing and present only one copy of the message.
    
    Reviewed-on: http://gerrit.openafs.org/10943
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit a70f8e1a7e3fcbc13c9a60f8a7409dd01d014afb)
    
    Change-Id: I264633cd4a30cfb7f7264e56512f318cfb23ef3e
    Reviewed-on: http://gerrit.openafs.org/11182
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 6f9038dcbe01370e275cc2391397841e93d86eb2
Author: Perry Ruiter <pruiter@sinenomine.net>
Date:   Fri Mar 21 23:31:21 2014 -0700

    afs: restructure afs_warn and afs_warnuser
    
    Restructure afs_warn.c to provide an afs_vwarn and afs_vwarnuser
    that accepts a va_list rather than a variadic parameter
    specification.  afs_warn and afs_warnuser continue to be
    variadic functions but now call afs_vwarn and afs_vwarnuser.
    This is a preparatory change.  A subsequent update will
    further exploit afs_vwarn and afs_vwarnuser.
    
    Reviewed-on: http://gerrit.openafs.org/10942
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit c3d4c109305b2db8a63b754c1894ad37326dc340)
    
    Change-Id: Ica9c3c8a0ae2c5b680b2e11bc85c747cfd11d30a
    Reviewed-on: http://gerrit.openafs.org/11181
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit f3c0f74186f4a323ffc5f125d961fe384d396cac
Author: Marc Dionne <marc.dionne@your-file-system.com>
Date:   Wed Jun 18 09:06:39 2014 -0400

    Linux 3.16: Convert to new write_iter/read_iter ops
    
    Change read/write operations to the new write_iter/read_iter
    operations.
    
    Reviewed-on: http://gerrit.openafs.org/11303
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit a303bb257ed9e790d8c14644779e9508167887b6)
    
    Change-Id: I3f66104be067698a4724ed78537765cf26d4aa10
    Reviewed-on: http://gerrit.openafs.org/11309
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit ae86b07f827d6f3e2032a412f5f6cb3951a27d2d
Author: Marc Dionne <marc.dionne@your-file-system.com>
Date:   Wed Jun 18 08:53:48 2014 -0400

    Linux 3.16: Switch to iter_file_splice_write
    
    Users of generic_file_splice_write need to switch to
    using iter_file_splice_write.
    
    Reviewed-on: http://gerrit.openafs.org/11302
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit e284db57f94c8f97ed1c95dcd0bd9518d86c050c)
    
    Change-Id: I6f88ec0388fe43accc150c7243c1a474c9e643af
    Reviewed-on: http://gerrit.openafs.org/11308
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>

commit 251de92a72c4c5a95aa58e5cb1cd3d6b0b3b6833
Author: Chas Williams (CONTRACTOR) <chas@cmf.nrl.navy.mil>
Date:   Fri May 23 07:48:11 2014 -0400

    afs/VNOPS: use osi_AllocSmallSpace() correctly
    
    Send the size down to the allocator so it can perform some
    consistency checks.
    
    Reviewed-on: http://gerrit.openafs.org/11168
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 2d973c10f13b40c0ac9da25fe7f4c73b3560a686)
    
    Change-Id: I38d16bdd014010a2ccc9636b890c9ea7a6158e6a
    Reviewed-on: http://gerrit.openafs.org/11203
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit f48e111f6802c8b9f220ee9c53fea281731171a8
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Wed May 25 21:54:06 2011 -0400

    volinfo: refactor size counters
    
    Put the volume, partition, and server size counters into structures.
    
    Reviewed-on: http://gerrit.openafs.org/4733
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 4e97b2e5f820e07ffbaf8407cca18c536d9d0f67)
    
    Change-Id: I1d6f5d31d359a6e89dad34c7319b6bbd4d121ed6
    Reviewed-on: http://gerrit.openafs.org/11251
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit dbefc9c2b070e5d39e19967ed3eb15adc82d66f0
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Wed May 25 18:19:22 2011 -0400

    volinfo: refactor -sizeOnly printing
    
    Refactor the -sizeOnly output processing to reduce code
    duplication and coupling with -saveinodes.
    
    Reviewed-on: http://gerrit.openafs.org/4732
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    
    (cherry picked from commit 70145b4f4affc6aabf83fc1cc34cb4de0702c83f)
    
    Change-Id: I8ca8979854959dc62ac5ff5147d2087e00e1f198
    Reviewed-on: http://gerrit.openafs.org/11250
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 8d29caec8b60295e2c0d32e1a101e672fc9acf6a
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat May 21 20:56:23 2011 -0400

    volinfo: print namei filenames of index files
    
    On namei fileservers, also print the namei filenames of the volume special
    files when the -header flag is given.
    
    Reviewed-on: http://gerrit.openafs.org/4696
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit 4999ed13d2355743e07587c8d7c4d23cbc073c5f)
    
    Change-Id: I09c93c6b7512250f47359e70c5a744182ea91d9f
    Reviewed-on: http://gerrit.openafs.org/11249
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 7953ca06b21abf880c99e8dc6f3312dd784b36fe
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat May 21 12:06:43 2011 -0400

    volinfo: remove code duplication in HandleVolumes
    
    Reduce duplicate code for processing volume header files when printing header
    details (-header) and calculating the volume size (-sizeOnly).
    
    Reviewed-on: http://gerrit.openafs.org/4695
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    
    (cherry picked from commit ae27283550dab33704f30e18975722e0ed2c5424)
    
    Change-Id: I83e5797acf09597d7c4da8c90e49049cec1294db
    Reviewed-on: http://gerrit.openafs.org/11248
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit c35419e495575840e5cac8ee6f5e2e5ee430f85f
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat May 21 12:38:03 2011 -0400

    volinfo: fix volume aux totals output
    
    Do not print the volumes aux totals prematurely when running
    volinfo with the -headers flag on an namei fileserver. Instead
    print the aux totals only once after the link table size is found.
    
    Reviewed-on: http://gerrit.openafs.org/4694
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    (cherry picked from commit c833ff6c5b7f9c27cf26eae4833b033bd7382c56)
    
    Change-Id: I6e059a070785fb44821827a75397d04c8669418d
    Reviewed-on: http://gerrit.openafs.org/11247
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 96f3e86ab6f419a46fb8b2507b447b850212e212
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Sat May 21 07:28:41 2011 -0400

    volinfo: print errors to stderr
    
    Print volinfo errors messages to stderr instead of a mix of stdout
    and stderr. Print a consistent program name.
    
    Reviewed-on: http://gerrit.openafs.org/4693
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementia.org>
    
    (cherry picked from commit b7fe087745923bdea4571870799e484da67221d2)
    
    Change-Id: Id9b6eb5c0cb50bc3908d6e1662f4485219452ecc
    Reviewed-on: http://gerrit.openafs.org/11246
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 23cb83b45f70186fa97b9e7d2a1a8b44272579d8
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Thu Apr 24 15:27:38 2014 -0400

    libafs: check afs_InitReq return code
    
    Do not ignore the return code from afs_InitReq everywhere it is
    called. If afs_InitReq fails, the vrequest could not be initialized
    for some reason.
    
    Reviewed-on: http://gerrit.openafs.org/11097
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit cdbf49f06baf33abd803b5d1ec245e58a94eec52)
    
    Change-Id: Ia8c0368f50f77b148a1e3f41b0538b0ec7c4123d
    Reviewed-on: http://gerrit.openafs.org/11163
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Gergely Madarasz <madaraszg@gmail.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 3b554f62f138997a5b75834e9bf3bc427c7438c3
Author: Chas Williams (CONTRACTOR) <chas@cmf.nrl.navy.mil>
Date:   Fri Mar 28 16:46:32 2014 -0400

    afs/VNOPS: reduce stack usage
    
    AFSFetchStatus is rather large and is in the stack twice.  Allocating with
    osi_AllocSmallSpace will save about 160 bytes of stack.
    
    Reviewed-on: http://gerrit.openafs.org/10964
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 972585c24b5c193a982570ff9264a1971760f48f)
    
    Change-Id: I5ee4441cd1c09646051e148a67147a2663768d44
    Reviewed-on: http://gerrit.openafs.org/11162
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 6c9fe7f80e4b5d9fb21609ee6743470d39dfb8f5
Author: Chas Williams (CONTRACTOR) <chas@cmf.nrl.navy.mil>
Date:   Fri Mar 21 16:33:36 2014 -0400

    vlserver: Add auditing to some more RPC's
    
    A future commit will conditionally restrict access to these RPC's.
    Auditing will allow debugging and monitoring of this feature.
    
    Reviewed-on: http://gerrit.openafs.org/10939
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 900427ecac4bde5ef78ae9fc86f9237552cc1dd4)
    
    Change-Id: Id140855220522ebfe560e1023f3b68acb67e82e9
    Reviewed-on: http://gerrit.openafs.org/10946
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 619448f16c91b496e7dc2cc9b24dfbff38fabd73
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon Jan 20 14:37:52 2014 -0500

    doc: afs_compile_et -h option
    
    Document the afs_compile_et -h option.
    
    Reviewed-on: http://gerrit.openafs.org/10722
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 501d6d288fcaa195c3cda0be0e3423c7959c9958)
    
    Change-Id: I5085f35d1b75a6dbae2768c2ba1ea61bb9c4201c
    Reviewed-on: http://gerrit.openafs.org/11226
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 6b0c80f5577e1097a04c501c1fa8dfaa3939f3ef
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Tue Jan 21 09:26:11 2014 -0500

    comerr: long and short form of the -prefix option.
    
    The man page documented the prefix option as -prefix; compile_et
    supported only the short form -p.
    
    Document and support both the long and short forms for the prefix
    option; -p and -prefix.
    
    Reviewed-on: http://gerrit.openafs.org/10721
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 37937a3e924eee7a09c7719ca6355703e65092e1)
    
    Change-Id: I65b8d54bde89be85bd535d3a85fd2b22408bba39
    Reviewed-on: http://gerrit.openafs.org/11225
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 526f285306d8a676fe05b9ccd6dff6b4d3500b9c
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Nov 22 15:26:34 2013 -0500

    comerr: avoid comma operator
    
    Avoid unnecessary use of the comma operator in compile_et's
    command-line argument processing.
    
    Reviewed-on: http://gerrit.openafs.org/10491
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
    Tested-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 15c80b1a92516a41d4aed8403db1485e97a7eff6)
    
    Change-Id: I28f7503877d670406c973520a33924480bb96ad9
    Reviewed-on: http://gerrit.openafs.org/11224
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit ad28b296c242e321eb768235407e5b9892ed01fe
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Tue Jan 21 09:39:56 2014 -0500

    doc: afs_compile_et -lang short form
    
    Document the -lang short form for -language.
    
    Reviewed-on: http://gerrit.openafs.org/10720
    Reviewed-by: Ken Dreyer <ktdreyer@ktdreyer.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 355ca7b20b8bb9f06b030be966311d4afb40ed00)
    
    Change-Id: I26c56ac064968d65f06de9f34c50bc71d2208560
    Reviewed-on: http://gerrit.openafs.org/11223
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit b0cfa5af5fa564f51a6da8ed0ab96293c856e5dc
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Tue Jan 21 09:36:37 2014 -0500

    doc: afs_compile_et formatting fixes
    
    Fix two pod formatting errors and remove one trailing
    whitespace characters.
    
    Reviewed-on: http://gerrit.openafs.org/10719
    Reviewed-by: Ken Dreyer <ktdreyer@ktdreyer.com>
    Tested-by: Ken Dreyer <ktdreyer@ktdreyer.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit de8ff76f8767246431115bf04a1475a0cf3ad28a)
    
    Change-Id: Ie2da8d8bf55a6ef9a067be06eb6626fc3dfd57fc
    Reviewed-on: http://gerrit.openafs.org/11222
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit f45ab4ffb526e8493d7bd3c27a1850ed535dac82
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Oct 25 13:47:59 2013 -0400

    ubik: fix include quotes
    
    Include the generated header in the current directory.
    
    Reviewed-on: http://gerrit.openafs.org/10361
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit aa440ec7cbb8732ad0d9e1e1401fe4929c2cfd50)
    
    Change-Id: I985dadc0db2ecd76c6a8640bd838511cf2abd80b
    Reviewed-on: http://gerrit.openafs.org/11221
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 562a1ba1267b0cdd2a8d4a2b2bdaabd04e993ca5
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Sep 23 11:28:05 2011 -0400

    bozo: remove duplicate prototype
    
    Remove duplicate function prototype.
    
    Reviewed-on: http://gerrit.openafs.org/5496
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit fab921de67fe2bfbf6967c2e1cbf27230aad8bb2)
    
    Change-Id: I6074ff7d8cdb6b3360ad4064b524d22ab6afe61c
    Reviewed-on: http://gerrit.openafs.org/11220
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit f77bf62c4b315d73176bd61fbb9248e613881c7e
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri May 9 11:43:35 2014 -0400

    aklog: double get_credv5 in retry logic
    
    Fix a bug where get_credv5() is called twice, even if the first one
    succeeded, in the aklog retry logic.
    
    (This bug uncovers another bug where get_credv5_akimpersonate
    crashes in the krb5 libs when get_credv5 is called back to back.)
    
    Reviewed-on: http://gerrit.openafs.org/11133
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit b9979e1a23ce28b20fe95d5e6042b9b15506c993)
    
    Change-Id: I53b274f5e417ebd2a88b18df15ceb0e1ea39624d
    Reviewed-on: http://gerrit.openafs.org/11218
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit c9d4ab575e5596560fae656d76fcc101e2b7c118
Author: Chas Williams (CONTRACTOR) <chas@cmf.nrl.navy.mil>
Date:   Thu Apr 3 14:12:38 2014 -0400

    rx: Remove rx_waitingForPacket
    
    Commit f43c2f4412d670ce1131dc429cb43302352df3e4 introduced
    rx_waitingForPacket.  Given its current usage, I can't see any
    functionality.
    
    It looks like this might have been the result of merging a renamed
    rx_waitForPacket from another development branch?
    
    Reviewed-on: http://gerrit.openafs.org/10981
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit be236140f72fc51e111898abc896f93cc505fac7)
    
    Change-Id: Ib1be9031bc217183f1997b6d79455e1693fa7c21
    Reviewed-on: http://gerrit.openafs.org/11219
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 60e878e80aaa0f217b538261380f95ecceba7ed9
Author: Perry Ruiter <pruiter@sinenomine.net>
Date:   Tue May 27 01:26:59 2014 -0700

    config: Move AFS_LRALLOCSIZ to afs_args.h
    
    AFS_LRALLOCSIZ is currently defined in afs/afs.h.  Other memory
    related definitions such as AFS_SMALLOCSIZ and AFS_MDALLOCSIZ
    are defined in config/afs_args.h.  Move AFS_LRALLOCSIZ to
    config/afs_args.h for consistency.
    
    Reviewed-on: http://gerrit.openafs.org/11174
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 02565591855f5a5ddb7dd6e308d9f535c2fd64b8)
    
    Change-Id: I691a7d6025a1b4353f479049d09c54297b80989c
    Reviewed-on: http://gerrit.openafs.org/11209
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit aa734b700c8f6d6d84f35318ab8f669bb17853c0
Author: Perry Ruiter <pruiter@sinenomine.net>
Date:   Tue May 27 01:16:26 2014 -0700

    Delete several unused memory management constants
    
    Change 412854593cf368006c18e6c0dc607a9ecd76a0e0, removed from
    the code base the last usage of:
    AFS_SALLOC_LOW_WATER (defined in afs/afs.h)
    AFS_MALLOC_LOW_WATER (defined in config/afs_args.h)
    AFS_MDALLOCSIZ (defined in config/afs_args.h)
    This patch deletes these constants.
    
    Reviewed-on: http://gerrit.openafs.org/11173
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 85f3d0941b37c71047f59e1b1f4f92557d232fb8)
    
    Change-Id: Ie9178db145bde21021251a17adb4bbb1bd77f14d
    Reviewed-on: http://gerrit.openafs.org/11208
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 1423a3debec3ec5a67c0ef1c613c02a266529e45
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon Jun 2 23:24:45 2014 -0400

    linux: dont ignore kmod build errors
    
    Errors from the linux kmod build are not propagated, since make is
    run as the first command in a pipeline, and the shell returns the
    exit code of the last command in the pipeline.  Run the make command
    in a subshell to detect errors, and exit afterwards.  (This method
    is more portable than bash specific pipeline processing options.)
    
    Thanks to Mark Vitale for pointing out this build system defect
    to me.
    
    Reviewed-on: http://gerrit.openafs.org/11186
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Tested-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 48789d47b613e40734e7b0caac58572a80f8b318)
    
    Change-Id: Idbdfad2a50901041aedaed35b8f01d713a66620d
    Reviewed-on: http://gerrit.openafs.org/11205
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Anders Kaseorg <andersk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 9c7f4490af8582c943f115474df645e825ad4cff
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Fri May 30 15:05:28 2014 +0200

    libadmin: Remove redundant memset call
    
    Commit bf78bf2c115659b78c34d3bc9d1934bcff21c8cc added initialisation
    of the nbulkentries structure to 0, to avoid freeing garbage due to a
    goto fail_... before the structure is initialised. As pointed out by
    Andrew Deason, there already is an equivalent memset call later in the
    code which is now redundant. Remove it.
    
    Reviewed-on: http://gerrit.openafs.org/11180
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit f05abc47938beddb436fd0b9677f7b59fc64a215)
    
    Change-Id: I7338e42a45d0871af2ad404191ab622605172ac3
    Reviewed-on: http://gerrit.openafs.org/11195
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 627dc517250de390316c2b8523318be755bd898c
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon Jan 13 15:28:17 2014 -0500

    xstat: use ephemeral ports for xstat_fs_test and scout
    
    Instead of trying to bind to port 7101, and then retrying if
    the port is in already in use, let the os find an available
    port for scout and xstat_fs_test.
    
    This fixes a bug where scout and xstat_fs_test do not call
    rx_Finalize() before retrying rx_Init() with a different port
    number, causing the program to crash later when more than
    one copy of xstat_fs_test and/or scout are running at the same
    time.
    
    Reviewed-on: http://gerrit.openafs.org/10707
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit cda5e665ebee3da5615dba71b7a11ffff1229c6d)
    
    Change-Id: I00c2d9e7d48e80dc1bc062a85788ad2de65709c7
    Reviewed-on: http://gerrit.openafs.org/11155
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 40dc074227de0985940fd97de81d36372c1ca349
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon Jan 13 15:38:44 2014 -0500

    xstat: fix a malformed debug message
    
    a munged format specifier obscured the missing rn arg.
    
    Reviewed-on: http://gerrit.openafs.org/10708
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit ba0208f1d69c8c403150fb6312214f9b1c972c6d)
    
    Change-Id: Ie422f4a7be98052fec9281be73eac1823e9ea57f
    Reviewed-on: http://gerrit.openafs.org/11154
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 1174e0a6adcc4cfe7719e7090d75b4eda855998d
Author: Anders Kaseorg <andersk@mit.edu>
Date:   Sun May 4 05:30:25 2014 -0400

    Fix buffer length validation in ktc_GetToken and knfs
    
    The signed int tktLen is checked against a maximum size, then passed
    as the unsigned size_t argument to memcpy.  So we need to make sure it
    isn’t negative.
    
    This doesn’t appear to be exploitable: tktLen comes from the kernel,
    which should have previously validated the length within the SETTOK
    pioctl.
    
    This bug was found with STACK <http://css.csail.mit.edu/stack/>.
    
    Signed-off-by: Anders Kaseorg <andersk@mit.edu>
    Reviewed-on: http://gerrit.openafs.org/11109
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 9c10c202f1f2e516dde8b70c3a3b69a73d163070)
    
    Change-Id: Id8dacdc00fd686d4f2ff234ffd6c8f5346d9e7b0
    Reviewed-on: http://gerrit.openafs.org/11112
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Anders Kaseorg <andersk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit f99226a2ec12997060202e8badd3a67e66cd871b
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Wed Jun 4 09:42:46 2014 -0500

    bozo: Ignore ListKeys ka_KeyCheckSum return value
    
    With commit c04de52da4e89e15b211b4a19a3d9bc4d612b209, an error in
    ka_KeyCheckSum here makes the entire BOZO_ListKeys RPC to fail. This
    caused two changes:
    
     - That commit makes the RPC fail in situations where it did not
       before. But even if we cannot calculate the checksum, we can still
       return other information about the key, so this is undesirable.
    
     - It masks the previous 'code' value, returned from stat(). The
       return code of stat() is now effectively ignored, except for the
       purposes of setting st_mtime, whereas previously a failure caused
       the RPC to fail. This is a behavior change.
    
    So, effectively revert c04de52da4e89e15b211b4a19a3d9bc4d612b209.
    Explicitly cast the return value of ka_KeyCheckSum to void, to make it
    clear that we are intentionally ignoring the return value, so
    hopefully this will not be flagged as a warning by code analysis tools
    such as coverity.
    
    Reviewed-on: http://gerrit.openafs.org/11194
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 1673764ea091a3f02a64a3d853c3e14f758cdda7)
    
    Change-Id: Ibb05f0afc68db5fa66e1dc55f7dae190d8057232
    Reviewed-on: http://gerrit.openafs.org/11206
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 955c4999b5ac73dcc0a38b315f1dea7667579fd6
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 12:10:17 2013 +0000

    bosserver: Return error if key is bad
    
    If a key is bad, have SBOZO_ListKeys return an error, rather than
    silently ignoring the result from ka_KeyCheckSum.
    
    Caught by coverity (#988413)
    
    Reviewed-on: http://gerrit.openafs.org/9270
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit c04de52da4e89e15b211b4a19a3d9bc4d612b209)
    
    Change-Id: I7474da0967d759fc4359140c9057ac997935dc76
    Reviewed-on: http://gerrit.openafs.org/11014
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 04ef24659a428af037dfb3a3d368142cd3ffd8c3
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Mon Jun 2 16:15:15 2014 +0200

    fstrace: Don't read uninitialised data on other platforms either
    
    Commit 908105fe8d51551e45692de4e145022138a0356c fixed an off-by-one
    error potentially causing a buffer overread in CheckTypes, but only
    in the IRIX/AIX version of the function. Apply the same fix to the
    code for the other platforms.
    
    Spotted by Andrew Deason.
    
    Reviewed-on: http://gerrit.openafs.org/11185
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 3ab546395536a3c93613dfd53363d380e2c05081)
    
    Change-Id: Iea700be24803d8156f07d1cf0617ba7aa2aa03d5
    Reviewed-on: http://gerrit.openafs.org/11196
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 05d1bf1f462fc956ecdc5087c6e9f5241b1430da
Author: Perry Ruiter <pruiter@sinenomine.net>
Date:   Thu May 29 19:24:24 2014 -0700

    afs: Delete unneeded duplicate code
    
    Delete a memory release and a goto since natural code flow will
    result in exactly the same thing.
    
    Reviewed-on: http://gerrit.openafs.org/11179
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 69705782318226806b6a2b092ec4b63d594d184c)
    
    Change-Id: I44ea83c6b7da68fe0c5c8959d2c8eafb6e942d4b
    Reviewed-on: http://gerrit.openafs.org/11207
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 11cab56df59e028a294c2799e83a40ba14288090
Author: Marc Dionne <marc.dionne@your-file-system.com>
Date:   Wed May 28 09:53:58 2014 -0400

    vol: Fix gcc 4.9 warnings
    
    gcc 4.9 complains here because the trailing 0 in these macros
    has no effect, the value having already been set to NULL.
    Just remove the offending 0s, nothing uses the return value
    anyway, even if there were platforms where 0 != NULL.
    
    Reviewed-on: http://gerrit.openafs.org/11176
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit c0683441a0121433d772bfb36e1e9a1c020a5dcb)
    
    Change-Id: Ia63f56d3254b87e7d56752ec11729d82e0293792
    Reviewed-on: http://gerrit.openafs.org/11204
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 47c5ef52c6cabd9a18273cf779a3972c90da4144
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Thu Jun 28 17:24:49 2012 -0400

    vldb_check: remove unused functions
    
    Remove the readSIT function, which has been unused
    since the IBM days.  Remove the commented out and
    unimplemented writeUbikHeader stub.
    
    Reviewed-on: http://gerrit.openafs.org/7613
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 7f646382f633fb83d2054298cd5ce12a7bfa250c)
    
    Change-Id: I706e3728216cecf0d0c12ad3008ff0ae6ddbc553
    Reviewed-on: http://gerrit.openafs.org/11159
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 7cfb8d388ee64a05aa01cef6f60ef1e89817e0f7
Author: Christof Hanke <christof.hanke@rzg.mpg.de>
Date:   Thu Apr 24 06:19:32 2014 +0200

    Logfiles: open with O_APPEND
    
    This does not change the current (normal) behaviour, but allows
    logrotation via "copy and truncate" as offered by logrotate.
    Otherwise the processes will remember the offset of the last write
    and a truncated file is filled with '\0' until the current offset.
    The mrafsStyleLogs are untouched, since they can be rotated by a
    kill -HUP and are deprecated anyway.
    
    Reviewed-on: http://gerrit.openafs.org/11092
    Reviewed-by: Nathaniel Filardo <nwfilardo@gmail.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit b71a041364d28d6a56905a770cd20d1497ee26ec)
    
    Change-Id: Idc148f4d6b9302d25cbf32763d08ee24eaf7378b
    Reviewed-on: http://gerrit.openafs.org/11193
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 81be318c65e70df4add91838b4de275840c6127c
Merge: 9492d2a 3381492
Author: Jeffrey Altman <jaltman@your-file-system.com>
Date:   Thu Jun 12 19:21:13 2014 -0400

    Merge tag 'openafs-stable-1_6_9' into openafs-stable-1_6_x
    
    openafs 1.6.9

commit 3381492d26c2c3677b5f6065e1022c9cfe225c79
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Thu Jun 12 10:30:48 2014 +0200

    Make OpenAFS 1.6.9
    
    Update version strings and NEWS for 1.6.9
    
    Change-Id: I80fe292dd091a26cbec5d5b4a2fab51e4cf4dee6

commit bc8f62fcdfa479023d15125404d1b13b6dfd6dc3
Author: Jeffrey Altman <jaltman@your-file-system.com>
Date:   Wed Jun 11 19:03:45 2014 -0400

    Revert "viced: Avoid issuing redundant TMAY requests"
    
    This reverts commit 03a9b481c7f27c462c9d65a756d172e79758b86d.
    
    Andrew Deason wrote,
    
      "Briefly, 'host' structures are allocated without clearing all of the
      contents to '0'. Only part of the structure is cleared, according to the
      HOST_TO_ZERO macro. Unfortunately I put the new tmay_ fields right below
      the 'index' field for some reason, so this means they aren't zeroed and
      can contain garbage. This means we can easily segfault in the fileserver
      when we try to access the pointers in there.
    
      "We access uninitialized memory for every 'host' that is allocated. So
      the chance of us corrupting memory is the chance that a particular
      pointer-sized area of memory from 'malloc' is not already NULL.
    
      "That seems pretty likely, but it's not so frequent as to have the
      fileserver effectively "constantly" crashing at the site that noticed.
      So it has not been a fire drill, but it has been noticeable (we heard
      about it I think yesterday, and got details today when it happened
      again). The noticing incident was a segfault, but an abort or sigbus are
      probably also likely.
    
      "Of course, the chances of noticing go way up with more clients. I expect
      the chances dramatically increase if you have more than 512 client hosts
      hit the box, since the first block of 512 are allocated before we really
      do anything. For the next 512, it seems much more likely that 'malloc'
      will give us back non-zeroed data. But this is just theory.
    
      "With the incident I know about, the crash happened semi-quickly after
      the server started (a few minutes). But it seems likely to occur after
      the server has been up for a long time, if/when you cross the next line
      of 512 hosts.
    
      "I am also concerned that this can easily be corrupting memory without
      being noticed via a crash (or it takes a while to crash), since we are
      potentially free'ing invalid pointers, or stomping over someone else's
      memory, etc etc."
    
    Change-Id: I20bd40fc9df69247884099a0623e6db40908b3e8

commit 9492d2ac0ca6ff8390713229382fcc5e1adb24ce
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Mon May 20 11:32:04 2013 -0400

    volser: -log restore operations
    
    Add vos restore to the list of operations which are logged
    when the volserver is running with the -log option. Example
    log line:
    
        admin on 172.16.50.141 is executing Restore 536870969
    
    Reviewed-on: http://gerrit.openafs.org/9926
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit eb7b3dac482ed0427b6e618bf60507a7a1a99769)
    
    Change-Id: If09d8d170c14cfd71c181cbdc87c6027ee570c45
    Reviewed-on: http://gerrit.openafs.org/11153
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit c10aa39f31d7000b746d429cd75d74cb9390be0e
Author: Antoine Verheijen <antoine@ualberta.ca>
Date:   Mon Apr 8 20:51:52 2013 -0600

    Increase size of space for ACL in "up" command.
    
    The amount of space allocated for use by the pioctl call to
    obtain the ACL for the source directory in the "up" command
    is not large enough and the call fails when access lists get
    sufficiently large.
    
    This change increases the size of the space provided to
    pioctl to the maximum possible. This allows for much larger
    access lists and is consistent with a similar call in the
    "fs listacl" command).
    
    Reviewed-on: http://gerrit.openafs.org/9753
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 639453196dd9f71a86e61d2c83e2e8ae0d8bf45f)
    
    Change-Id: I4fabbe3fc294c076bd786d43f5e9d2dd0b32e99d
    Reviewed-on: http://gerrit.openafs.org/11111
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 6609a7dfa4884f8996102e220546ac2023719ad4
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Wed May 7 15:20:51 2014 +0200

    redhat: Use the right path to depmod
    
    As of Fedora 17 and RHEL 7, depmod has moved from /sbin to /usr/sbin.
    The full path to depmod is used in package scripts and as a dependency.
    This hasn't caused problems in most cases because on an installed
    system a link /sbin -> /usr/sbin is present and during ordinary package
    installations yum/rpm correctly then figure out that /sbin/depmod is
    actually provided. But in other situations, the dependency check is not
    that clever and (incorrectly) fails.
    
    Add a macro to the spec defining the full path to depmod, use the macro
    rather than plain /sbin/depmod throughout the spec, and also pass it to
    kmodtool when required to generate the kmod package scripts and
    requirements.
    
    FIXES 131860
    
    Reviewed-on: http://gerrit.openafs.org/11128
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit c20c01185ed748b2bc823369a8f28cf004b7d1c9)
    
    Change-Id: Ib9e0bfe586de668ddba6fb82ff1ea2a081277150
    Reviewed-on: http://gerrit.openafs.org/11171
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Ken Dreyer <ktdreyer@ktdreyer.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 0fe14e5487330a161dbbb1d293aba43ac395ddcf
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 11:09:08 2013 +0000

    libadmin: Don't double check for required param
    
    The server, process and stat_type parameters are declared as
    required when the command syntax is set up - so they must be
    present when the command handler is called. So, don't bother
    checking for them.
    
    Caught by coverity (#985963, #985964, #985965, #985966, #985967,
    		    #985968, #985969, #985970, #985971, #985972,
    		    #985973, #985974, #985975, #985976, #985977)
    
    Reviewed-on: http://gerrit.openafs.org/9399
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit f5b462c9d4a56be0ae4696db08fb92a1e7390e2c)
    
    Change-Id: I4ea58eadbc97a934bb54a346086cdaf77ab28b9c
    Reviewed-on: http://gerrit.openafs.org/11048
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Dan Hyde <drh@umich.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e47d97c8ae316c90ecb636a497c52cdb9a27a935
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Tue Apr 15 12:30:19 2014 -0500

    doc: Clarify some BosConfig.new text
    
    It is not always clear to users whether BosConfig.new is noticed
    during an automatic restart, or if it requires stopping and starting
    the bosserver. Slightly reword the relevant text and add a small note
    that a "general restart" does cause BosConfig.new to be noticed, so
    this is explicitly clear.
    
    Reviewed-on: http://gerrit.openafs.org/11076
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 3946b50a7ecdfd34681ab471863929b2f82aff4b)
    
    Change-Id: Ia630aec6ef5259fc3c3fd531fdf8fda8a4152c54
    Reviewed-on: http://gerrit.openafs.org/11216
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Ken Dreyer <ktdreyer@ktdreyer.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 6519f31fd9238864c17cd2fac0a14fda40e47943
Author: Chas Williams (CONTRACTOR) <chas@cmf.nrl.navy.mil>
Date:   Fri Mar 21 14:35:46 2014 -0400

    volser: remove commented code
    
    Apparently this predates AFS 3.0 so it should be safe to remove.
    
    Reviewed-on: http://gerrit.openafs.org/10935
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit cc39ac77c6e8d120a41ffe67a60896463323ab31)
    
    Change-Id: Ia034b8a14c000ee2772ba555a45a9776a20aff43
    Reviewed-on: http://gerrit.openafs.org/10945
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 08355369c3917392ea1d3eabd420452c2e1361a3
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Wed Mar 27 18:12:41 2013 -0500

    afs: Raise fake free space reporting
    
    We report 'fake' values for free space, free file nodes, etc for the
    'AFS' filesystem, since these values are not meaningful for AFS
    itself. Currently we report about 9G of free space for most platforms,
    and a few different values for a few others. Raise all of these to
    2^32-1, so that trying to copy over 9G of data into AFS does not fail
    for those applications that check the destination free space with
    statfs(2). Note that one such application is KDE 4.8.x.
    
    Consolidate all places that do this, and put the 'fake' value in one
    place, AFS_VFS_FAKEFREE, along with the relevant comments.
    
    Related issues reported by Lars Schimmer, Richard Brittain, and
    others.
    
    Reviewed-on: http://gerrit.openafs.org/9688
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Markus Koeberl <markus.koeberl@tugraz.at>
    Tested-by: Markus Koeberl <markus.koeberl@tugraz.at>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit e385571ba37fa6d43fecca17e9e5d60a22a414cd)
    
    Change-Id: Id9b5fa92f48bc83b84bb4f50bc0ae25b028694b0
    Reviewed-on: http://gerrit.openafs.org/10984
    Tested-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 9e227094914d1a74b64f247cb74793c429930b25
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Thu Apr 10 17:59:24 2014 +0200

    fs: Fix improper use of readlink
    
    readlink returns a non-NUL terminated buffer. If we are going to
    terminate its response, we need to make sure that there's space to
    do so. So the length passed to readlink should be one less than the
    real length of the buffer.
    
    This is a 1.6-only change
    
    It is inspired by commit 25011b4544e48dffd5978201669f7b9e23da3144
    which cannot be cherry picked due to other missing commits on
    the 1.6 branch, like 763ec5250deef6f0f8ae1c85b52bac3ffc1a6176.
    
    Change-Id: I5c3f2946f7c1b8e935ae46bc195f58e207e115d6
    Reviewed-on: http://gerrit.openafs.org/11054
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit d08e048e57906574d3e505a345e0935d1df2dba4
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Fri Feb 28 18:47:12 2014 +0100

    bozo: remove obsolete bnode_Deactivate() prototype
    
    Commit 54eb2485b59550ba42569ed3a8d76211a3a35019 removed the
    implementation of bnode_Deactivate(), which had been #ifdef'd out
    for a long time, but left the prototype in place. Remove the
    obsolete declaration in bosprototypes.h as well.
    
    Reviewed-on: http://gerrit.openafs.org/10868
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 01a7c64e472c241798306e7f8137de28efdef37e)
    
    Change-Id: Ic1ca95ef455705a14cf68f0801d73789cc7bd4b5
    Reviewed-on: http://gerrit.openafs.org/11192
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 5382e9f9adadd0851615e697876134e3a2c8e21e
Author: Stephan Wiesand <stephan.wiesand@desy.de>
Date:   Fri Mar 14 14:44:54 2014 +0100

    bos: Change the remaining use of ktc_to_charptr to char cast
    
    This is a 1.6 only change to complement the preceding commit.
    
    On the master branch, this modification is part of commit
    a9b8fd81bf14c04d33113e9e4df4e1ca7573e49d which otherwise comprises
    changes not foreseen to be applied to 1.6.
    
    Change-Id: I44678c2fb15f136d70f2d38a3996ad3d7d0455d5
    Reviewed-on: http://gerrit.openafs.org/10891
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 98d8b56c7d9a1865492fe4bb23d28674162b7050
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Thu Apr 5 15:50:35 2012 -0400

    bos: Change to using char casts for ka functions
    
    The ka_IsZero and ka_PrintBytes function just use char strings. Cast
    directly, rather than going via a helper functions to simplify this
    code.
    
    The helper functions add complexity, and additional dependencies which
    cause problems with some uses of this code.
    
    Reviewed-on: http://gerrit.openafs.org/7066
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@dementix.org>
    (cherry picked from commit 46c5aabfc6f5af2875e8b20252a17955ad89dd38)
    
    Change-Id: Ifee3178e5cdc2eab947f759541864ecea4345b7a
    Reviewed-on: http://gerrit.openafs.org/10867
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 6c591b74e4c4ecd1653efc46c4dca15fd0b748d7
Author: Ken Dreyer <kdreyer@usgs.gov>
Date:   Wed Mar 6 13:53:29 2013 -0700

    doc: recommend cleanup steps in "vos convertROtoRW" man page
    
    vos convertROtoRW leaves the older RW copy on the original fileserver,
    although it is no longer in the VLDB. Provide the user with some hints
    regarding clean up.
    
    Reviewed-on: http://gerrit.openafs.org/9408
    Reviewed-by: Ken Dreyer <ktdreyer@ktdreyer.com>
    Tested-by: Ken Dreyer <ktdreyer@ktdreyer.com>
    (cherry picked from commit 279345c231d0a2d9f6e8c2f76a5347bafd40e70b)
    
    Change-Id: Id273ab86bfe68f89ef629f0c4d839882852e09ab
    Reviewed-on: http://gerrit.openafs.org/11126
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Ken Dreyer <ktdreyer@ktdreyer.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
    Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 63e35976933c8e24c2153fb55a46842a8dc04414
Author: Ben Kaduk <kaduk@mit.edu>
Date:   Wed Jul 17 15:00:11 2013 -0400

    bozo: Remove dead code and minor cleanup
    
    This stuff has been #if 0'd for ages; put it out of its misery.
    
    While here, remove the global bnode_waiting which is not used for anything.
    
    bnode_SoftInt claims to return a pointer, so return NULL instead of 0.
    
    Reviewed-on: http://gerrit.openafs.org/10284
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 54eb2485b59550ba42569ed3a8d76211a3a35019)
    
    Change-Id: Ife2604f1a99ef81e2075a82cb97d94ae5373031c
    Reviewed-on: http://gerrit.openafs.org/10864
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit ef449bc73ea35130f83d15fba4b497c972f50f70
Author: D Brashear <shadow@your-file-system.com>
Date:   Tue Apr 22 11:38:44 2014 -0400

    linux: make reading unixusers from proc actually work
    
    our indentation did not match our braces so we would never read all the
    objects in each unixuser hash chain. add the missing braces
    
    Reviewed-on: http://gerrit.openafs.org/11094
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
    Reviewed-by: D Brashear <shadow@your-file-system.com>
    (cherry picked from commit 279e01051600f0884ed3669786543578e53cf518)
    
    Change-Id: If8d4faf8a9cc301d231c1f7b11ab5bb9ca721451
    Reviewed-on: http://gerrit.openafs.org/11093
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Reviewed-by: Ken Dreyer <ktdreyer@ktdreyer.com>
    Reviewed-by: Nathaniel Filardo <nwfilardo@gmail.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 6cdeb497923b11b94de08a32f784c04871a25970
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Mon Mar 4 16:34:20 2013 +0000

    butc: Init volheader before using it for hton
    
    When converting a volume header from host to network order, make
    sure that any unused fields in the structure are zero'd, so we don't
    end up filling them with stack garbage in the network version of
    the structure.
    
    Caught by coverity (#985956)
    
    Reviewed-on: http://gerrit.openafs.org/9548
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 21166744bf15f13bc04c25d68a28fe803a960b0a)
    
    Change-Id: I7156cc51f52a8c9911d6ce087ba0a6b1cc0d9a9e
    Reviewed-on: http://gerrit.openafs.org/11065
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 7597fdda3ff949077829727c26f4bd289c4ae285
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Mon Mar 4 16:22:08 2013 +0000

    upserver: Don't overflow file and hostname buffers
    
    If the user specifies a ridiculously long command line, don't
    overflow the filename or hostname buffers with what they supply.
    
    Caught by coverity (#985911)
    
    Reviewed-on: http://gerrit.openafs.org/9546
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit d672d5ee78d7673f3c42a7a343989b2bd4dca02b)
    
    Change-Id: Id86f5488bfb3bbf5794af43e9f8fe84a2fe796c3
    Reviewed-on: http://gerrit.openafs.org/11064
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit fd403e3f2ad74e7d568a4982d99af1acba305b55
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 13:01:14 2013 +0000

    auth: Don't overflow buffer in CompFindUser
    
    The fullname buffer in CompFindUser is theoretically big enough
    to take the data usually supplied to it. However, play it safe by
    using strlcat and strlcpy to catch buffer overflows.
    
    Caught by coverity (#985771)
    
    Reviewed-on: http://gerrit.openafs.org/9543
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit cc95fca8e16f83d7dda3f09a5133dc9294299d61)
    
    Change-Id: I900611e13d6254c4410915b0688b18a3b6c4acc3
    Reviewed-on: http://gerrit.openafs.org/11063
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 19bcc0ab08ad6b1080688ce06b2e9300610bbc33
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 12:38:49 2013 +0000

    audit: Fix overflow in file backend
    
    If the filename passed to open_file was larger than MAXPATHLEN-5,
    then we'd overflow the oldName buffer when creating the backup
    filename. Fix the overflow by using a malloc'd buffer instead.
    
    Caught by coverity (#985767)
    
    Reviewed-on: http://gerrit.openafs.org/9448
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit b0b3def56c15161df28059e270f0360c31241217)
    
    Change-Id: I3993de8e4372c30d35e6e675042511f85ba9d014
    Reviewed-on: http://gerrit.openafs.org/11062
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 2c3b0c239285b2f503c5c745648a710cb84af130
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 12:21:06 2013 +0000

    aklog: Fix buffer overflows in next_path
    
    Use strlcpy and strlcat
    
    Caught by coverity (#985765)
    
    Reviewed-on: http://gerrit.openafs.org/9447
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit f4373e7867abd50b3fe39716073811794fe62379)
    
    Change-Id: I45d3be18e2975443ce2135f4057128e51d995fa2
    Reviewed-on: http://gerrit.openafs.org/11061
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e49026b294d3b625baba2a91dab65e3d2e0050a7
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 12:15:22 2013 +0000

    aklog: Protect against overflows from cmdline
    
    The cell, realm and path arrays are populated based on the user's
    command line, and xlog_path is populated from their passwd map
    entry. Protect against all of these overflowing, by making suitable
    use of strlcpy and strlcat.
    
    Caught by coverity (#985764, #985904)
    
    Reviewed-on: http://gerrit.openafs.org/9446
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 2902ef93976fd4baa1a1ed07f4940c5979702856)
    
    Change-Id: I1c8b72aa087902e45cef758844193949471170c5
    Reviewed-on: http://gerrit.openafs.org/11060
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 110b2b674f0e2fda46d01a0b038c49bcc410cca4
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 12:09:42 2013 +0000

    aklog: Avoid overflows in get_afs_mountpoint
    
    When working with the fixed length cellname buffer, use
    strlcat and strlcpy rather than strcat and strcpy.
    
    Caught by coverity (#985763)
    
    Reviewed-on: http://gerrit.openafs.org/9445
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 19d2683d711f95165adc16fac765bb4a31c99043)
    
    Change-Id: I91c169380600496a8b5148fffcb1a21feb1eee29
    Reviewed-on: http://gerrit.openafs.org/11059
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit a68deb7fc5719b2399e3e1d063f9681f6aa4bf31
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 12:04:46 2013 +0000

    aklog: Fix overflows in auth_to_path
    
    In the auth_to_path routine, don't use strcpy and strcat when
    working with the fixed length pathtocheck buffer. Instead, use
    strlcpy and strlcat to ensure that all string operations fit within
    the buffer limits.
    
    Caught by coverity (#985762)
    
    Reviewed-on: http://gerrit.openafs.org/9444
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 788a6b67a088e2565c3b47ecb6e594a7b15f2757)
    
    Change-Id: I9abb8ab33da1d72e42764969e5527d443eea9652
    Reviewed-on: http://gerrit.openafs.org/11058
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit ba71a23fd47ee603eba670259caf96b8618fc8cc
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 12:00:47 2013 +0000

    afsmonitor: Fix theoretical overflow of handler string
    
    Don't do an unbounded copy into the thresh structure's handler
    string, in case the caller has passed us a string which is too
    long.
    
    Instead, switch to strlcpy for all string copies.
    
    Caught by coverity (#985761)
    
    Reviewed-on: http://gerrit.openafs.org/9443
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 95cd5b1d950ecb820179e4279b8570d8ad6780f5)
    
    Change-Id: Id8d7f3b97ac3ccbf65862d61b2f9e9d39baeb162
    Reviewed-on: http://gerrit.openafs.org/11057
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 7eb63cd21ee57312ca71930d59f49177d80f4f2a
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 10:27:47 2013 +0000

    util: Avoid overflow in GetNameByINet
    
    We copy the results of gethostbyaddr into a fixed length buffer
    without checking whether they fit. Add a length check, and use
    strlcpy to do the copy to make sure we can't overflow.
    
    Caught by coverity (#985912, #985872)
    
    Reviewed-on: http://gerrit.openafs.org/9393
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit fcb7974b838c2b37a8b81b88b11905c6ece398f6)
    
    Change-Id: I2d7f781c159999e721504cd6eec408db93bb703c
    Reviewed-on: http://gerrit.openafs.org/11056
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 5ad98f49dfb52b9f20375a9163ec17dd184523b3
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 09:35:01 2013 +0000

    kauth: Don't overflow stack when building username
    
    knfs constructs the userName by combining the clientName.name
    and clientName.instance arrays, along with a dot separator. Make
    sure that the userName array is big enough to hold these, and
    use strlcpy and strlcat just to make sure.
    
    Caught by coverity (#985829)
    
    Reviewed-on: http://gerrit.openafs.org/9351
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit cc194827a841f057654f1dbe4dcb3f6de98c1c60)
    
    Change-Id: Iec62a0e0fb830e8bfc76896733269d0511c5a8d9
    Reviewed-on: http://gerrit.openafs.org/11055
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit cb1c5ddb307db2d4f7a9e3e9627b8576fc1aa9e5
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 11:49:13 2013 +0000

    fstrace: Don't read uninitialised data
    
    The pftix variable points to the next free element in the
    printfTypes array, so when we iterate through that array to
    read that data back, we should stop when our iterator equals
    pftix, not when it is greater than it.
    
    Caught by coverity (#986013)
    
    Reviewed-on: http://gerrit.openafs.org/9442
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 908105fe8d51551e45692de4e145022138a0356c)
    
    Change-Id: I2dec4dc3b041093e1d1ac2ea4546a341e9b00687
    Reviewed-on: http://gerrit.openafs.org/11053
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit c5d1f3130dc2943de19e3a40b84500eb84078a79
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 11:44:02 2013 +0000

    readpwd: Make sure user supplies a passwdfile
    
    If the user supplies enough command line arguments, but doesn't
    provide a passwdfile, then we can end up trying to open whatever
    garbage is on the stack.
    
    Once we've finished parsing the command line arguments, make sure
    that a filename was supplied.
    
    Caught by coverity (#986009)
    
    Reviewed-on: http://gerrit.openafs.org/9441
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit d81271640891fb8c364e8625e7a9f6ede21572f4)
    
    Change-Id: I66d38c04c0f9519c401d3299e7d3ece57d001d96
    Reviewed-on: http://gerrit.openafs.org/11052
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 6682261c9fdc0ea76a96b166fba2746b421dee02
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 11:44:02 2013 +0000

    readgroup: Make sure user supplies a groupfile
    
    If the user supplies enough command line arguments, but doesn't
    provide a groupfile, then we can end up trying to open whatever
    garbage is on the stack.
    
    Once we've finished parsing the command line arguments, make sure
    that a filename was supplied.
    
    Caught by coverity (#986008)
    
    Reviewed-on: http://gerrit.openafs.org/9440
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 3c564444cf1c0bad25792b10edc158030e180369)
    
    Change-Id: I8d0bb6ec6a39ad095959ede0252dc6f00777515e
    Reviewed-on: http://gerrit.openafs.org/11051
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit de7353838a0ed78eb7bc797ce75be2a1605455b3
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 11:36:31 2013 +0000

    libadmin: Don't pass garbage to pts_UserCreate
    
    The libadmin pts_UserCreate function uses the value passed to
    it in newUserId to control whether the user is being created
    with a user supplied ID or not.
    
    Initialise this value in the caller, so we don't end up creating
    users with corrupt ids.
    
    Caught by clang (#985979)
    
    Reviewed-on: http://gerrit.openafs.org/9401
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 5cf4415c8ad400a92fc9c7f436ae52256db2ef09)
    
    Change-Id: I0e91352a98f63b386185abf9860dc056cb775821
    Reviewed-on: http://gerrit.openafs.org/11050
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit ce9230839696af7f6fbcca23364f9ee0fdf2e759
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 11:36:31 2013 +0000

    libadmin: Don't pass garbage to pts_GroupCreate
    
    The libadmin pts_GroupCreate function uses the value passed to
    it in newGroupId to control whether the group is being created
    with a user supplied ID or not.
    
    Initialise this value in the caller, so we don't end up creating
    groups with corrupt ids.
    
    Caught by clang (#985978)
    
    Reviewed-on: http://gerrit.openafs.org/9400
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit ece7bd669af0c58dcaa2589e093387adb7d1756a)
    
    Change-Id: I51750db47f7709406c079c4fbeec561228359e73
    Reviewed-on: http://gerrit.openafs.org/11049
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit a78e3a7e673d5d0428e769a8a9f0ea1ccb683d40
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 11:02:09 2013 +0000

    libadmin: Don't free garbage pointer
    
    If we jump to the error handler early on in pts_GroupOwnerChange,
    idlist may not have been used, and so we will end up trying to
    free stack garbage.
    
    Initialise the structure to 0 at the start of the function, so it
    is always safe to enter the error handler.
    
    Caught by coverity (#985962)
    
    Reviewed-on: http://gerrit.openafs.org/9398
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 8260d86dda766a21e9f457994e7a3b259ba3a31b)
    
    Change-Id: I79f7fe3cba11a2904c644e6747511e3630d74a79
    Reviewed-on: http://gerrit.openafs.org/11047
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 37eb63dfaf020dfc17553d33a846bf09a9a9566b
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 10:54:16 2013 +0000

    kauth: Use strl* functions in ka_log
    
    Switch to using the strlcat and strlcpy functions in ka_log, to
    avoid potential buffer overflows.
    
    Caught by coverity (#985824)
    
    Reviewed-on: http://gerrit.openafs.org/9397
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit b535059d48ac592760e2e5b87414d9010143c993)
    
    Change-Id: Ie2a3f39e3189492f855729b4ded7a6fa71c43c9c
    Reviewed-on: http://gerrit.openafs.org/11046
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 43b80fee3dee191fe7d768f2594eb1f57cdda624
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 10:48:50 2013 +0000

    kauth: Handle calls to ka_log with no principal
    
    If ka_log is called without a principal string, then the resulting
    buffer will be garbage, as we don't start with a string for strlcat
    to append to.
    
    Caught by coverity (#985959)
    
    Reviewed-on: http://gerrit.openafs.org/9396
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 508674486a5b1b3b25d7f28febb41e8712d8592d)
    
    Change-Id: Ib65f63a1a7adef73d56d61ea59adfbca430dff13
    Reviewed-on: http://gerrit.openafs.org/11045
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 99795bac249f56e49999117eeaaedaf327f1b15a
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 10:42:27 2013 +0000

    vsys: Avoid uninitialised variable warning
    
    Initialise the parms array to 0 so that we don't get warnings from
    the compiler when we call syscall() using it.
    
    Caught by coverity (#985949)
    
    Reviewed-on: http://gerrit.openafs.org/9395
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit a666bfd67bd14028aac5eb49f1bf02576fb58405)
    
    Change-Id: Ia777a33c1332fe9a1f00cc56be3980f0d50b69ea
    Reviewed-on: http://gerrit.openafs.org/11044
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit da3dc59ce087ff2128a96f4dbf171e7ec38af218
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 10:15:10 2013 +0000

    rmtsys: Don't overflow pathname buffer
    
    When we're constructing a homedirectory path to look for the
    .AFSSERVER file in, we copy the HOME environment variable into a
    static buffer, with a risk of overflowing that buffer.
    
    Instead of using a static buffer, just allocate one with asprintf.
    
    Caught by coverity (#985910)
    
    Reviewed-on: http://gerrit.openafs.org/9392
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit f322b0ff1ec44d713c23d567f4d304e3dc65e702)
    
    Change-Id: I588fecf4caee64915fc2e7730f68f051d6faa92a
    Reviewed-on: http://gerrit.openafs.org/11043
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 049e7650a81866c4b32b8a5189780d0a4379ea44
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 10:35:42 2013 +0000

    fsprobe: Get rid of unused hostname buffer
    
    When we copy the user supplied hostname into the fixed length
    hnamebuf array, we might overflow it. As we never use this buffer,
    just get rid of it.
    
    Caught by coverity (#985913)
    
    Reviewed-on: http://gerrit.openafs.org/9394
    Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit b32d92268f77608b57adf350d963941a94a31604)
    
    Change-Id: I09d119745dfdc9545af4912bd27f8ee09ccefd1f
    Reviewed-on: http://gerrit.openafs.org/11042
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit a5b40254de63ade492da9508b7d0218a7fe07f30
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 09:59:20 2013 +0000

    auth: Don't overflow hostName array
    
    afsconf_cell's hostName structure is a fixed length. Don't overflow
    it by writing whatever comes back from gethostbyaddr into it. Use
    strlcpy to catch an overflow, and if one occurs, just use
    "UNKNOWNHOST", rather than a truncated host name.
    
    Caught by coverity (#985906)
    
    Reviewed-on: http://gerrit.openafs.org/9354
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit fed5dac9f25f7fbd74b6834ce6f087eaf31be2f2)
    
    Change-Id: I468f66585e19623d62dee8730141767bd050ed1d
    Reviewed-on: http://gerrit.openafs.org/11041
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 06f0b6022342879c5519ff1bd0f272e1bff4538a
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 09:47:53 2013 +0000

    libadmin: Don't overflow volume name
    
    The maximum volume name length in the VLDB RPCs is VL_MAXNAMELEN
    (65), not 64 as used as a hardcoded value in vsprocs. Switch to
    using the defined value, and also use strlcat to check that we
    don't overflow this.
    
    Caught by coverity (#985849)
    
    Reviewed-on: http://gerrit.openafs.org/9353
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 79abe9d68ea041a2ea6261c6f7bb1f055a45bf0a)
    
    Change-Id: I0e1dd46be835e74fc43335606bf5ab8341678251
    Reviewed-on: http://gerrit.openafs.org/11040
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e6984f84d53115810e7936b8ee240b3a67789e56
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Fri Mar 28 17:08:46 2014 +0100

    volser: fix spurious strcat of volume extension.
    
    Fix malformed merge error left over from
    commit 4f9ec8396d1c7f12f8fa264cea7c255ce62b7b8d
    where we converted strcat to strlcat.
    
    Reviewed-on: http://gerrit.openafs.org/10963
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit e6110959e802bd9ae60e3724ba41078e7b335bab)
    
    Change-Id: I3ac39245f9151f319ab5d5bb6b6d17dd13446ac1
    Reviewed-on: http://gerrit.openafs.org/11039
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit fe288204f65298e494b5ea8bc031ae9c9b798364
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 09:47:53 2013 +0000

    volser: Don't overflow volume name
    
    The maximum volume name length in the VLDB RPCs is VL_MAXNAMELEN
    (65), not 64 as used as a hardcoded value in vsprocs. Switch to
    using the defined value, and also use strlcat to check that we
    don't overflow this.
    
    Caught by coverity (#985849)
    
    Reviewed-on: http://gerrit.openafs.org/9352
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 4f9ec8396d1c7f12f8fa264cea7c255ce62b7b8d)
    
    Change-Id: I7e2dfcaf23312dde123515e2c7329df1fa62de3e
    Reviewed-on: http://gerrit.openafs.org/11038
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e511a4069e30ecf14375f58380972b17b04e0fc2
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 09:33:12 2013 +0000

    kauth: Don't overflow cell string
    
    The cell string within a ktc_principal is only 64 characters long.
    Be careful not to overflow it.
    
    Caught by coverity (#985829)
    
    Reviewed-on: http://gerrit.openafs.org/9350
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 77aa6c65b74e46c77dfaf440745496ab98b14244)
    
    Change-Id: I7e0411ce635d481cf1618c2eabf79dfb85fcd069
    Reviewed-on: http://gerrit.openafs.org/11037
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 286f9e47d97c55bd8724a65350cf162478eea87c
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 09:26:05 2013 +0000

    auth: Don't overflow cell string
    
    If the kernel gives us bogus data back from the VIOCGETTOK pioctl,
    we might overflow the cell string when copying in to it. Use
    strlcpy to avoid this (unlikely) occurrence.
    
    Caught by coverity (#985768, #985769)
    
    Reviewed-on: http://gerrit.openafs.org/9349
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 362728d2d6d53011603dc39f691707db20866434)
    
    Change-Id: I839c330a232525ddccc7957ead785c7ed9beec88
    Reviewed-on: http://gerrit.openafs.org/11036
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e56dfc5c2c97e1429924c44acce56bde8486ac8b
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 09:16:10 2013 +0000

    aklog: Fix improper use of readlink
    
    readlink doesn't NUL terminate its return string, so it is up to
    us to do so.
    
    Caught by coverity (#985739)
    
    Reviewed-on: http://gerrit.openafs.org/9347
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 2fac53522e7ef5b3a376e191bffdc1f6784e6995)
    
    Change-Id: I9d47a6a7cbc86fba3f68f7e47c5d7a0fb924781f
    Reviewed-on: http://gerrit.openafs.org/11035
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 82f66b96fac2deb8e8afe189d51d1b003f72f111
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Sat Mar 2 09:01:59 2013 +0000

    vlserver: Use correct literal in bounds check
    
    The base array has VL_MAX_ADDREXTBLKS elements. Use this when
    checking for an array overflow, rather than VL_ADDREXTBLK_SIZE.
    
    Caught by coverity (#985600)
    
    Reviewed-on: http://gerrit.openafs.org/9346
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 6a54bf735871d93bc77e5cf166e506f4f2423d0a)
    
    Change-Id: I056432a1bf85b175ee4fc307d0662d072724b272
    Reviewed-on: http://gerrit.openafs.org/11034
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit b76b80bb08173edb5d2423c4edcd951b6630c679
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Fri Mar 1 11:35:05 2013 +0000

    rxgen: Don't overflow PackageIndex
    
    PackageIndex++ returns the pre-index value of PackageIndex, so the
    error statement isn't run when PackageIndex == MAX_PACKAGES. This
    means we go on to overflow all of the arrays that are MAX_PACKAGES
    in size.
    
    Caught by coverity (#985583, #985584, #985585, #985586,
                        #985587, #985588, #985589)
    
    Reviewed-on: http://gerrit.openafs.org/9325
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit a1d8109c8fa8c10e3ce5ed67cda03b3b557608ff)
    
    Change-Id: I5278bff5fe6be1bf127b240f7752c69385a9da24
    Reviewed-on: http://gerrit.openafs.org/11033
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 2e644c3d860b5576be0cdf69b09b554fc4af1542
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Fri Mar 1 11:09:04 2013 +0000

    bucoord: Remove theoretical overflow of ubik array
    
    The ubik connections array is NULL terminated, so we have to
    ensure that there is enough space for the trailing NULL. As the
    array is MAXSERVERS elements long, this means that we can only
    store MAXSERVERS-1 connections in it.
    
    This problem will never be encountered by the correct code, as
    the number of hosts returned from afsconf_Open is capped at
    MAXHOSTSPERCELL (currently 8). MAXSERVERS is currently 20. However,
    fix the bug in case we increase MAXHOSTSPERCELL at some point in
    the future.
    
    Caught by coverity (#985576)
    
    Reviewed-on: http://gerrit.openafs.org/9322
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit c0fba6eab519bd1bb6929b788361219f97da7212)
    
    Change-Id: I1e2556df6867ebb7b6b311e54a0271fb6fe631fd
    Reviewed-on: http://gerrit.openafs.org/11032
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 16bef5a55429feb067d7db163e102e6322e75485
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Fri Mar 1 10:52:32 2013 +0000

    xstat: Add the residency RPC to the list of fs ops
    
    Include the ResidencyRpc in the list of fs operation numbers that
    can be display by xstat_cm_test.
    
    Caught by coverity (#989029)
    
    Reviewed-on: http://gerrit.openafs.org/9320
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 64630d07b893199431b601a73de23c303c61db40)
    
    Change-Id: If14fb4e6929ea667b2dde18b381ab5c59c6bf8db
    Reviewed-on: http://gerrit.openafs.org/11031
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 08002c553bda0a7bfa60a4d269b57f5b168e6668
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Thu Feb 28 22:07:12 2013 +0000

    libadmin: Don't free garbage
    
    Make sure that we initialise the nbulkentries structure to 0 before
    we start work, so that if the failure handler is called, it doesn't
    try to free garbage.
    
    Caught by coverity (#985980)
    
    Reviewed-on: http://gerrit.openafs.org/9317
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit bf78bf2c115659b78c34d3bc9d1934bcff21c8cc)
    
    Change-Id: I24536b0bec47f381eee7cfcbe1feb89c373cca0f
    Reviewed-on: http://gerrit.openafs.org/11030
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e73905634170b2708386bc0697f87dad1614a4be
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Thu Feb 28 17:14:20 2013 +0000

    afsmonitor: Fix multiple NUM_CM_STAT_ENTRIES overflows
    
    If an array is n elements long, accessing element array[n] is an
    overflow. Fix various places where we apply loop bounds incorrectly
    using the NUM_CM_STAT_ENTRIES constant.
    
    Caught by coverity (#985571, #985573)
    
    Reviewed-on: http://gerrit.openafs.org/9316
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 3beca62928665868294ec3e9d34ab63b41e12645)
    
    Change-Id: Icb2221409d7cd62a7efa229697eeb16146ad3ddd
    Reviewed-on: http://gerrit.openafs.org/11029
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit ab2077b4646e612a4d51b0216344c4e63c165c1b
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Thu Feb 28 17:14:20 2013 +0000

    afsmonitor: Fix multiple NUM_FS_STAT_ENTRIES overflows
    
    If an array is n elements long, accessing element array[n] is an
    overflow. Fix various places where we apply loop bounds incorrectly
    using the NUM_FS_STAT_ENTRIES constant.
    
    Caught by coverity (#985570, #985571, #985572)
    
    Reviewed-on: http://gerrit.openafs.org/9315
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 4ea1c8440aad6bb6dc9cdb598b5708c685603219)
    
    Change-Id: I028fcb13716ba60266635a1f04f2dda083cba1a3
    Reviewed-on: http://gerrit.openafs.org/11028
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit d2d2b5759006dcb6e1820c528f88339867db183c
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Thu Feb 28 17:07:31 2013 +0000

    afsmonitor: Add missing items to fsOpNames array
    
    The Lookup and Residency fs stats counters were missing from the
    fsOpNames array. Add them in - Lookup has been missing since the
    IBM release, Residency was missed when the MR-AFS code was merged.
    
    This is still rather fragile, as there's no guarantee that
    AFS_STATS_NUM_FS_RPC_OPS matches the number of elements in this
    array. However, this is now correct until someone breaks it again...
    
    Caught by coverity (#985569)
    
    Reviewed-on: http://gerrit.openafs.org/9314
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 74d0d0d5e686d82e18f896889870af666c4d495d)
    
    Change-Id: Iac7275fd9dd9a2fa5fe163ba96a15d32d4e5d05e
    Reviewed-on: http://gerrit.openafs.org/11027
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 564573da48f61e5d96d5df017d25a39c930d566f
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Thu Feb 28 12:15:29 2013 +0000

    dumptool: Remove newlines safely
    
    The code currently does
    
       fgets(cmdbuf, ... );
       cmdbuf[strlen(cmdbuf - 1)] = '\0';
    
    in order to remove new lines from cmdbuf. Coverity thinks there's
    a danger of strlen(cmdbuf) being 0, and thus the strlen being negative.
    That shouldn't happen, but if fgets hits EOF midway through a line, we
    might get a string that doesn't have a trailing '\n', and end up
    removing the wrong character. Tidy this up by checking that the string
    isn't 0 length, and that the character we're zapping is a newline.
    
    Caught by coverity (#985430)
    
    Reviewed-on: http://gerrit.openafs.org/9310
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 8f51502e5f45a43fba130d260813716be894d51e)
    
    Change-Id: Ie165c8e50c4071c07fffa220601c8b5e92ccf815
    Reviewed-on: http://gerrit.openafs.org/11026
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 113ede2a6b43551efe9df19774202e91730dfe11
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Wed Feb 27 10:28:05 2013 +0000

    Unix CM: Don't free cell, then release lock on it
    
    If afs_NewCell fails, then we can end up releasing a lock on a
    section of memory that we have already freed. As this only happens
    if the memory we're operating on is newly allocated and not yet
    visible to anyone else, it is safe to release the lock before
    starting to tidy things up.
    
    Caught by coverity (#986054)
    
    Reviewed-on: http://gerrit.openafs.org/9298
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 816b0c76738b7e404c9384a745b58b4d90bfc30d)
    
    Change-Id: I7976f00431e4dc96642b45fc7563485a5087c938
    Reviewed-on: http://gerrit.openafs.org/11025
    Reviewed-by: Nathaniel Filardo <nwfilardo@gmail.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 206d6d9271504cad16326bcb717146ea5b3eed35
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Wed Feb 27 10:11:21 2013 +0000

    libafscp: Can't unlock something we've freed
    
    When we call _StatCleanup on a stored statent structure, it
    deletes the mutex, and frees the structure itself. This means it
    can't be called with a locked structure as the mutex deletion
    will fail, and then we'll try to reference freed memory when we
    later unlock that mutex.
    
    Fix this by unlocking the mutex before calling _StatCleanup. This
    is safe because the only reference to the structure visible to other
    threads must have been deleted by the time we reach this point.
    
    Caught by coverity (#986058, #986059)
    
    Reviewed-on: http://gerrit.openafs.org/9297
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit ce20f1f15103226667bc872378cf9b2e4b3e8cd7)
    
    Change-Id: Id89df6302002224ec2f871f18711e781990f73d3
    Reviewed-on: http://gerrit.openafs.org/11024
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 7863332ab7a88dd1aaa3c5bd2138622c57ee6197
Author: Michael Meffie <mmeffie@sinenomine.net>
Date:   Tue Apr 30 11:30:15 2013 -0400

    pt_util: fix group line check for input files
    
    Fix the check for requiring group lines before any membership lines. Do
    not clear flag indicating the presence of a group after reading each
    line.  (This error was caught by the pt_util-t unit test.)
    
    Fix for commit 12ced70c95fe8efbcec09a372f0af81d819bb8cd
    
    Reviewed-on: http://gerrit.openafs.org/9832
    Reviewed-by: Simon Wilkinson <simonxwilkinson@gmail.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 9c391e7f7d0e5dfdfe947d385e2db9a8b8ca3610)
    
    Change-Id: I6414f78d7611c61628aaacb4ae41111dbeec0d89
    Reviewed-on: http://gerrit.openafs.org/11148
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit cf4f1c7775f445987d8df1a4b4c4c7a12a0928e8
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Wed Feb 27 09:23:07 2013 +0000

    pt_util: Protect against corrupt input files
    
    If we have an input file which contains a group membership line
    (with a leading space) before any group definitions occur, pt_util
    would use stack garbage as the group to create these members in.
    
    Avoid this by requiring the presence of a group line before any
    membership lines.
    
    Caught by coverity (#92180, #986000, #92248)
    
    Reviewed-on: http://gerrit.openafs.org/9296
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 12ced70c95fe8efbcec09a372f0af81d819bb8cd)
    
    Change-Id: I1ad524ed701e78ebe5b2e990168782a75d69613b
    Reviewed-on: http://gerrit.openafs.org/11023
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 464ea3abdc46a31729cf8389fe8bba66706d65ae
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Wed Feb 27 09:21:30 2013 +0000

    pt_util: Catch sscanf failures
    
    If there isn't sufficient data in the input line to satisfy sscanf,
    fail with an error, rather than continuing with potentially corrupt
    data.
    
    Reviewed-on: http://gerrit.openafs.org/9295
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 62a10e063b4fe6721bd9768611d5f0c13b303189)
    
    Change-Id: I7b9cff1d106538496c6d554291710f73fd6b5370
    Reviewed-on: http://gerrit.openafs.org/11022
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 3afc0fdfcfef07d11046a34b8c74ad0f7b1bb9ad
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 22:40:04 2013 +0000

    kauth: Fix overflow when writing ticket file
    
    krb_write_ticket_file uses a fixed length buffer to store the name
    of the ticket file, but copies into this from an environment variable.
    
    Remove the fixed length buffer, and use a mixture of the variable
    itself, and dynamically allocated strings.
    
    Caught by coverity (#985909)
    
    Reviewed-on: http://gerrit.openafs.org/9294
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit a332ce9d0e87fab55f3d286690026fe075f624dd)
    
    Change-Id: Idcf442323b13cc4daa893917ede6492616ba1aeb
    Reviewed-on: http://gerrit.openafs.org/11021
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 7822702cf80de1902de5fe8fe0e7128690622a6f
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 22:31:49 2013 +0000

    auth: Refactor afsconf_Open failure handler
    
    Refactor the code which returns a failure from afsconf_Open into
    a single section, rather than having multiple copies through out
    the routine.
    
    Reviewed-on: http://gerrit.openafs.org/9293
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit a5324a6bb6ff127997c48b54f8ad0e98189f3f1e)
    
    Change-Id: I03f963b717c8095914dd994d7d5612bf57148ce7
    Reviewed-on: http://gerrit.openafs.org/11020
    Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 13515489cbfd138d221d54bdedc4bf44ff24778e
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 22:27:25 2013 +0000

    auth: Fix buffer overflow in afsconf_Open
    
    If we fallback to the .AFSCONF file in the user's homedirectory,
    the results of getenv("HOME") are copied into a fixed length string,
    without checking for overflows.
    
    Instead of risking this, just use asprintf to dynamically construct
    a string, and free it when we are done.
    
    Caught by coverity (#985905)
    
    Reviewed-on: http://gerrit.openafs.org/9292
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 41d9ea697bf5e81e5003ad7b208788223c25536b)
    
    Change-Id: I5b8664328dd0d397cbe459ff1e7667e63afc31e2
    Reviewed-on: http://gerrit.openafs.org/11019
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 2ae05022bfd083f2095565636ab0251ff5204a85
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 21:30:20 2013 +0000

    bos_util: Fix buffer overflow
    
    Get rid of a buffer overflow in the bos_util utility, by just
    printing the key from the 'tbuffer' string, rather than copying
    it into 'x' which is too small for it.
    
    Reviewed-on: http://gerrit.openafs.org/9291
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit debf43714b0f00fa00a0ef3384e098de78d28ed6)
    
    Change-Id: If8b075691defeded972d0eff29b7fb594680e433
    Reviewed-on: http://gerrit.openafs.org/11018
    Reviewed-by: Nathaniel Filardo <nwfilardo@gmail.com>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit adc34642923d8969c3aa6bc73d90e0817ba57a8e
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 21:28:52 2013 +0000

    volser: Fix bad readlink usage
    
    readlink fills the buffer passed to it with a non-terminated string.
    It can legitimately fill the whole of this buffer. So, if we require
    a string to be NUL terminated, we must give readlink one less than
    the string length so that the termination character can be safely
    appended.
    
    Caught by coverity (#985611)
    
    Reviewed-on: http://gerrit.openafs.org/9290
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit ddc37043351056c402158610477312f0d7d01c13)
    
    Change-Id: Ic3aa9f767b3dce988e32ce670763791f17e72aa2
    Reviewed-on: http://gerrit.openafs.org/11017
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit ac970305e80c8d43c7bc3a85e9486f0fc3d75b69
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 20:52:47 2013 +0000

    afsmonitor: Use NULL, rather than (struct foo *)0
    
    Reviewed-on: http://gerrit.openafs.org/9285
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit caabad98232557220f153461520fc0cf1c6978fb)
    
    Change-Id: Ie1e0e1bb4dcae88f17c592b4ebccaef227298190
    Reviewed-on: http://gerrit.openafs.org/11016
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 588252806a478e36e59a6dfdb2c470eff6c3e25a
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 20:51:34 2013 +0000

    afsmonitor: Check correct variable is non-NULL
    
    Before freeing curr_fsData, check that it is non-NULL, rather than
    checking prev_fsData in error.
    
    Caught by coverity (#985289)
    
    Reviewed-on: http://gerrit.openafs.org/9284
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 5a61e826fa0de6a5987f06257199476f79d2473a)
    
    Change-Id: Ie63e90f8873f4fbe8afc7abee160a090920add4d
    Reviewed-on: http://gerrit.openafs.org/11015
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit f40cc4dbdfb5ace884fcc84f0949316840cc6c6f
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 12:30:00 2013 +0000

    ptserver: Zero ubik header before writing to it
    
    When using pt_util's ubik shim, if we're creating a new ubik label
    make sure to zero the whole structure before writing it out to disk.
    Otherwise we get a shorts worth of stack garbage in the resulting
    file.
    
    Caught by coverity (#986010)
    
    Reviewed-on: http://gerrit.openafs.org/9274
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    (cherry picked from commit 96131593b329a319b22368a9ef37788fb4e5d4f4)
    
    Change-Id: I9b2b22c075bf896a74f4b527354c8a6758ac2865
    Reviewed-on: http://gerrit.openafs.org/11013
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 2c37afa50fd01e8208c55056895de0e140fad966
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 12:26:36 2013 +0000

    ptserver: Rename ubik.c as ptubik.c
    
    Coverity gets confused between ubik/ubik.c and ptserver/ubik.c,
    and produces a load of false positives. Rename the ptserver ubik
    shim (which is only used by pt_util) in order to reduce this
    confusion.
    
    Reviewed-on: http://gerrit.openafs.org/9273
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit daed548f70a2187c679232e4f79d703389419c4e)
    
    Change-Id: I834fab3b65859cb73ece3fc52d9272d0b7d452ed
    Reviewed-on: http://gerrit.openafs.org/11012
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit d5d8de145551c7afaf2aa488712901b2b9c18678
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 12:06:15 2013 +0000

    bosserver: Catch failures to create daemon thread
    
    If we can't create the bozo daemon thread, then don't keep going
    regardless. Just warn the user and exit.
    
    Caught by coverity (#988414)
    
    Reviewed-on: http://gerrit.openafs.org/9269
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 4587ddc130547b4cce723476cfa798a03ccc0320)
    
    Change-Id: I4dcf67f4aeb2533ad39e9b1b0202d00205584118
    Reviewed-on: http://gerrit.openafs.org/11011
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit 5b0d0785ef6dad2cdc5389d708a7556bbb545da2
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 11:59:56 2013 +0000

    libadmin: Catch VL_GetNewVolumeId failures
    
    If ubik_VL_GetVolumeId fails in the vos ProcessEntries routine,
    report the failure and give up, rather than continuing with a
    0 maxVolid
    
    Caught by coverity (#988417)
    
    Reviewed-on: http://gerrit.openafs.org/9268
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit 8192554e36272d5ed21007b4c0e3b6c56511457d)
    
    Change-Id: I004386d62dc9d2955a795c4c5952b573ff203784
    Reviewed-on: http://gerrit.openafs.org/11010
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit e27aa85f8d07960ceac1c54542373090f2e9cd9e
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Thu Feb 21 20:36:19 2013 +0000

    libadmin: Fix a lot of dead assignments in vsprocs
    
    Tidy up a lot of places where we initialise a variable, then
    immediately assign a proper value to it, or store a return value
    that we don't actually care about.
    
    Caught by clang-analyzer
    
    Reviewed-on: http://gerrit.openafs.org/9205
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
    (cherry picked from commit ee0d57bb488e9fd74b46547273904a9821e20c57)
    
    Change-Id: I60f690336bc449f481a5be542ab7369d6e04f4b6
    Reviewed-on: http://gerrit.openafs.org/11009
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

commit d6ea973022fb2a73ccfddb584a34b793b12043d1
Author: Simon Wilkinson <sxw@your-file-system.com>
Date:   Tue Feb 26 11:55:32 2013 +0000

    fs: Catch pioctl failure in mkmount
    
    If the VIOC_FILE_CELL_NAME pioctl fails in fs mkmount, return an
    error to the caller, instead of ploughing on with potentially bad
    data.
    
    Caught by coverity (#988418)
    
    Reviewed-on: http://gerrit.openafs.org/9267
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
    (cherry picked from commit 3ad7ba106dea28277b9e1f7a7370ba17b9fb3d17)
    
    Change-Id: I239ff7e567b01ecbec0314ec61f79d2fd0064de7
    Reviewed-on: http://gerrit.openafs.org/11008
    Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
    Reviewed-by: Andrew Deason <adeason@sinenomine.net>
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
    Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>