commit 340d3be82aa6d1fbaa0c775fe743f86e5a7335ed Author: Jeffrey Altman Date: Mon Jan 18 22:23:54 2010 -0500 Windows: Help text update for Network Identity Manager Provider Update the NetIdMgr provider help text to better describe its functionality. (Or at least not be incorrect.) Change-Id: I5d6b18f15cab7c48751666e754223ee68fb18d11 Reviewed-on: http://gerrit.openafs.org/1124 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit e010c8e9379bd2fa9b08a142e57cee56c123791c Author: Asanka Herath Date: Mon Jan 18 16:47:31 2010 -0500 Windows: Add a context menu for the AFS icon The OpenAFS plug-in for Network Identity Manager displays an icon in the notification area that displays status information about the AFS service and tokens. Add a context menu to the icon so that users can open the NIM application and get help for the plug-in from the notification icon. Change-Id: I704934b4f4eab72a18c54ef2a7a7dc3ca248ba78 Reviewed-on: http://gerrit.openafs.org/1121 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit b0ff95e2ee26f04dd7b03172acca075ddcd963a8 Author: Jeffrey Altman Date: Sat Jan 16 11:07:23 2010 -0500 Windows: Version number update for 1.5.69 Change-Id: I8af0167649cfeec95e5a5e5a72faeaccdeb92102 Reviewed-on: http://gerrit.openafs.org/1115 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit e33a7346a6b9153daf593ae4c084ce3839f822cf Author: Jeffrey Altman Date: Sat Jan 16 11:05:57 2010 -0500 Windows: ChangeLog for 1.5.69 Change-Id: I078f719c6e769cfcb7997bb8b67403de480255f9 Reviewed-on: http://gerrit.openafs.org/1114 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 97d0d22e34dbb1e927c90695e55ee582c51f9e64 Author: Derrick Brashear Date: Mon Jan 18 19:59:28 2010 -0500 make 1.5.69 for unix set version number for unix Change-Id: I2273e97ec43fd172e6f486ab6226cc6376885163 Reviewed-on: http://gerrit.openafs.org/1123 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit cc47e765912e1a5dedddb6ef00ca8b8c8d567f0e Author: Derrick Brashear Date: Sun Jan 17 01:10:28 2010 -0500 create debugging kext package for MacOS this creates and installs a debugging kext package for macos. it also always installs the decode-panic script (which can be used even without the debug kext) Change-Id: Iff03de66cd3df2690f03333e6629d21660364cd1 Reviewed-on: http://gerrit.openafs.org/1120 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 9f79dde2c804e943c2d6f7deaa00c6997b991691 Author: Marc Dionne Date: Sat Jan 16 17:40:52 2010 -0500 More pam warning cleanups - test_pam.c Clear up a few more warnings in the pam code. The changes here are very similar to the ones in the previous patch and use the same configure test: - use PAM_CONST to conditionally declare pam_message as const - cast a few arguments to putenv, which expects a non-const pointer Change-Id: I6c98623c35f4453f34c1d48b8b7d6ff1bfbc1e0c Reviewed-on: http://gerrit.openafs.org/1116 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit fdee40d8eac5466dff3969183debd422df60c269 Author: Marc Dionne Date: Sat Jan 16 16:29:10 2010 -0500 up.c: remove unused variable pageSize Variable pageSize is declared and set to the system page size using getpagesize(), but the value is not used anywhere. getpagesize() doesn't necessarily have a prototype declared in unistd.h with recent glibc, which can generate a new warning and trip up an enabled-checking build. Instead of trying to put in a workaround, just remove the unused variable. Change-Id: I6a9519eb2642bb0479edd1cf1195ce3f751c72bb Reviewed-on: http://gerrit.openafs.org/1117 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 41ae68f2986709daecd1b00a91919df8b2d9581f Author: Marc Dionne Date: Sat Jan 16 18:57:24 2010 -0500 uss: Fix IP address parsing and cleanup warnings In uss_vol_GetServer(), the IP address octets are scanned into "char" variables, and later cast to afs_int32 to build the address. sscanf gives warnings because it's expecting an int pointer, and testing shows that this code doesn't work as expected - the first 3 octets are always parsed as 0. Use afs_int32 variables instead, which works, eliminates warnings and simplifies the code. Note that this code does not seem to be reachable currently. It was probably meant to be used by planned additional uss commands. Change-Id: I646d4cbfa8ac0d0c50f98a334ac3fe387d6d361b Reviewed-on: http://gerrit.openafs.org/1119 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit ad48e6fb1f8749a059696612ad503aea28c4707d Author: Asanka Herath Date: Fri Jan 15 15:39:12 2010 -0500 Windows: Query the MTU value from the registry The syscfg_GetIFInfo() call uses the interface info returned by GetAdaptersAddresses(). Also manually query the MTU value in the registry for any interfaces bound to the same adapter and use the smallest such MTU as the value returned by syscfg_GetIFInfo(). Change-Id: I8a1d487b51f6674ff6ebbf6b1f20d37b1e278279 Reviewed-on: http://gerrit.openafs.org/1105 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 806423be3c55f3de91c2b836d2088eeb0f4e4665 Author: Simon Wilkinson Date: Sat Jan 16 15:35:34 2010 +0000 Don't double free call structure If the rx_Read() of the number of bytes in the FetchData64 response fails, then it sets code, and disposes of the call structure. However, the length safety check that was added in c7b92a3018044f7aca4d9a77644e5c06ef64d1e9 executes regardless of whether code is set, and the call has already been freed. So we end up calling rx_Error with a NULL call structure, and panic. Change-Id: Ia2e341b7a9a2ddc1d656e8b8a31698c0d1771d5e Reviewed-on: http://gerrit.openafs.org/1112 Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 3c57a1a85a2b3299b7b38557c95ff79a77dc3252 Author: Simon Wilkinson Date: Sat Jan 16 02:15:36 2010 +0000 Linux: Add missing prototype 6e65ffbb6c520bf1c28356206410363d8eb36d78 added osi_get_group_pag. On most platforms this is static, but on Linux it's provided by the OSI layer. Add a prototype so the compiler doesn't go boom. Change-Id: I106fa5d5299f8ed486e70cea2ea8681b43a81a33 Reviewed-on: http://gerrit.openafs.org/1110 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit f5cfa4cf7345e3d36c44f9bc01e0c70762e366b9 Author: Simon Wilkinson Date: Sat Jan 16 02:09:34 2010 +0000 Unix CM: Fix negative file length case, again As originally noted in f6f9ee5402f1718f330a00ec89fb34b05c3cd360 some fileservers return a negative length, typically when a client is attempting to fetch data that is past the extents of the file, the CM needs to retain this negative length, and handle it correctly. c7b92a3018044f7aca4d9a77644e5c06ef64d1e9 added safety checks for the fileserver returning a length larger than that asked for by the client. Sadly, this check does a comparison between a signed, and an unsigned, variable. This leads to it incorrectly classifying negative responses as being too large. Add a cast, and a comment, to fix this. Change-Id: I2ca67f55204c565667d5cd91cde3d520f8d9b10c Reviewed-on: http://gerrit.openafs.org/1109 Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit df702210275453e0d2362b0e142d82bfaf14406c Author: Jeffrey Altman Date: Fri Jan 15 09:06:05 2010 -0500 Rx: Correct AFS_NT40_ENV rx_GetIFInfo max MTU assignments On UNIX, the rx library values for rx_maxReceiveSize and rx_MyMaxSendSize are sent by the cache manager directly. In Windows, they are set by rx_GetIFInfo() which had two errors. (1) The comparison of rx_maxReceiveSize and maxsize were reversed which prevented rx_maxReceiveSize from ever being set to the interface MTU. (2) rx_MyMaxSendSize was never assigned a value. As a result, two problems occurred. (1) The remote peer was never told about the local MTU. (2) The local peer ignores the MTU. From 1.3.60 to 1.5.33, OpenAFS for Windows installers provided a registry default RxMaxMTU of 1260. This caused the cache manager to call rx_SetMaxMTU() which in turn set both rx_maxReceiveSize and rx_MyMaxSendSize in effect masking these errors. Change-Id: Ib05927d7985052e233ff6f4bd170a939eb05c320 Reviewed-on: http://gerrit.openafs.org/1107 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit c5d9f23cde1a024835582536e56cf4ea1652b7a8 Author: Jeffrey Altman Date: Fri Jan 15 09:18:50 2010 -0500 Rx: Do not drop call lock in rx_WriteProc* and rx_ReadProc* rx_WriteProc and rx_ReadProc has special fast logic that handles the most frequent case. This code was called without obtaining the call lock. However, each of these functions must obtain the call lock for the queue_IsNotEmpty() test and must re-obtain the call lock if the rxi_XXX variant is required. Dropping the lock and re-obtaining it is more expensive than holding it across the memcpy. Therefore, we shouldn't drop the lock until we are done. Change-Id: Icca679567994e91bbbf3afec72b863d986f86582 Reviewed-on: http://gerrit.openafs.org/1108 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Simon Wilkinson Tested-by: Simon Wilkinson Reviewed-by: Jeffrey Altman commit c1b74af7504e699ac831c81d0d7556ca36239298 Author: Jeffrey Altman Date: Fri Jan 15 09:00:41 2010 -0500 Rx: Remove last remnants of DJGPP support DJGPP code just clutters the AFS_NT40_ENV specific code but is never built. Change-Id: I90192bb5cf35239fdbbeaa28f85d1381162f3bae Reviewed-on: http://gerrit.openafs.org/1106 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit d4c97c0017be80c798206767c750e0855ee6c015 Author: Marc Dionne Date: Thu Jan 14 18:56:49 2010 -0500 src/pam warning fixes The second parameter to pam_conv() should be a const pointer on recent systems. Make it so to eliminate a couple of warnings. A configure test is added to deal with some systems where pam_conv() might not be const. Cast a few assignments to cell_ptr in afs_auth.c and afs_setcred.c since the argv parameter is const. Change-Id: I5757310c94a6f26ca7dab656edaa416d16e32e2a Reviewed-on: http://gerrit.openafs.org/847 Tested-by: Marc Dionne Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 62e4bf7ddd99d6958cde8dc3639ff4305fb66556 Author: Asanka Herath Date: Thu Jan 14 19:15:03 2010 -0500 Fix typo in AdminGuide -> Change-Id: If0f8183f59f038b1b5e033d5ebd2607b5091f6da Reviewed-on: http://gerrit.openafs.org/1103 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit d4f6ece19b05f2233e53f2d3c59f92316ec5ec3a Author: Dan Hyde Date: Wed Jan 13 14:38:47 2010 -0500 volmonitor keep vtrans lock VolMonitor must maintain the VTRANS lock the whole time it is walking the allTrans list. Failure to do so can cause core dumps trying to access memory that has already been free'd. Two versions of this change were coded and tested. The other version used the VTRANS lock only around a THOLD, but needed a TRELE, too. Timing tests were run counting the number of vos status, vos listvol, and vos backupsys operations that could be performed during a fixed number of vos status operations. The THOLD/TRELE version caused other vos operations to run about 5% slower. FIXES 126110 Change-Id: I7e749d30c955867faacafa978d7d643dee648ca3 Reviewed-on: http://gerrit.openafs.org/1098 Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 64778fd7bece52360482f9a51f19b34dac1d2678 Author: Simon Wilkinson Date: Tue Nov 17 20:46:17 2009 +0000 Kernel is always defined When we build the kernel module, either in the real or the ukernel case, KERNEL is defined. So, remove the #ifdefs around our locking primitives, so that things are a little bit clearer. Change-Id: I60893cc630d8cd4dd6cb11cdc44e8bf4f2f9f863 Reviewed-on: http://gerrit.openafs.org/838 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 1a027a3ee151c7f77bbfa74c8002c8ff4b406985 Author: Simon Wilkinson Date: Tue Nov 17 19:52:15 2009 +0000 Move GLOCK initialisation to platform directories Rework the GLOCK initialisation code so that it's moved out into platform directories, rather than all being done in osi_Init. Change-Id: I1aae76ba12cd4e45f54881f5573ed1713159b64b Reviewed-on: http://gerrit.openafs.org/837 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 39b59269e5b7715c5a3017fb5e0a3e5222129ac5 Author: Chas Williams Date: Tue Jan 5 00:22:19 2010 +0000 rewrite afs_MemWriteBlk() using afs_MemWritevBlk() this avoids the code duplication of extending/shrinking cache entries Change-Id: Ieeae668caa506e934f92edf193b99dabdba2eabe Reviewed-on: http://gerrit.openafs.org/1062 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 9984a95687ab23fea422bbf2b01d92caf33a24a1 Author: Chas Williams Date: Tue Jan 5 00:18:36 2010 +0000 Quick fix for readpages when using memcache Just don't do readpages if we're using memcache Change-Id: I6b8b45f291d106ad1303d5bea1caf7f910b7ecf4 Reviewed-on: http://gerrit.openafs.org/1061 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 18459cd32abe9aba75d46910f9a676e4a535e0da Author: Chas Williams - CONTRACTOR Date: Thu Jan 7 18:07:43 2010 -0500 afsd: decprecate -mem_alloc_sleep flag (and related code) On most platforms, afs_osi_Alloc_NoSleep() is already afs_osi_Alloc(). I have tested this on Solaris (the major exception) and haven't seen any problems. Change-Id: I0e8bfd76b2bd25889c1491633a3a6d50aceac510 Reviewed-on: http://gerrit.openafs.org/1079 Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 1544243167b0f294f080866710b3f29dec133f02 Author: Andrew Deason Date: Mon Jan 11 13:36:32 2010 -0600 Always check VInitVolumePackage2 return code Some programs were not checking the return code of VInitVolumePackage2. Although some programs do not care so much if we fail to properly init the volume package (SYNC debug tools), at the very least log/print an error, so it doesn't silently fail. Other programs are changed to exit when VInitVolumePackage2 fail, so e.g. salvages don't accidentally cause corruption on 'logging'-mounted UFS partitions. In any case, ensure the return code is always checked anywhere it is called. Change-Id: I164d5920a5ea2dd7e5ed9ad4ccc578e9bdf0db0b Reviewed-on: http://gerrit.openafs.org/1090 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit 9b23804a82ea12b5d46e6ee2667ec05bed502081 Author: Simon Wilkinson Date: Wed Jan 13 17:28:24 2010 +0000 Remove weekly bosserver restarts Change the default so new installations of the bosserver have no weekly restarts. Update the manpage and XML documentation to reflect this change. FIXES 126138 Change-Id: Ic22b750a602f6d2a22be881f5e1b04cd4fa132ae Reviewed-on: http://gerrit.openafs.org/1097 Reviewed-by: Russ Allbery Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 6e65ffbb6c520bf1c28356206410363d8eb36d78 Author: Simon Wilkinson Date: Sat Dec 19 23:58:54 2009 +0000 Linux: Rework PAG to group conversions The change to using a single group for PAGs on Linux led to a load of special cases throughout the code. This patch moves the OS dependent parts of this into the LINUX/ platform directory, and rearranges that file so that there is a clear distinction between the one and two group sections of the code. Change-Id: Ib6e6f081519b23494dcf731b4be689c006180c68 Reviewed-on: http://gerrit.openafs.org/1007 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit d2ddc3b6cfb1bc05fa045360bc09d708fe9cf611 Author: Jeffrey Altman Date: Mon Jan 11 14:35:12 2010 -0500 Windows: remove signed vs unsigned error in smb_Init Use UINT_PTR instead of INT_PTR. LICENSE MIT Change-Id: Id10cd7b7a18688c9eee68e3eac9c20348519fd37 Reviewed-on: http://gerrit.openafs.org/1089 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 6789f170d64695907970f01c22ac6eb8c7b14d15 Author: Jeffrey Altman Date: Mon Jan 11 14:21:11 2010 -0500 Windows: Protect buffers in smb_WriteData from simultaneous writes smb_WriteData does not properly use CM_SCACHESYNC_WRITE to protect buffers from simultaneous writes. Instead of simply testing CM_SCACHESYNC_WRITE at the top of the while loop, the flag must remain set until the entire write completes. cm_SyncOp is now called once and cm_SyncOpDone is only called upon final success or error. In addition, as 'count' is unsigned, the test for count < 0 is replaced with count != 0. LICENSE MIT Change-Id: I82c8dc20e62079b13bf305e906f4744756aa0ac2 Reviewed-on: http://gerrit.openafs.org/1087 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 513a7e48a2e586bd687af75084cfdf955f37b42f Author: Jeffrey Altman Date: Mon Dec 21 12:35:12 2009 -0500 Windows: fs examine owner and group are signed Change the owner array to be signed for displaying owner and group within fs examine output. LICENSE MIT Change-Id: I807e3f1b3c07eb26c1782d6b76cd49977467ce33 Reviewed-on: http://gerrit.openafs.org/1017 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 57aac9734c12d12b12cb0f2c83a5d97c093a979e Author: Jeffrey Altman Date: Mon Jan 11 13:59:12 2010 -0500 Windows: do not call cm_SearchCellByDNS if AFS_AFSDB_ENV is not defined cm_SearchCellByDNS is only available when AFS_AFSDB_ENV is defined. Do not call it when it isn't. LICENSE MIT Change-Id: I203ab775513bd75ff6a547c557579c0bc095d555 Reviewed-on: http://gerrit.openafs.org/1086 Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Jeffrey Altman commit 35ed0439e32b6aeffc4aee2601a08e0406302cbc Author: Jeffrey Altman Date: Mon Jan 11 13:51:42 2010 -0500 Windows: buf_Recycle should clean up flags and reset version The CM_BUF_EOF and CM_BUF_ERROR buffer flags and the buffer dataVersion should be reset within buf_Recycle() instead of by the caller of buf_Recycle(). LICENSE MIT Change-Id: I643da102553200b20f5ecc23ec43974581663a8e Reviewed-on: http://gerrit.openafs.org/1085 Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Jeffrey Altman commit edc39892cbf60eb2f918180f0b4c217ac3bd6dab Author: Jeffrey Altman Date: Sat Jan 9 00:26:37 2010 -0500 Windows: do not leak scp->dirlock if cm_BPlusDirBuildTree fails In cm_BeginDirOp, the scp->dirlock would be leaked if cm_BPlusDirBuildTree() failed. This would either result in a panic later on if lock order validation is active; or as an inability to process subsequent requests on the directory. LICENSE MIT Change-Id: I03afd0c9e6296c0f43ae39e5a7b1ff29a1619a43 Reviewed-on: http://gerrit.openafs.org/1083 Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Jeffrey Altman commit 6a96e0bf92e0a454e9d4fccf61402c033f374722 Author: Jeffrey Altman Date: Mon Dec 21 12:29:10 2009 -0500 Windows: alter nmtest CreateFile modes Change -r to open the file for FILE_SHARE_READ Change -w to open the file for FILE_SHARE_WRITE Change -w to open the file twice. Once for sequential access and once for random access. LICENSE MIT Change-Id: I295a7e7408e7e7eac06901108a726fe9e94bf18f Reviewed-on: http://gerrit.openafs.org/1016 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Jeffrey Altman commit 6f4ed82da9d941ac303eb2f886f95d97828119bc Author: Jeffrey Altman Date: Tue Dec 8 09:38:53 2009 -0500 Windows: return ENOMEM from cm_BPlus functions on malloc failure There are several cm_BPlus functions that do not return an error code on malloc failure. LICENSE MIT Change-Id: I3a3d78cc6d6844c78e51fa81ebf330f5af88a7a5 Reviewed-on: http://gerrit.openafs.org/900 Tested-by: Jeffrey Altman Reviewed-by: Rod Widdowson Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Jeffrey Altman commit 987f3bf9c7420bb555eccde3b7407080a760b641 Author: Simon Wilkinson Date: Sun Nov 22 23:31:00 2009 +0000 Use dget_parent to handle getting inode of parent We can't safely do dp->d_parent->d_inode to access the parent inode of a given dentry. Instead, use dget_parent() to get safely get a reference on the parent dcache, and access the inode using that reference. Dispose of this reference with dput() as appropriate. Change-Id: Ic4f2159f68f95744bca08ebc99ecd5f45dc46966 Reviewed-on: http://gerrit.openafs.org/1075 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 90f91f4464f5785290040436b2d8cbe4b8ed5810 Author: Matt Benjamin Date: Mon Jan 4 21:31:27 2010 -0500 freebsd: CM changes targeting RELENG_8 Force all vnodes onto the fs mount queue when allocated. This fixes a long-standing vnode recycling problem. Don't call vgone() on a vnode whose refcount is 0. Always destroy vnodes in VOP_RECLAIM. This is work in progress towards fixing old reclaim bug mentioned in Rees comment. Hold vnode returned from gop_lookupname_user in afs_pioctl_syscall, to avoid it going inactive before we're finished. Also unlock it if necessary. Don't use custom vop_lock impl when AFS_FBSD80_ENV. Remove duplicate conditional code in vnode pretty-print (old cruft). Also don't format fid members as hex. Revert vn_lock exclusve in osi_VM_StoreAllSegments (fixes deadlock introduced by me in a 2009 changeset). Remove unused variables in osi_VM_StoreAllSegments. Change-Id: I9fd146d6f405382a20a75523ec2b75c62ac6d17a Reviewed-on: http://gerrit.openafs.org/1068 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 7c24f660474dea82a96e6c65883e53c9ad77379f Author: Andrew Deason Date: Thu Dec 17 13:59:57 2009 -0600 DAFS: avoid saving fileserver state when panicing When ShutDownAndCore is called with dopanic=1, avoid trying to save fileserver state. When we are panic'ing it is very possible that the thread that called ShutDownAndCore is one of the background threads we are waiting for, or that the calling thread is holding H_LOCK. Since we are panicing, the fileserver state is probably not consistent anyway, so just avoid trying to save state altogether, and avoid a possible deadlock. Change-Id: If727808bfdfda74a4ec0e65b27ef9c77fbee4aae Reviewed-on: http://gerrit.openafs.org/997 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit fe07f017f75b2ce0f783bbd8f31eb5b1bcd7c61b Author: Andrew Deason Date: Fri Nov 6 14:05:16 2009 -0600 DAFS: Allow non-fileserver to schedule salvages Allow non-fileserver programs to schedule salvages through the fileserver via FSSYNC (VOL_FORCE_ERROR with the FSYNC_SALVAGE reason code). Also make the volserver schedule salvages this way when it encounters the appropriate errors. FIXES 124484 Change-Id: I03ecf6302436c35fec705cd6c84a40b7cdbf6f97 Reviewed-on: http://gerrit.openafs.org/787 Reviewed-by: Andrew Deason Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit 9a08865c36013e7e2c6b564588f5a2a6b2a9fd1e Author: Simon Wilkinson Date: Fri Jan 8 17:29:16 2010 +0000 Revert "Linux: Replace invalidate_inode_pages" This reverts commit 40719534d5d906f97a6ae7d28a00289270daf2a6. RHEL5 kernels publish the invalidate_mapping_pages symbol as EXPORT_SYMBOL_GPL, so we can't use it with them. For now, revert this change - we can live with the deprecated warning at present... Change-Id: I22875683e643c4184bb2c1e06f37d4c6eb9ea0be Reviewed-on: http://gerrit.openafs.org/1082 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 165571947be770645900bb8d55ba7b6a3c58f8fd Author: Derrick Brashear Date: Mon Jan 4 17:57:30 2010 -0500 linux kernel lacks uintptr sadly only recent kernels include uintptr_t. change the cast to use unsigned long Change-Id: Ib69f7aa0f2d316c5ea8bdc960b15ee0f89f96250 Reviewed-on: http://gerrit.openafs.org/1059 Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 708dc955012334fc9ada5fad576cfecd33edb326 Author: Chas Williams - CONTRACTOR Date: Thu Jan 7 17:48:15 2010 -0500 UNIX CM: remove the last remaining reference to afs_rxglobal_lock Somehow this was missed earlier. Change-Id: Iebebdb90cb42cc9ef716409af435509916e4ab58 Reviewed-on: http://gerrit.openafs.org/1078 Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit f72207d8c48bfa087bd677e3966e82952c25fd83 Author: Chas Williams - CONTRACTOR Date: Thu Jan 7 17:35:20 2010 -0500 LINUX/: ifdef for GFP_NOFS conditionals Remove the conditionals in the linux 2.6 tree for GFP_NOFS. This feature has existed since the beginning of the 2.6 tree. This makes the code easier to read. Change-Id: Ib42af012c57912f72effb836743ab8f1ddc30486 Reviewed-on: http://gerrit.openafs.org/1077 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit fcce9a4727d80762552c10075b03a48ecd40edac Author: Derrick Brashear Date: Sun Jan 3 19:01:47 2010 -0500 darwin module prototype and cleanup tidy up the osi_module and osi_misc prototyping, and the error checking and returns at module load time. side effect: also use the afs3_syscall prototype for the BSDs. Change-Id: I373f44f3b5999dc05ba23f09c74149aaf237edcc Reviewed-on: http://gerrit.openafs.org/1056 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 8f689aec1499fa0c8d1b49cff1a51a9f0dcd8890 Author: Dan Hyde Date: Wed Jan 6 10:49:39 2010 -0500 volmonitor copy link before calling free Copy tt->next before TRELE(tt) calls free(tt). We have a core file from a VTRANS_OBJ_LOCK(tt) assert failure, with tt pointing into glibc's malloc data structures. Change-Id: Id52b774520c59c224b58f5d507cc490dafea5ca1 Reviewed-on: http://gerrit.openafs.org/1069 Reviewed-by: Andrew Deason Tested-by: Andrew Deason Reviewed-by: Thomas L. Kula Reviewed-by: Michael Meffie Reviewed-by: Dan Hyde Reviewed-by: Derrick Brashear commit c37b9230c5ce845483d573efbb19e41d5b5cc48f Author: Simon Wilkinson Date: Wed Jan 6 15:43:18 2010 +0000 Linux: Mark our super block as not updating access time We don't update access times, so mark our mount options as such. FIXES 126084 Change-Id: Ic1591b943288dae45267676046f78e02c306ec08 Reviewed-on: http://gerrit.openafs.org/1071 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit e34702ef89649df47745121f45df32bec1f2fccb Author: Simon Wilkinson Date: Wed Jan 6 15:12:32 2010 +0000 Linux: Use the correct ATIME flag Since Linux kernel 2.4.0, MS_NOATIME has been a super block flag, and S_NOATIME has been the corresponding inode flag. Use the correct flag when we're opening cache files. FIXES 126084 Change-Id: I69cbcd651584cc86568c51793dd3f6d3e8644709 Reviewed-on: http://gerrit.openafs.org/1070 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit b2433a3e4cf08e2c489100ea6c7a676712e25369 Author: Derrick Brashear Date: Tue Jan 5 00:14:26 2010 -0500 cachemanager additional cleanup integrate support for additional cachemanager cleanup. free volume, server, unixuser objects. cleanup messages printed at shutdown. zero/null/init additional locks and structures. FIXES 126069 Change-Id: Id00219b679a0b4ad15ca06fc16335b0e4282e0eb Reviewed-on: http://gerrit.openafs.org/1065 Tested-by: Derrick Brashear Reviewed-by: Marc Dionne Reviewed-by: Derrick Brashear commit c03980f710a9b169f68ce72a2f00b1a414c0ad2d Author: Derrick Brashear Date: Mon Jan 4 13:44:48 2010 -0500 macos code signature for afsd this is a dodge; we should sign with a real certificate and distribute signed binaries. until we more formally exist, this allows application firewall to at least cope better with us. Change-Id: I84d18f72f7b9a42f4eb41f86e2e6dc1ae54f662a Reviewed-on: http://gerrit.openafs.org/1057 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 6e82a621e6ddfe6b38c42f8302168b2b58502522 Author: Andrew Deason Date: Fri Dec 18 12:17:41 2009 -0600 Refuse to attach inode partitions with UFS logging Partitions with the 'logging' UFS mount option are known to cause corruption when using the inode fileserver backend. So, if we detect that we are attempting to attach a 'logging' partition, refuse to attach it. Change-Id: I0ee23b9935ac6ffc66e6228fe03d6bbfb5d64574 Reviewed-on: http://gerrit.openafs.org/999 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 94ff83fee835f6d6c43d1907daee7c0e1567ff52 Author: Marc Dionne Date: Mon Jan 4 19:37:40 2010 -0500 Linux: don't oops on writeback if vcache has no stashed credentials When doing writeback, use current credentials if we can't find stashed credentials in the vcache entry. This is normally stashed in afs_open, so it's not clear how we get to that point, but that's not a reason to trigger an oops. Change-Id: I60937e3f9e360e68ea84205570c05cabb47ef08e Reviewed-on: http://gerrit.openafs.org/1063 Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 747a8c0642aeaef814d953d16968fb5026e1ec69 Author: Michael Meffie Date: Tue Dec 29 13:40:15 2009 -0500 viced: allow alternate addresses on the same hash chain again Revert the logic meant to prevent duplicate entries in the host address hash table so hosts with multiple addresses can be stored in the same hash bucket again. Add a new log message to show when the host cannot be stored in the hash table because of an address-port pair collision with a host already in the hash table. Change-Id: I24bf48b912dcf3062201691b446372d78de9bc14 Reviewed-on: http://gerrit.openafs.org/1046 Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit daff4006627fc88be85dade3d72aa45e57a6804a Author: Simon Wilkinson Date: Tue Jan 5 00:14:06 2010 +0000 Fixes for supergroups on Darwin 64bit Some fixes needed to make supergroups build on 64bit Mac OS 10.5 Change-Id: I1aea100b138a8212010dd9f511377c993589977f Reviewed-on: http://gerrit.openafs.org/1060 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit e4eb19cdc03c4f31ed1d4cefcd01163036ed8c6d Author: Jeffrey Altman Date: Wed Dec 30 11:32:58 2009 +0000 Unix CM: Use xdr_free to free memory allocated by XDR In src/afs/afs_volume.c VL_GetAddrsU() returns memory allocated by the xdr package. In 1.4 there was no method of freeing this safely. On the head there is using the xdr_free() function. FIXES 124937 Change-Id: I72b8333e02e0e58dd16d25e9ed258a2551cdef9d Reviewed-on: http://gerrit.openafs.org/1047 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 54c4ce48bf4883ee4f1cb8db8899d754baef9c34 Author: Matt Benjamin Date: Wed Dec 30 19:19:09 2009 -0500 freebsd: fix afs_root signature (RELENG_8) Track removal of thread id param, which had become redundant. Change-Id: Ifa8ddce411373a1aee01b577bf7e5a268e644dd7 Reviewed-on: http://gerrit.openafs.org/1055 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit a5d054668a8ec5f0cff2e446512a7d027fc65343 Author: Marc Dionne Date: Thu Dec 31 11:08:32 2009 -0500 Build fix: restore centry in ptutils.c The declaration of centry is needed when supergroups are not enabled. Restore it within the ifdef so that we don't get an unused variable warning if supergroups are enabled. Change-Id: I0e7916b7898cdd5c47accb7f185764bbb1f2e94d Reviewed-on: http://gerrit.openafs.org/1054 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 4d6d7866689a2c005a055c580b8a54d7c9412386 Author: Russ Allbery Date: Wed Dec 30 16:22:37 2009 -0800 Remove warnings from supergroups code on x86 Prototype functions where necessary, remove unused variables, fix mismatches of data types (char * != void *), initialize variables the compiler can't tell are initialized, compare integers against 0 and not NULL, and wrap assignments used as conditions in an explicit comparison. This removes all warnings that fail --enable-checking on x86 with --enable-supergroups. 64-bit will still have warnings. Change-Id: I5ab6e317a280bea29cb44b97f2805a00e387577f Reviewed-on: http://gerrit.openafs.org/1050 Tested-by: Russ Allbery Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear commit 1526593621f78efaf2b37e4ac25a2944b6099920 Author: Russ Allbery Date: Wed Dec 30 20:30:27 2009 -0800 Correct spelling errors in man pages Correct several spelling errors in the man pages detected by Debian's Lintian package checking tool. Change-Id: I3834a12776ec5e27b04d80fbfcc43ffe71cf1790 Reviewed-on: http://gerrit.openafs.org/1051 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 64cacab28ba7b9692db0b494e2d4399c535bd1ae Author: Matt Benjamin Date: Tue Dec 22 19:48:02 2009 -0500 freebsd: track RELENG_8 Fixes to re-enable build and load of kernel module on FreeBSD's RELENG_8. Includes the following changes: Remove cred pointer argument to vop_getattr and vop_setattr. Restore VSUID and VGUID defines, but move to osi_machdep.h. Fixup calls to vinvalbuf, create a macro to avoid too many ifdefs. Revert incorrect definition of gop_lookupname_user. Avoid uninitialized use of 'code' variable in vop_access, and track new a_accmode member name. Remove cred pointer in VFS_STATFS. Avoid including sys/ioctl.h in kernel mode (formerly had no effect, it's now an error). Avoid using an empty file as an object file in shlibafsrpc link. Replace suser() calls with calls to priv_check, using defined OpenAFS privileges (thanks due to Ben Kaduk). Change-Id: I96fc29599a797b975630c8fa5b8b84798b3740a6 Reviewed-on: http://gerrit.openafs.org/1023 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit e4708157ea55ef79d1c3a5387859618bdba90395 Author: Simon Wilkinson Date: Sun Dec 27 11:28:43 2009 +0000 Linux: Check for multiple silly renames We don't want to do multiple silly renames of the same dcache entry, so add a check for that occuring, and just return EBUSY if we're trying to do so. Change-Id: Ic1cb4061d89bf87926995162f1ac410375bddcb5 Reviewed-on: http://gerrit.openafs.org/1035 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit ec352e0bfd6f324c6b95a3b1e816809c24004e84 Author: Simon Wilkinson Date: Sun Dec 27 11:06:01 2009 +0000 Abstract out Linux sillyrename function In order to keep the dcache happy, the Linux client has its own sillyrename function. Abstract this out from afs_linux_unlink into a function of its own (afs_linux_sillyrename) so we can make use of it from other vnodeops. Change-Id: I298251c400dfc22efb3bacaa72612b28a5409112 Reviewed-on: http://gerrit.openafs.org/1034 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 35d5b6c4e101c92e2c242bb75029db24eb1aa7d7 Author: Simon Wilkinson Date: Sat Dec 26 18:22:32 2009 +0000 Remove unused configuration tests Remove configure tests that are no longer used by the build. Testing for unused features just slows down the configuration process. Change-Id: I18e161e8e608a69801c53980e545c3077a7578d7 Reviewed-on: http://gerrit.openafs.org/1033 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 16a824222ba1ecdee4734659d76680bf4f61695a Author: Simon Wilkinson Date: Thu Dec 24 18:19:01 2009 +0000 Remove HAVE_STRUCT_BUF test Ever since b1edf891d717ee8e08c0d93738a204cff09cf68f was committed, we've not needed to test to see if the OS provides struct buf - we can just declare it as a structure without providing a definition in all circumstances. Change-Id: I81ebad0dcda91229883f44b657e8113ec832668d Reviewed-on: http://gerrit.openafs.org/1032 Tested-by: Andrew Deason Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f54588201488fe1038f52546853c7c2082ff069a Author: Simon Wilkinson Date: Thu Dec 24 15:35:47 2009 +0000 Remove --disable-full-vos-listvol-switch option Remove the --disable-full-vos-listvol-switch configuration option, and the corresponding #ifdefs. Full output from vos listvol is now always enabled. Change-Id: Ib4900cc0a8532b3db31d13d34fe59946b34e86ed Reviewed-on: http://gerrit.openafs.org/1031 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 5364fada4e4eb48dcb72cd0802b8486bee3228c9 Author: Simon Wilkinson Date: Thu Dec 24 15:14:46 2009 +0000 Remove --disable-afsdb Remove the --disable-afsdb option from configure, and the corresponding AFS_AFSDB_ENV #ifdefs from the code. This means that the AFSDB code will always be built, but whether it used or not can still be controlled by runtime options in the cache manager. Change-Id: I1378c4626568e02345c7c400804747c446078c7e Reviewed-on: http://gerrit.openafs.org/1030 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 0fce88e07934899eb2dfcff87ec289e0d4f683eb Author: Derrick Brashear Date: Tue Dec 29 11:29:09 2009 -0500 clean up axscache at shutdown modify allocations in axscache code to be able to be tracked. at shutdown, clean up allocations. Change-Id: I1fbde0fe49cf0cdeea451dac58718a90f1c87e66 Reviewed-on: http://gerrit.openafs.org/1037 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit d11ca53be7d80096c21b777ec04e1874bed870d9 Author: Andrew Deason Date: Wed Dec 30 11:44:39 2009 -0500 Make DAFS 'bos salvage' work in restricted mode bosserver currently has code to specifically allow 'bos salvage'-initiated salvages to run when in restricted mode. This only specifically tests for running salvager, though, and so fails when 'bos salvage' is run against a DAFS fileserver and tries to run 'salvageserver -client' instead. Test for 'salvageserver -client' as well, so we can run 'bos salvage' for DAFS fileservers in restricted mode. Change-Id: I27052a440ea8d6347a9d86e4a1f1a7131a277b0b Reviewed-on: http://gerrit.openafs.org/1048 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit 12f35e84934015251ec4e0171d302e7f10f894c2 Author: Simon Wilkinson Date: Thu Dec 24 14:34:42 2009 +0000 Remove --disable-largefile-fileserver Make largefile fileservers the only option. Remove all of the AFS_LARGEFILE_ENV ifdefs, and tidy up some code as a result of this change. Change-Id: I126f7dc5505bbdb28c9337dcd2e81403045707f4 Reviewed-on: http://gerrit.openafs.org/1029 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear Tested-by: Andrew Deason commit f085951d39c0d6c1e6a626177c30235704317600 Author: Simon Wilkinson Date: Thu Dec 24 13:00:53 2009 +0000 Turn on bos restricted code Remove the #ifdef's around the bos restricted mode code. This makes restricted mode available as part of the standard build, but a server will not go into restricted mode unless the relevant command line options are specified, or bos setrestricted is run. Document bos_setrestricted and bos_getrestricted, and the new '-restricted' command line option. Add a note to the man pages of all of the commands whose behaviour is affected by restricted mode. Add 'setr' and 'getr' aliases for setrestart and getrestart so that these documented shortcuts continue to work (otherwise they'd be ambiguous against setrestricted and getrestricted). Note that setre, setres, and setrest will not work once this patch is applied. Change-Id: Ie69d21493ea5f78757f0a3d478de43fdaabd3c31 Reviewed-on: http://gerrit.openafs.org/1028 Reviewed-by: Michael Meffie Reviewed-by: Andrew Deason Tested-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit bd4c636e9169cc098696916a40da1301c3100d88 Author: Russ Allbery Date: Wed Dec 30 20:33:14 2009 -0800 Update .gitignore for copied rxkad files src/rxkad/Makefile copies fcrypt.h and sboxes.h from the domestic subdirectory, so ignore the copies in the src/rxkad directory. Change-Id: I263c8f5ea45c3c6b32bc377f6451424477d255a2 Reviewed-on: http://gerrit.openafs.org/1052 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit c45e2b374b7fd03863e82e013fee6bc8821717a1 Author: Simon Wilkinson Date: Tue Dec 29 22:48:39 2009 +0000 Linux: #if BLAH should be #if defined(BLAH) As the subject says, using #if BLAH gives warnings. Fix them in osi_ioctl.c Change-Id: Iee3da68cd29e84bd201a1ee657d3f80ca9b2f5d5 Reviewed-on: http://gerrit.openafs.org/1041 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit dab6cbadd666f83ebaf597b5fe228525ad65bed3 Author: Michael Meffie Date: Wed Dec 30 13:02:31 2009 -0500 missing brace in afs_get_sb Fix a syntax error when GET_SB_HAS_STRUCT_VFSMOUNT is not true so we can build on older versions of linux. Change-Id: I85aac803f68c3f3729abd32dfcecbc20ccac8ab9 Reviewed-on: http://gerrit.openafs.org/1049 Reviewed-by: Simon Wilkinson Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 187630ed3e2fa65c8c49143da0b99b91450a6c5e Author: Simon Wilkinson Date: Tue Dec 29 17:06:42 2009 +0000 Unix: Rename aklog_main.c as aklog.c Now the reasons for having aklog_main.c separate from aklog.c have gone, rename the file so we've just got aklog.c Change-Id: I32e34be246a5357be25ab93328d434c396483042 Reviewed-on: http://gerrit.openafs.org/1038 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit da8c26533d101f5e90d7c2d829441c0f2c48a63b Author: Simon Wilkinson Date: Tue Dec 29 17:03:50 2009 +0000 Unix: Merge aklog with aklog_main Historically, aklog was split into aklog.c (which just contained a wrapper) and aklog_main.c, which did all of the hard work. Now that we've purged all of the Windows code from aklog_main.c, we can merge them both into the same file, so do so. FIXES 20884 Change-Id: Ifdcb33f4eb2b26703c833056882d95f7f0f654b1 Reviewed-on: http://gerrit.openafs.org/1036 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 6ec18461649d3e4f44b2476f886bcc480c456500 Author: Derrick Brashear Date: Thu Dec 17 15:33:42 2009 -0500 avoid leaking stat info if a file is already CStatd we just copy out the information without doing access checks. add an access check. Change-Id: I94d1dc118189b19759d8e9635988c40f38026cbb Reviewed-on: http://gerrit.openafs.org/995 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit 6c9d49d096017f15306d0c9256f6dc2d933f001e Author: Andrew Deason Date: Tue Dec 29 15:45:51 2009 -0500 Return a cell name from afsconf_LookupServer Previously, afsconf_LookupServer could not meaningfully return a cell name, since a char* was passed in for realCellName, and afsconf_GetAfsdbInfo was expecting the value of the pointer to change. Change afsconf_LookupServer to take a char**, and pass realCellName by reference, so we can get a cell name back. Change-Id: Ib945fcb4be482ee155cdd1dcd62fe577c002082d Reviewed-on: http://gerrit.openafs.org/1039 Tested-by: Andrew Deason Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear commit 87de027fa430f67bd92153feedfc3fbab54c4c64 Author: Simon Wilkinson Date: Tue Dec 29 21:56:36 2009 +0000 Fix ioctl32 inclusion on Sparc 64 ioctl32.h only became available in Linux 2.5.44, so reduce the scope of the include. It went away again, in Linux 2.6.22. In its short life, it only ever provided prototypes for registering translation handlers, and for sys_ioctl. Only include it where we call those handlers, and when we call them, to remove compilation errors for Sparc64. Change-Id: I7816bd8b1e18ead68f7e5078e684d60bf59ac470 Reviewed-on: http://gerrit.openafs.org/1040 Reviewed-by: Russ Allbery Tested-by: Russ Allbery Reviewed-by: Derrick Brashear commit 99d007067329e451b99058e94f7a76e37b3dbdcd Author: Simon Wilkinson Date: Wed Dec 30 01:39:26 2009 +0000 Documentation: Fix asetkey syntax To set a key, use "asetkey add", not just "asetkey" FIXES 125430 Change-Id: Ifa381ec95f9253bcc5c7a1d374fbf88408f82f67 Reviewed-on: http://gerrit.openafs.org/1045 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 40719534d5d906f97a6ae7d28a00289270daf2a6 Author: Simon Wilkinson Date: Tue Dec 29 22:58:56 2009 +0000 Linux: Replace invalidate_inode_pages invalidate_inode_pages is now marked as deprecated in the kernel headers. Use the equivalent call to invalidate_mapping_pages() which has been available since Linux 2.5 Change-Id: I58de20e16874bb06991320b26bc6ce63685b8bb4 Reviewed-on: http://gerrit.openafs.org/1042 Reviewed-by: Russ Allbery Tested-by: Russ Allbery Reviewed-by: Derrick Brashear commit acd1bcf7267ea800ee4e3a19761105482a24f7b6 Author: Simon Wilkinson Date: Wed Dec 30 01:04:23 2009 +0000 Documentation: vos dump -verbose outputs to stderr vos dump -verbose sends its logging to stderr, not to stdout (where it would potentially collide with the dump data itself). FIXES 124911 Change-Id: I515c50df59d2f376787969df59b6e01e244ecbc7 Reviewed-on: http://gerrit.openafs.org/1044 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 10c00e1f17ceb0c74c074593d09633b6c0e51278 Author: Simon Wilkinson Date: Tue Dec 29 23:20:36 2009 +0000 rxgen: Remove stray debugging statement A stray "Printing ex_req" slipped into the last set of rxgen changes. Remove the unnecessary debugging statement. Change-Id: I2dda4138d70bf3429122f58bbbae996b84baefac Reviewed-on: http://gerrit.openafs.org/1043 Reviewed-by: Russ Allbery Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 9f1c90a6e0004bda153e9e077dc68381b2beec13 Author: Andrew Deason Date: Thu Dec 24 13:32:14 2009 -0500 Move TOP_INCDIR/des dependency to prelude Make TOP_INCDIR/des a dependency of the 'prelude' target, not all of the 'dest'-ish targets. Without this, things like 'make tviced' fail since we never create the TOP_INCDIR/des directory, but 'des' needs to copy headers into there. Also, remove the other redundant INCDIR/LIBDIR deps in the 'dest'-y targets, and put them in 'prelude'. Change-Id: I1beb1a0c8b93a7bf17af71792ab38590d03c9976 Reviewed-on: http://gerrit.openafs.org/1027 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 1f23ff72e9d0b555c44dca90a92c6379e5d52f3a Author: Andrew Deason Date: Thu Dec 17 15:16:50 2009 -0600 Check viced FetchData length for cache bypass Same fix as change I413393a7bacbf207332d7f904cf396c79b77b6b5, but for the cache bypass code. Change-Id: Ic181e257f7d0e1892bd10bf14d8d5571b4804d63 Reviewed-on: http://gerrit.openafs.org/1000 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit 9651fd726f8cc5d7b2ebdadf48b7e22bf25d1715 Author: Andrew Deason Date: Wed Dec 23 15:23:30 2009 -0500 Fix warnings in fs.c with --enable-cache-bypass Fix some warnings in src/venus/fs.c so we can compile with --enable-cache-bypass and --enable-checking: -- Include ctype.h so isdigit gets a prototype -- Make BypassThresholdCmd have the proper signature -- Remove the unused 'size' variable Change-Id: I09afc6c04c990476226d1c2a751e23d3d39085b6 Reviewed-on: http://gerrit.openafs.org/1025 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 2c0a9ab3c361ade9218c2f458d86165de8eadc76 Author: Simon Wilkinson Date: Tue Dec 22 21:46:43 2009 +0000 Solaris: Don't access lbolt directly Recent changes in OpenSolaris have removed the 'lbolt' variable. However, the ddi_get_lbolt accessor (which has been present since Solaris 10) can be used to get access to the same value. So, use it. Change-Id: I7a72bab14b0226fb25adb642f3621512e02ca216 Reviewed-on: http://gerrit.openafs.org/1022 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit dd9ab4b84c0bad163ccef8c3d24554e19f005cb1 Author: Simon Wilkinson Date: Tue Dec 22 21:42:19 2009 +0000 Solaris: Don't directly fiddle with the groups structure Solaris doesn't let us directly play with the groups structure anymore. Instead, there is a crsetgroups accessor which can be used instead. So, use it. Change-Id: I4d5b99110318630c8a7744812476e1941c117381 Reviewed-on: http://gerrit.openafs.org/1021 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 0f0f6cd613fe1084af948f1765a5e7e0772b117d Author: Simon Wilkinson Date: Tue Dec 22 21:38:00 2009 +0000 Solaris: Be more flexible about compilers OpenSolaris doesn't have its C compiler in /opt/SUNWspro/bin/cc, but we still have to be careful to avoid gcc, as that can't build the kernel module. As a short term stop gap, add a PATH_PROG test which looks in both /opt/SUNWspro/bin and /opt/SunStudioExpress/bin for cc. We probably should look in more places, and in the long run, we should probably be taking whatever autoconf gives us (for userspace, at least) Change-Id: Ie31cf1bf474650a081fc101a2aa40cfa6bd39423 Reviewed-on: http://gerrit.openafs.org/1020 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit b631f5d64c629f5cda8ca02d859a089dca0a71fe Author: Simon Wilkinson Date: Tue Dec 22 21:34:23 2009 +0000 Look for aclocal in more places Some operating systems (cough, OpenSolaris, cough) have multiple versions of aclocal installed, and don't populate the 'aclocal' name. If 'aclocal' isn't present, then try using 'aclocal-1.10' before we give up in disgust. Change-Id: Iad6daf1038942aeee13f38cb0c00c58da621cfd1 Reviewed-on: http://gerrit.openafs.org/1019 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 2ec18e9f7adb8a5916e54cd9f45e5e6db6408de9 Author: Andrew Deason Date: Tue Dec 22 09:49:21 2009 -0500 Fix typo in afs_linux_cred_is_current 987816dfa852750caca8c64c44174a5333ae0e3b introduced a stray 'cred' in one of the afs_linux_cred_is_current definitions. Remove it so we can build without STRUCT_TASK_HAS_CRED. Change-Id: I7ef94c1c3d15a2a744755d8a20ec2b0c92cd5349 Reviewed-on: http://gerrit.openafs.org/1018 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 846f772601114dc57ddba934fbdca2b2f2a4aa31 Author: Michael Meffie Date: Thu Dec 10 16:13:45 2009 -0500 Prefix global defines Prefix constants relocated to the common afs_consts.h header to void naming collisions. Change-Id: Ib657e00385002c957b40b36058f260c6cabd108c Reviewed-on: http://gerrit.openafs.org/905 Reviewed-by: Mickey Lane Tested-by: Mickey Lane Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 2b8e09315c6f08f3972754b3ea0b6847b1f12d25 Author: Michael Meffie Date: Thu Dec 10 11:37:34 2009 -0500 Consolidate duplicate definitions Housekeeping change to consolidate some common definitions. Create a new common header called afs_consts.h. This allows us to remove the afscp.c dependency on afs.h (so src/tests will build again.) Rename the max filename definition in the update server package to MAXFNSIZE to avoid a name conflict with MAXSIZE. The global defines will be prefixed with AFS_ in a second patch. Change-Id: I2b8d555a244cc92d889618de4eec4a99550d7c7f Reviewed-on: http://gerrit.openafs.org/855 Reviewed-by: Mickey Lane Tested-by: Mickey Lane Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 9bbd7a211761db6bd9c9412037a35d3024af26cc Author: Marc Dionne Date: Sun Dec 20 08:30:07 2009 -0500 Linux: fix sysctl for 2.6.33 The sysctl patch for 2.6.33 was a bit overzealous and ifdef'ed a few lines that it shouldn't have. Change-Id: I7033259e567a06ce05b968366e810c5b2688c271 Reviewed-on: http://gerrit.openafs.org/1011 Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 36f97969f39637042a54c0d45877a48cc9dfcac1 Author: Marc Dionne Date: Sat Dec 19 22:22:05 2009 -0500 Linux: utsrelease.h is moving In kernel 2.6.33, utsrelease.h has moved to include/generated. Adapt the configure code to consider that location, and clean up that section's indentation. Change-Id: I5061043ff7f46875a39953b11c472693650c7485 Reviewed-on: http://gerrit.openafs.org/1009 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 846c28282fb4ccd2136e3e27b60b9363ea7f759e Author: Simon Wilkinson Date: Sat Dec 19 21:53:54 2009 +0000 Fix PAGs for all platforms without Linux keyrings The changes in 7b272177de4c6f78db7f2315f4e30e85ab7660bb sadly break all platforms which aren't Linux. This is because the logic in PagInCred doesn't handle the non-Linux case at all. Fix this so that we call afs_get_group_pag whenever we're not running on Linux. The code also doesn't match the comment - Linux kernels which don't have keyrings should use afs_get_group_pag(), regardless of whether STRUCT_TASK_HAS_CRED. It's unlikely this bit would ever bite anyone though, kernels with cred support almost certainly require keyrings. Change-Id: I5373da51151229dc13b6dc60c3cf10700f0f881a Reviewed-on: http://gerrit.openafs.org/1006 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 987816dfa852750caca8c64c44174a5333ae0e3b Author: Simon Wilkinson Date: Sat Dec 19 20:21:36 2009 +0000 Linux: Simplify keyring compatibility code This introduces a few inline functions in osi_compat.h, to reduce the number of #ifdefs in the main chunk of code. In particular, we gain * afs_linux_key_alloc : to handle all the different key_alloc signatures * afs_linux_search_keyring : to handle our two different mechanisms for searching a keyring * afs_linux_cred_is_current : will return true if we're using native credentials, and the passed creds are also those of the current task Change-Id: I138f3533a7e8e88e04e4b5508158e003882d63ee Reviewed-on: http://gerrit.openafs.org/1005 Reviewed-by: Marc Dionne Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit cda45cc7a11495c1acc5a5ebbac1474f3eb5a6bd Author: Simon Wilkinson Date: Sat Dec 19 15:40:49 2009 +0000 Linux: Don't panic when keys aren't found This fixes two potential problems in our session keyring lookup code, which can lead to panics in situations where we're using the new struct cred based code. The first is that if there is no session kerying installed for the current task, we'll attempt to do a lookup on a NULL kerying and oops. The second is that if the keyring_search returns EPERM, then we can end up unmasking that error code, and return NULL, rather than an error. Change-Id: If0e2804408ec17b00f352980cee6a8e56704d93f Reviewed-on: http://gerrit.openafs.org/1004 Reviewed-by: Marc Dionne Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit 994ef0e7cab95e2fc6f47fc8838490112e432ffd Author: Simon Wilkinson Date: Sat Dec 19 14:48:32 2009 +0000 Linux: Flush vcaches when a mount fails GetVCache (well, really NewVCache) creates a new vcache, with an attached inode, and links it into the VLRU queue, regardless of whether it is successful in populating that vcache or not. The attached inode, on Linux, contains a reference to the super block of the filesystem. If the created vcache is for the root, however, and populating that vcache failes, then mount fails, and the super block is disposed of. This leaves us with a vcache in the VLRU queue which contains a reference to a non-existent inode. When ShakeLooseVCaches comes along a few minutes later, it attempts to discard this inode. However, doing so fails because the inode no longer has a valid super block. Avoid this trauma by ensuring all vcaches are disposed of before the super block goes away, in the event of a mount failure. Change-Id: I68864f1ea401d24adba76164905a17de6ab3e6ce Reviewed-on: http://gerrit.openafs.org/1003 Reviewed-by: Marc Dionne Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit c7b92a3018044f7aca4d9a77644e5c06ef64d1e9 Author: Andrew Deason Date: Thu Dec 17 14:59:44 2009 -0600 Do not trust FetchData length from fileservers Currently the Unix CM implicitly trusts that the length from a FetchData request from a fileserver will always be less than the requested length. If the fileserver sends more data than requested, we can use up more cache space than we intended, possibly exceeding the cacheinfo cache limits. Add a check for this, and return EIO to the caller if the fileserver responds with too much data. Change-Id: I413393a7bacbf207332d7f904cf396c79b77b6b5 Reviewed-on: http://gerrit.openafs.org/996 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 244397335e41bb83e4dba12bc30a7b4ec6fc6218 Author: Andrew Deason Date: Fri Dec 18 12:21:35 2009 -0600 platform target depends on cmd and vol The 'platform' target depends on cmd and vol, since on solaris non-namei, we build fs_conv_sol26.c, which depends on some volume structures, and uses libcmd. So, have Makefile.in accurately reflect that dependency so we can build. Change-Id: Ic7038f252dd069522ebfc8e72b9743c01c97d99c Reviewed-on: http://gerrit.openafs.org/998 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 9faaa2fed8c8dd0ae1c9288b1e1130bec78dc9f8 Author: Derrick Brashear Date: Thu Dec 17 09:48:06 2009 -0500 kernel ioctl32 conversion typecasting cast types to avoid a pointer from integer warning when using pointer types for sizing Change-Id: Idac76608e5352c65a13d07bfadb66d78f9db0ffd Reviewed-on: http://gerrit.openafs.org/988 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 3df80a163874c841f32c4c523fba641142e6d698 Author: Andrew Deason Date: Fri Oct 16 17:12:35 2009 -0500 Add the 'vos endtrans' command Add a command to vos to explicitly end volume transactions. These can happen if (for example) we segfault or the user ctrl-C's in 'vos' before/after a volume operation, but before we AFSVolEndTrans. Change-Id: Ie34ee1fdff917b56900f456c7cf8b1329533a7da Reviewed-on: http://gerrit.openafs.org/870 Reviewed-by: Dan Hyde Reviewed-by: Alistair Ferguson Tested-by: Alistair Ferguson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 2a69aa22c1278d62008863aabe6833954b4466c0 Author: Claudio Bisegni Date: Fri Dec 11 22:03:39 2009 +0100 OpenAFS Preference Pane Now the preference pane is fat compiled. Change-Id: I5c54555d00b16d85f01286719bbc41ea5f1fb67d Reviewed-on: http://gerrit.openafs.org/906 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 6f439ff7edc0e333d477bf7c65b291dae5d993c2 Author: Andrew Deason Date: Fri Nov 6 14:03:52 2009 -0600 Expand ProgramType enumeration The ProgramType values volumeUtility and salvager are overloaded. Expand the ProgramType enum to include more specific program types, and adjust conditionals to match. Also, instead of determining all behavior by checking programType, add some flags to be passed in to VInitVolumePackage to determine e.g. whether or not we can use the FSSYNC channel. This makes it easier to see the intent of some conditionals, and reduces the number of times a caller must lie about what program it is. Change-Id: Ic9852a35bb16a6b1f4b0aa9766de63178ecea56f Reviewed-on: http://gerrit.openafs.org/786 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 34ffc9cd7d7eed62229704ad0e1d327f076ea7b6 Author: Simon Wilkinson Date: Fri Nov 20 15:08:25 2009 +0000 Linux: Use splice to speed up cache storeback This patch adds a new cache store function for Linux, which uses splice() and direct access to the page cache, rather than doing data copies to a temporary buffer between rx and afs. It removes one copy, and some context switching, from the write codepath. One side-effect here is that it will delay storebehinds from returning control to the user. Instead of returning once the first 4k has been successfully transfered, we will wait until a cache chunk has been transmitted. This is currently unavoidable, as we can't take the GLOCK within a splice actor. Change-Id: I5b0284d67febccf099710589908fad18b808332c Reviewed-on: http://gerrit.openafs.org/903 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 292ec075d2beea2d718caa3f50929e125b1b97c1 Author: Simon Wilkinson Date: Fri Nov 20 15:03:37 2009 +0000 Rework cache store back This patch reworks the code to store data from the cache to the server, such that the entire store loop can be replaced. The idea here is that a platform which wishes to provide a different store loop, in particular one which doesn't rely upon multiple data copies, may do so simply by plugging in a new function. Change-Id: I6573c6a5c3e93a1259266e7e1a2b7bd17357203f Reviewed-on: http://gerrit.openafs.org/902 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 886801b069fab1e6fc94003221dcfe18e05ac376 Author: Marc Dionne Date: Wed Dec 9 19:06:18 2009 -0500 Linux: deal with ctl_name removal The binary sysctl interface will be removed in kernel 2.6.33 and ctl_name will be dropped from the ctl_table structure. Make the code that uses ctl_name conditional on a configure test. Change-Id: Iba0f107f299c6515e4e560d7596e6187bd68e399 Reviewed-on: http://gerrit.openafs.org/904 Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit 33a87fce6b46515c7e9e057858141cfb0c601d81 Author: Simon Wilkinson Date: Tue Dec 8 15:21:54 2009 +0000 pt_util runs on database servers Fix the pt_util manpage to reflect the fact that it is run on database servers, not fileservers. Change-Id: If2a8e5b65ef925c50eb9bfebea4e0d30c20f0970 Reviewed-on: http://gerrit.openafs.org/901 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 62a21819a1b57d006c73f84362494794651d1a37 Author: Jeffrey Altman Date: Sat Dec 5 10:51:27 2009 -0500 Windows: cm_BPlusEnumAlloc should not fail for zero entries If cm_BPlusEnumAlloc returns NULL, the caller assumes a memory allocation error. If the enumeration consists of zero entries, allocate a structure that stores zero entries. LICENSE MIT Change-Id: I8ed3811a1b3a0e4262749e110027c5d5812338b6 Reviewed-on: http://gerrit.openafs.org/892 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 2bffe725c5ebb785257555286567f128e0911cb7 Author: Jeffrey Altman Date: Sat Dec 5 10:53:03 2009 -0500 Windows: cm_BPlusDirBuildTree can fail It is possible that cm_BPlusDirBuildTree can fail. For example, the server could be marked down after a callback is obtained but before all of the directory data buffers have been fetched. cm_BeginDirOp must check for the failure, destroy the tree, and return the failure code to the caller. Otherwise, a tree with no entries may be created and marked with the current data version. LICENSE MIT Change-Id: I26fbfceaf68389a1906797b12721c49172b027ec Reviewed-on: http://gerrit.openafs.org/893 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 019ae5240691f27beaf583084fc81f4efb84b166 Author: Derrick Brashear Date: Sun Dec 6 23:44:53 2009 -0500 macos avoid dotunderbar lookups in fakestat mode cocoa tries to lookup ._ files for every object, possibly generating AFSDB queries and other fun. avoid them Change-Id: Id70b6335d4dddcb6d5628a9883b2c81193bb39d7 Reviewed-on: http://gerrit.openafs.org/896 Reviewed-by: Rod Widdowson Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 61ba8e5a88f0fa09a212b89b375167f0b4e1c70d Author: Derrick Brashear Date: Mon Dec 7 15:43:33 2009 -0500 add newline to lockprocs_prototypes.h gcc was unhappy about the lack of trailing newline. add one. Change-Id: Ie9c93bd9ed8c923ea8069fe49e7f5ddb20c28f80 Reviewed-on: http://gerrit.openafs.org/898 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 3cb49f57a34b42c9efdc24797efda053cd88be80 Author: Andrew Deason Date: Tue Nov 24 16:09:42 2009 -0500 Dump all hostFlags in hosts.dump Currently only certain flags are dumped in hosts.dump. Also dump the value of hostFlags itself, so we get more information from a host dump. Change-Id: I2d265b85e057c2d44938e1d92f4c102048c4bf1f Reviewed-on: http://gerrit.openafs.org/869 Tested-by: Andrew Deason Reviewed-by: Dan Hyde Reviewed-by: Alistair Ferguson Tested-by: Alistair Ferguson Reviewed-by: Derrick Brashear commit 5529bf9b6b6b69bbe244f1185e4842e3eca732f5 Author: Andrew Deason Date: Sun Dec 6 14:56:20 2009 -0600 Make HandleClientContext take an afs_ucred_t 5d5d18071608d9782a5d936f79215048af641410 missed one occurrence of AFS_UCRED. Make HandleClientContext take an afs_ucred_t instead of AFS_UCRED, so afs_pioctl.c builds again. Change-Id: I04c831ad262cade5da0f90fb8860174657dae4bf Reviewed-on: http://gerrit.openafs.org/895 Tested-by: Andrew Deason Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 03b5994d7bec0088d0edbfc83f5820c089ac9599 Author: Simon Wilkinson Date: Sun Dec 6 14:25:08 2009 +0000 Remove AFS_USEBUFFERS The AFS_USEBUFFERS code has been disabled for all supported platforms since the initial OpenAFS code drop. Simplify the buffers code by removing it entirely. Change-Id: Iab6b2d54361eca1a1446b4804b3d6533d75f2831 Reviewed-on: http://gerrit.openafs.org/894 Reviewed-by: Andrew Deason Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit ae1926fa95dea39dce2166583d2948c22d59f2c1 Author: Derrick Brashear Date: Fri Dec 4 19:53:21 2009 -0500 Windows: Version update for 1.5.68 1.5.6800 = 1.5.68 Change-Id: Id3bdc21e5f72ebe2047cb70c2496df2ba7300b4b Reviewed-on: http://gerrit.openafs.org/891 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit adf9baebc81dd0a1a88007a1982b889d9eefe72e Author: Derrick Brashear Date: Fri Dec 4 11:52:29 2009 -0500 unix 1.5.68 update version numbers for unix Change-Id: Ic8a42a9ca1cfc74ab2d8f8d2ac0442efa716a84b Reviewed-on: http://gerrit.openafs.org/888 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 1ad30c2ea8cd2139a14ebe698117f1dc08fb4cf4 Author: Derrick Brashear Date: Fri Dec 4 15:31:10 2009 -0500 rx packet dumper not in kernel don't compile the rx packet dumper when in kernel Change-Id: I8484f3ed80d3b97d733091901f6e252a455cefa1 Reviewed-on: http://gerrit.openafs.org/889 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b6b18f12315f648614823bafa016c422a3e0c6f7 Author: Jeffrey Altman Date: Fri Dec 4 10:52:21 2009 -0500 Fix midnight volume calculation to build on Windows Change I516d732d broke the Windows build. localtime_r does not exist on Windows. Change-Id: Ib28e414a85d763dbe146bc2fadec91310f6144ab Reviewed-on: http://gerrit.openafs.org/887 Tested-by: Jeffrey Altman Reviewed-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear Reviewed-by: Jeffrey Altman commit f48c0a20a1a5507f499260175e5308931ecd03be Author: Jeffrey Altman Date: Fri Dec 4 00:43:54 2009 -0500 Windows: Version update for 1.5.67 1.5.6700.0 == 1.5.67 Change-Id: I0f4402cdb8f387b67c93ee9066dc3be352d163c1 Reviewed-on: http://gerrit.openafs.org/886 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit ccb64bd3aacf6f1253dfe4dc3d04bb6b87e100b7 Author: Derrick Brashear Date: Thu Dec 3 23:26:18 2009 -0500 unix 1.5.67 make 1.5.67 for unix Change-Id: I1e25ec581b9b2a37230bd2a889f88f454a73ba8f Reviewed-on: http://gerrit.openafs.org/885 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit a031c900ca6eb40a914327bfc9e9cca370016d56 Author: Derrick Brashear Date: Thu Dec 3 15:37:52 2009 -0500 add rx packet trace debug dumping for unix revised version of a patch i've had for months to actually be clean. allow state of all packets to be dumped so you can see what's on what queues where. Change-Id: Ibaa692c835e9ced5e7cd3299922f5bac09344d28 Reviewed-on: http://gerrit.openafs.org/883 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear commit b98ca30c160c85834b1ad63a9d806efdd2940e61 Author: Rainer Toebbicke Date: Thu Nov 19 14:07:07 2009 +0100 Calculate midnight (for volume stats) based on standard functions The "tz" structure used with gettimeofday is not blessed by common standards and not widely supported, on Solaris for example it does not return anything useful. Calculate midnight based on standard functions (localtime/mktime). Change-Id: I516d732d4a9dd4696a524a271d806d349c074c25 Reviewed-on: http://gerrit.openafs.org/849 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 96eaa67edbe25c475836aa31921864936c271941 Author: Jeffrey Altman Date: Thu Dec 3 15:47:38 2009 -0500 Windows: change notes for 1.5.67 release Change-Id: I0eedd81fbfee98c591cfd57364bc23392ccca2da Reviewed-on: http://gerrit.openafs.org/884 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit e26926210057a6666c66825a78dbb04bf3238846 Author: Derrick Brashear Date: Tue Dec 1 16:17:49 2009 -0500 add unlock support to afscp make the afscp test client able to drop a lock on a file. additionally, make it build again. Change-Id: Ib4a5acf787f8f2e84699e1638a662068b993d965 Reviewed-on: http://gerrit.openafs.org/881 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b40b60650cf91f005990bc2e55185a4af7e2cd4b Author: Jeffrey Altman Date: Mon Aug 17 12:30:44 2009 -0400 Use xdr_alloc and xdr_free within ptuser If the memory allocation routines for libafsauthent and libafsrpc differ, callers of the ptuser routines in libafsauthent will crash. Use xdr_alloc and xdr_free in ptuser to ensure that the memory allocation routines are always consistent. LICENSE MIT Change-Id: I20fa1e1fc0677917e47e2ed9f0eaec83f23b699b Change-Id: Id31bf20b482e9502a5af79f4d86319fe530aa5a5 Reviewed-on: http://gerrit.openafs.org/319 Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear Reviewed-by: Jeffrey Altman commit 14dbe49786f2547b66a6ad38bdae0db9d1648c49 Author: Michael Meffie Date: Mon Nov 30 19:28:13 2009 -0500 shutdown_icl return type void Change the shutdown_icl return type to void to match the 1.4.x branch. Change-Id: I641abbd0f87d648c3c9de3cab4d0dd926a51eb89 Reviewed-on: http://gerrit.openafs.org/879 Tested-by: Marc Dionne Reviewed-by: Marc Dionne Reviewed-by: Russ Allbery commit d393aabca577917b107afdd42efb40cc2fdac50c Author: Andrew Deason Date: Mon Oct 26 14:09:41 2009 -0500 Correct duplicate special inodes while salvaging Right now when the salvager encounters duplicate special inodes for a volume, it refuses to salvage the volume, presumably because it does not know which inodes to use when recreating the volume header. However, this can cause the confusing state where the fileserver and various volume utilities have no problem with a volume, but the salvager refuses to salvage it and marks the volume as needing salvage. When salvaging, if we already have a volume header, and we encounter duplicate special inodes, it is likely that the special inode referenced by the volume header is the correct one. So, instead of erroring out, keep track of which inodes are referenced in the volume header, and if there are any duplicates, either ignore or delete the unreferenced ones, depending on the -orphans setting. Also be a little more verbose when logging errors in this area. Change-Id: I15e34e8f2bccdc666bb59e3730fdf8bf51624259 Reviewed-on: http://gerrit.openafs.org/736 Tested-by: Andrew Deason Reviewed-by: Alistair Ferguson Reviewed-by: Steve Simmons Reviewed-by: Derrick Brashear commit 19f0da1e44c6ac5acd22f8a2b1d9095d568d216e Author: Marc Dionne Date: Thu Nov 19 18:29:08 2009 -0500 Warning fixes - key handling Various warning fixes related mostly to the different types used to handle keys. This should clear most of the remaining warnings in this area. The technique of inline converter helpers is extended to cover a few more cases. README.WARNINGS is adjusted to reflect the current status. Fixes: - bos: define and use an inline converter from a ktc key to a bozo key - bos.c and bos_utils.c should no longer have warnings - adjust Makefile - define a ktc key to char * converter and use it in a few places - define kas key to bozo key ptr converter and use it in a few places (afs_bosAdmin) - cast a few arguments to ka_StringToKey which expects non-const pointers Change-Id: I1c19869ac232d78209126d4eeeb11af8bcb95815 Reviewed-on: http://gerrit.openafs.org/860 Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 0188cf081f3c21cc1cb467a9babeb22a52b093f7 Author: Andrew Deason Date: Sat Nov 28 22:25:27 2009 -0500 Add server prefix to utst_int.xg When compiling src/ubik/utst_int.ss.c, a warning would be produced since the server stubs are defined as accepting an rx_connection instead of an rx_call, and since the server and client RPC stubs have the same name. Give a server prefix so we can distinguish between the two, and fix the server stubs and squash the warning, similar to bd011aeee7f5dad5c61fd81a90b296c46a0b9058. Change-Id: Iebf843bcabb4cf8f4a56c6ac30d210573b58d801 Reviewed-on: http://gerrit.openafs.org/876 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit 58258ba3b89732ea825e1aff2decab54347ab92e Author: Andrew Deason Date: Fri Nov 20 14:15:28 2009 -0600 Add safety checks on all hostList traversals Currently, h_Enumerate checks that it doesn't enumerate over more than hostCount hosts, in case the hostList has a cycle or is otherwise corrupt. Add similar checks to all places in the code that loop over hostList, to prevent the code from getting in an infinite loop under H_LOCK in the case of a hostList cycle. Also, ShutDownAndCore instead of assert'ing, so we try and detach volumes first, possibly reducing salvaging time when we restart after core'ing. Change-Id: Ide1e5aca7c2c4a4af3f62bc07821db694f2f9999 Reviewed-on: http://gerrit.openafs.org/863 Tested-by: Andrew Deason Reviewed-by: Alistair Ferguson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 9bff2027cb963343778001512d5cdf00cc7094c6 Author: Andrew Deason Date: Wed Nov 25 16:23:06 2009 -0500 Add a watchdog timer for ShutDownAndCore(PANIC) Add a watchdog timer that is started when ShutDownAndCore(PANIC) is called, to ensure we actually panic and do not e.g. get stuck in deadlock. Change-Id: I9201fe7d09aeb6819beefaf1755b51129c7bda6b Reviewed-on: http://gerrit.openafs.org/873 Tested-by: Andrew Deason Reviewed-by: Alistair Ferguson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c4780421a41a05683bcec8d1092534c2ad58f341 Author: Andrew Deason Date: Wed Nov 25 10:25:14 2009 -0500 Correct include paths in fs_conv_sol26.c Make the #include paths in fs_conv_sol26.c correspond to the 36524b2ed73a2774ee1f6242208a1395be7736a8 changes, so fs_conv_sol26.c will build again. Change-Id: Ic454dae07c0fb324f8550d1281b63fe539f8d525 Reviewed-on: http://gerrit.openafs.org/871 Tested-by: Andrew Deason Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit af9d80512852c083dd25655c2f717cfd75a9dce5 Author: Andrew Deason Date: Wed Nov 25 16:47:27 2009 -0500 'Flexible client buffer growth' fallout e7c966354c428a5a5929a3db6a829ee71c8ba2fc re-introduced a usage of the 'M' lock macro variants previously removed by bab6fd227f5724c4e4ca5d0ba1dc64e21ed21f97. Use the non-'M' macros instead so we can build. Change-Id: Ie27fb8e82a7440a6952517d9a0cc1aeb8523511c Reviewed-on: http://gerrit.openafs.org/872 Tested-by: Andrew Deason Tested-by: Marc Dionne Reviewed-by: Marc Dionne Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 3138aaba25fc93ec0ef38cd1cf61100b86990e80 Author: Jeffrey Altman Date: Tue Nov 24 18:08:55 2009 -0500 Windows: Fix test for setting FILE_ATTR_READONLY When checking whether or not to enforce the unix mode bits as if they were the Windows FILE_ATTR_READONLY flag the mask 0200 is used. Make sure that the same mask is used when publishing the FILE_ATTR_READONLY flag to the smb client. LICENSE MIT Change-Id: Ia68bd17ad80341f1c14f3c0caaec8f09a0a2f3c5 Reviewed-on: http://gerrit.openafs.org/868 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit e7c966354c428a5a5929a3db6a829ee71c8ba2fc Author: Rainer Toebbicke Date: Thu Oct 29 14:52:45 2009 +0100 Flexible client buffer growth Allocates the 2k-directory-buffers for the client as needed, in small increments, rather than a fixed-length area upon startup. Change-Id: I6061b71d40284a0059e54377e3b374fee9b86816 Reviewed-on: http://gerrit.openafs.org/799 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit f716962ab41847af4450d0a361f5de9195b32ed0 Author: Jeffrey Altman Date: Thu Nov 19 18:53:56 2009 -0500 Windows: disable readonly volume versioning due to file server bug Change I17e3980184ec68e38c5186e1c9637ac6e38451fe corrects a file server bug that results in invalid volume sync data being sent to clients during bulk status rpcs. Unless this is fixed in the file servers it is not safe to use the volume versioning functionality. This patchset disables the functionality by default and permits it to be turned on via a registry value. If the client is deployed in an environment in which all of the file servers have been fixed, then it will be safe to turn this feature on. LICENSE MIT Change-Id: I0db38ffc9cdeb90db20b92adca9a42a06fed2e2f Reviewed-on: http://gerrit.openafs.org/859 Reviewed-by: Derrick Brashear Reviewed-by: Rod Widdowson Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 072d69ac27587b6d384aae52de27b6e9b83fdea3 Author: Jeffrey Altman Date: Thu Nov 19 11:35:12 2009 -0500 Windows: provide enhanced error output to aklog Add Simon Wilkinson's change from Unix aklog to Windows aklog If afs_com_err fails to describe the error, allow the krb5 error_message function try. LICENSE MIT Change-Id: I47bb6806f1076116a68967617d32d69b98a5bba9 Reviewed-on: http://gerrit.openafs.org/852 Reviewed-by: Derrick Brashear Reviewed-by: Rod Widdowson Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit c5e362a683c5a0b2e046aa62d652ff1c83e42818 Author: Jeffrey Altman Date: Thu Nov 19 18:21:39 2009 -0500 Windows: cm_TryBulkStatus processing changes move the logging of success or failure in order to try to avoid the VS8 compiler optimizing them out. merge the bulk status information if the current cm_scache_t object is flagged with an access denied failure on the last request or if it is a readonly volume. This permits us to return something valid to the directory enumeration that generated the cm_TryBulkStatus call. LICENSE MIT Change-Id: I97e9e096e2c36b0a87baaa8d728b588aaf10f153 Reviewed-on: http://gerrit.openafs.org/858 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit dac817389081d45dab15880f34d9a35c059853c9 Author: Jeffrey Altman Date: Thu Nov 19 18:19:39 2009 -0500 Windows: when assigning a new clientModTime, hold a lock The smb server modifies the cm_scache_t clientModTime without holding a write lock creating a race condition. Fix it. LICENSE MIT Change-Id: I6f110f87ef76131965da31a8bf02685480ad9641 Reviewed-on: http://gerrit.openafs.org/857 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 985a62bcf1a3315ce0460f64e56fa667a4268f1b Author: Jeffrey Altman Date: Thu Nov 19 14:18:18 2009 -0500 Windows: modify src/rxkad/NTMakefile to avoid file copies Permit src/rxkad/domestic/* files to be compiled / installed in place. This permits the tree to build after the application of change I0796fabcf83ffcd74e533624c64e138a160dd632. Change-Id: I5616c7ab9374751dcb44bb2bce37dec40e01148a Reviewed-on: http://gerrit.openafs.org/854 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 13843d852749ba081804f3af368620db7b4b7d7a Author: Jeffrey Altman Date: Thu Nov 19 18:11:06 2009 -0500 viced: set volume sync data in bulk status rpcs The bulkstatus and inlinebulkstatus rpcs have a bug that prevents the volume sync data from being set. Currently the data is being set within the for loop only when i == nfiles. The conditional of the loop is i < nfiles so the SetVolumeSync call is never performed. This patch changes the test for performing SetVolumeSync to i == 0. LICENSE MIT Change-Id: I17e3980184ec68e38c5186e1c9637ac6e38451fe Reviewed-on: http://gerrit.openafs.org/856 Reviewed-by: Dan Hyde Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 7b272177de4c6f78db7f2315f4e30e85ab7660bb Author: Marc Dionne Date: Sat Oct 24 22:10:46 2009 -0400 Linux: Keyrings PAG handling changes We can take advantage of the fact that PagInCred now receives a kernel credentials structure as an argument (including any session keyring) to make some improvements in the handling of PAGs when keyrings are in use. These changes are effective only if keyrings are in use and we have a recent enough kernel where we can use the kernel credentials structure. 1 - Search the session keyring of the passed credentials instead of the current process' to determine the PAG, if any. This was always not really correct, and now we're able to do the right thing. In some situations such as background writeback and pre-fetching, this means that we'll now do it with the right credentials, even when in a PAG. 2 - Don't use groups at all to determine PAG membership. Doing so can lead to some inconsistent situations such as the one described in RT 125198, where a process gets access through a soon to be deleted PAG. Make PagInCred look exclusively at the keyrings. Groups are still updated to try to reflect the current PAG for now, if the passed credentials belong to the current process. Note that a process can no longer get a PAG's privileges simply by adding the corresponding groups to its group list. No behaviour change for kernels prior to 2.6.29. FIXES 125198 Change-Id: Ifb171993cc9ca9d6a97fb7312909485ec0666efb Reviewed-on: http://gerrit.openafs.org/730 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 51ece42ab438295d3807180dae34963c676f170a Author: Marc Dionne Date: Sun Nov 22 14:17:19 2009 -0500 Remove "unused" warnings from lex generated files Some (f)lex generated source files produce warnings because of unused labels or variables. Since there is limited control of the source itself, just be more permissive in this particular case with -Wno-unused. Change-Id: Ice25019f8a592a25f5084e88119b68846d900033 Reviewed-on: http://gerrit.openafs.org/867 Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit 85fd4e86af2a6c8a1742774ea4126b8a7b919f3c Author: Marc Dionne Date: Fri Nov 20 17:27:20 2009 -0500 Linux: hinting removal fallout The removal of the hinting missed a few things - the prototype to afs_linux_raw_open needs to be changed, as well as a few additional call sites. Change-Id: I006540cee574bca7155d9209c2d9b6702c4f6c94 Reviewed-on: http://gerrit.openafs.org/864 Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit 8ebade0e67c62335416ba3cfd40d19d1e152de02 Author: Marc Dionne Date: Fri Nov 20 17:50:41 2009 -0500 Revert "osi_UFSOpen returns struct osi_file *" This reverts commit 4057a9941b95f7a00c57738c1810ec5abf315e97. UFSOpen shares a prototype with MemCacheOpen because of the afs_cacheOps structure. This is why a void * is used. Revert until a more complete fix can be submitted that adresses the memcache case as well. Change-Id: I2e259c08a0bfbc695260c981d29319c2bb7c93dd Reviewed-on: http://gerrit.openafs.org/865 Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 4057a9941b95f7a00c57738c1810ec5abf315e97 Author: Simon Wilkinson Date: Thu Nov 19 16:34:07 2009 +0000 osi_UFSOpen returns struct osi_file * The osi_UFSOpen function always returns a (struct osi_file *). Fix the code to reflect this, rather than casting to and from (void *). Change-Id: I3aa0bb17b547060671aa7045a8237b3926ec613f Reviewed-on: http://gerrit.openafs.org/851 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 6f803428fdb1d85021cde1606498178d557a9db1 Author: Simon Wilkinson Date: Wed Nov 18 20:07:04 2009 +0000 Remove inode hinting for dcaches The VNOP read code has always contained incomplete support for inode hinting. In theory this would let us attach open cache files to dcache structures, so that we don't have the overhead of opening the file with every read that we do. However, this has been ifdef'd off ever since the first release, and is fundamentally broken - it relied upon structure elements that just don't exist, and has no mechanism for throttling the number of inode hints that are maintained. Inode hinting also required that we store an inode number within the osi_file structure (so hint validity could be checked), which causes a problem on some modern OS's. Simplify all of this, by just removing the partial hinting support. If we want to revisit this in the future, then the code is in git, but if we _do_ feel we want to keep open cache files around, it's probably better to start from scratch! Change-Id: Ia378922f7fcc24fb27b343015dbd16818302ec10 Reviewed-on: http://gerrit.openafs.org/850 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 573cd80cd145ca2d6bbfcc48499599ec4a86c0b1 Author: Andrew Deason Date: Wed Nov 18 14:33:09 2009 -0600 Define afs_maxvcount everywhere afs_maxvcount can be referenced by non-Linux code, so define it everywhere, not just on Linux. Change-Id: I6e99b6735d58823d0809a00be42a447deb3ced89 Reviewed-on: http://gerrit.openafs.org/845 Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit dce56fb8ceff9d052ebcebd21db9e070015142ab Author: Simon Wilkinson Date: Mon Oct 26 19:58:53 2009 +0000 Fix prepare and commit_write to do the right thing Even when we're doing syncronous writeback, as we currently do for write() operations, it's important to correctly fill, and flag the pages we're writing to. Not doing so has a huge performance penalty, as it means even when we've just written a page, we have to pull it back from the backing store for a read. This code fixes prepare_write and commit_write (for RHEL5) and write_begin and write_end (for Fedora) to correctly populate and flag pages which are being written. Change-Id: Iaa2165b9b429000dcf0c6dd452e3eb8033257277 Reviewed-on: http://gerrit.openafs.org/820 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 4f91de7cf429db63bcf67466cf3fb36feb990643 Author: Simon Wilkinson Date: Sat Oct 24 15:08:52 2009 +0100 Linux: Use atomics for credential reference counts The reference count maintained as part of the afs_cred structure wasn't being maintained atomically, requiring that crfree and crhold always be called with the GLOCK held. This patch just switches to using Linux's inbuilt atomic types to maintain the reference count. Change-Id: I1787061afbb48e234b4839b38b8801168ea2f25f Reviewed-on: http://gerrit.openafs.org/726 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit b9f6a8ce1898cd90c713dc4b54a27bd1644fe47a Author: Andrew Deason Date: Wed Nov 18 15:43:17 2009 -0600 Define WCOREDUMP in salvsync-server.c Some platforms do not define WCOREDUMP. Conditionally define WCOREDUMP in salvsync-server.c, and make all of the similar WCOREDUMP defines in the tree consistent. Change-Id: I197979881ade20f6e790bf41523938089379dbe3 Reviewed-on: http://gerrit.openafs.org/846 Reviewed-by: Russ Allbery Reviewed-by: Tom Keiser Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit ca9a12c422ad2d29a0c865a2c35ea12fc71158e0 Author: Mickey Lane Date: Wed Nov 18 12:23:15 2009 -0500 Fix 2 errors in Windows release Notes Description of registry key HKLM\ SOFTWARE\ OpenAFS\ Client\ Server Preferences\ File (and \ VLDB) states "256" - should be 15 - and "ServerPreferences" should have a space between the words. Change-Id: Ia2147f920ecc023d26250efaf9815f1b09d1550a Reviewed-on: http://gerrit.openafs.org/840 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit aa9072ce40f7af11919252da82179b45481eb878 Author: Jeffrey Altman Date: Fri Nov 13 13:56:20 2009 -0500 Windows: cm_BkgDaemon requeuing only applies to BkgStore cm_BkgDaemon currently requeues failed requests for a variety of errors. It only applies to cm_BkgStore requests. The current code only supports cm_BkgStore and cm_BkgPrefetch operations. Additional background operations may be added in the future. If requeues are meant to apply to the new operations, they should be explicitly specified. Specify cm_BkgStore explicitly now. LICENSE MIT Change-Id: Iae7c5fe4f2f7bc701ebe93500626b68f49b0063f Reviewed-on: http://gerrit.openafs.org/824 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 4c58b1db9f34c220d839dd4a1b38ed11e9ce2197 Author: Jeffrey Altman Date: Sat Nov 14 16:33:31 2009 -0500 Windows: Improvements to background fetch processing Log offset and length in cm_BkgPrefetch() Convert mxheld to rwheld in cm_BkgPrefetch() now that cm_scache_t objects use rwlocks. Do not clear CM_SCACHEFLAG_PREFETCHING from within the error returns from cm_CheckFetchRange(). Let the caller decide if that is appropriate. Add CM_BUF_CMBKGFETCH cm_buf_t cmFlag to make it possible to quickly detect if a background fetch operation has already been queued for a particular cm_buf_t data range. LICENSE MIT Change-Id: I4ac9a2f84ddd64cba86612d7a2abe849bd0bec0b Reviewed-on: http://gerrit.openafs.org/827 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 87b1b849811cb4c8c7d3a7e9fd22e5a9f8b3fadc Author: Jeffrey Altman Date: Sun Nov 15 00:11:24 2009 -0500 Windows: buf_DirtyBuffersExist uses fileHashp not allp list pointer buf_DirtyBuffersExist() should use the fileHashp pointer and not the allp list pointer in order to walk the hash table list. LICENSE MIT Change-Id: Ie043647cbeec479abe0d96b3b5405130f2ba1aac Reviewed-on: http://gerrit.openafs.org/828 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 3f3a76c0ca2a6e098f337e28cdfcb39ee865446a Author: Jeffrey Altman Date: Sun Nov 15 15:48:00 2009 -0500 Windows: Permit custom version numbers and default cellname Permit custom version numbers and default cellname to be specified using environment variables. LICENSE MIT Change-Id: If72430a33d8317fcb59d2f83769193e79984046c Reviewed-on: http://gerrit.openafs.org/829 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 84cc4f2b367399cdadf544c473566c3ffa908535 Author: Andrew Deason Date: Wed Nov 18 14:14:16 2009 -0600 src/afs/afs_user.c typo Commit eb8e55bba7740a87e07ef07bb4b789e6d4e36f0d had a paren-related typo. Correct it to make afs_user.c build on some platforms again. Change-Id: Iec4634b4c0f1769c81bf9baab0d2cc53f47aaa9c Reviewed-on: http://gerrit.openafs.org/843 Reviewed-by: Marc Dionne Reviewed-by: Alistair Ferguson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 9c61e1196a4eb5131cff555fbaeb357bf2e78c1f Author: Andrew Deason Date: Wed Nov 18 14:08:49 2009 -0600 Define T_SRV when not defined for us Define T_SRV when we don't have a usable arpa/nameser_compat.h, just like we do with T_AFSDB. Some platforms like AIX do not have an easily-usable arpa/nameser_compat.h. Change-Id: I8406a3d2b1f98d0849a1739875656432869ea3c4 Reviewed-on: http://gerrit.openafs.org/842 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c42222c40e3c4ef80edcdaa34b976505ae9421ac Author: Andrew Deason Date: Wed Nov 18 14:25:48 2009 -0600 AIX: Missing brace in afs_vnop_flock.c Commit 50f6529cf1f191606f55add4cabe53fceab492ed missed a brace in the AIX lockIDSet. Add it back to make afs_vnop_flock.c build again. Change-Id: I09c5ee58ee5258fb904fd752213eb28a1e80291a Reviewed-on: http://gerrit.openafs.org/844 Reviewed-by: Alistair Ferguson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 0a8e7b15486f5baa089eef661cdf0924af736160 Author: matt@linuxbox.com Date: Tue Oct 6 08:42:51 2009 -0400 viced ihandle boost Make ihandle file descriptor cache parameters tunable, and accommodate platforms where max open files is large. Expand the fd cache hash table to 2048 entries. Raise fd cache size automatically to match configured number of lwps. NOTE: This code has been tested on Centos 5.3 x86_64, on VMWare, 2 physical, 2 logical CPUs (in tandem with viced_more_threads). LICENSE BSD Change-Id: If68eda6e1c955e026b250ca52bddf0b8383959c9 Change-Id: I5fbbec95523ea9cd9ff42dcf43f17db94c7bb161 Reviewed-on: http://gerrit.openafs.org/584 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 82c131f6c5b57c224d157e810df264b66d052ba0 Author: Simon Wilkinson Date: Wed Nov 18 11:23:06 2009 +0000 Name chunkOps structure elements Name the structure elements in chunkOps, to reduce the danger of things getting misaligned when new function pointers are added. Change-Id: I3d22130f9bd9625d836681531646b9eac75329f5 Reviewed-on: http://gerrit.openafs.org/839 Reviewed-by: Marc Dionne Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 42516f2c0bb6445c9f870cf1943efa016d66349b Author: Michael Meffie Date: Wed Nov 18 14:05:02 2009 -0500 fix for volser transaction object race conditions Spell AFS_PTHREAD_ENV correctly and fix missing pthread_mutex_init() argument. Change-Id: I9a6397ef5ba3ef7197f3d927759258be31914fd7 Reviewed-on: http://gerrit.openafs.org/841 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit a2744cab12c87a8c42ba40a9f186a1f05c6886f8 Author: Simon Wilkinson Date: Mon Nov 16 22:52:01 2009 +0000 Linux: Fix lock ordering The inode mutex (or semaphore) should be held before acquiring the alloc semaphore. Fix the lock ordering to avoid theoretical deadlocks. Change-Id: Ifc572083dc92fff51be6785b0bcc92152fab1d73 Reviewed-on: http://gerrit.openafs.org/835 Reviewed-by: Marc Dionne Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 22541ea8323434cc555d71daf3c90b66e34c7c87 Author: Marc Dionne Date: Tue Nov 17 17:59:58 2009 -0500 aklog build fix: com_err.h header Fix this build error: aklog_main.c:67:21: error: com_err.h: No such file or directory On some systems this system header is actually "et/com_err.h". Cope by checking for this at configure time and using that location if needed. Change-Id: Iaf4fb4fe157ff8e54aa043785377706eab6fb3d1 Reviewed-on: http://gerrit.openafs.org/836 Reviewed-by: Derrick Brashear Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 36524b2ed73a2774ee1f6242208a1395be7736a8 Author: Simon Wilkinson Date: Fri Nov 13 09:50:29 2009 +0000 Rationalise our include paths Our include paths are a bit of a mess. Fix these so that they're more rational, and more in line with normal coding style. In particular: *) Don't include all of the subdirectories of our top level include directory. If a file wants afs/file.h, it should include that, not "file.h" *) Try to avoid including '.' in the search path (although objdir builds make this harder) *) Don't blindly include other directories from the code tree in the search path. If a package wants another packages header, then it should get it from the include directory *) Use the convention that quoted includes ("") pick up local headers. Bracketed includes (<>) pick up ones from the top level include dir *) In directories which pull in files from multiple packages, don't blindly put all of the package directories in the search path. Specifically include the file's package directory when required The big change here is that it's no longer possible to hide a system include by placing a header of the same name in include/afs. The most common case where this was happening was for 'assert.h' Change-Id: I0796fabcf83ffcd74e533624c64e138a160dd632 Reviewed-on: http://gerrit.openafs.org/834 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit cb6681c0d189d15fb5ff0d21cf47c9ac223a98c5 Author: Derrick Brashear Date: Mon Nov 16 20:58:11 2009 -0500 ktc remove unused variable inadvertantly introduced non-linux warning (error) due to unused variable. fix it. Change-Id: Ie44013fdf2ff8e5d401f5598a7ec628fd887588a Reviewed-on: http://gerrit.openafs.org/832 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 146b732fc877a23d515191471603a9ef0a655501 Author: Simon Wilkinson Date: Fri Nov 13 16:40:53 2009 +0000 Translate messages from ktc_SetToken Error messages from ktc_SetToken weren't being passed through com_err, leading to the confusing unable to obtain tokens for cell inf.ed.ac.uk (status: 11862788). error message. Instead, call into afs_com_err here, which gives: a pioctl failed while obtaining tokens for cell inf.ed.ac.uk Much nicer ... Change-Id: Id4c7e6f6a2f52efc6ac1db9fa007ba1a452092fe Reviewed-on: http://gerrit.openafs.org/822 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit fda55b178c12bba1474ae2c63bc7b803cdc9730f Author: Simon Wilkinson Date: Fri Nov 13 16:33:52 2009 +0000 Better errors from aklog Since the great com_err fracture, aklog has only returned decent error messages from AFS, leaving Kerberos errors untranslated. Needless to say, this causes user confusion and distress. This patch uses the error display proc hook to call out to the real com_err in situations where AFS can't supply an error message, giving clearer errors for Kerberos problems. Change-Id: I8832b755beb84c593e1b2eace5c356e71a582b2a Reviewed-on: http://gerrit.openafs.org/821 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 9bfd03d723a9cf17673f40513a7adde1d503bcbc Author: Derrick Brashear Date: Wed Nov 11 19:36:01 2009 -0500 asm unexecutable stack make stack not executable in assembled files FIXES 125491 Change-Id: I396680b6877843201f6c07d5607385044abd5e74 Reviewed-on: http://gerrit.openafs.org/818 Reviewed-by: Simon Wilkinson Reviewed-by: Russ Allbery Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 65db6150246294e49e0c4a1a0e64780d040faf7a Author: Jeffrey Altman Date: Sat Nov 14 16:24:41 2009 -0500 Windows: Code signing with cross-signed certificates Permit the version of signtool.exe to be specified with the SIGNTOOL environment variable. Add the CODESIGN_CROSS_CERT environment variable to specify the cross-signed certificate to be used LICENSE MIT Change-Id: Ib549e31f1f240e0de2cedfabac9bb998ee58a517 Reviewed-on: http://gerrit.openafs.org/825 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 7d44a087712def4b07011212f978c6d4572bf0de Author: Jeffrey Altman Date: Sat Nov 14 16:27:37 2009 -0500 Windows: Error mapping for VBUSY and VRESTARTING Add error mapping for VBUSY and VRESTARTING to cm_MapRPCError(). Return CM_ERROR_ALLBUSY. This prevents an unknown error from being returned to the SMB redirector. LICENSE MIT Change-Id: Ie8bf8bc88e087a8eef428444ca07c7ca7c4621a8 Reviewed-on: http://gerrit.openafs.org/826 Reviewed-by: Jacob Thebault-Spieker Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 1594cf98926ceef1de36010335f9ca19cc050bad Author: Jeffrey Altman Date: Sat Oct 31 10:33:00 2009 -0400 Windows: Use STATUS_IO_TIMEOUT where STATUS_TIMEOUT was returned STATUS_TIMEOUT causes the smb redirector to drop the connection. STATUS_RETRY is interpreted by the smb redirector as if the error was generated by the transport stack and not the smb server. STATUS_IO_TIMEOUT is listed in the SNIA CIFS 1.0 spec as a valid return code for the smb server. Lets us that. LICENSE MIT Change-Id: I842a78cde3d975c88bbeb64294dd53cc8b101047 Reviewed-on: http://gerrit.openafs.org/831 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 4c25f00088a603723b75e60d6b808a89034b33d3 Author: Jeffrey Altman Date: Sun Nov 15 01:01:23 2009 -0500 Windows: Fix port assignment to use network byte order Service port numbers are stored within sockaddr* structures and returned by afsconf_FindService() in network byte order. getAFSServer() and afsconf_GetAfsdbInfo() accept and return service port numbers in network byte order. When processing the special case for 7002 and 7003 in afsconf_GetAfsdbInfo(), the comparisons must consistently use network byte order. When assigning port numbers for AFSDB lookups, getAFSServer() must use network byte order. Document the use of network byte order for each variable. LICENSE MIT Change-Id: I2163826e8a234a1d19474b2eba3d36335ba12afb Reviewed-on: http://gerrit.openafs.org/830 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 9d245a26228a80e4584cb3b481dffa3fd77514cb Author: Jeffrey Altman Date: Wed Oct 21 18:41:59 2009 -0400 Windows: ports in the cache manager are stored in network byte order When assigning ports from SRV/AFSDB lookups, convert to network byte order when assigning them to cm_server objects. LICENSE MIT Change-Id: Ic22a445c9f6433f9f7544774ea9952d82fcdba8a Reviewed-on: http://gerrit.openafs.org/791 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit c53abbb3e8d14643f3f82999cbe24fb12d358ce0 Author: Andrew Deason Date: Wed Nov 11 11:23:49 2009 -0600 Make ktc_curpag also detect ONEGROUP PAG gids ktc_curpag falls back to looking at the group list if the VIOC_GETPAG pioctl fails. If we're in AFS_LINUX26_ONEGROUP_ENV in the kernel, though, ktc_curpag still looks for two groups, instead of the one combined group. Add a check for the big one group in the fallback if we're on LINUX26. Change-Id: I28e5eda5c62f13a6fb466c8a2b04d2628706498f Reviewed-on: http://gerrit.openafs.org/815 Tested-by: Andrew Deason Reviewed-by: Marc Dionne Reviewed-by: Derrick Brashear commit 5e99d56cf2a8c4c9789bc7ace04a804d07e6238f Author: Simon Wilkinson Date: Wed Oct 21 23:17:15 2009 +0100 Use set_page_writeback and end_page_writeback Calling set_page_writeback and end_page_writeback is necessary to ensure that the dirty page radix tree and the page dirty flags tally. The results of end_page_writeback are also used by the bdi code to prioritise writeback. The Linux kernel documentation contains further warnings of doom for what may happen due to not calling them. Adding set_page_writeback and end_page_writeback also allows us to unlock the page earlier (the page can be locked any time after the writeback flag is set). This means that we're not calling the backing filesystem's ->write function with our pages locked, and should help reduce contention and the potential for deadlocks there. Change-Id: I9130b2ad9a09c6b9b16a0f63d7b4a614a93de8d3 Reviewed-on: http://gerrit.openafs.org/819 Reviewed-by: Marc Dionne Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit dc85abcaa6e3423452078e36bbfcd281e613c407 Author: Marc Dionne Date: Thu Oct 29 19:58:00 2009 -0400 Linux: Use the kernel's credentials structure Recent kernels (2.6.29 and above) have a separate ref-counted structure for holding credentials. Use it directly instead of keeping a separate afs specific structure that shadows the same information. Also adapt Linux for the change from cr_xxx to afs_cr_xxx wrappers. Reference counting is done with the appropriate get/put calls. Change-Id: I1135bb5a66cda51cee4fa9f3f3e63eaa9af28f61 Reviewed-on: http://gerrit.openafs.org/797 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 97d3fcfcd1617bafa6ee62d291f09b2e8bb6daf7 Author: Andrew Deason Date: Wed Nov 11 10:51:19 2009 -0600 Do not check *aoutSize in PGetPAG *aoutSize is always zero in pioctls, since afs_HandlePioctl handles checking the output buffer size, and sets outSize to 0 before calling the pioctl. So, PGetPAG was always returning E2BIG; remove the check to make it work. Change-Id: Ibed16b35ea14237f44a494add8c7a4a48e0c2b71 Reviewed-on: http://gerrit.openafs.org/814 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit e854e26ef1a2ddb26d926891ffb32c1f46293878 Author: Simon Wilkinson Date: Wed Nov 11 10:34:30 2009 +0000 Update warning inhibition A number of recent changes haven't caught all of the locations where warning inhibition can be removed. This patch updates all of the inhibitions to reflect the current state of the tree when built with gcc4.2 Change-Id: I7bad4fee1258f4e37fd729cda84711fed66acbc9 Reviewed-on: http://gerrit.openafs.org/813 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 748eaf804119a632204f0c6cce5e07ec4c372c13 Author: Simon Wilkinson Date: Wed Nov 11 10:32:59 2009 +0000 Prototype kalog_Init Prototype the kalog_Init function in kauth_internal.h, and remove the warning inhibition from kaserver.c Change-Id: Ic48d199126629f1c0c2e498081be97901678ec70 Reviewed-on: http://gerrit.openafs.org/812 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 420dfad900267720d1665a67c92c567a341728c7 Author: Simon Wilkinson Date: Wed Nov 11 10:28:29 2009 +0000 const char paths for ubik_ServerInit ubik_ServerInit* take a pathname, which should really be a const. It already is in many of the callers, some of which remove the const by casting, the others throw errors. Make pathName const for all of ubik_ServerInitByInfo, ubik_ServerInit and ubik_ServerInitCommon. Update all of our callers to remove the now unecessary casting. Remove the now uneccessary warning inhibition on vlserver/vlserver.c Change-Id: I009103dc49e4473eec65ebd75aab727915c26f3c Reviewed-on: http://gerrit.openafs.org/811 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 420a544ecea96d5f72e5446f1f75add666b4f463 Author: Simon Wilkinson Date: Wed Nov 11 10:19:07 2009 +0000 Fix des key type issue in bosoprocs The call to afsconf_AddKey was using 'akey' rather than 'akey->data'. As data is the first element of the akey structure, these are actually identical, but the compiler sees it as a type error. Fix to use the correct name, and remove the warning inhibition. Change-Id: Id4775a836276ddd6f5ae105c298dcc3c68b92145 Reviewed-on: http://gerrit.openafs.org/810 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit be305ae119c4bd71431596f81d97f9195faa069f Author: Simon Wilkinson Date: Wed Nov 11 10:13:57 2009 +0000 Prototype UV_Bind Publicly prototype UV_Bind in volser_prototypes.h Make dump.c use the public prototype, instead of an incomplete private copy, and remove the warning inhibition that was required to support the private copy. Change-Id: I945192454702d79083a10062adaf2cb124d14a35 Reviewed-on: http://gerrit.openafs.org/809 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit bab6fd227f5724c4e4ca5d0ba1dc64e21ed21f97 Author: Simon Wilkinson Date: Wed Nov 11 08:32:48 2009 +0000 Remove 'M' variants of lock macros Since the beginning, we've had M variants of the lock macros, which are identical to the normal form. Dispose of these variants, to make it clearer what's going on. Change-Id: I0b7708ec670ef0edb4c1dc21d472e5041d31f6a2 Reviewed-on: http://gerrit.openafs.org/807 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit cbe83cb1a12fddc63c1775243c47fb43da40f9c1 Author: Simon Wilkinson Date: Wed Nov 11 09:10:36 2009 +0000 Fix warnings from afsconf_SetExtendedCellInfo If a is declared as an array, then a == &a. However, the compiler still gives a type warning when usign the & form, as the types no longer match. 5f720faab920a1007327de415ceaf187c16fdbe6 fixed this problem for calls to GetExtendedCellInfo - do the same for the corresponding Set calls. Change-Id: I8204afe7df0c0db1d059cb3f6ab61eff1cdf9140 Reviewed-on: http://gerrit.openafs.org/808 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c90132f2af3455948f029f9c475c768e476f66e4 Author: Simon Wilkinson Date: Wed Nov 11 08:28:32 2009 +0000 Include signal.h for sigfillset f6ce2af008feb615e94d924fc9f81e2098e73e7c added a call to AFS_SIGSET_CLEAR to vol/volume.c. However, it didn't add signal.h to this file. As AFS_SIGSET_CLEAR calls sigfillset(), this broke checked builds. Add signal.h to the list of headers to fix the build warning. Change-Id: Ib861abfbd153f6ef2ff4b42ea03b5604a95975d4 Reviewed-on: http://gerrit.openafs.org/806 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit d616d1ee99794525aa2d778d11552c1986007ebb Author: Marc Dionne Date: Tue Nov 10 18:36:55 2009 -0500 krb_udp.c warning fix This file generates a warning because the left side of a variable assignment is commented out. Keep the effect of the line (incrementing packet) but remove the unused casting and reference, and remove the comments that date from the original IBM source. Leave a new comment in place in case the information is useful. Adjust the Makefile and README.WARNINGS to account for the change. Change-Id: I944e1c488e39411d32d700cba2d3ef567eddddb4 Reviewed-on: http://gerrit.openafs.org/804 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c4dfacc9341cd47805de5cd2d2de151199344a67 Author: Michael Meffie Date: Mon Nov 9 11:03:10 2009 -0500 cm: address race condition in afs_QueueVCB Access the vcache callback member after taking the xvcb lock to avoid the server object from being freed in FlushServer on another thread. Eventually, we should have a ref count on avc->server. FIXES 125596 Change-Id: I760819b1632d0e8188eaa34531239951aab980d3 Reviewed-on: http://gerrit.openafs.org/800 Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 2d0824245c030b08f90972ea0756fccf981263c0 Author: Marc Dionne Date: Tue Nov 10 18:16:45 2009 -0500 src/pam/afs_auth.c warning fix ka_UserAuthenticateGeneral expects an afs_int32 pointer for the password_expires argument. A (long *) was used in afs_auth.c, generating a few warnings. Change-Id: Iafc92e72022644ff23c642e801d51bd4387afa88 Reviewed-on: http://gerrit.openafs.org/803 Reviewed-by: Russ Allbery Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 954f67c682bdceb10c58646336ae0178ad47e317 Author: Simon Wilkinson Date: Wed Nov 11 08:12:51 2009 +0000 cr_gid is already used by Darwin Commit eb8e55bba7740a87e07ef07bb4b789e6d4e36f0d introduced a variety of functions for accessing members of the credentials structure in a platform independent way. Sadly, cr_gid is already defined by the Darwin platform headers (on Darwin, the GID is just the first of the user's groups) Turn cr_gid() into afs_cr_gid() to avoid this problem, and for consistency, also rename cr_uid, cr_ruid, cr_rgid, and the corresponding set_* functions. Change-Id: I82d74900324d079b5a5c8985510a2c9586c4a526 Reviewed-on: http://gerrit.openafs.org/805 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit fc5e2a4d81f535db29cea962b26748a04f1bca4d Author: Derrick Brashear Date: Mon Nov 9 13:10:55 2009 -0500 unix srv record network byte order fix correctly process dns lookups corresponding to the srv record changes in network byte order Change-Id: Id70f972331582912ca984ae1b1c027c7b702a22c Reviewed-on: http://gerrit.openafs.org/801 Reviewed-by: Thomas L. Kula Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit 24de8dae6d5d9ef72bd89877eb2f29c401024504 Author: Russ Allbery Date: Sun Nov 8 17:31:25 2009 -0800 Update afsd cache and firewall details Cache parameters are discussed in two locations in the afsd man page, and the first copy had not been updated for the new auto-tuning of the chunk size and the stat parameter. Fix both. Note that the firewall requirements for klog only apply if you're using kaserver and klog. Kerberos v5 has its own requirements, but this is not the place to talk about them. Change-Id: I9cdaaa71351a64cecc1b6904efba87d4871d42fb Reviewed-on: http://gerrit.openafs.org/798 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit c9197a1f32f3ba69b4c609726532977324dabd7b Author: Simon Wilkinson Date: Mon Nov 9 23:20:14 2009 +0000 Fix locking in FlushVCBs when called from discon The disconnected code doesn't request locking from FlushVCBs when it calls it, but also doesn't hold the required locks itself. Fix this. Change-Id: I2450df4b19b2d44dca80990197e5e7637c9c8334 Reviewed-on: http://gerrit.openafs.org/802 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit eb8e55bba7740a87e07ef07bb4b789e6d4e36f0d Author: Marc Dionne Date: Thu Oct 29 19:23:28 2009 -0400 Unix client: wrappers for credentials structure access This patch introduces and makes use of wrappers for access to credentials structure members: cr_uid (afs_ucred_t *) cr_ruid(afs_ucred_t *) cr_gid (afs_ucred_t *) cr_rgid(afs_ucred_t *) cr_group_info(afs_ucred_t *) Inline functions are also introduced to set values: set_cr_uid (afs_ucred_t *, uid_t) set_cr_ruid(afs_ucred_t *, uid_t) set_cr_gid (afs_ucred_t *, gid_t) set_cr_rgid(afs_ucred_t *, gid_t) set_cr_group_info(afs_ucred_t *, struct group_info *) This will allow an architecture to make use of an alternate structure to hold credentials. In particular it will allow the linux client to be modified to use the kernel credentials structure directly instead of shadowing it into our own local structure. There should be no functional change. Change-Id: I7739196a0691a9c30887043b085e4878e88780ae Reviewed-on: http://gerrit.openafs.org/768 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit f6ce2af008feb615e94d924fc9f81e2098e73e7c Author: Michael Meffie Date: Thu Nov 5 11:08:08 2009 -0500 viced: avoid useless core if shutdown during initialization Avoid leaving an unnecessary core file when the fileserver is shutdown while still attaching volumes. The bosserver issues SIQUIT to shutdown the fileserver which leaves a core file by default. Register the fileserver shutdown signal handler earlier in the fileserver initialization, before the long running volume attachment is started. The volume package shutdown has been changed to allow the VShutdown to gracefully abort the volume attachment (or pre-attachment for DAFS). FIXES 124485 Change-Id: Ic22e68afb7bcc54ad956b2ae093375f29b969191 Reviewed-on: http://gerrit.openafs.org/764 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit d98d3060f880f4c7d4089fd2fb981ee08fd1486f Author: Simon Wilkinson Date: Sat Nov 7 11:52:59 2009 +0000 Add printf-style format checking Add the AFS_ATTRIBUTE_FORMAT macro which can be used to turn on printf-like format checking for our va-arg log functions. Enable this checking for volser's Log(), and fix the fallout from doing so. Change-Id: Ic5ab93ba731856f1f90e894d711b0f84298ded12 Reviewed-on: http://gerrit.openafs.org/789 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 392dcf676bd3642fc114abb29b79888055d8c409 Author: Simon Wilkinson Date: Wed Nov 4 20:15:36 2009 +0000 Complete removal of DUX client code With commit cfce015ead18c72ee921f480c73e9247a98838fc (in 2006) all of the files specific to the DUX cache manager were removed. However, the DUX code within general files remained untouched. This patch completes the removal of the (entirely non-functional) DUX client, by removing all cache manager code which is for AFS_DUX*_ENV and AFS_OSF_ENV platforms. It also takes the advantage of this removal to simplify some #ifdef ladders, and indents others (purely because I needed the indentation to work out what on earth was going on!) Change-Id: Icbea5ed3ef94c5e902cdb0d722be85f376c3d296 Reviewed-on: http://gerrit.openafs.org/785 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c90134fd1f1b5cd16052c5fdc91ddd1b1ac6e19a Author: Simon Wilkinson Date: Wed Nov 4 18:09:51 2009 +0000 Move vnode macros to their own directories The tree is inconsistent whether macros for access to vnodes are provided by the OS directories, or in afs_osi.h. This makes things very confusing, especially in the Linux case where macros are provided in afs_osi.h, and then promptly redefined in LINUX/osi_machdep.h Adopt a convention where default macros are conditionally provided by osi_machdep.h. Where these aren't wanted, they should be disabled in osi_machdep.h, and OS specific versions provided in the individual OS's directory. Change-Id: I47bc969af3f6670db9348689b5ce60181fd44f21 Reviewed-on: http://gerrit.openafs.org/784 Tested-by: Marc Dionne Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 457303440042ad43e61652b6ca11c84fab390b82 Author: Marc Dionne Date: Sat Nov 7 10:51:52 2009 -0500 Linux: always use afs_maybe_unlock_kernel In one error case in afs_linux_lookup unlock_kernel() is called directly instead of using the conditional "maybe" form. If the config is such that the BKL is not taken, this can result in an attempt to unlock when the lock has not been taken, and can cause an oops. Change-Id: I27d5db58e9b9d45d925b24e27bc43960499c6ead Reviewed-on: http://gerrit.openafs.org/790 Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 09c4c1978b8901cac0191900c8679095b7e53e6d Author: Simon Wilkinson Date: Sat Nov 7 01:10:22 2009 +0000 Add error_table.c to gitignore in comerr error_table.c is a build product for comerr, should we should gitignore it Change-Id: Ie47ae4daec734b31c884e4732d053635ee1048bb Reviewed-on: http://gerrit.openafs.org/788 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit fd592c7674d4aa44dda90998b54d7b56947f6ed8 Author: Andrew Deason Date: Tue Nov 3 21:22:50 2009 -0600 Cleanup VOffline log message Make the 'Volume X (Y) is now offline' messages appear more sanely in the log; logging as one line at once. Change-Id: I8a3cf986fb30e292e509237357bd1039f2f181b9 Reviewed-on: http://gerrit.openafs.org/782 Tested-by: Andrew Deason Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 95770bf95ad766207252ea0c2d2b5ab2415c896f Author: Simon Wilkinson Date: Wed Nov 4 23:40:39 2009 +0000 Prevent VLRUQ race in ShakeLooseVCaches When ShakeLooseVCaches is called from afs_Daemon, the xvcache lock is not held. This means that if the GLOCK is dropped for any reason (for example, whilst purging the dentry cache), then ShakeLooseVCaches can be raced, end we can end up attempting to flush the same vcache twice. The symptoms of this in Linux are that we oops in clear_inode. Get the xvcache lock in afs_Daemon(), before calling ShakeLooseVCaches. Also, remove the conditional GLOCK code from that function. If we don't have the GLOCK on entry, then we're really in trouble (and both code paths - afs_Daemon and afs_NewVCache should get the GLOCK for us, anyway) FIXES 125589 Change-Id: I3fe5b41a661cd162ec73c51492925ad87c6d4c13 Reviewed-on: http://gerrit.openafs.org/781 Reviewed-by: Marc Dionne Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 86858bdfb6e25168828d8595f387ef5919e0df3a Author: Rainer Toebbicke Date: Fri Oct 30 12:10:21 2009 +0100 Correct diskused and files when cloning a volume Recalculates a volume's disk space used and number of files upon every clone where it is effortless. Even though tracked mostly correctly, bugs and accidents leave their traces which only a salvage would correct. Change-Id: Ied6fb9eb3944b6e30eac175fe42649c5b7cfaefb Reviewed-on: http://gerrit.openafs.org/756 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 2df6f25f61cc888bc2a8fb3ccab1de37fc4c04b0 Author: Derrick Brashear Date: Tue Nov 3 19:26:33 2009 -0500 macos fstrace msgcat search path everything else on osx will look for config in /var/db/openafs; make fstrace do the same Change-Id: I7b787435343b15c82cd8eb8f3ed00096d469e888 Reviewed-on: http://gerrit.openafs.org/772 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 848b781d114cbf5cd245273f37be97f64047c8cc Author: Derrick Brashear Date: Tue Nov 3 19:25:23 2009 -0500 macos 10.6 64bit trace fixes the 64 bit pointer massaging was incomplete for kernel tracing on macos. add in the missing cases. Change-Id: I38eb608c233819ab437adec25e2cd3afac3e234e Reviewed-on: http://gerrit.openafs.org/771 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c41d3b21323de122fc0a60dc602a5377dfb19d3e Author: Marc Dionne Date: Wed Oct 28 17:54:32 2009 -0400 Linux - Fix disk cache access for selinux/AppArmor constrained processes Preserve the credentials used for cache initialisation and use then whenever disk cache files are opened. This takes advantage of the credentials separation work from David Howells available in kernels 2.6.29 and above. Access to cache files was done under the security context of the user process, causing processes constrained by selinux or AppArmor to fail to access AFS cache files and causing the cache manager to panic. Besides the RT tickets, should also fix the following Ubuntu bugs: 415766 429260 457779 459299 FIXES 92944,125544 Change-Id: Ief8acd65c1a3e4d8c951f80bfd65f8340b8cec34 Reviewed-on: http://gerrit.openafs.org/752 Reviewed-by: Derrick Brashear Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit cbe580fee176c9e9e083379129c309fd15d0f24c Author: Jeffrey Altman Date: Fri Oct 23 09:54:35 2009 -0500 Check for (hostFlags & HOSTDELETED) after h_Lock_r Many callers of h_Lock_r do not check if the HOSTDELETED flag is set, even though it could have been set while waiting for the host lock. Add checks for it everywhere we call h_Lock_r and we care if the host has been deleted. FIXES 125507 Change-Id: Id1430529a1afdb5e2af29d40148877f5e4260a41 Reviewed-on: http://gerrit.openafs.org/716 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit f08c714f8800aaa28177c3d58e7a5641af61d7de Author: Andrew Deason Date: Mon Nov 2 12:19:45 2009 -0600 DAFS: Avoid SALVSYNC communication during shutdown Avoid trying to contact the salvageserver for any reason while we are shutting down. During shutdown the salvageserver may not be around anymore, so any SALVSYNC communication will appear to hang. Just set a global flag to indicate 'no-SALVSYNC' on shutdown, in addition to the thread-local flag we already have. Change-Id: Id96f20917fd0753b4934a0377b91032b2ea3d0dc Reviewed-on: http://gerrit.openafs.org/765 Tested-by: Andrew Deason Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 5e6842283f5c2fdf0fe3306993a6e18c2e590716 Author: Andrew Deason Date: Mon Nov 2 17:18:19 2009 -0600 DAFS: Wait for exclusive ops in FSYNC_VOL_OFF In the FSYNC_VOL_OFF handler, fssync-server.c errors out if the call to VGetVolumeByVp_r fails. However, this can fail if the volume is in an error state such as SALVAGING. Normally we don't even call GetVolume when the volume is salvaging, but the volume state can change to SALVAGING inside GetVolume. This is particularly likely to happen on a demand salvage, since we switch to the SALVSYNC_REQ state when scheduling the salvage, and if we are still in that state when the salvaged child requests a VOL_OFF, we will fail to get the heavyweight ref. Fix this in two ways. First, we VWaitExclusiveState_r before examining states for the short-circuit logic so our view of the volume state is more accurate. Second, re-examine the volume state after the call to GetVolume, and perform the same short-circuit logic, since the volume state may have changed during GetVolume. Change-Id: I4ebb87691c28170b42e0056b342477a12d0f6888 Reviewed-on: http://gerrit.openafs.org/769 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit 93d48b1735b88b3051357307bdbebf5da9872d69 Author: Dan Hyde Date: Thu Oct 29 12:07:47 2009 -0400 Add array bounds checking in h_Enumerate When hostList is not properly NULL-terminated, the current code does not protect from buffer overflow. The following patch prevents buffer overflow, prints a message, and asserts. On our Linux hosts, we never reached the original assert, as there is a problem handling the segfault the buffer overflow causes. FIXES 125506 Change-Id: Ifce92c593d17050e45add9e37a7a9ed4fbc377ef Reviewed-on: http://gerrit.openafs.org/757 Reviewed-by: Dan Hyde Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 715c67f2fb3c1756f0c9cee0bc3258a3e378d3fd Author: Marc Dionne Date: Sat Oct 31 13:27:18 2009 -0400 Linux: Fix write_begin configure test for recent RHEL kernels Recent RHEL kernels now define simple_write_begin, which was used as a test for the write_begin address_space op. This makes the test succeed when it shouldn't, and breaks the build. Rewrite the test to actually check the address_space operation. Change-Id: Idac9b318ff716b61bf8ca4508d2dbdbfbad5b50d Reviewed-on: http://gerrit.openafs.org/759 Reviewed-by: Simon Wilkinson Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit 5a537f071970c38881fde1ad8508775fafd7489d Author: Marc Dionne Date: Sat Oct 31 08:54:52 2009 -0400 Fix memory allocation warnings at shutdown At shutdown we check for unfreed memory allocated with AllocSmallSpace and AllocLargeSpace and complain in the syslog if there are dangling pieces. This patch takes care of a few cases that always showed up as warnings, even after a simple start-stop of the client. - The cacheInode file needs to be closed before the checks, since it uses a large piece for its struct file. - The ICL logging code allocates 6 small pieces that are never freed. Add a shutdown_icl() function that releases everything. While we're at it, correct one place where we allocated with afs_osi_Alloc but freed with osi_FreeSmallSpace, confusing our accounting. Change-Id: I4c28c848f155dec9d89e6199cde34209227ca5c9 Reviewed-on: http://gerrit.openafs.org/758 Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 8b3d2c1a3c9c430bb28e8d209d8399a9dc635f4b Author: Marc Dionne Date: Thu Oct 29 17:11:34 2009 -0400 Linux: remove unused cr->next member in struct afs_cred This field was once used to track allocations in a credentials pool. That code was removed a few years ago but the field remained. Change-Id: Ieac642d7d55c4da766a5a3aa8ff790a514b606d6 Reviewed-on: http://gerrit.openafs.org/753 Reviewed-by: Simon Wilkinson Reviewed-by: Dan Hyde Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit afdfbefe9cbf1818bee0072d2845fd02f7ac69a4 Author: Simon Wilkinson Date: Thu Oct 29 18:53:30 2009 +0000 Cleanup cache bypass This patch cleans up the cache bypass code so that it uses a consistent form of indentation throughout the file. It also changes the do { } while(0); macros to omit the trailing semicolon, as macro definitions with trailing semicolons break normal coding conventions. Change-Id: Id5161fe4b1ba27110e41ed27e14a2bb3c9cccd4a Reviewed-on: http://gerrit.openafs.org/754 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 416e2f11c35f5d55f91090b30b4db1a9bf6d6e07 Author: Andrew Deason Date: Wed Oct 28 11:06:47 2009 -0500 Avoid using released hosts Since h_Release_r has the possibility of freeing a host, we should not be using a host after it has been released. A few places can still use a released host, potentially causing heap corruption, double frees, and generally weird behavior. So either move calls of h_Release_r until after we finish using a host, or make sure to set the pointer to NULL after it has been released. Change-Id: I3d5275c3862003e372d3c19a5462e62bf9cb269e Reviewed-on: http://gerrit.openafs.org/747 Tested-by: Andrew Deason Reviewed-by: Dan Hyde Reviewed-by: Derrick Brashear commit 28ccbd1ad88f8cee34515b0552441083c310aa1d Author: Simon Wilkinson Date: Thu Oct 29 18:42:41 2009 +0000 Coding style cleanup Our style for function definitions has the name of the function as the first item on a new line - this means you can find a definition by using grep ^functionName. Fix the disconnected code to follow this style. Change-Id: I925039070f2bbbd97f04fbee006ea08df92d7cf5 Reviewed-on: http://gerrit.openafs.org/751 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 7833e472b9585ee1a7085ca704e642a73ca969a5 Author: Simon Wilkinson Date: Wed Oct 28 11:12:18 2009 +0000 Make afsd.pod reflect reality 9d396c4916fdac64fcface30e6637ca6e2911203 (from 2005) introduced autotuning for afsd, and changed some of the defaults which aren't autotuned. Update the afsd man page to reflect the autotuning, and the new defaults. Change-Id: Iea2035743cb45cca1c249bc2e838405039ad7d3a Reviewed-on: http://gerrit.openafs.org/744 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 53fc41a856da4a23fa603bd5a274d819e7a3b54e Author: Simon Wilkinson Date: Wed Oct 28 18:24:33 2009 +0000 Move PMTU header block to top of file 1206e7538be86f073b21cd289266286b60a95d0a added linux/errqueue.h to rx_user.c, but added the include in the middle of a function - which means that the new structure is out of scope for the rest of the file, which breaks the build on Linux. Put the header include at the start with all of its other friends. Cc: Alf Wachsmann Change-Id: Id932ff63b59e6cd62eda3df4f01e4eef354736ca Reviewed-on: http://gerrit.openafs.org/748 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 21efa6394ebf0b1eea440b74aef9f62160d5f851 Author: Marc Dionne Date: Mon Oct 26 18:23:00 2009 -0400 afs_buffer.c: fix uninitialized variable warning Squash a warning about lt being potentially used uninitialized. Change-Id: I41bfccfd1a0db925a4d728a217b154f45c28b112 Reviewed-on: http://gerrit.openafs.org/742 Reviewed-by: Simon Wilkinson Tested-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit bea4c4ea5d563bebe9f9c6289a1f25fd016a01a4 Author: Simon Wilkinson Date: Mon Oct 26 19:52:48 2009 +0000 Use fewer #ifdefs for dynamic vcaches When we're not in AFS_MAXVCOUNT_ENV, make afsd_dynamic_vcaches a static 0, which allows the removal of a scattering of #ifdef's in the middle of conditionals in afs_vcache.c, and generally improves the code browsing experience. Also, move the externs for this variable to afs.h, where they belong, and fix related formatting. Change-Id: I4d56ebae63fe1855ac80f8511b9fc76f7e5a326f Reviewed-on: http://gerrit.openafs.org/741 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit d769b27694b4ab6d3fba23c6121238b311bd82d6 Author: Simon Wilkinson Date: Mon Oct 26 23:17:36 2009 +0000 Make cache bypass build again Recent commits had left cache bypass somewhat behind, make it build again. Change-Id: I500372f4584f4d0d90f6ea9f98a9ac3fb05f5185 Reviewed-on: http://gerrit.openafs.org/743 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 293e8c6a1048bf3c342134b5ca6f79d68023258b Author: Simon Wilkinson Date: Mon Oct 26 18:52:52 2009 +0000 Remove hardcoded maximum time When iterating across the buffer list, afs_newslot used a hardcoded maximum time to find the oldest. Instead of using this, just use the accesstime of the first unused buffer that we find as the oldest, and continue as normal. Change-Id: Ifeacb8a407901b46a23fbc838b1fca761108ebbb Reviewed-on: http://gerrit.openafs.org/738 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit f97262c1d422e0a32289c75665d051914c8d69ad Author: Simon Wilkinson Date: Mon Oct 26 19:36:53 2009 +0000 Fix dynamic vcache / rxmaxmtu cmd id collision Both dynamic vcaches and rxmaxmtu had been committed as using the 35th command entry. Fix this according to the order they are in the command list (35 and 36, respectively). Tidy up the command list so it's easier to read, and remove the #ifdef notdef entry from it, as adding it back in would just cause chaos. Change-Id: I3fce403aa0ab01c42f0e1a48ae401503b0e21c24 Reviewed-on: http://gerrit.openafs.org/740 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b21b209f1cb2bafe916543c1ac8f232d6fc84847 Author: Simon Wilkinson Date: Mon Oct 26 17:06:20 2009 +0000 Fix locking in afs_buffer.c Back in 2002, 0eb68f307aac84472a13523a0ce8b7a865f01ac7 was committed to fix locking problems in dir/buffer.c. Sadly, similar changes were never made to afs/afs_buffer.c, so the same problems remain in the cache manager. The issue here is with two processes racing in afs_newslot. Calls to afs_newslot protect buffers with a zero reference count using afs_bufferLock. If we release afs_bufferLock, before we increase the reference count of the vcache, then we can end up with newslot picking the same buffer for two different purposes. The GLOCK actually protects us from the worst of this, but this fix is necessary both for correctness, and for symmetry with the file server buffer code. Change-Id: I7f1c7d6571559c5f1784926c39d4889b77677231 Reviewed-on: http://gerrit.openafs.org/737 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit ba93d8f9f1379e3342460273234f964a39e1caf9 Author: Simon Wilkinson Date: Mon Oct 26 19:46:09 2009 +0000 Remove pininodes The pininodes option has been commented out of afsd since the original OpenAFS commit. Enabling it now would cause chaos, due to the way that cmd orders its arguments. Just remove the sections of code to avoid this danger. Change-Id: I9e9944d4470fd21d2ec9e36e17771b499d7c8e0b Reviewed-on: http://gerrit.openafs.org/739 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit dbe3b7b8eeb4a010f82248befc6167b3b5ed9606 Author: Andrew Deason Date: Mon Oct 26 14:04:48 2009 -0500 Dec old special inodes in inode convertROtoRW The convertROtoRW code for the inode fileserver makes copies of the volume's special inodes, but leaves the old (RO) inodes around. If the RO is created again, this will result in duplicate special inodes for the same volume, which freaks out the salvager (and possibly other things). So IH_DEC the old RO special inodes after converting, so they go away. Change-Id: Ifefa2cb69c5b2960b81dbee9d54e5ea8401b240e Reviewed-on: http://gerrit.openafs.org/735 Tested-by: Andrew Deason Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c95ace2c5963076deaf5f5c3a9856978f19ea0c4 Author: matt@linuxbox.com Date: Mon Aug 3 12:36:25 2009 -0400 viced (non atomic) refcount/more-threads Replace host-hold bitmap with reference counting, phase 1, not atomic. Increase viced MAX_THREADS. NOTE: This code has been tested on Centos 5.3 x86_64, on VMWare, 2 physical, 2 logical CPUs. LICENSE BSD Change-Id: Id62dcc786619dfd99e1a7b69a196bbaa0b45158c Change-Id: I8ee2ec645402f02fdba0920815409b56172d393b Reviewed-on: http://gerrit.openafs.org/268 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit bf8355bd9aa7e7bd47ec5554030258fe43e2abdb Author: Jeffrey Altman Date: Mon Oct 26 07:13:00 2009 -0700 ubik_VL_GetAddrsU does not accept a VLCallBack parameter ubik_VL_GetAddrU accepts a pointer to a uniqifier and not a pointer to a VLCallBack structure. Remove an incorrect cast and provide the correct parameter in src/volser/vos.c. Change-Id: I4b12cf2d4c65f115fdef76f0a4306960b5cd0413 Reviewed-on: http://gerrit.openafs.org/733 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b90f4241285efccdf8be5f9ce3ae28c64fbccd38 Author: Andrew Deason Date: Fri Oct 23 15:02:12 2009 -0500 Avoid 'salvageserver -client -showlog' segfault Running salvageserver with the -client and -showlog options will currently segfault, since -client does not open logFile, and -showlog will attempt to rewind logFile on exit. Fix this by not allowing -client and -showlog together (since it won't work anyway, as -showlog tries to read SalvageLog), and by making showlog() check logFile for NULL-ness. Change-Id: I30f43ef1696f1e7e8873b9e1cc3867b4e06d1980 Reviewed-on: http://gerrit.openafs.org/734 Tested-by: Andrew Deason Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 8edafd92c0ec5b31aff7f86b73f954a04d0f17d4 Author: Jeffrey Altman Date: Mon Aug 17 12:23:57 2009 -0400 Updates to Jake's RTT based server ranking (Gerrit 317) Remove check on powerStateSuspend in cm_Daemon() Update the server Reference lists if the ranking changes. Change-Id: Id290e0f98c616a12f4f8b1746dca58ad7a0f06ce Reviewed-on: http://gerrit.openafs.org/729 Tested-by: Jeffrey Altman Reviewed-by: Jacob Thebault-Spieker Reviewed-by: Jeffrey Altman commit d22c05e6799649a1b5c06b0396e78b0520b3e4f6 Author: Jacob Thebault-Spieker Date: Wed Aug 12 01:32:06 2009 -0400 Adds cm_RankUpServers() and cm_RankServer() This adds the functions cm_RankUpServers() and cm_RankServer() to the Windows cache manager. cm_RankUpServers() steps through the list of servers, and calls cm_RankServer(), which in turn re-ranks the servers that are currently up based on rx peer statistics as exposed by rx_GetLocalPeers(). cm_RankUpServers() is called every 10 minutes by the cache manager daemon, so as to allow re-ranking of the servers. Also added is the struct server->adminRank data structure, to allow for the modification of the rank that the admin has set, without but basing this modification on the admin-set rank. Change-Id: I118b885e179e4f84901dd9a3180ce821f194feb8 Reviewed-on: http://gerrit.openafs.org/317 Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman commit 4a006f167bf6fe550eac9c96c6fce1f538760709 Author: Simon Wilkinson Date: Mon Oct 26 12:49:11 2009 +0000 Clean up console message Clean up the 'all buffers locked' console message so that it's clear that it comes from AFS, and so it has a trailing newline. From a bug report by Rainer Toebbicke to openafs-info Change-Id: I3f69e57e37a91ae3e6e8822ccfe72dddc06b4359 Reviewed-on: http://gerrit.openafs.org/732 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b8e4c573a5da18ecd80578a1061594891528ffc9 Author: Simon Wilkinson Date: Fri Oct 23 16:34:33 2009 +0100 Don't return AOP_WRITEPAGE_ACTIVATE to write() When we're called from write(), we don't have the option of deferring the writing of a page by returning AOP_WRITEPAGE_ACTIVATE. Instead, write() simply sees this as the output of 0x8000 bytes of data. So, whilst we can mark a vcache as being output, we can't defer the processing of one which is already being written (by, for example, an earlier writepage()). This problem only affects files which are have mmap() and write() called in quick succession, but it does break the fsx utility. Change-Id: I750a186de38da9873665a862f5b584a78e6979ad Reviewed-on: http://gerrit.openafs.org/725 Reviewed-by: Marc Dionne Tested-by: Marc Dionne Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 70c8deab1694e2cd200f4ff7a81f5f3f028a4c19 Author: Simon Wilkinson Date: Sat Oct 24 10:54:32 2009 +0100 Use user credentials for Linux writepage() We have no control over the context in which the kernel calls our writepage routine. It may be from the process which original wrote the page, from any other process on the system which is writing and goes over the dirty page threshold, or from the flush thread (pdflush / flush-afs). Therefore, we cannot use the credentials of the current process to perform the writeback. This is an issue both for afs_write (which, in our current MM model, may need to contact the fileserver to read missing chunks), and for DoPartialWrite (which needs to be able to store chunks when the local cache is getting full) This patch stores the credentials of the first process to open a file in the vcache structure. Whenever writepage() is used to writeback pages for this file, the cached credentials are used rather than those of the current context. Thanks to Marc Dionne for his work in testing and refining this patch. FIXES 125471 Change-Id: I2900f711150fd81b2b4839bbc2bf77623bde3b64 Reviewed-on: http://gerrit.openafs.org/724 Reviewed-by: Marc Dionne Tested-by: Marc Dionne Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 207882ec4fa91a69d1ec0f25d23a409fd19898de Author: Derrick Brashear Date: Fri Oct 23 17:50:09 2009 -0400 windows 1.5.66 make 1.5.66 for windows Change-Id: I04902106c35eea2dccf6db594c496302cde3f15b Reviewed-on: http://gerrit.openafs.org/723 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 944580c19566fbf1d6d2717cf21f9afd3ef93c14 Author: Derrick Brashear Date: Fri Oct 23 17:35:37 2009 -0400 make 1.5.66 for unix push version changes for 1.5.66 Change-Id: I5302e9aa83b4aba0081130934f0d6df0786ce43c Reviewed-on: http://gerrit.openafs.org/722 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 11cdb701556fc0430445caaf3a4c6955683d9bd7 Author: Michael Meffie Date: Thu Oct 22 15:51:33 2009 -0400 volser transaction object race conditions Fix the transaction object races between VolMonitor and the volume operation procedures which can cause the volume server to crash. Add a per transaction object mutex to safely set the transaction call pointer and name. Fix VolMonitor to safely traverse the transaction list and to access the call pointer and last proc name while copying info to send to the vos client. Fix the sleep thread to safely access the last proc name. FIXES 125479 Change-Id: I59595b93522d111b6a771d3d93c246bfc2ce65de Reviewed-on: http://gerrit.openafs.org/718 Reviewed-by: Andrew Deason Tested-by: Andrew Deason Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit bbcfbe1a04eda9e75b1643be88cf9d4842a8aa86 Author: Andrew Deason Date: Thu Oct 22 11:12:30 2009 -0500 Avoid prematurely destroying callback_rxcon Currently, h_GetHost_r and removeAddress_r can destroy the callback_rxcon of a host. Having a NULL callback_rxcon can cause segfaults in code that does not properly check if a host has been HOSTDELETED before trying to use it. Although such code is incorrect and should be fixed, we can still avoid a segfault in those situations by not destroying callback_rxcon until we destroy the host itself. This just prevents destroying callback_rxcon in h_GetHost_r and removeAddress_r, leaving it to h_TossStuff_r to destroy when it destroys the host. Change-Id: I6fd5cbb924053446689c576026f9044f78ba71be Reviewed-on: http://gerrit.openafs.org/717 Tested-by: Andrew Deason Reviewed-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit ed8d83e0f6b9825503643d1ee8398b2310946dd7 Author: Simon Wilkinson Date: Fri Oct 23 12:42:19 2009 +0100 Resolve error return issues in writepage The writepage_sync changes get error returns wrong in a couple of places. In particular, they return a 0 code from dopartialwrite in preference to the length return from page_writeback Change-Id: I34a848fed5f799aa6844e9ef0339321f91c7e59b Reviewed-on: http://gerrit.openafs.org/721 Reviewed-by: Marc Dionne Tested-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 5f720faab920a1007327de415ceaf187c16fdbe6 Author: Jeffrey Altman Date: Thu Oct 22 10:38:23 2009 -0400 Remove warning from all calls to afsconf_GetExtendedCellInfo Fix 'afsconf_GetExtendedCellInfo' : different types for formal and actual parameter 5 Change-Id: I922d653a88a9d0c04ed6dbd1c9c0b3fc90719337 Reviewed-on: http://gerrit.openafs.org/715 Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit ecfeb5365f7b7812529b8f6c269700f4ce30b45e Author: Jeffrey Altman Date: Fri Oct 23 00:16:01 2009 -0700 Windows: Notes for 1.5.66 ChangeLog description for 1.5.66 on Windows. Reviewed-on: http://gerrit.openafs.org/720 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit d0080431fab17c5e96f617ce78980adb3680d0f8 Author: Jeffrey Altman Date: Fri Oct 23 00:04:52 2009 -0700 Windows: Updates to Release Notes Add support for Windows 7 and Server 2008 R2. Improve text in a variety of areas. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/719 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit e16ce66634a85a870dae3323a2257953cfe571be Author: Simon Wilkinson Date: Tue Oct 20 12:38:53 2009 +0100 Refactor writepage_sync This change refactors writepage_sync into 4 functions - *) prepare_writeback() readies a vnode for writeback, and performs the anti-recursion check. *) dopartialwrite() intialises a request and performs the call to DoPartialWrite *) page_writeback() does the actual work of writing an AFS page into the disk cache page *) complete_writeback clears the writeback flag from a vnode There should be no change to the current behaviour of writepage_sync, these modifications are the first part of a fix to our writepage() behaviour. Reviewed-on: http://gerrit.openafs.org/712 Tested-by: Derrick Brashear Reviewed-by: Marc Dionne Reviewed-by: Derrick Brashear commit 234acbbb84534c5327bb69a2fcb7675dcd0d1198 Author: Jeffrey Altman Date: Thu Oct 22 10:27:41 2009 -0400 Windows: no longer use WinExec in afscreds WinExec is a compatibility interface for 16-bit applications. It is not compatible with Windows 7. Replace it with ShellExecuteEx. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/714 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 95cddea6da14d2dd58a2d5e5da775d26d647033f Author: Derrick Brashear Date: Wed Oct 21 14:42:23 2009 -0400 pthread pid casting in rx, we use pthread_self (which can return a pointer) as a pid; in order to not cause problems, cast it as we do elsewhere Reviewed-on: http://gerrit.openafs.org/703 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit cd2d4ceadcb3c52ec8e1b7bfd078b32226bd0d9f Author: Jeffrey Altman Date: Thu Oct 22 10:10:12 2009 -0400 rx lwp include assert.h where AFS_NT40_ENV builds can see it Reviewed-on: http://gerrit.openafs.org/713 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 196b2a2cb35eb85fe599e5faa946c93073935928 Author: Jeffrey Altman Date: Thu Oct 22 08:57:04 2009 -0400 Windows: Update Control Panel to use ShellExecuteEx instead of WinExec WinExec is for 16-bit application compatibility. Starting with Windows 7 it cannot be used to execute a process that requires elevated privileges. ShellExecute[Ex] must be used instead. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/711 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit a3bad94d1726a13460dd2c6f55f8742efa9c34d6 Author: Derrick Brashear Date: Thu Oct 22 08:07:43 2009 -0400 remove spurious log in icl fstrace should not log sets to the kernel message log Reviewed-on: http://gerrit.openafs.org/710 Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e83d382d208950029610ff04ec696b7ce6840a56 Author: Simon Wilkinson Date: Thu Oct 22 00:34:50 2009 +0100 Add -Wpointer-arith to warning and checking builds GCC doesn't catch issues with performing pointer arithmetic on (void *)s, unless the -Wpointer-arith warning flags is supplied. Enable it for warning and checking builds. Reviewed-on: http://gerrit.openafs.org/708 Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit 5f688ff4bd89aa0c73d96a51c0d5343a2ed2e843 Author: Derrick Brashear Date: Wed Oct 21 14:43:26 2009 -0400 rx don't exit exiting in library code is antisocial. if rx encounters an error which cannot be returned and would otherwise indicate a service thread has gone away, assert. Reviewed-on: http://gerrit.openafs.org/668 Tested-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman Reviewed-by: Tom Keiser commit 304f21cb7094e68224b22f8a91144f80207d7a3c Author: Simon Wilkinson Date: Thu Oct 22 00:31:10 2009 +0100 Fix fall out from removal of memset casts In places where we're doing pointer arithmetic, we must cast to (char *), because pointer arithmetic on a void * isn't permitted by the C standard. Sadly gcc lets us get away with it 'for convenience'. Reinstate the necessary casts. Reviewed-on: http://gerrit.openafs.org/707 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit a8a9c3c0f248d8ce0fbe7da701abb898adfe003c Author: Jeffrey Altman Date: Wed Oct 21 18:51:09 2009 -0400 Windows: Update MSI installer properties Reference useful web pages such as docs.openafs.org for help, www.openafs.org/windows.html for upgrade info, etc. Reviewed-on: http://gerrit.openafs.org/706 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 32b2f18628f4e7942e988111ba9903e9a2967754 Author: Jeffrey Altman Date: Wed Oct 21 18:41:59 2009 -0400 Windows: ports in the cache manager are stored in network byte order When assigning ports from SRV/AFSDB lookups, convert to network byte order when assigning them to cm_server objects. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/705 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 2a9263a451847f4f1fb4deff56ee68d73c70e5bc Author: Asanka Herath Date: Wed Oct 21 15:56:12 2009 -0400 Windows: Set the ARPINSTALLLOCATION property when installing The WiX based Windows Installer package for OpenAFS should set the ARPINSTALLLOCATION property when installing. This property contains the main installation directory for the product and is necessary for Windows Logo compliance. Reviewed-on: http://gerrit.openafs.org/704 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit b9eaf43bbe31ac20604e79b0fd4e35aa029a06bd Author: Simon Wilkinson Date: Wed Oct 21 17:34:30 2009 +0100 Don't cast the pointer past to memset memset() takes a void * as it's first argument. Don't explicitly cast what we're passing in to (char *), as this may mask other errors. Reviewed-on: http://gerrit.openafs.org/701 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 5d5d18071608d9782a5d936f79215048af641410 Author: matt@linuxbox.com Date: Sun Oct 11 20:52:26 2009 -0400 Make typedefs of AFS_UCRED and AFS_PROC with renaming Make typedefs of AFS_UCRED and AFS_PROC, with a corresponding name change. The names afs_ucred_t and afs_proc_t are chosen since these appear to be the best available choices. The names cannot actually collide with anything which POSIX might later introduce. For UKERNEL, the preprocessor is used to redirect references. This seems not easily avoidable at present. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/645 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit bf9c51a4e13b3e621b99866e9be53c8fe35a39fe Author: Andrew Deason Date: Tue Oct 20 12:43:42 2009 -0500 HPUX: Do not sigwait on critical signals On HPUX, it is possible for 'critical' signals such as SEGV, ABRT, etc to be delivered to the softsig thread when we sigwait(). The current code marks these as 'fatal' and just exit(0)s when they are received, preventing us from getting cores in the case of a SEGV, ABRT, etc. To work around this and keep behavior on other platforms the same, just do not wait on 'critical' signals on HPUX in the softsig thread. Reviewed-on: http://gerrit.openafs.org/693 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit 4141bf4084b3f473a8a756b42556c6273cd7c9bd Author: Jeffrey Altman Date: Wed Oct 21 09:14:51 2009 -0400 Windows: Add registry entries for rx_SetMinPeerTimeout, rx_SetMaxRecvWindow, rx_SetMaxSendWindow Permit the new rx settings to be configured via the registry and set at startup. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/700 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit c4263054a0c3101199d84527f36e18e2743169c4 Author: Jeffrey Altman Date: Wed Oct 21 09:13:22 2009 -0400 Add rx_SetMinPeerTimeout and rx_GetMinPeerTimeout Permit the minimum peer timeout value to be adjusted at runtime. The default remains 350ms. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/699 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 54d9c6cb34af3da75831b4b8c68cb40475eee1ea Author: Simon Wilkinson Date: Tue Oct 20 15:30:33 2009 +0100 Use real names for page lock operations Call a spade a spade. Don't use macros to rename lock_page as LockPage, and unlock_page as UnlockPage. Instead use the same names as the kernel, which makes it a lot easier for people familiar with kernel code to read ours. Reviewed-on: http://gerrit.openafs.org/692 Reviewed-by: Marc Dionne Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 040712a744dd5e021d20987c2e2a98ac0f129b15 Author: Jeffrey Altman Date: Wed Oct 14 23:43:46 2009 -0400 Windows: Modify afscreds.exe and afs_config.exe to be UAC compatible afscreds.exe: 1. disable the drive mapping and advanced tabs. 2. on exit, remove the option to stop the service. afs_config.exe: 1. disable the drive mapping tab Removing this functionality by default will address some of the problems while permitting users that wish to continue using these tools to do so. The drive mapping tab can be re-enabled setting the registry value to be non-zero: {HKCU,HKLM}\Software\OpenAFS\Client DWORD "ShowMountTab" LICENSE MIT Reviewed-on: http://gerrit.openafs.org/663 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit ee7399fa3795652c3d903e9af2baa9ba0174ca03 Author: Jeffrey Altman Date: Wed Oct 21 09:02:04 2009 -0400 Windows: Do not permit infinite attempts to obtain a pioctl file handle The recent change to detect sharing violations and initiate retries permits infinite attempts. Change this to a limit of 100 attempts and increase the sleep period between attempts from 1ms to 100ms. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/697 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 2e9dc9ee20181db0e3c6dbee0b51b0f8de5d52ec Author: Jeffrey Altman Date: Wed Oct 21 09:07:47 2009 -0400 Windows: digital signatures are required for resource dlls Windows 7 logo requirements state that all dlls including resource only dlls be digitally signed. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/698 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 7673b2450c9e7449d8165a0be5bbd8e0c063dfd2 Author: Jeffrey Altman Date: Wed Oct 14 22:06:38 2009 -0400 Windows: Adjust error return values Do not return STATUS_TIMEOUT to the smb redirector, doing so results in an undesireable disconnect. Map RXKADNOAUTH to STATUS_CLOCK_SKEW as that is the most frequent cause of rx level authorization failures. Map CM_ERROR_UNKNOWN to access denied since there is no better error choice. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/661 Reviewed-by: Asanka Herath Tested-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 310cec9933d1ff3a74bcbe716dba5ade9cc28d15 Author: Derrick Brashear Date: Tue Sep 29 05:34:30 2009 -0400 rx window size increase window size was previously pushed to 64; push to 128. as this increases memory use, anything further should be arguably tied to rx-using-program's resource allocation preferences, e.g. fileserver -LL should be willing to up this Reviewed-on: http://gerrit.openafs.org/549 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit b8e3de897a05ac07ea8cff5774d982ce6ad605b2 Author: Derrick Brashear Date: Tue Oct 20 15:03:09 2009 -0400 afscp warnings cleanup make the copy of afscp in src/tests compile with fewer warnings (and provide needed prototype for RXAFSCB_ExecuteRequest) Reviewed-on: http://gerrit.openafs.org/694 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman commit cc112e7a59d441d28a1d195cb48f23887df51929 Author: Jeffrey Altman Date: Tue Oct 20 16:16:47 2009 -0400 prevent rx peer timeout from reaching 0.0 seconds The rx peer timeout is computed from the round trip time calculation. It traditionally has had a lowerbound of 350ms. The computation in rxi_ComputeRoundTripTime() was incorrect and instead used 350ms as an upperbound. rxi_ComputeRoundTripTime() had a second problem wherein if the actually RTT is shorter than the resolution of the clock then the RTT would quickly approach 0.0 seconds. Enforce a lowerbound of 1ms if the RTT for a given packet appears to be 0.0 seconds. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/696 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e7e057346fa456cb27c54112a4dba311bcaf9aaf Author: Jeffrey Altman Date: Tue Oct 20 15:08:51 2009 -0400 Rx warning removal This patch set removes many but not all of the warnings in the rx library. - use AFS_PTR_FMT in dpf debugging output - fix many signed vs unsigned warnings - on Windows, the first parameter to select() is ignored. Passing an osi_socket produces an unnecessary warning. - In rx_SlowReadPacket and rx_SlowWritePacket, use 'r' the unsigned value for internal computation and 'resid' for holding the original value. This avoids many signed vs unsigned warnings. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/695 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c188acf396487be4b902549c215e3da5cda615ce Author: Jeffrey Altman Date: Tue Oct 20 12:32:22 2009 -0400 Windows: AFS_PTR_FMT is just 'p' The printf format specification for a pointer of any size is just 'p'. The 'I' is only to be used for [duox]. Reviewed-on: http://gerrit.openafs.org/690 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 840e4d2123e1e94adfc27ae0b286a11d472cf0fc Author: Andrew Deason Date: Sun Oct 18 22:48:56 2009 -0500 Avoid 'static __inline' on HPUX 'static __inline' functions on HPUX can segfault the /opt/ansic compiler (unless we lose debugging symbols). So, just use 'static' for those functions on HPUX. Also revert a9368a6c3dfe4435ec2ae63fff4a3325104ed9f7, so we get a static inline function on other platforms. Reviewed-on: http://gerrit.openafs.org/691 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit a26f10a01a39747cd275baa326adf8415c5648e4 Author: Simon Wilkinson Date: Tue Oct 20 13:38:08 2009 +0100 Remove pageoff macro The pageoff macro is now unused. Remove it. Reviewed-on: http://gerrit.openafs.org/689 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit bd011aeee7f5dad5c61fd81a90b296c46a0b9058 Author: Jeffrey Altman Date: Mon Oct 19 18:43:44 2009 -0400 Add server prefix to bumon.xg; avoid rx_call * vs rx_connection * warning When compiling src/bubasics/bumon.ss.c a warning would be produced due to an rx_call* being passed into BC_Print which in its client form requires an rx_connection*. The server implementation and client stub each were called BC_Print because there was no server prefix specified in bumon.xg. Add prefix 'S' and update bucoord/server.c to match. Reviewed-on: http://gerrit.openafs.org/686 Reviewed-by: Simon Wilkinson Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 3eec9fa7700de5d20a5c7eec8fc02f87ead1f342 Author: Simon Wilkinson Date: Mon Oct 19 23:56:12 2009 +0100 Return both error codes for rxfs_fetchInit The FetchStore refactoring was causing the result from rx_EndCall to be discarded. This change will cause that to be returned to the caller if rx_Error() returns 0 Reviewed-on: http://gerrit.openafs.org/687 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 6f2ce4cdc216ad5a3e8ed09a011a5f0681f098b4 Author: Simon Wilkinson Date: Fri Oct 16 16:39:24 2009 +0100 Always unlock pages when returning from writepage Writepage has a return path which returns an error with a locked page. However, all returns that are not AOP_WRITEPAGE_ACTIVATE must unlock their pages - using this codepath would leave a stray page lock, which would eventually hang the machine. The logic behind the -EIO return was also incorrect. In the Linux page cache model, truncates simply reduce the size recorded in the inode. If there are pages pending writeback then they may still have writepage() called upon them - it's up to the writepage routine to discard the write request (rather than returning an error) Reviewed-on: http://gerrit.openafs.org/685 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit ebf6516db2f1105e5ca8172f6d64038c6acc60bd Author: Andrew Deason Date: Thu Oct 15 13:15:44 2009 -0500 Fix a couple more unlink()s in vol-salvage.c There are a couple more unlink() calls in vol-salvage.c that were using relative paths. Fix them to use absolute paths and to log a warning if the unlink() fails. Reviewed-on: http://gerrit.openafs.org/684 Tested-by: Andrew Deason Reviewed-by: Derrick Brashear commit 6b0e4039c65262e68481ff43bc0cce531c5b39eb Author: Asanka Herath Date: Mon Oct 19 17:12:32 2009 -0400 Windows: Add a token status icon to the NIM plug-in The Network Identity Manager plug-in for OpenAFS replaces afscreds.exe for token management. However, unlike afscreds.exe, the plug-in did not indicate the status of AFS tokens using an icon in the notification area. This patch adds a token status icon to the plug-in so that while the plug-in is used, a familiar padlock icon in the notification area will indicate the status of tokens as well as the OpenAFS service. There are four possible states indicated by the icons: - No tokens: indicated by a padlock with a bright red 'X' beside it. - At least one valid token: indicated by a normal padlock. - Service is not running: indicated by a grayed out padlock with a black square beside it. - Service error: indicated by a padlock broken in half. The 'Service error' state means that the OpenAFS client service is technically running (as reported by Windows), but is not responding to requests. In addition to the icon, hovering the mouse cursor over the icon will show details about the current state (such as the list of cells for which valid tokens exist) and the version of OpenAFS running on the machine. Reviewed-on: http://gerrit.openafs.org/683 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit edbef134b7ee2abbd8e2b9639991e5906f3b8fb0 Author: Claudio Bisegni Date: Mon Oct 19 17:34:09 2009 +0200 AFSPreference Pane Mounts View refresh issue Resolved the bug that prevented to show the link description after it was added. Now the table is refreshed at any operation(add/remove). Reviewed-on: http://gerrit.openafs.org/682 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e82f3b210e0e49fb9d9531565f634ed9d49426a5 Author: Claudio Bisegni Date: Sun Oct 18 20:39:21 2009 +0200 OpenAFS Preference Pane 64bit and Symbolic Link features implemented. Now the OpenAFS preference pane is compiled with 32 and 64 bit snowleopard support, so the preference windows is no more restarted in 32 bit mode. The tab for symbolic link creation has been implemented. Now the user can create and delete link. For create a link both name and destination path must be set. AFSBackgrounder has been updated to manager in a separate thread the link creation and destroy operation, according to the vaule of checkbox "Enable Symbolic Link" in "Mounts" tab. Reviewed-on: http://gerrit.openafs.org/677 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 67395a7b6a3c83d3f15fae75cf78db9f60730bbc Author: Andrew Deason Date: Sun Oct 18 21:05:58 2009 -0500 Prototype encode_krb5_enc_tkt_part for aklog Prototype encode_krb5_enc_tkt_part in aklog_main.c, since it is a private interface so we don't get a prototype from the krb5 headers. Reviewed-on: http://gerrit.openafs.org/680 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit bb7f31bc3cd85557ddaf89e801572e0d933702af Author: Andrew Deason Date: Sun Oct 18 22:20:59 2009 -0500 Fix format warnings in tviced/state_analyzer.c state_analyzer.c assumes subtracting two char*s will result in an unsigned int, which can cause warnings. Lacking a portable format specifier, just use %ld and cast to long. Reviewed-on: http://gerrit.openafs.org/681 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 9818e3dce9461f08f4aafbfd99be5a48ac098464 Author: Andrew Deason Date: Sun Oct 18 20:46:27 2009 -0500 Fix a couple of size_t warnings fsprobe/fsprobe.c and kauth/ka-forwarder.c were trying to print size_t's without using AFS_SIZET_FMT. Fix that. Reviewed-on: http://gerrit.openafs.org/678 Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 3dbee6f66d3932d1e2e9141220c0e9f6623a9b94 Author: Andrew Deason Date: Sun Oct 18 20:47:43 2009 -0500 Prototype ka_log Prototype ka_log in kauth/kalog.h to prevent warnings. While we're at it, only prototype kalog_log and kalog_Init when they actually get implemented. Reviewed-on: http://gerrit.openafs.org/679 Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 9bbe16d33097b387c5f855de0ca7ba4c67631e67 Author: Simon Wilkinson Date: Sun Oct 18 12:07:37 2009 +0100 Fix warnings in tviced Prototype hpr_Initialize and hpr_End to remove warnings in the tviced build. Reviewed-on: http://gerrit.openafs.org/675 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit c9dc69afae4c359058f1f524a388f4cd059fdf10 Author: Andrew Deason Date: Fri Oct 16 14:30:34 2009 -0500 Log error messages in volser i/o errors Currently, in various places in src/volser/, we log/print an error message when some disk i/o error occurs, but we don't log what error was returned. Log that little bit more info to make debugging easier in some cases. Reviewed-on: http://gerrit.openafs.org/671 Tested-by: Andrew Deason Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c4f190ca605597fd31972192c65363117863e262 Author: Simon Wilkinson Date: Fri Oct 16 23:15:52 2009 +0100 More warning fixes for kauth Resolve more minor warnings from the kauth directory. *) kaux_read takes an unsigned for the number of failures *) The COUNT_REQ macro generates an unused variable (this_op) *) kas is missing some headers *) Add some more prototypes to kauth_internal.h *) Add the standard boilerplate to kauth_internal.h *) recvfrom takes a socklen_t * as its 6th argument This make kaprocs.c, kaauxdb.c, kas.c, klog.c, and ka-forwarder.c warning clean. Mark them as such. Reviewed-on: http://gerrit.openafs.org/673 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 3064879c8d69ca9541c622e9f3f90e7c1e35c26c Author: Simon Wilkinson Date: Fri Oct 16 22:45:50 2009 +0100 Update warning management This change tidies up after the recent slew of warning reduction. It updates README.WARNINGS to reflect the current state of the tree, disables warnings for a couple of files that are now warning clean, and ensures that the libuafs and libafsrpc Makefiles match the state of the rest of the tree in terms of which warnings are enabled. Reviewed-on: http://gerrit.openafs.org/672 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 7de8be52f5720f865fdfbf59772df1f2ab1bd8e5 Author: Simon Wilkinson Date: Sun Oct 18 12:44:56 2009 +0100 Use ranlib -c for Mac OS X Leopard Building with --enable-demand-attach-fs requires that ranlib -c be used on Leopard (it is already the default for Tiger) Reviewed-on: http://gerrit.openafs.org/676 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 20a5b58e23ceab1c6be60e173e631ee8fb6834a5 Author: Simon Wilkinson Date: Sat Oct 17 08:49:03 2009 +0100 afs_Conn must be called within the analyze loop afs_Analyze calls afs_PutConn, so each pass through the afs_Analyze loop must call afs_Conn to get a new connection handle. afs_CacheStoreVCache (part of the fetchstore refactoring) wasn't doing this, and so producing garbage data upon retries. Reviewed-on: http://gerrit.openafs.org/674 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f3d5b94f2e2dfcdb5c626a42b6be4f1e412f4a33 Author: Jeffrey Altman Date: Fri Oct 16 15:28:04 2009 -0400 Windows: Always compute time remaining in cm_Analyze In cm_Analyze, the time remaining for processing the request is used to determine if a retry should requested upon return. If the request's CM_REQ_NORETRY flag is set, cm_Analyze can still permit a retry if a new rx connection is to be forced. This cannot happen if the time remaining is not calculated when the CM_REQ_NORETRY flag is set. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/670 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 2285341b5f009329d84f1ccdb6bcadcb6a507047 Author: Jeffrey Altman Date: Fri Oct 16 15:31:02 2009 -0400 Windows: mark volume status online during cm_MergeStatus During cm_MergeStatus, if the volume status is not vl_online mark it vl_online. The volume must be online because an AFSFetchStatus was just processed. This change reduces the amount of work that must be performed by the daemon thread's volume status check. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/669 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 3abc87a5a94f0d5eaca702c7bd66fbe35ce7b896 Author: Marc Dionne Date: Thu Oct 8 21:53:03 2009 -0400 Linux: kmem_cache_create fix and cleanup Fix the kmem_cache constructor function to match the current expected prototype, and cleanup related code. This has been wrong for a while, but since we were just passing extra parameters the only effect was to generate a warning. - Add a new configure test to detect the new constructor function signature - Define the older versions of the constructor in osi_compat.h, making them call the current version - Move a few compatibility #defines to osi_compat.h Reviewed-on: http://gerrit.openafs.org/657 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 508bcd69b5ad55bcadf26d9b748f175c7a33ce77 Author: Andrew Deason Date: Thu Oct 15 13:48:08 2009 -0400 Fix rxgen-generated warnings Prevent rxgen from generating code that produces warnings at compile time. * Add print_ifarg_with_cast(). Used within print_ifstat() to generate a member in an argument list complete with a type cast. The type cast may be a pointer to the type or the type depending on the value of the 'ptr_to' parameter. * When print_ifstat() generates the output for an opaque vector, cast the object to 'caddr_t' as xdr_opaque() accepts an argument of type 'caddr_t'. * When print_ifstat() generates the output for an opaque array, cast the object to 'char **' because xdr_bytes() accepts an argument of type 'char **'. * When print_ifstat() generates the output for any array that is not opaque or string, cast the object to 'caddr_t' because all of the xdr_XXX() functions other than xdr_opaque and xdr_bytes accept an argument of type 'caddr_t'. * When print_ifstat() generates the output for an alias, cast the output to a pointer to the specified type because xdr_ accepts an argument of type ' *'. This addresses warnings generated when compiling fsint/Kvice.xdr.c and fsint/afsint.xdr.c. Reviewed-on: http://gerrit.openafs.org/664 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit fe68604f113773c1ffcb6d83d4a2febc3e0e3ed8 Author: Derrick Brashear Date: Fri Oct 16 10:44:58 2009 -0400 exit less start cleanup of calls to exit scatter into library code. ugen_ callers handle error returns correctly; rmtsys already deals with errors; and rx_pthread can already deal with errors in the case that's fixed Reviewed-on: http://gerrit.openafs.org/667 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 50313a72a99ab312a796108d807aef0f6b4d2ca9 Author: Derrick Brashear Date: Thu Oct 15 19:21:54 2009 -0400 snowleopard 64 bit warning death make all errors from warnings when compiling on snowleopard die as a note, the ukernel pid, and pthread self as id changes, probably should be revisited, but for now i have changed nothing. it should be a separate change. Reviewed-on: http://gerrit.openafs.org/666 Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 58628eb745acdf4b1b7e9f5ab828e4ca0fa18b81 Author: Andrew Deason Date: Sun Oct 11 21:55:05 2009 -0500 Detect and use %zu for size_t when available Commit db949b7fade69d7eb1e38ad85d5b822c443306cb was incorrect and generated warnings on many platforms; we cannot determine the correct format string for a size_t at compile-time. Instead use the %z length modifier when we can detect that it is safe to use. Otherwise, fall back to just %lu on Unix, since it is reasonable to assume sizeof(size_t) == sizeof(unsigned long) on Unix. Reviewed-on: http://gerrit.openafs.org/647 Reviewed-by: Russ Allbery Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 1fa650cee2d6cc708ee29a963ad3498a808bbde8 Author: Andrew Deason Date: Wed Oct 14 22:43:27 2009 -0500 Fix unitialized variable warning in cfghost.c Initialize cellentry. It does not appear to be possible to actually hit code that references an uninitialized cellentry, but the compiler can still complain. Reviewed-on: http://gerrit.openafs.org/665 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 862390a987f5ef4438079e7d1e961c7ddafb94ac Author: Jeffrey Altman Date: Tue Oct 13 23:36:26 2009 -0400 Windows: AFSVolSync creationDate based readonly volume versioning Implement readonly volume versioning based upon the .readonly volume creation date as reported in the AFSVolSync output parameter of every RXAFS RPC. Whenever a new callback is obtained for an object stored within a .readonly volume, the volume creation date is recorded in the cm_volume object along with the callback expiration time and a reference to the server that issued it. These values are used to determine if a callback is present when the cm_scache object's volume creation date matches the cm_volume object's volume creation date. If there is no match, the cm_scache object's individual callback information is used to determine whether a callback has been registered. This mechansism ensures that the whole-volume callback issued in response to a RXAFS_FetchStatus request against a .readonly volume can be applied to all objects that are cached from the same version of the .readonly volume instance. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/654 Tested-by: Jeffrey Altman Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Alistair Ferguson Reviewed-by: Jeffrey Altman commit 0468b18058332a21c52dd336eaea9768de271208 Author: Jeffrey Altman Date: Wed Oct 14 22:33:11 2009 -0400 Windows does not provide sys/wait.h sys/wait.h was added to butm/file_tm.c by patch set 789580d13591ff1aa53cfbf5fef4d46b0b65c805 (gerrit 635) Reviewed-on: http://gerrit.openafs.org/662 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 25882899879531d7bea20ab2d8c1e3dea0a7975b Author: Simon Wilkinson Date: Sat Oct 10 00:30:01 2009 +0100 Fix checked builds with gcc4.2 Recent change sets removed the 'ignore-all-warnings' mode from a number of files, in favour of using the implicit-function-declaration pragma. Sadly, that pragma isn't available in gcc 4.2. Revert the Makefile changes such that ignore all warnings is turned back on for the affected files, and note this in README.WARNINGS Reviewed-on: http://gerrit.openafs.org/639 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 41baf5c58fabc62145731be1d6c99c833c8ee003 Author: Derrick Brashear Date: Wed Oct 7 09:21:53 2009 -0400 add SRV record lookups to unix afsconf support suite also create new api call afsconf_LookupServer make afsconf_GetAfsdbInfo call it include T_SRV support Reviewed-on: http://gerrit.openafs.org/594 Reviewed-by: Simon Wilkinson Tested-by: Simon Wilkinson Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman commit 34c71e6b11e4e7fae40fa64a998a564feaa4a4b0 Author: Simon Wilkinson Date: Wed Oct 14 22:27:34 2009 +0100 Add fsint dependency to audit builds The 'audit' target requires that fsint is built first. Express this as a make dependency. Reviewed-on: http://gerrit.openafs.org/660 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 94ceae1220538dec8ba3400b1368b599fe28197d Author: Jeffrey Altman Date: Mon Oct 12 21:57:52 2009 -0400 Windows: refactor afs status cloning and clone when fs fetchdata bug detected When the file server fetchdata invalid length bug is detected the cache manager must fake the AFS Status info for the file as well as the AFSVolSync info. Otherwise, the merge status is incorrect. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/651 Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman commit a394d74e4462a2a3e006ca161f22e35a9f44a77c Author: Jeffrey Altman Date: Wed Oct 14 09:26:27 2009 -0400 Revert "Windows: Readonly Volume Versioning for Windows Cache Manager" This reverts commit bb6e38a45b8b5061cd4c9613262fa015957fb8d8. Reviewed-on: http://gerrit.openafs.org/659 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 5a403db74efc732c3695fb60d4baa652656151a5 Author: Jeffrey Altman Date: Tue Oct 13 22:35:55 2009 -0400 Windows: fix build due to broken src/volser/NTMakefile Commit 82aa5b4e09ac8a550525efd0e357783a3b3aed88 incorrectly updated the src/volser/NTMakefile resulting in a broken build system. Reviewed-on: http://gerrit.openafs.org/658 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 958f54766452d3468e849570114fe1ff685bb0cc Author: Marc Dionne Date: Tue Oct 13 21:52:47 2009 -0400 Linux: Remove declaration of unused variable filp filp is unused after the recent rework of osi_file.c Reviewed-on: http://gerrit.openafs.org/656 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 789580d13591ff1aa53cfbf5fef4d46b0b65c805 Author: Andrew Deason Date: Fri Oct 9 10:17:43 2009 -0500 Fix warnings in butc, tbutc, and butm tbutc: - Ignore warnings for dump.c butc/dump.c: - butm_WriteFileData takes a char*, no need to cast buffer - volumeHeader_hton takes a struct volumeHeader*, though, need to cast buffer there - Ignore strict prototypes butc/recoverDb.c: - scanVolData takes a uint*, not an int* - Initialize nbytes to 0 - Remove warning inhibition butc/tcmain.c: - atocl takes an int*, not a uint* - Ignore implicit function declaration warnings butc/tcudbprocs.c: - Ignore implicit function declaration warnings (ubik stuff) butm/file_tm.c: - Include sys/wait.h for the waitpid() prototype Reviewed-on: http://gerrit.openafs.org/635 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 664e5aca1692b664cfacd906bd4e632baedf4a4b Author: Jeffrey Altman Date: Mon Oct 12 14:20:00 2009 -0400 Windows: If SecurityLevel is configured use it for vos.exe and pts.exe If the SecurityLevel registry value indicates that crypt should be the default, then always set -encrypt for vos.exe and pts.exe. Reviewed-on: http://gerrit.openafs.org/648 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 78d8b8c5c19b8d6873b2d62beaa60cc7acba1840 Author: Andrew Deason Date: Thu Sep 24 12:02:55 2009 -0500 Use f_bsize for ZFS afs_fsfragsize On ZFS, the disk space files can use up can be rounded up to the next recordsize boundary if they've been truncated. This can cause the Unix CM to mis-estimate cache usage, since it truncates files fairly often, and assumes the disk space used is the file length rounded up to the next f_frsize. Since the ZFS recordsize is available via the statvfs f_bsize, just round up to that instead. There is still some additional file metadata that takes up some additional space on disk, but according to ZFS people I've spoken to about this, it cannot be known in advance. In practice, the additional metadata storage doesn't appear to exceed about 10% of the data storage, which should be acceptable. FIXES 125365 Reviewed-on: http://gerrit.openafs.org/650 Reviewed-by: Derrick Brashear Tested-by: Andrew Deason commit 82aa5b4e09ac8a550525efd0e357783a3b3aed88 Author: Simon Wilkinson Date: Fri Oct 9 21:17:16 2009 +0100 Add public protoypes for volser Add a new public header file volser_prototypes.h, which contains prototypes for those volser functions that are used by the rest of the tree, and link it into the Unix and Windows build systems. Rename the current volser_prototypes.h volser_internal.h, and update references to it. Make those places that should use the new public header use it, and re-enable warnings-as-errors as appropriate. Remove the warning free files from the list in README.WARNINGS Add butm_prototypes.h to butc/lwps.c, so we can enable warnings for that, too. Reviewed-on: http://gerrit.openafs.org/636 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 9bd725692787534c5fb0d209b69be1de01c3cdf2 Author: Andrew Deason Date: Mon Oct 12 13:26:57 2009 -0500 Formatting typos in pts.pod Fix a couple of B<...> sequences pod2man yells at us about. Reviewed-on: http://gerrit.openafs.org/649 Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit 633047c378b58b4bcd7e9dac046224955e868ea9 Author: Simon Wilkinson Date: Fri Oct 9 21:21:23 2009 +0100 Add afsio to gitignore Add the new afsio binary to the appropriate .gitignore file Reviewed-on: http://gerrit.openafs.org/637 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit bb6e38a45b8b5061cd4c9613262fa015957fb8d8 Author: Jeffrey Altman Date: Mon Oct 5 14:00:50 2009 -0400 Windows: Readonly Volume Versioning for Windows Cache Manager When the HKLM\SYSTEM\CurrentControlSet\Services\TransarcAFSDaemon\Parameters "ReadOnlyVolumeVersioning" DWORD registry value is non-zero, the volserver will be queried for each .readonly volume to obtain the lastUpdateTime. The lastUpdateTime will be used as a volume version identifier for each cm_scache_t object stored in the volume. With a known volume version, whenever a current status is obtained for any object within the .readonly volume, all the cached objects within that volume that have the same volume version can share the resulting callback registration. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/579 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit e026fcb2f03d792c80a81d99435a4ecdebba8fc9 Author: Jeffrey Altman Date: Sun Oct 11 18:06:25 2009 -0400 Windows Explorer Shell Extension: Remove OutputDebugString calls Remove all OutputDebugString calls from the explorer shell extension. OutputDebugString() requires acquiring system global locks. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/643 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 93fb21a8d090cea1ce25d0394bff921c44096575 Author: Jeffrey Altman Date: Mon Oct 12 08:28:54 2009 -0400 Windows: Correct lock error codes and log file server lockCount The error codes that should be returned when a lock request fails are: STATUS_LOCK_NOT_GRANTED for an explicit lock request STATUS_SHARING_VIOLATION when a CreateFile fails due to a previous lock Correct the service to ensure that these values are in fact returned. Also, add 'fsLockCount' field to cm_scache_t and dump its value as part of the "fs memdump" output. This permits some ability to identify what the file server thinks the lock count is. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/646 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 917a860e818d5cdda82add0d4d50b594820816f2 Author: Jeffrey Altman Date: Mon Oct 5 14:34:59 2009 -0400 Improve accuracy of Rx RTT calculation by skipping retransmitted packets Rx RTT calculations are based on Van Jacobson's work using constants that make computations fast but are not necessarily the best for modeling Rx protocol exchanges. This patch does not alter the constants but does improve the comments to show that the math is correct. Phil Karn in 1987 demonstrated that Van Jacobson's algorithms produced inaccurate results when the RTT computed from an acknowledgement of a retransmitted packet were included. The resulting RTT would either be too small causing the system to retransmit too many packets or too long resulting in too few being sent. This patch follows Phil Karn's advice which was also adopted as mandatory for TCP in RFC2988. Retransmitted packets and delayed acks are skipped and the retransmit time is backed off (up to a maximum of 3 seconds) until a successful acknowlegement is received for an initially transmitted packet. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/580 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 76ae0f51892a703d7bd4aea5fdcf60c586e4a440 Author: matt@linuxbox.com Date: Sat Oct 10 09:09:53 2009 -0400 Use AFS_PROC consistently Make consistent use of AFS_PROC in portable and mixed files, adding the define for platforms which lacked it. This completes a change that has been ongoing for several years. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/642 Reviewed-by: Simon Wilkinson Tested-by: Simon Wilkinson Reviewed-by: Derrick Brashear commit d705e26eac5c4327ef1499cd59228e123f03971f Author: Simon Wilkinson Date: Sat Oct 10 00:46:08 2009 +0100 Revert "Linux: kmem_cache_create fix and cleanup" This reverts commit 6133d25397b8365d450c99b8bc147972f8600074. This patch breaks builds on RHEL5.3 - revert it until we can come up with a fix. Reviewed-on: http://gerrit.openafs.org/640 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit dc94d7da5f6767d0de4e11e8b41408394092a48b Author: Jeffrey Altman Date: Thu Oct 8 08:59:15 2009 -0400 Windows: use port when finding server by address Modify cm_FindServerByIP to search by port as well. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/607 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 8788462b65eca3e4b25f0e5bda44eac43a135d79 Author: Jeffrey Altman Date: Fri Oct 9 06:23:10 2009 -0400 Windows: Prevent fs fetchdata offset bug error from propagating to caller When the file server fetchdata offset bug is triggered and detected, not only do we have to behave as if 'length_found' is zero, but we also must ignore the RXGEN_CC_UNMARSHAL error that will be returned from rx_EndCall() due to the parsing error that occurred during the rx_Read32() call. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/634 Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman commit 6133d25397b8365d450c99b8bc147972f8600074 Author: Marc Dionne Date: Thu Oct 8 21:53:03 2009 -0400 Linux: kmem_cache_create fix and cleanup Fix the kmem_cache constructor function to match the current expected prototype, and cleanup related code. This has been wrong for a while, but since we were just passing extra parameters the only effect was to generate a warning. - Add a new configure test to detect the new constructor function signature - Define the older versions of the constructor in osi_compat.h, making them call the current version - Move a few compatibility #defines to osi_compat.h - Clean up the call to kmem_cache_create by introducing an inline afs_kmem_cache_create in osi_compat.h Reviewed-on: http://gerrit.openafs.org/621 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 6d59a0fcd04b7eaa917a84b98c7a932734e69b91 Author: Andrew Deason Date: Thu Oct 8 17:50:06 2009 -0500 Fix warning in vol/namei_ops.c Commit 906403c6d770026fd9da606ea468e47ee911f896 introduced a warning by making 'error' unused anywhere. Remove the declaration, as well. Reviewed-on: http://gerrit.openafs.org/620 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 94eae9ed26c9de6d30f2abf3b856412503359270 Author: Davor Ocelic Date: Thu Oct 8 23:03:06 2009 +0200 Update README with solved/pending docs tasks Reviewed-on: http://gerrit.openafs.org/618 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 04fa499ac9285f51fdbc2ff724c2a1bd7f0e5d58 Author: Davor Ocelic Date: Thu Oct 8 23:01:39 2009 +0200 Update backup suite manpages -- Add missing POD links (L<>) -- Verify all subcommands and options -- Format > 80 columns synopsis lines Reviewed-on: http://gerrit.openafs.org/617 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit a6e15c992e0d1d4a6934917acacc864160846eb0 Author: Davor Ocelic Date: Thu Oct 8 22:58:31 2009 +0200 Update fstrace suite manpages -- Add missing POD links (L<>) -- Verify all subcommands and options -- Format > 80 columns synopsis lines Reviewed-on: http://gerrit.openafs.org/616 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 923721f8396178902a001887497566b8a8d2efa4 Author: Davor Ocelic Date: Thu Oct 8 22:57:03 2009 +0200 Minimal left docs updates for vos suite Reviewed-on: http://gerrit.openafs.org/615 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit eb46f02e560653d8fa72b7ef453b87c8f1986575 Author: Andrew Deason Date: Thu Oct 8 13:15:00 2009 -0500 Typo in vos_remsite.pod A typo in c717fcd32cabbc9651b81ef3d0cea11d3a6ecd57 removed the = before the first head1 in vos_remsite.pod. Put it back. Reviewed-on: http://gerrit.openafs.org/612 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 065d9a65ba90505b6a1a2ad58b7e208028a17ced Author: Davor Ocelic Date: Thu Oct 8 19:32:36 2009 +0200 Add POD links (L<>) in pts.pod and symlink.pod Reviewed-on: http://gerrit.openafs.org/610 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c717fcd32cabbc9651b81ef3d0cea11d3a6ecd57 Author: Davor Ocelic Date: Thu Oct 8 19:31:00 2009 +0200 Update vos suite manpages Larger collection of all vos suite commands, including but not limited to: -- documented all commands / options, verified against both 1.4 and 1.5 tree (including the common -encrypt/-noresolve options) -- correct order, POD formatting and synopsis for all commands' options -- shorthand synopsis provided for all commands that missed it, with proper non-ambiguous command abbreviations of all options -- POD synopsis formatted to 80-columns in commands where it was running over -- for newer options, documented which OpenAFS version they became available -- proper manpage links using L<> in vos.pod Reviewed-on: http://gerrit.openafs.org/609 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit dde6f7d84087ad7a99bc7694f58521d6947c0665 Author: Davor Ocelic Date: Thu Oct 8 19:20:33 2009 +0200 Allow check-pod to work on specific files or dirs Reviewed-on: http://gerrit.openafs.org/608 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f387806bd43e9fa357b48a5c9381d1434a311f2e Author: Davor Ocelic Date: Thu Oct 8 19:33:26 2009 +0200 Update readme with solved and pending tasks Reviewed-on: http://gerrit.openafs.org/611 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 8314001bdb305204467adfb27b3dfa2e6890a3b1 Author: Andrew Deason Date: Wed Oct 7 15:57:04 2009 -0500 Reduce warnings in vos.c Squash a few miscellaneous that appear when building vos.c: -- CreateVolume should use util_GetUInt32 to parse vol ids, since they are now unsigned -- The m_uuid argument of print_addrs is altered, so do not declare it const -- Declare the confDir argument of ugen/vsu_ClientInit to be const, since it does not change, and vos.c passes a const confDir in MyBeforeProc -- Ignore implicit function declaration warnings and remove CFLAGS_NOERROR from the vos.c build, since the only remaining warning is an implicit function declaration Reviewed-on: http://gerrit.openafs.org/602 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit c8482d0fb97b3cfe0445c14a605af8c2d00fb50d Author: Andrew Deason Date: Wed Oct 7 17:33:02 2009 -0500 Fix warnings in rxkad Some miscellaneous warnings throughout rxkad: rxkad/ticket5.c: - Explicitly cast ticket blob to unsigned char*, as some functions take a ticket as a char*, and some take it as an unsigned char* - in tkt_DecodeTicket5, make 'start' and 'end' be unsigned, since that is what their callers think they are - Ignore implicit function declaration warnings (for CRC functons) - Remove general warning inhibition rxkad/ticket.c: - in tkt_DecodeTicket, make 'start' and 'end' be unsigned, since that is what their callers think they are - Remove general warning inhibition rxkad/v5der.c: - In decode_enumerated, use der_get_unsigned instead of der_get_int, since we're decoding an unsigned integer. rxkad/rxkad_server.c: - The last two arguments to rxkad_DeriveXORInfo are char*s, so explicitly cast them to be so - Remove general warning inhibition rxkad/rxkad_common.c: - rxkad_stats_t has had a couple of spares transform into clientObjects/serverObjects; account for them and don't overrun the spares array Reviewed-on: http://gerrit.openafs.org/600 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 549002c906795f978eebf81c706995116a04a8ff Author: Andrew Deason Date: Wed Oct 7 16:42:42 2009 -0500 Remove warnings related to type-punning cmd/cmd.c: - Just make dummy be a struct cmd_item instead of casting rxdebug/rxdebug.c: - Access the stats packet through a union instead of casting and dereferencing util/uuid.c: - Access the seed through a union and an array instead of that incrementing-pointer approach Reviewed-on: http://gerrit.openafs.org/599 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 7197d35ef181bdbbe813ec7fd9c7e5173b801bdb Author: Jeffrey Altman Date: Thu Oct 8 08:35:09 2009 -0400 Windows: use xdr_alloc to allocate memory for Callback data structs xdr_alloc must be used instead of malloc in SRXAFSCB_GetLocalCell and SRXAFSCB_GetCacheConfig LICENSE MIT Reviewed-on: http://gerrit.openafs.org/606 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear commit 7f7b4c9aad5deb5be62825ed6b88ca17093c0da6 Author: Marc Dionne Date: Thu Oct 8 08:12:28 2009 -0400 authclient.c: fix 64-bit specific warnings Commit 36be36e034141ded8fff5ff2edab3223b23c9fcf introduced some casts from an integer type to void *. This generates warnings on a 64-bit platform. Use uintptr_t casts to make the compiler happy. Reviewed-on: http://gerrit.openafs.org/605 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 3ea144bde535f405f1cef101daa461e0bbbf0fc5 Author: Jeffrey Altman Date: Thu Oct 8 07:25:24 2009 -0400 Add missing variable to afsio Callback variable missing in WriteFile LICENSE BSD Reviewed-on: http://gerrit.openafs.org/604 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Reviewed-by: Hartmut Reuter Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e249aace420e20996fef8ace2b5051d5bbdcd809 Author: Jeffrey Altman Date: Tue Oct 6 14:46:09 2009 -0400 Permit DNS SRV record lookups to be used by the Windows afsconf_GetAfsdbInfo Permit DNS SRV record lookups to be used by the Windows afsconf_GetAfsdbInfo As per the published DNS SRV internet draft for the AFS3 protocol, DNS SRV records are to replace AFSDB records as the primary method of looking up AFS3 service location information. In order to make that happen for Windows: 1. afsconf_GetAfsdbInfo must be able to translate from internal service names to IANA assigned service names. 2. The Windows getAFSServer() API must accept IANA service and protocol parameters as well as the port number to use if AFSDB record fallback is required. 3. The Windows cache manager must pay attention to the port number stored within the sockaddr_in structure instead of using hard coded values based upon the server type. For afsconf_GetAfsdbInfo, in addition to searching for the requested IANA service, if that service is prserver or kaserver fallback to the vlserver record (if any). LICENSE MIT Reviewed-on: http://gerrit.openafs.org/593 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 38ffa111190548f2648f15dd7f1d3469c7f96e08 Author: Andrew Deason Date: Wed Oct 7 17:14:08 2009 -0500 xdrproc_t functions take a caddr_t, not caddr_t* Callers of xdrproc_t functions give the function a foo* as the second argument, not a foo**, and the xdrproc_t functions themselves expect this. Make the xdrproc_t typedef accurately reflect that, thereby ridding us of some warnings. Reviewed-on: http://gerrit.openafs.org/603 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 1d8118d3da8251ecbb18743fbaff6ebd3330f484 Author: Andrew Deason Date: Wed Oct 7 16:39:18 2009 -0500 Ignore libafsrpc warnings for shlibafsrpc also Some warnings were ignored in libafsrpc, but not in shlibafsrpc. Ignore them in both places. Reviewed-on: http://gerrit.openafs.org/601 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 8ef41263cfaff03cd5c33a0278d327596c68b730 Author: Andrew Deason Date: Wed Oct 7 17:07:52 2009 -0500 Fix warnings in lwp/process.c -- The EP/ep function does not return anything; declare the function pointer accordingly -- Explicitly cast &stackvar to char* to avoid a warning Reviewed-on: http://gerrit.openafs.org/598 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 36be36e034141ded8fff5ff2edab3223b23c9fcf Author: Andrew Deason Date: Wed Oct 7 17:48:52 2009 -0500 Fix warnings in kauth/authclient.c -- In ka_Authenticate, explicitly cast 'start' and 'end' to void*, since kawrap_ubik_Call takes all arguments as void*s -- Fix kawrap_ubik_Call to not be an old-style declaration -- Only ignore strict prototypes and implicit function declaration warnings Reviewed-on: http://gerrit.openafs.org/597 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f512597b0ad288081930c1e578f76a3d417aab23 Author: Andrew Deason Date: Wed Oct 7 17:16:30 2009 -0500 Remove a pointer->integer warning in fstrace.c Explicitly cast eparm to a long in afs_syscall when calling proc_afs_syscall, to avoid a warning. Reviewed-on: http://gerrit.openafs.org/596 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 72c2473724e1b0a8cdc4a9e3e7639d80e5ec1086 Author: Andrew Deason Date: Wed Oct 7 17:19:22 2009 -0500 Prototype strcasestr in afsmonitor.c If we HAVE_STRCASESTR, we lack the prototype for strcasestr in afsmonitor.c unless we def _GNU_SOURCE before including string.h on GNU systems. To avoid side-effects or pulling in extra stuff, just prototype strcasestr ourselves for the time being (if we have it) instead of def'ing _GNU_SOURCE. Reviewed-on: http://gerrit.openafs.org/595 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit db949b7fade69d7eb1e38ad85d5b822c443306cb Author: Andrew Deason Date: Wed Oct 7 14:52:02 2009 -0500 Correct and use AFS_SIZET_FMT On *nix, a size_t needs either %lu or %u to be interpolated in a string, depending on if we're on an ILP32 arch or not. Define AFS_SIZET_FMT accordingly, and actually use AFS_SIZET_FMT when we try to print a size_t. This removes numerous -Wformat warnings, at least when building on i386_linux26. Reviewed-on: http://gerrit.openafs.org/592 Reviewed-by: Matt Benjamin Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 6ef4627412ed554f3a3c0d7c2e1b9132b3a624d0 Author: Michael Meffie Date: Sat Jul 25 15:28:07 2009 -0400 Allow gnu-style long options New users are surprised when OpenAFS command options cannot be prefixed with two dashes, as is common with most modern tools. Permit an extra dash for common commands when more than one character is given. For example vos listvol --server foo.bar.com is equivalent to vos listvol -server foo.bar.com, but vos listvol --s foo.bar.com is an error. Reviewed-on: http://gerrit.openafs.org/216 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 1793f454e4bb4f0eb5cbe9009ddb6bd48cc1cfd3 Author: Hartmut Reuter Date: Wed Oct 7 15:26:42 2009 +0200 pioctl with VIOC_FS_CMD removed This should ease the ingtegration for Windows. Instead RXAFS_FetchStatus is called. Reviewed-on: http://gerrit.openafs.org/590 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 811418887df505b9012a96802aa3dc3281b302e7 Author: Jeffrey Altman Date: Tue Oct 6 11:03:27 2009 -0400 Build afsio on Windows; remove many warnings With this commit afsio builds on Windows. It will not work until the VIOC_FS_CMD OSD extension is implemented in the Windows Cache Manager. Required changes: * Export ugen_ClientInit from libafsauthent.dll * Fix util_GetInt64 and util_GetUInt64 to return afs_int32 instead of afs_int64 since it is just returning success or error * Define VIOC_FS_CMD for Windows even though it isn't implemented LICENSE BSD Reviewed-on: http://gerrit.openafs.org/587 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 906403c6d770026fd9da606ea468e47ee911f896 Author: Andrew Deason Date: Wed Oct 7 12:14:11 2009 -0500 Make namei convertROtoRW'd volumes usable Right now, if you convertROtoRW a volume on namei, the converted volume appears to need a salvage before it is usable, and the header of the old (now empty) RO volume is kept around. Fix this: -- Set inUse = 0 on the converted volume, so the fileserver will be able to attach the volume when we give it back -- Unlink the RO header file, instead of trying to unlink the VI_VOLINFO file twice -- Log the actual error code (errno) in the error message for the last unlink Reviewed-on: http://gerrit.openafs.org/591 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e3d1eaf0ca6bfddede5aba1d1fc3f1e25cdb259e Author: Simon Wilkinson Date: Fri Oct 2 23:15:26 2009 +0100 Use page_offset() on Linux Since time began, Linux has provided page_offset() to turn a page index into an offset into the corresponding file. Make us use this everywhere we calculate a page offset, rather than doing our own maths. Reviewed-on: http://gerrit.openafs.org/581 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 5d7084fc5e5cfb47a36ea2d26a74b0b5bbd7724a Author: Jeffrey Altman Date: Tue Oct 6 09:33:45 2009 -0400 Windows: fs listacl -cmd Add the new functionality from the Unix fs command to Windows. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/585 Tested-by: Jeffrey Altman Reviewed-by: Hartmut Reuter Reviewed-by: Jeffrey Altman commit e74f81955568f68ed2d5166f5dea3f20706bf4f3 Author: Jeffrey Altman Date: Tue Oct 6 09:48:57 2009 -0400 documentation for "fs listacl -cmd" LICENSE BSD Reviewed-on: http://gerrit.openafs.org/586 Reviewed-by: Matt Benjamin Reviewed-by: Hartmut Reuter Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit ea78369ab6e67dfc7d9fbc355efe333ec057a50d Author: Derrick Brashear Date: Mon Oct 5 12:45:26 2009 -0400 afs_FindService should handle iana portnames right now we compare against /etc/services, and a hardcoded array. but since there's no guarantee /etc/services will be useful, this can mean inconsistent behavior. hardcode the iana names in the table, and take the internal structure used private at the same time. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/577 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit e5cf14ba043f29b8b81440e6c32cf6f1cc91851c Author: Hartmut Reuter Date: Tue Oct 6 09:10:45 2009 +0200 New option '-cmd' for 'fs listacl' prints 'fs setacl' commands necessary to create the current ACLs. This is useful for backup scripts using TSM (or others) to save the ACLs into a file to allow for later restore. Reviewed-on: http://gerrit.openafs.org/556 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit f7d601eefa0b98dd54720a4639ed746039d2675c Author: Simon Wilkinson Date: Fri Oct 2 23:43:46 2009 +0100 Use standard Linux paths for all headers As we're being built by the standard Linux module build system, we can use the normal #include convention from including kernel headers. Reviewed-on: http://gerrit.openafs.org/582 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f8cf2a44ab2e896b3c22c9a9e39cc9ade839545e Author: Claudio Bisegni Date: Mon Oct 5 13:42:27 2009 +0200 OSX Launchd Startup Manage with Preference Pane OpenAFS preference pane has been updated to manage the new launchd startup mode. Has been delete the custom startup and shutdown file now is user the /Library/OpenAFS/Tools/root.client/usr/vice/etc/afs.rc OpenAFS.postinstall has been modified to remove the old existing /Library/StartupItems/OpenAFS directory OpenAFS.pre_upgrade has been modified to shutdown daemon, if it is runnig, and remove the old preference pane to permit the one to be installed Reviewed-on: http://gerrit.openafs.org/578 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 4e3d3d50496cc96799a84cf98873d6f68e9a8ca7 Author: Hartmut Reuter Date: Wed Sep 30 10:06:14 2009 +0200 afsio is a command to pipe data into or out of afs files afsio bypasses the cache manager to achieve higher throughput. However, it uses the cache manager to stat or create files over the AFS path. Besides 'apropos' and 'help' there are 3 subcommands: 'write' pipes data into a new or empty AFS file 'append' pipes data at the end of an existing AFS file 'read' pipes data out of an AFS file for 'write' there is an option '-md5' which calculates on the fly the md5 chscksum and prints it to stdout. (Useful when you create long time archives to keep it separately for later ...) for 'write' there is also an option '-synthesize ' to do just performance tests. It creates a file which contains at the begin of each 4 KB block the offset printed in ascii. for all subcommands exists a '-verbose' option which writes to stderr data rate and timing information. All three subcommands may also be used prefixed with 'fid' accepting then a Fid instead of an AFS path. With the 'fid' prefix also a '-cell' option is allowed. Reviewed-on: http://gerrit.openafs.org/555 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit db23268f682564000f2ac4f9f845d4fd261d4c90 Author: Marc Dionne Date: Thu Sep 17 16:57:52 2009 -0400 Linux: 2.6.32 - Adapt to writeback changes Adapt to the writeback changes in kernel 2.6.32 - Since we define our own backing_dev, it needs to be registered with the writeback code and attached to the super_block. Otherwise it might get ignored when writeback is needed. - Each backing_dev now gets its own kernel thread. The name of the thread is based on the registered name - the openafs one will appear as "flush-afs". Reviewed-on: http://gerrit.openafs.org/574 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit fa8766d220e37d5c11fc6ac72e3de40f5054cfff Author: Marc Dionne Date: Sun Oct 4 13:40:10 2009 -0400 rxfs_storePadd: return 0 on success On success, storePadd should return 0, not the number of bytes written by the last rx_Write call. In some cases this return value would leak all the way out to the close() system call, causing it to fail. Reviewed-on: http://gerrit.openafs.org/573 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 6d9ad2e4d0c5e87a8d2d02834134ca68122b8e33 Author: Simon Wilkinson Date: Fri Oct 2 14:34:50 2009 +0100 Refactor linux readpage support The readpage call on Linux was becoming horribly complex. This patch refactors it into three main components - a function which fills a locked page (without unlocking it), a function which triggers a cache bypass operation on a page, and a function which does conditional prefetch, based on the properties of the page that was just read. In addition, we abstract out the cache bypass code further, and provide static inline variants which are simply stubbed out when cache bypass is disabled. Reviewed-on: http://gerrit.openafs.org/569 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 3e164335affa617137ebf280fe4c82a51c99894e Author: Simon Wilkinson Date: Fri Oct 2 13:43:01 2009 +0100 Rationalise some #ifdefs in the LINUX osi layer Introduce osi_compat.h, a place to hide compatibility #ifdefs. Make a start on using this by purging #ifdefs from osi_vnodeops, and pushing changes into inline compatibility functions. The general idea here is to create a single location where we can do our multiple version compatibility magic, and by doing so reduce the complexity of the rest of the code. The approach is that where the kernel introduces a new interface, we should switch to using it in the rest of the code, and add a compatibility function (in osi_compat.h) which implements the new interface in terms of the old one, suitably protected by #ifdefs. Where an interface changes signature, but not name, we should implement an afs_ version of the function which has the signature of the newest version, and within that call out to the real kernel versions, mapping between the different parameters as appropriate. Reviewed-on: http://gerrit.openafs.org/568 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 109927bf6f54b58b76ac48ba41c2012c74937fed Author: Simon Wilkinson Date: Fri Oct 2 11:51:52 2009 +0100 Remove pre-Linux 2.6 support This change removes support for kernels before Linux 2.6.0 from src/afs/LINUX. Older kernels should be supported by the src/afs/LINUX24 code. Reviewed-on: http://gerrit.openafs.org/567 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b7cc8bf2850c5650a9e47416af8bd488f9be9161 Author: Derrick Brashear Date: Thu Oct 1 16:09:17 2009 -0400 create LINUX24 directory shadow src/afs/LINUX into .../LINUX24, removing 2.6 code from it same for rx/LINUX cheat and simply modify MKAFS_OSTYPE in MakefileProto.LINUX.in Reviewed-on: http://gerrit.openafs.org/565 Reviewed-by: Matt Benjamin Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 2ea379b9f9a1df59327fb2b05b8d9af3bf6615af Author: Simon Wilkinson Date: Fri Oct 2 18:36:24 2009 +0100 There can be only one ... MD5 The cache manager has two implementations of md5 - one in afs_md5.c (used by afs_NewCell) and one in afs_util.c - used by Linux's MD5-inode code. Remove the one in afs_util.c in favour of using the common implementation in afs_md5.c Reviewed-on: http://gerrit.openafs.org/572 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 69290ffe9488ea5d5b3c3b9ccc875d1a0bab393c Author: Derrick Brashear Date: Thu Oct 1 04:34:09 2009 -0400 launchdaemon support for MacOS the changes needed to switch from a StartupItem to a LaunchDaemon for the MacOS OpenAFS client Reviewed-on: http://gerrit.openafs.org/564 Tested-by: Claudio Bisegni Tested-by: Derrick Brashear Reviewed-by: Claudio Bisegni Reviewed-by: Derrick Brashear commit d192fec670e6c5fce8910b40322da22f95fa5010 Author: Simon Wilkinson Date: Thu Oct 1 21:27:11 2009 +0100 Remove page past end of file optimisations The kernel checks itself for read() calls which attempt to fetch pages past the current file extents. Remove ours. Reviewed-on: http://gerrit.openafs.org/566 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 031f5eb528c94c1ad13fb1485db5cd40bc2877c2 Author: Andrew Deason Date: Wed Sep 30 16:50:07 2009 -0500 DAFS: Wait until preattach to service FSSYNC reqs Make FSYNC_sync wait until VInit == 2 before serving FSSYNC requests. This follows the existing similar behavior of waiting until after volume preattachment is completed before serving RPC requests in DAFS. This prevents FSSYNC clients from being denied requests simply due to a volume not having been preattached yet, at the small cost of delaying how soon we can serve FSSYNC requests. This does not alter the behavior of non-DAFS, which still only waits until VInit == 1, since volume attachment takes significantly longer than preattachment. Reviewed-on: http://gerrit.openafs.org/563 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit d88c03492d1ea9a7533298977d8d6bec5e91ebcd Author: Andrew Deason Date: Wed Sep 30 16:42:46 2009 -0500 DAFS: Avoid volserver segfault in GetVolInfo It is possible for GetVolObject to return success, but result in a NULL fs_tv. In particular, when the fileserver responds with FSYNC_WRONG_PART or FSYNC_UNKNOWN_VOLID. It is possible, though difficult, for the fileserver to respond with FSYNC_UNKNOWN_VOLID if the requested volume hasn't been preattached on the fileserver yet. So, in GetVolInfo, also check fs_tv, so we don't try to dereference it later. Reviewed-on: http://gerrit.openafs.org/562 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b5c4dbf861a0be675e5dbe775059e3bf7628f127 Author: Jeffrey Altman Date: Wed Sep 30 21:43:45 2009 +0200 Windows version 1.5.65 Reviewed-on: http://gerrit.openafs.org/560 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 1937eadfdad6e7616f6db97d802c3b8c5000f5d6 Author: Derrick Brashear Date: Wed Sep 30 17:28:36 2009 -0400 openafs 1.5.65 make openafs 1.5.65 for unix Reviewed-on: http://gerrit.openafs.org/561 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 75dbaa82cd54bdbfc99a8c66a9d7a7327041863b Author: Jeffrey Altman Date: Wed Sep 30 21:42:16 2009 +0200 Windows: change log for 1.5.65 LICENSE: MIT Reviewed-on: http://gerrit.openafs.org/559 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit d5b40d99a9e8284c1ce8784a6b8fcc7fb7453532 Author: Simon Wilkinson Date: Wed Sep 30 11:44:51 2009 +0200 Add configure test for pagevec_lru_add_file pagevec_lru_add_file isn't available on all Linux kernels. Fallback to using pagevec_lru_add where necessary. Reviewed-on: http://gerrit.openafs.org/558 Tested-by: Marc Dionne Reviewed-by: Marc Dionne Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 2f270a3e9206344464f1414cb04895090d93590d Author: Tom Keiser Date: Tue Sep 29 10:25:55 2009 -0400 make VOL_STATE_VLRU_ADD exclusive VLRU_Add_r() places a volume into VOL_STATE_VLRU_ADD before calling VLRU_Wait_r(), which drops VOL_LOCK while waiting for the required VLRU queue to quiesce. Thus, it is essential that state VOL_STATE_VLRU_ADD be marked exclusive so that another thread cannot mutate state until the VLRU generation add transaction completes. Reviewed-on: http://gerrit.openafs.org/554 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 06520711cbbb731da57e34cf955e525140bef33a Author: Jeffrey Altman Date: Tue Sep 29 14:29:55 2009 +0200 Windows: short circuit background volume checks for shutdown If the service is shutting down or the machine is entering a suspend state, short circuit the background volume checks to permit faster shutdown. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/552 Reviewed-by: Derrick Brashear Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit af9c9d905a08f28dc672dda6e5a6b9437f1650a8 Author: Simon Wilkinson Date: Wed Jul 15 00:02:31 2009 +0100 Add support for background page copies LICENSE BSD This patch adds support for backgrounding the page copies which are caused by a call to readpages() In theory, this should improve the throughput of the AFS kernel module as it permits processes to start work whilst data is still being read into the page cache for later pages. Reviewed-on: http://gerrit.openafs.org/537 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f75d84c404761a03ebf24406db12bfaff4bc3e74 Author: Simon Wilkinson Date: Tue Jul 14 23:55:18 2009 +0100 Add support for blocking readahead This patchset adds support for the readpages() system call, and enables readahead on Linux. At the moment each page read causes readpages to block, so the client won't see much benefit from readahead, beyond the reduction in call overhead. Reviewed-on: http://gerrit.openafs.org/536 Reviewed-by: Matt Benjamin Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f5c55d23a2a745e848c6e013c8b42cf3292c4691 Author: Simon Wilkinson Date: Tue Sep 29 12:26:55 2009 +0200 Demand attach warning fixes Fix a whole host of warnings in the demand attach code. Make a broken tvolser build stop the build, rather than carrying on regardless. Reviewed-on: http://gerrit.openafs.org/551 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 36700b51b34bbab515e947ed60104ada5ba6f827 Author: Simon Wilkinson Date: Tue Sep 29 10:25:53 2009 +0200 Don't use volatile when it makes no sense The demand attach code defines volume pointers as volatile in a number of places, despite the fact that the values in question aren't being shared between multiple threads. It then also passes these volatile pointers into functions which don't treat them as volatile (and even to some which assign them to registers). This patch simply removes the use of volatile in this situation. Reviewed-on: http://gerrit.openafs.org/550 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit ca8890245b44cc3abf311797ae62d2f0aaca5429 Author: Derrick Brashear Date: Tue Sep 29 10:26:23 2009 -0400 intptr fallout some kernels don't have e.g. uintptr_t; revert this hunk for now. also, autoconf as recent as what's in rhel5 has no macros. provide some. Reviewed-on: http://gerrit.openafs.org/553 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 88a037585d65e31e9d832bea89bb1cc1f107ab0f Author: Simon Wilkinson Date: Tue Jul 14 23:39:44 2009 +0100 Use readpage, not read for fastpath access Modify the fast path case so that it uses readpage(), rather than read() to access data in the cache. This removes a lot of the hidden, uncessary work that the kernel was doing behind the scenes, and takes advantage of the fact that we know a page read will always result in a page read against the backing cache. Reviewed-on: http://gerrit.openafs.org/535 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c4bffd7efbcf27f7a8c9c0f81c4b79d3251a5d3a Author: Derrick Brashear Date: Tue Sep 29 05:25:46 2009 -0400 irix compile fixes fix compilation for irix (and warning for solaris) for icreate as well as more stdint.h fixes Reviewed-on: http://gerrit.openafs.org/548 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit e0bbecf2693c2a7e3ec06fbb9335254f841c8e71 Author: Jeffrey Altman Date: Mon Sep 28 16:58:25 2009 +0200 Windows: Trace log smb_FindFID errors To assist with debugging, add consistent trace log messages for smb operations that generate an error because smb_FindFID failed. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/545 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit d9d3902894d1bde920feda7f5f1a798037b52cf8 Author: Claudio Bisegni Date: Tue Sep 29 09:57:52 2009 +0200 OS Preference pane clean for final version Has been removed from license file the reference to menucracker for hack NSMenuExtra, that is no more needed. Reviewed-on: http://gerrit.openafs.org/547 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 45e98a4455e1da7e79b70a4c42dccb07ab9102a6 Author: Jeffrey Altman Date: Mon Sep 28 16:22:31 2009 +0200 Windows: cm_GetBuffer does not need to contact file server when extended a file If cm_GetBuffer is being called in order to obtain a buffer to store data beyond the end of the existing file as known to the file server there is no reason to contact the file server. Instead use the cached status info in order to allocate a new buffer zero initialized. This logic avoids triggering the FetchData bug in all file servers older than 1.4.12 and 1.5.65 in which the file server returns a large negative number (filesize - requested_offset) when a FetchData is received where the requested_offset is larger than the filesize. It also avoids unnecessary work. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/542 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 50e98677ca5b62b3b82608c6da3e719956d3a03d Author: Jeffrey Altman Date: Mon Sep 28 16:52:45 2009 +0200 Windows: Directories do not have a default stream When enumerating streams for objects, do not offer a default stream for directory objects (including mount points). LICENSE MIT Reviewed-on: http://gerrit.openafs.org/544 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit fee0efedc12a90605f2c2e3e10d2492be5f42be3 Author: Andrew Deason Date: Mon Sep 28 10:14:23 2009 -0500 Formatting typo in vos_setfields manpage The POD formatting code for bold is B, not b. Reviewed-on: http://gerrit.openafs.org/546 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 158043416326d67708880ed801de53653d9453ad Author: Simon Wilkinson Date: Mon Sep 28 16:21:21 2009 +0200 Don't try to print the thread ID pthread_t is defined as being opaque - there's no way to portably print it on a way that makes sense on all platforms. Remove this output. Reviewed-on: http://gerrit.openafs.org/541 Reviewed-by: Tom Keiser Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 4f65bec3fc4d0c1157aa80323c8d7ecc8a53d3a1 Author: Simon Wilkinson Date: Mon Sep 28 16:50:20 2009 +0200 Fix warnings in new dumptag code 3f2dd80697959f5922032f4d4a7c9ef0cfadf35c contained a number of new warnings. This patch fixes them. It also adds the AFS_UNUSED_FUNCTION macro which can be used to portably mark functions as unused. Reviewed-on: http://gerrit.openafs.org/543 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 6d628bbb7c188e5644e27b3657d824c1481034b6 Author: Simon Wilkinson Date: Sat Sep 26 17:44:06 2009 +0100 Squash more viced warnings Get rid of more warnings in viced - Cast fids that we pass into the Dir package to avoid type warnings - Add ()s to a && b || c, to clarify its meaning - (a && b ) || c - Don't use %ld to print ints - Prototype another function from the host package Reviewed-on: http://gerrit.openafs.org/539 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit e287f72e4e4de82fd2ab5c4a4137aa58a5f45b55 Author: Derrick Brashear Date: Mon Sep 28 09:53:11 2009 -0400 irix UCRED is already a struct just like everywhere else. move the one last struct UCRED to UCRED like everywhere else Reviewed-on: http://gerrit.openafs.org/538 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 0ec76649b62919cff3244eb0a6390662f72d7950 Author: Simon Wilkinson Date: Tue Jul 14 23:33:16 2009 +0100 Minimise crref() and add a fastpath for cache hits Reduce the number of times we cref() unnecessarily, and add a fastpath at the beginning of readpage() to handle the cache hit case. Refactor the Linux implementation of afs_open to provide a directly callable version that bypasses the OSI layer. Add a non-blocking variant of ObtainReadLock() Reviewed-on: http://gerrit.openafs.org/534 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit be34175e0f089cbf8a90a0afc7362432be004e06 Author: Derrick Brashear Date: Mon Sep 28 09:21:59 2009 -0400 macos 10.6 warning fixes due to 32/64 and a newer compiler, macos 10.6 finds more warnings. these are fixes for some of them. Reviewed-on: http://gerrit.openafs.org/533 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit f63a8662a7b05c60e85f5e525b58ccf476bc1753 Author: Derrick Brashear Date: Mon Sep 28 08:05:15 2009 -0400 kauth should use static_inline for irix et al "static inline" doesn't work on various still-supported systems. use the workaround macro Reviewed-on: http://gerrit.openafs.org/532 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit efe8258a924903e3c9d7b339349f83861d6be0d1 Author: Simon Wilkinson Date: Mon Sep 28 12:01:54 2009 +0200 Use configured compiler for libuafs on Darwin There's no need to hardcode 'cc' for libuafs builds on Darwin. Let the user specify the compiler to use, in the same way as for the rest of the tree. Reviewed-on: http://gerrit.openafs.org/531 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 6d51ebd6c8d4d5d6ddc42b539be5814e7c468d9c Author: Simon Wilkinson Date: Mon Sep 28 12:07:58 2009 +0200 Add support for warning checked builds This patch adds a '--enable-checking' configuration option. When this option is supplied, and gcc is in use, the compiler will treat any warnings as errors. This will hopefully help stop new warnings from creeping into the tree. In order to still be able to build, all of the currently existing warnings are accepted (these are documented in README.WARNINGS). With this set of warning inhibitions, the tree is known to build on 32bit Leopard - other systems may vary. Warning inhibition may be disabled by supplying --enable-checking=all - in this case the tree will definitely not build! If --enabled-checking is not specified, the existing compilation behaviour is maintained, so there is no user-visible change. Gcc 4.2, or later, is required to use the pragma sets contained within this patch. Again, they are not visible unless --enable-checking is given. Reviewed-on: http://gerrit.openafs.org/526 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 5afd2c34699c60ba247b1de8ec42efbed1c09e39 Author: Derrick Brashear Date: Mon Sep 28 07:54:02 2009 -0400 conditionalize stdint.h inclusion in lwp Irix has no stdint.h; wrap in ifdefs so we don't include when we don't have it. Reviewed-on: http://gerrit.openafs.org/530 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 5d3400f4e103a7c4d7027cb809c8a109bf003316 Author: Derrick Brashear Date: Mon Sep 28 07:46:48 2009 -0400 afsmonitor warnings fix again, add missing format strings to *printf to eliminate warnings Reviewed-on: http://gerrit.openafs.org/529 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 9ee76d8a8fe326c64a08aeb0e1785d009b9ffb36 Author: Derrick Brashear Date: Mon Sep 28 06:32:09 2009 -0400 kill cnvldb warnings previously we used fprintf without a format string in some cases. now we don't Reviewed-on: http://gerrit.openafs.org/528 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 3f2dd80697959f5922032f4d4a7c9ef0cfadf35c Author: Hartmut Reuter Date: Fri Sep 11 12:29:45 2009 +0200 Implementation of new dump tag and length standard The implementation follows the specification from October 2007. All old tags are accecpted as before. New tags 0x06-0x60 (capital letters) are followed by a 1 byte length field which may contain directly the length (up to 127) or the length of the then following length field (max 8) ored with 0x80. New tags 0x61-0x77a are directly followed by 4 bytes building a 32bit integer. 0x7b-0xf are single-byte tags, 0x7e meaning next tag is critical. On this basis unknown tags can be skipped unless they were marked critical. In this case the restore is aborted. in dump.h tags following the new standard are marked by an asterisk Last update: added parameter types for HandleUnknownTag. Reviewed-on: http://gerrit.openafs.org/191 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 9a82cdae42512dc6cd55dcc961eec6b1932e707f Author: Simon Wilkinson Date: Mon Sep 28 11:41:52 2009 +0200 Avoid redefinition errors for AFS_NONFSTRANS Some parts of the build provide -DAFS_NONFSTRANS on the command line. This causes an error when the 'param' file redefines it. Fix this by #undef ing the token before defining it. Reviewed-on: http://gerrit.openafs.org/510 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit d7b00d5f19e7dfd7d8ee3d600d0184e4364fa7be Author: Marc Dionne Date: Fri Aug 28 17:03:44 2009 -0400 Use intptr_t and uintptr_t for integer/pointer conversions Use intptr_t and uintptr_t casts to appease the compiler when values are converted between 32-bit integers and pointers. This generates many warnings (currently ~170 on linux amd64) when pointers are 64-bit. These types are normally defined in stdint.h, and get defined by autoconf if that's not the case. In a few places, NULL is simply replaced with 0 where compared with an integer. Reviewed-on: http://gerrit.openafs.org/474 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 01aa7055142936f73919c48468707ee90df73dbd Author: Simon Wilkinson Date: Mon Sep 28 10:43:24 2009 +0200 Make butc logging use va_args Change the logging functions in butc so that they use va_args. This means that we can prototype the logging functions, and kill a bunch more compiler warnings. Reviewed-on: http://gerrit.openafs.org/509 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit a53732ef5f425706abc1c5e511df23cecb2f6113 Author: Simon Wilkinson Date: Sat Sep 26 18:11:53 2009 +0100 Miscellaneous warning cleanup Assorted warning cleanup, that it didn't seem to make sense having one patch per file for. This patch - Adds some casting for syscall pointers - ANSIfies SRXAFSCB_GetDE in fsprobe - Loads sys/ioctl.h on some more platforms in usd - Includes some missing header files - Removes unused variables - Makes it clear that VIsSalvager does handle all enumerated types - Adds some more prototypes Reviewed-on: http://gerrit.openafs.org/508 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 6dcf37d8109a31ec1b95438a70e485a66fede848 Author: Simon Wilkinson Date: Sat Sep 26 18:04:06 2009 +0100 Remove some more warnings from rx The mtu variable in InitPeerParams is in the wrong place. It's only required when the (never used) AFS_USERSPACE_IP_ADDR code is enabled. Move the variable to the appropriate location, and indent the if and endif directives in this section to try to make it clearer what the control flow is (my brain hurt) Remove the unused rx_pthread_n_event_wakeups variable ANSIfy rxi_syscall - we can't prototype it yet, sadly. Reviewed-on: http://gerrit.openafs.org/503 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 9d42c45e6513ebfa405ecd1d5404f753a0b2045b Author: Simon Wilkinson Date: Sat Sep 26 22:12:11 2009 +0100 Warning fixes for afs_fetchstore The recent afs_fetchstore refactoring added a load of warnings. Remove them. Reviewed-on: http://gerrit.openafs.org/502 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 4c1c92c0bdd2b62845187c19a5f5821fe08cf47b Author: Simon Wilkinson Date: Sat Sep 26 17:34:48 2009 +0100 Fix signed/unsigned warnings in XDR Our xdr routines use the same native functions to read signed, and unsigned integers from the wire. This leads to compiler warnings when the unsigned versions of these functions are called. This patch always casts to (afs_int32 *) when calling PUT_INT32 and GET_INT32, to resolve these warnings Reviewed-on: http://gerrit.openafs.org/507 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 4bbc4a5a1dc3c07ac130e9afdfab03ac5a245a16 Author: Simon Wilkinson Date: Sat Sep 26 17:50:04 2009 +0100 Tidy up unlog Remove warnings from the unlog code - Prototype internal functions, and make them static - Define variables appropriately - Remove uneccesary local function defintions Reviewed-on: http://gerrit.openafs.org/505 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit ace95ffa63f718c15a3ef362482c030e1f69186f Author: Simon Wilkinson Date: Sat Sep 26 17:52:57 2009 +0100 Remove warnings in the update client and server rx_Read and rx_Write take a datablock which is a char *, rather than a void *. Cast appropriately. Reviewed-on: http://gerrit.openafs.org/506 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit fabe41d6443586778cd992ad0aa8fad41b130114 Author: Simon Wilkinson Date: Sat Sep 26 17:56:48 2009 +0100 Squish some warnings in ubik/ Remove some more warnings from the ubik/ directory - Remove a dangling else case from an if statement - Prototype ubik_dprint_25 - Don't do (a || b()) - it's horrible, and causes warnings! Replace with if (!a) b(); Reviewed-on: http://gerrit.openafs.org/504 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e14e5aa0cfba456eee9252c47294d863e935f67b Author: Simon Wilkinson Date: Sat Sep 26 20:54:06 2009 +0100 Relax compiler specification on Darwin 9 and 10 Commit 1992b702f64f561c75cc74d4645bb0e1afeec6bd made it possible to relax the compiler choice on a per architecture basis. That commit allowed the user to specify their compiler of choice on all Linux systems, but hardcoded 'cc' everywhere else. This patch permits Darwin 9 and 10 users to also override the default compiler for user space builds. Reviewed-on: http://gerrit.openafs.org/501 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 291d31e55f64992d8d529522f3479e5ffe5fd607 Author: Marc Dionne Date: Sat Sep 26 09:32:46 2009 -0400 fetchOps: fix more() prototype Adjust the prototype in the fetchOps structure to match the recent change to rxfs_fetchMore(). Reviewed-on: http://gerrit.openafs.org/499 Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 529d487d65d8561f5d0a43a4dc71f72b86efd975 Author: Derrick Brashear Date: Fri Sep 25 03:15:40 2009 -0400 viced cap fetchdata len to avoid negative when trying to read from a short or zero length file, it's possible for sanity checking to knock the length below zero. set a floor at zero. Reviewed-on: http://gerrit.openafs.org/494 Reviewed-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit bc6559d62c21ee046c4082aba282097a8c1de9ac Author: Simon Wilkinson Date: Sat Sep 26 10:06:27 2009 +0100 Attempt to fix CForeign moredata behaviour The fetchstore patches changed the behaviour of the multiple chunk handling that's used in FetchData when the vnode's CForeign bit is set. In the original code, the data would be read as (length, payload) chunks. The new code does (length, length, payload), which corrupts the incoming data. This patch restores the original control flow. Reviewed-on: http://gerrit.openafs.org/498 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 5d765426e597c60228e66bddaa21bf2453c74a85 Author: Derrick Brashear Date: Fri Sep 25 05:19:33 2009 -0400 h_GetHost_r cleanup cases avoid potentially leaking a cb_in or a capabilities blob; use a common exit function and free when these were left set. Reviewed-on: http://gerrit.openafs.org/496 Tested-by: Alistair Ferguson Reviewed-by: Alistair Ferguson Reviewed-by: Jeffrey Altman commit ce9da0d76c53127e7f2f2142832602b52dd78f10 Author: Claudio Bisegni Date: Thu Sep 24 19:03:28 2009 +0200 AFSPreference Pane, has changed the content of launchd xml control file for AFSBackgrounder has been used Program instead of ProgramArgument Reviewed-on: http://gerrit.openafs.org/495 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f6f9ee5402f1718f330a00ec89fb34b05c3cd360 Author: Simon Wilkinson Date: Fri Sep 25 00:27:40 2009 +0100 Fix CacheFetchProc in cases where the fileserver hates us In some situations, the fileserver returns a large negative number as the length in an FetchData64 call. The old FetchProc code used an int32 to hold this number, and checked length > 0 before attempting to read more data. The new code uses a uint32, and does while (length), which causes the cache manage to loop until RX aborts the connection. This patch restores the old behaviour. length becomes a signed int once more (and the original 32 bit length from the wire is used, rather than truncating the 64 bit value), and the conditional checks for > 0. Reviewed-on: http://gerrit.openafs.org/493 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 29ee678f3ab051a27cae46b02a0d42e0958a6bc8 Author: Andrew Deason Date: Mon Sep 21 12:48:30 2009 -0500 Unlink correct files in salvager Fallout from 0ac956b3384842b3c60e72bde78a4baf58a5877f; a couple of unlink() calls were not updated to use the absolute path. Update them, and log errors from unlink(), since otherwise it is difficult to tell that anything is going wrong. Reviewed-on: http://gerrit.openafs.org/479 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 07b1dc861bee97c44507f437685d7f8c3d094807 Author: Andrew Deason Date: Tue Sep 22 16:59:34 2009 -0500 Solaris: Default to fs_pathconf in afs_pathconf Instead of returning EINVAL in afs_pathconf when we don't recognize the pathconf command, return the result of fs_pathconf. fs_pathconf provides sensible defaults or correctly represents a filesystem not implementing a particular pathconf cmd; all in-tree (Open)Solaris filesystems call fs_pathconf for unimplemented commands. Returning EINVAL allegedly represents that the fileystem does not support pathconf at all. Also, account for OpenSolaris adding another parameter to pathconf-related calls. Reviewed-on: http://gerrit.openafs.org/488 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b56a794f8d77987df07d2efcb8af5f9d63f6e678 Author: Simon Wilkinson Date: Wed Sep 23 18:18:34 2009 +0100 Refactor the cache bypass determination code The code which determines whether the cache can be bypassed occurs in multiple locations in this file. Make a single static inline function that can do this, and use it. Reviewed-on: http://gerrit.openafs.org/489 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 3567441f92349bb21bb42405ecf6ada4844551e5 Author: Andrew Deason Date: Tue Sep 22 17:36:38 2009 -0500 Remove one more AFS_UCRED struct After 8a8244dd351f865af2da3b5ebb746ba57723b6a9, AFS_UCRED is no longer assumed to be a struct. Fix one instance that still declares it as a struct. Reviewed-on: http://gerrit.openafs.org/487 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 7edc6694e7632c9736bd1516935604a638165313 Author: Simon Wilkinson Date: Tue Sep 22 17:18:34 2009 +0100 Whitespace cleanup (sorry) The cache bypass code changed the indentation of afs_linux_readpage so that pullups from 1.4 no longer works. This patch simply restores the original (correct) indentation. Sorry for a whitespace change, but this will make things much easier going forwards. Reviewed-on: http://gerrit.openafs.org/486 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f3c3e4da18519571ef3a8a868297510ed4e132a3 Author: Derrick Brashear Date: Tue Sep 22 04:51:15 2009 -0400 DAFS protocol state diagrams update DAFS protocol state diagrams FIXES 124990 Reviewed-on: http://gerrit.openafs.org/485 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 40b18318e4a04a323dbdd9e3c4a73d3b2e92104d Author: Andrew Deason Date: Mon Sep 21 16:57:01 2009 -0500 Implement _PC_FILESIZEBITS for solaris pathconf Using recent NFS clients and servers with the translator under Solaris causes AFS to be queried for the _PC_FILESIZEBITS pathconf value. Right now we don't implement it and return EINVAL, causing at least some modern NFS clients to be unable to mount AFS via the translator on at least some modern NFS servers. So, return _PC_FILESIZEBITS as either 32 or 64, depending on whether we are a 64-bit client or not. Reviewed-on: http://gerrit.openafs.org/481 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b7ae31a7484b609cd22d029fd753798001f72864 Author: Andrew Deason Date: Mon Sep 21 14:28:29 2009 -0500 Avoid salvager vol header read assert When we read the volume header in order to write it back with a modified inUse while salvaging, we were aborting if we couldn't read the header. Since we can fail to read the header data if the volume header file isn't associated with any data (and will be deleted by the salvager), don't abort. Do still abort if we can't write the data back, since if the data can be read but not written, other programs may think that the volume is not being salvaged. Reviewed-on: http://gerrit.openafs.org/480 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 759c756b0fa51b774e3894d5f9a5029955232612 Author: Andrew Deason Date: Mon Sep 21 11:09:56 2009 -0500 DAFS: Put back volumes we get in FSSYNC handlers fssync-server.c has a few issues with not properly VPutVolume_r'ing volumes that were VGetVolume_r'd. The most important of these was that the handler for FSYNC_VOL_MOVE can put back a volume it did not get, when DAFS is enabled. Fix that, and another erroneous edge case in the FSYNC_VOL_QUERY_HDR handler when DAFS is not enabled. Reviewed-on: http://gerrit.openafs.org/477 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 1542d943df24de94e4b61e0303db542f0e2c982d Author: Derrick Brashear Date: Mon Sep 21 12:33:37 2009 -0400 make 1.5.64 for unix update version strings to 1.5.64 Reviewed-on: http://gerrit.openafs.org/478 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e646a3e4dc62aaccebb81dada9d6d744ac19354f Author: Felix Frank Date: Sun Sep 20 14:43:34 2009 +0200 Use the padd op. When the padd operation was added, the change that makes actual use of it got lost somewhere along the line. Fixed now. Originally introduction of the padd op: 6220ede6a96d06c53eddd848435764cff96be1b4 Reviewed-on: http://gerrit.openafs.org/471 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 4fd7101577613bbafcf4488f3d82dd03642b01c0 Author: Jeffrey Altman Date: Mon Sep 21 17:11:25 2009 +0100 Windows version number 1.5.64 Reviewed-on: http://gerrit.openafs.org/476 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 91d9ca106def5cde2b75e2b03ad0111a44551868 Author: Jeffrey Altman Date: Mon Sep 21 17:07:23 2009 +0100 Windows: 1.5.64 updates for Windows Notes LICENSE MIT Reviewed-on: http://gerrit.openafs.org/475 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 10706d8208df865ac0bc89f6d83a5779b9794128 Author: Jeffrey Altman Date: Sun Sep 20 11:06:07 2009 -0400 Windows: uninitialized variable in cm_GetBuffer Initialize code and code1 to zero. Otherwise, a non-zero value on the stack can result in an incorrect error value being passed to cm_Analyze(). LICENSE MIT Reviewed-on: http://gerrit.openafs.org/473 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 65d1d94634c2d31aeecf1c512828a1bcbd93bbe5 Author: Jeffrey Altman Date: Sun Sep 20 11:04:07 2009 -0400 Windows: Protect against null serverp in cm_Analyze If cm_Analyze is called with both 'serverp' and 'connp' set to NULL and an RX error is provided, a null pointer dereference will occur. Test for non-NULL serverp before dereferencing LICENSE MIT Reviewed-on: http://gerrit.openafs.org/472 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 427b27a87fd34035f855ff8b1b9ec3ad618829c8 Author: Jeffrey Altman Date: Sat Sep 19 13:52:32 2009 -0400 Windows: Do not mark server down due to Store / Fetch Data protocol error When performing a StoreData or FetchData operation there are several data validation checks performed to ensure that the lengths of data obtained with rx_Write and rx_Read are consistent with the RXAFS_FetchData and RXAFS_StoreData protocol operations. When an inconsistency is detected the cache manager terminates the call and returns an error to the caller which is passed to cm_Analyze(). The cache manager was returning -1 as the error code which is equivalent to RX_CALL_DEAD which in turn will result in the server being marked down. This commit makes the following changes: . add trace logging to permit monitoring this case . instead of returning -1 return either RX_PROTOCOL_ERROR or RX_EOF depending on the situation . in cm_Analyze do not mark a server as down for rx errors other than RX_CALL_DEAD. Instead, force a new connection and retry until the request timeout limit is reached. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/470 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 5b5dc4a85bde6e959a0943ac694833784a838164 Author: Jeffrey Altman Date: Mon Sep 14 07:59:54 2009 -0700 Windows: more pioctl output validation Add output validation checks to the Explorer Shell and the Client configuration control panel. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/458 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 72e8bac22201e194242e715a107f3b3cb8a480df Author: Jeffrey Altman Date: Sat Sep 19 04:55:09 2009 -0400 Windows: Use "Name not found" instead of "File not found" When a file cannot be opened because the name of the file or a directory in the path cannot be found, return "Name not found" instead of "File not found". "File not found" is the error returned by the smb redirector to the application when the file cannot be located in the search path. "Name not found" indicates that the entry is not present at the location requested. The use of "File not found" prevented execution of applications from the \\AFS name space on Windows 7. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/469 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 3be5d2ca5f2a1af97502f5fd0f5b25f382b123c4 Author: Jeffrey Altman Date: Fri Sep 18 10:46:07 2009 -0400 Windows: trace logging changes for smb_ReceiveTran2QPathInfo Add new trace log entries in smb_ReceiveTran2QPathInfo to help track down the reason for queries in which the path and tidPath are both the empty string. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/467 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 2c54ae82a49f6df7f7c76d333d3fe00a0b1cff28 Author: Jeffrey Altman Date: Fri Sep 18 10:41:14 2009 -0400 Windows: Improve WKSSRC and SRVSVC compatibility with Windows This commit includes several changes to improve compatibility with Windows (in particular Windows 2000). 1. Specify a Lan Workgroup name. We use "AFS". 2. Ensure that the server name returned does not include leading slash or backslash characters. The name provided might include them but they are not part of the name and cannot be returned. 3. The NetrWkstaGetInfo and NetrServerGetInfo responses must be consistent. Otherwise, the Explorer Shell will get confused and refuse to provide access to the server shares. This commit also includes some minor comment changes. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/466 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 211a23a06fd762478aa2f420b9cc638320857463 Author: Jeffrey Altman Date: Fri Sep 18 10:25:59 2009 -0400 Windows: Trace wkssvc and srvsvc rpc calls Add osi_Log statements identifying which RPCs are being called from the wkssvc and srvsvc modules LICENSE MIT Reviewed-on: http://gerrit.openafs.org/465 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit ccb02bf6eb7395bbb3d66c11b99a576c19d033d4 Author: Jeffrey Altman Date: Fri Sep 18 10:01:10 2009 -0400 Windows: No rand_s on Windows 2000 Even if the rand_s() function is supported by the compiler it is not supported on Windows 2000 because the kernel level functionality it requires does not exist on that platform. Calling rand_s() on Windows 2000 will throw an exception and terminate the service. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/464 Reviewed-by: Derrick Brashear Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 1ba9e95715a5c769580adbbda2ca19aae62eef75 Author: Andrew Deason Date: Fri Sep 18 13:23:46 2009 -0500 DAFS assert correction in GetVolume FSSYNC_VolOpRunningUnknown is a vol op state, not a pointer to a vol op itself. Reviewed-on: http://gerrit.openafs.org/468 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 48589b5d3957c27a5944e23fd770687adc078934 Author: Marc Dionne Date: Mon Sep 14 17:40:23 2009 -0400 Linux: Restore aklog -setpag functionality for kernel 2.6.32+ With kernel 2.6.32 it is now possible for a process to copy its session keyring to its parent through the use of the KEYCTL_SESSION_TO_PARENT function of the keyctl syscall. We can't use this easily from kernel space to cover all calls to VIOCSETTOK with the setpag flag - we'd need to make a syscall or have keyctl exported. Instead, a hook is added to ktc_SetToken to make it honour the AFS_SETTOK_SETPAG flag, which was ineffective with recent kernels. This should cover the most common cases (ex: aklog) where this is needed. The syscall is coded directly to avoid introducing a dependency on the keyutils library or header files which may not be installed everywhere. Reviewed-on: http://gerrit.openafs.org/463 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 1ea845ebc953bb49afc354afe036f7f01cd05db8 Author: Claudio Bisegni Date: Tue Sep 15 09:29:21 2009 +0200 Manage the login in the OSX Fast User Switch mode AFSBackgrounder has been update to get notification for switch in/off in the "Fast User Switch" mode, and in switch in it try to get tokens. Reviewed-on: http://gerrit.openafs.org/460 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 8af8af05f0a87af154f11bc8a7a7ec3f2505291e Author: Simon Wilkinson Date: Mon Sep 14 13:49:22 2009 +0100 Remove unecessary initialisation We already memset av to contain all 0s, therefore we don't need to initialise individual elements to 0 as well. Inspired by Rainer Toebbicke's patch for RT 125355 (which is 1.4.x only) Reviewed-on: http://gerrit.openafs.org/456 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 090b61e9d731d1cc55707fcb9ea6dbc7bc7b5018 Author: Brant Gurganus Date: Sun Sep 13 22:02:10 2009 -0400 Corrects file_CmdRef_1_fs_chgrp_html and file_CmdRef_1_fs_chown_html sharing short names. Reviewed-on: http://gerrit.openafs.org/455 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit bb4a5038d9f8d0585ed39ba3d82d459d7ca5d398 Author: Jeffrey Altman Date: Sun Sep 13 10:32:12 2009 -0400 Add indexing to Windows Release Notes An initial pass at adding indexing to the Windows release notes. The next pass should refine the index terms and add appropriate secondary index values. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/454 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit d190d2400eeef7f736338edea943ba8b93f64c69 Author: Jeffrey Altman Date: Sun Sep 13 01:45:48 2009 -0400 Windows Release Notes XML Reformat the Registry and Environment Values in Appendix A so that they are easier to identify in the table of contents. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/453 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit a747e934c40040061386d8ca591eba09b9745287 Author: Derrick Brashear Date: Sun Sep 13 01:00:45 2009 -0400 cm fetchstore should dereference unset ops if rxfs_fetchInit fails, ops will not be set; calling the destroy op unconditionally thus leads to a panic. Reviewed-on: http://gerrit.openafs.org/452 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 4b6fafa440fa51652d12d6522769c8f156b7bda1 Author: Derrick Brashear Date: Fri Sep 11 13:26:01 2009 -0400 macos package updates make the readme correct; allow back reving (downgrades) Reviewed-on: http://gerrit.openafs.org/447 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 431b54f642c5c34e260a1b35ecfca17d5e3dcde5 Author: Jeffrey Altman Date: Fri Sep 11 11:44:41 2009 -0400 Windows: Version 1.5.63 Reviewed-on: http://gerrit.openafs.org/445 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit d15ca10da0074bd14a777a0590e7271fe28ecf01 Author: Derrick Brashear Date: Fri Sep 11 13:30:29 2009 -0400 unix 1.5.63 make 1.5.63 for unix Reviewed-on: http://gerrit.openafs.org/448 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 60c44cc6ddf101b8085f242f2c1bf85896563923 Author: Jeffrey Altman Date: Fri Sep 11 11:41:01 2009 -0400 Windows: changelog updates for 1.5.63 LICENSE MIT Reviewed-on: http://gerrit.openafs.org/444 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 5b6e5019453952f122523354d0001b04189271a7 Author: Derrick Brashear Date: Tue Sep 8 14:31:09 2009 -0400 make fileserver avoid salvage loop on init failure if the vlserver or prserver setup can't succeed, it doesn't indicate a condition which salvaging is required to fix; instead, come up and retry in the background. Reviewed-on: http://gerrit.openafs.org/428 Reviewed-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 133fed07384aec910e22b4fd315f86440dff2fb2 Author: Felix Frank Date: Thu Jul 16 08:26:55 2009 +0200 Code beautifications. * get rid of register declarations * remove unused local var InStatus * comment prototypes properly (correct .c file) * save some linebreaks in function headers Reviewed-on: http://gerrit.openafs.org/135 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit bffbc55c220bd28c20856b5d00ed423f878319d8 Author: Felix Frank Date: Mon Jul 13 13:40:26 2009 +0200 More cosmetics. * FetchProc: length loop shorter condition * added fancyspace in FillStore call. * removed unused bsent variable * shortened some conditions * storeDestry: saved the code2 variable. Reviewed-on: http://gerrit.openafs.org/134 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit e99490ffd31edef1a349f06f975949b82707a0ee Author: Felix Frank Date: Mon Jul 13 13:28:41 2009 +0200 Cosmetics in CacheStoreDCaches, CacheStoreVCache and storeInit. * StoreProc: renamed alen to size. * StoreProc: Make connection before do {} * rename fP to tfile. * Declare nchunks later in StoreProc. * Fixed order of storeInit parameters. * storeInit: renamed tlen to length. Reviewed-on: http://gerrit.openafs.org/133 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit d47eb8f21b2782d9441c2ea4d0261c21cb423a19 Author: Felix Frank Date: Mon Jul 13 11:13:21 2009 +0200 Immediately abort call when not able to fetch length (fetchInit). Reviewed-on: http://gerrit.openafs.org/132 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 63abaf515c6f16907fdd9a226797bdc310dd704a Author: Felix Frank Date: Mon Jul 13 10:26:47 2009 +0200 Locking comment in FetchProc Reviewed-on: http://gerrit.openafs.org/131 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 46f7bbb19dbb697e626a20363ff23ad2fe0ee4c0 Author: Andrew Deason Date: Wed Sep 9 09:22:02 2009 -0500 Do not respond to SYNC_COM_CHANNEL_CLOSE requests SYNC clients, when closing a channel, send a SYNC_COM_CHANNEL_CLOSE command, and immediately disconnect before waiting for a response. So, don't send a SYNC response, since by the time we send it, the other end will most likely have already hung up, causing a lot of needless 'SYNC_putRes: write failed' messages whenever a SYNC channel is closed (e.g. when a demand-salvage finishes). Reviewed-on: http://gerrit.openafs.org/434 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit c1c8da78b680964b0259266207b2c07df54b5ef1 Author: Jeffrey Altman Date: Fri Sep 11 11:54:27 2009 -0400 Windows: Handle "(Default)" regsitry value in MountGlobalDrivesThread In MountGlobalDrivesThread(), if the "(Default)" registry value is defined that should be interpreted as a drive mapping to a device with no name. This is specified using NULL instead of the nul-string. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/446 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit bef42619ba3cf7f4b20783942c989e6d96185104 Author: Felix Frank Date: Mon Jul 13 10:08:37 2009 +0200 fetchDestroy can end calls now too. Reviewed-on: http://gerrit.openafs.org/130 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit b961dc1630baf9e6e1171c66430074fc1e7f9ef8 Author: Felix Frank Date: Mon Jul 13 10:06:50 2009 +0200 Included proper 64bit case in fetchClose() and storeClose(). Reviewed-on: http://gerrit.openafs.org/129 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 3898524693e7297e228ded03f34125558f225d58 Author: Derrick Brashear Date: Fri Sep 11 01:59:08 2009 -0400 darwin knet avoid rx socket during shutdown theoretically a user thread can race us during shutdown and end up panicing us if the soclose happens at the wrong time. if we're shutting down just return. using afs_shuttingdown would have the side effect that we'd lose the ability to add any graceful behavior. Reviewed-on: http://gerrit.openafs.org/443 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit cc7938e8ff2a56575122066a8750e881c4d280b0 Author: Felix Frank Date: Mon Jul 13 09:07:17 2009 +0200 Added guard against missing call and moved alength assignment in fetchInit. The returned value of rx_NewCall is important of course and must be taken into account before trying to start RPCs. Do assign the length output variable ASAP. Also fixes an overlong line and the type of the pos local var to unsigned. More style fixes: * Moved length64 to use proper scope, initialized code. * Generally make more tidy Reviewed-on: http://gerrit.openafs.org/128 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 98f9b6ae2bafe69440c090443efb2f71ec15309c Author: Derrick Brashear Date: Fri Sep 11 01:28:49 2009 -0400 des crypt cope with 64 bit longs we test for them in configure; instead of hardcoding it in yet another place, use the information we have Reviewed-on: http://gerrit.openafs.org/442 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e24d64f2a696eb85b44fb471326f6dbb525d60a0 Author: Jeffrey Altman Date: Fri Sep 11 00:35:04 2009 -0400 Windows: Add pioctl data output validation to fs and symlink command line tools pioctl data buffer output was not being validated to ensure that buffers were not overwritten or accessed beyond their limits. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/441 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit fdea6a3418315cd7b88219778118857fd32e9da6 Author: Russ Allbery Date: Thu Sep 10 11:02:46 2009 -0700 Windows: update build system for restorevol man page move restorevol moved from section 8 to section 1. The Windows build system needed corresponding changes. Reviewed-on: http://gerrit.openafs.org/440 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit d96ec9ec031d0d15d1cfe3b86e58c12c4c267c00 Author: Russ Allbery Date: Fri Aug 21 18:59:01 2009 -0700 Stop using sig_t acinclude.m4 was adding to afsconfig.h some code to define sig_t as the type of a signal handler. This definition was in terms of RETSIGTYPE, which is deprecated by Autoconf. It also adds an unnecessary abstraction for only two places in the AFS source code where it was used. Remove it and change those two spots to use the standard C declaration of the function pointer. Reviewed-on: http://gerrit.openafs.org/335 Tested-by: Simon Wilkinson Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear commit d6df1a8cec39edf7c0d2598921c735ac6aca70d7 Author: Russ Allbery Date: Fri Aug 21 18:12:39 2009 -0700 Move restorevol to bin from sbin restorevol only requires access to a dump file and write access to the directory in which the dump is being unpacked. It doesn't require being a superuser, so it should be installed in bin instead of sbin. Also move the man page to section 1 and update references accordingly. Reviewed-on: http://gerrit.openafs.org/333 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit c46689c05ffd56299a12f9883645e8fcf50fa29a Author: Derrick Brashear Date: Tue Sep 1 11:18:19 2009 -0400 redhat spec dkms don't strip modules provide a debug module which is unstripped. this is necessary for debugging problems. Reviewed-on: http://gerrit.openafs.org/391 Reviewed-by: Russ Allbery Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 96a176ed5872f54402e1625f6e67ce2979e48875 Author: Derrick Brashear Date: Thu Aug 13 10:05:44 2009 -0400 make salvager able to cope with corrupt class index right now if a directory ends up in the small vnode index, the salvager will never fix it. unlinking from the index (and recovering an orphan later) beats crashing forever Reviewed-on: http://gerrit.openafs.org/309 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 754a4b628a14657db2e00931926311a1c703558b Author: Derrick Brashear Date: Wed Sep 9 18:49:29 2009 -0400 macos panic decoder should handle 64 bit kernel in 32 bit mode panic from 64 bit should be decodable in 32 bit mode. make it so. add -k switch to allow a path to a kernel to be specified. Reviewed-on: http://gerrit.openafs.org/438 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 392e3dab970c998af63ddb43665655e0f3815c45 Author: Marc Dionne Date: Wed Sep 9 19:00:49 2009 -0400 Avoid __USE_XOPEN redefinition Only define __USE_XOPEN if not already defined. This eliminates a few build warnings where __USE_XOPEN is already defined in system header files. Reviewed-on: http://gerrit.openafs.org/439 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 12a7afa6481e8e4a9c0ef8115eaf328dc7af3029 Author: Marc Dionne Date: Wed Sep 9 18:39:24 2009 -0400 Remove extraneous + character in src/volser/common.c Remove an unneeded extra + character at the end of line - probably from a typing accident. This generates a warning at compile time. Reviewed-on: http://gerrit.openafs.org/437 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f041bd25343f40986c035ed6c0a087709ed64bc4 Author: Felix Frank Date: Mon Jul 13 08:54:23 2009 +0200 Cosmetics: Rename some variables, fix types. * Replaced tsize by new local var llbytes in rxfs_storeInit. * Make int32 lengths unsigned in rxfs_storeInit. * Renamed lengthFound to length64. * renamed abase to base. Reviewed-on: http://gerrit.openafs.org/127 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 23143230e68516c89f3acf76999223dad4af612f Author: Christof Hanke Date: Wed Sep 9 16:21:44 2009 +0200 Moved CForeign check to rxfs_storeInit/storeMore. This is rxfs-specific, so move it out of CacheStoreProc. It must be done before entering the do { } while (moredata) loop proper now, as rxfs_fetchMore is never called during the first iteration (moredata is always 0), but the length may need fixing (note that this was done after what is now the fetchMore op originally). Thus it appears in rxfs_fetchInit. To prevent a bogus call during the first loop iteration, also check for length!=0. Finally, don't bother with fetchMore at all unless CForeign is set. In rxfs_fetchInit, we added an additional check for length_hi being zero. uploade patchset 8. Reviewed-on: http://gerrit.openafs.org/126 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 01fae602425b91647b54888c82450091d4c89714 Author: Jeffrey Altman Date: Tue Sep 8 16:36:32 2009 -0400 Windows: Use secure ctime and strncpy in afs_ctime Microsoft compilers version 1400 and above provide secure versions of ctime and strncpy. Use them in afs_ctime. Correction to sha1:359c64bb674ea0606e64b91fd8252297310a9862 Thanks to Andrew Deason for identifing the mistake. Reviewed-on: http://gerrit.openafs.org/429 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 5d1efd3cd86f12d6be073e9b8103f16bf33d8bab Author: Jeffrey Altman Date: Tue Sep 8 16:43:01 2009 -0400 Windows: secure rand() rand_s() is available on Visual Studio 2005 and above (aka 1400 and above) LICENSE MIT Reviewed-on: http://gerrit.openafs.org/430 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 0f7efd94fa12cf82efe6c31ee33d9b3ca51666e1 Author: Jeffrey Altman Date: Sun Sep 6 15:10:56 2009 -0400 Windows: Add data validation to ktc_xxxx functions that perform pioctls The ktc_GetToken and ktc_ListTokens functions perform a pioctl and then parse the response data. There is no validation that the data required is not longer than the pioctl output or that the data received fits into the data structures that are being written. As a result, random crashes have occurred when the wrong data has been received from the pioctl. This commit adds data validation to at least ensure that these functions cannot read beyond the data provided or write beyond the allocated memory. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/405 Reviewed-by: Derrick Brashear Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit f7085c38e15db15e2795ff33e9b54977e703a097 Author: Marc Dionne Date: Tue Sep 8 17:58:41 2009 -0400 build fix: ubik_client is a struct Fix a build failure - ubik_client is a struct and not a type Reviewed-on: http://gerrit.openafs.org/431 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 359c64bb674ea0606e64b91fd8252297310a9862 Author: Jeffrey Altman Date: Sun Sep 6 18:47:54 2009 -0400 Windows: Use secure ctime and strncpy in afs_ctime Microsoft compilers version 1500 and above provide secure versions of ctime and strncpy. Use them in afs_ctime. Reviewed-on: http://gerrit.openafs.org/408 Reviewed-by: Derrick Brashear Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Derrick Brashear Reviewed-by: Jeffrey Altman commit 1992b702f64f561c75cc74d4645bb0e1afeec6bd Author: Russ Allbery Date: Sat Aug 22 00:31:22 2009 -0700 Only force a specific compiler where necessary Rather than setting the compiler to cc on all platforms by default, use the Autoconf default unless the specific compiler might matter. Conservatively set the compiler to cc for all non-Linux, non-BSD operating systems that previously didn't explicitly set it. Fix a few places on Linux where the compiler was set to gcc explicitly rather than using the Autoconf result. Don't bother setting the Linux i386 compiler to gcc -pipe. The compile performance difference isn't enough to bother with the special exception, and we don't do this for other Linux systems. With this change, setting CC at Autoconf time will correctly set the compiler per the user's preferences unless they're on an operating system where we care about having a particular compiler for kernel purposes. This can be relaxed further in the future, particularly if the kernel compiler is broken out to a separate setting. Reviewed-on: http://gerrit.openafs.org/337 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 950b96f290d0874e5a8e6d8bc693d4d03a3e88f2 Author: Russ Allbery Date: Fri Aug 21 19:11:58 2009 -0700 Remove old disabled code to support truncated passwords ka_UserAuthenticateGeneral had code disabled with #ifdef OLDCRUFT to retry failed authentications by truncating the password to eight characters, with a comment that the truncating behavior of kpasswd was disabled in 1990. Nothing references this preprocessor define in the source tree. Delete the dead code. Reviewed-on: http://gerrit.openafs.org/336 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 7e91d071f007c3be74dce800c38b0ac980465df0 Author: Jeffrey Altman Date: Sun Sep 6 15:25:42 2009 -0400 Windows: Prevent pioctl races from crashing afsd_service The SMB redirector will permit two processes to open the pioctl file at the same time without giving SMB server an opportunity to say 'no'. As a result multiple reads and writes on the allocated smb_fid->ioctl can play havoc with the pioctl state. Since afsd_service doesn't know the writes and reads are coming from separate requests there is nothing it can do to prevent incorrect data going to the wrong process. However, it can (and should) protect itself when the state becomes invalid. Two prevention methods are applied: 1. add an additional state flag that explicitly indicates when the ioctl is in the dataout state 2. validate the length of data in the ioctl input or output buffers before copying it. If the length becomes negative, return a CM_ERROR_INVAL error. In addition, when the invalid state results in a failure to to find a matching pioctl function do not return CM_ERROR_BADOP. CM_ERROR_BADOP can only be returned if the SMB operation is not supported. Returning it in response to a ReadFile request will cause the SMB client to drop the connection. Finally, fix smb_FindFID to prevent the same 'fid' from being used for more than one open file. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/407 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 96ebb6df31ad300680d4a1dd7d04a714f54a22b5 Author: Jeffrey Altman Date: Sun Sep 6 15:20:58 2009 -0400 Windows: Fake scache not completely initialized The fake scache object used for pioctl operations was not fully initialized. The magic value, data version, and several locks were not initialized. Do so. Since the fid of the fake scache object is 0.0.0.0 remove the assert in cm_GetSCache for cell != 0. Instead simply return CM_ERROR_INVAL. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/406 Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 132268042d1992d39614e72d67957b2b10ebfba6 Author: Jeffrey Altman Date: Sun Sep 6 14:45:42 2009 -0400 Windows: Prevent simultaneous pioctls The Windows pioctl implementation makes an incorrect assumption. It is not true that every CreateFile() operation results in a SMB NTCreateX operation being delivered to SMB Server. The SMB client can combine open requests from multiple processes or threads onto a single SMB file descriptor and locally manage the operations. This is a problem for pioctls since the Transceive operation requires that a WriteFile/ReadFile combination must belong to the same request. Prior to this change simultaneous pioctl operations would be combined and the individual reads and writes could overlap resulting in responses going to the wrong requestor and end of file errors being received by the others. Due to lack of data validation in fs.c, ktc_nt.c, symlink.c, etc random crashes are produced. This change alters the sharing mode under which the pioctl file is opened. Instead of FILE_SHARE_READ | FILE_SHARE_WRITE, only FILE_SHARE_READ is specified to CreateFile(). This ensures that the CreateFile will fail with a sharing violation if the pioctl file was previously opened for writing. A sharing violation check is provided and the CreateFile is retried indefinitely until the open succeeds or the error is not a sharing violation. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/404 Reviewed-by: Derrick Brashear Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 60caadec3a7d6ef64744be8533205ecfa0ff4179 Author: Jeffrey Altman Date: Sat Sep 5 09:44:11 2009 -0400 Windows: smb_FindShareCSCPolicy uses invalid registry key smb_FindShareCSCPolicy() ignored the error state of RegCreateKeyEx() and would pass the uninitialized hkCSCPolicy to RegQueryValueEx() and RegCloseKey(). While this did not produce invalid results, it did result in unnecessary operations and exception handling within the Win32 registry apis. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/402 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 5aced2e8d68e109145893a508ff61437d31a6de9 Author: Jeffrey Altman Date: Sat Aug 29 14:16:45 2009 -0400 Correct nvldbentry and vldbentry misuse in uss/uss_vol.c The uss module relies on MapNetworkToHost / MapHostToNetwork from src/volser. These functions convert a struct nvldbentry and not a struct vldbentry. When src/volser was converted to struct nvldbentry src/uss must have been forgotten. In uss_vol.c convert GetServerAndPart() to accept a nvldbentry instead of a vldbentry. Add two static functions: * ovlentry_to_nvlentry() to convert from vldbentry to nvldbentry if required * uss_vol_GetEntryByID() which first attempts to use ubik_VL_GetEntryByIDN() and if that is not supported falls back to ubik_VL_GetEntryByID() and ovlentry_to_nvlentry(). LICENSE MIT FIXES 125101 Reviewed-on: http://gerrit.openafs.org/377 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 0ee69d5b9a64a96c5c217d523ba23371d41cb85d Author: Derrick Brashear Date: Mon Sep 7 22:29:54 2009 -0400 fetchstore nocall argument breaks non-64bit clients a label before the end of a loop breaks, which is the case when AFS_64BIT_CLIENT's not defined (e.g. UKERNEL). fix it. Reviewed-on: http://gerrit.openafs.org/410 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 8a8244dd351f865af2da3b5ebb746ba57723b6a9 Author: matt@linuxbox.com Date: Thu Sep 3 10:15:18 2009 -0400 Remove struct from AFS_UCRED instantiations (opaque credential type support) The identifier AFS_UCRED is intended as a preprocessor alias to a possibly-opaque credential type. A platform header will normally rename AFS_UCRED to a platform credential type with #define. This is not intended to change the meaning of AFS_UCRED, but removes the assumption that it is a struct type, which may not be true, depending on the platform and other decisions made by the AFS client port. Reviewed-on: http://gerrit.openafs.org/397 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 3de3cb03c2c7a23bfb092f51a7715c73ef38b9bd Author: Jeffrey Altman Date: Fri Sep 4 23:22:12 2009 -0400 Windows: Log RXKAD errors in cm_Analyze RXKAD errors were not logged at the point where the errors were handled. As a result they were never logged. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/400 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit edccb905d4753fa5412e3212e8626e8437cbecfb Author: Jeffrey Altman Date: Fri Sep 4 23:23:10 2009 -0400 Windows: Explorer Shell Invalid Parameter Errors The attempt to follow the smb protocol specification by returning extended responses to NTCreateAndX requests (when specified) resulted in random "invalid parameter" errors from the Explorer Shell (and common control dialogs) on Vista SP2. As a result we won't send the extended responses. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/399 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit a43c893d498effd1165bfe78179934194c34b448 Author: Jeffrey Altman Date: Fri Sep 4 23:13:52 2009 -0400 Windows: Freelance get callback sync and uninitialized variables In cm_GetCallback the Freelance mode case did not properly synchronize attempts to fake obtain a callback. cm_GetCallback also failed to initialize the contents of afsStatus and volSync which are used as input to cm_MergeStatus. cm_MergeStatus special cased the freelance root.afs volume root directory but failed to handle any other freelance volume objects. As a result it used the contents of the uninitialzed input structures to populate the status of the object for which the callback was obtained. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/401 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit ad1e9c7084e99a67ee7a61c255a6059ebc9190c3 Author: Derrick Brashear Date: Tue Sep 1 13:00:00 2009 -0400 make afsd partition size check be large partition safe right now the math overflows the 32 bit type for >2tb partitions. use larger variables to avoid this. Reviewed-on: http://gerrit.openafs.org/392 Reviewed-by: Matt Benjamin Reviewed-by: Andrew Deason Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 5d9c767ac55b2d1b8f5b87dc9ced63e282af7bac Author: Andrew Deason Date: Mon Aug 31 11:10:10 2009 -0500 Update accessDate on volume access Right now accessDate is simply never updated, so the last access time for a volume is never reported. Simply update the field in VBumpVolumeUsage_r, so we track the last time the volume was accessed. Note that this does not increase disk writes to the volume header; the performance impact is effectively nil. Reviewed-on: http://gerrit.openafs.org/385 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 24ddc90e5dd3e8847d314adf9858b67b47ed7854 Author: matt@linuxbox.com Date: Fri Aug 28 11:54:41 2009 -0400 Add tracing to MCAS allocator and GC Adds conditional trace logging to MCAS object cache and supporting GC, using ViceLog. While in future this should be normalized, it is correct for both fileserver and volserver, the two programs using MCAS currently. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/374 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit fb79d6e1f0bcef0602df7bb4ec961955c2f06563 Author: Jason Edgecombe Date: Sun Aug 30 18:26:10 2009 -0400 Updated Chapter 2, Section 3.4 of the Admin Guide Added a bullet point explaining the use of a Kerberos cross-realm trust and PTS foreign groups to give foreign users access. Replaced a reference to Authentication Database with Kerberos Database. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/381 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 880664bd0df8380b77cefe80379170c9c183442c Author: Jeffrey Altman Date: Wed Sep 2 22:49:40 2009 -0400 Windows: The unnamed stream is a synonym Treat a file request for "name::$DATA" as if it were specified as "name". Otherwise, the inclusion of the colon in the file name will cause it to be treated as invalid. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/395 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit ae7ef5f5b963a5c8ce4110a7352e0010cb6cdbc1 Author: Jeffrey Altman Date: Wed Sep 2 22:54:17 2009 -0400 Windows: rx_Write failures must be processed The error code returned by rx_Write takes precedence under all circumstances over the error returned by EndRXAFS_StoreData. cm_ReleaseBIOD must apply the error code to all buffers in the BIOD list. cm_ReleaseBIOD accepts an error code, not a boolean indicating failure. Fix a related signed/unsigned error. FIXES 125351 LICENSE MIT Reviewed-on: http://gerrit.openafs.org/396 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit baa883aa6b878abe808d302d14142f702dfb9cca Author: Jeffrey Altman Date: Wed Sep 2 22:44:33 2009 -0400 Windows: avoid inappropriate dns searches Do not perform searches for cells if the string prefix matches _._AFS_IOCTL_._. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/394 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit d352ca1df447c489b46f45edfbf633ca39d56fd4 Author: Jason Edgecombe Date: Sun Aug 30 17:54:16 2009 -0400 Updated Chapter 2, Section 3.2 of the Admin Guide Removed the reference to the Authentication Server and added a reference to the Kerberos Server and Kerberos 5 authentication for foreign clients. Replaced AFS Product Support with the AFS registrar as the maintainer of the public CellServDB file. A link was added to grand.central.org for getting the latest copy of the file and submitting changes for the local site. Reviewed-on: http://gerrit.openafs.org/379 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit e86cb488b3d28eea7d2a1780d578fcfee67d8e3b Author: Andrew Deason Date: Wed Sep 2 11:50:06 2009 -0500 SALVSYNC_com initialization typo The size of sres_hdr is sizeof(sres_hdr), not sizeof(sres). Reviewed-on: http://gerrit.openafs.org/393 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 5dd137c474cc5ffc877bb0655220ad4b2503ed10 Author: Russ Allbery Date: Fri Jul 24 13:18:31 2009 -0700 Turn on --enable-bos-new-config unconditionally Remove the conditional and Autoconf flag for enabling BosConfig.new handling and change bosserver to always rename BosConfig.new to BosConfig on startup if the former exists. Document BosConfig.new handling in the bosserver and BosConfig man pages. Tone down the warning about the BosConfig file format changing and warn that bosserver rewrites BosConfig when shutting down. Reviewed-on: http://gerrit.openafs.org/211 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 64bad257d66b7d70ebdb62a10217818730e2e0a6 Author: Andrew Deason Date: Wed Jul 29 11:56:34 2009 -0400 DAFS: avoid shutdown hang during salvage Right now, when the fileserver shuts down, it tries to cancel any demand-salvages in progress. This causes the fileserver to hang, since during shutdown, the salvageserver may already be gone. This avoids cancelling in-progress salvages, and allows salvages to continue after the fileserver has shut down. To do this, the salvageserver now closes SALVSYNC sockets in spawned children, so the children don't get SALVSYNC requests directed at them, since they can't handle them. The salvageserver also now periodically scans for logs of salvaging children that have terminated, and incorporates them into SalsrvLog, just like it does for it's own children. The salvageserver children that actually perform salvages now also set the inUse volume header field to their programType, so the fileserver knows not to schedule new salvages for that volume in the event of a fileserver restart during a salvage. FIXES 124486 Reviewed-on: http://gerrit.openafs.org/279 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 5fd700d1fda856b0e16588cef0e54bc37498d375 Author: Christof Hanke Date: Tue Sep 1 14:33:53 2009 +0200 Uploaded patchset 9. Sorry for the mess. Reviewed-on: http://gerrit.openafs.org/125 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 04aecc99e073b07fe781d65c5c274acee14d8d26 Author: Andrew Deason Date: Thu Aug 27 12:43:03 2009 -0500 Fix cache tracking for small fragsizes The tracked amount of disk cache used by a client can be incorrect when afs_fsfragsize is tuned to below 1023. Since we round up to the next nearest afs_fsfragsize+1 then round down to the kb, if afs_fsfragsize+1 < 1kb, we can undershoot the cache usage. This enforces afs_fsfragsize to always be at least 1023. Reviewed-on: http://gerrit.openafs.org/338 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 67bcc19c754e7bfd55d098e9fe17723340c275ba Author: Jason Edgecombe Date: Sun Aug 30 18:13:06 2009 -0400 Updated Chapter 2, Section 3.3 of the Admin Guide Added text about Freelance Mode and Dynamric Root Mode and the changes they cause when dealing with mounts to foreign cells in /afs and \\AFS Reviewed-on: http://gerrit.openafs.org/380 Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 3e28e72e409550f398d006b7e1fa073bd23e1cfd Author: Christof Hanke Date: Mon Aug 31 15:39:02 2009 +0200 Remove unnecessary type ViceFid The type "ViceFid" is just a clone of the type AFSFid and used only in a couple of places. Thus, for simplicity, rename all occurences of ViceFid to AFSFid and remove the typedef itself. Reviewed-on: http://gerrit.openafs.org/383 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit ac1e6fa1a6f3287e2862e6ea6f4dafea0c92e8cb Author: Jeffrey Altman Date: Mon Aug 31 20:10:13 2009 -0400 Windows: Permit cygwin apps to read from AFS again For some reason specifying a unique GUID for each open file based on the cm_fid results in cygwin apps being unable to read from AFS. ReadFile() calls fail with Invalid Device Request errors instead. While fixing that issue discovered that not all of the data was properly set for QueryPathInfoAll operations. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/388 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit c0e1cc0762eb7e49d72fdfecda168e72db55c3e8 Author: Jeffrey Altman Date: Mon Aug 31 20:08:53 2009 -0400 Windows: uninitialized variable Ensure that the index variable used to walk the fid history of the current evaluated path is always initialized. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/389 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 95df1a47d1e40eb9d007853c99826432e7ac4016 Author: Jeffrey Altman Date: Mon Aug 31 20:06:27 2009 -0400 Windows: integrated logon The previous fix prevented a null pointer dereference but forgot to set 'effDomain' to the domain specified by the caller if it exists and is not the local machine name. LICENSE MIT FIXES 125325 Reviewed-on: http://gerrit.openafs.org/390 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit e31f3f68b0a28a9fe0c95aa44828844426a557e2 Author: Matt Benjamin Date: Mon Aug 31 08:57:55 2009 -0400 Make catalog file destdir when not transarc paths The appropriate mkdir -p was missing for this case, the patch adds it. Reviewed-on: http://gerrit.openafs.org/387 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 616ab5c9ec624fc1f852e8188b800e32a9ebe74e Author: Matt Benjamin Date: Mon Aug 31 06:16:27 2009 -0400 Remove AFS_KERBEROS_ENV in NetBSD 30, 40 param files This creates dependency on ktc_newpag, which has been determined to be obsolete. Reviewed-on: http://gerrit.openafs.org/384 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 49d893eff3bf5933bd4a6c62c5576d30bcda56d9 Author: Matt Benjamin Date: Sun Aug 30 13:30:18 2009 -0400 Build shared afsauthent and afsrpc on *BSD This seems to be a required step, going forward. Omitting breaks pam, for example. Reviewed-on: http://gerrit.openafs.org/382 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit dffd78ccb013cbda907d5c266137de94814d9c00 Author: Claudio Bisegni Date: Fri Aug 28 21:16:52 2009 +0200 Fixed the tokens update and update .gitignore for MacOSX packaging file Fixed the tokens update on preference pane if operation is made with NSStatusItem. Has been updated the src/packaging/MacOS/.gitingore for CellServDB file and src/libafs/.gitignore has been added afs.x86_darwin_100.plist. Reviewed-on: http://gerrit.openafs.org/372 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 85408141403cc18a954877dd682022063203f4c8 Author: Michael Meffie Date: Fri Aug 28 11:40:01 2009 -0400 doc: typo fix in asetkey man page example Fixed a typo in the asetkey man page. Reviewed-on: http://gerrit.openafs.org/373 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e26235ed3ed4c444d907d217a4b6cdd25fa1d475 Author: Derrick Brashear Date: Fri Aug 28 01:01:46 2009 -0400 macos 10.5 doesn't support compiler kext flag -kext was added in later xcodes; it's safer to just assume we don't have it. Reviewed-on: http://gerrit.openafs.org/365 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 7bf32f6115c5af3e772287754ea4aa1465764dca Author: Jeffrey Altman Date: Thu Aug 27 16:17:24 2009 -0400 Windows: Version Update 1.5.6200.0 Version update to 1.5.6200.0 LICENSE MIT Reviewed-on: http://gerrit.openafs.org/354 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit f77cc39801b4ee046f6968616332ef3db5415f97 Author: Jeffrey Altman Date: Thu Aug 27 03:59:02 2009 -0400 Windows: SMB Server does not support streams, so say that The SMB server does not support streams. When replying to NT Create operations with extended responses report that there are no streams. In addition, add support for Query Path/File Stream Information and return only the null stream. Correct the 'totalData' response field in several places within Trans2QPathInfo and Trans2QFileInfo. Return CM_ERROR_BADOP for SMB NT Transact operations that are not supported instead of CM_ERROR_INVAL. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/347 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit a767455f02460e39e8c5eaa77768718667a2f29a Author: Jeffrey Altman Date: Thu Aug 27 15:29:50 2009 -0400 Correct description of afs krb.conf file format The file format is a single line containing one or more realms separated by white space. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/352 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit a747f5951b920dfb6d77465de6ca8ff54bae1706 Author: Derrick Brashear Date: Thu Aug 27 15:47:58 2009 -0400 update decode-panic for 10.6 how panics get reported changed in 10.6. also, the 64 bit universal kext means we don't know what the last boot was. Reviewed-on: http://gerrit.openafs.org/353 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 6b555e5dc116905a3e8f356c45827f58b3a00f9d Author: Derrick Brashear Date: Thu Aug 27 11:18:41 2009 -0400 make openafs 1.5.62 update version strings for 1.5.62 Reviewed-on: http://gerrit.openafs.org/351 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 2b1336b59b554b657a2d671adbc0469e18004fbb Author: Derrick Brashear Date: Thu Aug 27 08:12:31 2009 -0400 macos afs prefspane support for 10.4 NSUInteger is newer than what's included in the 10.4 SDK. restore functionality for 10.4 Reviewed-on: http://gerrit.openafs.org/349 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit abcb52c4fd84c1d371be90ec3d602ca780644e2a Author: Derrick Brashear Date: Thu Aug 27 10:12:13 2009 -0400 correct GetuTime function name GetuTime is really osi_GetuTime Reviewed-on: http://gerrit.openafs.org/350 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 81099c479e148a103dcf9f4def125b28e989107c Author: Derrick Brashear Date: Wed Aug 26 17:34:50 2009 -0400 macos 10.6 64 bit support support 64 bit userland with 32 bit kernel, and 32 and 64 bit userland with 64 kit kernel Reviewed-on: http://gerrit.openafs.org/343 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 74d3b110628fee3d0cc08303736c1b84deb8d4e6 Author: Derrick Brashear Date: Thu Aug 27 07:53:00 2009 -0400 redefine xdr functions consistently if we redefine the names of all xdr_ functions, the same must be done for xdr_alloc and xdr_free Reviewed-on: http://gerrit.openafs.org/348 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit af8dee05f07e63cf954326eff27630b38ad76edd Author: Jeffrey Altman Date: Wed Aug 26 22:31:58 2009 -0400 Windows: Release Notes Updates for 1.5.62 Some formatting corrections Section 3.26 updated to describe limitations caused by Apple Bonjour on 32-bit Windows. Section 3.40 updated to mentions Microsoft SMB Redirector Extended Server Timeout support. Section 3.41 updated to describe inability of pioctl operations to succeed on service mapped drives. Section 3.43 updated to include Windows 7 and Server 2008 in the known issues list. New section 3.51 on Microsoft RPC Services LICENSE MIT Reviewed-on: http://gerrit.openafs.org/346 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit d605bf109db15e535618847baadffb35a92ed41a Author: Jeffrey Altman Date: Wed Aug 26 17:32:31 2009 -0400 Windows: Updates to Windows ChangeLog 1.5.6200 LICENSE MIT Reviewed-on: http://gerrit.openafs.org/345 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 9473089bdf1997b2f43e3ea368907c6cdc0fa582 Author: Derrick Brashear Date: Wed Aug 26 15:15:27 2009 -0400 macos rc script server handling only start bosserver if its configured. shut it down if we (likely) started it Reviewed-on: http://gerrit.openafs.org/344 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 622065f98ea806314e1b7116f0b280092aa397b1 Author: Russ Allbery Date: Tue Aug 25 21:00:33 2009 -0700 Initialize xferStartTime for StoreData timings In the reorganization of fetch and store procs, the initialization of the transfer start time for a store was lost, leading to meaningless statistics from the uninitialized variable. Initialize the transfer time at the start of transferring each chunk and move the variable into the for loop. Reviewed-on: http://gerrit.openafs.org/340 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit a59df36211d6bc641eeec6d8fd8876a98ce3600a Author: Russ Allbery Date: Fri Aug 21 18:37:41 2009 -0700 Add automatic sysname detection for ARM Linux Add arm*-linux* to the case statement that attempts to automatically determine the AFS sysname, similar to the other Linux sysname determination cases. Reviewed-on: http://gerrit.openafs.org/334 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b695261de43af0fbdd8166b4b2272465783e76d6 Author: Claudio Bisegni Date: Wed Aug 26 17:18:37 2009 +0200 10.6 update(Workaround for kerberos bug) and cleaning of deprecated function form code For aklog has been added the workaround for kerberos function KLAcquireInitialTickets that in 10.6 return always error. First is called KLCacheHasValidTickets for check user ticket presence, if there are no ticket KLAcquireNewInitialTickets will be called for get user credential. Has been removed also many deprecated api. Reviewed-on: http://gerrit.openafs.org/341 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit a66dc4d0cb99d2b2f0bc5e7537d83522f68fbb44 Author: Felix Frank Date: Wed Jul 15 14:11:32 2009 +0200 Some renames and reformattings in afs_fetchstore Reviewed-on: http://gerrit.openafs.org/124 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 88b7deb5bc39f58e490e2ec83e563feeb32668e7 Author: Felix Frank Date: Fri Jul 10 15:55:58 2009 +0200 Sanity for the padd storeOp Reviewed-on: http://gerrit.openafs.org/123 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 6220ede6a96d06c53eddd848435764cff96be1b4 Author: Felix Frank Date: Wed Jul 8 16:36:34 2009 +0200 Add the padd storeOp and unify statistics keeping. Filling with zeroes is done within a storeop of its own. This raises consistency and readability. Also, the formerly copy-pasted (to afs_dcache and afs_segments respectively) statistics code is now in a seperate function of its own. Reviewed-on: http://gerrit.openafs.org/122 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 4b10f1916cd000cfd75134c8e1665d72899bc10d Author: Jeffrey Altman Date: Tue Aug 25 12:46:01 2009 -0700 Windows: MSRPC_WriteMessage, call MSRPC_NewCall at right time In MSRPC_WriteMessage, call MSRPC_NewCall after checking for MAX_RPC_MSG_SIZE and return an error if MSRPC_NewCall fails. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/339 Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 1692c27300e55f9219dc75e1b5ab81d4ff98e4ae Author: Felix Frank Date: Tue Jul 14 12:46:08 2009 +0200 Cleanups in rxfs_storeInit() Reviewed-on: http://gerrit.openafs.org/121 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 0e1bd20462d4fd0aaa3fb18e127b1f1597a76799 Author: Felix Frank Date: Tue Jul 14 12:42:44 2009 +0200 More CacheStoreProc call context to afs_fetchstore from afs_segments The loop over the dcaches is performed in afs_fetchstore now as well, in a new routine afs_CacheStoreVCache that is called in afs_CacheStoreProc's stead. The original afs_CacheStoreProc has largely moved to afs_CacheStoreDCaches in afs_fetchstore.c. Enhances readability of afs_StoreAllSegments. rxfs_storeInit() can be performed earlier now, which is instrumental for the inclusion of alternative protocols (which will call other storeInit() functions). Reviewed-on: http://gerrit.openafs.org/120 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 334114ac58b0039ae90d7e29fa2f019fe068bd79 Author: Felix Frank Date: Tue Jul 14 12:02:19 2009 +0200 Limited the scope of some local variables in afs_CacheStoreProc Reviewed-on: http://gerrit.openafs.org/119 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit beb57af06ff9d20aa8d038f6d3474b62922c41b4 Author: Felix Frank Date: Tue Jul 14 11:19:31 2009 +0200 Open/close connections in afs_fetchstore rather than afs_segments The respective snippets are moved from afs_StoreAllSegments to rxfs_storeDestroy and rxfs_storeInit respectively. This makes sense and enhances readability. Reviewed-on: http://gerrit.openafs.org/118 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 74d53f288c7eeecc36d4c082dd96d840f1861d7b Author: Simon Wilkinson Date: Tue Jul 21 20:26:34 2009 +0100 PAG numbers are unsigned (and other warnings) PAG numbers are represented by afs_uint32. Fix assorted call sites to reflect this. While we're here, prototype ktc_newpag, and fix the casts used by the ktc_curpag() call. Reviewed-on: http://gerrit.openafs.org/167 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 50f6529cf1f191606f55add4cabe53fceab492ed Author: Simon Wilkinson Date: Tue Jul 21 19:58:16 2009 +0100 Make lockIDSet readable by mortals The lockIDSet function was a sprawling mess of #ifdefs. This change consolidates it so there is completely different function for each platform, with some internal #ifdefs remaining for platform-specific variations. The side effect of this is that the function is now readable. Reviewed-on: http://gerrit.openafs.org/164 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 0666fe12facf53ad2b67e4ba23b034b2e639d737 Author: Simon Wilkinson Date: Tue Jul 21 20:10:05 2009 +0100 Fix printfs of time for Darwin Darwin uses a fancy type for tv_sec, which needs to be cast to long before it can be printed. Reviewed-on: http://gerrit.openafs.org/165 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit 01349d8a9468de0e46eeef42dede3a7076f1abb5 Author: Felix Frank Date: Tue Jul 14 11:07:07 2009 +0200 Move statistics and and call-closing from afs_segments to afs_fetchstore. Rather than in afs_StoreAllSegments, do statistics in afs_CacheStoreProc, further boosting the former's readability. Calls are closed in a new storeOp now, rxfs_storeClose, and have been moved there from afs_StoreAllSegments as well. Reviewed-on: http://gerrit.openafs.org/117 Reviewed-by: Derrick Brashear Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit db717c69dad1518043cb317aedb6d082476386f0 Author: Jeffrey Altman Date: Thu Aug 20 17:22:08 2009 -0400 Windows: Correct buf_Write data loss errors buf_Write has two errors in it. First, if offset at which the write is supposed to begin does not align with the cm_data.blockSize, then (offset %blockSize) octets at the end of the write will fail to be written to the file server. Second, if there is no knowledge of the file server's ability to handle RXAFS_StoreData64 calls and the file server does not support StoreData64 calls, then the first chunkSize of data will be written to the file server before the RXGEN_OPCODE error is detected. In this case a retry using RXAFS_StoreData is performed but the values of 'nbytes' and 'qdp' were not reset before the retry. As a result, the first chunkSize of data would fail to be written to the file server. The second problem can reliably occur when connectivity between the cache manager and the file server is interrupted due to firewall port mapping closures. Upon establishing a new rx connection, a SRXAFSCB_InitCallBackState3 RPC will be issued by the file server erasing any prior knowledge of the file server's ability to process 64-bit data operations. If the first 64-bit operation is a StoreData64, then data loss will occur. LICENSE MIT FIXES 125220 FIXES 108199 Reviewed-on: http://gerrit.openafs.org/332 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 687a40c7c6f3e0391ec1c863113c22f970003b49 Author: Jeffrey Altman Date: Thu Aug 20 10:54:47 2009 -0400 Windows: cleanup smb polution of non-smb modules There are a variety of functions that are declared in smb modules that are used within non-smb modules. In order to reduce some of the polution, several time conversion functions and the thread priority operations are migrated to cm_utils. As part of this migration the unused !USE_NUMERIC_TIME_CONV time implementations are removed. In addition, an unnecessary use of an SMB preprocessor symbols is removed from cm_freelance.c and smb_ioctls.h is no longer included within afsd.h. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/330 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit ef197772e7a1bd823f6f5d0ea3846ccabe950a1e Author: Jeffrey Altman Date: Thu Aug 20 14:30:27 2009 -0400 Windows: Init root.afs before smb_Init It is not safe to initialize the root.afs cm_scache object after the SMB package. Break it out of afsd_InitDaemon() into its own afsd_InitRoot() and call from afsd_InitCM(). LICENSE MIT Reviewed-on: http://gerrit.openafs.org/331 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit da0673f0eabb960b203b1a814aa62acbef62eeb1 Author: Russ Allbery Date: Wed Aug 19 16:07:27 2009 -0700 Describe 's' PTS group permissions more accurately PTS groups with 's' access permissions can be examined by members of the group and the owner of the group in addition to system:administrators. State this in the manual page. Reviewed-on: http://gerrit.openafs.org/327 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 8b5846b080d455c8764450b545c1ee3ded61aa3c Author: Jeffrey Altman Date: Thu Aug 20 09:21:53 2009 -0400 Windows: Ensure consistency of error code mapping For Windows, the error mapping table used throughout the system is located in util/errmap_nt.h. This table was incomplete and WINNT/afsd/cm_utils.c added additional mapping locally. Move said error mapping to util/errmap_nt.h. When including afs/unified_afs.h it must be done after including afs/errmap_nt.h. Otherwise, undefined errors are mapped to EIO which should not be. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/328 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 995c76e73e828eac2e30b33de5ee8085e6cead0a Author: Jeffrey Altman Date: Thu Aug 20 09:44:18 2009 -0400 Windows: Add prototype for osi_SetLockOrderValidation Add prototype for osi_SetLockOrderValidation() defined in osibasel.c LICENSE MIT Reviewed-on: http://gerrit.openafs.org/329 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 5ff34cc364ea80fe1e55262ac97091b42d47e3d8 Author: Felix Frank Date: Tue Jul 14 11:01:57 2009 +0200 Move context of afs_CacheStoreProc() call from afs_segments to afs_fetchstore The innermost loop in afs_StoreAllSegments (looping over chunks) is now inlined in afs_CachStoreProc. This is step one in a series of such inlinings. Reviewed-on: http://gerrit.openafs.org/116 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit ebd42496392d4ff207a97dd664d8dbaad66425b0 Author: Felix Frank Date: Tue Jul 14 10:57:21 2009 +0200 Move statistics keeping from afs_dcache to afs_fetchstore. More context of the afs_CacheFetchProc() call in GetDCache is now inlined in the afs_CacheFetchProc. Boosts readability of GetDCache and saves stack, as counter pointers need not be passed anymore. The statistics code is more readable due to lesser indentation. Reviewed-on: http://gerrit.openafs.org/115 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit e2ce6a0f40aceb83a53883875e4430677a0f3068 Author: Jeffrey Altman Date: Wed Aug 19 18:10:43 2009 -0400 Windows: cm_conn_t must not be referenced after cm_Analyze is called The 64-bit Large File Support added a reference to the cm_conn_t object after cm_Analyze() is called and releases the hold. This permits the object to be freed if it is appropriate to do so which can result in an invalid memory reference. This change removes the improper reference. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/326 Tested-by: Asanka Herath Reviewed-by: Asanka Herath Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 1d78be16945a5a025b7e10098d89d7bccc01c231 Author: Felix Frank Date: Tue Jul 14 10:54:06 2009 +0200 Some code cleanups and variable renames. Reviewed-on: http://gerrit.openafs.org/113 Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit 1c12747818d1bbd327f94ba66808f5d705f8b618 Author: Jeffrey Altman Date: Wed Aug 19 08:04:30 2009 -0400 Windows: Permit build system to update symbol store Microsoft Debugging Tools for Windows, Visual Studio Debugger, and SysInternals tools can all make use of a Symbol Server. http://msdn.microsoft.com/en-us/magazine/cc163563.aspx The commit adds functionality to the build system to automatically add binaries and symbols to a symbol store during the build. This functionality is only enabled if two environment variables are defined: SYMSTORE_EXE - specifies the location of symstore.exe SYMSTORE_ROOT - specifies the location of the symbol store an optional environment variable permits an arbitrary comment to be added to the symbol store history file. SYMSTORE_COMMENT - arbitrary text to be added to the history LICENSE MIT Reviewed-on: http://gerrit.openafs.org/324 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit b48908cbbaee53747c9a7cdfc08692a20aa92cb1 Author: Jeffrey Altman Date: Wed Aug 19 11:51:18 2009 -0400 Windows: Add resource info to threaded volserver.exe 1.5.60 and 1.5.61 shipped without resource information linked to the threaded version of the volserver.exe executable. Correct that oversight. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/325 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 57e218ab61e824133f252e4a0da74552beb14b05 Author: Simon Wilkinson Date: Tue Aug 18 22:31:38 2009 +0100 Make MacOS installer pane permit dashes The MacOS installer only permits characters in [0-9A-Za-z] in cellnames. However, OpenAFS itself will also allow dashes, and they're in use by some sites. This trivially amends the installer pane to permit dashes. FIXES 125211 Reviewed-on: http://gerrit.openafs.org/323 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f819561707805c46b1a67c35d8f9ae1eee420af3 Author: Michael Meffie Date: Tue Aug 18 14:51:57 2009 -0400 Fix stack corruption on 64 bit linux when md5inum is enabled Fix a stack overflow on 64 bit linux which corrupts the stack saved arguments and causes a kernel panic. This bug is seen on platforms where ino_t is 64 bits and the md5inum sysctl option is enabled. Reviewed-on: http://gerrit.openafs.org/322 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit cbaf97a953dc91e54d7148ad4294f003b8deef9c Author: Jeffrey Altman Date: Mon Aug 17 12:33:09 2009 -0400 Windows: Be more conservative about checking error conditions It has been reported that winlogon.exe is crashing on some systems. The reports indicate that the failure is somewhere in GetLogonDomainOptions. This commit ensures that we are more conservative about the assumptions that are made regarding which Lsa operations can fail. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/321 Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 4eee2f24a43052e5cafc1a3019b6554109a7cc6d Author: Jeffrey Altman Date: Mon Aug 17 17:28:28 2009 -0400 Windows: src/WINNT/afsd cleanup Update the "clean" rule to remove the files generated from ms-srvsvc.idl and ms-wkssvc.idl. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/320 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit fa07f46db9dcc1dccf3a7ff50037f2b81936e452 Author: Jeffrey Altman Date: Sun Aug 16 08:43:23 2009 -0400 Windows: Prevent smb_StartedLock use before initialization The smb_StartedLock osi_mutex can be obtained before initialization due to a race if the IP address configuration is in a state of flux as afsd_service is starting up. To avoid the problem call cm_InitDaemons() after smb_Init(). This race is the cause of the periodic assertions in some environments when lock order validation is enabled. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/318 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 918e5b635938738fa9d65a10573e53190ca24ca7 Author: Jeffrey Altman Date: Sat Aug 15 06:43:57 2009 -0400 Windows: Add missing msrpc.h dependency msrpc.h must include cm_nls.h LICENSE MIT Reviewed-on: http://gerrit.openafs.org/316 Reviewed-by: Derrick Brashear Reviewed-by: Asanka Herath Tested-by: Asanka Herath commit 8ed3acdf13c40d93e60f8f057f99d3f3377feab5 Author: Jeffrey Altman Date: Fri Aug 14 21:40:22 2009 -0400 Windows: Prevent cm_daemon thread from terminating during suspend Remove the check for powerStateSuspend that caused the cm_daemon thread to terminate when the machine enters suspend mode. When the machine awakens there is no thread to check the down server state, new IP address bindings, etc. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/315 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 1cfa2259eca210ca480f16a725ca70f5cfc2c8d4 Author: Felix Frank Date: Tue Jul 14 10:51:03 2009 +0200 Move context of CacheFetchProc from afs_dcache.c to afs_fetchstore.c GetDCache() is quite bloated. This inlinining makes code more readable. For protocols to come besides rxfs (such as rxosd), some initializations may need to be performed differently. Thus, much has to be moved to the specific rxfs_fetchInit() function rather than afs_CacheFetchProc() proper. Reviewed-on: http://gerrit.openafs.org/112 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 3a48ae3e243b695ac5bb3b35aa3b09641db1af3b Author: Derrick Brashear Date: Fri Aug 14 12:06:03 2009 -0400 macos 10.6 updates cope with mixed 32/64 environment provided by macos 10.6. build needed stuff for audit logs in shlibafsauthent. Reviewed-on: http://gerrit.openafs.org/310 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit ff138d1bdeab24de27790474adf24ea124a211f1 Author: Claudio Bisegni Date: Wed Aug 12 21:19:49 2009 +0200 OSX Preference Pane and AFS Backgrounder Cleaned most unused log Reviewed-on: http://gerrit.openafs.org/308 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit b2503cd599be26dd5948526d00e3a28dfacd49ec Author: Simon Wilkinson Date: Wed Jul 22 23:05:48 2009 +0100 Fix gtx_create calls to all share a prototype All of the different _create calls need to share a prototype, so function pointers can be stuffed into a structure. Use an anonymous pointer so that we can acheive this. Reviewed-on: http://gerrit.openafs.org/187 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 19459804b0622ebad1e21e2d34ceb55ad7baddde Author: Asanka Herath Date: Wed Aug 12 14:56:56 2009 -0400 Handle more RPC service names While the Windows client only implements support for WKSSVC and SRVSVC RPC services, it should be aware of and handle requests for other well known service names. This patch refactors service name checks to a separate MSRPC_IsWellKnownService() function. In addition, it separates the tests for IPC TIDs from the test for well known service names. An IPC TID may be used for generic pipe operations as well as for RPC message pipe operations. Therefore the fact that a TID was opened for IPC doesn't necessarily mean that it will only be used for RPC. Reviewed-on: http://gerrit.openafs.org/307 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 9f2eb69899f1c4dba6671fe784ea2dd61e75a7eb Author: Asanka Herath Date: Wed Aug 12 13:57:11 2009 -0400 rand_s isn't supported on older Visual C compilers We still support building on Visual Studio 2003 where rand_s() is not available. If we are building on a Visual C compiler prior to version 15.00, failover to srand()/rand() instead of using rand_s(). Reviewed-on: http://gerrit.openafs.org/306 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit a1d46036fee7134a375d57baf4898ca1af6c27ba Author: Felix Frank Date: Thu Jul 2 11:12:24 2009 +0200 Remove CacheStoreProcs and CacheFetchProcs from the afs_cacheOps. The entries are no longer used, as the macros from afs_chunkops.h are no longer necessary and afs_StoreAllSegments calls the CacheStoreProc proper. Reviewed-on: http://gerrit.openafs.org/110 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit ce174b9ef1771395981b297d4bb8779e57c9afab Author: Claudio Bisegni Date: Wed Aug 12 12:41:42 2009 +0200 OSX AFSBackgrounder fix minor bug Has been fixed the status menu icon width, now i keeped from icon image. Fixed the status item icon view redraw. Reviewed-on: http://gerrit.openafs.org/305 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 1024c4cd71d2b63a3b7f608a244d90e75c933d7c Author: Jeffrey Altman Date: Tue Aug 11 10:37:19 2009 -0400 Windows: Dfs Referrals Processing. Not all errors are errors. When processing a Dfs Referral request, not all lookup errors should be treated as if the path does not exist. Servers being down or busy, volumes offline, cell vldb servers not found, etc. do not mean that the client should go searching elsewhere to evaluate the path. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/304 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit d6071aa6e5f93cf9f9dd42c0c49d56416cfdabbe Author: Jeffrey Altman Date: Tue Aug 11 08:43:53 2009 -0400 Windows: Avoid unnecessary DNS lookups Windows will attempt to open connections to a broad range of pipe service (share) names which do not contain a dot in them. Attempts to search for these names as cell names in DNS result in timeouts and sluggish behavior when browsing \\AFS in the Explorer Shell. To avoid this problem, do not perform a DNS lookup for a cellname that doesn't not contain a dot in it. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/302 Reviewed-by: Derrick Brashear Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 8cd1dc27dc16349b94c66eec721191d5dff29dab Author: Jeffrey Altman Date: Tue Aug 11 08:59:39 2009 -0400 Windows: Setting Server Preferences The Windows cache manager can apply administrator specified server preferences as specified in the registry. When these rankings are applied the CM_SERVERFLAG_PREF_SET flag was not set on the cm_server_t object. In addition, appropriate locking was not being used in the places where the flag was set. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/303 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 61ae8792f6608c86f4e3ff82c329b5bb4369204e Author: Felix Frank Date: Thu Jul 2 09:14:13 2009 +0200 Unite CacheFetchProcs and add abstraction calls. The cache type specific differencies among afs_MemCacheFetchProc and afs_UFSCacheFetchProc are divided into two sets of "fetchOps". Upon rxfs_fetchInit, the appropriate set is chosen. Reviewed-on: http://gerrit.openafs.org/109 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit d8c70aa2c34c223d04f5dc1e2999e1489cb05f3b Author: Asanka Herath Date: Thu Aug 6 22:56:42 2009 -0400 Windows: Implement SRVSVC and WKSSVC RPC interfaces Windows uses RPC over SMB to communicate with file servers for administrative tasks including enumeration and queries of file server shares. This patch implements support for RPC over SMB and partially implements the SRVSVC and WKSSVC RPC interfaces. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/301 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit b4975a6a7c4fc3ffa025d2faee148449f26a21f1 Author: Andrew Deason Date: Mon Aug 10 12:06:26 2009 -0500 Restore util des dependency Commit c3c8a3e2f912855addc2c430f909bdce912e3670 removed 'des' as a dependency of the 'util' target, but util still depends on des since rxkstats.c includes des.h. So, put the des dep back in. Reviewed-on: http://gerrit.openafs.org/278 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 6ec3db1bb94a6eee55020b7fa4ac1ba8425a4b2d Author: matt@linuxbox.com Date: Sat Jul 25 14:10:25 2009 -0400 MCAS changes from Matt Change static max allocators to 30. Add atomic add/sub macros returning original value, based on CASIO. Add interfaces to add and remove generic allocator caches. Add atomic inc/dec/sub macros using MCAS primitives. Add inline assembly for x86_64 and shim for Solaris (9+) atomic operations, providing Solaris x86 and alternate shim for Solaris Sparc. Set interface adapted for iteration and generalized for use with opaque key, value pointers. File cas_skip_func.c provides kv interface, cas_skip_adt.c provides kv interface, plus iteration on skip lists. Casual dependencies on stdio and exit() defined out. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/214 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 160aff88be210a8141b67a54583aed7387d8bffc Author: Derrick Brashear Date: Mon Aug 3 12:17:14 2009 -0400 fileserver should actually retry VL_RegisterAddrs on failure currently the background daemon logic for retrying was never triggered. easy enough fix: set FS_registered to 1 so the loop retries Reviewed-on: http://gerrit.openafs.org/266 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit ec83174608917d80517c5107d583d702174bef30 Author: Jeffrey Altman Date: Sun Aug 2 18:59:51 2009 -0400 add xdr_alloc applications can allocate memory that must be deallocated by the XDR package. Add xdr_alloc to permit that. Export from libafsrpc. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/269 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit be1a675dcc7968c6fe10b42fcae85b1e49a5af3c Author: Jeffrey Altman Date: Sat Aug 1 12:31:36 2009 -0400 Make Windows pioctl prototypes consistent with Unix The Windows pioctl prototypes differed from those now exported by sys/sys_prototypes.h. This produced undesirable warnings. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/260 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 1c5dc25c0dae21265296d6b41f903efb116c7774 Author: Jeffrey Altman Date: Wed Aug 5 23:25:42 2009 -0400 Windows: Preserve GetLastError during WinTorture testing When an error occurs during the WinTorture scripts the actual error was not always being preserved because subsequent Win32 calls were executed before the value was logged. In at least one case, the variable used to store the last error was not initialized nor assigned in all data paths. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/270 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit c3c8a3e2f912855addc2c430f909bdce912e3670 Author: Marc Dionne Date: Mon Jul 27 14:24:15 2009 -0400 kauth warning reduction Warning removal for various functions that manipulates keys and use several data types interchangeably. Inline helpers are introduced to convert between the types and are used when making function calls to target the appropriate type: des_prototypes.h cblockptr_to_cblock: des_cblock * to des_cblock charptr_to_cblock: char * to des_cblock charptr_to_cblockptr: char * to des_cblock * rxkad_prototypes.h ktc_to_cblock: struct ktc_encryptionKey * to des_cblock ktc_to_cblockptr: struct ktc_encryptionKey * to des_cblock * kauth_internal.h EncryptionKey_to_cblock: EncryptionKey * to des_cblock EncryptionKey_to_ktc: EncryptionKey * to struct ktc_encryptionKey * ktc_to_EncryptionKey: struct ktc_encryptionKey * to EncryptionKey * - parameters are adjusted for tkt_DecodeTicket(5), replacing the char * key with struct ktc_encryptionKey, to match usage - the get_key function is changed to have a void * parameter, to match usage - rxkad_prototypes.h includes des.h to get the des_cblock definition. This causes conflicts for a few files where the kerberos headers are also included - aklog/aklog_main.c and WINNT/afsd/afskfw.c Use NO_DES_H_INCLUDE in thoses cases to skip the new parts of rxkad_prototypes.h Reviewed-on: http://gerrit.openafs.org/234 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 20243612a15b150a3dbb3c9e027c1c79a0e5f200 Author: Claudio Bisegni Date: Mon Aug 3 19:05:46 2009 +0200 Removed user perspectivev3 file in xcode project and update the gitconfig gitconfig in src/platform/DARWIN/AFSPreference has been modified to ignore the perspectivev3 that is created by xcode for window layout.Has been also delete the file created for the user Reviewed-on: http://gerrit.openafs.org/267 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b0818fcdb227c8b291eb7b23e504fd1d2240eea6 Author: Claudio Bisegni Date: Mon Aug 3 16:40:05 2009 +0200 Cleaned most warning OSX OpenAFS preference and completed the AFSBackgrounder implementation At startup the preference pane check for the presence in ~/Library/LaunchAgents of the file it.infn.lnf.network.AFSBackgrounder.plist that. The agent could be started in OpenAFS preference pane view. AFSBackgrounder has replaced the NSMenuExtra, when it doesn't quit well launchd restart it. AFSBackgrounder can be used also for other work, for now, at login it check the user preference for get token. Has been made some refactoring in code for remove most warning. The unused think are been delete from project. Reviewed-on: http://gerrit.openafs.org/263 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit b3d9dcb855060a9e1cb5b2140983111030fab1a0 Author: Felix Frank Date: Thu Jul 2 09:02:50 2009 +0200 Storeops beautifications. Things can be made a lot more readable in storeOps than in the monolithic StoreProc. Also shorten a panic message that is a bit gratuitous. Reviewed-on: http://gerrit.openafs.org/108 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 7868e1961048d2a24bd5d4d5afab07d3dbf54fd2 Author: Claudio Bisegni Date: Sat Aug 1 19:43:39 2009 +0200 AFS Backgrounder implementation & warirng clean Replaced the NSMenuExtra and created the AFSBackgrounder that will do all work for aklog at login and manage the Status menu in menu bar Reviewed-on: http://gerrit.openafs.org/262 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f52f509962fbaade008f5dc6c2f8a3bece70c13c Author: Claudio Bisegni Date: Wed Jul 29 15:12:13 2009 +0200 Start coding OSX Backgrounder Application, for OpenAFS Preference Pane, that user NSStatusItem To prevent future compatibility with osx we must use NSStatusItem instead NSMenuExtra that is not documented api. For this has been created a background only application that will manage all function managed by current NSMenuExtra Reviewed-on: http://gerrit.openafs.org/261 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit a13d8146a33b2c74909d2bb396af2b7ce01d8bb3 Author: Jeffrey Altman Date: Sat Aug 1 11:23:00 2009 -0400 Add generated files to doc/xml/AdminGuide .gitignore Add htmlhelp.hhp, index.hhk, and toc.hhc Reviewed-on: http://gerrit.openafs.org/259 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 175774acab31968d9033e7c16b99b34c695c8e20 Author: Derrick Brashear Date: Fri Jul 31 17:53:18 2009 -0400 version update for 1.5.61 make configure version strings be 1.5.61 Reviewed-on: http://gerrit.openafs.org/258 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 5a4f31090f573caad71aab16cd65afaaa5e2c914 Author: Russ Allbery Date: Fri Jul 24 13:03:48 2009 -0700 Restore permission documentation in bosserver man page The original IBM HTML documentation had a table showing the permissions that bosserver expects and sets when it creates the directory structure for AFS. That table was accidentally dropped in the conversion to POD. Restore it from the HTML shipped with an older version of OpenAFS. Reviewed-on: http://gerrit.openafs.org/210 Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit 5d8c3f6758ef9927d3e28c6adcb7f6fa792fbb49 Author: Jeffrey Altman Date: Thu Jul 30 10:23:38 2009 -0400 Windows: Version and ChangeLog updates for 1.5.61 1.5.61 == 1.5.6100.0 LICENSE MIT Reviewed-on: http://gerrit.openafs.org/255 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 147aeeb6c59b5f4a9f8a795a91e0c42ecf80278c Author: Marc Dionne Date: Mon Jul 27 09:47:08 2009 -0400 Eliminate some multiple targets in Makefile rules Rules with multiple targets can cause problems with parallel builds. This patch fixes two cases that have caused occasional build errors. Reviewed-on: http://gerrit.openafs.org/257 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 152e9152ff8bef4efac822b5a43b33ba50e8eed5 Author: Andrew Deason Date: Thu Jul 30 13:43:27 2009 -0400 Fix UKERNEL afs_mount arguments Change 73 (commit dc6299f5) changed the order of arguments for the UKERNEL implementation of afs_mount, causing uafs_mount to segfault whenever called. This changes them back to what they were before. Reviewed-on: http://gerrit.openafs.org/256 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 8b86acea67f5e4a2138676edf82c3218b2a74bfd Author: Jeffrey Altman Date: Thu Jul 30 10:00:00 2009 -0400 Windows: Rename README-NT to README-WINDOWS Windows has not been referred to as NT in a long time. We do not support Windows 9x any longer. Rename README-NT to README-WINDOWS. Reviewed-on: http://gerrit.openafs.org/254 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 21e7b0d0c1dab60b0394336ec660d0852fe95536 Author: Jeffrey Altman Date: Thu Jul 30 09:56:33 2009 -0400 Windows: Update the README-NT file Update the README-NT to be more up to date. It still requires a lot of work. Reviewed-on: http://gerrit.openafs.org/253 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit ef7e0d64e7c29675405299f36ee3b7343b31cb35 Author: Andrew Deason Date: Mon Jul 20 12:31:44 2009 -0500 Add additional vlprocs safety checks This adds additional safety checks to the vlserver's implementation of the VL_CreateEntry, VL_ReplaceEntry, and VL_UpdateEntry RPCs. Now in all three of these, any new volume ID that would be added to the VLDB or that would be newly referenced in a VLDB entry is checked against duplication in other entries. Additionally, any new volume names added to the VLDB (either by creation, or modifying an existing volume) are checked against duplication. This should make it impossible for clients to make a volume ID or volume name correspond to multiple volume groups (either conceptually or literally in the vldb). This also alters the vlserver's implementation of the VL_GetNewVolumeId RPC such that the vlserver increments maxvolid until the range of volume IDs [*newvolumeid, *newvolumeid+bumpcount) is unused. 'vos' is modified to only allocate one new volume id at a time, so we don't skip over potentially-usable vol ids. Reviewed-on: http://gerrit.openafs.org/158 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e18216b91fa7171efdf796908ce2e98e7bc42f11 Author: Derrick Brashear Date: Wed Jul 29 22:56:08 2009 -0400 macos 10.6 package naming call the dmg Snowleopard for 10.6. Reviewed-on: http://gerrit.openafs.org/252 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 6bec05a874035b30a1b7d5119a053f550adeba4d Author: Derrick Brashear Date: Wed Jul 29 22:14:01 2009 -0400 macos 10.6 amd64 kmod build fix make the ARCHFLAGS support for amd64 work correctly by grepping for the correct thing Reviewed-on: http://gerrit.openafs.org/250 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 5593ff360c7a8f9f69cebda0cb2e2909ff2f31b4 Author: Derrick Brashear Date: Wed Jul 29 17:23:14 2009 -0400 macos 10.6 pam support Make pam module compile on 10.6. Not tested yet. Reviewed-on: http://gerrit.openafs.org/249 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e2dcd47f352af396e71b815cd2bb557b3180ccc0 Author: Marc Dionne Date: Wed Jul 29 22:35:21 2009 -0400 afs_pag_call.c needs rx/rxstat.h for RXSTATS_ExecuteRequest This fixes a build error introduced by change 247 (commit 967abaf2). Reviewed-on: http://gerrit.openafs.org/251 Reviewed-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 967abaf29b29866174fecc22df85fb4a19ab5833 Author: Simon Wilkinson Date: Wed Jul 29 16:58:03 2009 +0100 Make rxgen emit prototype for ExecuteRequest Make rxgen provide a prototype in its header file for _ExecuteRequest, and remove all of the adhoc prototypes from the tree. Reviewed-on: http://gerrit.openafs.org/247 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear commit 2ade93993a9a82a23f44355065e2b5573acca372 Author: Jeffrey Altman Date: Wed Jul 29 14:31:45 2009 -0400 Windows: test for and react to SMB Extended Session Timeout support SMB Extended Session Timeout Support is available only on Windows systems with specific versions of the mrxsmb.sys driver. Add a test for those driver versions. If a supporting version is present use the extended session timeout value instead of the standard timeout value for the redirector timeout. Adjust the rx hard, conn, and idle timeouts accordingly. The SMB module will define the ExtendedSessTimeout registry value if it does not exist. We rely on the fact that this is done after the rx timeout values are calculated. The mrxsmb driver only reads the value at boot. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/248 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Reviewed-by: Asanka Herath Tested-by: Asanka Herath Reviewed-by: Derrick Brashear commit 7a333523ea5930d666686d5614328d10db4ef9e2 Author: Simon Wilkinson Date: Tue Jul 28 10:32:10 2009 +0100 Fix signed vs unsigned pointers in volser Cast iod_Read returns to (char *) Fix signed vs unsigned pointer argument issues Reviewed-on: http://gerrit.openafs.org/236 Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit 6ae0c53d93f26ddadc37dbf268652b1f8af8b3ec Author: Simon Wilkinson Date: Tue Jul 28 11:09:30 2009 +0100 Code cleanup for vlserver Move the cnvldb.h include so it's after vlserver.h Don't define MAXSERVERS in cnvldb.h (it's already defined elsewhere) Cast nvldbentry(s) to vldbentry to avoid warnings from display_entry Volume IDs are unsigned Use var[0]='\0' rather than sprintf(var, ""); Reviewed-on: http://gerrit.openafs.org/237 Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit 5eae1c8062a8662d172d21a059533e04eef318d2 Author: Simon Wilkinson Date: Tue Jul 28 12:25:08 2009 +0100 Warnings work in util/ Make afs_ctime an inline function, instead of a complex macro. This both improves our type safety, and suppreses warnings about unused results. Add bracing to clarify operator precedence in if (a && b || c) statement AFS_DARwiN60_ENV != AFS_DARWIN60_ENV Use (void) rather than () in function prototypes Reviewed-on: http://gerrit.openafs.org/240 Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit fb96e13d6f93fd7f7d833b4c66753b63a50c9003 Author: Simon Wilkinson Date: Tue Jul 28 12:13:10 2009 +0100 Cleanup for the USS directory Add additional header files for prototypes Add additional prototypes to header files yyerror() is internal, not external. Make it static while we're at it. ANSIfy various function definitions Unsigned vs signed cleanup Reviewed-on: http://gerrit.openafs.org/239 Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit 6640b8b064b238333a46ef72aa09913b06271a91 Author: Derrick Brashear Date: Tue Jul 28 12:13:24 2009 -0400 install AFSCommander in prefpane dir make the AFSCommander prefPane be installed, in /Library (as are growl, macfuse, etc) Reviewed-on: http://gerrit.openafs.org/243 Tested-by: Derrick Brashear Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear commit 4dadd24ba8ce72fd655e29d74801f27e9e148b01 Author: Jeffrey Altman Date: Mon Jul 27 12:54:16 2009 -0400 Protect rx_call iovq from simultaneous attempts to empty it The iovq queue is not safe to clear without holding the call lock. FIXES 125110 LICENSE BSD Reviewed-on: http://gerrit.openafs.org/242 Reviewed-by: Derrick Brashear Tested-by: Hans-Werner Paulsen Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit e6d321fcd4cbf0fdc6b153c0894f8d4c222093ad Author: Simon Wilkinson Date: Tue Jul 28 11:55:47 2009 +0100 Use an anonymous pointer for lpioctl The block passed to lpioctl as cmarg is an anonymous chunk of memory, so use a type that represents it as such. Reviewed-on: http://gerrit.openafs.org/238 Tested-by: Marc Dionne Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c861bb0d779b54236b63eda87d9dfaf7792d1659 Author: Simon Wilkinson Date: Tue Jul 28 12:55:36 2009 +0100 Additional UKERNEL headers, prototyping and other fixes Add additonal headers to include prototypes for UKERNEL builds Add some more prototypes Remove some unused variables Reviewed-on: http://gerrit.openafs.org/241 Reviewed-by: Derrick Brashear Tested-by: Marc Dionne commit 02f083730750a03e60eb412a1aed1f03d3c62a49 Author: Simon Wilkinson Date: Mon Jul 27 22:32:01 2009 +0100 More warnings cleanup for vol/ Prototype a number of functions Add additional includes as required Make some existing prototypes match the actual declarations Volume IDs are unsigned in most of the code, change this bit to match Make various Procs take an anonymous pointer, so they can be type checked Add vol_internal.h for prototypes internal to this package Reviewed-on: http://gerrit.openafs.org/235 Tested-by: Marc Dionne Reviewed-by: Derrick Brashear commit 479ce49e9ceb3ad7ea3dd2282759689a7ab43f4c Author: Simon Wilkinson Date: Sun Jul 26 19:41:30 2009 +0100 Further warning cleanup for the libadmin directory More code cleanup for libadmin, including additional header inclusion, better prototyping, and signed/unsigned and const fixes Reviewed-on: http://gerrit.openafs.org/228 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 4c2e426d2dad559e1ed2c2c43d48193400b22c61 Author: Simon Wilkinson Date: Sun Jul 26 19:23:08 2009 +0100 Move end label into correct position The end label was in the wrong #ifdef block in order to actually be referenced in the case where USEIFADDR is unset Reviewed-on: http://gerrit.openafs.org/226 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit d48b1e83bfb5ab483877df0ff633049a9b0bbce1 Author: Simon Wilkinson Date: Sun Jul 26 19:34:48 2009 +0100 Additional prototyping in dir.h Add prototypes for functions used by the file and volservers Reviewed-on: http://gerrit.openafs.org/227 Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 581ec9f06a8958637db33d14f8d0e24d841d5eff Author: Marc Dionne Date: Mon Jul 27 11:29:34 2009 -0400 Eliminate some "implicit function declaration" warnings Include appropriate header files to eliminate some warnings for implicit function declarations. These are simple cases that don't generate new warnings because of the prototypes. Use grp.h if it exists to get setgroups() definition. Reviewed-on: http://gerrit.openafs.org/233 Tested-by: Simon Wilkinson Reviewed-by: Simon Wilkinson Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 1ddc7fa920213f9b5455e632bbddf05b866af647 Author: Adam Megacz Date: Sun Jul 26 20:32:07 2009 -0700 In rxi_SendPacket[List], down hosts if ENETUNREACH or equivalent This patch causes rxi_SendPacket[List] to "down" a host if rxi_Sendmsg() returns -ENETUNREACH (or equivalent). Previous behavior only did this check if defined(KERNEL) becauase non-defined(KERNEL) implementations did not return meaningful error codes from rxi_Sendmsg(). Jeff Altman supplied the logic for the AFS_NT40_ENV case; I was not able to test this (I do not own a Windows license) and took him on his word. Reviewed-on: http://gerrit.openafs.org/59 Reviewed-by: Adam Megacz Tested-by: Adam Megacz Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit d82e9c851c4d8ad765a0a81b9d5f290d184b7b07 Author: Marc Dionne Date: Sun Jul 26 22:28:29 2009 -0400 Unused variable cleanup Eliminate some warnings for unused variables. In most cases the variables are not used at all and are removed; in a few cases the declarations need to be ifdef'ed to follow the code that uses them. For a typical build here this removes 24 warnings. Reviewed-on: http://gerrit.openafs.org/232 Reviewed-by: Jeffrey Altman Tested-by: Simon Wilkinson Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear commit 38a641bd6b41fe37a8be1614578efa9cb8b6da53 Author: Jason Edgecombe Date: Sun Jul 26 21:26:59 2009 -0400 Future-proof the wording of the auditlog options in the man pages It was suggested that the auditlog option should not say there is one record per RPC. In the future, there might be a need for multiple records per RPC. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/229 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 9a490c96a074f4c3c82a3f01c18bc74cc19ae184 Author: Marc Dionne Date: Sun Jul 26 21:45:33 2009 -0400 Build fix - pre-processor typos in rx_lwp.c and rx_pthread.c Commit 119c756d96c4a7f9e01e4ff6bb20156f1abf761b introduced a typo in two places, using #elif instead of the apparently intended #else. Reviewed-on: http://gerrit.openafs.org/231 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 119c756d96c4a7f9e01e4ff6bb20156f1abf761b Author: Adam Megacz Date: Sun Jul 19 11:00:41 2009 -0700 Use -errno or WSAGetLastError() as return value from rxi_Sendmsg() This patch causes the pthread and lwp implementations of rxi_Sendmsg() to use -errno or WSAGetLastError() as the return value if it is positive. This is required in order to communicate more meaningful error conditions to rxi_SendPacket[List], which should "down" a host immediately when it observes ENETUNREACH. Jeff Altman supplied the logic for the AFS_NT40_ENV case; I was not able to test this (I do not own a Windows license) and took him on his word. Reviewed-on: http://gerrit.openafs.org/58 Tested-by: Derrick Brashear Reviewed-by: Adam Megacz Tested-by: Adam Megacz Reviewed-by: Derrick Brashear commit 20687eecd09cdcf46274979d744de8708e6567b3 Author: Jeffrey Altman Date: Sun Jul 26 13:03:49 2009 -0400 Windows: Add buf_FindAll() and buf_FindAllLocked() Add two new buffer search functions buf_FindAll and buf_FindAllLocked. Similar to buf_Find and buf_FindLocked except they search the all buffer list. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/225 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 5d80dbe42622f17f881e7f53a798a5c1fd0e735b Author: Jeffrey Altman Date: Sun Jul 26 12:57:10 2009 -0400 Windows: Add cm_GetVolumeType Add new volume utility function cm_GetVolumeType which returns the type of volume based upon provided volume group and volume id. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/224 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit cdbd09abf1590c5b84d8238e3cf4096919e3446f Author: Jeffrey Altman Date: Sun Jul 26 12:20:26 2009 -0400 Windows: Add cm_req_t parameter to cm_MergeStatus cm_MergeStatus allocates its own local cm_req_t object even though all of its callers already have an active cm_req_t object available. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/223 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit f5c25235008a446449f1220f76fa5037bdceb637 Author: Jeffrey Altman Date: Sun Jul 26 11:54:27 2009 -0400 Windows: Add cm_req_t parameter to buf_Get* functions The buf_Get* functions do not currently accept a cm_req_t parameter. As a result they allocate their own cm_req_t on the stack even though all callers already have one that can be used. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/222 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 3781ef99e379cb47cb33e86d555d8cfd495dcf9d Author: Jeffrey Altman Date: Sun Jul 26 11:48:37 2009 -0400 Windows: Add enhanced audit log to afsauthent.dll Add the enhanced audit log support to afsauthent.dll. Reviewed-on: http://gerrit.openafs.org/221 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman commit 96c746c75260a3cf6dc58fcf692b44f83ef65a95 Author: Jeffrey Altman Date: Sun Jul 26 11:01:43 2009 -0400 Permit enhanced audit logs to work on Windows Gerrit 82 / Git 7b0b6a0ce9b320a3145f9d600596946230d815f0 broke the Windows build. Add audit-file.obj to file list in NTMakefile. Remove unnecessary includes from audit.c. Properly conditionalize includes in audit-file.c. Reviewed-on: http://gerrit.openafs.org/219 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 777a4a9be8f909648d05d6644624e822aeca8423 Author: Asanka Herath Date: Sun Jul 26 10:16:33 2009 -0400 Windows: Tests for afsd modules Add test routines for internationalization routines. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/218 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit e3b7fa7a1ebacee6a7bf0d15d34d382d22ba3d26 Author: Jason Edgecombe Date: Sat Jul 25 13:37:08 2009 -0400 Expanded the -auditlog entries in the man pages of the server processes The expanded auditlog explanation includes what information is recorded in the auditlog. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/213 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit bb981b953f34fc0e63a0a09020c57329dd44ac98 Author: matt@linuxbox.com Date: Wed Jul 22 15:43:22 2009 -0400 Portable lock-free data structures by Keir Fraser (MCAS) The MCAS suite, previously released as lock-free library, under a non-restrictive license. This software includes software previously released in 2003 under a GPL license, but released by the original copyright holder, Keir Fraser, under a BSD license, on 5/28/2008. Reviewed-on: http://gerrit.openafs.org/183 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 55b8a4d35eb5913ebdc9e5ce8c1f1db525c55ff1 Author: Russ Allbery Date: Fri Jul 24 13:38:09 2009 -0700 Document human-readable size suffixes Document that the quotas passed to fs setquota, vos create, and vos setfields and the size passed to fs setcachesize may take a suffix indicating the unit. This documents the change in behavior implemented by 54c0a3f3e6575fa5af39ddd797d5381c36b48001. Fix a copy/paste error in the vos create -maxquota option definition. Reviewed-on: http://gerrit.openafs.org/212 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 7b0b6a0ce9b320a3145f9d600596946230d815f0 Author: Andrew Deason Date: Wed Jun 24 17:46:27 2009 -0400 Enhance audit logs to support SysV message queues Adds support for sysv message queues for fileserver audit logs. This also organizes the audit log code into various 'interfaces', of which there are two: the original 'file' interface, and the 'sysvmq' interface that this adds. The interface is configurable at runtime with the -audit-interface switch. FIXES 124674 Reviewed-on: http://gerrit.openafs.org/82 Tested-by: Andrew Deason Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 29a5ddf1ddc05dd1ea826220a424f4f6650cc0c7 Author: Andrew Deason Date: Mon Jul 6 10:29:20 2009 -0500 Allow specifying vos create/addsite volume IDs This adds the -id option to 'vos create', and the -roid option to 'vos create' and 'vos addsite'. This allows the user to manually specify the volume IDs that a new RW or RO volume will get (or explicitly specify that an RO volume ID should be unset), instead of always relying on the volume IDs retrieved from the vlserver. Reviewed-on: http://gerrit.openafs.org/157 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e435e248f44c46866cb73db185b9548c0bd148b4 Author: Jeffrey Altman Date: Fri Jul 24 12:58:26 2009 -0400 Running bos -noauth should not require client CellServDB configuration When setting up a new cell, the admin is instructed to use "bos -noauth" to configure the servers and only afterwards create the client configuration. This leads to a catch-22 since currently bos -noauth fails if there is no client configuration even though it is not required. This change avoids the call to afsconf_Open() which is only required if tokens are being acquired. FIXES 125156 Reviewed-on: http://gerrit.openafs.org/209 Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit a6025e0268fd7cff6ee7de145bdbf59cc350c572 Author: Derrick Brashear Date: Fri Jul 24 00:44:31 2009 -0400 afsprefs pane shouldn't hardcode 10.4 sdk 10.4 sdk isn't available in the release after 10.5 as a default. don't hardcode it same with afscell Reviewed-on: http://gerrit.openafs.org/207 Tested-by: Simon Wilkinson Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit ed74213df6449aba8ec58250f912fbc526a3cb56 Author: Jeffrey Altman Date: Thu Jul 23 22:23:13 2009 -0400 Windows: Move src/NTMakefile to top-level in order to avoid copying For some unknown reason the Windows top-level NTMakefile is stored at src/NTMakefile and must be copied to the top-level before it can be used. Now that git permits easy file moves, relocate src/NTMakefile to where it belongs. Reviewed-on: http://gerrit.openafs.org/206 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit f914b42d26305ba5af3efb4aeee9f74244150376 Author: Simon Wilkinson Date: Thu Jul 23 20:33:36 2009 +0100 Make buildpkg work out of tree Don't reference files in the local directory, so that buildpkg.sh can be invoked from elsewhere Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/202 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 1ea9c02f8ec985605a52bde331de5c848a7a5d56 Author: Toby Blake Date: Thu Jul 23 20:18:28 2009 +0100 Finish afscell implementation work This patch completes the implementation of an install time prompeter for information about the local AFS cell, which is then used to populate the ThisCell file. It removes the need for manual editing of configuration files as part of the installation. (Build system modified by Simon Wilkinson from Toby's original patch) Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/201 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit adddef8d1464cdf5ef07e9ee5e0b8a09f9ce8805 Author: Derrick Brashear Date: Thu Jul 23 15:42:14 2009 -0400 correct macos 10.6 amd64 support add a missing space so the kernel module can link Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/203 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b4564fa8254afbfef94915f1051a5ad7ab17b11d Author: Simon Wilkinson Date: Thu Jul 23 19:27:47 2009 +0100 Move afscell to platform/DARWIN Move our current afscell code into platform/DARWIN so that it's in a location that can be added to the build, rather than packaging, step Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/200 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c24c251966f218bcf9c0bd13718ef00ca4d12e80 Author: Marc Dionne Date: Thu Jul 23 16:52:46 2009 -0400 Fix build error - libafsrpc.map syntax Fix a build error introduced by commit 3a6d18: /usr/bin/ld:./libafsrpc.map:125: syntax error in VERSION script There seems to be a missing semicolon with the new rx_GetLocalPeers entry. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/205 Reviewed-by: Jacob Thebault-Spieker Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 8af5762909714367c1cc764b3f491c06c2bcd5d0 Author: Russ Allbery Date: Sat Jul 18 11:38:22 2009 -0700 Clean up some obsolete Autoconf code Remove hand-crafted equivalents of AC_SEARCH_LIBS for socket, connect, and gethostbyname functions. The only effective difference between this code and AC_SEARCH_LIBS was to define the HAVE_* macros for the functions, which are not used anywhere in the tree. Remove AC_FUNC_SETVBUF_REVERSED. This call no longer does anything in current versions of Autoconf since the last system with this problem was based on SVR2 and became obsolete in 1987. Remove the one place in the source tree where the results are used. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/154 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit ab27eb24afce7a467a2e0da8dc3eafab08ed4c14 Author: Jeffrey Altman Date: Thu Jul 23 15:43:55 2009 -0400 Windows: rename compile_et.pod to afs_compile_et.pod Gerrit 175 renamed compile_et and compile_et.pod to afs_compile_et*. Fix the Windows build system to process the new pod file name and modify the WiX installer scripts to install afs_compile_et.html. FIXES 125152 LICENSE MIT Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/204 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 6bb7bad9fc258c482d2f5786f2b03e90ccb54ad2 Author: Simon Wilkinson Date: Tue Jul 21 20:53:57 2009 +0100 Further code cleanup for the backup suite Protect butm.h against multiple inclusion Prototype more functions for internal use in bucoord Remove some unused variables Include additional headers as required Prototype exported functions in budb Make SendReturnList helper function generic, by using a void * rock Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/168 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear commit 0e6a776e0e73b532d0d22ddeef20c868b95f8aed Author: Simon Wilkinson Date: Thu Jul 23 18:44:42 2009 +0100 Remove duplicate copy of afssettings.m afssettings.m lives in src/platform/DARWIN. Remove the duplicate copy from this directory, and the (now unnecessary) Makefile. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/199 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c321cb467220bbdf2ff49d5fa6e052fd27a4df5e Author: Simon Wilkinson Date: Wed Jul 22 01:11:15 2009 +0100 Rename installed version of compile_et Rename the installed version of compile_et to afs_compile_et to avoid conflicts with other, more standard, users of com_err. Also rename the man page to match Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/175 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 43ec8a64eb066774ee29136269e77dc0db1ff01d Author: Matt Benjamin Date: Tue Jul 21 17:07:36 2009 -0400 Refactor OpenBSD param files into common and architecture-specific sections. The new structure follows the pattern of the NetBSD param files, as suggested by Derrick. Since the change is retroactive, it seems reasonable to also make the retroactive change to add the amd64 param files, back to OpenBSD 3.6. OpenBSD 3.6 added SMP support for x86_64, so the architecture was a mature subtarget at that point. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/177 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 5cce838a2454927c3fea8ad6defadf1f2ce4833f Author: Russ Allbery Date: Tue Jul 21 11:04:41 2009 -0700 Fix warnings in vlserver/vlprocs.c rxinfo's code to print out the principal corresponding to an rx_call uses static arrays for the principal components but was checking that the array pointer was non-NULL when deciding whether to print principal components. Instead check whether each portion of the principal is the empty string. Add explicit initializations of the static buffers to the empty string so that we're not relying on rxkad_GetServerInfo always initializing them for us. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/163 Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit ccb3e316868f381831d9ddda530af83102f67697 Author: Jeffrey Altman Date: Wed Jul 15 03:58:02 2009 -0400 Modify Solaris Rx NetIfPoller to avoid Panic This patch changes the common error reporting type from CE_PANIC to CE_WARN and adds appropriate cleanup processing so that we do not leak resources if an error occurs. LICENSE MIT FIXES 124498 Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/97 Reviewed-by: Russ Allbery Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e8a2833996e783f4ebd051ae87dbd301948689b0 Author: Simon Wilkinson Date: Wed Jul 22 22:07:32 2009 +0100 Squish more warnings in xstat Use a correct prototype for a_ProbeHandler in xstat_cm_Init Fix a printf warning rx_getAllAddr and afs_cb_interface.addr disagree on the sign of addresses afs_interface.addr is a [], which we then use & to get the address of. Fix this to stop the compiler from sulking. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/184 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear commit c9f313ba6a26a0a21632b439e690efefc4e7c260 Author: Simon Wilkinson Date: Wed Jul 22 22:40:13 2009 +0100 Do not call principal_ntoh to copy ktc_principal structs principal_ntoh() is designed for butc_principal structures, which are a different size from ktc_principal structures, and so it can't be used to copy them. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/185 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman Reviewed-by: Derrick Brashear commit 889907ebd1f6bac883d116d2754b1cb599fec23c Author: Derrick Brashear Date: Thu Jul 23 11:46:50 2009 -0400 platform makefile should handle clean target pass "make clean" through to platform-specific makefiles Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/198 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f1bb016e12a1f4bb3b9b01d5a9abe4f8c8dabe32 Author: Claudio Bisegni Date: Thu Jul 23 16:40:39 2009 +0200 Makefile.in modification for compile AFSPreference source code Have been added the rule "OpenAFS.prefPane" tha compile with xcodebuild the xcode project Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/197 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 694c5ca3f400ce88219f60edec75249bf73cc8fc Author: Claudio Bisegni Date: Sat Jul 11 00:18:56 2009 +0200 OSX Preference Pane Source Import Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/196 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 3a6d185d400d88607c28514f7b2ba5c0361c91b3 Author: Jacob Thebault-Spieker Date: Wed Jul 22 17:56:32 2009 -0400 Expose locally collected rx peer statistics This implements rx_GetLocalPeers(), which exposes peer statistics that are currently collected to the cache manager. This function will later be used to rank both the file server and vldb server lists using the statistics exposed by rx_GetLocalPeers(). Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/186 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 2675642e024f56a3069414d1f96ee440c9cb0c77 Author: Claudio Bisegni Date: Sat Jul 11 00:18:04 2009 +0200 OSX Preference Pane Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/195 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 706b299e1e5bb7658c1a9a26eae4e277027ce731 Author: Mickey Lane Date: Thu Jul 23 09:20:27 2009 -0400 Update Windows strcmpi call This POSIX function is deprecated beginning in Visual C++ 2005 Change to _stricmp instead This change affects 4 calls in 3 Windows only files. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/188 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 77b661c6a07346117896f9de4547976e54e02573 Author: Jeffrey Altman Date: Thu Jul 23 10:12:02 2009 -0400 Windows: Fix cm_UpdateVolumeStatusInt log message In the server "down" case, the log message reported "online". Fix that to avoid confusion while debugging. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/194 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit f26ff22c2a4cd93e07c141ec3be85094251e3f6b Author: Mickey Lane Date: Wed Jul 22 14:55:02 2009 -0400 Remove 8.3 dir requirement for Windows IDN path This adds double quotes around the IDNMRedistDir symbol in ..\wix\NTMakefile so that the 8.3 alternate directory name is no longer required. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/182 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 22996dc4d6d22b0b811ef5e0ae5bff8441629a6d Author: Russ Allbery Date: Wed Jul 22 07:00:10 2009 -0700 Remove conditional on LINUX/osi_pag_module.c osi_pag_module.c should not be built conditionally based on whether the NFS translator is enabled. This file is used by afspag.ko, which is run on NFS translator clients, not servers, and should not have GPL symbol problems. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/179 Reviewed-by: Derrick Brashear Tested-by: Marc Dionne Reviewed-by: Marc Dionne commit 69cf150be870f4b4f9d10b7d0b0aa780054c6958 Author: Felix Frank Date: Thu Jul 2 08:55:47 2009 +0200 Unite CacheStoreProcs and add abstraction calls. The cache type specific differencies among afs_MemCacheStoreProc and afs_UFSCacheStoreProc are divided into two sets of "storeOps". Upon rxfs_storeInit, the appropriate set is chosen. FIXME: Simon suggests that there should be a single set of storeOps, as the main difference lies in what rx_ calls must be made. This decision would then be made by calling a wrapper function from each storeOp. These wrappers should be cachetype-specific and protocol- independent. They would be associated to struct afs_cacheOps. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/107 Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit 789c3451ba000f7c9665742890b305e2e7938add Author: Simon Wilkinson Date: Tue Jul 21 20:58:36 2009 +0100 Fix warnings in comerr directory Prototype yylex in error_table.y to remove warning Fix the bizarre definition of LOCK_ET_LIST so that it upsets neither the compiler, nor the reader. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/169 Reviewed-by: Jeffrey Altman Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit 09c4b3006d81eeb52b89d870ee7568de455040ea Author: Simon Wilkinson Date: Tue Jul 21 20:16:51 2009 +0100 Further prototyping and cleanup of UKERNEL This patch continues to reduce the number of warnings that come from a UKERNEL build. It also replaces the use of a system provided suser() call (which isn't available everywhere), with afs_suser that's provided by UKERNEL. Note that this makes UKERNEL applications usable by everyone, not just root. fork_syscall() becomes a normal function call_syscall() is ANSIfied UKERNEL/osi_groups.c gets the includes it needs UKERNEL/osi_machdep.c stops thinking it's on Solaris UKERNEL/osi_vnodeops.c stops confusing vnodes and vcaches Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/166 Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit fc695707f87143f2bfefd1260560cd6fdef613c0 Author: Hans-Werner Paulsen Date: Mon Jul 20 12:06:23 2009 +0200 Use Posix regex(3) within src/bucoord/commands.c Normally pattern matching against volume names is done on the server, but if this fails, the client (src/bucoord/commands.c) is doing this. This program had no code to use regex(3) when HAVE_POSIX_REGEX is defined. This patch adds calls to regex(3) if HAVE_POSIX_REGEX is defined. For systems without POSIX regex there were two (slightly different) implementations in src/bucoord/regex.c and src/util/regex.c. The newer version src/bucoord/regex.c has been modified and moved to src/util/regex.c. Some header files and Makefiles have been removed/updated to work with this setup. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/99 Tested-by: Russ Allbery Reviewed-by: Russ Allbery Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 05ee0932fa3d56193b9cbd235c5faa33fe02876d Author: Marc Dionne Date: Tue Jul 21 18:16:45 2009 -0400 Build fixes: prevent unnecessary rebuilding Fixes to a few Makefiles to prevent needless rebuilding when using make after a successful build. Rework dependencies in src/bubasics to prevent needless rebuilding and fix some remaining parallel build issues. Multiple targets really have to be avoided. Remove dependency on the include/afs directory from the src/config Makefile. Depending on a directory means that we will rebuild the target if the timestamp changes, for instance if other files or sub-directories are installed. This caused param.h to get re-installed in some cases and the kernel module source files to be recompiled. This directory is created in the top-level Makefile anyway so we shouldn't need an explicit dependency. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/171 Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit e35dfdcce9d11607669783844331ad2dbafd2793 Author: Hans-Werner Paulsen Date: Wed Jul 22 15:14:33 2009 +0200 avoid call to rxi_FreePacket with NULL pointer the function rx_ReadProc32 (src/rx/rx_rdwr.c) checks the pointer call->currentPacket before the function rxi_FreePacket is called. This test was missing in the function rx_ReadProc. FIXES 125110 Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/178 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 322a7a854b348e68b0bc49f5ad37049af188518f Author: Derrick Brashear Date: Tue Jul 21 17:09:39 2009 -0400 OSX lock initialization cleanup Move GLOCK creation before other things at modload time. Also remove unused rwlock support from rx kmutex package. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/170 Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit dbdd3190a75ce634c2e13d2e2141c564af379519 Author: Matt Benjamin Date: Sat Jul 18 09:29:20 2009 -0400 Add amd64 subtarget for OpenBSD The subtarget name is amd64_obsd. A sysname is created for the OpenBSD 4.5 release, since it's current. The sysname id range starting at 4000 is claimed for amd64_obsd, with amd64_obsd45 at 4014, so that prior releases can be added in the correct order, if needed. Mention of Jim Rees and CITI in new param file changed to line crediting them for original work. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/153 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit ba27f1b3cb08db66e184682b30d60ff6fc4ce43e Author: Derrick Brashear Date: Tue Jul 21 13:14:57 2009 -0400 AFSOP_STOP_RXEVENT sometimes set without wakeup make sure when AFSOP_STOP_RXEVENT is set, a wakeup is sent on the variable so waiters realize it's the case Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/162 Reviewed-by: Simon Wilkinson Tested-by: Simon Wilkinson Reviewed-by: Russ Allbery commit f149a3c54b0c0c3503556722e9b7f9d8f0b793b8 Author: Andrew Deason Date: Wed Jul 15 09:54:32 2009 -0500 Correct ctime arguments Corrects a few places throughout the tree where ctime() is incorrectly passed a pointer to an afs_uint32 or similar fixed-width datatype, instead of a pointer to a time_t. FIXES 124538 Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/100 Tested-by: Andrew Deason Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit 262be76294c1c1b2cfdb5e3d77118b6aae5ed430 Author: Simon Wilkinson Date: Tue Jul 21 11:58:47 2009 +0100 Make DRelease take an anonymous pointer DRelease is used to free data blocks returned by the dir package. These can be any of a number of different types, which we were previously dealing with by casting everything to (struct buffer *) before calling DRelease. Instead, make DRelease take a (void *), so we can free any dir package product without requiring casts. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/159 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit f56ca81fbf4abc8d7d1e6e7c5b7c37080cb37b9e Author: Simon Wilkinson Date: Tue Jul 21 14:06:36 2009 +0100 Clarify the proscription of $< Clarify the situations in which $< can be used, as we do use it in some places in the tree. It is sufficiently portable in pattern rules, but should not be used elsewhere Also, change the function definition example to match the format used through out the source tree. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/160 Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 7ee55ba59f39587591b4e3af0702889a24d5e118 Author: Derrick Brashear Date: Mon Jul 20 09:40:26 2009 -0400 fix init script install rules for linux and darwin the mode needs to be provided before src dest; do so, so we get boot scripts again Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/156 Reviewed-by: Simon Wilkinson Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit 5bc9641620d8e1c56a4af6857cb4c79109c79194 Author: Felix Frank Date: Mon Jul 20 11:50:06 2009 +0200 Fixed out-of-tree builds. The problems were * wrong location of Makefile.version-CML * lots of omissions of "$?" in favor of actual file names in Makefiles * wrong dependencies in pam/Makefile.in The latter now point to TOP_INCDIR. Still, ktc.c could not be built from src/pam (buildtree), as include "..." would not work on generated headers. Therefore, it uses include <...> where appropriate now. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/155 Tested-by: Simon Wilkinson Reviewed-by: Simon Wilkinson Tested-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b4783c245d233a0883a29241351869d616a9f6a4 Author: Marc Dionne Date: Sat Jul 18 00:15:01 2009 -0400 Warning cleanups for kernel module build Take care of various warnings (about 70) during a libafs build. A non-exhaustive list of changes: - Unused variables, in some cases to be IFDEFed along with the code that uses it - Cast some const char * to char * for the afs_* functions - Move afs_UFSCacheFetchProc and afs_UFSCacheStoreProc declarations to afs_prototypes.h - Include afsutil.h in error_msg.c to get strlcpy - Change type of argument 3 in export_sysname, to match what the callers are actually doing - Rework a few lines in pthread_glock.c to avoid a warning about unused value - Fix a warning in rpc_scan.c that really looks like a bug (but probably harmless in our case) Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/151 Reviewed-by: Russ Allbery Tested-by: Russ Allbery commit f6e46babd8e3a0d51d31ae381748516330f5b84d Author: Michael Meffie Date: Fri Jul 17 11:06:34 2009 -0400 Build on linux 2.4 again Add missing conditional to fix building on linux 2.4. FIXES 125120 Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/148 Tested-by: Simon Wilkinson Reviewed-by: Simon Wilkinson Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit 2797f8380a700eee870fbd3a5fb08a2cb4ea1deb Author: Jeffrey Altman Date: Sat Jul 18 03:46:21 2009 -0400 Correct ifdefs in rx.c for rx packet debugging Reported by Marc Dionne Fix two sets of ifdefs in rx.c required for RXPACKET_DEBUG. LICENSE BSD Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/152 Tested-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 25eb69a32aac30f50a33432664c287984f24162c Author: Marc Dionne Date: Fri Jul 17 21:29:10 2009 -0400 Disable kdump build on linux 2.6 Don't try to build kdump on linux 2.6 where it has been known to be broken for a long time. The build failure was ignored, but produced a large number of errors and warnings, polluting the build log. On a test amd64_linux26 system with a recent kernel and --enable-warnings, this results in over 750 fewer warnings and 100+ fewer errors. Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/150 Tested-by: Russ Allbery Reviewed-by: Russ Allbery commit 0b3e7a074789dccf4738364e24f20656d3f06729 Author: Felix Frank Date: Wed Jul 1 13:20:14 2009 +0200 Gathered alternative afs_TttCacheFetchProcs and afs_TttCacheStoreProcs Fetch and Store procs now live in the new source file afs_fetchstore.c Reviewed-on: http://gerrit.openafs.org/106 Reviewed-by: Russ Allbery Verified-by: Russ Allbery commit 07692c44d39e3c11347ce7428730342ea9c6f53c Author: Derrick Brashear Date: Thu Jul 16 14:59:09 2009 -0400 fstrace needs -lnsl on Solaris in order for gethostbyname to be satisfied for util.a, -lnsl is needed Reviewed-on: http://gerrit.openafs.org/146 Reviewed-by: Derrick Brashear Verified-by: Derrick Brashear Reviewed-by: Russ Allbery commit 2cf12c43c6a5822212f1d4e42dca7c059a1a9000 Author: Simon Wilkinson Date: Tue Jul 14 00:01:09 2009 +0100 Use AFS_PTR_FMT to format pointers Replace "0x%x" with "%"AFS_FMT_PTR for pointer printing in all locations where gcc flags a warning. This change is warnings reduction driven - there are many more occurences of this in the code which don't currently result in compiler warnings, because the va_args functions they're used in aren't defined as printflike. Reviewed-on: http://gerrit.openafs.org/75 Verified-by: Russ Allbery Reviewed-by: Russ Allbery Reviewed-by: Derrick Brashear Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 0c7bb45c91cee0d47fa0263831f7d22889153a36 Author: Simon Wilkinson Date: Fri Jul 10 16:13:09 2009 +0100 Make afs_warn() and afs_warnuser() va_args The afs_warn() and afs_warnuser() functions take a variable number of arguments. Historically, we've handled this by just not prototyping them. This change builds on the work done a while back to get a prototyped osi_Panic() working in the kernel, and contains the same work arounds for platforms with no usable va_args support (HPUX) and those where support is limited (some Darwin, some Linux) Reviewed-on: http://gerrit.openafs.org/27 Reviewed-by: Russ Allbery Verified-by: Russ Allbery Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 54b13240943e1a4f244d412892d0d266def42a5e Author: Russ Allbery Date: Wed Jul 15 00:47:09 2009 -0700 Demystify catopen return value in fstrace For some reason, the code was, on all platforms other than Digital UNIX, assigning the return value of catopen to an integer, with and then immediately assigning it to an nl_catd (the actual return value type). Remove all of that and store the return value directly in an nl_catd variable. Reviewed-on: http://gerrit.openafs.org/93 Reviewed-by: Simon Wilkinson Verified-by: Simon Wilkinson Reviewed-by: Derrick Brashear commit 0e3036e4d13dd3f055c9a2d9406e5953587b25f6 Author: Russ Allbery Date: Wed Jul 15 00:06:09 2009 -0700 Simplify fstrace message catalog and support non-dest installation fstrace was searching for its message catalog first through the normal NLS message catalog search paths and then falling back on the client configuration directory. This, however, is neither a traditional message catalog for internationalization nor is it a configuration file. Instead, search for the message catalog only in a C directory under AFSDIR_CLIENT_DATA_DIRPATH, which is for architecture-independent data, and simplify the code. Now that we have a standard location for the message catalog, install it with make install as well as make dest. Reviewed-on: http://gerrit.openafs.org/92 Verified-by: Simon Wilkinson Reviewed-by: Derrick Brashear commit 5b224f299e27e7708feb9372e362fd74f9441d01 Author: Hartmut Reuter Date: Thu Jul 16 10:33:57 2009 +0200 Remove misplaced lines The same lines appears 17 lines up. So it is already done. But here we shouldn't do it again after having released the write lock in tdc and tdc itself Reviewed-on: http://gerrit.openafs.org/79 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 79f00021ce2d7049e0c69815ab4599a9161145e6 Author: Russ Allbery Date: Tue Jul 14 23:22:00 2009 -0700 Provide an AFSDIR_DATA_DIR path for architecture-independent data Add AFSDIR_DATA_DIR to dirpath.h, defined to be the location for installing and finding architecture-independent data files. Add a corresponding AFSDIR_CLIENT_DATA_DIRPATH macro that retrieves the possibly-prefixed version of this path. This will be ${datadir}/openafs with normal UNIX installation paths and /usr/vice/etc for Transarc paths. Since there is no apparent need for this path on Windows, it is not defined in Windows builds. The only intended use for this path for right now is the message catalog for fstrace. Reviewed-on: http://gerrit.openafs.org/91 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 868ddef206e7c764427cf4abb91e1e69326a2198 Author: Jeffrey Altman Date: Thu Jul 16 11:53:52 2009 -0400 Do not print volume name in DisplayFormat2 if status is not VOK DisplayFormat2 is used to generate volume output for ListVolumes and ExamineVolume. If the volume status is not VOK, the name field will not have been populated with valid data. Do not print it. This commit also removes an extraneous switch block from XDisplayFormat2. The switch variable is already known to have the value VOK due to an enclosing conditional. FIXES 125111 LICENSE MIT Reviewed-on: http://gerrit.openafs.org/140 Reviewed-by: Derrick Brashear Verified-by: Derrick Brashear commit a2d3f60222b29988f78b42608088d4db3da95d9d Author: Simon Wilkinson Date: Mon Jul 13 23:00:44 2009 +0100 Make UAFS builds stop the main build The sub-make invocations in libuafs ignored the return code of the make, which allowed the libuafs build to appear to succeed even if files had failed to build. Fix this. Reviewed-on: http://gerrit.openafs.org/74 Verified-by: Russ Allbery Reviewed-by: Russ Allbery Reviewed-by: Derrick Brashear commit 1d1ae6195bd03c4348a57914cf892e06b507d855 Author: Derrick Brashear Date: Wed Jul 15 14:57:56 2009 -0400 MacOS 10.6 support update Make things build on MacOS 10.6 again. Don't break 10.5 build. Fix an error in the MacOS port which was left from previous head. Reviewed-on: http://gerrit.openafs.org/96 Verified-by: Derrick Brashear Reviewed-by: Russ Allbery Reviewed-by: Derrick Brashear commit 7cd67334333f9b25c5cdf5f0169809948db8896a Author: Jeffrey Altman Date: Thu Jul 16 01:54:56 2009 -0400 Correct build rules for NSIS in top-level NTMakefile NSIS.i386 build rule must build the NSIS directory, not the NSIS.i386 directory. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/105 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 280861970ec2b714d1f2d651541a9552f92a32e4 Author: Russ Allbery Date: Tue Jul 14 22:52:35 2009 -0700 Remove NLS message catalog implementation for pre-2.0 OSF fstrace had its own copy of the NLS catopen/catgets/catclose library functions only on OSF platforms prior to 2.0 with the functions renamed to add a "1" (which looked cut and pasted from somewhere else). This is old enough that we no longer support that platform, so drop all of that code and partly untangle the #ifdefs to remove the pre-2.0 OSF case. Reviewed-on: http://gerrit.openafs.org/88 Reviewed-by: Derrick Brashear Verified-by: Simon Wilkinson commit 86b0f09bddeded9515f39ad17b47a0b4e23a968b Author: Jeffrey Altman Date: Wed Jul 15 11:26:12 2009 -0400 vos print_addr() must call ubik_VL_GetAddrsU with correct level of indirection Reported by Marcus Watts. print_addr() accepts a afsUUID* and must not pass the address of that variable to ubik_VL_GetAddrsU. LICENSE IPL10 Reviewed-on: http://gerrit.openafs.org/101 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 6d9617981c3fb6c0d188f12e896ad42c34d9e611 Author: Jeffrey Altman Date: Wed Jul 15 19:58:47 2009 -0400 de-"register" src/WINNT Remove all uses of "register" from the src/WINNT source tree. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/104 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 1c24db09fa193f964729aee27f309c27dec9853a Author: Jeffrey Altman Date: Wed Jul 15 19:16:14 2009 -0400 Add/Update .gitignore files for Windows builds Many Windows files were not included in the .gitignore files. Many directories did not have .gitignore files at all. Add and update where required. LICENSE IPL10 Reviewed-on: http://gerrit.openafs.org/103 Verified-by: Simon Wilkinson Reviewed-by: Simon Wilkinson Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 15d203c7be957ba0e63288e2d95cbd078d94eb21 Author: Michael Meffie Date: Wed Jul 15 12:46:56 2009 -0400 Fix assert message to avoid printing garbage Fix an off by one error in assert() to avoid printing garbage characters to the log. Remove the newline character generated by ctime() to match the format generated by the other logging functions. FIXES 124613 Reviewed-on: http://gerrit.openafs.org/102 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 4f36dd089a9c7187f94f77516a486245c057f7f4 Author: Andrew Deason Date: Tue Jul 14 11:29:01 2009 -0500 Ignore SIGSYS when issuing pioctl syscall Ignore SIGSYS when we issue the pioctl syscall, so we don't dump core when the kernel module hasn't yet been installed on several platforms. Also, restore the old SIGSYS signal handler afterwards, so we don't cause any side-effects. Reviewed-on: http://gerrit.openafs.org/81 Verified-by: Andrew Deason Verified-by: Derrick Brashear Reviewed-by: Russ Allbery commit 00e32618c0f08f314e191655e373452891213ee5 Author: Asanka Herath Date: Wed Jul 15 11:23:42 2009 -0400 Use InterlockedExchangeAdd() instead of InterlockedAdd() on Windows InterlockedAdd() is not supported on all the platforms we wish to support. However, InterlockedExchangeAdd() is. The two functions are semantically similar with the exception that InterlockedExchangeAdd() returns the initial value of the object being modified while InterlockedAdd() returns the resulting value. Since the return value of the rx_MutexAdd() macro is unused, this is irrelevant. Reviewed-on: http://gerrit.openafs.org/98 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 0732d4505654fb51daf6302439b467dffcbe7d3d Author: Jeffrey Altman Date: Wed Jul 15 02:41:03 2009 -0400 To reference one element of a C-string use [] Reported by Marcus Watts Pointer arithmetic is inappropriate when attempting to output one of the elements of an array or C-string. LICENSE IPL10 Reviewed-on: http://gerrit.openafs.org/90 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 6a68be71da262b7cc3a150097d579f64325c29ce Author: Jeffrey Altman Date: Wed Jul 15 02:27:29 2009 -0400 RXAFSCB_GetCellServDB takes a serverList not an array of afs_int32 Reported by Marcus Watts ListCellsRPC calls RXAFSCB_GetCellServDB which takes a serverList and not an array of afs_int32. Add the serverList and copy the resulting server addresses into the array of afs_int32 address values. Include afs/afscbint.h instead of afs/afsint.h in order to obtain prototypes for RXAFSCB_ functions. Reviewed-on: http://gerrit.openafs.org/89 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 47e31b020c3393fdbda9dddd99269482693cfb6c Author: Jeffrey Altman Date: Wed Jul 15 01:53:32 2009 -0400 Correct pointer type of 'next' field within struct volinfo Reported by Marcus Watts The next field of struct volinfo is supposed to be a pointer to a struct volinfo. LICENSE IPL10 Reviewed-on: http://gerrit.openafs.org/87 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit f498c18a6f7300eb89ca3b9d9b85c4d461fa8474 Author: Jeffrey Altman Date: Wed Jul 15 01:46:45 2009 -0400 Do not call principal_hton() to copy ktc_principal structs Reported by Marcus Watts. principal_hton() is used to copy butc_principal structs. Passing in a ktc_principal as source and destination will result in beyond the end of the ktc_principal. LICENSE IPL10 Reviewed-on: http://gerrit.openafs.org/86 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit a8cd0240e19301673598544166dab639f8e83c10 Author: Jeffrey Altman Date: Wed Jul 15 01:32:28 2009 -0400 Do not call ctime() twice in the same statement Reported by Marcus Watts. Two calls to ctime() in the same fprintf() statement will result in only one of the times being printed twice. This is due to the fact that ctime() returns a static buffer. LICENSE IPL10 Reviewed-on: http://gerrit.openafs.org/85 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 91ff083dfb098232722ed0fb9dc9bed495174e27 Author: Jeffrey Altman Date: Wed Jul 15 01:06:07 2009 -0400 Add missing TapeLog parameter to warning message Bug identified by Marcus Watts. Add missing TapeLog parameter to warning message. LICENSE IPL10 Reviewed-on: http://gerrit.openafs.org/84 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 6d6390338c7b3eadb725f916464ddb7d3b3e7b09 Author: Jeffrey Altman Date: Mon Jul 13 21:24:58 2009 -0400 Improve Windows Build System By Using MT-safe Versions of Libraries For many years the Windows Build System has incorrectly mixed some Pthread and LWP code. One of the side effects of this mixing was the need for the EXT2 extern macro definition in src/rx/rx_globals.h which permitted the LWP compiled routines to link with the Pthreaded afsrpc library. This commit creates or modifies multi-threaded versions of various libraries including mtafsubik.lib, mtafsutil.lib, mtafsvldb.lib, and mtafsvol.lib. All of the threaded servers now make use of these libraries. This reduces the number of times that many source files were recompiled for each server directory. util_GetInt32 was defined in both src/util/volparse.c and src/WINNT/afsd/fs_utils.c. Now that mtafsutil.lib is being used within src/WINNT/afsd there is no need to maintain the duplicate copy. The export list for afsauthent.def now includes all of the ubik_PR_xxxx function variants and afsrpc.def now include rxi_CallError as it is linked to outside the rx library. The top-level NTMakefile has been modified to permit the tree to build with the new header and library dependencies. The threaded volserver which never built before now does. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/77 Verified-by: Russ Allbery Reviewed-by: Russ Allbery Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear Reviewed-by: Asanka Herath Verified-by: Asanka Herath Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 8a2330a9a6914baf29b94f000848fcca0c331d50 Author: Jason Edgecombe Date: Tue Jul 14 22:12:18 2009 -0400 Updated chapter 2, sections 1-3 of the Admin Guide Replaced some references to the Authentication Database with Kerberos. Removed text about obsolete tools like rcp, inetd, and rlogin. Corrected references to AFS Product support by replacing them with links to the OpenAFS Support page. Added warnings about using the wrong fsck binary with inode and namei-based fileserver binaries. Removed an obsolete paragraph about ThisCell and how it interacts with the Authentication Database. LICENSE BSD FIXES 124931 Reviewed-on: http://gerrit.openafs.org/10 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit d9445f505ad0fc5a993d954a2d6654785c140351 Author: Jeffrey Altman Date: Tue Jul 14 17:49:00 2009 -0400 Prevent crash on Windows when data version goes backwards Within cm_MergeStatus() cm_FindVolumeByID() was called with a NULL pointer instead of a valid cm_req_t object pointer in the case where the data version for an object received from the file server is smaller than the value already stored in the cache. This results in a NULL pointer dereference. Allocate a cm_req_t object on the stack and initialize it before calling cm_FindVolumeByID() in this case. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/83 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit cdda13eec2a00becb8c2ce5270dd00a0f1097519 Author: Michael Meffie Date: Tue Jul 14 12:03:22 2009 -0400 Fix dirpath shell script generated from makefile Generate the correct paths when building transarc style paths. Remove the redundant dirpath shell script that was generated by the afs-newcell script. Update the run-tests driver to use the build time generated dirpaths. FIXES 124976 Reviewed-on: http://gerrit.openafs.org/80 Reviewed-by: Russ Allbery Verified-by: Russ Allbery commit dc6299f5bbe9defe8627519674a3ffab01443410 Author: Simon Wilkinson Date: Sat Jul 11 00:15:26 2009 +0100 Ukernel prototypes Prototypes and warning fixes for the cache manager when built as part of libuafs Reviewed-on: http://gerrit.openafs.org/73 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 243836efbb89a3b863d29ac9b0459411a4b666d5 Author: Simon Wilkinson Date: Tue Jul 14 00:18:25 2009 +0100 Capabilities are unsigned on Windows too Capabilities are defined in the .xg file as being an array of unsigned integers. Implement them as such on Windows, too. This is a Windows version of the fix in 7191005e4df1eaaf4ec94c8199ffeb72be785794 Reviewed-on: http://gerrit.openafs.org/76 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 54c0a3f3e6575fa5af39ddd797d5381c36b48001 Author: Evan Broder Date: Wed Mar 25 18:18:09 2009 -0500 Allow passing in human-readable units for specifying amounts of space Add a util_GetHumanInt32 function for parsing numbers human-readable units using single-character, uppercase suffixes for indicating orders of magnitude (e.g. 'M', 'G'). Use this function to parse human readable values for all arguments that previously accepted a value in kilobytes: fs setquota, fs setcachesize, vos setfields, and vos create. Reviewed-on: http://gerrit.openafs.org/66 Verified-by: Marc Dionne Reviewed-by: Russ Allbery Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 2510a6ec675669739a625305bcc11ab2ad671122 Author: Russ Allbery Date: Sun Jul 12 09:07:12 2009 -0700 Ensure PAM modules are built PIC and pthread-aware where needed Link the PAM modules against libafsauthent_pic and libafsrpc_pic instead of the large collection of LWP AFS libraries so that they are always built PIC, even on platforms that don't normally build everything PIC. This also uses the pthread-aware version of the AFS routines on platforms that support it, avoiding conflict problems between LWP in PAM modules and pthread in a calling application. Build a separate copy of ktc.krb.o in the pam directory for pam_afs.krb since there is no AFS_KERBEROS_ENV-aware version of libafsauthent. Enable the PAM module build by default on x86_64-linux now that it's properly built PIC and can compile. Stop ignoring build failures in the PAM modules if they're configured to build. On platforms where they should not be built, they should be excluded in acinclude.m4. Reviewed-on: http://gerrit.openafs.org/65 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit cd37fd33f70c2196ff64188e32ff759590cb3748 Author: Russ Allbery Date: Sun Jul 12 11:26:03 2009 -0700 Make ktc_curpag generally available ktc_curpag isn't specific to a Kerberos v4 environment, so move it outside the AFS_KERBEROS_ENV #ifdef. Add it to the auth.h header and to the exports from the shared libafsauthent. Reviewed-on: http://gerrit.openafs.org/64 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 7191005e4df1eaaf4ec94c8199ffeb72be785794 Author: Simon Wilkinson Date: Mon Jul 13 18:24:42 2009 +0100 Capabilities are unsigned Capabilities are defined in the .xg file as being an array of unsigned ints. Implement them as such. Reviewed-on: http://gerrit.openafs.org/72 Reviewed-by: Jeffrey Altman Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 86cfd2302074f4bbc2a09e882b70b0b540f019c7 Author: Simon Wilkinson Date: Fri Jul 10 17:57:16 2009 +0100 Remove unused variables in vol Remove some unused variables and isolate items that are demand attach only Reviewed-on: http://gerrit.openafs.org/71 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 215838d65734ad819d3bd27a2f715d1d6f68394a Author: Russ Allbery Date: Sun Jul 12 11:24:17 2009 -0700 Add strlcat and strlcpy to libafsauthent and libafsrpc Other functions included in libafsauthent and libafsrpc are using strlcpy and strlcat, so include those objects in the libraries so that they stay self-contained. strlcat and strlcpy shouldn't be part of the public API for the libraries, for various reasons including the fact that they're not built on all platforms. Therefore, don't add the functions to the library exports and include them separately in each library. Reviewed-on: http://gerrit.openafs.org/63 Reviewed-by: Derrick Brashear Verified-by: Derrick Brashear commit 4c2a6c8799ab7e8fabee9af6d50a7c56cb220cf9 Author: Marc Dionne Date: Sun Jul 12 22:03:36 2009 -0400 Linux build: properly install built kernel module Fix a problem introduced by the recent parallel make patches - the resulting kernel module was not getting copied to the install or dest location. Copy some of the code from the COMPDIRS target for INSTDIRS and DESTDIRS. We still have to call into the lower level make and have it install the module. Reviewed-on: http://gerrit.openafs.org/67 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit d58dc56d9986ab863065e5f3d8f926a25aa5b5bf Author: Simon Wilkinson Date: Sat Jul 11 18:54:15 2009 +0100 Add system headers There are a number of places in the tree which are missing system headers such as and . Add these. Reviewed-on: http://gerrit.openafs.org/62 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 42d64b5b1f9944fe35bd6358ebeba9a24162243e Author: Hartmut Reuter Date: Fri Jul 10 15:46:09 2009 +0200 Make 'fs listquota' output readable for large quota With the old print format quota and used values became one large number for quotas in the terabyte range. Fix alignment of the "no limit" string in the Windows fs command for volumes with no quota. Reviewed-on: http://gerrit.openafs.org/34 Verified-by: Russ Allbery Reviewed-by: Russ Allbery Reviewed-by: Jeffrey Altman commit e11eb503790015d817b031f9c15ce13050d836ee Author: Simon Wilkinson Date: Fri Jul 10 18:14:21 2009 +0100 Tidy up the rx directory Give functions that need them return values Add prototyping for server_proc and rx_ts_tinfo_init Make debug functions only build when RXDEBUG is enabled Reviewed-on: http://gerrit.openafs.org/61 Reviewed-by: Derrick Brashear Verified-by: Derrick Brashear commit 94a3f8fb64fa7bc28529eb3a3abd3f5b10f7854a Author: Simon Wilkinson Date: Sat Jul 11 18:07:20 2009 +0100 Remove vlclient.h The vlcient.h header file just provides definitions for functions that are now protoyped elsewhere by rxgen. It is only referenced by vlclient.c which was already including the rxgen header. So, nuke vlcient.h, and references to it. Reviewed-on: http://gerrit.openafs.org/60 Reviewed-by: Derrick Brashear Verified-by: Derrick Brashear commit 8e382795d52b6fe8db33ff5353f841b077a25671 Author: Marc Dionne Date: Sat Jul 11 18:18:08 2009 -0400 Parallel make: additional fixes Testing turned up a few more errors with parallel builds: - Linux: Apply a similar fix for "make dest" to the one in the previous patch for "make install". Avoid conflict between DESTDIRS and COMPDIRS, which also prevents unneeded duplicate work. - Fix a couple of cases where we have 2 targets in a single rule with a command that generates both of them. Two parallel jobs can run this command at the same time, with missing or corrrupted files as a result. The workaround: make one of the targets build the files, and make the second target depend on the other one. Reviewed-on: http://gerrit.openafs.org/57 Verified-by: Russ Allbery Reviewed-by: Russ Allbery Reviewed-by: Derrick Brashear commit c8920835ae9e33555a7d023cd0bd3a2f26a98b98 Author: Russ Allbery Date: Fri Jul 10 16:48:42 2009 -0700 Probe for getcwd in configure src/venus/test/fulltest.c wants to use getcwd and expects HAVE_GETCWD to be defined, but we weren't probing for it in configure. Reviewed-on: http://gerrit.openafs.org/51 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 8519ed8d217a484c29e514bb2e6e7c7faa88b20e Author: Simon Wilkinson Date: Sat Jul 11 14:37:37 2009 +0100 Make lwp.h always provide fasttime prototypes The fasttime functions are used regardles of whether we're using pthreads or LWP. Previously, lwp.h only provided their prototypes if LWP was in use. Change this so these prototypes are always provided, by refactoring the header a little. In the process, remove some duplicate header includes. Reviewed-on: http://gerrit.openafs.org/56 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit d46713d4bd0d0ce32640d973696c914e804413f6 Author: Marc Dionne Date: Mon Jul 6 20:41:25 2009 -0400 Parallel make fixes Fixes several problems with parallel makes in the current source: - Add '+' prefix to many top-level Makefile commands. This informs make that the following command should be treated as a sub-make and propagates the -jN flag. - Add a few missing dependencies - Tweak some Makefiles that work with generated header files to prevent cases where we attempt to use the file while it's being generated - For the Linux kernel build, eliminate duplicated effort between COMPDIRS and INSTDIRS, which also prevents conflict between the two in a parallel situation. FIXES 125031 Reviewed-on: http://gerrit.openafs.org/3 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit df87d886bb1b2cf2bab8075a21a62f11d4eafc97 Author: Derrick Brashear Date: Fri Jul 10 15:59:55 2009 -0400 Update IRIX build issues Refer to srcdir, not SYS, for syscall.s Don't build fc_test for all (libsys doesn't exist yet) Include needed header for Fd_t in xfs_size_check Reviewed-on: http://gerrit.openafs.org/41 Verified-by: Derrick Brashear Reviewed-by: Russ Allbery Reviewed-by: Derrick Brashear commit 7f8249bc57e5a03051f44ec62f1523d02f428692 Author: Jeffrey Altman Date: Sat Jul 11 01:37:45 2009 -0400 Correct format specification for "struct clock" values struct clock contains signed seconds and signed microseconds. The format specification should be %d.%06d in all cases. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/55 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit c4c0c67fb6afc30a97c93552d00460b3291ac872 Author: Jeffrey Altman Date: Fri Jul 10 20:43:13 2009 -0400 Correct computation of rx packet resends and data packets sent. rx packet resends were being double counted. rx data packets sent were one more per send list than it should have been. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/54 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 5d4dabc50a0f313b95eb3ab6be7153d5f41fef5f Author: Simon Wilkinson Date: Sat Jul 11 00:54:04 2009 +0100 ANSIfy bu_utils A very small amount of code cleanup to add prototypes, ANSIfy, and remove warnings from the fms.c file Reviewed-on: http://gerrit.openafs.org/53 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit a2e728fe9f34ca12c9d26eb299dbc8806273e9a4 Author: Simon Wilkinson Date: Sat Jul 11 00:51:14 2009 +0100 Prototypes for the update directory Prototyping, ANSIfication, and warning cleanup for the update directory Reviewed-on: http://gerrit.openafs.org/52 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit ac3e0ed03187cf7c8af046adb102d6500452815f Author: Simon Wilkinson Date: Sat Jul 11 00:41:02 2009 +0100 Rename printf cast helpers and clean up format string warnings Some confusion had ensued about the usage of our printf cast helper functions. Rename these to attempt to allay that confusion, and restore the functions themselves to their original definitions. Essentially, afs_printable_int32_ld() and friends are helpers to go from afs specifc types to things that can be emitted by printf without causing compiler warnings. Also clean up some additional warnings from type mismatches between escapes in printf format strings and the variables being printed. Reviewed-on: http://gerrit.openafs.org/50 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit d34017c9edccf35825bc2cf1b345e78aeb50b73a Author: Simon Wilkinson Date: Sat Jul 11 00:07:37 2009 +0100 Warning cleanup for the libadmin directory Where we can, include headers from the include directory Resolve a load of const char* /char * issues Mark some Windows only variables as such Fix prototypes Reviewed-on: http://gerrit.openafs.org/49 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 01ba9cde63214397843c6f45e0abcacb685218c3 Author: Simon Wilkinson Date: Fri Jul 10 23:57:38 2009 +0100 Prototypes for venus/test Add additonal headers, prototypes, and ANSIfy function definitions in venus/test Reviewed-on: http://gerrit.openafs.org/48 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 738878d9f0cbf38e2bb53be13cf7f1d35f217eeb Author: Simon Wilkinson Date: Fri Jul 10 23:36:39 2009 +0100 Further cleanup of the butc directory Now that butm is sharing its prototype, further cleanup, ansification and warnings reduction for butc. Reviewed-on: http://gerrit.openafs.org/46 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 4e7b1578384250a0ab7b054af0fabe157a5dba45 Author: Simon Wilkinson Date: Fri Jul 10 23:46:36 2009 +0100 Prototypes for rxdebug Trivial prototyping and warning cleanup for the rxdebug directory Reviewed-on: http://gerrit.openafs.org/47 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit bf786eaf43cf58aac576994f3bfed5a41957aa32 Author: Simon Wilkinson Date: Fri Jul 10 23:04:25 2009 +0100 Add exported butm_prototypes.h header Add exported header for the butm directory so it can be used elsewhere Reviewed-on: http://gerrit.openafs.org/45 Verified-by: Russ Allbery Reviewed-by: Russ Allbery Reviewed-by: Jeffrey Altman commit fb51d2796f8d7f1ae4338181a80bb5ceb58e2d3f Author: Simon Wilkinson Date: Fri Jul 10 22:27:30 2009 +0100 Export budb_prototypes.h Other modules need prototypes from the budb directory, so we need to export this header. However it contains lots of internal functions. So, split the header into budb_prototypes.h and budb_internal.h, and reference the internal.h header locally. Reviewed-on: http://gerrit.openafs.org/44 Verified-by: Russ Allbery Reviewed-by: Russ Allbery Reviewed-by: Jeffrey Altman commit dae49105c81b526f7fb3c3832984e9411c5c7ac2 Author: Jeffrey Altman Date: Fri Jul 10 15:47:35 2009 -0400 bucoord_prototypes.h is a new public header file. Install bucoord_prototypes.h to the include/afs directory. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/43 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 73cef96bb335056963c31a6ec382cb4fa969b29e Author: Jeffrey Altman Date: Fri Jul 10 15:33:47 2009 -0400 afs/vol_prototypes.h is a new public header file. Add afs/vol_prototypes.h to src/vol/NTMakefile so it will be installed in the public include directory. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/42 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 8978e035bab7c49cceb942589f65d8b0a5d0465c Author: Russ Allbery Date: Fri Jul 10 08:10:37 2009 -0700 Clean up uses of strcpy and strcat in src/vol/namei_ops.c Replace all uses of strcpy and strcat in src/vol/namei_ops.c with either strlcpy/strlcat or afs_snprintf as appropriate. Reviewed-on: http://gerrit.openafs.org/29 Reviewed-by: Derrick Brashear Verified-by: Derrick Brashear commit c244091b192053084d48af0607b0e25419674a76 Author: Simon Wilkinson Date: Fri Jul 10 20:22:18 2009 +0100 Add prototypes for butc Prototype, fix warnings, and ansify the butc directory Reviewed-on: http://gerrit.openafs.org/39 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 586d32c53370458c780c721995695f1ee7bee272 Author: Simon Wilkinson Date: Fri Jul 10 20:28:06 2009 +0100 Don't remove ccode, just conditionalise it The change in b21015242022872101b9c3c78df511e2a2dc6399 broke systems without posix regexes by removing, rather than conditionalising the 'ccode' variable Reviewed-on: http://gerrit.openafs.org/40 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 740d923f4569d888246b231ff9a93278561d3c65 Author: Jeffrey Altman Date: Fri Jul 10 15:07:26 2009 -0400 Add rx_headers build rule on Windows src/util/netutils.c must include rx/rx.h in order to avoid warnings due to the lack of prototypes for rx functions. src/rx depends on src/util being built in order to properly compile. Add a rx_headers build rule to the top level NTMakefile to permit rx headers to be installed before src/util is built. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/38 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 3c6ce91e5a23fa2cb742cb3f6759cec3ece10249 Author: Simon Wilkinson Date: Fri Jul 10 13:52:16 2009 +0100 Roughly prototype the kauth directory A first pass at prototyping and warning reduction for the kauth directory. kauth is plagued by the des key type problems, and no attempt to remedy this has been made. Some other complex warnings remain - it didn't seem worth the effort to do this in too much detail, as it's dying soon. Reviewed-on: http://gerrit.openafs.org/23 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman Reviewed-by: Derrick Brashear commit 32e107317cbc0db93b46a56dcf69102e9ab0ff1e Author: Simon Wilkinson Date: Fri Jul 10 18:33:38 2009 +0100 Rework bucoord prototypes for external dlq use Rework prototyping in the bucoord directory so that bucoord_prototypes.h can be used by others who need definitions of the dlq_* types. Add additional prototyping and header includes so these types work correctly No Windows specific changes are required, as the NTMakefile doesn't have header dependencies Reviewed-on: http://gerrit.openafs.org/35 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit b21015242022872101b9c3c78df511e2a2dc6399 Author: Simon Wilkinson Date: Fri Jul 10 12:54:10 2009 +0100 Prototyping for the volser directory Prototyping and warning message reduction for the volser directory. Adds physio.h and dumpstuff.h as internal header files, Many error code variables are changed from being afs_int32, to the 'Error' typedef, to remove signed comparison errors. Reviewed-on: http://gerrit.openafs.org/19 Reviewed-by: Russ Allbery Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit e712cae20ec3e256e47fba5bac9b7d467c44810b Author: Simon Wilkinson Date: Fri Jul 10 17:28:44 2009 +0100 Prototype viced Add prototypes, remove warnings, and ANSIfy code in the viced/ directory Reviewed-on: http://gerrit.openafs.org/33 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 8d546dcc90d861df24cef6fcded2fbc5998d7407 Author: Simon Wilkinson Date: Fri Jul 10 13:40:56 2009 +0100 Remove pr_PrintEntry from public headers pr_PrintEntry isn't used outside of the ptserver directory, and requires struct prentry, which is defined internally, so remove it from ptuser.h, and create a new internal header to hold it. Also, tidy up some type mismatch warnings by making static strings const char * Reviewed-on: http://gerrit.openafs.org/22 Reviewed-by: Russ Allbery Verified-by: Russ Allbery commit 3bf2e90f251344f72437dc05e3780ba5c86e8096 Author: Simon Wilkinson Date: Fri Jul 10 16:44:39 2009 +0100 ANSIfy ptclient Change all the function definitions in ptclient to ANSI form Reviewed-on: http://gerrit.openafs.org/32 Reviewed-by: Russ Allbery Verified-by: Russ Allbery commit a151529de62bd6049ddc507c62bc09747c3ec111 Author: Simon Wilkinson Date: Fri Jul 10 13:30:20 2009 +0100 Tidy up util Resolve a number of minor warnings Prototype the stolower function for use elsewhere Reviewed-on: http://gerrit.openafs.org/21 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 095ad16a315bf564139dd9904348f889bee58f73 Author: Simon Wilkinson Date: Fri Jul 10 14:25:40 2009 +0100 Fix return type defaults to int warnings in ubik Fix "return type defaults to int" warnings in ubik/beacon.c Reviewed-on: http://gerrit.openafs.org/24 Reviewed-by: Russ Allbery Verified-by: Russ Allbery commit 4087484fb45c5e6dbde6106d9c389e6f69b80b05 Author: Simon Wilkinson Date: Fri Jul 10 12:10:46 2009 +0100 Tidy up libacl Very small amount of prototyping Rewrite comment block so it wraps at 80 lines Make sure there are no implicit ints Reviewed-on: http://gerrit.openafs.org/18 Reviewed-by: Russ Allbery Verified-by: Russ Allbery commit 7c472cd9a685fe13a96038dfe57c62c5da5a669c Author: Simon Wilkinson Date: Fri Jul 10 13:19:03 2009 +0100 Prototype the xstat directory Prototype, ansify, and remove errors in the xstat directory Reviewed-on: http://gerrit.openafs.org/20 Reviewed-by: Russ Allbery Verified-by: Russ Allbery commit 79316efa84daead80c8cb8e28ebc3530768a6da7 Author: Jeffrey Altman Date: Fri Jul 10 11:42:17 2009 -0400 Modify Windows top-level NTMakefile to use "md" instead of "mkdir" Now that src/config/NTMakefile. actually uses the override value. Lets fix the definition of MKDIR to avoid the Unix style executables. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/31 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 386fea8d86b6debeb81355ba9bdede83b2f7285d Author: Jeffrey Altman Date: Fri Jul 10 11:16:25 2009 -0400 The Windows Makefiles provide macros for various commands. The MKDIR macro is current assigned to mkdir which causes the cygwin/msys mkdir.exe commands to be used instead of the cmd.exe built-in command. Change this to use "md" instead so that the built-in will be used by default. In addition, permit the macros to be overridden by the top level NTMakefile or the environment. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/30 Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit a9368a6c3dfe4435ec2ae63fff4a3325104ed9f7 Author: Derrick Brashear Date: Fri Jul 10 10:52:27 2009 -0400 HP-UX 11i compiler will segv on static __inline in the fsbnode-bnode xlator since this function appeared the compiler on HP-UX 11i started segving. since it's not necessary, we simply remove it Reviewed-on: http://gerrit.openafs.org/28 Reviewed-by: Derrick Brashear Verified-by: Derrick Brashear commit 9e8ae43b112f2f1f4a9e81eacf5e8abc0a3e16b5 Author: Jeffrey Altman Date: Thu Jul 9 21:25:07 2009 -0400 Add "PerFileAccessCheck" registry value. The HKLM\SYSTEM\CurrentControlSet\Services\TransarcAFSDaemon "PerFileAccessCheck" registry value (DWORD) is intended for use only by developers who wish to test how Windows would behave if a per-file access rights check was performed. Windows performs all access rights checks using the directory access rights. There is no support for the VL_DFSFILESET flag. During CreateFile() processing the requested access rights are checked against the access rights reported by the file server for the directory. If the reported rights are more permissive than the effective access rights for the file, Windows applications (including the Explorer Shell) will behave quite poorly. In other words, if the request is for write privilege and the CreateFile() successfully opens the file with write privilege, subsequently reporting an access denied on a WriteFile() call will result in very poor behavior. The addition of this option is simply to make it easier on developers to test various prototype solutions for adding per-file access rights. LICENSE MIT Reviewed-on: http://gerrit.openafs.org/15 Reviewed-by: Asanka Herath Reviewed-by: Derrick Brashear Verified-by: Jeffrey Altman Reviewed-by: Jeffrey Altman commit 6c6f9dce248bb22162981fec8a5de53736740e7f Author: Simon Wilkinson Date: Fri Jul 10 11:58:44 2009 +0100 Tidy the vol directory - Remove some further warnings from the vol directory - Add volutil_PartitionName2_r to afsutil_prototypes.h - Export vol_prototypes.h so it can be used elsewhere in the tree Reviewed-on: http://gerrit.openafs.org/17 Reviewed-by: Derrick Brashear Reviewed-by: Russ Allbery Verified-by: Derrick Brashear commit 0cf977e5354bd28ac6d9777662e6a2121a510d35 Author: Simon Wilkinson Date: Thu Jul 9 13:53:33 2009 +0100 Prototype the vlserver directory Prototype, ansify, and other do warning cleanups on code in the vlserver directory. Reviewed-on: http://gerrit.openafs.org/16 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit b7942950c2d1fcaa1e94ebbe91c8d2a9a7670cdb Author: Aaron M. Ucko Date: Mon Jul 6 17:41:49 2009 -0700 Always use kbuild for all Linux kernel configure probes Some Linux kernel probes for the existence of header files were done with file existence checks (test -f). This breaks if the kernel build system is stacking multiple directories of headers together with compile-time -I include path options, as is the case for the current Debian Linux header packages. Instead, always use kbuild to check whether a kernel header is available. Similarly, use AC_TRY_KBUILD instead of AC_TRY_COMPILE when checking for an SELinux kernel, since AC_TRY_COMPILE doesn't call into kbuild and won't get the correct kernel header paths. This is part of the fix for Debian Bug#521745 and has been included in the Debian package since 1.4.10+dfsg1-1. Reviewed-on: http://gerrit.openafs.org/5 Verified-by: Russ Allbery Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 01d390d0d022309d06760aac1373829a35a6d79c Author: Aaron M. Ucko Date: Mon Jul 6 17:51:00 2009 -0700 Build shadow header files when necessary on Linux The current kernel module build infrastructure relies on the ability to create symlinks from known directory names used in the AFS code to the actual locations of the kernel header files. This breaks if there is no single kernel header tree and instead multiple trees are layered together by kbuild using compile-time -I include paths. Attempt to detect this case by seeing if linux/types.h is in the kernel header directory where we expect it. If not, rather than creating symlinks for h, sys, and netinet, create directories and populate them with single-line headers that just include the corresponding linux/*.h header. The list of headers for which to do this is generated dynamically by analyzing the AFS kernel source code and looking for relevant #include directives. This patch has been part of the Debian OpenAFS package since 1.4.10+dfsg1-1. The check for whether we have layered kernel header trees may be specific to Debian and may require modification later if other Linux distributions do something similar. FIXES 124583 Reviewed-on: http://gerrit.openafs.org/6 Verified-by: Russ Allbery Reviewed-by: Derrick Brashear Verified-by: Derrick Brashear commit 3bb5fa5f1b3dc13ab20ed026c7ea64e11388b9c9 Author: Simon Wilkinson Date: Thu Jul 9 15:08:32 2009 +0100 Remove the RCSID macro The move to git means that we can no longer populate the RCSID macro in the way that it was used with CVS. This patch simply removes the macro from every file, except where it contains information from upstream (and it's in a comment). Reviewed-on: http://gerrit.openafs.org/14 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit bbab48b047000db0d1821e2f65917c2e8c2c7768 Author: Russ Allbery Date: Mon Jul 6 18:41:39 2009 -0700 Build and install PIC versions of libafsrpc and libafsauthent To include AFS code in loadable modules such as PAM modules, NSS modules, or Perl/Python/PHP/Ruby extensions, it needs to be built PIC or one must link with the AFS shared libraries. Since we haven't historically been that great about maintaining the shared library ABI, it's nice to have static libraries built with PIC code that can be linked into such modules. Based on a patch by Garrett Wollman updated with the build system changes that happened after 1.4. Make shlib makefiles have clean rules for PIC libraries. Make RedHat specfile know how to deal with PIC libraries. Reviewed-on: http://gerrit.openafs.org/8 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit 072974935c12ee9e3a512933d8246b5dc5a251e0 Author: Simon Wilkinson Date: Thu Jul 9 13:17:27 2009 +0100 Prototype the afsmonitor directory Prototypes and code cleanup for afsmonitor Reviewed-on: http://gerrit.openafs.org/13 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit f52b97b76cba008c9aa6ae843869c95d83fbd9f9 Author: Andrew Deason Date: Tue Jul 7 17:34:17 2009 -0500 Always display vnode accesses in vos output Vos was not displaying the "N accesses in the past day (i.e., vnode references)" message when updateDate was unset. Fix that. FIXES 125064 Reviewed-on: http://gerrit.openafs.org/9 Verified-by: Andrew Deason Reviewed-by: Jeffrey Altman Reviewed-by: Simon Wilkinson Reviewed-by: Derrick Brashear commit 722070a5c6b1c87cb8c80e8938464183dab01c8f Author: Andrew Deason Date: Wed Jul 8 16:15:37 2009 -0500 Correcting formatting typo in vos addsite manpage Reviewed-on: http://gerrit.openafs.org/12 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit 7488aeef5cfd58935fe4a6a07810c8d757dd98a3 Author: Andrew Deason Date: Wed Jul 8 16:07:58 2009 -0500 Fixing manpage for vos addsite -valid The -valid switch to vos addsite doesn't take an argument, and it is optional. Correcting documentation to reflect that. Reviewed-on: http://gerrit.openafs.org/11 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit ecd3fc42d1d6dca23bb2e2728a0066d3db8eceb6 Author: Russ Allbery Date: Mon Jul 6 17:19:26 2009 -0700 Search for the Linux version in the correct header src/config/linux-version already had support for handling either versioned or unversioned kernel source directories, but the grep for UTS_RELEASE was unconditionally done against the versioned source tree, ignoring the previous determination of where the header file was. Instead, check instead the header file location that we'd previously determined. This patch has been tested in the Debian OpenAFS 1.4.11~pre3+dfsg-1 package. Reviewed-on: http://gerrit.openafs.org/4 Reviewed-by: Simon Wilkinson Verified-by: Russ Allbery Reviewed-by: Derrick Brashear commit 002363adb9526f4c0bc2937b0b6589fae0e5334e Author: Jason Edgecombe Date: Mon Jul 6 21:26:30 2009 -0400 Fixed a minor grammatical error in the voz_zap man page Reviewed-on: http://gerrit.openafs.org/7 Verified-by: Russ Allbery Reviewed-by: Russ Allbery commit d5081f264dae17fed3daca5ed646f9c082557f0c Author: Simon Wilkinson Date: Mon Jul 6 13:52:21 2009 +0100 Remove CVS ignore files Now we're in git we don't need any cvsignore files any more... Reviewed-on: http://gerrit.openafs.org/1 Verified-by: Derrick Brashear Reviewed-by: Derrick Brashear commit ba9ad6284528e669bfaacf0400b90fc08a5614e4 Author: Simon Wilkinson Date: Mon Jul 6 14:38:42 2009 +0100 Revise git ignore files Revise our git ignores to match the current state of the tree, and include entires in the top level for all of the 'dest' directories for all of the architectures we claim to support. Reviewed-on: http://gerrit.openafs.org/2 Reviewed-by: Derrick Brashear Verified-by: Simon Wilkinson commit 46287f679023c8d1430c64d03e06933cf6121a24 Author: Jeffrey Altman Date: Sat Jul 4 04:45:37 2009 +0000 windows-optimizations-20090703 LICENSE MIT when performing offline volume checks, do so in most recently used order if the system is entering suspend state, short circuit the background daemon operations to avoid extra work that is going to fail when the network is shutdown behind the back of the service. commit ebc4f737ae8f8056de1a7f80828a6173ebb24292 Author: Simon Wilkinson Date: Fri Jul 3 14:16:53 2009 +0000 linux-vnop-return-value-cleanup-20090703 LICENSE IPL10 rework all linux vnode ops so the vulnerability we previously had can't recur later just because someone makes a change that would leak a negative error commit 6ef1234402435306cb3935d1eadc5fcf332bd632 Author: Andrew Deason Date: Fri Jul 3 14:03:57 2009 +0000 viced-ubik-clientdestroy-null-20090703 LICENSE IPL10 FIXES 125020 null ubik client point when it's freed in hpr_End to avoid a null deref later commit 22196a7fd78dff342b2f9fca2b38d9a2dd04d42c Author: Derrick Brashear Date: Fri Jul 3 13:56:43 2009 +0000 redhat-spec-manpage-updates-20090703 LICENSE IPL10 add missing manpages to srpm commit 8a6bd630354ab7fc17bc5cfaeb10267ad2cc10eb Author: Jeffrey Altman Date: Wed Jul 1 22:14:42 2009 +0000 wix-manpages-chgrp-chown-20090701 LICENSE MIT add fs_chgrp.html and fs_chown.html man pages commit 4db337f87c0170380037593d1c998fb1b9819aa3 Author: Jeffrey Altman Date: Wed Jul 1 22:12:10 2009 +0000 manpages-fs-chown-chgrp-20090701 LICENSE BSD Add new man pages for fs chown and chgrp on Windows. Update titles for Windows only commands to indicate they are Windows only. commit 4ca66112c2a012e04619445275507ae9cd6c11da Author: Marc Dionne Date: Wed Jul 1 21:56:48 2009 +0000 linux-keyring-export-check-20090701 LICENSE IPL10 FIXES 125001 check for key_type_keyring being exported; only use it if so commit ffd065a69578ad26c860b0b3e54053d6432c4a21 Author: Jeffrey Altman Date: Wed Jul 1 21:25:28 2009 +0000 windows-fs-chown-chgrp-20090701 LICENSE MIT On Windows there is no chown or chgrp command that can be used to change the owner or group of an object in AFS. Therefore we add them to the fs command. Usage: fs chown -owner [-path +] [-literal] [-help] Where: -literal literal evaluation of mountpoints and symlinks Usage: fs chgrp -group [-path +] [-literal] [-help] Where: -literal literal evaluation of mountpoints and symlinks commit ad6a8942db587b2c5b9aaee6a3e8e89b69e3918c Author: Jeffrey Altman Date: Wed Jul 1 02:44:05 2009 +0000 windows-cellconfig-20090630 LICENSE MIT nul terminate the correct variable commit efdf78ae086ba02cc3f6ffbd7b0a2ca31743ced7 Author: Jeffrey Altman Date: Tue Jun 30 19:11:28 2009 +0000 windows-dfs-file-set-warning-20090630 LICENSE MIT Add a debug log warning if the target volume is a DFS File Set. If so, the client will not properly protect against information leakage or properly deal with directory name caching, symlinks, and other behavioral differences between AFS and DFS. commit 49d6a0992c42a6bb1fba8245029f31ca916214e5 Author: Jeffrey Altman Date: Tue Jun 30 18:59:43 2009 +0000 windows-smb-20090630 LICENSE MIT Be sure to call smb_ReleaseVCNoLock before we drop the smb_rctLock. commit 58024c16844a7298f04495ff9023e396a5391aff Author: christof.hanke@rzg.mpg.de Date: Mon Jun 29 21:24:23 2009 +0000 rpmlint-try2-20090629 LICENSE IPL10 FIXES 124951 remove unneeded return; fix iob initialization for curpag pioctl commit a50fa631cad6919d15721ac2c234ebbdda2b4031 Author: Jeffrey Altman Date: Mon Jun 29 20:38:17 2009 +0000 windows-dcache-prefer-xdata-error-20090629 LICENSE MIT FIXES 125018 Fix issue reported by Marc Dionne. RXAFS_FetchData and RXAFS_StoreData return access denied errors that are not reported by the subsequent call to rx_EndCall which should be preferred. commit f202b9778e4489fd80288c5be36e3c102b0cfba9 Author: Derrick Brashear Date: Mon Jun 29 16:19:59 2009 +0000 revert-voldump-v-tag-generation-20090629 LICENSE IPL10 FIXES 18349 generating v tags is currently incompatible. revert this for now commit 3d5415922ea4ede4ce538d7894a6062bf115c6bd Author: Marc Dionne Date: Mon Jun 29 14:58:58 2009 +0000 rcu-patch-fallout-20090629 LICENSE IPL10 FIXES 124996 massaging this for 1.5.x/head caused some fallout. fix doubled endif, and install_session_keyring arguments commit 4a09cd4976dc9088cd32115dc06458afb3a577d4 Author: Jeffrey Hutzelman Date: Mon Jun 29 07:03:09 2009 +0000 cellservdb-20090629 CellServDB from central.org dated 29 Jun 2009 commit 307e077b2343b73731d7f21f422b7a130caf12c7 Author: Jeffrey Altman Date: Mon Jun 29 04:27:41 2009 +0000 windows-shutdown-20090628 LICENSE MIT short circuit on-going offline volume checks once a shutdown has begun. commit b8a1dba29367c9786a5f43c90b0a000ff4d4315d Author: Jeffrey Altman Date: Mon Jun 29 04:25:16 2009 +0000 windows-hard-link-count-20090628 LICENSE MIT cm_Link() is used to create hard links. It did not apply the updated link target status info to the target cm_scache_t object. As a result the linkCount would be incorrect. cm_Unlink() did not take linkCount into account. It did not reduce the locally known linkCount, nor did it invalidate any currently known callback. As a result the linkCount would be incorrect. commit d54859c6ac2e5186b18da027303860966504dbd9 Author: Jeffrey Altman Date: Sun Jun 28 05:15:31 2009 +0000 windows-multi-homed-callbacks-20090627 LICENSE MIT Properly handle callbacks from multi-homed file servers. Comparing cm_server_t pointers is insufficient. For a multi-homed server there will be multiple entries. The UUID for all of the equivalent entries will be the same. What matters is not that the pointers are the same but whether in the case of UUID labeled servers that the UUIDs match. Add cm_ServerEqual() to perform the comparison. commit 100186ec2e4ca5046e1bc312918d4630de00bc7e Author: Jeffrey Altman Date: Fri Jun 26 15:11:10 2009 +0000 windows-callback-server-tracking-for-readonly-vols-20090626 LICENSE MIT Readonly volume callbacks apply to every cm_scache_t from the same volume. We were already tracking the cbExpires time in the cm_volume_t. We need to also track the cbServerp in the cm_volume_t so that the cm_scache_t objects can be assigned the correct server from which the callback was issued. Add cbServerpRO field to the cm_volume_t. Bump the memory map version to force a rebuild of the cache data. commit de374565233eea489079e102865ab6cd65ef0dbb Author: Jeffrey Altman Date: Fri Jun 26 14:14:47 2009 +0000 windows-cell-config-clones-20090626 LICENSE MIT Add support for parsing clones from the CellServDB file. commit e43342e3778524a68219875b5fdc6fae0adbef1f Author: Derrick Brashear Date: Thu Jun 25 13:13:14 2009 +0000 allow-gcpags-disabling--at-compile-20090624 LICENSE IPL10 put this back as was for now; if we want to undef, we can do it later, completely commit 4ac7d59d464d66322a2925c86e955cd8d8067f75 Author: christof.hanke@rzg.mpg.de Date: Thu Jun 25 00:14:43 2009 +0000 pag-get-lint-20090623 LICENSE IPL10 FIXES 124951 make things happy for rpmlint again (wrong initialization) commit 0e718b642cedd1ebc799ada35960164c95c24280 Author: Marc Dionne Date: Wed Jun 24 22:53:40 2009 +0000 linux-rcu-read-lock-export-20090623 LICENSE IPL10 FIXES 124986 deal with rcu_read_lock() becoming GPLONLY commit a125b571a4d7c6c8c491bda079115a5eab835971 Author: Harald Barth Date: Wed Jun 24 22:44:56 2009 +0000 fbsd61-stdlib-proto-define-20090623 LICENSE IPL10 FIXES 124952 add define to make stdlib have malloc prototype commit ee72f251049ca361b095e813adce63216343afd8 Author: Andrew Deason Date: Wed Jun 24 22:38:15 2009 +0000 osol-solookup-20090624 LICENSE IPL10 FIXES 124924 update for new opensolaris solookup function signature commit b45838ca82a085360491b14fdb16e88612a43165 Author: Jeffrey Altman Date: Wed Jun 24 16:15:39 2009 +0000 util-snprintf-replacement-20090624 LICENSE BSD 1. Add a test program for *printf functionality. util/tests/snprintf_test.c 2. Replace OpenAFS implementation of afs_*printf() with Heimdal's version. 3. Add support to Heimdal's version to support: - floating point - OpenAFS %I ipv4 address formatting (dotted notation and hostname lookup) - Microsoft's I32 and I64 integer size modifiers With these changes OpenAFS gains: - output that is compliant with standard *printf implementations. the previous implementation had justification, padding and case errors. - support for a NULL buffer which computes the required size based upon the input format and arguments. the previous implementation would crash. - support for additional format types. - OpenAFS specific implementations of vasnprintf(), vasprintf(), asprintf(), and asnprintf(). commit 74d49eb2c68f787044fe9f612d4f5f4610907572 Author: Jeffrey Altman Date: Wed Jun 24 15:47:29 2009 +0000 windows-config-amd64-20090624 LICENSE MIT amd64 uses 64-bit pointers. Define AFS_64BITPOINTER_ENV. commit b02e22b5f0590929ef9120da4799ca9a47fa3aeb Author: Marc Dionne Date: Mon Jun 22 16:25:23 2009 +0000 linux-call-inode-setattr-op-20090622 LICENSE IPL10 FIXES 124942 call inode's setattr op instead of just inode_setattr, when one is available. needed for xfs, notably also will cause truncates to be journalled for ext3, which may solve some existing issues commit 0200a40061a70c8e768f7510604839aaa7925a28 Author: Jeffrey Altman Date: Fri Jun 19 04:08:08 2009 +0000 cellconfig-gethostbyname-20090618 LICENSE MIT The CellServDB processing in auth/cellconfig and WINNT/afsd/cm_config differ in one important way. cellconfig uses the IP addresses specified in the CellServDB file and ignores the host name; whereas cm_config calls gethostbyname() on the host name and falls back to the specified address only if gethostbyname() fails. This commit modifies cellconfig to use gethostbyname() calls on the host names when the client CellServDB file is being used. The server CellServDB file is left alone because ubik servers need to be given the exact list of ip addresses specified by the administrator and there is no method of indicating clones to other servers using DNS. This change permits a greater resilency to cell server configuration changes due to IP address renumbering as the DNS names in the CellServDB file can be CNAME or A records. A host name can be resolved to multiple IP addresses and all of the addresses will be added to the hostAddr list for the cell provided that they do not exceed the maximum number of hosts. If the same host name is listed multiple times the duplicate IP addresses will be ignored. The behavior of all tools that use CellServDB files on Windows will now be consistent. commit cfe1f5676d458ca2ca8ba562ace782305e68059f Author: Jeffrey Altman Date: Thu Jun 18 06:04:29 2009 +0000 windows-netidmgr-20090617 LICENSE MIT permit building with a broader range of visual studio versions commit f310847d2dfa924aaeff2924cfbc885d1cd58a31 Author: Jeffrey Altman Date: Thu Jun 18 00:45:36 2009 +0000 windows-testcellconf-20090617 LICENSE MIT make testcellconf work on Windows commit 3af8eafae68b7260941b59346720730410f97944 Author: Jeffrey Altman Date: Tue Jun 16 23:40:38 2009 +0000 windows-kauth-cell-search-registry-20090616 LICENSE MIT add registry based cell search to ka_UserAuthenticateGeneral2() which is used by klog() and afslogon.dll when no kerberos support is available. commit 377b8c176fde2cab27d27c644b6966bf153daad5 Author: Jeffrey Altman Date: Tue Jun 16 23:37:49 2009 +0000 windows-client-config-cell-search-registry-20090616 LICENSE MIT Add registry based cell search functionality to afs_config.exe even though the tool is close to useless at this point. commit 4bf09a2ebfabede83cdac782de52386423e01927 Author: Jeffrey Altman Date: Tue Jun 16 22:57:08 2009 +0000 windows-netidmgr-cell-search-registry-20090616 LICENSE MIT Forgot to update the afs provider to support registry based cellservdb lookups commit e44c38c423fee7f10540ee339c372dce043af10d Author: Andrew Deason Date: Tue Jun 16 19:09:43 2009 +0000 ubik-fix-allbetter-loglevels-20090616 LICENSE IPL10 FIXES 124938 make allBetter log more sensibly; right now it's very loud. move it to level 25 commit a44bee561505c8f955c84d5c96227d72d3cdaf57 Author: Derrick Brashear Date: Tue Jun 16 19:08:11 2009 +0000 afs-snrpintf-support-percentp-for-ptrs-20090616 LICENSE IPL10 so we can portably log pointers commit 82d9807e2246997ac73930c91d1ad4312084cc57 Author: Jeffrey Altman Date: Tue Jun 16 05:59:22 2009 +0000 windows-conn-analyze-20090615 LICENSE MIT When processing RX_CALL_TIMEOUT, if there is no fid specified its a vldb rpc and we should retry. If there is a fid and the volume is a readonly volume then we should also retry. Only fail if the request has no alternate server to look at. When processing RX_CALL_DEAD, log the fact that the call is dead. When processing any other RX error between -2 and -64, do not force a new connection to the same server. Mark the server down and retry with a new server if possible. commit 81c9b8c0c4ddf711872104ba6645c1310093af24 Author: Jeffrey Altman Date: Tue Jun 16 05:56:19 2009 +0000 windows-cellservdb-rank-20090615 LICENSE MIT When inserting a new vldb server, if the rank is 0 (unknown), do not override the default rank assigned by cm_NewServer(). Doing so erases the randomized ranking. commit c41a46774134aee6eaf6a41e9061386035ae6ebf Author: Simon Wilkinson Date: Mon Jun 15 23:29:29 2009 +0000 gitignore-20090615 LICENSE IPL10 make gitignore files commit 3e26e46b660f2e92eb9c693f9a3c4f97f2acd80c Author: Jeffrey Altman Date: Mon Jun 15 14:47:00 2009 +0000 windows-installer-nsis-20090615 LICENSE MIT reorder some operations and make sure that directories are created before the installer attempts to generate files into them. commit a79ce67d7a52a99c10192a92c66a7e10500770bf Author: Jeffrey Altman Date: Mon Jun 15 02:57:17 2009 +0000 windows-callback-handling-20090614 LICENSE MIT Turn SRXAFSCB_InitCallBackState3() into the primary function for processing InitCallBackStateX RPCs. InitCallBackState3 accepts an optional server uuid which can be used instead of the IP address to locate a matching server object. If the RPC comes from a server that we know of, we can restrict the calback state initialization to cm_scache_t objects on that file server. If the request comes from a server that we know nothing about and a uuid was specified, we can ignore it. During callback revocation, make use of the cell associated with the server to restrict the revocation to cm_scache_t objects in the one cell. This is especially important for readonly volume callbacks since volume ids are shared across multiple cells. Add a missing case where the cm_volume_t cbExpiresRO time should be set to the cm_scache_t cbExpires time. commit 88ef4fb720efd8f7c0b130b5bdf35ef840aafc59 Author: Jeffrey Altman Date: Mon Jun 15 02:02:59 2009 +0000 windows-server-find-by-uuid-20090614 LICENSE MIT Add cm_FindServerByUuid(). This function is similar to cm_FindServerByIP() but uses the server's known uuid instead which is constant across multi- homed systems. commit 571dc5edbe76a7e62d47adee8df52bbf532c55bc Author: Jeffrey Altman Date: Mon Jun 15 01:56:22 2009 +0000 windows-server-xdr-free-20090614 LICENSE MIT when releasing the capabilities memory allocation use xdr_free() not the free() of the afsd_service.exe module. commit a7f9ce9ce1b2608937c5c3ffc73a2de07abc5fb1 Author: Derrick Brashear Date: Thu Jun 11 20:39:53 2009 +0000 vnode-disk-object-name-hi-length-field-20090611 LICENSE IPL10 reserved6 is used for the high portion of the 64 bit length. make the structure reflect it. commit 27cbb188bd1cb3e050c6911b1ddde75c46aa712f Author: Andrew Deason Date: Thu Jun 11 15:25:15 2009 +0000 dafs-create-volumes-online-20090611 LICENSE IPL10 FIXES 124492 newly created volumes were not marked "not in use" by the volserver, so the fileserver would not take them. fix it. commit 2c755529c79492738fec61a5fc311216678a52e7 Author: Andrew Deason Date: Thu Jun 11 15:19:15 2009 +0000 bosserver-invoke-salvager-fully-specifying-force-20090611 LICENSE IPL10 FIXES 124916 bos salvage can invoke salvager with -f (instead of -force) which is no longer unique. fix that. commit ae1923e36260ff59efb85dda99b5345341bff6d8 Author: Jeffrey Altman Date: Wed Jun 10 18:08:19 2009 +0000 windows-cache-validation-20090610 LICENSE MIT correct cell validation to avoid false detection of infinite loops if a cm_cell_t object had to be freed. add newlines to output of volumeHashTableSize and cellHashTableSize commit 796dbb891b9aee17cef07e085e089123e6c94b83 Author: Derrick Brashear Date: Tue Jun 9 22:34:54 2009 +0000 aix-dest-make-audit-object-dir-20090609 LICENSE IPL10 now make dest works on aix 6 again commit e87be8c5794ccd6eecd3b420dc12085a3608fadb Author: Derrick Brashear Date: Tue Jun 9 22:30:28 2009 +0000 aix6-no-vprintf-but-strict-kernel-prototypes-20090609 LICENSE IPL10 alas, we can't use varargs style prototypes since we can't handle the args! commit 2ee2aa00bc689b7876dc589537a8f805d44eaef5 Author: Derrick Brashear Date: Tue Jun 9 22:10:54 2009 +0000 excise-cplusplus-comments-from-kernel-20090609 LICENSE IPL10 aix6 compiler doesn't allow // style comments commit 6794613924416dd542a1d54a9d692af396a0f0d9 Author: Derrick Brashear Date: Tue Jun 9 22:05:20 2009 +0000 aix6-kernel-varargs-prototypes-ok-20090609 LICENSE IPL10 varargs style prototypes are ok in the aix6 kernel env commit 37e1cd23195215cd5999be7fa5a8de6af7efebcb Author: Jeffrey Altman Date: Tue Jun 9 21:11:04 2009 +0000 windows-freelance-default-cell-20090609 LICENSE MIT If a freelance mount point does not specify a cell name, default to the workstation cell. commit 22fb6954e05de91d414cf17db07322824a090db3 Author: Derrick Brashear Date: Tue Jun 9 20:25:47 2009 +0000 aix6-tsm41-makefile-flub-20090609 LICENSE IPL10 add missing quoting commit a8614747878cedef5e54f10dcc7296034a88e738 Author: Derrick Brashear Date: Tue Jun 9 14:46:51 2009 +0000 tsm41-makefile-fix-20090609 LICENSE IPL10 fix form of case statement in makefile for tsm41 commit 2033fa9ec62089887f074381ac118a2c60e9c311 Author: Jeffrey Altman Date: Tue Jun 9 00:58:10 2009 +0000 windows-dirty-buffers-20090608 LICENSE MIT In the buf_IncrSync thread, if the volume is known to be unavailable do not attempt to write the buffer. Just skip it. In buf_Sync(), if we are shutting down and a buffer is left dirty, log a message to the Windows Event Log indicating that the dirty buffer was lost. commit 394243f3ae2dc5437b66d8f5afb393c2cfd1fb7b Author: Mike Meffie Date: Mon Jun 8 23:39:51 2009 +0000 man-page-xstat-fs-test-20090608 LICENSE IPL10 FIXES 124905 Document xstat_fs_test collection 3, which returns callback statistics from the file server (useful for tuning). commit f5b74d9fbcc42ad3a1105df3363e6c22c16fee84 Author: Jeffrey Altman Date: Mon Jun 8 23:09:19 2009 +0000 windows-cell-locking-20090608 LICENSE MIT FIXES 124910 cm_cellLock protects the cm_cell_t fields allNextp, nameNextp, idNextp, and freeNextp. Therefore, a write lock must be obtained whenever those items may change. This patch makes that consistent. This patch also fixes an out of order lock acquisition and removes cm_cell_t objects from the id and name hash tables before freeing them. commit 7bf6fd6bcbdcb87544798c9634618fccb4678f45 Author: Jeffrey Altman Date: Mon Jun 8 22:42:01 2009 +0000 windows-search-cell-registry-20090608 LICENSE MIT do not clear the newCellNamep buffer on error. that is inconsistent with the other SearchCell functions and breaks "fs newcell". commit ddaf2d5de4b41e2d15ac8f715774d9a3bceff6e6 Author: Derrick Brashear Date: Mon Jun 8 20:47:14 2009 +0000 aix-kopenafs-also-correct-directory-20090608 LICENSE IPL10 also make this include syscall.s from the right place. commit e3b4b25d4f1dd15579cb15a2088fff0ea94606f9 Author: Derrick Brashear Date: Mon Jun 8 05:44:23 2009 +0000 kopenafs-set-sflags-20090607 LICENSE IPL10 make kopenafs build on aix commit dad31c8ca57d56a8856718d43d04f2c9fe30dba0 Author: Jeffrey Altman Date: Mon Jun 8 03:34:28 2009 +0000 windows-notes-20090607 LICENSE MIT synchronize with the 1.5 branch commit 9a1328b9217902439abdbd3424fdd4e887169116 Author: Jeffrey Altman Date: Mon Jun 8 03:15:12 2009 +0000 windows-sync-head-with-1_5-20090607 LICENSE MIT Synchronize the build system from 1.5 branch to the head commit 5bd88cfa6b41b9aa92def74894133a84d2a417d7 Author: Jeffrey Altman Date: Mon Jun 8 03:08:33 2009 +0000 doc-man-pages-windows-20090607 LICENSE MIT dpass and package docs removed from repository. do not attempt to build them. commit bada49cff904c1e783ca9fa81a92036ceae7378d Author: Jeffrey Altman Date: Mon Jun 8 02:22:09 2009 +0000 windows-buf-infinite-looping-on-dirty-buffers-20090607 LICENSE MIT If there are dirty buffers when the file server becomes unresponsive, the cache manager will attempt to write them repeatedly resulting in use of 100% of the cpu of the machine until the file server becomes responsive. This patch reduces the cpu utilization by ensuring that only the first in a list of buffers on the same file needs to fail with timed out, all down, all busy, all offline, or clock skew. The other dirty buffers will just be skipped. A small delay is enforced in the buf_IncrSync thread between invocation. This patch is not a complete fix for the problem. The buf_IncrSync thread needs to become more intelligent in order to avoid attempts to write to volumes that are known to be inaccessible. commit d5d6976a640e5dbdd4eb3be24e8722d77ad30488 Author: Derrick Brashear Date: Sat Jun 6 01:10:46 2009 +0000 viced-cblater-unmark-20090605 LICENSE IPL10 make things match 1.5.x: unmark entries FE_LATER when they get unchained commit 575d48538fa9da54fe7b68e2e4c3ec228cd98da5 Author: Derrick Brashear Date: Sat Jun 6 01:08:57 2009 +0000 darwin-rx-netreceive-fix-20090605 LICENSE IPL10 put back code that went missing post-rxtcp commit 527c48861132d5d9a314ba12935f796bc397cac1 Author: Derrick Brashear Date: Sat Jun 6 00:36:20 2009 +0000 aix-kopenafs-cpp-20090605 LICENSE IPL10 build syscall.o on aix the same way we do in libsys commit 6d973e499acd598bbc3a4e131d14f9801b94fe71 Author: Derrick Brashear Date: Fri Jun 5 19:17:13 2009 +0000 man-page-cellservdb-extras-20090605 LICENSE IPL10 Document linked cells and non-voting replicas in the CellServDB man page and note the need for better linked cell documentation. commit ee2d4a858b56b5fa9d6155be6ecc64d7596dcf16 Author: Derrick Brashear Date: Fri Jun 5 16:50:10 2009 +0000 death-to-docs-20090605 LICENSE IPL10 docs now built from doc/xml; kill the other copies of same commit 3e65e3aee17c64a19c0a1ff4b9b7d99c0725b689 Author: Derrick Brashear Date: Thu Jun 4 23:09:11 2009 +0000 fsbnode-rename-unused-to-dummy-20090604 LICENSE IPL10 a prayer this will make hpu cc stop segving commit 33e04c09a1f36281a6f37fdfd7b402426b9df5d4 Author: Derrick Brashear Date: Thu Jun 4 21:50:33 2009 +0000 aix51-no-userspace-pag-subsystem-20090604 LICENSE IPL10 getpagvalue() appeared post 5.1. commit 654871583371f70683a295623fdd4364965042c4 Author: Derrick Brashear Date: Thu Jun 4 21:30:45 2009 +0000 pam-build-dont-fail-on-link-problems-20090604 LICENSE IPL10 linking static objects into shared works badly on some platforms. deal by not breaking the build, for now commit 17ccfb4fa5889c45ddaf8e18fd048c0aaaed8d86 Author: Derrick Brashear Date: Thu Jun 4 19:05:40 2009 +0000 solaris-fs-conv-needs-ihandle-20090604 LICENSE IPL10 FD_t defined in ihandle.h; include it here commit 72d314f001e0067a7a00d3cb2a4d5ff073b54f70 Author: Derrick Brashear Date: Thu Jun 4 17:18:07 2009 +0000 kopenafs-syscall-object-dependency-20090604 LICENSE IPL10 cause syscall.o to build commit 64a1b3101fde534f10054f9f4890243c95e2c728 Author: Derrick Brashear Date: Thu Jun 4 00:15:05 2009 +0000 unroll-experimental-rx-20090603 LICENSE IPL10 reconverge Rx with that in 1.5.x in prep for git commit 6124a81e791f54953ea4be3cf3588d9ccf5fb248 Author: Andrew Deason Date: Wed Jun 3 23:11:40 2009 +0000 ptserver-debug-flag-20090603 LICENSE IPL10 FIXES 124893 parse -d (debug) earlier in the ptserver argument parsing, so database switch does not override it. commit d9d50fea986569dfaa3c3b6aee2e8c99f0d280e8 Author: Andrew Deason Date: Wed Jun 3 22:48:55 2009 +0000 ptserver-procs-loglevels-20090603 LICENSE IPL10 FIXES 124894 make loglevels for create/delete match those for other pts operations commit 4310874d8f8b83b8a2c5840880d4f35059c67ea7 Author: Andrew Deason Date: Wed Jun 3 22:43:53 2009 +0000 ptserver-vicelog-missing-newlines-20090603 LICENSE IPL10 FIXES 124894 some ViceLog calls in ptserver were missing newlines. that's fixed. commit edfb415915bff06c055f58867695cbb37df626e1 Author: Douglas Engert Date: Wed Jun 3 21:58:10 2009 +0000 klog-krb5-avoid-freeing-garbage-20090603 LICENSE IPL10 avoid freeing garbage due to an uninitialized variable commit ec51165b5134b406eecfbb2b7d53b2a094f30256 Author: Derrick Brashear Date: Wed Jun 3 16:13:26 2009 +0000 aix-pag-complaints-20090603 LICENSE IPL10 make the new code work properly, thanks to aix's complaints commit 4af75fe96a9e4a985081d4af78439aeebabd6939 Author: Derrick Brashear Date: Wed Jun 3 06:39:47 2009 +0000 curpag-via-pioctl-20090603 LICENSE IPL10 FIXES 124709 curpag needs to know about kernel constructs (getpagvalue on AIX, onegroup versus two group on linux) and on aix 5.1 simply can't work. add a new pioctl and use it to simply ask the kernel what the current pag is commit 091139b3e2160e1f56b11820d59589de9ccd9c40 Author: Simon Wilkinson Date: Tue Jun 2 19:31:45 2009 +0000 linux-allow-disabling-syscall-probing-20090602 LICENSE IPL10 give a configure switch to allow disabling syscall probing commit 521f4e6d473335ac8f7f265904bda7840fddad71 Author: Derrick Brashear Date: Tue Jun 2 19:12:10 2009 +0000 linux-locking-brace-fix-20090602 LICENSE IPL10 so regardless of which code branch we choose we work commit be47f4de0595dd044053695de3cdcedb2ec2a113 Author: Derrick Brashear Date: Tue Jun 2 18:39:28 2009 +0000 vfsck-conditional-for-namei-20090602 LICENSE IPL10 make build fly again on solaris when namei and not inode is in play commit 3ae35e12714bf4759d313086b17ef47bae1d7504 Author: Russ Allbery Date: Tue Jun 2 18:31:32 2009 +0000 doc-man-page-install-variables-20090602 LICENSE BSD We were horribly confused about variables when creating man page symlinks. Be less confused by using variables less. commit e89f90f7f17efc80c984b2858cd85a87f8cdfbf3 Author: simon@sxw.org.uk Date: Tue Jun 2 04:32:08 2009 +0000 auth-cellconfig-overflow-20090601 LICENSE IPL10 FIXES 124891 commit d7b3953a530a49edfed203d59194b3a293ed80b8 Author: Jason Edgecombe Date: Mon Jun 1 23:35:17 2009 +0000 doc-admin-guide-updates-20090601 LICENSE BSD FIXES 124889 Updates to chapter one of the Admin Guide. Remove references to the Authentication Server, add references to a Kerberos server, revise ntpd parts to reflect the fact that OpenAFS doesn't ship ntpd, and removed the distinction between the US and non-US versions of the Update Server. commit e34fe0f9a85c0fa965fe30ead4c5ba14d077268f Author: Russ Allbery Date: Mon Jun 1 23:31:47 2009 +0000 doc-xml-build-cvsignore-20090601 LICENSE BSD Ignore new generated files from the documentation build. commit 2520cc9aabef8877cdd99abb858dc011dfa5629f Author: Russ Allbery Date: Mon Jun 1 23:30:42 2009 +0000 doc-xml-version-depends-20090601 LICENSE BSD Make PDF manual generation also depend on version.xml, matching HTML generation. commit 0a617e33234f6104fdfb0d45593cf313c961f653 Author: Derrick Brashear Date: Mon Jun 1 18:51:45 2009 +0000 xml-versioning-take-two-20090601 LICENSE IPL10 deal with this in a way which does not trip creation of CML state config files commit 8e0b8243ea8b38e6ceab8f1dc6a0e032d6622568 Author: Simon Wilkinson Date: Mon Jun 1 00:12:46 2009 +0000 vsprocs-log-format-bug-20090531 LICENSE IPL10 fix the logged data to avoid a format string issue commit 5526ba218f7f3653cabe5423b25b82f0241b0abc Author: Jeffrey Altman Date: Sun May 31 17:52:46 2009 +0000 doc-doxygen-20090531 LICENSE BSD Doxygen converted versions of the IBM provided architecture and protocol documentation. Funded under an SBIR grant. commit 74df876dafb9cf80ab5a8099b4202f2205bd9791 Author: Douglas Engert Date: Sun May 31 02:22:24 2009 +0000 afsd-allow-maxmtu-override-20090530 LICENSE IPL10 FIXES 124880 rxi_Findcbi, rxi_FIndIfnet, rxi_FindIfMTU "failure" end up returning the RX_REMOTE_PACKET_SIZE as the mtu to use unless we allow our override to apply, so we do that. then, add an afsd switch to allow setting it. afsd man page update required and will follow. ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE IPL10 FIXES 124880 man page update to document previous work commit ca613599a2537756462a420ae1a632747a433226 Author: Jeffrey Altman Date: Sat May 30 18:27:07 2009 +0000 viced-host-uuid-and-addr-hashing-corrections-20090530 LICENSE IPL10 FIXES 124634 only valid addr/port pairs are registered in the hash table. add then remove when changing addresses. make host restoral properly hash hosts. remove should remove the address we asked for and not simply the primary address. commit e452c704c59700496227dccb3161efd34ca709ba Author: Derrick Brashear Date: Wed May 27 20:44:24 2009 +0000 xml-doc-building-glue-20090527 LICENSE IPL10 FIXES 124804 add configure switches for building docs. generate version files needed. commit d28e5fd04def989dcfb98ccd2b99ef44f5667167 Author: Jeffrey Altman Date: Wed May 27 14:55:42 2009 +0000 windows-install-20090527 LICENSE MIT Install ptclient.exe and pt_util.exe as part of the server installation commit c1876dbf32b5c253b5325bf18a0bf2549b6c9682 Author: Jeffrey Altman Date: Wed May 27 14:45:07 2009 +0000 windows-ptserver-ubik-20090527 LICENSE MIT move io.h inside AFS_NT40_ENV commit ea404cf1e3a174c8809cd7f3bcc5750e0983cce6 Author: Matt Benjamin Date: Wed May 27 14:26:41 2009 +0000 obsd-45-param-file-20090527 LICENSE IPL10 FIXES 124719 add missing param file for obsd 4.5 commit 39b4c0381a68824cb52c0d3a2ee1d81851598373 Author: Jeffrey Altman Date: Wed May 27 08:04:06 2009 +0000 windows-pt_util-20090527 LICENSE MIT add missing build rules for pt_util.exe commit 8ea8519f3094692c2d7a55fb1702255d0b115a8f Author: Jeffrey Altman Date: Wed May 27 07:59:36 2009 +0000 windows-pt_util-20090526 LICENSE MIT build pt_util.exe on Windows commit 34fc86bcc749f3bd059831b7e5dae03dc09a9393 Author: Derrick Brashear Date: Wed May 27 03:46:43 2009 +0000 volser-retry-transaction-creation-20090526 LICENSE IPL10 FIXES 124635 version of the retry transaction creation patch for head/1.5 commit 29223f5a52beac5b40853863733c70028fc7c52c Author: Derrick Brashear Date: Wed May 27 03:12:53 2009 +0000 unix-mkvers-xml-20090526 LICENSE IPL10 make mkvers do a xml version file for unix also commit 4c7a7f343c6cb0c5e6def6d28649cea65ff2907e Author: Russ Allbery Date: Wed May 27 02:21:45 2009 +0000 man-page-vos-dump-flags-20090526 LICENSE BSD Add documentation of the -clone and -omitdirs flags to vos dump. commit 49b7bbdd3b45df694fadbef48f9ed99d9bfe07b9 Author: Simon Wilkinson Date: Wed May 27 01:47:40 2009 +0000 linux-byte-range-locks-sensibility-20090526 LICENSE IPL10 FIXES 124766 make our locks work correctly with the linux connectathon lock testing commit 3b2a1ac2b1d4212363527a6edc6dd2aa76a3f960 Author: fabrizio.manfredi@gmail.com Date: Wed May 27 01:13:38 2009 +0000 java-errno-header-20090526 LICENSE IPL10 FIXES 124810 use the errno header instead of assuming extern int commit 1fb1b8d0a2f82c6e72e59afb0a400ea0d5b21fe1 Author: Russ Allbery Date: Wed May 27 00:44:29 2009 +0000 linux-mmap-antirecursion-avoid-spurious-eio-20090526 LICENSE IPL10 fix error code checking commit e754a0bebdeaa5bd8acfdb5d802392715e38fd5b Author: Jeffrey Altman Date: Tue May 26 16:29:16 2009 +0000 doc-xml-windows-release-notes-20090526 LICENSE MIT Add notes describing registry support for CellServDB info and conversion of docs to HtmlHelp format. commit 582688f1be17611d2926a4a7281d55bc7ccaa611 Author: Jeffrey Altman Date: Tue May 26 03:20:06 2009 +0000 windows-xml-release-notes-version-20090525 LICENSE MIT autogenerate version info. fix chapter title. commit 2f7046eff6599d9a66a7f31bb6f33b7f88646db5 Author: Jeffrey Altman Date: Tue May 26 01:54:15 2009 +0000 windows-top-makefile-20090525 LICENSE MIT add rules for building documentation sources add option for including cygwin libs in wix installer commit 4a523957feabf7f5d9f36b7a05c79fd6eccf426e Author: Jeffrey Altman Date: Tue May 26 00:53:53 2009 +0000 windows-doc-man-dependency-20090525 LICENSE IPL10 html\index.html not index.html commit 22a932c40a3ecabae8110db21572a4cae2ba1fae Author: Jeffrey Altman Date: Mon May 25 23:06:16 2009 +0000 windows-cellservdb-lookup-20090525 LICENSE MIT Add a new Registry distribution method for CellServDB info. The CellServDB registry schema is as follows: HKLM\SOFTWARE\OpenAFS\Client\CellServDB\[cellname]\ "LinkedCell" REG_SZ "[cellname]" "Description" REG_SZ "[comment]" "ForceDNS" DWORD {0,1} HKLM\SOFTWARE\OpenAFS\Client\CellServDB\[cellname]\[servername]\ "HostName" REG_SZ "[hostname]" "IPv4Address" REG_SZ "[address]" "IPv6Address" REG_SZ "[address]" "Comment" REG_SZ "[comment]" "Rank" DWORD "0..65535" "Clone" DWORD "{0,1}" "vlserver" DWORD "7003" "ptserver" DWORD ... ForceDNS is implied non-zero if there are no [servername] keys under the [cellname] key. Otherwise, ForceDNS is zero. If [servername] keys are specified and none of them evaluate to a valid server configuration, the return code is success. This prevents failover to the CellServDB file or DNS. Registry distributed info takes precedence over the CellServDB file. Registry support has been added to both the Windows specific cm_config interface and the auth/cellconfig interface utilized by aklog, the services, and the vast majority of support commands. Enhance the DNS lookup for Cell vlserver info to support ranking info which is used with _vlserver._udp SRV record lookups when AFSDB records are not present. Priorities become ranks. commit c8ccb887882bc4affef02a8193e9b1ed01f885f5 Author: Jeffrey Altman Date: Mon May 25 22:30:24 2009 +0000 windows-libafsconf-20090525 LICENSE MIT libafsconf.dll has been present since OpenAFS 1.0. However, for some unknown reason the components that it consists of (cm_dns.obj, cm_config.obj, cm_nls.obj) have been staticly linked into exes and dlls all over the code base. This commit removes all of the static references and replaces them with libafsconf.lib. libafsconf.dll is also moved from Client\Program to Common because it is now linked to by server and utility components. commit d8410b56c895830d609846aec56d61dfd2efb897 Author: Jeffrey Altman Date: Mon May 25 21:00:18 2009 +0000 windows-doc-man-makefile-20090525 LICENSE IPL10 Add a proper dependency list so that the man-pages are not rebuilt when no changes have occurred. commit 20460e1391d87bdedbf1b84e233ffd5b926b5df8 Author: Jeffrey Altman Date: Mon May 25 20:57:39 2009 +0000 windows-make-version-20090525 LICENSE IPL10 remove space before "KEEP". older versions of nmake.exe do not like it. commit a31fd7f70f0049a180e5b02202941d3b1266c1f8 Author: Jeffrey Altman Date: Fri May 22 17:00:33 2009 +0000 windows-btree-flush-race-20090522 LICENSE MIT FIXES 124787 A flush operation on a directory will result in the btree being destroyed. This can race with on-going operations. Make sure that the dirlock is held if the btree is destroyed. Otherwise, just invalidate the btree version number. ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE MIT FIXES 124787 correct sandbox leakage commit 12e85227c5dbfdb1258718ee3360bffacc4f96ac Author: Derrick Brashear Date: Fri May 22 17:00:26 2009 +0000 background-fsync-consistency-issues-20090522 LICENSE IPL10 FIXES 124359 avoid either reopening closed vnodes and leaving cached descriptors around, or discarding a reference we're not holding; instead, sync changes when the fd is closed, and note such has been done; otherwise, no changes from older code. commit 556597af26150041e3b44ec2769ec6c962ab06db Author: Asanka Herath Date: Thu May 21 19:08:23 2009 +0000 windows-install-wix-vs2008-20090521 LICENSE MIT add merge modules for VS2008 RunTime Libraries commit 32ddb143388bb5d6bbcc1f3afc5860f0566de81c Author: Jeffrey Altman Date: Thu May 21 19:06:08 2009 +0000 windows-install-wix-doc-xml-20090521 LICENSE MIT replace static html documentation with auto-generated html help files from doc/xml/... when building en_US locale. commit e4b36071ef35b73fb68db6c054e811ba7e6b65e0 Author: Jeffrey Altman Date: Thu May 21 18:51:42 2009 +0000 doc-xml-version-generation-20090521 LICENSE MIT Replace version info in the DocBook files with a new ENTITY "version" associated with a local "version.xml" file which contain a tag for the current release. The version.xml file should be autogenerated by the Makefile system. commit da5794d9caa47e96679c197610bd8ea2a682c338 Author: Jeffrey Altman Date: Thu May 21 18:25:50 2009 +0000 config-mkvers-xml-20090521 LICENSE IPL10 Add a -x option to mkvers.c to permit generation of XML entities containing a revision tag and tags for each delta Add autogeneration of version.xml to Windows Makefiles commit 278f8a18305b376e1c764bb38dc0e69ba5b246e5 Author: Jeffrey Altman Date: Thu May 21 14:33:47 2009 +0000 windows-install-nsis-20090521 LICENSE MIT Remove old documentation and start menu links before installing new versions. No longer install versions from src/WINNT/doc/install/... tree Install versions from doc/xml/... Use CHM files when available. Construct new Start Menu/Program/OpenAFS/Documentation/ menu with links to individual documents instead of using an index.html top level link. commit 716c81782eae719b43b3b90464b821b398a0f9a6 Author: Asanka Herath Date: Thu May 21 04:25:46 2009 +0000 windows-make-cygwin-libs-20090520 LICENSE MIT added libosi.a and libafsconf.a commit 4e9bd3bd0ec5977609fd75d681fcc6dbd24a8c6f Author: Asanka Herath Date: Wed May 20 06:03:09 2009 +0000 windows-make-cygwin-libs-20090519 LICENSE MIT Unless NOCYGWIN is defined create cygwin .a import libraries for each OpenAFS DLL that is constructed. commit 85a10ffc9385240818ff9a968f308ac31ee03348 Author: Jeffrey Altman Date: Wed May 20 05:53:57 2009 +0000 doc-xml-windows-20090519 LICENSE IPL10 remove references to xml files no longer in the repository commit 6cc155e8da8f505443f43a312a522a64c52515e8 Author: Derrick Brashear Date: Tue May 19 19:40:09 2009 +0000 krb-conf-manpage-path-fix-20090519 LICENSE IPL10 fix path to krb.conf, per IRC discussion commit 7b56f2ebfc8c2e1695e007798833ad2053e08113 Author: Russ Allbery Date: Tue May 19 04:58:53 2009 +0000 doc-xml-build-20090518 LICENSE MIT Standardize the UNIX Makefiles for all of the DocBook guides. Remove the rest of the generated files and switch to xsltproc and dblatex for the document generation in all cases. Fix a few DocBook errors by removing the contents of the tag and removing the unknown tag in the field. commit 74585aa5003cfb42103ac8d6059137eebd2005e0 Author: Russ Allbery Date: Tue May 19 04:27:36 2009 +0000 doc-quick-start-unix-build-20090518 LICENSE MIT Use dblatex to build PDF documentation instead of docbook2html and xsltproc to build HTML instead of docbook2html. Remove all the index generation logic, since dblatex and xsltproc handle that automatically. Remove the contents of the tag in the source, since neither program requires there be anything in there. Remove the style sheets and configuration that were used for docbook2*. commit 8f2a8edb2aec01226d18feae71643e856bbd6470 Author: Jeffrey Altman Date: Tue May 19 03:36:21 2009 +0000 windows-wix-new-man-pages-20090518 LICENSE MIT FIXES 124800 pod1/compile_et.pod pod1/copyauth.pod pod1/fs_cscpolicy.pod pod1/fs_getfid.pod pod1/fs_memdump.pod pod1/fs_monitor.pod pod1/fs_rxstatproc.pod pod1/fs_setcbaddr.pod pod1/fs_trace.pod pod8/rmtsysd.pod pod8/vsys.pod commit 9ad6c37ccfec016df9e845972ae626a1da19dfbf Author: Russ Allbery Date: Tue May 19 00:53:26 2009 +0000 man-page-syntax-errors-20090518 LICENSE BSD Fix some man page syntax errors that snuck into the recent round of updates. commit 798ffe54af1f5798bf07947439fc62946bc2f07e Author: Steven Jenkins Date: Mon May 18 23:22:29 2009 +0000 man-page-krb-varients-20090518 FIXES 124799 LICENSE IPL10 Install symlinks for the *.krb versions of klog, pagsh, and tokens to the non-krb versions and add information about the *.krb versions to the non-krb man pages. commit 6df60468130977744fea0499fba2351ef74175d8 Author: Steven Jenkins Date: Mon May 18 21:42:26 2009 +0000 man-page-cellservdb-updates-20090518 FIXES 124794 LICENSE IPL10 Note in CellServDB man page that it's also used to populate root.afs for a -dynroot client. Also document the dynamic lookup of database servers with -afsdb and provide some more information about when CellServDB has to contain the cell and when it doesn't. Mark the backup server as optional, and indicate that the authentication server is deprecated and CellServDB isn't required for authentication if Kerberos v5 and aklog are used. commit 1df9282985949b38313f05640d9afd05948f45c4 Author: Steven Jenkins Date: Mon May 18 21:28:26 2009 +0000 man-page-vsys-20090518 LICENSE BSD FIXES 124793 Add man page for vsys. commit 921774594faead45f9432af218c5f9f394a03204 Author: Steven Jenkins Date: Mon May 18 21:22:04 2009 +0000 man-page-rmtsysd-20090518 LICENSE IPL10 FIXES 124792 New man page for rmtsysd. commit 97b0d230145c4c5f58ef785b11bf2d201ded2d26 Author: Steven Jenkins Date: Mon May 18 19:46:33 2009 +0000 man-page-restorevol-20090518 LICENSE IPL10 FIXES 124791 Add man page for restorevol. commit 01ba5ab1ed24d14c1068d5dac951cbea1befba10 Author: Steven Jenkins Date: Mon May 18 19:35:31 2009 +0000 man-page-fs-monitor-20090518 LICENSE IPL10 FIXES 124790 Add man page for fs monitor. commit a7a80efd577d9f2a9573fe35c12ca30b59e2f375 Author: Steven Jenkins Date: Mon May 18 19:32:06 2009 +0000 man-page-copyauth-20090518 FIXES 124789 LICENSE IPL10 Add man page for copyauth. commit 16ec87e0b382bc8bca14ec6a70987f54899eea7f Author: Steven Jenkins Date: Mon May 18 19:28:05 2009 +0000 man-page-compile-et-20090518 LICENSE IPL10 FIXES 124788 Add man page for compile_et. commit faf518ace7c8c0ec9c3269afd267afd276d69cd4 Author: Mike Robinson Date: Mon May 18 04:34:38 2009 +0000 man-page-yet-more-fs-commands-20090517 LICENSE IPL10 FIXES 109189 Add new man pages for fs rxstatproc, fs setcbaddr, and fs trace. Also updates the links from fs to its subsidiary man pages and fixes the fs rxstatpeer man page a bit to mirror fs rxstatproc. commit 32c93cf55210809de92e81428bff784b07a58d44 Author: Steven Jenkins Date: Mon May 18 03:50:00 2009 +0000 man-page-more-fs-commands-20090517 LICENSE IPL10 FIXES 124756 Add man pages for fs cscpolicy, fs getfid, and fs memdump. commit d5c2efa499fdef6811e40e79a041a43761b3d208 Author: Simon Wilkinson Date: Fri May 15 14:30:07 2009 +0000 man-pod-fileserver-20090515 LICENSE IPL10 FIXES 124778 -L sets the max number of threads commit b41d124409589e2890dea60963db4dc158f4d19c Author: Jeffrey Altman Date: Fri May 15 13:30:06 2009 +0000 printf-format-macros-20090515 LICENSE IPL10 FIXES 124776 The Windows format macro for AFS_INT64_FMT was wrong. It is "I64" not "l64". Also added macros for AFS_SIZET_FMT. Although not currently in use. size_t varies in size on Windows just like pointers. commit 1f07c903055c54fb7f0a584e88cfc1c289a161c6 Author: Derrick Brashear Date: Thu May 14 21:50:44 2009 +0000 vol-split-no-nearinode-hint-for-namei-20090514 LICENSE IPL10 nearinode hint makes no sense when you're not using inode fileserver commit fb985eefcea791ae16610c210f1ca5408b8ed62f Author: Jeffrey Altman Date: Thu May 14 18:47:44 2009 +0000 doc-xml-release-notes-windows-20090514 LICENSE MIT Initial take at converting the OpenAFS for Windows Release Notes to DocBook. Website style HTML and HtmlHelp (.chm) output is generated. Formatting of Registry Value descriptions could be improved. There is no indexing at present. commit 8a2fcaa8f45c36a80c574a7e903e71041bbd53cc Author: Derrick Brashear Date: Thu May 14 05:05:29 2009 +0000 cfileopen-cleanup-20090514 LICENSE IPL10 make disconnected work again. also, use static_inline macro consistently commit 9e8e080a5c1281dfa6109700cacd13cd1c44f5ef Author: Jeffrey Altman Date: Thu May 14 03:25:35 2009 +0000 doc-xml-20090513 LICENSE IPL10 FIXES 124760 Remove generated HTML from the respository Update XML to support autogeneration of Index files via XSLT Add graphics referenced by generated HTML output Add top level index.html used by the docs.openafs.org web site. Add NTMakefile for AdminGuide, QuickStartUnix, and UserGuide that utilizes XSLT to generate Windows HTMLHelp (.CHM) and website appropriate HTML output. In AdminGuide and UserGuide, relabel the documentation as OpenAFS instead of IBM AFS. Create a new revision entry for the OpenAFS docs. Incorporate updates to QuickStartUnix Appendix A commit 070f02923cfa4e01ccb754928cdd4d02bec48720 Author: Derrick Brashear Date: Wed May 13 22:34:56 2009 +0000 ukernel-use-fsblkcnt-20090513 LICENSE IPL10 FIXES 124681 blkcnt_t doesn't exist on fbsd, macos 10.3, and isn't really the right type. this is the right type, but also can be missing. test appropriately. commit 2c0bf1c881f34554472982df2b74c50c4eeb7dcd Author: Marc Dionne Date: Wed May 13 21:40:56 2009 +0000 mmap-antirecursion-port-to-head-20090513 LICENSE IPL10 FIXES 124770 deal correctly with the structure reorg which took place commit 6ba44802ea6cf722c22a4784cbbad70ed6f5d60a Author: Derrick Brashear Date: Tue May 12 20:40:20 2009 +0000 pts-encrypt-option-20090512 LICENSE IPL10 FIXES 124681 add -encrypt flag to pts generic options, allowing the wire to be encrypted if desired and the user's authenticated. document same. commit 5e0e1ea2540d0cb7d7274350eb1fadfd41733ea4 Author: Felix Frank Date: Tue May 12 18:56:30 2009 +0000 linux-mmap-antirecursion-fix-20090512 LICENSE IPL10 FIXES 124627 fix the mmap anti-recursion protection to set and mask CPageWrite appropriately and with the correct lock protection. this leaves us with an issue to handle when the mmap'd file is larger (possibly considerably larger) than the cache commit 3b6bf1a05730b6383d1cef4516b94a63e802521b Author: Matt Benjamin Date: Tue May 12 18:18:37 2009 +0000 freebsd-kauth-sig-t-20090512 LICENSE IPL10 FIXES 124569 define the old signal type as sig_t on freebsd (e.g. everywhere we prototype as sig_t) commit b967654434f4d24b50dbc96e0296d2c632f76ea3 Author: Rainer Toebbicke Date: Tue May 12 18:12:20 2009 +0000 rxdebug-print-values-unsigned-20090512 LICENSE IPL10 FIXES 124563 for the values which are unsigned, use %u, not %d commit eb9fff14c7be1b15369c6d1a44426c1c7c82c92e Author: Anders Kaseorg Date: Tue May 12 17:58:27 2009 +0000 redhat-use-postinit-in-initscript-20090512 LICENSE IPL10 FIXES 124552 if a postinit script is defined, use it commit 214ce7c8b488e90301e9f604b6ecc625b7000e62 Author: Felix Frank Date: Tue May 12 17:42:24 2009 +0000 memcache-write-on-laststore-20090512 LICENSE IPL10 FIXES 124671 write back dirty pages on last store for memcache, lest we end up unintentionally discarding the changes. commit c6adb0d2f32f8e8f3974b8ea3049601bf01d6877 Author: Steven Jenkins Date: Tue May 12 17:22:49 2009 +0000 tests-generate-dirpath-in-makefile-20090512 LICENSE IPL10 FIXES 124715 fix rmcell to not have hardcoded paths; instead, generate a dirpath shell script from makefile and use that commit c39f38d8c6703a9d1b9967a1bf0901db35e19267 Author: Steven Jenkins Date: Tue May 12 14:06:14 2009 +0000 tests-no-dirpath-infile-20090512 LICENSE IPL10 FIXES 124716 Dirpath.pm.in is no longer needed commit 4b9283a30db0c3aee943c94573b412f24894d366 Author: Matt Benjamin Date: Tue May 12 14:02:38 2009 +0000 openbsd-44-45-20090512 LICENSE IPL10 FIXES 124719 add missing osi_free backend, missing param file, modify soreceive for 4.5 commit 947213da0ee6a0d805f0fc5eaeec0202d0bbffa4 Author: Jeffrey Altman Date: Mon May 11 17:22:24 2009 +0000 windows-dcache-store-data-20090511 LICENSE MIT The windows dcache module synchronizes store data operations in order to prevent multiple simultaneous store data operations against the same file at the same time by multiple threads. This is performed using cm_SyncOp(CM_SCACHESYNC_STOREDATA_EXCL). However, cm_SetupStoreBIOD() was being processed prior to the synchronization. As a result a dirty buffer could be added to two BIOD lists resulting in the same buffer contents being written to the file server twice. This patch moves the cm_SetupStoreBIOD() into the synchronization region. It also adds a new 'locked' parameter to cm_ReleaseBIOD() that indicates whether or not the cm_scache_t object is locked when called. This permits fewer lock state changes to be used in several cases. commit 7d530b9080f6dd4d7f7e4555ed6ce855ff81bcaa Author: Simon Wilkinson Date: Mon May 11 15:54:50 2009 +0000 linux26-defer-cred-changing-20090511 LICENSE IPL10 FIXES 124737 Newer Linux kernels differentiate between the real and effective credentials of a process, and prevent a process's credentials from being change when the effective credentials have been set to a different value. When AFS notices a keyring PAG exists but no group-based PAG does, the attempt to rectify this, if done in a VFS call (which changes effective creds) triggers this issue. We defer the change to the groups to avoid it. commit f5a97a145e09a16a9b2d3ab485f33f520235b7e9 Author: Jeffrey Altman Date: Mon May 11 15:15:35 2009 +0000 windows-hard-and-idle-dead-timeouts-20090511 LICENSE MIT Fix conditional test that assigns value to idleDeadTimeout Modify event log message to indicate timeout could be either a hard or an idle timeout. As described in the source comments, do not retry on a hard or idle timeout. commit 5520747790b599bc10013dc78efb81b5d50a3f52 Author: Jeffrey Altman Date: Mon May 11 15:04:43 2009 +0000 windows-fs-getfid-20090511 LICENSE MIT Implement "fs getfid + [-literal]" on Windows. Same as the first line of output as "fs examine ...". commit 326ffcc108e1db32fa2071b66ac9dbf2321ae71d Author: Marc Dionne Date: Mon May 11 14:39:58 2009 +0000 linux-fh-based-cache-20090511 LICENSE IPL10 FIXES 123620 rework previous fh-based cache support. now allows use of arbitrarily large file handles, and build correctly for UKERNEL. we now just use this if there's no iget, instead of providing a configure switch. because this relies on the somewhat invasive patch from 124184 it is not currently pulled up to 1.4.x commit 8747236d54742c1c2fb8788c1f6aee4e657b3e89 Author: Simon Wilkinson Date: Mon May 11 14:27:42 2009 +0000 abstract-cache-inode-ops-20090511 LICENSE IPL10 FIXES 124184 previous versions had abstract functions for linux (use_fh) and osx/solaris (cache_vnode_path) cache file access, which was contributing to code bloat switch to a union for disk/memory cache objects, and provide functions to convert these into something appropriate for each system commit fd0f1f49f27b5f92547a0d15e23efd3b2e46376d Author: Jeffrey Altman Date: Thu May 7 16:02:53 2009 +0000 windows-fs-path-in-afs-20090507 LICENSE MIT Switch the PathInAfs test to use VIOCGETFID instead of VIOC_GET_CELL_NAME so that the literal option can be used. commit 621719905806a5883be5a17ca1af0d1929b874e3 Author: Jeffrey Altman Date: Thu May 7 15:53:14 2009 +0000 windows-shellext-path-in-afs-20090507 LICENSE MIT FIXES 124742 Change the PathInAfs test to use VIOCGETFID instead of VIOC_GET_CELL_NAME. VIOCGETFID permits a literal test of the specified object. This is needed for testing the validity of a symlink to a msdfs: or non-existent path. Otherwise, the AFS Shell Extension context menu will not be displayed. commit c8ac7d1c499150b3f82a6566e9bbdb7478ddd469 Author: Derrick Brashear Date: Tue May 5 13:30:24 2009 +0000 man-pages-allow-dots-consistent-20090505 LICENSE IPL10 make all server man pages list -allow-dotted-principals (rather than -allow-dotted-principal) commit 5958aa0c4b0a9279a918cda1f37cb7e6c5666d44 Author: Mike Meffie Date: Tue Apr 28 15:37:39 2009 +0000 dafs-vol-offline-20090428 LICENSE IPL10 FIXES 124582 fix a logic error in the dafs vos offline support commit c4006edf4022e4f80cda5afd427d43997299c890 Author: Jeffrey Altman Date: Tue Apr 28 00:37:16 2009 +0000 windows-smb-disable-loopback-check-20090427 LICENSE MIT Now that BackConnectionHostNames can be set each time the smb listener threads are stopped and restarted, we need to make sure that we do not clear the DisableLoopbackCheck value if it was set during the same service session because BackConnectionHostName value changes only take effect on a reboot. commit 8655541d1eb6ea7d935f50d9256e12bf90db5045 Author: Steven Jenkins Date: Tue Apr 28 00:03:35 2009 +0000 rename-residency-from-mrafs-to-osd-20090427 LICENSE IPL10 FIXES 124130 rename mrafs commands into their equivalent osd versions; structures etc are the same. commit 4836fd1e374c30b5e3be72e73b3dbd21c0c98548 Author: Jeffrey Altman Date: Mon Apr 27 21:17:59 2009 +0000 vos-reveal-hidden-cmds-20090427 LICENSE IPL10 vos hides "online", "offline", "delentry -noexecute", and "addsite -valid". All of these are currently documented in the man pages without warning. Reveal them. commit 2f5ac61b0a8775c58536ee954f2208ab88d0b225 Author: Simon Wilkinson Date: Mon Apr 27 20:17:12 2009 +0000 dprintf-rename-20090427 LICENSE IPL10 FIXES 124657 make dprintf be afs_dprintf to fix for fedora 11 and probably others commit 758366c26a0d1b2e97449ab858e15da8cc0d73f0 Author: Jason Edgecombe Date: Mon Apr 27 19:37:25 2009 +0000 netinfo-fake-address-text-20090427 LICENSE IPL10 FIXES 124699 explain fake address support for NetInfo files commit 25f13f38064bf38ed89332b38c53c740475db87d Author: Matt Benjamin Date: Mon Apr 27 19:29:09 2009 +0000 dragonfly-bsd-userland-20090427 LICENSE IPL10 FIXES 124702 add support for dragonflyBSD's userland commit aea52af634dd20c1cff1a6347ac24770ae727328 Author: Marc Dionne Date: Tue Apr 7 17:16:43 2009 +0000 linux-2-6-30-support-for-head-20090407 LICENSE IPL10 FIXES 124592 make proc dir entry owner field only be initialized when it exists commit b4b61821081d809bb3a737f9e23964f4f99b3c58 Author: Jeffrey Altman Date: Tue Apr 7 15:05:30 2009 +0000 windows-smb-registry-config-20090407 LICENSE MIT Move configureBackConnectionHostNames() to smb_StartListeners() so that when the NetbiosName changes while the service is running the new values can be set. Add configureExtendedSMBSessionTimeouts() which configures new SMB functionality added in a Win2003 post-SP2 hot fix. commit 473149653ee3ef0c67510746131e75839846cf38 Author: Derrick Brashear Date: Tue Apr 7 14:00:56 2009 +0000 rx-internal-use-static-inline-macro-20090407 LICENSE IPL10 some platforms can't use "static inline" commit 62bca1123fb471ca1eec58b448fd39f7f797638a Author: Simon Wilkinson Date: Mon Apr 6 23:52:52 2009 +0000 avoid-buffer-overflow-on-rx-fixed-size-array-return-20090402 LICENSE IPL10 FIXES 124579 avoid potentially writing beyond allocated memory if a return is larger than expected commit 160619505de3dbf70f0f0c4a813098113eb42129 Author: Simon Wilkinson Date: Mon Apr 6 23:50:15 2009 +0000 linux-avoid-returning-invalid-pointers-on-error-20090402 LICENSE IPL10 FIXES 124580 avoid returning a positive error as it will look like a pointer. commit 9a0b3da255032f177dfedb650c7a0b65cff24fba Author: Jeffrey Altman Date: Mon Apr 6 22:47:49 2009 +0000 windows-pioctl-subst-unc-20090407 LICENSE MIT Add code to support determining if a drive substitution refers to a UNC path. commit aad7a2c5858a94672db6c23f508e404e236e4142 Author: Jeffrey Altman Date: Mon Apr 6 18:24:48 2009 +0000 windows-smb-trace-20090406 LICENSE MIT include the correct function name in a trace message commit ac199c845e6771c627dfb5e7efc0cdd8c5356df9 Author: Jeffrey Altman Date: Sun Apr 5 13:54:04 2009 +0000 windows-test-torture-stack-overflow-20090405 LICENSE MIT avoid stack overflow. commit 59945d1cb5f14baf9ab0008990079e1dde9a796d Author: Jeffrey Altman Date: Sun Apr 5 06:25:08 2009 +0000 windows-tests-torture-20090405 LICENSE MIT replace the VOLSTAT online test with the PATH_AVAILABILITY online test. We do not care of the volume is offline on the file server if the cache manager has current data to serve. commit ffe04f710b41120f1bbd843c73ee2d95bc179d9c Author: Jeffrey Altman Date: Sat Apr 4 21:16:27 2009 +0000 windows-smb-error-map-20090404 LICENSE MIT For CM_ERROR_BADSHARENAME return BAD_NETWORK_PATH instead of BAD_NETWORK_NAME. The latter refers to the server name and the former to the share name. Returning BAD_NETWORK_NAME will causes the smb redirector to break its connection to \\AFS. For CM_ERROR_ALLOFFLINE and CM_ERROR_ALLDOWN return PATH_NOT_FOUND instead of BAD_NETWORK_PATH. We don't want the smb redirector to tear down all open files just because some volume in the path is inaccessible at the moment. commit 4ecaeaac97a48c36df3866f1f71eb8a95c8f6e51 Author: Simon Wilkinson Date: Sat Apr 4 17:43:42 2009 +0000 linux-key-alloc-no-pointer-arith-20090404 LICENSE IPL10 make the key_alloc configure test work commit f6b4902daeb731eb01de44464476cb0a3edb26b1 Author: Jeffrey Altman Date: Fri Apr 3 03:56:36 2009 +0000 windows-afsd-no-more-ods-20090402 LICENSE MIT Any use of OutputDebugString() in production can result in serious delays in the execution of the thread that issues the call. Remove the last of the unprotected calls within afsd_service. commit fc408da993e753d33336ab408167383a75ed97f0 Author: Jeffrey Altman Date: Thu Apr 2 08:44:51 2009 +0000 windows-rx-xmit-20090402 LICENSE IPL10 permit compilation with Windows SDK v6.0/6.1 which hides previously exposed XP symbols unless _WINNT_WIN32 is at least 0x0501 commit 0700567eef0c52b1b8892454b72c5123fe0514b1 Author: Jeffrey Altman Date: Thu Apr 2 08:40:06 2009 +0000 windows-src-makefile-two-20090402 LICENSE MIT get the i386 case right ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE MIT fixup the @echo again commit 27aedf7a2cfb04f49b6b8f3c9cabc3d6cdb91c78 Author: Jeffrey Altman Date: Thu Apr 2 06:06:44 2009 +0000 windows-src-makefile-20090402 LICENSE MIT remove extraneous echo command output do not attempt to build NSIS target on non-x86 platforms since support is not implemented commit 8673c0de48140b8cd148bf3ea47094968ffbda8b Author: Jeffrey Altman Date: Thu Apr 2 06:04:48 2009 +0000 windows-config-clean-20090402 LICENSE MIT permit "nmake -f ntmakefile clean" to complete on a clean source tree. commit d86247619136d3080eb6be08fd8c077bc2afc68b Author: Asanka Herath Date: Wed Apr 1 23:56:16 2009 +0000 windows-install-loopback-20090401 LICENSE MIT Define INCLUDE variable and reorder binary link order to ensure compatibility with latest WDK/SDK combinations. commit d8a8bfb5c3b49980135b9da26082fa668640ec0f Author: Jeffrey Altman Date: Wed Apr 1 18:36:29 2009 +0000 windows-talocale-20090401 LICENSE MIT perform proper casting to avoid a warning commit 520fef4278bd43073782e1c75f67900f96fa6ddf Author: Jeffrey Altman Date: Wed Apr 1 18:30:29 2009 +0000 windows-afsd-smb-logging-20090401 LICENSE MIT Add more info about the smb request to the log entry that is written to afsd_init.log if the request took longer than 45 seconds to complete. commit 37f582326c1c5d5363a988f7038af0b62d0fb3ea Author: Jeffrey Altman Date: Wed Apr 1 18:29:15 2009 +0000 windows-afsd-priority-class-20090401 LICENSE MIT Change the default priority class for afsd_service.exe to High. This matches the priority class assigned to other system processes that generate requests to afsd_service.exe. Permit the ..\TransarcAFSDaemon\Parameters "PriorityClass" registry value to be used to change the default. commit d7749751df230d919188546106b61bd2dbb8974c Author: Jeffrey Altman Date: Wed Apr 1 17:37:50 2009 +0000 xdr-free-20090401 LICENSE MIT add xdr_free() and export it from afsrpc.dll. This permits applications to free memory allocated within the xdr routines with the same run time library memory management routines as was used to allocate it. This is necessary on Windows to prevent memory corruption. VL_GetAddrsU() is an example where a xdr array is allocated in the library and must be freed by the application. commit 3d81394f9106b187c28e35328676e11b662025c6 Author: Jeffrey Altman Date: Wed Apr 1 17:35:29 2009 +0000 windows-afsd-xdr-free-20090401 LICENSE MIT make use of xdr_free() to release memory allocated within afsrpc.dll. this prevents crashes when the library is built with a different runtime library version than the application. fix signed/unsigned warnings in the same code snippet commit 84871adb4bb3f8d1d50127255da75629e2167977 Author: Derrick Brashear Date: Tue Mar 31 13:41:25 2009 +0000 dynamic-vcache-no-printf-20090331 LICENSE IPL10 no printf in releases commit d0a166bdffce2d2498cab54cc458d9489d05c299 Author: Marc Dionne Date: Tue Mar 31 13:16:17 2009 +0000 linux-2630-maybe-20090331 LICENSE IPL10 FIXES 124560 hopefully support 2.6.30 when it's released commit 07c187c84384635413e6353dc9913a8826f25bb5 Author: Jeffrey Altman Date: Sat Mar 28 23:25:16 2009 +0000 windows-afsd-log-smb-mid-20090328 LICENSE MIT For each SMB transation log the 'mid' field of the smb packet. The 'mid' field can be used as a reference against the mrxsmb request logging for debugging purposes. commit 4bc36a697fffe78cc0ec93cb9cf98772aeadfcb6 Author: Jeffrey Altman Date: Sat Mar 28 23:17:29 2009 +0000 windows-remove-reset-all-vcs-event-20090328 LICENSE MIT remove the smb reset all VCs message. duplicates the reportSessionStartups functionality. commit 27609fe288eb20f30e1f17a709a07468a74372eb Author: Jeffrey Altman Date: Fri Mar 27 17:58:02 2009 +0000 windows-afsd-symlink-20090327 LICENSE MIT Increase max symlink limit to 64 and remove the repeated fid recursion test. Breaks too many things. commit 977674dfb0470de693e5e7700c614c3b68317efa Author: Jeffrey Altman Date: Wed Mar 25 01:15:20 2009 +0000 volser-new-is-special-20090324 LICENSE IPL10 Do not permit the word "new" to be used for a field name as it is special. Our headers get pulled into C++ compilations. commit a523710780d54b27fc61db0fd1a561f789871046 Author: Mike Meffie Date: Fri Mar 27 15:47:23 2009 +0000 uss-kvno-warning-fix-20090327 LICENSE IPL10 FIXES 124220 suppress bogus kvno warning in uss commit 9243308990dc93ef3f42b9d024b9b02568881468 Author: Chaskiel M Grundman Date: Fri Mar 27 15:45:27 2009 +0000 linux-flushpages-call-truncate-inode-pages-after-all-20090327 LICENSE IPL10 in this case we're discarding just the data in case it's stale, so this is correct commit 3fcbdab1889f2674f1229cb551afeafc6f06b66a Author: Garry Zacheiss Date: Fri Mar 27 13:45:49 2009 +0000 bucoord-update-kvno-check-20090327 LICENSE IPL10 update kvno check in bucoord to match what it is elsewhere commit 4ced67ca980218e27aa4033f31a9d238590919d5 Author: Simon Wilkinson Date: Thu Mar 26 23:42:03 2009 +0000 vol-proto-do-not-break-dafs-20090326 LICENSE IPL10 FIXES 12540 Reenable prototype of VolumeExternalName_r for dafs commit 8cc60f4931f1b62c84d0a74d0fbbbfd0ea582a91 Author: Andrew Deason Date: Thu Mar 26 21:33:50 2009 +0000 state-analyzer-usage-20090326 LICENSE IPL10 FIXES 124539 fix usage for state-analyzer commit d4359ad72aee9839ee019165a3fb37c9cfae3b4d Author: Derrick Brashear Date: Thu Mar 26 14:30:13 2009 +0000 return-values-missing-fix-20090326 LICENSE IPL10 FIXES 124194 add return values for functions missing them commit 80494f5096d231e1e032229732f2d94ba569718e Author: Chaskiel M Grundman Date: Wed Mar 25 19:34:38 2009 +0000 cbr-free-what-you-alloc-20090325 LICENSE IPL10 FIXES 124531 dequeue and free items as alloc'd commit 4162ff9d4d733afc788b3c002adc57aac78a3282 Author: Derrick Brashear Date: Tue Mar 24 22:40:05 2009 +0000 shutdown-vcache-avoid-null-deref-20090324 LICENSE IPL10 avoid potential null pointer deref at shutdown commit cc0922c26fcbeebe73d4df422db65a550a9c6bf8 Author: Simon Wilkinson Date: Wed Mar 25 18:42:17 2009 +0000 redhat-spec-update-20090325 LICENSE IPL10 FIXES 123650 install afszcm.cat, update CellServDB commit 78e29484eb67deb8c19e4549eabaa27a3527fcf6 Author: Rainer Toebbicke Date: Wed Mar 25 14:34:38 2009 +0000 copyonwrite-optimization-fix-20090325 LICENSE IPL10 update to do tail case commit db844c458457a0bbcff81e9dbff362784db6958a Author: Jeffrey Altman Date: Tue Mar 24 22:36:09 2009 +0000 vol-split-warnings-no-win-20090324 LICENSE IPL10 remove many warnings disable on Windows since there are missing dependencies in ntops.c commit 5e770d6d18eacd5e4e70dd95853e4f1d99c54df2 Author: Derrick Brashear Date: Tue Mar 24 18:20:23 2009 +0000 volser-split-namei-only-20090324 LICENSE IPL10 make vos split be namei-only commit 1f83528147ee47addd926ae729ee36520d1e82e5 Author: Derrick Brashear Date: Tue Mar 24 17:55:48 2009 +0000 vol-split-nearino-20090324 LICENSE IPL10 add nearInode hint commit 9a697699b487066f04783194771774db42ecfba9 Author: Derrick Brashear Date: Tue Mar 24 14:23:58 2009 +0000 vfsck-needs-fd-t-defn-20090324 LICENSE IPL10 make vfsck build again commit 4df81d17bfbc1e2437883260c350be2631002ec0 Author: Derrick Brashear Date: Tue Mar 24 14:21:56 2009 +0000 volser-prototype-cleanup-20090324 LICENSE IPL10 make prototypes and return values etc match commit ba742892e2102cf545157e9c97df10799a58403e Author: Hartmut Reuter Date: Tue Mar 24 13:36:23 2009 +0000 volserver-split-volume-functionality-20090324 LICENSE IPL10 FIXES 124520 implement the server side of vos split commit 71a73608b1393a5f7f333cb680608d8a1f03a3f6 Author: Derrick Brashear Date: Tue Mar 24 12:43:05 2009 +0000 fssync-enum-syntax-20090324 LICENSE IPL10 no trailing comma commit 63b0d495cfc6362bced7b2492310cf1a0bf684b0 Author: Derrick Brashear Date: Tue Mar 24 04:31:13 2009 +0000 fd-t-definition-fun-20090323 LICENSE IPL10 make FD_t be defined everywhere we need it commit ede1c215d16d394fcd0afb7aacd827680be56cf6 Author: Derrick Brashear Date: Tue Mar 24 03:43:59 2009 +0000 viced-threadnum-return-cast-20090323 LICENSE IPL10 cast return type from threadNum commit a209012f1a3f83959f9df14ebad4aa2b50bacae0 Author: Jeffrey Altman Date: Mon Mar 23 22:47:36 2009 +0000 vol-lock-fd-type-20090323 LICENSE IPL10 the lock_fd field of DiskPartition[64] is a file descriptor. On Windows this is a HANDLE and on *nix platforms an int. OpenAFS uses the FD_t type to provide platform specific type info for file descriptors. Use it for the lock_fd field and the salvageLock in ObtainsSalvageLock(). Finally, the on the wire diskPartition[64] struct in volser/volint.xg also contains a lock_fd field. This is an on the wire field and must be left at a fixed width of 32-bits. Since a file descriptor is not portable across machines we truncate the 64-bit HANDLE value to fit in the 32-bit lock_fd field when necessary. commit aa8d735b8707e2bf9142699fd25034655c821f96 Author: Jeffrey Altman Date: Mon Mar 23 22:42:48 2009 +0000 vol-fssync-server-socket-20090323 LICENSE IPL10 GetHandler() sets up a fdset and returns the max socket fd which is used with select(). Windows ignores the numfd param (first param) of select() and therefore computing the max fd value is meaningless. We can avoid a number of casts by not attempting to treat this value as osi_socket. commit 1d4542f93bae6b59e7d4321c23a2551fa43416ba Author: Jeffrey Altman Date: Mon Mar 23 22:38:16 2009 +0000 libadmin-vos-ihandle-20090323 LICENSE IPL10 include afs/ihandle.h in order to gain access to the FD_t definition commit 4d9f5731c9ec6c50154da9784df0631a65dd9a9d Author: Derrick Brashear Date: Mon Mar 23 19:53:46 2009 +0000 volser-fcn-return-types-20090323 LICENSE IPL10 make internal functions have correct return types commit 3e15ed48d305a5fedb1af552459cf5bbe1b95a40 Author: Derrick Brashear Date: Mon Mar 23 19:39:59 2009 +0000 printf-sanity-args-20090323 LICENSE IPL10 fix type specifier for correct arg commit 62f4c29eef578b7f3df143f3ddd04307d8f2271f Author: Simon Wilkinson Date: Mon Mar 23 19:11:16 2009 +0000 disconnected-put-back-vcaches-we-held-20090323 LICENSE IPL10 if we hold a vcache for shadow, we need to release the ref when we give it up commit ad20213bbba4083160a88c2f65e5e8c8de259266 Author: Simon Wilkinson Date: Mon Mar 23 18:59:53 2009 +0000 disconnected-dont-double-dequeue-shadow-removal-20090323 LICENSE IPL10 FIXES 124496 queue_Remove twice tends to cause things like panics commit 7a7b55658b7c72eef0f9b495f02ce766c9961d6e Author: Derrick Brashear Date: Mon Mar 23 18:46:40 2009 +0000 viced-type-fixups-20090323 LICENSE IPL10 SetLogThreadNum takes a fcn returning int. get_key's first arg is a void* commit c39d0161552bf69affe839fcb36dfb858dbaedc1 Author: Jeffrey Altman Date: Mon Mar 23 18:18:44 2009 +0000 volid-unsigned-int32-20090323 LICENSE IPL10 FIXES 124510 assume volume ids are always unsigned 32 bit values commit 4830a7c8d79c72dcd5d8ce4bab6b8c0a8b249d96 Author: Derrick Brashear Date: Mon Mar 23 15:16:30 2009 +0000 linux-task-becomes-task-struct-20090323 LICENSE IPL10 struct task->struct task_struct. configure needs to cope commit 39c4e32bf484aab2c9cf978cbf5877bdb989e9d6 Author: Derrick Brashear Date: Sat Mar 21 16:29:46 2009 +0000 krb5-run-configure-tests-20090321 LICENSE IPL10 FIXES 124522 --with-krb5=/path caused us to not run configure tests. fix that commit c1d545dff6483369ade640b27b9ab7baaa6faac5 Author: Derrick Brashear Date: Sat Mar 21 15:49:07 2009 +0000 aix-no-aklog-tsm-without-krb5-20090320 LICENSE IPL10 FIXES 124522 don't build aklog_dynamic_auth without krb5 commit 4398d6277dacde8464c0db7a73d5ecb37039823f Author: Derrick Brashear Date: Sat Mar 21 15:45:41 2009 +0000 rx-prototypes-alloc-free-ifdefs-20090321 LICENSE IPL10 don't prototype osi_Alloc/osi_Free if they're just #defines commit 4bf68765b6d2a04c388ae9a5e6f134c0505a785b Author: Derrick Brashear Date: Sat Mar 21 15:39:05 2009 +0000 sig-t-exclude-multiple-20090321 LICENSE IPL10 disallow multiple typedefs of sig_t commit b1aaf822f558236b91e543f03bcf159db1054c0b Author: Derrick Brashear Date: Sat Mar 21 15:07:41 2009 +0000 update-config-guess-20090321 LICENSE IPL10 update from upstream commit 3e034dcb6cbb82ef78853a342bd2c459250e0bcd Author: Derrick Brashear Date: Fri Mar 20 22:44:54 2009 +0000 aix51-pag-header-20090320 LICENSE IPL10 FIXES 124522 no sys/pag.h until 5.2 commit 73a57e8013c67d5760c677c6aef36611af076af0 Author: Jeffrey Altman Date: Fri Mar 20 17:25:21 2009 +0000 vol-fssync-server-socket-20090320 LICENSE IPL10 another location where we need osi_socket commit b2db1e83c1b4b66ee4f7fb22a6211f849f0e5dd4 Author: Jeffrey Altman Date: Fri Mar 20 17:21:51 2009 +0000 libadmin-client-prototype-20090320 LICENSE IPL10 correct the prototype for afsclient_RXDebugOpenPort commit 218f08ffedb8c75e0314ab00000adf8419fdfe7b Author: Jeffrey Altman Date: Fri Mar 20 17:10:06 2009 +0000 xstat-printf-ptr-format-20090320 LICENSE IPL10 make use of AFS_PTR_FMT to avoid warnings on Windows. commit 37fc3b01445cd6446f09c476ea2db47fea544b7d Author: Jeffrey Altman Date: Fri Mar 20 17:09:01 2009 +0000 config-afs-ptr-format-20090320 LICENSE IPL10 Define AFS_PTR_FMT to permit per platform printf formats for pointer representation. commit 18da64a45c5f1a069f39f687bd84ee51b77a6bd3 Author: Chaskiel M Grundman Date: Fri Mar 20 15:55:38 2009 +0000 linux-osi-vm-flushpages-use-remote-invalidate-20090320 LICENSE IPL10 use invalidate_remote_inode instead of vmtruncate in osi_VM_FlushPages commit 6ef7d7dfb8caf4a555c2de480037769783cbe88e Author: Derrick Brashear Date: Fri Mar 20 15:04:08 2009 +0000 dyn-vcache-shake-needs-exporting-20090320 LICENSE IPL10 update to export shakeloosevcaches commit 0cd43484be886721c0c4d9750f0b40015ba60756 Author: Jeffrey Altman Date: Fri Mar 20 12:15:01 2009 +0000 vol-fssync-socket-20090320 LICENSE IPL10 the argument to the function parameter is a socket. fix the type to be osi_socket. commit 64c451cec0ccce8d095109a8697144be093c1259 Author: Jeffrey Altman Date: Fri Mar 20 11:51:55 2009 +0000 libadmin-vos-windows-exports-20090320 LICENSE IPL10 do not export function name arrays that are already exported by other libraries. commit 5eea839b637a120e9b10246511b3d826a1e49a0f Author: Jeffrey Altman Date: Fri Mar 20 11:49:27 2009 +0000 libadmin-client-prototypes-20090320 LICENSE IPL10 fix the prototype for afsclient_RPCStatOpenPort and afsclient_CMStatOpenPort commit 14a60754951b7b4920ba1dfcf9c9aac99ae8bce4 Author: Jeffrey Altman Date: Fri Mar 20 11:47:00 2009 +0000 libadmin-windows-socket-20090320 LICENSE IPL10 a socket on Windows is type SOCKET not HANDLE commit df961512e1162188a60cec613dd273e25dbf63c9 Author: Jeffrey Altman Date: Fri Mar 20 11:44:29 2009 +0000 windows-osistatl-20090320 LICENSE MIT Add lock level to osistatl commit e460a6e30539086ff3c4bdb264ab57f6e045ad71 Author: Jeffrey Altman Date: Fri Mar 20 05:30:12 2009 +0000 static-inline-macros-20090320 LICENSE IPL10 FIXES 124515 add back support for AFS_64BIT_ENV commit ef5f6f988c352db58e8b9df422b417cc199b4837 Author: Derrick Brashear Date: Fri Mar 20 03:48:52 2009 +0000 ubik-recovery-use-file-number-not-hardcoded-zero-20090319 LICENSE IPL10 don't hardcode DB0, use the file number which is being recovered commit 4eef62a2f29d81d4fd8c3d28beb0403499f9802e Author: Derrick Brashear Date: Fri Mar 20 03:12:11 2009 +0000 param-file-64-bit-scalar-updates-20090319 LICENSE IPL10 64 bit scalar type availability commit e59b81c984652f7570708831d8b36bdd42f98cf8 Author: Derrick Brashear Date: Fri Mar 20 02:30:49 2009 +0000 dynamic-vcache-allocation-20090319 LICENSE IPL10 FIXES 124334 add dynamic allocation of vcaches when possible (currently just for linux) commit 79d362c77cfc307dc66bfe874952a914e2313e89 Author: Derrick Brashear Date: Thu Mar 19 20:12:53 2009 +0000 cbd-new-magic-version-with-fixed-time-size-and-dump-switch-20090319 LICENSE IPL10 FIXES 124451 make cbd able to select whether time is 32 or 64 bit; when time size is known, have a new magic number so it's obvious commit fe98c927d3888814077b085e53725f15996cd1b9 Author: Derrick Brashear Date: Thu Mar 19 18:03:41 2009 +0000 bozo-fs-create-unused-ptr-20090319 LICENSE IPL10 add an "unused" field so we match the prototype for create in the bnodeops struct commit 101399171b5a5315cb3f1fdd003d56f0ca214bc8 Author: Derrick Brashear Date: Thu Mar 19 17:44:39 2009 +0000 static-inline-macros-20090319 LICENSE IPL10 rework the static inline macros to work with headers, with userspace code, and to have just one copy commit a343f09803a4b3d5c5492c7d52becbd1526c1f8b Author: Derrick Brashear Date: Thu Mar 19 14:58:22 2009 +0000 viced-type-errors-20090319 LICENSE IPL10 use ktc_encryptionKey instead of a char array to avoid prototype issues threadNum should return int, not char commit 3d54f743bce4c1bd603e9572790f51e85905dabb Author: Derrick Brashear Date: Thu Mar 19 14:42:39 2009 +0000 linux-put-back-warnings-20090319 LICENSE IPL10 need to verify this for all platforms at the same time; since the function is portable. should be const anyway; we don't want to change it. commit bf9dc554b366b08ce0bef62ce242c94371938000 Author: Marc Dionne Date: Thu Mar 19 04:02:18 2009 +0000 linux-key-alloc-changes-20090318 LICENSE IPL10 FIXES 124507 Fix the old configure test for key_alloc for the task argument - we can't just rely on the number of arguments anymore. Wish this could be done without using -Werror. Add an additional test for the struct cred argument commit aaae44dfe993d95a253b35f60feab5e9806e51f2 Author: Marc Dionne Date: Thu Mar 19 03:57:42 2009 +0000 mypidxx-not-always-int-20090318 LICENSE IPL10 FIXES 124505 don't assume MyPidxx will be an int; on linux it's current, for instance, a task_struct commit 156f1b8e4a3607a49de45ca43a52f42a21cdaab8 Author: Marc Dionne Date: Thu Mar 19 03:53:31 2009 +0000 discon-ifdef-cleanup-20090318 LICENSE IPL10 FIXES 124508 fix the disconnected ifdefs commit be4d4076f281840070a908a7da10f4cab70cea62 Author: Jeffrey Altman Date: Wed Mar 18 22:46:21 2009 +0000 printf-sanity-20090318 LICENSE IPL10 make it work for Windows commit 85d8bdac7439966a64709724d20dfd487911f7bc Author: Marc Dionne Date: Wed Mar 18 13:41:07 2009 +0000 linux-warning-reduction-20090318 LICENSE IPL10 FIXES 119434 cleanup warnings in linux kernel builds commit 09b23c27a7b59a32b8e39bbc0410ddda373da5d4 Author: Jeffrey Altman Date: Wed Mar 18 03:56:12 2009 +0000 windows-afsd-badsharename-20090317 LICENSE MIT When Dfs support is enabled in the smb server do not return CM_ERROR_BADSHARENAME unless the component that is not found is in fact a share name. Return CM_ERROR_NOSUCHPATH instead. commit f26074cbde320fbc89da291e0aa243c2301bb599 Author: Derrick Brashear Date: Tue Mar 17 15:44:15 2009 +0000 configure-cpp-fallback-to-cc-E-20090317 LICENSE IPL10 if we don't find any cpp whatsoever, fall back to $CC -E, or cc -E commit 57326151f50270695c572afa06c1d4b4b5df40b0 Author: Derrick Brashear Date: Tue Mar 17 15:10:23 2009 +0000 prototyping-fallout-20090317 LICENSE IPL10 clean up to make prototyping code build everywhere commit b7372c3e1473ffcd4ab13451d3861103b51df3af Author: Derrick Brashear Date: Tue Mar 17 15:09:49 2009 +0000 solaris-vnode-path-cache-cleanup-20090317 LICENSE IPL10 declare needed variables everywhere commit 355344253605925972ea032d05dcb5fee3d8c3b6 Author: Simon Wilkinson Date: Tue Mar 17 04:51:40 2009 +0000 printf-sanity-20090317 LICENSE IPL10 FIXES 124239 sanitize the arguments to printf to minimize warnings commit 9fa77320ca368af97162d561bb7560b9fa55666a Author: Jeffrey Altman Date: Tue Mar 17 04:49:35 2009 +0000 vol-socket-abstraction-20090317 LICENSE IPL10 windows needs the abstraction for sockets commit 8aa03f1168c19166333a47e88e667a8ca5138133 Author: Steven Jenkins Date: Tue Mar 17 03:06:52 2009 +0000 tests-update-20090316 LICENSE IPL10 1- make afs-newcell.pl remove KeyFile in unwind 2- correct missing space in volserver setup for DAFS 3- fix klog to not try to use a Kerberos realm name 4- fix minor POD bug in src/tests/OpenAFS/wrapper.pm 5- enhance src/tests/OpenAFS/vos.pm to support On-line/Off-line state commit e7b25342096994520b7cea8eab76791edc68b9aa Author: Derrick Brashear Date: Tue Mar 17 02:31:24 2009 +0000 gtx-x11-init-debug-20090316 LICENSE IPL10 initialize x11 version of gtx correctly commit 85bb464bb46cd87e10a90b75748e164ae683cba0 Author: Jason Edgecombe Date: Tue Mar 17 02:21:14 2009 +0000 man-page-vos-setfields-20090316 LICENSE BSD FIXES 124472 New man page for vos setfields. Also adds -noresolve documentation to the vos(1) common flags. commit d26b3688625231465e17e39f082ed31f230dc667 Author: Derrick Brashear Date: Mon Mar 16 19:59:36 2009 +0000 disconnected-cache-type-genericization-miss-20090316 LICENSE IPL10 the cache type union change missed this town... commit a3125d5752390d424fc828d6f87da3c67589a9bb Author: Derrick Brashear Date: Mon Mar 16 19:50:49 2009 +0000 ubik-header-needs-stdarg-20090316 LICENSE IPL10 like com_err.h, includers now need this commit 143819664227f239c9cc07503c9fad1faa5ba9a3 Author: Jeffrey Altman Date: Mon Mar 16 18:13:21 2009 +0000 windows-afsconfig-20090316 LICENSE MIT add typedef for socklen_t which is not present on Windows. commit 6862d4685510ca618c16ed9c150dcfc7e31d5299 Author: Derrick Brashear Date: Mon Mar 16 17:54:12 2009 +0000 irix-no-inline-20090316 LICENSE IPL10 no inline on irix; deal like elsewhere commit 0e89bfb934863e6ab852b24422fa2c8f8c328120 Author: Jeffrey Altman Date: Mon Mar 16 17:52:31 2009 +0000 rxstat-include-path-20090316 LICENSE IPL10 do something sensible with rxstat prototypes header commit 0097888d53b71ef38491d71c3259ca9b5ac5dfa3 Author: Simon Wilkinson Date: Mon Mar 16 17:21:49 2009 +0000 bucoord-prototypes-20090316 LICENSE IPL10 FIXES 124238 prototype the bucoord directory commit 8377e2e34d750ef1318969f4a59b002920dc2d70 Author: Derrick Brashear Date: Mon Mar 16 17:17:17 2009 +0000 bubasics-prototype-getsize-correctly-20090316 LICENSE IPL10 fix prototype of getSize op commit 2d683a880bf5f30db22862f0f6add14142dbcf9a Author: Derrick Brashear Date: Mon Mar 16 16:14:12 2009 +0000 socklen-t-check-20090316 LICENSE IPL10 verify we have socklen_t and if not, get it commit 3eec4075102b18bac036c33c9acb155e44c23f08 Author: Derrick Brashear Date: Mon Mar 16 16:09:34 2009 +0000 fssync-abstract-fd-type-20090316 LICENSE IPL10 apparently 64 bit windows has 64 bit fds commit 7815171a8d300d550dd61c2db0f329b19390cf16 Author: Derrick Brashear Date: Mon Mar 16 15:48:20 2009 +0000 irix-no-sig-t-20090316 LICENSE IPL10 correct the sig_t checking macro commit a5daae759d6b513f27f4fe3ab255ea7b4497ff41 Author: Derrick Brashear Date: Mon Mar 16 15:17:12 2009 +0000 kauth-needs-sys-for-headers-20090316 LICENSE IPL10 get sys's header for kauth commit 97fad3a313088cb0ca5c4966fb9d24dedbecf146 Author: Simon Wilkinson Date: Mon Mar 16 15:06:54 2009 +0000 rxstat-prototypes-20090316 LICENSE IPL10 FIXES 124235 prototype the rxstat directory commit 92cd63b0b7cd26f05e6f316a6d209e4e5d0bfaa2 Author: Derrick Brashear Date: Mon Mar 16 14:41:22 2009 +0000 vol-no-cast-macro-20090316 LICENSE IPL10 afs_cast_uint32 doesn't exist, not sure we need it commit f076eb4f88a8e3b7633c21edb3921f4f08eefa6b Author: Jeffrey Altman Date: Mon Mar 16 14:19:39 2009 +0000 budb-no-pointer-math-on-void-star-20090316 LICENSE IPL10 can't do pointer math on void*; already casting to char* anyway commit 95d639b19452001835097fe4e0189efe5d8d08be Author: Jeffrey Altman Date: Mon Mar 16 14:12:37 2009 +0000 auth-unistd-not-on-windows-20090316 LICENSE IPL10 don't include unistd on windows commit 6e569d2518dba2f947626b40597c71e9798936b7 Author: Simon Wilkinson Date: Mon Mar 16 14:00:56 2009 +0000 sys-prototypes-20090315 LICENSE IPL10 FIXES 124233 prototype the sys directory commit 129905960db523e0a6365175bf0ce066fdbd60fd Author: Simon Wilkinson Date: Mon Mar 16 13:49:15 2009 +0000 gtx-prototypes-20090316 LICENSE IPL10 FIXES 124243 prototype the gtx directory utilize in scout commit 2b6d173530f38fba6ac9d2cc3459d7088a248f4f Author: Simon Wilkinson Date: Mon Mar 16 13:45:11 2009 +0000 butm-prototypes-20090316 LICENSE IPL10 FIXES 124241 prototype the butm directory commit f239bf808f63bb6a22e53696e9927ba2e4121c75 Author: Simon Wilkinson Date: Mon Mar 16 13:43:34 2009 +0000 uss-prototypes-20090316 LICENSE IPL10 FIXES 124248 prototype the uss directory commit bd00e10eb7caf66de33640bf06722d0169231703 Author: Simon Wilkinson Date: Mon Mar 16 13:41:23 2009 +0000 budb-prototypes-20090316 LICENSE IPL10 FIXES 124240 prototype the budb directory commit 14c3d5ed9179574692a0f7a5cc15d625083e3cf8 Author: Simon Wilkinson Date: Mon Mar 16 13:39:03 2009 +0000 bubasics-prototypes-20090316 LICENSE IPL10 FIXES 124237 prototype the bubasics directory make the volser prototypes available for bubasics to use commit 4fdda50ca7ea47d5b4b8a5cd31797b527deb148f Author: Simon Wilkinson Date: Mon Mar 16 13:28:55 2009 +0000 dir-prototypes-20090316 LICENSE IPL10 FIXES 124242 prototype the dir directory commit cff2da10d6f2c4b568c07a331ceb96cbf952576a Author: Simon Wilkinson Date: Mon Mar 16 13:26:20 2009 +0000 libadmin-prototypes-20090316 LICENSE IPL10 FIXES 124246 prototype the libadmin directory commit 0a8f1e16ae1a18094fa28521f29bee911aa6dcfb Author: Simon Wilkinson Date: Mon Mar 16 13:24:25 2009 +0000 venus-prototypes-20090316 LICENSE IPL10 FIXES 124250 prototype the venus directory commit 379162ec07cc76550e9690f3631cc00b931744f7 Author: Simon Wilkinson Date: Mon Mar 16 13:22:15 2009 +0000 scout-prototypes-20090316 LICENSE IPL10 FIXES 124253 prototype the scout directory commit 0dcdbf6dcda0814a5f24e84d4ef98ffc2279eff1 Author: Simon Wilkinson Date: Mon Mar 16 13:19:47 2009 +0000 bozo-prototypes-20090316 LICENSE IPL10 FIXES 124236 prototype the bozo directory commit 01e03837b81843c4f28eb6cc54811b1bd231514c Author: Simon Wilkinson Date: Mon Mar 16 13:17:33 2009 +0000 auth-prototypes-20090316 LICENSE IPL10 FIXES 124234 prototype the auth directory commit 242aa845a149d5132047e44d074064093fd2d61b Author: Simon Wilkinson Date: Mon Mar 16 13:13:45 2009 +0000 afsd-prototypes-20090316 LICENSE IPL10 FIXES 124231 prototype the afsd directory commit f28659bd826c2bb7311c84122262000caf33316c Author: Simon Wilkinson Date: Mon Mar 16 13:11:42 2009 +0000 vol-prototypes-20090316 LICENSE IPL10 FIXES 124252 prototype the vol directory commit 79448c25acead55728f40beec18e00113d8356f4 Author: Simon Wilkinson Date: Mon Mar 16 13:08:38 2009 +0000 ptserver-prototypes-20090316 LICENSE IPL10 FIXES 124249 prototype the ptserver directory commit a0179b07096014e31ba6ecf1643a9cf67ba45a24 Author: Jeffrey Altman Date: Mon Mar 16 12:37:09 2009 +0000 ubik-prototype-fallout-20090316 LICENSE IPL10 make things happy again commit 61dadb6458ec95b5bf4bd4250520453630fbbe4c Author: Derrick Brashear Date: Mon Mar 16 03:44:36 2009 +0000 irix-lacks-sig-t-20090315 LICENSE IPL10 sig_t is missing on irix commit 596614dd76aa5107f6cd30c67a79b371be48f504 Author: Simon Wilkinson Date: Mon Mar 16 03:10:21 2009 +0000 viced-prototypes-20090315 LICENSE IPL10 FIXES 124251 prototype the viced directory commit d5158b2ccb78fc7df0a346c7a5dd5b7cb5d0b58b Author: Simon Wilkinson Date: Mon Mar 16 03:03:14 2009 +0000 ubik-prototypes-20090315 LICENSE IPL10 FIXES 124245 prototype the ubik directory commit b18ec965dd58331eb32599a21e882fbe43a8257e Author: Simon Wilkinson Date: Mon Mar 16 02:53:55 2009 +0000 fsprobe-prototypes-20090315 LICENSE IPL10 FIXES 124254 prototype the fsprobe directory commit 8952e3d64d8099a5238be3ccf9cb56a7c0d1a2df Author: Simon Wilkinson Date: Mon Mar 16 02:42:34 2009 +0000 libacl-prototypes-20090315 LICENSE IPL10 FIXES 124256 prototype the libacl directory commit 2e4326e20ebadc2cb9b3efd117454bc422cdc63d Author: Simon Wilkinson Date: Mon Mar 16 02:35:29 2009 +0000 kauth-prototypes-20090315 LICENSE IPL10 FIXES 124257 prototype the kauth directory commit 12a60258f5ae680440b2a93369ca676359c888d4 Author: Simon Wilkinson Date: Mon Mar 16 02:26:28 2009 +0000 rxgen-prototypes-20090315 LICENSE IPL10 FIXES 124255 prototype the rxgen directory commit 47451b4c2009c51160686b4aca1b28b7011ba92f Author: Simon Wilkinson Date: Mon Mar 16 02:00:27 2009 +0000 util-prototypes-20090315 LICENSE IPL10 FIXES 124247 prototype the util directory commit 00fd29251e9326bd81d46387337ca014a118f7ec Author: Simon Wilkinson Date: Mon Mar 16 01:38:07 2009 +0000 audit-prototypes-20090315 LICENSE IPL10 FIXES 124232 prototype the audit directory commit c560efe73f79e396866918ee072849065ab70838 Author: Simon Wilkinson Date: Mon Mar 16 01:34:36 2009 +0000 des-prototypes-20090315 LICENSE IPL10 FIXES 124230 prototype the des directory commit 0c39a855a2da7b3e82970c65f835eed38b650215 Author: Rainer Toebbicke Date: Sun Mar 15 18:50:00 2009 +0000 viced-copyonwrite-optimization-20090315 LICENSE IPL10 FIXES 124397 optimize CopyOnWrite to avoid rewriting data if possible commit 6308037dec22d5a141fc64a11472b1a36585deb2 Author: Chaskiel M Grundman Date: Sun Mar 15 18:42:13 2009 +0000 cellservdb-proc-file-glocking-20090315 LICENSE IPL10 FIXES 124407 hold GLOCK appropriately when dealing with the proc file commit 5102d56f080f1284eecb94dbc7c06cb966c27f5b Author: Mike Meffie Date: Sun Mar 15 18:30:41 2009 +0000 viced-improve-host-hashing-20090315 LICENSE IPL10 FIXES 124447 hash based on host byte order so intel machines aren't sad commit fd6d954e95e016a78001e9bc12c4646ba8183e12 Author: Mike Meffie Date: Sun Mar 15 18:19:15 2009 +0000 butc-xbsa-buffersize-20090315 LICENSE IPL10 FIXES 124425 restrict buffer size to allow for header space commit 22c5edb1b22dbeee28b569ceefb543ab5ffed929 Author: Chaskiel M Grundman Date: Sun Mar 15 18:13:25 2009 +0000 solaris-avoid-returning-einval-if-possible-20090315 LICENSE IPL10 FIXES 124426 if we have a better error code, return it. commit fd9e5ffb4653b87f92438574083185a55086b661 Author: Derrick Brashear Date: Sun Mar 15 18:02:31 2009 +0000 aklog-old-principal-conversion-sans-524-20090315 LICENSE IPL10 we'll want to fix this differently later; since 524 is dying perhaps we need to just ship heimdal's version of this code commit d0e4044cfeef3ce1c5d435251de9b584343225f5 Author: Jeffrey Altman Date: Sat Mar 14 04:59:23 2009 +0000 windows-afsd-reset-acl-cache-20090312 LICENSE MIT Modify the cm_ResetACLCache interface to accept an optional cm_cell_t *. At the moment every time a token is set or cleared all of the acl info for all cm_scache_t objects regardless of cell is reset. This is both a performance hit and unnecessary. If we know the cell, only reset the acl info for cm_scache_t objects in that cell. If cell is not specified, reset for all cells. commit 8e01e5a4dbcaaea03fc3af59bec5ef211d5b4684 Author: Jeffrey Altman Date: Sat Mar 14 04:54:59 2009 +0000 windows-afsd-unlock-20090312 LICENSE MIT Modify the cm_Unlock() interface to support the ability to unlock all locks within a range. This is required for the redirector. commit 7ca2785f53d391afa5e7200f2b4d40c79a857443 Author: Jeffrey Altman Date: Sat Mar 14 04:51:11 2009 +0000 windows-freelance-20090312 LICENSE MIT correct error in windows-freelance-20090223. use cpath not filename since that is why we allocated cpath in the first place. commit ef81e9395c171f9dcb8df120991ba65ec1ca5610 Author: Jeffrey Altman Date: Sat Mar 14 04:49:06 2009 +0000 windows-afsd-callback-20090312 LICENSE MIT use cm_HaveCallback() to check for a call back instead of explicit checks on cbExpires and cbServerp. cm_HaveCallback takes into account Freelance mode and offline status. commit 15d4dd0f70925eaf2af333f2215235cb90637457 Author: Jeffrey Altman Date: Sat Mar 14 04:45:22 2009 +0000 windows-afsd-btree-20090313 LICENSE MIT Change cm_BPlusDirEnumerate interface to include a 'FetchStatus' parameter. When set to 0, we do not fetch status for fids for which we do not already have status info. This avoids unnecessary recycling of cm_scache_t objects. commit 77452db304abfc6ad0139769034986dc8bf172d9 Author: Matt Benjamin Date: Tue Mar 10 19:21:12 2009 +0000 dumpcallbackstate-64bit-timet-safe-20090310 LICENSE IPL10 FIXES 124451 on 64 bit platforms, 64 bit time_t means returning into afs_int32 is bad commit 581fd18bd9c3fe8e07169c60a7cde9e72e8af89c Author: Jeffrey Altman Date: Sat Mar 7 14:10:23 2009 +0000 avoid-blocking-with-connhashtable-lock-in-reapconnections-20090307 LICENSE BSD instead of potentially blocking waiting for a call lock, assume if the call is locked, the conn is still busy. also, don't even try to get the conn data lock if we don't need to commit 19ffc146fac828cd32b90c4d43d617de6c574556 Author: Jeffrey Altman Date: Mon Mar 2 04:44:43 2009 +0000 windows-afsd-server-uuid-20090301 LICENSE MIT Unlike the unix cache manager, on Windows the server uuid was not recorded as part of the cm_server object. This commit adds the uuid and a flag to indicate if it is set or not. A check is made in cm_UpdateVolumeLocation it confirm that the uuid known to the CM is the same as the one being reported by the vl server. If they differ, this is logged but no action is taken. The contents of the cm_allServers list is now dumped in response to "fs memdump" or a crash. This includes the uuid, addr, type, flags, downtime, caps, etc. The server uuid is not useful at the moment because there is nothing that the CM can use it for. However, it might be useful for debugging and it will be needed for extended callback support. commit 5d147351263be2636ef547f22acb24c7816348c1 Author: Jeffrey Altman Date: Sat Feb 28 16:19:13 2009 +0000 window-afsd-bad-version-20090228 LICENSE MIT create a new cpp symbol CM_SCACHE_VERSION_BAD to represent data version values in cm_scache objects that are known to be invalid. then consistently apply this value throughout the code. Previously some invalid values were set to 0 and others to -1 (0xFFFFFFFF:FFFFFFFF). Also fix at least one location where CM_BUF_VERSION_BAD was not used. commit a32971251670acc7944dcd4b1eade1ab161e587f Author: Jeffrey Altman Date: Sat Feb 28 15:40:56 2009 +0000 windows-afsd-btree-20090228 LICENSE MIT Change how BPlusDir enumerations behave with regards to bulk stat operations. If the number of entries in the enumeration is larger than the number of cm_scache objects, then using the previous model of cm_BPlusDirEnumBulkStat being called for the entire enumeration list results in the early objects being recycled and the status info discarded before the caller of cm_BPlusDirNextEnumEntry() receives the name. The revised model triggers bulk stat operations from within NextEnumEntry() as objects requiring status fetching are about to be returned to the caller. This reduces the thrashing of the stat cache. We should consider adding a flag field to cm_BPlusDirEnumerate() or cm_BPlusDirNextEnumEntry() to permit enumeration without status fetching. commit fbfaaf26890102dbe34315128183c27ce67f77a3 Author: Jeffrey Altman Date: Fri Feb 27 07:26:35 2009 +0000 windows-afsd-error-map-20090227 LICENSE MIT do not permit VNOSERVICE or VOFFLINE or VSALVAGE to leak and be returned as an error code. The resulting NTSTATUS is not valid. commit ab0691760f4cdd2fe8bded4700d051ea1ba51856 Author: Jeffrey Altman Date: Thu Feb 26 17:46:32 2009 +0000 windows-tests-torture-20090226 LICENSE MIT fix error message create a file of the specified size commit 3c1f85820853e9143cab076d735f7d7c27aeaf62 Author: Jeffrey Altman Date: Tue Feb 24 05:06:23 2009 +0000 windows-freelance-20090223 LICENSE MIT Fix another set of edge cases where adding a mountpoint or symlink to the Freelance volume would result in the wrong fid being returned to the request that made the addition. When the Freelance directory is updated, invalidate the cm_scache_t object. that is associated with it. Actually use the data version when checking callback status. The return value from Add Mount/Symlink is not negative on failure. Its an actual error code. Treat it that way. commit 80faa5e93ddc95ca676aa31f5d3522ad6b67f67e Author: Jeffrey Altman Date: Mon Feb 23 14:28:32 2009 +0000 windows-getrootcellname-20090223 LICENSE MIT do not mix and match CELL_MAXNAMELEN and MAXCELLCHARS. They are not the same. commit f83cfcafcbec8a953161fad300073b85a4215a03 Author: Russ Allbery Date: Sat Feb 21 20:51:08 2009 +0000 libafs-tree-clean-target-20090221 LICENSE IPL10 Add clean and distclean targets to the libafs_tree Makefile, based on suggestions by jhutz. commit 2290db5f160a0105005ec0787a002ce71629c3df Author: Mike Meffie Date: Sat Feb 21 15:36:39 2009 +0000 linux-module-build-test-configure-fix-20090221 LICENSE IPL10 FIXES 124381 deal when the module link warning has extra characters commit 8382f8ccb1c14f32318b3d1c587b417cce4c721c Author: Jeffrey Altman Date: Sat Feb 21 04:26:43 2009 +0000 windows-smb-misc-20090220 LICENSE MIT Fix smb_FindFIDByScache() to avoid obtaining the smb_fid_t.mx and smb_rctLock out of order. Doing so requires obtaining references on each smb_fid_t belonging to the smb_vc_t in order to prevent them from being removed from the list while the list is being walked. Reorder tests for CM_SCACHEFLAG_DELETED and smb_fid_t.scp to make them more efficient and consistent. When processing Tran2SetPathInfo do not fail because an smb_fid_t cannot be found for the path object. The PathInfo function is being used because we do not have a file descriptor. Most importantly do not fail by returning success. commit 54a3c85ae44aaaac9dd933893d975199b3cdca70 Author: Jeffrey Altman Date: Sat Feb 21 04:19:23 2009 +0000 windows-rename-cross-dir-invalid-handle-20090220 LICENSE MIT Problems with the cm_Rename() functions: * when a rename occurs across directories, the file server allocates a new vnode which in turn alters the FID. Since the new FID and potentially version number is unknown to the client, it is not possible to update the target directory with the new name and FID thereby avoiding reading the directory from the file server. * when the old vnode is removed, the callback is broken but the client did not discard the cm_scache_t object In order to optimize the client cache AFS requires a RXAFS_RenameEx rpc that is equivalent to the current RPC but returns the new FID and status. This would permit the cache manager to relabel the data buffers and cm_scache_t that are known to contain valid data. commit 4eb808d26b1d417189d363924c4e2e32ed832690 Author: Asanka Herath Date: Thu Feb 19 04:04:24 2009 +0000 smb-vc-reset-on-request-20090218 LICENSE MIT When processing SMB_SESSION_SETUP_ANDX in smb_ReceiveV3SessionSetupX it is possible that the smb client might indicate that it requires an Mpx Count greater than we are configured to support. If so, log it to the Windows Event Log as a warning. It is also possible that the client might specify that its maximum receive buffer is smaller than the SMB_PACKETSIZE. If so, log it to the Windows Event Log as a warning. Finally, if the client specifies a virtual circuit number of zero, the client thinks this is its first time communicating with us. In which case we should invalidate all prior virtual circuits. We also log this request to the Windows Event Log as informational. commit 5bd86a09eb897cf12f0d08442f956f79ec7d15b3 Author: Simon Wilkinson Date: Wed Feb 18 17:48:39 2009 +0000 windows-64bit-printf-sanity-20090218 LICENSE IPL10 FIXES 124265 don't assume %lld works for 64 bit ints on windows commit 733794b4d8be284dcb6f9e60fa4b4abe1f3398f2 Author: Peter Tripician Date: Wed Feb 18 17:27:59 2009 +0000 vos-increment-offline-count-20090218 LICENSE IPL10 FIXES 124333 increment offline volume count, not pointer to it commit da8df5ea2c9311c4e4b263fbdba3aea3141ef075 Author: Derrick Brashear Date: Tue Feb 17 14:34:18 2009 +0000 vldb-check-no-bogus-shadow-decl-20090217 LICENSE IPL10 unfussy compilers treat this as a shadow declare; others thankfully as an error commit 8b74a85b977f379ea94cd01df3fcb553147a42dc Author: Derrick Brashear Date: Tue Feb 17 14:27:48 2009 +0000 aklog-524-vars-20090216 LICENSE IPL10 add missing variables commit b9816e12f7ed8213c9c4eaea09e992e69ce4ee05 Author: Jeffrey Altman Date: Tue Feb 17 04:37:27 2009 +0000 vclosevnodefiles-ihandle-leak-20090216 LICENSE IPL10 FIXES 124359 don't leak ihandles on close. this isn't a complete fix for the issue commit 846919700b90b919d6a12102ae8c6d85ee36b83c Author: Peter Tripician Date: Tue Feb 17 04:32:08 2009 +0000 bozo-corefile-timestamp-fix-20090216 LICENSE IPL10 FIXES 124340 output y2k-correct corefile names commit b1f9b4cb5dd295162ae51704310e9d6058008f0a Author: Evan Broder Date: Tue Feb 17 04:28:53 2009 +0000 aklog-use-native-principal-conversion-20090216 LICENSE IPL10 FIXES 124338 use krb5_524_conv_principal instead of doing it potentially wrong ourselves commit 8bc58a3d6dd531b55c405590e419d2ce4d74b5fc Author: Chas Williams Date: Tue Feb 17 04:25:10 2009 +0000 macos-10-6-support-20090216 LICENSE IPL10 FIXES 124288 support for (32 bit) macos 10.6. no pam yet commit 43bcfaf9cc429cec51a98857d86d870c45759baa Author: Steven Jenkins Date: Tue Feb 17 04:16:56 2009 +0000 vldb-check-meaningful-return-codes-20090216 LICENSE IPL10 FIXES 124321 make vldb_check have meaningful return codes commit 52f3295d32e3a72916ea1f99119967b7279f642a Author: Peter Tripician Date: Tue Feb 17 03:59:28 2009 +0000 fs-lsm-parse-bug-20090226 LICENSE IPL10 FIXES 124319 print correct error on root directory commit 0e05505a8964da2e9d4c4eccab7a3b322e5d02f0 Author: Marc Dionne Date: Tue Feb 17 03:43:37 2009 +0000 linux26-bogus-param-define-20090216 LICENSE IPL10 FIXES 124324 remove orphaned define commit 4817a4a98fe9ccc61c90d8bbc769790ad067339b Author: Tony D'Amato Date: Tue Feb 17 03:29:22 2009 +0000 redhat-rpms-kernel24-20090216 LICENSE IPL10 FIXES 102673 rewrite make rule for 2.4 kernels commit f3080eb7c7c4c4f72d6560b12c3d8cffbb4b2b0d Author: Marc Dionne Date: Tue Feb 17 03:23:27 2009 +0000 rx-head-build-error-20090216 LICENSE IPL10 FIXES 124323 include header so mutex&atomic macros exist commit 8e3b67b9537097928b4fc13844db09d429ac9bed Author: Jeffrey Altman Date: Thu Feb 12 21:44:47 2009 +0000 windows-smb-fidp-scp-race-20090212 LICENSE MIT FIXES 124293 As evident in a crash dump, there is a race surrounding access to the scp field of the smb_fid_t object. Not all access was protected by the smb_fid_t mx and the cm_scache_t object was not always being reference counted within the accessing function. This patch ensures that all initial references to the scp object are performed under the smb_fid_t mx mutex and that the cm_scache_t is prevented from being recycled by obtaining a local reference. Finally, CM_ERROR_BADFD is returned as an error if a request begins after the smb_fid_t scp field has already been cleared by a smb_CloseFID() call as part of a concurrent request. commit 8bb35234aa8469ba93a2171fced503a875c2f1f6 Author: Jeffrey Altman Date: Thu Feb 12 21:30:03 2009 +0000 windows-vmoved-vnovol-failover-20090212 LICENSE MIT FIXES 124276 A readonly volume with multiple instances was being marked alldown when one of the instances resulted in VNOVOL because the vldb and the indicated file server were out of sync. The cache manager would then attempt to re-obtain the volume location info from the vldb for the entire timeout period. This patch: adds trace logging to cm_Analyze indicating which server references are being deleted and which remain in response to a VNOVOL/VMOVED error. adds trace logging to cm_UpdateVolumeStatusInt showing how the new volume status value is determined. corrects cm_Analyze() so that it doesn't corrupt the server reference list during cm_FreeServerList() calls; doesn't orphan the server reference list by setting *serverpp to NULL; and only re-obtains the volume info list once per request. commit 1050049411d1fc47441220c33e6353436fc586e7 Author: Jeffrey Altman Date: Tue Feb 10 22:42:40 2009 +0000 fix-tsfpq-20090210 LICENSE BSD avoid transferring more than the number of packets in a queue commit c12e2fa01912e7950570354c6d059588028c086c Author: Derrick Brashear Date: Tue Feb 10 22:39:58 2009 +0000 restore-unix-rxdebug-20090210 LICENSE IPL10 stale fixes from my sandbox commit c4d5f0a70229f55683735d13523744ad2361f6b8 Author: Marc Dionne Date: Mon Feb 9 23:15:13 2009 +0000 rx-atomic-20090209 LICENSE IPL10 FIXES 124322 add parens commit 0edbc512b52848f076525ede5ff166f3785128a7 Author: Jeffrey Altman Date: Sat Feb 7 17:22:26 2009 +0000 rx-writevproc-wrong-type-20090207 LICENSE BSD In rxi_WritevProc the queueScan that sets RX_PKTFLAG_TQ on the packet really needs to cast the queue objects to rx_packet instead of rx_call. Trashing random fields is not a good idea. commit b842ee3ea521a196652ff2d09d468ca008cececc Author: Asanka Herath Date: Fri Feb 6 03:13:38 2009 +0000 windows-netidmgr-progress-20090205 LICENSE MIT add progress reporting to the provider. commit ffdc7c70889386dca37e207a91791d5d0728d2d7 Author: Jeffrey Altman Date: Thu Feb 5 00:23:54 2009 +0000 windows-freelance-20090204 LICENSE MIT set the correct fid vnode/unique values when adding new symlnks and mount points. commit 58a924fd50e96c827fc6dd3dcea48328b6abe4be Author: Mike Meffie Date: Tue Feb 3 19:44:27 2009 +0000 upclient-cleanup-temp-files-20090203 LICENSE IPL10 FIXES 124221 remove tempfiles in the event of a fetching error commit 1811577fca393c4433de64ea6e1cd5a8d13521a3 Author: Simon Wilkinson Date: Tue Feb 3 19:42:14 2009 +0000 rename-internal-gettimeofday-refs-20090203 LICENSE IPL10 FIXES 124259 switch to using fasttime, instead of wrapper commit 0ac1e741783e0d5b0cbb8ec665e0acab132f6265 Author: Simon Wilkinson Date: Tue Feb 3 19:37:41 2009 +0000 redhat-packaging-non-stable-branches-20090203 LICENSE IPL10 FIXES 124273 make rpm stuff work for other than 1.4.x commit fe3779411ea025d5ecf40687d5c21649e6daabdc Author: Simon Wilkinson Date: Tue Feb 3 19:34:10 2009 +0000 redhat-packaging-updates-20090203 LICENSE IPL10 FIXES 124272 adds fc10, fc11 support commit d4763404655e27098eb4340eca8777b63d8a5847 Author: Russ Allbery Date: Mon Feb 2 01:19:00 2009 +0000 man-page-salvager-fixes-20090201 LICENSE BSD Fix the -parallel example in the main description text: "5all" should be "all5". Reword the description a bit to hopefully make it clearer that there are two separate values set here. Note under the option description of -parallel that multiple partitions on the same device are normally processed serially. commit f204e4e37f39fa15beabf68e68dce1f6425f7513 Author: Russ Allbery Date: Mon Feb 2 01:12:02 2009 +0000 man-page-vos-examine-copy-date-20090201 LICENSE BSD Document the Copy field of vos examine output. commit 7f371c53092b6d9532c2749eefa341616ba6edc6 Author: Jeffrey Altman Date: Sun Feb 1 21:57:10 2009 +0000 windows-tests-torture-enforce-querypath-info-errors-20090201 LICENSE BSD change nb_qpathinfo() 'Flag' to a thread local storage variable 'EnforcePathInfoErrors'. Add new 'Type' values that permit the enforcement to be turned on and off as needed by the test script. Populate the IoBuffer with the low byte of the pid value. ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE BSD Verified the state of every file's existence at every Query Path Info call in the script. Added 'Type' == 1 (Does not Exist) as needed. Removed the use of 'Type' == 1111 to disable enforcement part way through. commit 652c361054491e1b518451646b45a19dd32f9a69 Author: Jeffrey Altman Date: Sun Feb 1 00:26:40 2009 +0000 windows-tests-torture-scripts-20090131 LICENSE MIT Add some additional example scripts commit 3769240ac4c3c54933245dc09740447b97b6cc2c Author: Jeffrey Altman Date: Sun Feb 1 00:18:26 2009 +0000 windows-tests-torture-source-20090131 LICENSE MIT Do not unload afsrpc.dll as it cannot clean up after itself and become safe to reload. Instead of reporting that the AFS client is off-line, report the path that is unreachable. commit 5981379dea329800f88a12a74ea34402e63b789d Author: Jeffrey Altman Date: Sat Jan 31 17:05:02 2009 +0000 windows-tests-torture-20090131 LICENSE MIT rename torture.exe to wintorture.exe to match the name expected by stress.exe increase length of "Locker" to permit longer paths do not strip \\afs unc server name. treat all unc paths equal add GetLastError values to logged error messages clarify error messages when missing input params print all errors on a single line. quote paths and command strings fix the initialization of the IoBuffer for writes. initialize the whole buffer not just the sizeof(pointer) remove the static declaration of Flag in nb_qpathinfo() obtain real HANDLEs for directories. Do not fake them. commit 1e01bdc8e1b7ee4d9da36a1bb5899ca51daf2748 Author: Jeffrey Altman Date: Sat Jan 31 06:42:39 2009 +0000 windows-tests-20090130 LICENSE BSD build all of the tests commit 7c4ceecbd9d71e7f27ffd81598badeee36e6f17f Author: Jeffrey Altman Date: Sat Jan 31 06:39:48 2009 +0000 windows-tests-torture-20090130 LICENSE MIT Port to Win64 Integrate with OpenAFS build environment Build without warnings Add nb_flush() implementation commit e01ffce669318890484bf468c0b641336d10515b Author: Jeffrey Altman Date: Sat Jan 31 03:42:29 2009 +0000 windows-tests-largefiles-20090130 LICENSE BSD permit the largefiles test to build under the openafs build system commit b557da03d5089749b37ae356cadb4d00ff6d5af5 Author: Jeffrey Altman Date: Sat Jan 31 03:37:18 2009 +0000 windows-test-winflock-20090130 LICENSE BSD permit winflock to build under the openafs build system commit a9bc4bf32c959698e6ec3a361e94382f9500f85c Author: Asanka Herath Date: Sat Jan 31 03:08:55 2009 +0000 windows-tests-nm-20090130 LICENSE BSD A test application that produces verifiable random test files. ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE BSD make it build in the openafs build tree commit 175393288df30ca88178ee98cdfff364bffbabb7 Author: Simon Wilkinson Date: Fri Jan 30 14:36:13 2009 +0000 linux-vmtruncate-20090130 LICENSE IPL10 FIXES 124128 use linux's vmtruncate feature instead of doing a somewhat-right internal version commit ff795a12c50d0fa59d2b3ad0b383309b9a4e939d Author: Tom Keiser Date: Thu Jan 29 17:06:41 2009 +0000 dafs-vnode-close-race-20090129 LICENSE IPL10 FIXES 124223 address race between VCloseVnodeFiles_r and VGetFreeVnode_r commit 47e99e36fd40c55be7a5d947fb096d6f6f2c0ae4 Author: Derrick Brashear Date: Thu Jan 29 16:05:05 2009 +0000 discon-diskslot-linux-20090129 LICENSE IPL10 build in the linux case on non-disconnected commit df139845e9f83cd15f3b0ab8dcbb27781c811642 Author: Derrick Brashear Date: Wed Jan 28 22:39:04 2009 +0000 discon-remove-fix-20090128 LICENSE IPL10 fix my own error commit 35cc76c21ebb48a2257254798a57afac083896ee Author: Jeffrey Altman Date: Wed Jan 28 22:33:17 2009 +0000 rx-no-more-register-20090128 LICENSE BSD kill off use of register in rx commit 226cf894b65c62225785180dfeeed0ec1c1a160b Author: Jeffrey Altman Date: Wed Jan 28 21:34:33 2009 +0000 rx-pthread-mutex-protects-threadcount-20090128 LICENSE BSD add protection of previously unprotected thread count variables commit 7cd7bcdc4ca6787e19c12485f70fabb8f4f9f00b Author: Simon Wilkinson Date: Wed Jan 28 21:13:58 2009 +0000 discon-avoid-looping-on-replay-20090128 LICENSE IPL10 FIXES 124203 don't defer based on a shadow copy commit cc2f0d2bc52e980c376188888faa27cd37b0eccc Author: Simon Wilkinson Date: Wed Jan 28 21:02:16 2009 +0000 disconnected-reply-no-locking-yet-20090128 LICENSE IPL10 FIXES 124202 don't lock files before replaying changes yet commit 1cca08960b263baabcf7f86b1596f07fb8449223 Author: Jeffrey Altman Date: Wed Jan 28 20:35:50 2009 +0000 rx-atomic-macros-and-variables-20090127 LICENSE BSD adds macros to support accessing some variables as atomics, when atomic support is available; otherwise falls back to mutex-protected access. commit af61732e4aaac8e09369addde0ec31a88fad8964 Author: Derrick Brashear Date: Wed Jan 28 15:52:42 2009 +0000 disconnected-deal-with-unlink-while-open-20090127 LICENSE IPL10 FIXES 124178 treat something as unlinked until a rename suceeds, then let that win commit 50d57f6c7b325cb9576f33845cac60e1523f661e Author: Jeffrey Altman Date: Tue Jan 27 17:49:05 2009 +0000 rx-windows-debugging-20090127 LICENSE MIT separate rx debugging from cache manager debugging. assign bit 5 of the TraceOption registry value to activation of rx debug output via DebugOutputString(). commit 306a7761b3f2f7ec0d2909e1048ecd39e9c9cfd7 Author: Jeffrey Altman Date: Tue Jan 27 17:09:22 2009 +0000 windows-libafsrpc-20090127 LICENSE MIT confirmed that rx_ReadvProc, rx_WritevProc, and rx_WritevAlloc are properly implemented for Windows. Add them to the public export list. Add rx_ReadProc32 and rx_WriteProc32 to the public export list. commit bc558c75dcad12c7f45443c8e191b554b5d0c887 Author: Jeffrey Altman Date: Tue Jan 27 17:06:05 2009 +0000 windows-dcache-20090127 LICENSE MIT Use the optimized rx_Read32 call instead of the slower rx_Read when reading 32-bit integer values. commit 72d502be69ea3208634bb0665fd37e990d1fa38e Author: Mike Meffie Date: Tue Jan 27 14:24:23 2009 +0000 dafs-vol-offline-race-20090127 LICENSE IPL10 FIXES 124215 avoid race when taking volumes offline in dafs commit a4f63a818eea476efa456132ca6112329ef8a484 Author: Jeffrey Altman Date: Tue Jan 27 06:04:32 2009 +0000 rx-windows-xmit-20090126 LICENSE MIT The WinSock API does not include the Posix recvmsg/sendmsg interfaces. Beginning with XP/2003 Microsoft began to support WSARecvMsg which is a mostly compatible implementation of recvmsg. In Vista/2008 Microsoft began to support WSASendMsg a mostly compatible implementation of sendmsg. Neither are part of the WinSock API and therefore they must be loaded at runtime via a WSAIoctl() call to obtain the function pointers. When the functions are available it is now possible to avoid a large number of memcpy() calls. This patch also enables UDP port unreachable messages on XP and above. commit 6e8039e8a55056f19895036ef6784f4fab5ab758 Author: Jeffrey Altman Date: Mon Jan 26 22:53:48 2009 +0000 rx-slow-write-packet-20090126 LICENSE MIT In rx_SlowWritePacket the use of RX_MAXWVECS was incorrect. The niovecs field is allocated as [RX_MAXWVECS+1] with the 0th element reserved for the rx header. niovecs[RX_MAXWVECS] is therefore a valid data buffer and the comparison should be (i <= RX_MAXWVECS). This error has most likely not been noticed previously because nothing in the OpenAFS source tree uses this function. commit 8552f84b8ed0bce52dab1fd168054038d6ce20a9 Author: Simon Wilkinson Date: Mon Jan 26 19:33:06 2009 +0000 discon-allow-saving-vcaches-on-shutdown-20090126 LICENSE IPL10 FIXES 124211 restructure so we can save info necessary to keep dirty changes across offline shutdown commit e42a066da153750077b154e27249b5b4862724db Author: Jeffrey Altman Date: Mon Jan 26 15:50:46 2009 +0000 windows-btree-dir-enum-20090126 LICENSE MIT Modify the cm_BPlusDirEnum interface: * add the cm_scache_t * of the directory being enumerated to the cm_direnum_t object * remove the cm_scache_t * from the cm_BPlusDirEnumBulkStat call now that it is part of the cm_direnum_t object * maintain a reference to the cm_scache_t for the life of the cm_direnum_t object. This ensures that the object cannot be recycled while the enumeration is in use. commit 7a01a35adfc8f3124a259e682ea1555cb9ed7df2 Author: Simon Wilkinson Date: Mon Jan 26 13:42:01 2009 +0000 disconnected-lseek-extension-20090126 LICENSE IPL10 FIXES 124200 make extending a file by lseek make the extension-created parts as cache chunks commit d2960e5442bb7a7f4730d2a918d8cfb5a409d05c Author: Simon Wilkinson Date: Sun Jan 25 14:52:37 2009 +0000 disconnected-symlink-support-20090125 LICENSE IPL10 FIXES 124177 allow creation of symlinks while disconnected commit 58ab0e7c58e1e8cde3fd7595d25b3537062276b3 Author: Simon Wilkinson Date: Sun Jan 25 14:48:14 2009 +0000 disconnected-clear-cstatd-on-reconnect-20090125 LICENSE IPL10 FIXES 124180 don't treat any information we forged as being valid while offline as valid commit b690aa8f8139c2b52a1d0dca12e89aad57a9161d Author: Simon Wilkinson Date: Fri Jan 23 15:20:32 2009 +0000 linux24-update-20090123 LICENSE IPL10 make things work on linux 2.4 again commit c93e751599db8b8b1515a400ce398a4d365be782 Author: Simon Wilkinson Date: Fri Jan 23 14:44:31 2009 +0000 disconnected-allow-larger-directories-20090123 LICENSE IPL10 FIXES 124182 allow directories larger than a chunk commit 9093f0cf1594c72d9849ed6d4d9ab1532d0185c5 Author: Simon Wilkinson Date: Fri Jan 23 14:31:22 2009 +0000 linux-nfstrans-test-20090123 LICENSE IPL10 test for nfs translator before enabling commit 6742f2054ac96bcec19c01d408542c94de9a55f1 Author: Matt Benjamin Date: Thu Jan 22 21:49:03 2009 +0000 fbsd-ustrategy-20090122 LICENSE IPL10 make freebsd ustrategy correct commit 85fa1b132ae93a48dfb73155921245106f31f586 Author: Mike Meffie Date: Thu Jan 22 21:42:28 2009 +0000 hpux-readdir2-prototype-20090123 LICENSE IPL10 FIXES 124187 fix typo in prototype commit 6784222ac1741d9da18ba5d66fdd5057343ab8b1 Author: Matt Benjamin Date: Thu Jan 22 21:38:45 2009 +0000 fbsd-ignore-sigsys-20090123 LICENSE IPL10 FIXES 123867 wrong but a step forward commit 35a760632da0f15240153cb17ae96e0981e2c8c4 Author: Matt Benjamin Date: Thu Jan 22 21:28:29 2009 +0000 obsd44-pass1-20090123 LICENSE IPL10 FIXES 123830 first pass at openbsd 4.4 commit db15872a7ee0d1c666502f8da8c8c27c36159110 Author: Derrick Brashear Date: Thu Jan 22 21:19:47 2009 +0000 klog-krb5-link-order-20090122 LICENSE IPL10 match the (bad) link order used elsewhere commit 90f9073dde7041534d448083eaeabbc61d7563f9 Author: Derrick Brashear Date: Thu Jan 22 20:19:51 2009 +0000 disconnected-no-inline-on-irix-20090122 LICENSE IPL10 make this compile on irix commit 396b573b12a509b7e0d8d5094ebadc12c6aa8b45 Author: Derrick Brashear Date: Thu Jan 22 20:11:45 2009 +0000 disconnected-call-makedir-with-correct-casting-20090122 LICENSE IPL10 another find by the irix compiler. commit d6c5d0bbb09f84476d7928e62921a4aa01cd17ed Author: Derrick Brashear Date: Thu Jan 22 19:33:04 2009 +0000 bcdb-listdumps-argument-fix-20090122 LICENSE IPL10 prototype caught this. oops. commit 92cf4d996f91e895b8995d41419b32843a40b9fb Author: Derrick Brashear Date: Thu Jan 22 19:12:40 2009 +0000 volserver-manage-inuse-better-20090122 LICENSE IPL10 FIXES 124142 V_PEEK/V_SECRETLY should not change inUse. servertype based inUse should not leak past giving back a volume. commit 1d70f4e14e991326d8d7e6d3d3f179179a7aaf45 Author: Jeffrey Altman Date: Thu Jan 22 15:40:07 2009 +0000 bucoord-ubik_call-no-more-20090122 LICENSE MIT replace ubik_Call(RPC, ...) with ubik_RPC(...) commit d4b17a6e2e08c41de8ee07721029469ebcde6f72 Author: Jeffrey Altman Date: Thu Jan 22 15:28:54 2009 +0000 ubik_Call-no-more-20090122 LICENSE MIT remove more ubik_Call(RPC, ...) calls and replace them with ubik_RPC(...) commit 69bab4cc6ee68ab98b6f207f6ab80352250f6b97 Author: Peter Tripician Date: Thu Jan 22 15:15:55 2009 +0000 util-volparse-20090122 LICENSE IPL10 FIXES 84846 avoid some infinite loops on bad input ensure that all partition ids are within the legal limit provide prototypes for strlcat and strlcpy when the openafs implementations are being used. commit f11480748cd682f60e81e8854e254fe964d5955c Author: Marc Dionne Date: Thu Jan 22 14:28:27 2009 +0000 salvager-sensible-chdirlessness-20090122 LICENSE IPL10 FIXES 124154 make salvager look for and create headers in the right place. commit 81e1d5403438929bc6380c05bdacb808a31aaa37 Author: Simon Wilkinson Date: Wed Jan 21 21:33:32 2009 +0000 disconnected-linux-dont-inactive-while-disconnected-20090121 LICENSE IPL10 FIXES 124175 possibly not the ultimate right fix but it will make things work for now commit 0593374e2de0da391ea793e45ca08d6c971d8f86 Author: Simon Wilkinson Date: Wed Jan 21 21:27:42 2009 +0000 disconnected-pioctl-error-recovery-20090121 LICENSE IPL10 FIXES 124174 make reconnection possible by doing error recovery commit 4045f3d5350955de91e019b09ad2ed7941f6dadb Author: Simon Wilkinson Date: Wed Jan 21 21:17:09 2009 +0000 disconnected-shadow-directory-fixes-20090121 LICENSE IPL10 FIXES 124173 fix bugs in disconnected's directory shadowing commit cc42d05324c6a3dc619192a997125ca8f3a595fd Author: Simon Wilkinson Date: Wed Jan 21 21:14:48 2009 +0000 disconnected-replay-fixes-20090121 LICENSE IPL10 FIXES 124172 updates to fix bugs in disconnected change replays commit 0fb28687b498bd4cd7994fd388c3eef2f4cd17f9 Author: Jeffrey Altman Date: Wed Jan 21 21:04:11 2009 +0000 windows-avoid-rwevent-collision-part-two-20090121 LICENSE MIT don't leave out the size of the buffer. commit 10ecf76d281dc90a4f83f0c45404712b62bcea8b Author: Jeffrey Altman Date: Wed Jan 21 21:00:59 2009 +0000 windows-avoid-rwevent-collision-20090121 LICENSE MIT Prevent multiple smb_Server threads from sharing the same EVENT object when they are each waiting for their own packet requests to complete. commit a268678326f3713a0ba41f69a1432bd1fca2872f Author: Simon Wilkinson Date: Wed Jan 21 20:09:07 2009 +0000 rename-conn-to-afs-conn-20090121 LICENSE IPL10 FIXES 124116 based on patch from daleg@elemental.org. rename to avoid conflict with opensolaris ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE IPL10 FIXES 124116 based on patch from daleg@elemental.org. rename to avoid conflict with opensolar is ==================== LICENSE IPL10 FIXES 124116 based on patch from daleg@elemental.org. rename to avoid conflict with opensolar is commit 9cc62beeb985745475ac7b3ecc5bf61c2fa06a9d Author: Simon Wilkinson Date: Wed Jan 21 14:32:27 2009 +0000 darwin-no-vprintf-20090121 LICENSE IPL10 restore old behavior for mac client commit 541897d10d96805be841e56ad1f824c8abe2c07d Author: Jeffrey Altman Date: Wed Jan 21 14:32:08 2009 +0000 windows-installer-wix-20090121 LICENSE MIT remove man page files that no longer exist on the head commit a0fd9b17334333e257ae9c476c4fbf85ee9fec95 Author: Jeffrey Altman Date: Tue Jan 20 04:35:53 2009 +0000 windows-smb-parse-ascii-block-20090119 LICENSE MIT smb_ParseASCIIBlock() may be called with more than just data type ASCII (0x4). If the type is 2, 3, or 4 the data field is a null terminated string. If the type is 1 or 5 the data field is a counted string. if the type is 2 the data field is never Unicode. In any case, if the type is unrecognized smb_ParseASCIIBlock() will return NULL and all of the callers must be prepared to handle it. If the return is NULL, the smb request will fail with CM_ERROR_BADSMB. commit e5a6c3f62dde6bc1b6a26957b866c3f27dc28c3a Author: Steven Jenkins Date: Tue Jan 20 03:29:01 2009 +0000 undo-rename-residency-from-mrafs-to-osd-20090119 LICENSE IPL10 FIXES 124130 restore the mr-afs names until such time as the pioctl registrations are addressed. commit 8c18c62dffa23557fb521950eede4252cdafc0b5 Author: Jason Edgecombe Date: Mon Jan 19 23:02:36 2009 +0000 man-page-pts-membership-fixes-20090119 FIXES 124157 LICENSE BSD More wording and typo fixes for the pts membership man page. commit 5e1859a88e8133904f1315833c17851d7e6d10a4 Author: Derrick Brashear Date: Mon Jan 19 20:53:42 2009 +0000 linux-init-script-uses-bash-20090119 LICENSE IPL10 FIXES 124056 note the script uses bash commit dc0b96f5b7ee3f5f95639dfd5afb98ecb4ff6885 Author: Simon Wilkinson Date: Mon Jan 19 19:42:32 2009 +0000 disconnected-extend-truncation-20090119 LICENSE IPL10 FIXES 124094 implement extending truncation so disconnected works commit 57744971179a8ee7441e73eeb9e2a56d671fcc37 Author: Simon Wilkinson Date: Mon Jan 19 19:39:12 2009 +0000 abstract-reset-vcache-20090119 LICENSE IPL10 FIXES 124147 abstract vcache resetting code so disconnected can reuse it commit 9ef65a789feed5007f18041d259f0ddd6c3c97e9 Author: Simon Wilkinson Date: Mon Jan 19 19:27:00 2009 +0000 afs-q-improvements-20090119 LICENSE IPL10 FIXES 124134 simplify afs_q macros and allow further reuse in disconnected commit e1cc987ea57c03a93dd02164ecb75cd705fc79b3 Author: Simon Wilkinson Date: Mon Jan 19 18:47:52 2009 +0000 disconnected-flush-before-shadowing-20090119 LICENSE IPL10 FIXES 124149 make touch a fs discon offline rm -f a fs discon online work commit 92c7925b12d7b99e4ff044bc053330e77336a21a Author: Steven Jenkins Date: Mon Jan 19 18:09:06 2009 +0000 rename-residency-from-mrafs-to-osd-20090119 LICENSE IPL10 FIXES 124130 rename mrafs commands into their equivalent osd versions; structures etc are the same. commit 9fa51694c6a41323cfeb7b41bb4dff9e8dac77be Author: Simon Wilkinson Date: Mon Jan 19 17:29:08 2009 +0000 linux-disconnected-avoid-ls-hang-20090119 LICENSE IPL10 FIXES 124152 avoid allowing a non-CStatd vcache to make its way into a readdir which causes an infinite loop commit df71f42b637c5ef2aa266a709720b35e65b8e27f Author: Derrick Brashear Date: Mon Jan 19 03:25:10 2009 +0000 krb5-klog-link-rule-20090118 LICENSE IPL10 this was just wrong commit dbc73f43ee64072509ee0ae66cf7499ff9e5d861 Author: Derrick Brashear Date: Mon Jan 19 03:19:01 2009 +0000 volser-setflags-clear-callptr-20090118 LICENSE IPL10 make things calling SetFlags not error commit d781450cf3c08bf89f3d1490620ed89885f7e518 Author: Russ Allbery Date: Mon Jan 19 03:09:52 2009 +0000 man-page-pts-membership-privilege-20090118 FIXES 124151 LICENSE BSD Add system:ptsviewers to the privilege documentation of pts membership and try to clarify the privilege required by being less verbose and hopefully more direct. commit 24a5d12bae9a2af393f3641055893824c71a4712 Author: Marc Dionne Date: Thu Jan 15 13:26:55 2009 +0000 linux-2629-20090115 LICENSE IPL10 FIXES 124115 add 2.6.29 support commit 86225b60147d58ca71063a72be02236df1257407 Author: Chaskiel M Grundman Date: Thu Jan 15 13:12:58 2009 +0000 osi-probe-check-result-cope-with-enoent-20090115 LICENSE IPL10 in order for probing to work right commit 3394644531fb89b02ffbe0c10f4a51c3a4169a39 Author: Jeffrey Altman Date: Wed Jan 14 06:34:08 2009 +0000 rx-afs-kmutex-kcondvar-20090113 LICENSE BSD The rx_pthread.h defines afs_kcondvar_t and afs_kmutex_t but their use throughout the rx library is inconsistent. Sometimes they are used, other times pthread_cond_t and pthread_mutex_t. This commit ensures that afs_kmutex_t and afs_kcondvar_t are used consistently. commit e6d60f58e2a6b7ac9964cfb1ec753decd5d6ed91 Author: Simon Wilkinson Date: Tue Jan 13 19:37:03 2009 +0000 linux-truncate-cleanup-20090113 LICENSE IPL10 fix the patch to actually be applicable commit f1a13e15625afa324ffc6614eea432dcc89bf768 Author: Jeffrey Altman Date: Tue Jan 13 16:19:11 2009 +0000 rx-make-rxdebug-optional-20090113 LICENSE BSD Permit the rx library to be built without the RXDEBUG preprocessor definition. When RXDEBUG is not defined all of the debugging functions either become stubs or log a message indicating that the library was built without RXDEBUG so that there will be no surprises. There are no changes to the export list. By default RXDEBUG is defined. Eventually the definition of RXDEBUG can become a configuration option to the build system. commit 510b2042b017776366ed33e9590b81fc5c5c8b6c Author: Jeffrey Altman Date: Mon Jan 12 20:22:24 2009 +0000 rx-finer-grained-locking-20090112 LICENSE MIT fix typo in rx-finer-granded-locking-20090112 commit ba9556ff2bbf854bb5c05074032b94973bf339ec Author: Matt Benjamin Date: Mon Jan 12 14:33:09 2009 +0000 freebsd-cleanup-20090112 LICENSE IPL10 FIXES 124107 minor freebsd cleanup commit 45e808945627b36ab1dbb64b6fafa8ed7b1901b6 Author: Marc Dionne Date: Mon Jan 12 14:18:58 2009 +0000 linux-i-size-20090112 LICENSE IPL10 FIXES 124106 use i_size_read macro correctly commit 47ac8ba7022e80e5bc0023782b6b27d5ac97ccd3 Author: Andrew Deason Date: Mon Jan 12 14:11:36 2009 +0000 libuafs-set-fileoffsetbits-20090112 LICENSE IPL10 FIXES 124093 make libuafs work with things which expect to be able to use native file sizes etc commit 434ad307430fc12968abd65e007f8e606aa55917 Author: Marc Dionne Date: Mon Jan 12 13:28:42 2009 +0000 linux24-no-backing-dev-20090112 LICENSE IPL10 FIXES 124100 backing_dev_info isn't in 2.4 commit d158ddb25c769d357d5f58acbd911ec7a7281343 Author: Rainer Toebbicke Date: Mon Jan 12 13:24:13 2009 +0000 fetch64-fstrace-typo-20090112 LICENSE IPL10 FIXES 124113 move l to correct side of % for type printing commit 30cfed8e25dfcc6c423d1e121360f048d6724328 Author: Jeffrey Altman Date: Sun Jan 11 05:53:36 2009 +0000 rx-statistics-active-flag-20090110 LICENSE MIT Permit rx statistics gathering to be disabled by setting the new rx_stats_active variable to 0. This avoids grabbing the rx_stats_mutex throughout the execution of the requests and permits greater concurrency thoughout the library. commit 887a6eb59b5aa87bc8a5c3ec1fc78f80ac19a6f2 Author: Jeffrey Altman Date: Sun Jan 11 05:27:01 2009 +0000 rx-finer-grained-locking-20090110 LICENSE MIT not everything should be under the rx_stats_mutex. doing so results in too much lock contention. add new mutexes: rx_quota_mutex, rx_waiting_mutex, rx_pthread_mutex, and rx_packets_mutex. Each new mutex protects an associated group of variables. commit 5b0e23567e1ed64f448bb3253ad90d39cad31271 Author: Jeffrey Altman Date: Sun Jan 11 04:24:37 2009 +0000 rx-user-socket-buffer-sizes-20090110 LICENSE MIT if the socket buffer size specified by the configuration is too large to be applied, do not drop down immediately to 32766 bytes. Instead try increasingly smaller values trying to find the largest one that works. use the same value for the send buf size as well. commit 3162fdd59201e1615e2fe700ec003e81c7c932bf Author: Jeffrey Altman Date: Sun Jan 11 04:00:07 2009 +0000 rx-rwlocks-no-more-20090110 LICENSE MIT remove the use of rwlock and restore the use of mutexes. the rwlocks are actually slower in performance testing. commit f49bf1d919b48901533da78c9fe38ca0339b7bca Author: Simon Wilkinson Date: Fri Jan 9 15:09:14 2009 +0000 linux-truncate-race-20090109 LICENSE IPL10 FIXES 124094 avoid a race during truncation which trips an issue when fsx is run commit 2d07a62c38fea642d52c20ff86e8f72e3c16bbe0 Author: Andrew Deason Date: Fri Jan 9 14:50:48 2009 +0000 ac-verbatim-include-undefs-20090109 LICENSE IPL10 FIXES 124077 the undefs for things which are not ac macros ended up outside the ac verbatim blob. fix it. commit 80fc888a9223050481de932233fe7121a48df194 Author: Derrick Brashear Date: Tue Jan 6 13:40:04 2009 +0000 netrestrict-no-wildcard-20090106 LICENSE IPL10 don't misadvertise network wildcard support commit 423ab97eee35f57beeb481cac2159d28dea20577 Author: Jeffrey Altman Date: Mon Jan 5 23:12:54 2009 +0000 rx-do-not-race-current-packet-20090105 LICENSE MIT Throughout rx_rdwr.c functions allocate a register variable 'cp' which is used to optimize access to call->currentPacket. Unfortunately, if the call->lock is dropped (for example, CV_WAIT) the synchronization between the two is lost. This delta re-syncs 'cp' and call->currentPacket after each location where the call->lock may be dropped. commit e7edfbbf2204641ba08d0ae5e0d085e5f913f2d2 Author: Jeffrey Altman Date: Mon Jan 5 18:16:44 2009 +0000 windows-license-smgl2rtf-20090105 LICENSE MIT Ensure that the input string is nul terminated and then instruct WideCharToMultiByte to compute the length itself instead of passing in a value that is very likely to be wrong. commit 8c4b06a5b62a07d4d6733b313ad404e1cb6abe8d Author: Jeffrey Altman Date: Mon Jan 5 16:20:08 2009 +0000 windows-afsd-freelance-20090105 LICENSE MIT Bring a bit more sanity to the Freelance code: 1. Add functions cm_FreelanceFetchMountPointString and cm_FreelanceFetchFileType to cm_freelance.c. These functions permit the MountPointString and FileType to be obtained within cm_GetSCache without requiring knowledge of data structures that should be private to cm_freelance.c 2. Enforce the rule that odd vnode values are directory objects. The root directory is 1 and everything else must be a multiple of two. 3. Use the unique field as an index into the localMountPoints array. 4. Fix cm_GetCallback to process freelance data refreshes on all objects in the freelance volume not just the root directory. If this is not done, an access to \\afs\foo prior to \\afs\all being evaluated will cause an unnecessary attempt to send a fetch status request to a file server and produce an alldown error. commit 02cd4c510b2b9e2293e33372c39bd8b62089236b Author: Jeffrey Altman Date: Mon Jan 5 00:00:08 2009 +0000 rx-packet-count-debugging-20090104 LICENSE MIT change C preprocessor symbol required for packet count debugging to RXDEBUG_PACKET commit bf51eaca47db1bbf58490d770f1be105e69f7ea9 Author: Jeffrey Altman Date: Sun Jan 4 19:19:31 2009 +0000 windows-client-config-manifest-20090104 LICENSE MIT FIXES 123889 reverse change from 20081226. removing the auto-generated manifest removes the manifest binding to the run time library. The reason two manifests are specified is that we are merging them. commit 29e3bb5838ee224e8d13bf1e680e1eb9480f1400 Author: Jeffrey Altman Date: Mon Dec 29 22:36:32 2008 +0000 rx-packet-count-debugging-20081229 LICENSE MIT Validating the state of the rx library is hard. This patch makes it a bit easier to validate from within crash dumps (or on Windows in "fs memdump" output) whether rx packets and calls are in a sane state. When the library is compiled with -DDEBUG the rx_call and rx_packet data structures are extended to include a linked list of all allocated objects and counters are added to track the number of packets on each of the transmit, receive, and iovec queues. This compliments the tracking of packet states via RX_PKTFLAGs. For Windows, rx_DumpCalls and rx_DumpPackets functions are added that will dump the state of all allocated calls and packets (in Checked build) in response to a "fs memdump" command. These functions are exported from afsrpc.dll. commit 3d44f93f9a0b1d2d4a07b58b3104420e9c138d12 Author: Andrew Deason Date: Mon Dec 29 21:26:00 2008 +0000 libuafs-updates-20081229 LICENSE IPL10 FIXES 124072 adds ATTR_* constants for UKERNEL code, and makes use of them. Without this in some cases updating file metadata will also update unrelated metadata (e.g. truncating a file changes the mode bits). adds threadsafe positional i/o calls to afs_usrops.c: uafs_pwrite and uafs_pread, allowing for threadsafe libuafs i/o. changes the types of some fs-related variables to be more "correct", I think (off_t for offsets, mode_t for file mode, etc), it fixes a bug where nDaemons is not correctly set from the uafs_Init parameter, fixes a segfault in uafs_open when O_CREAT is specified, initializes a couple of static vars, "#if 0"s out code that copies tokens from kernel-space to user-space (doesn't seem to work from what I've seen, and the current code crashes on clientless Solaris machines from being killed by SIGSYS) commit c11eb4c3336f66a3f0fd92c3df41eb9765de050c Author: Derrick Brashear Date: Mon Dec 29 17:29:06 2008 +0000 macos-103-fixes-20081229 LICENSE IPL10 make macos 10.3 work again commit d0cc6eb2f5f0aea0a6ad88de2d847f93d07cc8b9 Author: Jeffrey Altman Date: Sun Dec 28 21:04:23 2008 +0000 rx-rdwr-writeproc-race-20081228 LICENSE MIT FIXES 123799 prevent rx_WriteProc() from passing a packet to rxi_PrepareSendPacket() that has been freed and possibly allocated to another call. commit 8f3e660270d9c1af268ba45118ab87740fbeeef8 Author: Jeffrey Altman Date: Sun Dec 28 04:41:38 2008 +0000 windows-smb-fs-attr-info-20081227 LICENSE MIT even though the docs for FILE_FS_ATTRIBUTE_INFORMATION state that the MaximumComponentNameLength field is in bytes, it turns out that Windows SMB servers return the value in characters. Reduce the reported value to 255 to match NTFS. commit f70ba203206a2953a3f51b48fe3455b9cad52eae Author: Jeffrey Altman Date: Sat Dec 27 19:22:26 2008 +0000 windows-libafsrpc-makefile-20081227 LICENSE MIT additional defines are to be appended to AFSDEV_AUXCDEFINES, they are not supposed to replace the prior definition commit a09a1709f646087c2ceb6f484b45b48495ea1127 Author: Jeffrey Altman Date: Sat Dec 27 06:01:09 2008 +0000 windows-afsd-fs-attr-info-20081226 LICENSE MIT Pointed out by jason edgecombe. the AFS SMB server failed to report the FILE_UNICODE_ON_DISK characteristic when responding to TRANS2_QUERY_FS_INFORMATION. commit f18b54bfe647cfee6a7072d11df04019161d8223 Author: Jeffrey Altman Date: Sat Dec 27 02:53:55 2008 +0000 windows-install-nsis-20081226 LICENSE MIT permit the location of the NSIS application to be configurable commit 06468cb9393aca2c58cc75ee51bfb50f56957c52 Author: Matt Benjamin Date: Sat Dec 27 02:27:34 2008 +0000 windows-client-config-manifest-20081226 LICENSE BSD FIXES 123889 remove extraneous reference to the output manifest file which resulted in two manifests being generated with conflicting UAC values. commit 61aa1b199c28abc763456b35a644047cb9bafc18 Author: Jeffrey Altman Date: Fri Dec 26 23:40:14 2008 +0000 windows-afsd-btree-lookups-20081226 LICENSE MIT when performing a lookup operation it is acceptable for the data version of the btree to be greater than the data version of the cm_dirOp_t under which the operation is being performed. No change to the btree can take place and the result of the lookup will maintain consistency without requiring an additional restart of the directory operation. commit 4435c4fdcc6ba21b86277cfd09b0dfa1b88989c5 Author: Jeffrey Altman Date: Fri Dec 26 23:34:26 2008 +0000 windows-afsd-dir-prefetch-20081226 LICENSE MIT when prefetching the directory buffers do not call cm_FlushFile to discard locally modified buffers. Instead just set the cm_scache_t bufDataVersionLow to the current version. out of date buffers will therefore be ignored without requiring that locks be dropped and reacquired and without searching all of the buffers associated with the directory. commit 9784a9f0cc35cf485c5f9533db9dd8247df3b7c3 Author: Jeffrey Altman Date: Fri Dec 26 23:29:22 2008 +0000 windows-afsd-max-daemons-20081226 LICENSE MIT permit the number of daemon threads to be increased to 64 instead of a maximum of 8. commit 9e2d9f6fa8862d33dfc7352c961f7945d0e04f4f Author: Jeffrey Altman Date: Fri Dec 26 23:26:09 2008 +0000 windows-afsd-rename-collision-20081226 LICENSE MIT Do not permit cm_Rename() to rename an existing object such that it creates a case-insensitive name collision with another object. This change in behavior is consistent with the restrictions when creating new objects. This change prevents the explorer shell from getting confused when it creates a new folder. commit 238ad07e13a85366bcf49a309e3735d26ff51ff2 Author: Jeffrey Altman Date: Fri Dec 26 21:17:49 2008 +0000 windows-pioctl-drive-subst-20081226 LICENSE MIT GetDriveType() will return "REMOTE" for drive letters that are mapped to network devices via the SUBST command. Recursively check drive letters for the final substitution before checking to see if the drive letter is in fact an AFS device. commit 411a63fb063cf24d6b9aedeb83df2eb58716e239 Author: Matt Benjamin Date: Tue Dec 23 20:42:38 2008 +0000 windows-afsd-findserverbyip-refcount-20081223 LICENSE BSD FIXES 124054 reference count the server object returned by cm_FindServerByIP commit 556b9780517376c688c965dd446506cac1a0353b Author: Derrick Brashear Date: Mon Dec 22 20:34:12 2008 +0000 solaris-largepartition-interface-20081222 LICENSE IPL10 add support for using statvfs64 on solaris commit 72cb3a5f18f0483515dd82f8c851309003cf3a2f Author: Derrick Brashear Date: Mon Dec 22 19:22:57 2008 +0000 ubik-serverinit-clones-correction-20081222 LICENSE IPL10 as pointed out by Simon Wilkinson commit d2ae1c99523ac4150a0d5536593781dbccfc1408 Author: Tom Kula Date: Mon Dec 22 19:01:46 2008 +0000 vol-dump-incr-largefile-support-20081222 LICENSE IPL10 FIXES 123984 add large file support for >2gb dumps; add incremental support commit 0c52c9b3d900f610822249765b6a441422361888 Author: Jeffrey Hutzelman Date: Mon Dec 22 17:30:58 2008 +0000 doxygen-getfid-correction-20081222 LICENSE IPL10 correct out param description commit c69fa8fef4de43182d9e6ebad1d5c1db71148d6d Author: Derrick Brashear Date: Mon Dec 22 17:14:36 2008 +0000 rx-idledead-only-ignore-keepalives-20081222 LICENSE IPL10 critical to not ignore e.g. other acks commit 992ec096332c31f64e8cff66e20d2ab87708485f Author: Jeffrey Altman Date: Sun Dec 21 06:05:12 2008 +0000 rxgen-cpp-definition-20081221 LICENSE MIT FIXES 124011 avoid "ologo" compilation error messages due to buffer overflow in rxgen on Windows. research performed by mlane@sinenomine.net. commit 46abfec0c74e6a1d4c5c76afcd24192484e2d0fa Author: Jeffrey Altman Date: Sun Dec 21 05:58:20 2008 +0000 tweak-vicelog-macros-20081221 LICENSE IPL10 add missing semi-colons left out from DELTA tweak-vicelog-macros-20081218 commit dbc92bde39361c9741828be7a2151e521c9aeef9 Author: Jeffrey Altman Date: Sun Dec 21 05:46:29 2008 +0000 audit-consolidate-open-20081221 LICENSE IPL10 FIXES 123923 fix audit-consolidate-open-20081217 which broke the Windows build. commit 12297b95885d030e5cae6bec2543bdeb3e65b5ee Author: Simon Wilkinson Date: Thu Dec 18 14:05:10 2008 +0000 tweak-vicelog-macros-20081218 LICENSE IPL10 deal with macro semicolon confusion for vicelog commit 539dc6f501459712136f574744dba196598bee0b Author: Steve McIntosh Date: Wed Dec 17 18:14:41 2008 +0000 audit-consolidate-open-20081217 LICENSE IPL10 FIXES 123923 consolidate opening auditlog in one place; make opening nonblock easier commit 8271c1674f75f80804d08e0f4ed3178b61b29eff Author: Steve McIntosh Date: Wed Dec 17 18:11:43 2008 +0000 auditlog-fids-20081217 LICENSE IPL10 FIXES 123922 make auditlog process multiple fids correctly commit dc4429487fbfc7a41f266b36d0f86ab32eb24e75 Author: Jeffrey Altman Date: Wed Dec 17 16:19:22 2008 +0000 windows-afsd-smb-error-mapping-20081217 LICENSE MIT map ENOMEM to STATUS_OUT_OF_MEMORY commit df90f5510a057d77a486a1b667f91ff63ad17fd2 Author: Derrick Brashear Date: Tue Dec 16 21:48:53 2008 +0000 irix-prototype-fixage-20081216 LICENSE IPL10 more cleanup to make prototypes match functions on irix commit dfc38ea7e950990eb4047d49892f4903b5c9b945 Author: Derrick Brashear Date: Tue Dec 16 21:05:20 2008 +0000 irix-close-vnop-typo-20081216 LICENSE IPL10 fix irix close vnop prototype to be correct commit 00d5f88fa5b09b795edf8fdf04b3a19bb577506f Author: Garry Zacheiss Date: Mon Dec 15 22:20:37 2008 +0000 butc-xbsa-64bit-linux-20081215 LICENSE IPL10 use the 64 bit libraries when built for amd64 commit 1754101972ffb9b2d36c39656dac04464c5e9798 Author: Derrick Brashear Date: Mon Dec 15 20:50:57 2008 +0000 fbsd71-like-current-20081215 LICENSE IPL10 FIXES 123917 rpc is in sys now, like in current. tweaked from matt's patch to also deal with amd64 commit c63e2541e5879fe153238ad1d774f60fa00dc0ee Author: Matt Benjamin Date: Mon Dec 15 20:37:51 2008 +0000 amd64-fbsd-20081215 LICENSE IPL10 FIXES 123811 add support for fbsd 7.1, amd64 fbsd commit b147521611a73d0578aca14b3252e062de1e5d8a Author: Derrick Brashear Date: Mon Dec 15 19:12:04 2008 +0000 aix-prototype-fixes-20081215 LICENSE IPL10 make the prototyping changes work on aix commit 7714162e9abb046e67d0fc68578a2e3d68ef2156 Author: Derrick Brashear Date: Sat Dec 13 21:30:55 2008 +0000 solaris-vnop-prototyping-20081213 LICENSE IPL10 make the head sane on solaris again commit 1f9467f9b7e3d6bc49267a32a7e2238c6d829ef0 Author: Derrick Brashear Date: Tue Dec 9 17:04:45 2008 +0000 eliminate-cplusplus-style-comments-20081209 LICENSE IPL10 aix compiler hates // style comments commit 9123966e43bc2f708baba756530aa90fcfe5e93d Author: Jeffrey Altman Date: Mon Dec 8 16:25:40 2008 +0000 windows-afsd-ntstatus-wouldblock-20081208 LICENSE MIT Change the mapping of CM_ERROR_WOULDBLOCK from STATUS_LOCK_NOT_GRANTED to STATUS_CANT_WAIT. STATUS_LOCK_NOT_GRANTED is used to indicate CM_ERROR_LOCK_NOT_GRANTED. commit 8166bd1d199f5a34225a49173b17e4682b5c3a84 Author: Derrick Brashear Date: Sun Nov 30 20:24:12 2008 +0000 missing-comerr-header-includes-20081130 LICENSE IPL10 FIXES 123676 include com_err header in places where it's not so afs_error_message et al exist commit 29457b1ca71518b29bb9e9e934c58e6fa4b9877a Author: Douglas Engert Date: Sun Nov 30 20:20:55 2008 +0000 solaris-fs-agnostic-cache-20081130 LICENSE IPL10 FIXES 123677 make the cache able to be filesystem-agnostic so a ZFS cache is possible commit 4db6293a06ff573eb650cbf9bbf53440a7ee83a2 Author: Andrew Deason Date: Sun Nov 30 20:17:13 2008 +0000 linux-nonfh-cache-file-handling-20081130 LICENSE IPL10 FIXES 123771 go back to referencing f.inode and not ainode when not using the fh cachefiles. put back the dcache reference again. commit fb549013e7bb2cf5cb3da3083349cb559c093e8f Author: Dragos Tatulea Date: Sun Nov 30 20:11:05 2008 +0000 disconnected-refcount-fixes-20081130 LICENSE IPL10 FIXES 123714 fix code which tweaks refcounts on disconnected vcaches to be correct commit 20aff72a7eae704241b67b6cf40fc92648abb1b0 Author: Dragos Tatulea Date: Sun Nov 30 20:06:35 2008 +0000 disconnected-dirty-list-keeps-reference-to-vcache-20081130 LICENSE IPL10 FIXES 123715 avoid putting vcaches on the dirty list unreferenced commit 96996e65fcd569565e78b7af79258dfad3b0d261 Author: Derrick Brashear Date: Sun Nov 30 19:49:16 2008 +0000 uphys-invalidate-returns-void-20081130 LICENSE IPL10 FIXES 123723 thanks to Hartmut Reuter for catching this. commit 0d94742ec33122b83a84eeb7a82bfd1eb8361464 Author: Derrick Brashear Date: Sun Nov 30 19:40:00 2008 +0000 libafs-prototypes-20081130 LICENSE IPL10 fix sun5 prototype for afs_close commit 55ac2b7aa7da8ead2b3457781d9d60958bfad6be Author: Jeffrey Altman Date: Sat Nov 29 18:55:25 2008 +0000 netrestrict-netinfo-20081129 LICENSE MIT Rename rxi_getAllAddrMaskMtu to rx_getAllAddrMaskMtu. Implement rx_getAllAddrMaskMtu for Windows. Add rx_getAllAddrMaskMtu to the libafsrpc exports list. Remove restrictions on use of NetRestrict / NetInfo files from all services on Windows. commit b7e12a1aec9cd3591a02023fb6e87ba6cfcb152f Author: Simon Wilkinson Date: Sat Nov 29 18:20:03 2008 +0000 libafs-prototypes-20081129 LICENSE IPL10 add prototypes missing from libafs commit deb20d02fb76e52210e44fe03e611e5d3a48a8e5 Author: Simon Wilkinson Date: Sat Nov 29 18:15:40 2008 +0000 standard-header-includes-20081129 LICENSE IPL10 add missing standard headers commit 85f1ef34c2533da2f47757bb8d8a3aecb9083283 Author: Simon Wilkinson Date: Sat Nov 29 18:08:33 2008 +0000 rxkad-prototypes-20081129 LICENSE IPL10 add prototypes for rxkad commit 5697e58a07e39eba9609685695e1718cbc9794e4 Author: Jeffrey Altman Date: Wed Nov 26 07:15:01 2008 +0000 windows-pioctl-global-auto-mapper-20081125 LICENSE MIT FIXES 123726 drive letters mapped to \\afs by the global auto mapper do not show up as mapped drives. Add a check for the drive mapping based upon the registry configuration. commit ebb2c8eacaffe25d430c4e3b3eca524ea0b6b103 Author: Jeffrey Altman Date: Fri Nov 21 16:52:40 2008 +0000 windows-afsd-memdump-20081121 LICENSE MIT add the buffer error state to the memdump output commit 9ddb573bbb7b9960430a98f32124c0cb4d5028b2 Author: Adam Vollrath Date: Fri Nov 21 07:09:42 2008 +0000 ubik-doxygen-20081121 LICENSE IPL10 FIXES 123681 restyle comments in ubik to be doxygen qt-style commit ef92a3331f25375387a99fbb690c4473ee91d945 Author: Jeffrey Altman Date: Thu Nov 20 22:56:12 2008 +0000 clones-take-two-20081120 LICENSE IPL10 FIXES 89557 commit jeff's revised version of the patch commit f3384d6378173dbaf550283851a8948654af548c Author: Jeffrey Altman Date: Wed Nov 19 12:36:39 2008 +0000 windows-smb-is-mask-20081119 LICENSE MIT FIXES 123680 Examination of dump shows that smb_IsMask is being called on a non-8.3 input buffer. Separate smb_IsMask() into smb_Is8Dot3Mask() for 8.3 input buffers and smb_IsMask() for non-8.3 input buffers. commit 122833a44eed58273e73992df815c7718ac6e4f7 Author: Tracy Di Marco White Date: Mon Nov 17 23:14:02 2008 +0000 netbsd-acinclude-typo-20081117 LICENSE IPL10 FIXES 123647 fix netbsd version tests for amd64 commit b5fea780fbb0ea12d3d086210d0abbef12e24560 Author: Derrick Brashear Date: Mon Nov 17 23:05:28 2008 +0000 aix6-lam-plugin-20081117 LICENSE IPL10 FIXES 123649 based on suggestion from Hung_Pham@unc.edu build aix5 module for aix6 commit a4177506ce59ffda41ae0cc04aeef581e3f4d305 Author: Jeffrey Altman Date: Mon Nov 17 22:28:43 2008 +0000 windows-smb-rename-20081117 LICENSE MIT FIXES 123673 avoid reference under count when renaming commit 5fe7d9c6d9482651859d91f3022ac5ae0a127835 Author: Jeffrey Altman Date: Mon Nov 17 19:08:23 2008 +0000 windows-smb-vc-uid-missing-20081117 LICENSE MIT FIXES 123655 Protect against an smb packet containing a uid for which we have no active session in the virtual circuit. commit d312166bfd2e7e877ae5559a82050f3ecc3555ee Author: Jeffrey Altman Date: Sat Nov 15 17:10:16 2008 +0000 windows-buf-clean-20081115 LICENSE MIT change the interface to buf_CleanAsync / buf_CleanAsyncLocked to permit errors to be propagated to the caller. commit ab37d70f502e3b5ebdbfe23107ac5006cc0e9a2f Author: Jeffrey Altman Date: Sat Nov 15 17:07:41 2008 +0000 windows-btree-20081115 LICENSE MIT return an error if the enumeration of the directory cannot complete because the btree has not yet been generated. commit 17b8c16000461c5b7908cdb3d923bba9a03122b5 Author: Jeffrey Altman Date: Sat Nov 15 17:05:19 2008 +0000 windows-error-mapping-20081115 LICENSE MIT do not map success (0) to an error commit bac191678f18669df4f2f5e69a033dcce4d2c38a Author: Jeffrey Altman Date: Sat Nov 15 16:47:55 2008 +0000 windows-conn-analyze-20081115 LICENSE MIT Add a delay after receiving a VBUSY before ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE MIT remove commit 0c3bf45fff85b54f6143d200b2e7884fdc1e2845 Author: Jeffrey Altman Date: Thu Nov 13 15:39:46 2008 +0000 windows-dir-prefetch-locks-20081113 LICENSE MIT cm_DirPrefetchBuffers() did not properly drop and regain the appropriate lock type y ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE MIT undo premature commit. commit 117066c481e956f7fea53a500271791db5cb375d Author: Marc Dionne Date: Thu Nov 13 13:47:52 2008 +0000 missing-linux-fh-configure-switch-20081113 LICENSE IPL10 FIXES 123620 add missing hunk to acinclude commit a3c9b01f3adae098dbd31e7b9742dec5f8081d2c Author: Russ Allbery Date: Wed Nov 12 02:30:58 2008 +0000 man-page-fileserver-fix-block-size-20081111 After code study, we've decided that additional blocks do add 32 octets, not 16, despite messages to the contrary in the archives. commit 794967ed3ec5a46329375ae19eac21c1c508c1ee Author: Jason Edgecombe Date: Wed Nov 12 02:17:49 2008 +0000 man-page-fileserver-updates-20081111 LICENSE BSD Various file server man page updates: number of partitions, partition size limits, directory file name block size, and a reference to the IBM manual set. commit 196e995b2569c7dceea8748a36431802d4875188 Author: Russ Allbery Date: Wed Nov 12 02:00:27 2008 +0000 man-page-fileserver-octet-20081111 LICENSE BSD The sizing limit on directories is better expressed in octets than in characters in the new possibly-Unicode world. commit 267472a473316fbc37e1fc5dc74e4e7f9edfa4ef Author: Derrick Brashear Date: Tue Nov 11 20:31:19 2008 +0000 viced-helper-thread-count-20081111 LICENSE IPL10 fix the thread count of helpers so we don't go past 128 commit de2044ca66f0de5bcdf0505373fb189b09cd49ef Author: Jeffrey Altman Date: Tue Nov 11 03:33:24 2008 +0000 windows-netidmgr-vs-referrals-20081111 LICENSE MIT kfw referrals logic broke the logic for automated configuration of the workstation cell with a new identity. Now if a referrals response is returned, assume the cell belongs with the new identity. In the long term, we need to change the logic as follows: 1. if realm indicates referrals, try to obtain the krb5 service ticket but do not generate a token 2. if the service ticket can be obtained and a. if the cell is not bound to any other identities, then bind it to this one b. if the cell is bound to another identity, prompt the user to ask which identity (or both) should this cell be bound to and follow the user's instruction commit 041f09e17b7e1760a968c0e38f52d7feac2862ba Author: Marc Dionne Date: Sat Nov 8 16:49:25 2008 +0000 linux-new-aop-20081108 LICENSE IPL10 FIXES 123580 support for 2.6.28 commit 4eab64ebd81305845d10c4a5fdfd1861bc41520b Author: Marc Dionne Date: Sat Nov 8 16:34:24 2008 +0000 linux-fh-based-cache-20081108 LICENSE IPL10 FIXES 123620 use linux fh (exportfs api) to do cache file access. conditionalize based on configure switch. commit 18e78d91e78e541fce6c9295919946af0744aa7e Author: Marc Dionne Date: Sat Nov 8 16:09:25 2008 +0000 linux-disable-readahad-20081108 LICENSE IPL10 FIXES 123604 The code has long contained a backing_dev_info structure, but it was never attached to anything. Initialize its use properly with bdi_init, and attach it to i_mapping for every newly filled inode. bdi_init and bdi_destroy are needed for proper initialization of some percpu counters, otherwise we get some oopses. commit 0ac956b3384842b3c60e72bde78a4baf58a5877f Author: Steve McIntosh Date: Sat Nov 8 15:58:06 2008 +0000 salvager-no-chdir-20081108 LICENSE IPL10 FIXES 123577 make sure salvager cores don't get left in vice partitions commit 35bc549bf9b6d5f1e4628621f0283d68c5808da5 Author: Jeffrey Hutzelman Date: Sat Nov 8 02:28:48 2008 +0000 cellservdb-20081107 new cellservdb from central.org commit aff6ee8987961bc2631fa5dfd599de91a2c51419 Author: Jeffrey Altman Date: Fri Nov 7 21:00:43 2008 +0000 windows-linked-cells-10081107 LICENSE MIT prevent stack overflow commit 99e202b073c35a5c7d76a66a9d9cd2d0b9a6c73d Author: Asanka Herath Date: Fri Nov 7 18:19:38 2008 +0000 windows-nim-afs-longer-cell-names-20081107 LICENSE MIT permit cell and realm names to be longer than the input field. commit fffc8d7016b3f659d111276a1657dad8acc8cf50 Author: Jeffrey Altman Date: Fri Nov 7 16:35:20 2008 +0000 windows-nim-afs-linked-cells-20081107 LICENSE MIT add linked cell support to the NIM afs provider. commit 01c4e08cf8c90c4f01a70e14a73c07e2382d3451 Author: Jeffrey Altman Date: Fri Nov 7 05:40:59 2008 +0000 windows-aklog-linked-cells-20081106 LICENSE MIT Add support for linked cells. Acquire tokens for the linked cell in addition to the specified cell. commit 32c271187ad7045abf376490ec3cbb44a6ce617c Author: Jason Edgecombe Date: Fri Nov 7 00:26:17 2008 +0000 doc-user-guide-acl-example-fix-20081106 FIXES 123331 LICENSE BSD fs sa takes a directory as its first argument. commit 68902640a2eb1d47d7dd13b3fae9d19eddf64a6e Author: Jeffrey Altman Date: Thu Nov 6 22:09:05 2008 +0000 windows-config-ipaddr-parsing-20081106 LICENSE MIT when parsing ipaddrs in CellServDB rejects addrs whose components are values greater than 255. commit a36618213694f37cd1cec660336267a38cee9344 Author: Jeffrey Altman Date: Thu Nov 6 19:18:32 2008 +0000 windows-afsd-hook-20081106 LICENSE MIT When loading the afsdhook.dll require that it be in the same directory as afsd_service.exe. This prevents LoadLibrary() from searching the PATH environment variable if it cannot be found. If the PATH environment variable contains a path in AFS, the library will fail to load and take a very long time doing so. commit eccc12fb07cc5fef660ee29fe5ebcc573b027568 Author: Simon Wilkinson Date: Wed Nov 5 21:29:06 2008 +0000 redhat-packaging-krb-conf-man-page-20081105 LICENSE IPL10 account for the new manpage commit 70fda445bd0fb8bd3e246e859b4582170ea271eb Author: Jeffrey Altman Date: Mon Nov 3 19:55:38 2008 +0000 windows-linked-cells-20081103 LICENSE MIT FIXES 123571 The Windows code base was implemented ignorant of linked cells as defined in the src/auth/cellconfig.h struct afsconf_cell. The code that made use of the afsconf_cell objects would leak the memory from the linkedCell field if is non-NULL. Add cm_SearchCellFileEx which is an extended version of cm_SearchCellFile capable of returning a linked cell obtained from the CellServDB file. Update GetCellConfig to populate the linkedCell field of the afsconf_cell structure. Modify cm_cell_t to support a linked cell name. Modify cm_GetCell_Gen() to populate the cm_cell_t linked cell and enforce that two cells are linked to each other. Modify cm_GetVolumeByID() and cm_GetVolumeByName() to perform fallback to the linked cell if the response is CM_ERROR_NOSUCHVOLUME. commit 303c70efd4cb54ad673bed5a0c438670ae2b97ad Author: Jeffrey Altman Date: Sat Nov 1 03:37:56 2008 +0000 windows-prevent-wow64-execution-20081031 LICENSE MIT prevent the 32-bit build from being executed in the wow64 environment commit 1d18280f20bacf3fa9cc650c7c64d25c72c0507a Author: Jeffrey Altman Date: Wed Oct 29 20:06:54 2008 +0000 windows-release-notes-missing-files-20081029 LICENSE MIT pulled down from 1.5 commit 50e1e59a92f38e0751384b401016ea01fe01ed8f Author: Simon Wilkinson Date: Wed Oct 29 19:43:42 2008 +0000 aklog-attempt-order-comments-20081029 LICENSE IPL10 to clarify what gets tried when and why. commit ef70f73141bf9940ec10d42c2d6ab5b6b341cdc9 Author: Max Cohan Date: Tue Oct 28 17:55:19 2008 +0000 windows-setup-utils-20081028 LICENSE IPL10 correct file name to match the file. committed broken in windows-file-versioning-20030619 commit fc78255c1dc29c55b67f7a7b4599bed141282213 Author: Simon Wilkinson Date: Mon Oct 27 23:53:23 2008 +0000 initialize-variables-to-avoid-logic-issues-20081027 LICENSE IPL10 make sure any variable whose value is used will be initialized before that value is used. (these aren't just warnings) commit f27165f13796a84cdbc36c31714781509ad25ba0 Author: Simon Wilkinson Date: Mon Oct 27 23:41:02 2008 +0000 kill-uninitialized-variable-warnings-20081026 LICENSE IPL10 kill lots of compiler warnings commit aa09aa2be151d44a9fe5008ff5931dd1892ddf35 Author: Jeffrey Altman Date: Sun Oct 26 21:52:29 2008 +0000 windows-pioctl-drive-map-20081026 LICENSE MIT a remote drive connection may not be mapped to a local drive letter. commit a824cbda621151c34dd85d00c3ee2779d839c237 Author: Jeffrey Altman Date: Sun Oct 26 21:16:57 2008 +0000 rx-rdwr-avoid-free-null-packet-20081026 LICENSE MIT avoid a potential call to rxi_FreePacket with a NULL pointer as input commit a614a8d95476ae49642d055cb0ac7942109d021e Author: Jeffrey Altman Date: Sun Oct 26 07:50:39 2008 +0000 ptutils-restricted-accessok-20081025 LICENSE MIT Fix restricted mode test when 'any' is not set on AccessOK commit 8a33059215c00f688ea38fa039b2ac53d8d26dc9 Author: Simon Wilkinson Date: Sun Oct 26 01:45:45 2008 +0000 exporter-call-gethost-method-correctly-20081025 LICENSE IPL10 actually call the correct method for EXP_GETHOST commit 3f08225c6b23f74e98b576a1ed27837989d64707 Author: Simon Wilkinson Date: Sun Oct 26 01:04:12 2008 +0000 rx-rwlock-cleanup-20081025 LICENSE IPL10 make the rwlock patch actually build everywhere commit f2014112bcc27ecc1426ef078af7456285d839d2 Author: Simon Wilkinson Date: Sun Oct 26 00:59:55 2008 +0000 aklog-chatty-20081025 LICENSE IPL10 make aklog not accidentally be chatty commit 069cd726c093d4856dc98353a75080547ea4e751 Author: Derrick Brashear Date: Fri Oct 24 22:07:01 2008 +0000 darwin-kernel-rwlocks-20081023 LICENSE IPL10 convert to kernel rwlocks on darwin commit e73e2ff4b53bfdfe16fec2d65776facae853eddd Author: Derrick Brashear Date: Fri Oct 24 21:59:52 2008 +0000 rx-atomics-for-solaris-and-darwin-20081023 LICENSE IPL10 support atomics on osx and solaris commit 23a511739b431afcec60b7f9ca681236f37b920d Author: Jeffrey Altman Date: Fri Oct 24 21:38:56 2008 +0000 rx-rw-locking-20081024 LICENSE BSD rename RWLOCK_INIT to AFS_RWLOCK_INIT in order to maintain naming consistency and to distinguish them from the new RWLOCK_INIT macros being used in rx. ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE BSD add rx/rx_internal.h as a dependency ==================== LICENSE BSD define RWLOCK_xxx operations replace MUTEX_xxx operations with RWLOCK_xxx when it is appropriate to do so. This improves concurrency on multi-processor systems. make additional use of atomic operations commit f64ecbf721dbc115103684a3d71a095854607812 Author: Jeffrey Altman Date: Wed Oct 22 02:25:25 2008 +0000 windows-reformatting-20081021 LICENSE MIT reformat some of the recent changes cast away warnings on 64-bit windows commit a7a1846ab7fb049360b2c69486b7c673d09b8b28 Author: Derrick Brashear Date: Tue Oct 21 19:36:35 2008 +0000 fd-setsize-test-20081021 LICENSE BSD a test so we can deal with platforms which don't honor FD_SETSIZE commit 9bca8ce22add91b32f45922650c429404d74797d Author: Derrick Brashear Date: Tue Oct 21 14:44:50 2008 +0000 linux24-writepage-antideadlock-20081021 LICENSE IPL10 also make this work for 2.4.x commit 6d14b44b7c83918bcd7e6e07ec365f8430ad23c5 Author: Derrick Brashear Date: Mon Oct 20 20:29:26 2008 +0000 blacklist-move-init-checks-back-into-req-code-20081020 LICENSE IPL10 revise things so we don't need to check initd outside analyze.c/InitReq ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE IPL10 since these end up being used, init them too commit 4a587356a31ac5afdf17d329a8598f70cf8bc3af Author: Derrick Brashear Date: Mon Oct 20 13:38:07 2008 +0000 linux-mmap-antirecursion-20081020 LICENSE IPL10 FIXES 120491 avoid deadlocking ourselves due to recursion when flushing pages on an mmap()ed file larger than the cache commit bc9c0a14154639d8e45554a3abeb867af9a8d0b2 Author: Marc Dionne Date: Mon Oct 20 13:34:58 2008 +0000 autoconf-262-support-20081020 LICENSE IPL10 FIXES 118058 fix the quoting and remove the tests we shouldn't need anymore commit 3ad8fba85f5b45cdd6537c3ca71717c9370cc48e Author: Derrick Brashear Date: Mon Oct 20 13:03:44 2008 +0000 blacklist-check-only-existing-servers-20081020 LICENSE IPL10 based on suggestion from haba@pdc.kth.se commit 7366eb3d46506b1fdda5ece843abd96aa76b7936 Author: Marc Dionne Date: Mon Oct 20 13:01:34 2008 +0000 blacklistonce-use-only-initd-vrequest-20081020 LICENSE IPL10 avoid using an un "initd" vrequest for server blacklisting commit 90e4242c2d7d4ce8477061469f4840212c195080 Author: Asanka Herath Date: Mon Oct 20 00:17:41 2008 +0000 windows-handle-invalid-utf16-names-20081019 LICENSE MIT FIXES 116641 Windows will deliver to OpenAFS UTF16 strings that are not valid Unicode and cannot be converted to UTF8. Return bad file name errors in those cases. Make sure all file server strings once converted to UTF16 can be converted back. If not, escape the invalid portions of the string so that the file can be accessed. commit 0c7d7ce3b8386a1aca6d1fc3d738c8621708eb95 Author: Jeffrey Altman Date: Sun Oct 19 23:50:21 2008 +0000 windows-smb-rdr-duration-logging-20081019 LICENSE MIT if an smb request takes longer than 45 seconds, log info to afsd_init.log that might be helpful in determining patterns in the smb client disconnects commit 622f9b0de85f2a45d3a327cd8b8bea470dba9862 Author: Jeffrey Altman Date: Sun Oct 19 23:44:20 2008 +0000 windows-smb-bridge-nowild-error-handling-20081019 LICENSE MIT add the error preprocessor symbol to the error string if both an NRC_BRIDGE and NRC_NOWILD error are received within the smb_Listener thread, try re-adding the NetbiosName to the lana before giving up and quiting. commit 2767cbf773653bffaa63e098cce463ada804d6d7 Author: Jeffrey Hutzelman Date: Sat Oct 18 20:25:56 2008 +0000 newtrans-lock-fix-fix-20081018 LICENSE IPL10 swap in the freshly allocated memory instead of throwing it away commit f9191fdebcf694f1a6afac8c0f4679c35114ce93 Author: Jeffrey Altman Date: Sat Oct 18 18:01:07 2008 +0000 smb-symlink-to-vnovnode-attribute-20081017 LICENSE MIT When reporting the attribute of a directory name which happens to be a symlink object to a file that cannot be accessed or does not exist, use the target name to guess the type of the object. If it has an extension, consider it a file, otherwise report it as a directory. commit 7e8c41d53fcd51ae0ff4420ba1027b354af306c8 Author: Jeffrey Altman Date: Sat Oct 18 16:24:35 2008 +0000 ubik-uninitialized-var-20081018 LICENSE MIT 'pass' must be initialized. do so. commit f69137625fde97e465671978820350d41ca5d5b8 Author: Jeffrey Altman Date: Sat Oct 18 16:23:13 2008 +0000 restore-uninitialized-var-20081018 LICENSE MIT 'last' must be initialized. do so. commit 1bdea5e4707e9c60b949cc55b847c498fc9a7bec Author: Jeffrey Altman Date: Sat Oct 18 16:08:50 2008 +0000 fix-maxmtu-command-line-20081018 LICENSE MIT fix the variable used for maxmtu command line processing commit f5455f74988da78a652f035cd93c3184aa2ce490 Author: Jeffrey Altman Date: Sat Oct 18 14:12:19 2008 +0000 windows-pioctl-wnet-connected-20081018 LICENSE MIT refactor. consolidate netbios name acquistion. commit 75f496df1727a5b1d00809fcf493c7c815c90816 Author: Jeffrey Altman Date: Sat Oct 18 07:19:17 2008 +0000 windows-pioctl-wnet-connected-20081017 LICENSE MIT use WNetEnumXXX functions to list connected disk resources. If the requested drive letter is an AFS resource, perform the pioctl test. If it is not, fail immediately. commit edf7a4020318b305ce8fd3852f09f2f565563f7c Author: Jeffrey Altman Date: Sat Oct 18 05:44:51 2008 +0000 windows-reset-acl-list-20081017 LICENSE MIT Move definition of cm_ResetACLCache from cm_ioctl.c to cm_aclent.c commit 4c79498bc3dd87cb45d1827133aff3c93c2caff8 Author: Jeffrey Altman Date: Sat Oct 18 05:12:25 2008 +0000 windows-shell-extension-20081017 LICENSE MIT windows-afsreg-20081017 wraps strings for wide char usage. use the wide char versions of win32 apis to match. commit 81a921759520b03088ddcc37c1c624c0641981fc Author: Jeffrey Altman Date: Sat Oct 18 05:09:44 2008 +0000 windows-afsreg-20081017 LICENSE MIT wrap all text strings with TEXT() to permit use with wide char functions commit e4b6e4d4a63c036be326e3e933fb7f7c6787275b Author: Jeffrey Altman Date: Fri Oct 17 21:24:19 2008 +0000 windows-pthread-rwlock-20081017 LICENSE MIT Adds pthread rwlock support to the library. commit c3251a3b18a83bf66d4d2f0a549fa573eccbdde2 Author: Jeffrey Altman Date: Fri Oct 17 02:41:12 2008 +0000 windows-install-nsis-20081016 LICENSE MIT update copyright dates remove old AFS IFS entries delete afslogon* and afscpcc.* from $SYSDIR correct install location of afslogon.dll in WinLogon\Notify registry key commit bfd01550bddcce18f6f76e97231e21680a545e3f Author: Jeffrey Altman Date: Thu Oct 16 02:38:35 2008 +0000 windows-netbios-name-logging-20081015 LICENSE MIT log more data to afsd_init.log regarding events that can cause the netbios name registration to become invalid. commit e0298d5f09d7e791aeb0f98438e299ad1faf186a Author: Jeffrey Altman Date: Thu Oct 16 02:26:11 2008 +0000 windows-dnlc-20081015 LICENSE MIT FIXES 116641 Do not use the DNLC if the name when converted from Unicode is NULL. commit 1115e29dacab98ed29ec603edfdaa8f697507daa Author: Jeffrey Altman Date: Wed Oct 15 14:50:51 2008 +0000 windows-checkVCs-20081015 LICENSE MIT FIXES 116641 Do not drop references to 'nextp' until we are done with the object. Dropping the last reference can result in the object being destroyed. commit 9be6b92a17ebe1d125e13c1cbd7bce620e7672ce Author: Mike Meffie Date: Tue Oct 14 15:38:30 2008 +0000 linux-alt-builddir-fix-20081014 LICENSE IPL10 FIXES 121650 correct the if test to include missing x commit 24ce8010cd414c8c573f2b035d186a2418900546 Author: Derrick Brashear Date: Sun Oct 12 19:44:27 2008 +0000 linux-proc-walk-locking-20081012 LICENSE IPL10 FIXES 116603 sort out rcu locking versus tasklist lock. if this fails we probably have to disable walking entirely commit 0195d7c0828e3eae7281aad3b983160089b8846a Author: Dragos Tatulea Date: Sun Oct 12 19:10:05 2008 +0000 disconnected-rmdir-infinite-recursion-20081012 LICENSE IPL10 FIXES 121226 fix infinite recursion when replaying rmdir transaction commit 7c6fac305c81af3e10f48560c03db4d2da630527 Author: Simon Wilkinson Date: Sun Oct 12 19:06:27 2008 +0000 disconnected-getvcache-avoid-duplicate-work-20081012 LICENSE IPL10 FIXES 121254 don't do duplicate work finding a vcache we already had commit 726fc5b8425eb7bbaab4bdde38d977382dc17a9d Author: Stefaan De Roeck Date: Sun Oct 12 19:01:58 2008 +0000 linux-alternate-kernel-builddir-20081012 LICENSE IPL10 FIXES 121354 add support for KBUILD_OUTPUT=... builds. commit 322f7e0e9fff02c5d6cad8d9aded3e40abce93ef Author: Jeffrey Hutzelman Date: Sun Oct 12 18:53:06 2008 +0000 volser-newtrans-racy-20081012 LICENSE IPL10 FIXES 121263 avoid a race on creating new transactions in volserver commit 4b72f8765cdf88540354291e8e7072185538ae5d Author: Dragos Tatulea Date: Sat Oct 11 00:26:47 2008 +0000 doxygen-comments-20081010 LICENSE IPL10 FIXES 98819 99069 add doxygen comments for some parts of openafs cache manager ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE IPL10 add doxygen comments for some parts of openafs cache manager commit 523dd766ef7ed26c2207c7ec4bebe8f74e4dc408 Author: Derrick Brashear Date: Fri Oct 10 17:25:29 2008 +0000 cachemgr-blacklist-down-servers-20081010 LICENSE IPL10 FIXES 121035 fix to issue suggested by reuter@rzg.mpg.de commit 8b1b390713a79fadd300d17713350f5789879615 Author: Jeffrey Hutzelman Date: Fri Oct 10 15:42:10 2008 +0000 volser-dumpstuff-log-errors-20081010 LICENSE IPL10 FIXES 121040 return sensible (ENOSPC) errors when out of tags or vnodes. don't perror. log instead. commit d569a083e337c2971a4ac471d8adeb1788518684 Author: Harald Barth Date: Fri Oct 10 12:50:52 2008 +0000 cmdebug-entry-count-20081010 LICENSE IPL10 raise max number of entries as cache managers routinely have more than 10,000 vnode status objects commit 7034078b3386e074a399f9387ff9b387e479f4f0 Author: Derrick Brashear Date: Thu Oct 9 19:56:43 2008 +0000 hpux-gop-lookupname-20081009 LICENSE IPL10 add missing gop_lookupname macro for hpux commit 2e15aa2b261f49a1d6648c36a34300cade3c968c Author: Derrick Brashear Date: Thu Oct 9 19:54:06 2008 +0000 solaris-gop-lookupname-20081009 LICENSE IPL10 add missing gop_lookupname macro for solaris commit 9f8865744e3f4c1830afdf32b6b38f6b8f584801 Author: Derrick Brashear Date: Thu Oct 9 13:55:19 2008 +0000 bypasscache-fix-linux24-20081009 LICENSE IPL10 no f_mapping in 2.4.x commit 32977eadf12aaec6608ce3457a976a0810da8590 Author: Jeffrey Altman Date: Wed Oct 8 22:14:52 2008 +0000 windows-build-do-not-mix-pthread-and-lwp-20081008 LICENSE MIT The rx library is built in lwp and pthread forms. The methods used to export data symbols are incompatible between the two. The ubik library is built with rx headers but only in the lwp form. As a result it is not possible to link the ubik libs without also including the lwp rx lib. We have pthreaded servers that require linking to the pthreaded rx and ubik. To fix the problem all of the macros that assigned values to variables and were used by ubik have been converted to functions (but only for Windows.) commit e7b06ab695b83114954b58bd8cd25e5c0ad3f395 Author: Jeffrey Altman Date: Wed Oct 8 18:43:03 2008 +0000 windows-cell-name-trailing-dot-removal-20081008 LICENSE MIT FIXES 120318 Lookups of cell names that have a trailing dot should have the dot removed otherwise there is a risk of duplicate cell entries since "foo" and "foo." will not match but both will resolve to the same AFSDB record in DNS. commit ab2d343c31fe41d663c5a5feb796c3a9250c60d8 Author: Jeffrey Altman Date: Tue Oct 7 23:28:40 2008 +0000 windows-libafsrpc-20081007 LICENSE MIT export missing symbols necessary for tbutc and performance testing. commit b8b3bd8d1b7ca1a95c07e2ee3a0004b07a0b9537 Author: Jeffrey Altman Date: Tue Oct 7 23:25:14 2008 +0000 windows-tbutc-20081007 LICENSE MIT do not link to both pthread and lwp rx libs commit 967cbd2628c02060870c2381bd6fca3480f5711a Author: Derrick Brashear Date: Tue Oct 7 22:30:23 2008 +0000 darwin-fake-more-disk-free-20081007 LICENSE IPL10 placate finder. this time for sure commit b3bf4b89e345b991984a416d97e3f9aeacc0e159 Author: Derrick Brashear Date: Tue Oct 7 20:00:31 2008 +0000 linux-d-reval-rewrite-mtpts-when-fakestat-enabled-20081007 LICENSE IPL10 FIXES 113558 avoid case where revalidate saw a mountpoint which hadn't been rewritten yet and failed to handle it, exposing ENOENT where the entry existed. commit af0b03055e8a3244881d8ac3e7c52ed775ae86d1 Author: Derrick Brashear Date: Tue Oct 7 19:51:25 2008 +0000 find-new-xbsa-first-20081007 LICENSE IPL10 FIXES 119162 change test order commit fe0186dccd4e4d16c0610f211d454a90b0841a83 Author: Derrick Brashear Date: Tue Oct 7 18:43:57 2008 +0000 ubik-notruncate-dont-pollute-fd-cache-20081007 LICENSE IPL10 issue suggested by Chaskiel Grundman; while it should not have been an issue we now behave usefully in the notruncate recovery code. commit 1e3674cafe3c3feea0840c531cc0461d358f87c6 Author: Derrick Brashear Date: Tue Oct 7 16:34:53 2008 +0000 vldb-check-fix-more-kinds-of-corruption-20081007 LICENSE IPL10 work harder to ferret out corruption; still reruns itself so if 2 hash chains are comingled they get split back out correctly without having to flush state continuously commit 2cfe5d555e2e9eaedf5107a34d5a2f74092b98b1 Author: Derrick Brashear Date: Tue Oct 7 04:40:49 2008 +0000 linux-fakestat-revalidate-to-validity-20081006 LICENSE IPL10 we had something which fakestat was faking, but the inode had no ops, so we ended up ENOTDIRing. oops. commit 061634bfc96e70e3c02ce93319f1f269e5c16a44 Author: Jeffrey Altman Date: Sat Oct 4 05:59:32 2008 +0000 rx-varargs-20081003 LICENSE MIT call va_start on Windows commit 5158e8c7aff8f0385edbebb688b6c79b19c604c3 Author: Hans-Werner Paulsen Date: Fri Oct 3 21:39:43 2008 +0000 kdump-rx-stats-20081003 LICENSE IPL10 FIXES 118700 add change to kdump also commit b8caeee989fcc096a1846c87b088263d3db130d9 Author: Jeffrey Altman Date: Fri Oct 3 15:35:15 2008 +0000 rx-windows-dpf-20081003 LICENSE MIT dpf on windows is conditional on rxdebug_active, not rx_debugFile commit a3154fbfc16bf3946b964f03340bca86d1ad657d Author: Jeffrey Altman Date: Fri Oct 3 15:33:19 2008 +0000 rx-prototypes-20081003 LICENSE MIT remove EXT from the function prototype definitions in rx_globals.h because they result in conflicts with the actual function declarations and the prototypes in rx_prototypes.h. commit 82fc110302a7f1b7e7971285777658bdce3735ac Author: Jeffrey Altman Date: Fri Oct 3 15:31:59 2008 +0000 rx-vaargs-20081003 LICENSE MIT define va_list ap where it will be defined on all platforms commit 97176bc65a298a5660fe5fb8ad936ebbc6fbbd5e Author: Jeffrey Altman Date: Fri Oct 3 15:29:37 2008 +0000 windows-client_exp-makefile-20081003 LICENSE MIT define UNICODE commit 0d368d7c0d039d88eaad58dfee51a4b0b086cba9 Author: Jeffrey Altman Date: Fri Oct 3 15:28:07 2008 +0000 windows-update-makefile-20081003 LICENSE MIT add missing reference to cm_nls.obj commit 38800039a7039c3fa832718799667557a5e24f66 Author: Jeffrey Altman Date: Thu Oct 2 13:12:23 2008 +0000 windows-smb_dir_watch_lock-20081003 LICENSE MIT re-order the lock hierarchyfor smb_Dir_Watch_Lock so that the lock does not have to be dropped when sending notifications within smb_NotifyChange(). commit 1e7203940456e783aad215e939c04ed01dd45599 Author: Jeffrey Altman Date: Thu Oct 2 12:51:48 2008 +0000 rx-current-packet-double-free-20081003 LICENSE MIT in rxi_WriteProc() make sure that rx_call currentPacket is set to NULL after the rx_packet is added to a queue or passed to rx_freePacket(). Otherwise we will panic when we attempt to call rx_freePacket twice on the same packet. commit 6acd68f0e88ffa40891be4b908b70af784b397a2 Author: Simon Wilkinson Date: Fri Sep 26 11:16:36 2008 +0000 linux-nfstrans-libafs-tree-20080926 LICENSE IPL10 add missing files needed for nfs variants commit 3853c326155d58613bb1711a10123ac88acce002 Author: Simon Wilkinson Date: Fri Sep 26 09:23:48 2008 +0000 disconn-prototypes-20080926 LICENSE IPL10 add a prototype we need for disconnected commit 3f11790f6ab999be828fb0868b64ea00b98a5ea4 Author: Simon Wilkinson Date: Thu Sep 25 22:40:25 2008 +0000 pthread-ubik-volser-stupidity-20080925 LICENSE IPL10 make volserver build again for not pthreaded ubik commit 3a5e912230fd09c72c1a27d7f7d4e4ac78f9323b Author: Simon Wilkinson Date: Thu Sep 25 21:19:33 2008 +0000 rx-dpf-clarify-20080924 LICENSE IPL10 rework dpf macro slightly so there are no trailing ; issues ddddddddddddd AUTHOR LICENSE IPL10 commit 8b50c9d9e3d181f749d0982f57410a5b4906627c Author: Jeffrey Altman Date: Thu Sep 25 21:17:22 2008 +0000 rx-clear-queues-correctly-20080925 LICENSE IPL10 don't potentially leak packets by leaving them behind and initing queues; in fact, if you are cleaning up there is no need to init queues anyway. commit b84da5849261867b201646e957c014e933a2c17f Author: Jeffrey Altman Date: Thu Sep 25 20:54:44 2008 +0000 rx-packet-allocation-debug-20080925 LICENSE IPL10 add field to track allocated packets commit 230dcebcd61064cc9aab6d20d34ff866a5c575ea Author: Jeffrey Altman Date: Thu Sep 25 20:34:41 2008 +0000 rx-change-packet-allocation-calculation-20080925 LICENSE IPL10 don't alloc ourselves to death; try harder to manage growth commit 559ea99b1e6e6e82ec6a77541ef9844ccc764de8 Author: Jeffrey Altman Date: Thu Sep 25 19:59:33 2008 +0000 rx-flag-all-packets-20080925 LICENSE IPL10 flag packets for all queues, and when they are currentPacket somewhere commit 939e070c869b46abc707bbd916d4dfbe1e66a55e Author: Jeffrey Altman Date: Thu Sep 25 18:26:23 2008 +0000 rx-global-lock-macro-correction-20080925 LICENSE IPL10 refer to the same macro everyone else does commit a72eea6bb1758678d25528cd1ab9b439ade2f844 Author: Jeffrey Altman Date: Thu Sep 25 18:21:15 2008 +0000 rx-clear-queues-correctly-20080925 LICENSE IPL10 don't potentially leak packets by leaving them behind and initing queues; in fact, if you are cleaning up there is no need to init queues anyway. commit 7a4041f9404ff27f3e446d7b523086e0938dc6b9 Author: Jeffrey Altman Date: Thu Sep 25 18:15:41 2008 +0000 rename-rx-stats-20080925 LICENSE IPL10 avoid using the same name for the struct and the global so the windows debugger works usefully ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE IPL10 avoid using the same name for the struct and the global so the windows debugger works usefully ==================== LICENSE IPL10 avoid using the same name for the struct and the global so the windows debugger works usefully commit 883683fc317c5196f2eea1c1baed3b510771f001 Author: Jeffrey Altman Date: Thu Sep 25 18:06:24 2008 +0000 rx-readproc32-avoid-losing-currentpacket-20080925 LICENSE IPL10 when currentPacket is empty, avoid leaking it and instead free and NULL it commit eb875d30340a67af78638cf7f395dfe14c0ed405 Author: Derrick Brashear Date: Thu Sep 25 17:59:52 2008 +0000 ah-verbatim-section-tweak-20080925 LICENSE IPL10 remove PACKAGE and VERSION commit 9d09de799b6efc1a62e0cf28f1b033fd4132b2e1 Author: Derrick Brashear Date: Thu Sep 25 15:41:02 2008 +0000 acfooter-inline-20080925 LICENSE IPL10 based on work by mdw@umich.edu commit 8871c545e3b6785b9f10a5b173c4701813269eae Author: Jeffrey Altman Date: Thu Sep 25 13:29:50 2008 +0000 rx-windows-mutex-is-mine-lwp-20080925 LICENSE MIT mutex is mine for lwp on windows commit 3be628e8fc34c2a047187ce3852c56734f9cfc0a Author: Jeffrey Altman Date: Thu Sep 25 13:04:46 2008 +0000 rx-user-prototype-20080925 LICENSE MIT fix prototype for rx_getAllAddr() on Windows commit ec6dcda473f4699454b3870994f147799044fb80 Author: Jeffrey Altman Date: Thu Sep 25 12:58:45 2008 +0000 rx-prototypes-20080925 LICENSE MIT fix errors introduced in rx-prototypes-20080924 on Windows commit db15c2f1cb6cf02ddf79e3539b6f202c439b92e0 Author: Jeffrey Altman Date: Thu Sep 25 12:49:10 2008 +0000 rx-windows-mutex-is-mine-20080925 LICENSE MIT Add MUTEX_IS_MINE for Windows commit 9d63160cccf88d554e47e4bed8e3bbe26f14f8c2 Author: Matt Benjamin Date: Thu Sep 25 12:42:02 2008 +0000 bypasscache-20080922 LICENSE IPL10 add cache bypass support (currently linux only) commit 84b423e932e05bd6ffb64729900f518091f26ef1 Author: Derrick Brashear Date: Thu Sep 25 10:02:23 2008 +0000 disconnected-fix-ifdefing-20080925 LICENSE IPL10 make disconnected code not be compiled in (and break) when you don't have it enabled commit b5a6e4bf36dbb2099f17318ae09ff38a25687c5f Author: Max Cohan Date: Thu Sep 25 09:57:39 2008 +0000 dafs-vol-offline-status-20080925 LICENSE IPL10 FIXES 117499 This patch makes several alterations to the DAFS volserver. The two major changes are: * a potential information leak whereby random heap contents could be exported over the four listvolume rpc variants is corrected * volume online/offline reporting correctly reports in several additional corner cases (see the comments in FillVolInfo() in src/volser/volprocs.c for the complete list of cases): VOL_STATE_SALVSYNC_REQ: exclusive state while a fileserver is busy requesting a demand salvage over the SALVSYNC protocol V_needsSalvaged(): volume disk header field which is asserted when the fileserver detects that a volume needs to be salvaged pending volume operation with command code FSYNC_VOL_OFF: this command code indicates that a volume utility requires exclusive access to the volume pending volume operation and VVolOpLeaveOnline_r returned false: this indicates that a volume operation is in-progress, and the internal function VVolOpLeaveOnline_r has decided that the volume cannot be served concurrently with this volume transaction commit 1659861640035f5405429194e72665839cff3720 Author: Steven Jenkins Date: Thu Sep 25 08:50:01 2008 +0000 dafs-drop-volheaders-20080925 LICENSE IPL10 FIXES 117470 Under certain demand salvage scenarios, it is possible for a stale header to remain cached with the needsSalvaged flag asserted. Although this will not affect clients accessing the volume over afsint, it is an issue for volser clients. VAttachVolumeByName in volser will always attempt to pull the header over FSSYNC before doing a disk read, under the assumption that a cached entry in the fileserver will be more current than what is on disk. This patch causes the fileserver to aggresively invalidate disk header cache entries when a salvage is in-progress. commit f52f24d6f0027be06d444c1dd7e0d35163b16ef6 Author: Jeffrey Altman Date: Wed Sep 24 23:47:59 2008 +0000 windows-remove-entraneous-commit-20080924 LICENSE MIT remove extraneous commit. maybe later. commit dd05bd3ba7be90a6348b144eb1c0a6ac1c5f43ba Author: Jeffrey Altman Date: Wed Sep 24 23:40:44 2008 +0000 windows-vlserver-updates-20080924 LICENSE MIT if a vlserver returns a ubik error, skip the server and retry commit 8aa9d07e35c132ba5bbc1704fc9c0ba289b277fd Author: Simon Wilkinson Date: Wed Sep 24 22:38:19 2008 +0000 rx-varargs-20080924 LICENSE IPL10 make rx use varargs instead of a large fixed set of parms commit 17d45aa8843c6608d6f98e5defbf0db5aefce66b Author: Simon Wilkinson Date: Wed Sep 24 22:36:29 2008 +0000 rx-prototypes-20080924 LICENSE IPL10 cut down by a few thousand the warnings we get commit af4d05c3a44d5b51dd6ae48e79c135af7efc530f Author: Simon Wilkinson Date: Wed Sep 24 22:34:19 2008 +0000 generic-inline-20080924 LICENSE IPL10 move static_inline macro to generic location commit 2d5987ea2bd96285899f1e5a141dcdaed8008e7e Author: Simon Wilkinson Date: Wed Sep 24 22:31:54 2008 +0000 rx-dpf-clarify-20080924 LICENSE IPL10 rework dpf macro slightly so there are no trailing ; issues commit 433afd4779b077a1d0f4b842335e38625e124dcc Author: Dragos Tatulea Date: Mon Sep 22 14:36:16 2008 +0000 disconnected-rw-20080922 LICENSE IPL10 FIXES 114605 114606 114607 add read-write disconnected support commit 41d5a5f7e30b5933408394db6aa107b8de966d33 Author: Derrick Brashear Date: Sun Sep 21 14:03:20 2008 +0000 macos-panic-decoder-format-fix-20080921 LICENSE IPL10 handle new panic format commit 1f686941197c32734acd2531a911b8e5e43cc94e Author: Asanka Herath Date: Tue Sep 16 12:45:22 2008 +0000 windows-local-dir-updates-20080916 LICENSE MIT When a local directory update occurs to the directory pages stored in the dcache, there is no guarrantee that the same modifications will be made to the cached pages as are being made by the file server. In the situation that one or more of the cached pages are recycled, it is not permissible to obtain the missing pages from the file server without first invalidating the rest of the cached pages. This is necessary to prevent mixing of incompatible data representations. Define a new flag CM_SCACHEFLAG_LOCAL which is used to indicate that dcache entries were locally modified even though they are not dirty. As the previous code could have corrupted the contents of the dcache, bump CM_CONFIG_DATA_VERSION in order to force the rebuilding of the cache. Add error CM_ERROR_NOTINCACHE to indicate that a requested directory page is not present in the cache and will not be created on the fly. Prefetch all dcache entries for directories and ensure that a consistent set is being used. commit c4117f6f07b92fcc3a135badb48099a01ba41fe2 Author: Asanka Herath Date: Tue Sep 16 12:32:38 2008 +0000 windows-dir-search-star-dot-pattern-20080916 LICENSE MIT Replicate the FAT and NTFS behavior that the "*." pattern should match all files without an extension. commit 414312a72a9b1f0dd64ba3bfe97865dcc8cd80e3 Author: Jeffrey Altman Date: Tue Sep 16 12:26:45 2008 +0000 windows-lock-order-20080916 LICENSE MIT do not violate lock order when freeing server reference lists commit 2d709220d53fe9c5da23e2dbb32764fd3cbfea48 Author: Jeffrey Altman Date: Sat Sep 13 14:51:16 2008 +0000 windows-byte-range-locks-20080913 LICENSE MIT Replace the int64 key with a struct because process ids on 64-bit Windows can be 64-bit when obtained through the redirector interface. commit 1456a67c5ca024c523e0fc3edcba720780d4be9e Author: Jeffrey Altman Date: Sat Sep 13 05:20:02 2008 +0000 windows-vnovol-20080912 LICENSE MIT The cm_serverRef_t list reference counts were undercounting and prematurely freeing the server lists for volumes that experienced VNOVOL and VMOVED errors. cm_Analyze() must release the server list before forcibly updating the volume location info. Otherwise, the list that gets freed is the old one concatenated with the new one. Add more trace messages. commit fd55471b57bce441454d7b3c72c7be6a66aad65d Author: Jeffrey Altman Date: Fri Sep 12 15:32:23 2008 +0000 windows-service-procs-20080912 LICENSE MIT if we are going to use hot threads it would be useful if there were some additional server threads available to become listeners as needed. commit 11b45ad09b7d257a476ddb57e48133ecf88375f7 Author: Simon Wilkinson Date: Fri Sep 12 14:07:31 2008 +0000 redhat-mockbuild-dksm-20080912 LICENSE IPL10 make mockbuild do the dkms rpms also commit 7ae4174d95a9d90e16f0ddc66648741a119339d2 Author: Asanka Herath Date: Fri Sep 12 05:08:00 2008 +0000 windows-dir-new-pages-20080911 LICENSE MIT A small patch to permit the directory package to allocate additional directory pages when adding new entries that do not fit in the pages that were obtained from the file server. commit 5ea02ad1e2bdb98bea27e11c1372f90d1940de17 Author: Jeffrey Altman Date: Thu Sep 11 18:24:38 2008 +0000 windows-vnovol-20080911 LICENSE MIT Modify MSG_SERVER_REPORTS_VNOVOL to mention that the volume may have been moved or deleted. In cm_Analyze(), do not call cm_ForceUpdateVolume() or force a retry when processing CM_ERROR_NOSUCHVOLUME. This CM error value is the result of a VNOVOL already being processed which would have forced the update. When a VMOVED or VNOVOL error is received, remove the volume id from the server's volume list. If cm_ForceUpdateVolume() returns a failure, do not retry if a VMOVED or VNOVOL error was received. Make sure that if a cm_serverRef_t object is marked srv_deleted that its references not be used. Now that cm_ForceUpdateVolume() is being called only when processing VMOVED and VNOVOL errors, permit it to call cm_UpdateVolumeLocation() immediately. Refactor cm_CheckOfflineVolume() to reduce code duplication. commit 186f1e97d0c15ead6bddae8697161a47ce9a80e4 Author: Jeffrey Altman Date: Thu Sep 11 18:09:34 2008 +0000 windows-flush-btrees-20080911 LICENSE MIT fs flushall, fs flushvolume, and fs flush should tear down directory B+ trees so that when the data buffers are re-read from the file server with the same data version, the B+ trees will be rebuilt. commit d85bdb4c9f9ddf7d287072a3d12e65423e551f40 Author: Jeffrey Altman Date: Thu Sep 11 18:03:52 2008 +0000 windows-cell-list-validation-20080911 LICENSE MIT correct cell list validation now that the free cell list exists commit 8e1b48ad0ab7f3790729ea0feb25256b3a9da709 Author: Jeffrey Altman Date: Thu Sep 11 17:59:18 2008 +0000 windows-rx-jumbo-20080911 LICENSE MIT Disable rx jumbo by default. Permit rx jumbo to be enabled with registry value "RxJumbo" set to 1 or "RxNoJumbo" set to 0. RxNoJumbo has priority. commit 59c1c22747b8aaf1da31f97d8a3ea178a4f7adee Author: Jeffrey Altman Date: Thu Sep 11 17:49:53 2008 +0000 windows-multi-check-server-20080911 LICENSE MIT Permit rx_multi check server to be toggled via a registry setting at checked prior to each invocation. "MultiCheckServers". Default is on. Remove volume status updates for vldb server status changes. commit f51e8e7be5b16f84f0603a0e8bc1be4ffafac617 Author: Derrick Brashear Date: Sat Sep 6 12:58:39 2008 +0000 aix-export-build-fix-20080906 LICENSE IPL10 add missing ; to case actions commit 21006bb844a3a93c7228b65ee4543ff2b8233761 Author: Derrick Brashear Date: Sat Sep 6 12:52:59 2008 +0000 oops-sias-dead-20080906 LICENSE IPL10 while we should try all the auth modules, sia is tru64 only, so, no... commit 4119d9742b3e17fac6a3f1f7ab64ec829f085498 Author: Derrick Brashear Date: Sat Sep 6 12:51:01 2008 +0000 syncserv-syncvldb-manpages-dryrun-20080906 LICENSE IPL10 make syncserv and syncvldb manpages reflect dryrun option commit 0860d5b5b17ef5f58592d739424a4cca8dd91bb5 Author: Jeffrey Altman Date: Sat Sep 6 05:24:31 2008 +0000 windows-vnovol-20080905 LICENSE MIT force a volume location update upon receipt of a VNOVOL error in case the volume was moved. VMOVED is only returned by the file server if the volume is in the process of being moved. Once it has been deleted the file server returns VNOVOL. commit 5c2406070fc08c5fee0a09a1aa25e16af123b81a Author: Derrick Brashear Date: Fri Sep 5 17:57:33 2008 +0000 fileserver-sticky-bit-admin-only-20080905 LICENSE IPL10 do restrict the sticky bit to admins. commit beef54e70cc86672b9971288fe4034829186aa41 Author: Jeffrey Altman Date: Thu Sep 4 21:07:40 2008 +0000 windows-smb-volname-20080904 LICENSE MIT Advertise the correct length for the volume name. Do not include the NUL. Add more create option values as #defines. commit 9689e78d716422970a0ae3ad89d36acaa517072e Author: Derrick Brashear Date: Thu Sep 4 20:41:14 2008 +0000 fileserver-sticky-bit-not-admin-only-20080904 LICENSE IPL10 don't restrict the sticky bit to admins. commit bbd713ad3f403c9137e01797f576f5dbd04a0f08 Author: Jeffrey Altman Date: Wed Sep 3 22:03:54 2008 +0000 windows-cell-locking-20080903 LICENSE MIT fix a lock order issue and protect the timeout and flags field of cm_cell_t with the mutex instead of the global lock. commit 441cc643e027ab98ed14ab486ec077bbbd0c0d4f Author: Jeffrey Altman Date: Wed Sep 3 21:37:00 2008 +0000 windows-smb-lock-order-20080903 LICENSE MIT another lock order violation to fix commit 539535cf679d6e70f34b80b74c127efae1f0bba2 Author: Niklas Edmundsson Date: Wed Sep 3 19:26:29 2008 +0000 aix61-initial-support-20080903 LICENSE IPL10 FIXES 113638 aix 6.1 support commit 7f4e0dfc3ef1464c8d8b422bf00915fa4538090c Author: Jeffrey Altman Date: Wed Sep 3 19:07:11 2008 +0000 rx-mutex-init-once-20080903 LICENSE IPL10 FIXES 114555 because rx_Finalize doesn't clean up, we end up reiniting mutexes. use pthread_once when not in the kernel. (kernel does not now call rx_Finalize, ever) commit 995ee981fd2631d6e1e45311cee0a6d58f4a56be Author: Derrick Brashear Date: Wed Sep 3 17:59:08 2008 +0000 linux26-libafs-makefileproto-trust-kbuild-system-no-really-20080903 LICENSE IPL10 if we are really not using COMMON_KERN_CFLAGS and being trusting, let's do so. commit 9803e84e63c28e87c76e6f4e77343fec4ef4dcf4 Author: Jeffrey Altman Date: Tue Sep 2 23:34:41 2008 +0000 windows-afsd-dns-env-20080902 LICENSE MIT Fix the conditionals so that the right thing happens if AFS_AFSDB_ENV is not defined. commit 8bf17e7c813f9b2aa8a953a8d0251322ee970d2c Author: Jeffrey Altman Date: Tue Sep 2 22:25:25 2008 +0000 windows-fs-setcrypt-auth-20080902 LICENSE MIT fix parsing and display of fs setcrypt auth commit 84e10d582abdf65a5354b1c4b41d7e2ecad532f8 Author: Jeffrey Altman Date: Tue Sep 2 22:20:58 2008 +0000 smb-string-conversion-20080902 LICENSE MIT more cases where -1 should be passed in as opposed to the strlen value when converting between char and wchar forms commit d94b9a78188357f87fa569ec7738d4e69ff05faa Author: Jeffrey Altman Date: Tue Sep 2 22:15:36 2008 +0000 windows-rxkad-auth-20080902 LICENSE MIT Add ability for users to select rxkad auth only mode. "fs setcrypt auth". commit 21abc0e0b51cd3fd014b06b187d497996058ffe4 Author: Jeffrey Altman Date: Tue Sep 2 22:08:24 2008 +0000 windows-afsd-init-20080902 LICENSE MIT report state of "Rx Jumbo" and "RxExtraPackets" more often commit e31826d3331b8eb1893c627ac55eb299df88995b Author: Jeffrey Altman Date: Tue Sep 2 21:17:42 2008 +0000 windows-cell-free-list-20080902 LICENSE MIT add a free list to the cm_cell_t structure. if during cm_GetCellGen() the cm_SearchCellXXX() calls fail, store the allocated cm_cell_t object on a free list so that it can be reused for the next request. commit 829ff4e54f055de1dc26a1508d2abf4a3c72ff75 Author: Jeffrey Altman Date: Tue Sep 2 17:34:00 2008 +0000 windows-cell-alloc-reversed-20080902 LICENSE MIT The approach taken in windows-cell-alloc-20080902 won't work. commit ef64f50fb9f477a0acbe1223ee2b0c9981f9324e Author: Jeffrey Altman Date: Tue Sep 2 16:20:13 2008 +0000 windows-cell-alloc-20080902 LICENSE MIT Perform the initial cm_SearchCellXXX call using a temporary cm_cell_t object in case the search fails. commit a653057ff453a0d340c8153615aa44ae1679c892 Author: Jeffrey Altman Date: Mon Sep 1 13:35:42 2008 +0000 windows-smb-free-lsa-response-20080901 LICENSE MIT Whether or not LsaCallAuthenticationPackage succeeds, it may return a response buffer. If it does, free it. commit 83dadab93adde0812f9ae228667683cfcc761f67 Author: Jeffrey Altman Date: Sat Aug 30 15:13:03 2008 +0000 windows-afsd-init-lock-order-validation-20080830 LICENSE MIT Add TransarcAFSDaemon/Parameters key "LockOrderValidation" DWORD to control lock order validation functionality. Defaults to off for release builds and on for checked builds. commit a36596f10ff4d87d75a808cabe4e0e5ec661c5df Author: Jeffrey Altman Date: Sat Aug 30 15:03:27 2008 +0000 windows-lock-order-validation-20080830 LICENSE MIT Add osi_SetLockOrderValidation(int) to permit lock order validation to be turned on and off. Must be executed before the first lock is obtained. commit ccdf50ade371de595abe20f5a6b0ff149ce9ae79 Author: Jeffrey Altman Date: Sat Aug 30 03:08:20 2008 +0000 windows-buf-shutdown-20080829 LICENSE MIT During buf_Shutdown() all dirty buffers should be written to the file server if they can be. commit 2da64d02a2707a3c9220951a30b5cea8464b9ef9 Author: Jeffrey Altman Date: Sat Aug 30 03:04:53 2008 +0000 windows-afsd-shutdown-20080829 LICENSE MIT reorganize the service shutdown order to permit dirty buffers to be flushed to the file server without competition from incoming requests. commit 00fee5efee68f1647fa810dffa7ad991235d01c5 Author: Jeffrey Altman Date: Thu Aug 28 10:45:45 2008 +0000 windows-check-servers-20080828 LICENSE MIT if the server count is zero, don't both trying commit 43eb87a916b87c6037841ea38cde616014d892a8 Author: Jeffrey Altman Date: Thu Aug 28 00:42:26 2008 +0000 windows-check-server-heap-overwrite2-20080827 LICENSE MIT the incorporation of nconns into the foo incremental was a mistake commit e68255c12c444e36b7ca7f1864d964cd3a0bcda8 Author: Jeffrey Altman Date: Wed Aug 27 23:08:06 2008 +0000 windows-check-server-heap-overwrite-20080827 LICENSE MIT Protect against a heap overwrite that could occur is the number of file servers or vldb servers grows while the maximum number of connections is computed and when the connection list is populated. commit 0affa4b86a08c3be9cb4edc4c9f680ae02a2fcd8 Author: Jeffrey Altman Date: Wed Aug 27 23:01:51 2008 +0000 windows-callback-lock-order-20080827 LICENSE MIT do not hold cm_server_t mutex when calling cm_FindVolumeByID because the cm_volume_t lock must be obtained ahead of the cm_server_t mutex commit c50857b05e6636bef864c9418b21d1bf3c63494a Author: Jeffrey Altman Date: Wed Aug 27 13:17:05 2008 +0000 windows-lock-order-20080827 LICENSE MIT do not hold cm_scacheLock while obtaining cm_scache_t->rw commit bef68684fd7bb4e58e621766a0f2abbdfd15af80 Author: Jeffrey Altman Date: Wed Aug 27 12:47:23 2008 +0000 windows-short-names-20080827 LICENSE MIT plus and equal are not valid characters in short names. we replace them with left and right brace in order to minimize the instability in the file names. commit a123bd8ccde0d6baf04401201b1672b19e9778db Author: Matt Benjamin Date: Tue Aug 26 15:59:42 2008 +0000 freebsd-70-client-20080826 LICENSE IPL10 FreeBSD 7.0 client support (and 8.0 support but that's a moving target) commit 4d245c6a19394d54a241bd612016b10d1113ee7b Author: Tom Keiser Date: Tue Aug 26 15:11:28 2008 +0000 studio12-solaris-updates-20080826 LICENSE IPL10 FIXES 113671 update so we build with studio 12 on solaris commit 82c62ae0e3b6366c9cdef0569e5be4637127e586 Author: Derrick Brashear Date: Tue Aug 26 14:44:31 2008 +0000 linux-rpm-make-dkms-remove-work-20080826 LICENSE IPL10 rpm -e failed because of a typo here when removing our dkms rpm commit e16c4f8a96f0568d5f7155c88f9b877baa500b7d Author: Jeffrey Altman Date: Tue Aug 26 05:55:40 2008 +0000 windows-scache-lock-20080825 LICENSE MIT restore a missing obtain write lock commit e0380d54bad50582b6bc39e2b41e78d72117ec79 Author: Jeffrey Altman Date: Tue Aug 26 05:36:34 2008 +0000 windows-misc-20080825 LICENSE MIT avoid a deadlock in cm_GiveUpAllCallbacks log UAEEXIST / EEXIST in cm_Analyze commit cb455744d49f250c236ab24cdcfffda104ef3774 Author: Jeffrey Altman Date: Tue Aug 26 05:14:14 2008 +0000 windows-client-osi-20080825 LICENSE MIT add more asserts to attempt to catch locks released in threads other than the one that obtained them. commit 12c8abc69030d3368194b148c692215c61b5da9c Author: Derrick Brashear Date: Mon Aug 25 02:14:39 2008 +0000 server-argument-consistency-and-jumbograms-off-20080824 LICENSE IPL10 FIXES 108703 go through and make servers able to take debug log level on command line; add -jumbo; default to -nojumbo commit a88d12746a9e7e8e79a80c5bcafda449810b4e22 Author: Jeffrey Altman Date: Sun Aug 24 22:45:24 2008 +0000 windows-smb-more-check-open-done-20080824 LICENSE MIT call cm_CheckNTOpenDone() in error conditions as well commit 82741251b1f444a1f18e3b9816f8cadac3e168b5 Author: Jeffrey Altman Date: Sun Aug 24 18:46:23 2008 +0000 windows-prefetch-lock-order-20080824 LICENSE MIT lock order violation between cm_daemonLock and cm_scache_t rw lock commit 24f8b1b4c327c3fb01a575ccb46d5ae6bf7edd36 Author: Jeffrey Altman Date: Sun Aug 24 17:31:28 2008 +0000 windows-smb-locks-20080224 LICENSE MIT smb_dirSearch_t refCount field is protected by smb_globalLock not the smb_dirSearch_t mutex. Do not hold the smb_fid_t mutex across calls to smb_NotifyChange() commit cc48a5a3b4d328127ca56c1a5845ec6cac136548 Author: Jeffrey Altman Date: Sun Aug 24 17:25:57 2008 +0000 windows-check-nt-open-lock-sync-20080224 LICENSE MIT Move cm_SyncOpDone(CM_SCACHESYNC_LOCK) from cm_CheckNTOpen to cm_CheckNTOpenDone. This is necessary to synchronize lock operations. commit 25b819543ea4343216b6a2955396719a49ea042f Author: Jeffrey Altman Date: Fri Aug 22 21:57:53 2008 +0000 windows-callback-shutdown-head-20080801 LICENSE MIT When the cache manager is shutting down, return an error to all callback requests. Otherwise, it is possible for a callback to get stuck waiting for a lock and when the lock clears to be left with nothing but invalid memory addresses to crash on. In the meantime, the file server is waiting for the response. commit 186f707378ce0c04705170743cbc67ff44e1c93f Author: Derrick Brashear Date: Fri Aug 22 20:26:38 2008 +0000 darwin-fake-afs-bigger-20080822 LICENSE IPL10 FIXES 112564 set up max uint64 "free" in afs so finder isn't dumb. commit ea81e608bae42ea84d7bc85d289bfe6f24d8d383 Author: Derrick Brashear Date: Fri Aug 22 19:52:44 2008 +0000 analyze-srvr-safety-check-20080822 LICENSE IPL10 FIXES 112681 safety check to make sure a conn's srvr is set before dereferencing it commit ef10390e12ffd697f9eaaacd1d7291e05d16c835 Author: Jeffrey Altman Date: Fri Aug 22 19:06:04 2008 +0000 windows-misc-20080822 LICENSE MIT 1. In multi-threaded applications deadlocking is always a problem. Deadlock avoidance requires a strict adherence to a documented hierarchy. The lock hierarchy for OAFW is described in a file called locks.txt. There are two problems. First, some of the locks are not included in locks.txt. Second, it is nearly impossible given the depth of function calls for any programmer to identify all of the locks that are held at any given time a function is called. This patch implements a new locking order verification mechanism. Each lock is assigned a lock level at initialization. Each thread maintains a queue of held locks. Each time a lock is acquired the queue is checked to ensure that no locks with a higher level than the requested lock has already been acquired. If a violation occurs, the service panics. 2. When the service panics ensure that a minidump will always be generated. 3. Remove unused lock cm_bufGetMutex. 4. The lock order verifier identified approximately a dozen lock order violations that are corrected. 5. A race condition within the function path cm_GetSCache() -> cm_GetNewSCache() -> cm_RecycleSCache() permitted a cm_scache_t object to be issued simultaneously to two threads. This would eventually result in a panic due to the resulting under count. 6. Fix interpretation of the empty string as the ioctl path to mean the current directory. "fs lsm", "symlink list", etc. now return a "not a ..." error instead of "does not exist". 7. Add SMB_STRF_SRCNULTERM flag to smb_ParseStringXXX functions to indicate that the input string is a nul terminated string. Assign it when input strings are nul terminated. 8. The CIFS protocol specification for handling NT_TRANSACT_CREATE does not match the observed behavior. The 'nameLength' is specified in bytes not in characters. Fix the implementation to match. 9. The cm_HaveAccessRights() attempt at deadlock avoidance by calling lock_TryRead() on the parent directory cm_scache_t rw-lock does not avoid the deadlock. Avoid the deadlock by enforcing the lock order of lowest vnode first. Then remove the infinite loop avoidance in cm_SyncOp() that was returning an unwarranted access denied error. commit 46dbd678714110002a36269beca8961e013650ac Author: Derrick Brashear Date: Fri Aug 22 05:31:32 2008 +0000 rx-allow-jumbogram-disabling-really-20080822 LICENSE IPL10 right now, jumbograms can still be sent when -nojumbo is specified. make the current macro a default and override when we're supposed to. commit a00f706eb67c257af9892557cfb6ad35594144cf Author: Jeffrey Altman Date: Wed Aug 20 20:44:56 2008 +0000 windows-list-symlink-20080820 LICENSE MIT Another casaulty of the Unicode transition, the return value of the ListLink operation was not being convered from wchar to char before it was copied into the output buffer. commit 9488898fdb22e8c999ad4f713bd656caba91fe1c Author: Jeffrey Altman Date: Wed Aug 20 20:41:17 2008 +0000 windows-afsd-service-20080820 LICENSE MIT When afsd_service.exe is not running as a service do not call the Service Manager functions. Doing so causes invalid access exceptions to be thrown in the kernel and can corrupt the heap. commit 651f25b9c84b57cb88e2066c91c5234399673164 Author: Derrick Brashear Date: Wed Aug 20 19:45:05 2008 +0000 redhat-spec-default-build-authlibs-20080820 LICENSE IPL10 FIXES 101879 make build_authlibs default usefully commit 03982bd54839f81cdc691ad83e946fac8f8789b7 Author: Derrick Brashear Date: Sat Aug 16 22:37:29 2008 +0000 namei-by-default-on-sol10-20080816 LICENSE IPL10 default to namei, not inode, on solaris 10 except by request commit b080c5d82ba5c7641afeb6836961cacf283e4902 Author: Dan Hyde Date: Sat Aug 16 21:07:30 2008 +0000 volser-initialize-volume-updatedate-20080816 LICENSE IPL10 FIXES 110943 right now this isn't set until a vnode update happens. technically creating the root directory is an update, so let's set it to now. commit 8190e75b38a7cd136ce70050fdd71b1d62888055 Author: Tracy Di Marco White Date: Sat Aug 16 20:46:44 2008 +0000 netbsd-sigwait-broken-til-nbsd5-20080816 LICENSE IPL10 FIXES 111404 work around netbsd sigwait brokenness commit d7a5619e5bd8241dd13611a4be37f04f3aa4ed27 Author: Marc Dionne Date: Sat Aug 16 20:42:34 2008 +0000 linux-2-6-27-20080816 LICENSE IPL10 FIXES 111634 add support for 2.6.27, which removes asm/semaphore.h commit 4274e854c58655ae2d1142ec3e08d62aebb07be0 Author: Jeffrey Altman Date: Sat Aug 16 18:39:33 2008 +0000 windows-build-20080815 LICENSE MIT remove duplicate rules for man-pages commit dbd98583d35d6aea57cb4d9c46790479dc1a137e Author: Jeffrey Altman Date: Sat Aug 16 18:00:50 2008 +0000 windows-rx-extra-packets-20080816 LICENSE MIT Make the default number of pre-allocated rx packets equal to the number of threads times the rx window size. commit ffbee95174ad1fffecff2889e80e168cea60a531 Author: Jeffrey Altman Date: Sat Aug 16 17:48:17 2008 +0000 windows-pioctl-getdrivetype-20080816 LICENSE MIT Use GetDriveType() to check if the current path is a local disk. If it is, fail the pioctl attempt immediately. This should avoid the reported 30 second delay in the AFS Shell Extension. commit 20d38bc268b13258e2358591756824d712cdb403 Author: Jeffrey Altman Date: Fri Aug 15 21:17:02 2008 +0000 windows-freelance-deadlock-20080815 LICENSE MIT avoid a deadlock in cm_reInitLockMountPoints() and make the function useful again by actually using the index value in the construction of the FIDs commit aa011cc0d8bbff96d5772d0069520b41826c3857 Author: Jeffrey Altman Date: Fri Aug 15 00:37:20 2008 +0000 windows-shlibafsauthent-20080814 LICENSE MIT export pioctl_utf8 commit 357223aefd86c007987333b2a8859faa33f21424 Author: Jeffrey Altman Date: Thu Aug 14 21:22:49 2008 +0000 windows-server-dereference-null-two-20080814 LICENSE MIT protect against a potential null pointer dereference of a cm_server_t object commit 90fe95e994efe62175959aab95c276898f1ff54c Author: Jeffrey Altman Date: Thu Aug 14 21:19:34 2008 +0000 windows-server-dereference-null-20080814 LICENSE MIT protect against a null pointer dereference of a cm_server_t object commit f430aee67c4f3d1f3c644f97c30db081d2a9880f Author: Jeffrey Altman Date: Thu Aug 14 18:23:28 2008 +0000 windows-memdump-20080814 LICENSE MIT add locks, waiting lock requests, smb user, smb tid, and cell expiration to the memory dump output (fs memdump) commit 06b5006517c77767a246df2b6d66a344a44cbea1 Author: Jeffrey Altman Date: Thu Aug 14 03:36:43 2008 +0000 windows-free-server-deadlock-20080813 LICENSE MIT avoid a deadloc when freeing servers. cm_serverLock must be released around cm_GCConnections() commit 4e7e66d4dc14513e1beed465fc5180429571921b Author: Jeffrey Altman Date: Thu Aug 14 03:32:54 2008 +0000 windows-search-cell-file-20080813 LICENSE MIT if a cell has been found with addresses and the next cell name is reached before the EOF, return success. If the cell has been found and there are no addresses, return -6 commit 919fb5e14bdcde66218e64cfdd7fecccab67d8f5 Author: Jeffrey Altman Date: Thu Aug 14 03:27:36 2008 +0000 rx-buffer-allocation-corrected-20080813 LICENSE MIT a corrected version of delta rx-buffer-allocation-20080812 commit 844d7e570772ab2bdbfa2d59ac0f48afff37d8b7 Author: Jeffrey Altman Date: Thu Aug 14 03:15:34 2008 +0000 windows-build-man-pages-20080813 LICENSE MIT move building of man pages to installer phase commit 04a25e0a4057b63cf7c700b17b1a6ab28e469547 Author: Derrick Brashear Date: Thu Aug 14 00:49:15 2008 +0000 nfstrans-extra-protection-20080813 LICENSE IPL10 ensure, at least, that there is a filehandle for everything we check commit e5bf9b91eaf8cb930c6cf70419983901907db84d Author: Rainer Toebbicke Date: Thu Aug 14 00:44:16 2008 +0000 salvager-dont-corrupt-dir-lengths-20080812 LICENSE IPL10 FIXES 111585 make the int64 macros work when the "64 bit" number to fill isn't. use the correct variable type for length in salvager commit 156b13f74d4cc4e42644c9c9d7c63cb42f1d4ae3 Author: Jeffrey Altman Date: Wed Aug 13 15:10:42 2008 +0000 rx-buffer-allocation-pulled-20080813 LICENSE MIT remove delta rx-buffer-allocation-20080812 as it leads to data corruption commit 643a632a38d3a9b0b9d4819abb37e227b5946c47 Author: Jeffrey Altman Date: Tue Aug 12 19:39:59 2008 +0000 rx-buffer-allocation-20080812 LICENSE MIT Prevent rxi_MorePacketsNoLock() from dereferencing a NULL pointer if the requested allocation size cannot be satsified. In that case back off the number of packets until osi_Alloc() succeeds or panic if no packets can be allocated at all. In AllocPacketBufs() do not transfer more than rx_TSFPQGlobSize packets. Modify RX_TS_FPQ_GTOL2() macro to protect against transfering more packets that are actually free. Modify RX_TS_FPQ_COMPUTE_LIMITS() to enforce a rx_TSFPQGlobSize maximum value of 64 packets to prevent ever increasing allocation sizes within AllocPacketBufs() commit c19c4b3ebb9460eb373081fcbfcca6b7ae1f1495 Author: Jeffrey Altman Date: Tue Aug 12 05:29:52 2008 +0000 windows-stack-overruns-20080811 LICENSE MIT prevent stack overruns commit 1f6c7ca14a10ec476dc6720c264a004bc2c9d955 Author: Jeffrey Altman Date: Tue Aug 12 00:54:48 2008 +0000 windows-fs-mkmount-20080811 LICENSE MIT fix volume name validity test. strip trailing '.' from volume name commit eaf2843a81839d1431280fa54f05c69135205e5c Author: Jeffrey Altman Date: Sun Aug 10 01:00:59 2008 +0000 windows-make-nls-win2000-compat-20080809 LICENSE MIT make the nls module compatible with windows 2000. cannot use LOCALE_INVARIANT instead must lie and say everyone is US English. windows 2000 does not have normalization functions and now doesn't have case insensitive string comparison functions either for languages other than English. ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE MIT not all applications that link to cm_nls perform initialization. Call initialization if it has not already been done explicitly. commit d5af3b4236f72349551ce326d615d2e74d993c97 Author: Jeffrey Altman Date: Sat Aug 9 23:31:09 2008 +0000 windows-freelance-deadlock-20080809 LICENSE MIT avoid a deadlock between cm_freelanceLock and cm_scacheLock commit cd316ff51c12b8c6dd5c09384bbe1d700735fe3c Author: Jeffrey Altman Date: Sat Aug 9 05:52:36 2008 +0000 windows-rx-udpbufsize-20080809 LICENSE MIT Set UdpBufSize to 256K. Add RxUdpBufSize registry value to permit runtime configuration. commit 4eea9caac3cf260cf99ec67c30e31dd2d8c623d9 Author: Jeffrey Altman Date: Sat Aug 9 05:48:10 2008 +0000 windows-smb-skip-nuls-20080809 LICENSE MIT rename SMB_STF_IGNORENULL to SMB_STF_IGNORENUL apply SMB_STR_IGNORENUL when copying length tagged strings into the smb response packets. commit 423cdb708f21dcbc28f6563c7c49069f6a6ec155 Author: Jeffrey Altman Date: Fri Aug 8 17:43:37 2008 +0000 windows-lock-corrections-20080808 LICENSE MIT Derrick helped identify a few locations where rw or mx locks where not properly being tracked. As a result there were some locations in which an assertion could be thrown due to releasing the wrong type of lock. Also added lock_AssertXXX calls to some locations to ensure that the correct lock type is being held when the calls are made. volume location updates, cm_SyncOp, cm_SyncOpDone. commit 425d6e2e159798e8d6a6d092d780edef6b3a2220 Author: Jeffrey Altman Date: Thu Aug 7 14:46:11 2008 +0000 windows-max-cell-name-20080807 LICENSE MIT Anywhere cm_GetCell_Gen() is called CELL_MAXNAMELEN must be used otherwise there will be a stack overflow error. commit 467ac5e32d5d57056e6e19a47bb69b9d8ac0ba2d Author: Jeffrey Altman Date: Thu Aug 7 06:35:36 2008 +0000 windows-misc-20080806 LICENSE MIT Return CM_ERROR_READONLY if the caller wants PRSFS_DELETE and the volume is readonly. In cm_CheckNTDelete() do not call cm_SyncOpDone if cm_SyncOp failed Do not force the use of fake directory data if the user does not have PRSFS_READ on the directory. Let the bulkstatus call take place now that it is actually being used efficiently. In ApplyV3SearchDirPatches, use cm_SyncOp(CM_SCACHESYNC_GETSTATUS) to obtain the status info for Freelance entries instead of the bulkstatus call. Fix the truncation of 8.3 names in directory search responses. commit d0ed34baa0e23b7bb24ea009004a527331baf275 Author: Jeffrey Altman Date: Wed Aug 6 21:25:43 2008 +0000 windows-cell-name-length-consistency-two-20080806 LICENSE MIT fix what I broke commit d44f1a17e4e1831ef39b8f5767a2ca7aad870fb2 Author: Jeffrey Altman Date: Wed Aug 6 06:10:14 2008 +0000 windows-afssw-20080806 LICENSE MIT prevent buffer underrun and overrun errors commit 255d055e6123bcce76ef9e531a0c4963da4f0fef Author: Jeffrey Altman Date: Wed Aug 6 06:09:34 2008 +0000 windows-cell-name-length-consistency-20080806 LICENSE MIT make all cell name lengths consistent so that safer string copy/cat functions can be used to prevent buffer overruns commit aab4b2b32f933daf48cc138c0eb5d8cf5a2023b5 Author: Jeffrey Altman Date: Tue Aug 5 16:45:35 2008 +0000 windows-getaccessrights-20080805 LICENSE MIT Do not permit GetAccessRights() to be called multiple times within cm_SyncOp for the same rights check. If the GetAccessRights() succeeded and in the next loop the rights check fails, the user simply doesn't have the rights. Move a call to cm_SyncOpDone(FETCHSTATUS) from GetBuffer() to MergeStatus(). Anytime an RPC completes successfully we get updated status info for the object. Might as well allow threads waiting for status info to us it. commit a021b79556f7918598fc48bcd8742429f5620cc9 Author: Jeffrey Altman Date: Sun Aug 3 04:28:32 2008 +0000 windows-ioctl-make-submount-20080802 LICENSE MIT FIXES 109951 Restore the ascii version of cm_NormalizeAfsPathAscii() so that it can be used by cm_IoctlMakeSubmount(). commit 1fbbaaa8781d0cbdb484ea6c731622e79325fa2d Author: Jeffrey Altman Date: Sat Aug 2 20:46:14 2008 +0000 windows-afsconfig-header-20080802 LICENSE MIT Enable Bos Restricted mode for Windows commit cc8e39872e1663599c1172573c75cd35b839a370 Author: Jeffrey Altman Date: Tue Aug 5 15:29:14 2008 +0000 windows-smb-dir-search-20080802 LICENSE MIT Apply the bulk stat improvements to smb_ApplyDirListPatches() and smb_ReceiveCoreSearchDir() for consistency even though smb_ReceiveCoreSearchDir() is no longer called by any of the platforms we support. ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE MIT Only return 50 items at a time to the caller. Do not apply patches based on buffer boundaries. Instead apply patches when AFSCBMAX entries are ready to be processed in order to minimize the number of RPCs. commit b9e0ab9f5bc1d45fa5cb6ca9342d06ea29119149 Author: Jeffrey Altman Date: Sat Aug 2 05:56:57 2008 +0000 windows-smb-dir-search-20080801 LICENSE MIT minimize the number of RPCs sent to the file server. only request status for objects that we are actually reporting on and only if we do not already have status for the object and then make sure that we return as much as we can at once but not so much that it exceeds the RDR timeout commit 807a9aa7b20ab4f457f5235513a5ab15828d6e5c Author: Jeffrey Altman Date: Fri Aug 1 22:35:06 2008 +0000 windows-scache-deadlock-20080801 LICENSE MIT do not recycle a deleted scache object unless the refcount is 0 commit 0c0b89e04627cc43ab3e31c607be4470292a1d0a Author: Jeffrey Altman Date: Fri Aug 1 22:01:49 2008 +0000 windows-smb-dumpvars-20080801 LICENSE MIT When dumping the smb data structs, report flags in hex and paths are now wchar_t strings. commit 005077a7e4fdc9ca8bedb357050875df8f1aa898 Author: Jeffrey Altman Date: Fri Aug 1 14:36:54 2008 +0000 windows-smb-warnings-20080801 LICENSE MIT cast away a number of compile time data size warnings commit 1f7ab13b6fffcf236927c7e3173d6e59d1521f4c Author: Jeffrey Altman Date: Fri Aug 1 14:30:21 2008 +0000 windows-smb-vc-refcount-debugging-20080801 LICENSE MIT define DEBUG_SMB_REFCOUNT in smb.h to activate refcount debugging versions of the functions that log the file and line number as well as object and refcount. This is for use in debugging refcount leaks. rename GetPacket and GetNCB to smb_GetPacket and smb_GetNCB, etc., to enforce the name space. Do not confuse with similar Win32 API functions. restructure some code that refers to smb_vc_t references in order to clarify where the refcount is dropped. commit ebf66eff4b0e68e06c26522ae29e33a5b6fb3298 Author: Jeffrey Altman Date: Fri Aug 1 14:14:50 2008 +0000 windows-smb-dead-vc-gc-on-head-20080801 LICENSE MIT deltas windows-smb-dead-vc-gc-20080627 and windows-dead-vc-cleanup-take-two-20080703 attempted to protect against an infinite recursion when cleaning up dead smb virtual circuits. they failed to address the incrementing of the vc refcount in smb_ReleaseVCInternal when it is about to call smb_CleanupDeadVC. If the vc is already being cleaned, then smb_ReleaseVCInternal should not increment the refCount and should not call smb_CleanupDeadVC. (This commit was committed incorrectly to the 1-5 branch first. delta name on the head was modified to avoid the delta name collision.) commit c38036761eef51f26b085ca8bc69f4a0a65a2f4a Author: Jeffrey Altman Date: Fri Aug 1 05:22:08 2008 +0000 windows-osilog-20080731 LICENSE MIT increase the number of parms from 4 to 5 for osi_Log commit 91d1501be5e8ca0f957de2897c4c4ea0782dfbc3 Author: Jeffrey Altman Date: Thu Jul 31 18:01:12 2008 +0000 windows-ioctl-create-mount-point-validate-volume-20080731 LICENSE MIT validate the specified volume to make sure it exists before permitting the mount point to be created. This will catch many instances in which the user swaps the parameters to "fs mkmount". commit 14e516f1d5304a1b00c40321124a6b2067b977f2 Author: Jeffrey Altman Date: Thu Jul 31 13:43:00 2008 +0000 windows-wix-custom-20080731 LICENSE MIT in c++, arrays allocated with new[] must be deallocated with delete[] commit a46b1879dc187b44c48691946479d1e9599abcfb Author: Jeffrey Altman Date: Thu Jul 31 13:37:29 2008 +0000 windows-handle-vl_badname-20080731 LICENSE MIT Process VL_BADNAME so that when a user creates an mount point with an invalid volume name we will do something sane. commit b61ac7dc6ffb05b03011fef8cfdd5e72886fb705 Author: Jeffrey Altman Date: Thu Jul 31 05:45:44 2008 +0000 windows-volume-recycling-race-condition-20080731 LICENSE MIT When recycling cm_volume_t objects, avoid a race condition that could result in the same cm_volume_t object being recycling simultaneously in two threads. The end result would be a reference count miscount and an undercount assertion being thrown. commit aa24715f068dad4dfdc2140bf8f793297ba10ac9 Author: Jeffrey Altman Date: Thu Jul 31 05:39:29 2008 +0000 windows-buf-clean-error-handling-20080731 LICENSE MIT When an error such as access denied, out of space, out of quota, invalid fid, etc. is received while writing a dirty buffer to the file server, apply that error code to all outstanding dirty buffers immediately instead of attempting to write each buffer to the file server only to obtain the same error. commit 24fd571c5210764212e0de30a474f252b46353b3 Author: Jeffrey Altman Date: Thu Jul 31 05:32:57 2008 +0000 windows-remove-unnecessary-malloc-include-20080731 LICENSE MIT remove unnecessary #include commit 8c22d2388af3a2e99aeb70fdb81dbfa158413840 Author: Jeffrey Altman Date: Wed Jul 30 23:16:24 2008 +0000 windows-stat-resource-files-20080730 LICENSE MIT Add version resource info to xstat_cm_test.exe and xstat_fs_test.exe commit 34923419b3d680005375b1598c09b20ec49bcb1e Author: Jeffrey Altman Date: Wed Jul 30 21:00:21 2008 +0000 viced-write-perm-grants-read-lock-20080730 LICENSE MIT Remove extra return(EACCES) added by delta viced-write-perm-grants-read-lock-20070423 on head and 1.5 branch. commit 8cce5d2a61227da8623dcd08b11d997c66815cf1 Author: Jeffrey Altman Date: Tue Jul 29 03:54:34 2008 +0000 windows-buf-overquota-20080728 LICENSE MIT propagate overquota errors through buf_Write() and cm_FSync(). commit b45b059ed9772642489d56372cbd74db4f0cfc02 Author: Jeffrey Altman Date: Mon Jul 28 23:57:24 2008 +0000 windows-large-files-20080728 LICENSE MIT as part of the restructuring of code to separate the smb layer from the cm layer, large file support was broken. Define AFS_LARGEFILES in the right place so that it will be used in the cm. commit 674e94b29c09cf87496d74a01ebeada14413daac Author: Hartmut Reuter Date: Mon Jul 28 13:58:30 2008 +0000 salvager-avoid-directory-issues-and-mark-volumes-busy-20080728 LICENSE IPL10 FIXES 107767 avoid corrupting length in vnodeds when salvaging directories. avoid tag reuse leaving data behind (not verified) avoid not marking something busy during salvage commit eb1ff11bf14cfc64b4e224ef574d62e6e3757bc1 Author: Jeffrey Altman Date: Sun Jul 27 03:43:14 2008 +0000 windows-ioctl-prefix-data-20080726 LICENSE MIT The ioctl-prefix-data can be accessed either via a char_t or a wchar_t. Copy the data buffer with memcpy() and not strcpy() because we need to copy the entire string if it happens to be Unicode. commit 61d1578324b8b4f4a18fc12a3d199155692e8e4b Author: Jeffrey Altman Date: Fri Jul 25 21:25:55 2008 +0000 windows-build-20080725 LICENSE MIT update README-NT and src/ntbuild.bat build instructions. commit ba846eb82994469b904c104d52369fb55b985a20 Author: Jeffrey Altman Date: Fri Jul 25 20:43:36 2008 +0000 windows-nsis-vc-runtime-install-20080725 LICENSE MIT The NSIS installer was building a msi for the vc runtime that included the Debug merge modules when the Retail merge modules should have been used instead. commit c10b26ca355e47bfb486de971ac275fb281461ca Author: Jeffrey Altman Date: Thu Jul 24 20:32:58 2008 +0000 windows-buf-setdirty-20080724 LICENSE MIT Everytime the CM_BUF_DIRTY flag is set on a cm_buf_t, the userp field on the cm_buf_t must also be set. Add a cm_user_t parameter to buf_SetDirty() so that each function that calls it doesn't have to manually set the last write user. This improves code readability and the abstraction layering. commit 0ca9a136a79d78a81fb6a2e941b2a6feef0d4952 Author: Jeffrey Altman Date: Thu Jul 24 18:54:53 2008 +0000 windows-cm-makedir-20080724 LICENSE MIT Extend the cm_MakeDir() function signature to permit the (optional) return of the cm_scache_t object that was created by the operation in the same way that cm_Create() does. Make the return of the cm_scache_t by cm_Create() optional although it is never used that way. In both cm_Create() and cm_MakeDir() avoid releasing the cm_scache_t object until we are actually finished with it. commit 70bfb2c59b0f989a643a51ceac1fca86ef50b5dc Author: Jeffrey Altman Date: Wed Jul 23 22:40:34 2008 +0000 windows-cm-req-smb-20080723 LICENSE MIT Add smb_InitReq() calls cm_InitReq() and then sets the new CM_REQ_SOURCE_SMB flag. When this flag is set, the source of the request is known to be the SMB interface. This flag will not be set on requests generated by the various background daemons. commit 8f75470349f4e9ce4b861bac10e2816edb69f15d Author: Jeffrey Altman Date: Wed Jul 23 22:24:51 2008 +0000 windows-cm-rename-debugging-20080723 LICENSE MIT Add some trace log statements to cm_Rename() that can be used for debugging. commit a9c00f2638d44e1d077fbd953bf153df9cc319c4 Author: Jeffrey Altman Date: Wed Jul 23 22:19:19 2008 +0000 windows-btree-enum-20080723 LICENSE MIT Fix next enum to return an invalid param error when beyond the end of the list. commit 2ed0ee573c2b36cc6979693827e36f1ce6bdfa1b Author: Jeffrey Altman Date: Wed Jul 23 05:55:36 2008 +0000 windows-volume-deadlock-20080722 LICENSE MIT When updating the volume location information, if a new server must be allocated and the server is down, then it is possible for a deadlock to occur on the cm_volume_t rw lock. Prevent that from happening. commit 5db162c8dcb6ae81a631d5ae6e95959428b61a6a Author: Jeffrey Altman Date: Tue Jul 22 16:01:22 2008 +0000 windows-build-system-20080722 LICENSE MIT Move the man-pages build out of the 'install' step. commit 44379715638563f6271cf1853d7081cea18a6824 Author: Jeffrey Altman Date: Tue Jul 22 07:42:20 2008 +0000 windows-volume-vlgetaddrs-deadlock-20080721 LICENSE MIT A missing tilde makes a huge difference. commit b7398a8a50522fe15f8a30dead6487b219c7b5f5 Author: Jeffrey Altman Date: Mon Jul 21 21:55:06 2008 +0000 windows-more-rxconnp-20080721 LICENSE MIT convert additional 'connp' instances to 'rxconnp' in cm_volume.c, make sure that we hold a reference to the rxconnp whenever we use it to perform an RPC. commit 0172a6aa2637a6f7d2df584f4dba60cce0285c9e Author: Jeffrey Altman Date: Mon Jul 21 19:34:05 2008 +0000 windows-cm_conn-20080721 LICENSE MIT callp -> rxconnp commit a92cd4ec76509a84a93764b94831114e00bbc3d5 Author: Jeffrey Altman Date: Mon Jul 21 17:18:41 2008 +0000 windows-callp-to-rxcallp-20080721 LICENSE MIT There has been long time confusion in the windows cache manager because there are cm_conn object ptrs call connp and rx_connection object ptrs call connp and rx_call object ptrs called callp and rx_connection object ptrs called callp. From now on, rxconnp is a ptr to an rx_connection object; rxcallp is a ptr to an rx_call object; and connp is a ptr to an cm_conn object. commit ab1ddbe803005004978b86516e4bcd68ef668e67 Author: Jeffrey Altman Date: Mon Jul 21 10:19:26 2008 +0000 windows-smb-ioctl-setacl-20080721 LICENSE MIT setacl does not support the options structure. just call parse ioctl path. bug introduced during ioctl refactoring. commit ff0f4a596554bf4b09224ca000663b596a034013 Author: Jeffrey Altman Date: Sat Jul 19 15:47:40 2008 +0000 windows-volume-vlgetaddrs-deadlock-20080719 LICENSE MIT During cm_InitVolume() clear CM_VOLUMEFLAG_UPDATING_VL if we are reusing the cache data just in case. In cm_UpdateVolumeLocation() add trace logging to the sleeping, waking, and awaking states; move the destruction of the old server list into the region protected by the CM_VOLUMEFLAG_UPDATING_VL flag. commit af5e519e8e72c37b732474e08b6648bbdf458e95 Author: Russ Allbery Date: Sat Jul 19 07:41:06 2008 +0000 always-wrap-vos-ctime-20080718 LICENSE MIT When calling ctime on an afs_int32, always use a wrapper that assigns the variable to a time_t before passing it in rather than conditionally doing so on hosts with a large time_t. This eliminates a configure test, removes a bunch of warnings in vos.c on platforms with 32-bit time_t, and will make no difference in generated code with any decent compiler. commit 9682d4c1073846b13ae0825c8d6b020e5b31559c Author: Russ Allbery Date: Sat Jul 19 07:11:05 2008 +0000 kill-ubik-pthread-env-20080718 LICENSE BSD Everywhere AFS_PTHREAD_ENV was defined, UBIK_PTHREAD_ENV was defined as well, so don't make them separate. Building pthreaded Ubik is controlled by deciding whether to build the t* versions of various directories, not by the preprocessor directives. AFS_PTHREAD_ENV is only defined when building in those directories. This change eliminates UBIK_PTHREAD_ENV and uses AFS_PTHREAD_ENV to mean the same thing. As a side effect, fixes compiles on arm with --enable-pthreaded-ubik, since arm never defined UBIK_PTHREAD_ENV. commit c797e0844328f2ee437e3c659eab52fc590388b3 Author: Jeffrey Altman Date: Sat Jul 19 06:58:02 2008 +0000 windows-volume-vlgetaddrs-deadlock-20080718 LICENSE MIT If during volume location updating, the VL_GetAddrsU call fails for any of the identified servers, return an error but do so without leaking memory or deadlocking other threads that might be waiting. commit d3900e4f357cbd8a475ee3e8a786e646bdb43a01 Author: Russ Allbery Date: Sat Jul 19 06:44:49 2008 +0000 suppress-cellconfig-warnings-20080718 LICENSE BSD Add a forward declaration for struct ktc_encryptionKey to suppress warnings from cellconfig.h about declaring a struct in a prototype. commit 227f7e8eda70fbd62d0747a4334149fcd43deaf8 Author: Russ Allbery Date: Sat Jul 19 06:42:23 2008 +0000 more-no-unconditional-pthreaded-ubik-20080718 LICENSE BSD More directories should be conditional on pthreaded ubik. commit d811361ce9b64938c0eeb4ab4ca7ad77f6502c60 Author: Russ Allbery Date: Sat Jul 19 04:27:33 2008 +0000 no-unconditional-pthreaded-ubik-20080718 LICENSE BSD Don't compile pthreaded Ubik by default and instead actually require the --enable-pthreaded-ubik flag. commit 5bbdc3fb6904825f75ebdb1f2a17ed0ee6aefcfe Author: Simon Wilkinson Date: Fri Jul 18 15:54:22 2008 +0000 discon-prototype-correction-20080718 LICENSE IPL10 correct prototype for disconnected afs commit 8009b045aa5d20c527f1fa1fec0642f9ca0f9cd5 Author: Russ Allbery Date: Fri Jul 18 07:14:12 2008 +0000 man-page-fileserver-long-line-20080717 LICENSE BSD Fix long line in the SYNOPSIS for the fileserver man page. commit a8e8287b755ab9cd8e6904f66334b8a5cd1bcb39 Author: Russ Allbery Date: Fri Jul 18 01:21:44 2008 +0000 demand-attach-vos-install-location-20080717 LICENSE IPL10 In the tvolser case, install vos in ${afssrvsbindir}/vos, not ${afssrvlibexecdir}/vos. commit 24ac19c606f28642d0ea5f339a7d0eb0a2526b96 Author: Asanka Herath Date: Wed Jul 16 16:22:31 2008 +0000 windows-nls-zero-length-input-20080716 LICENSE MIT If the input to the string conversion files is zero length return nul string instead of NULL. Pass in -1 instead of computing the strlen. commit 6a749b71f7908129189ef10019372edc5b400c61 Author: Jeffrey Altman Date: Wed Jul 16 05:43:06 2008 +0000 windows-set-rx-dead-time-20080715 LICENSE MIT No longer set the rx_SetConnDeadTime and rx_SetConnHardDeadTime to the remaining request SMB RDR timeout within cm_ConnByMServers(). There are not per-call timeouts so simultaneous requests on the same connection will race with each other either resulting in premature timeouts or significantly extended timeouts. commit 4d7cfa129353001759c6224cc5c590be7e043fe9 Author: Derrick Brashear Date: Wed Jul 16 05:25:09 2008 +0000 softsig-structure-handling-20080716 LICENSE IPL10 this is sort of a dumb ifdef. harmless, but fix it to be what it's supposed to commit b4ce530d365e97342a92f4a8d59de12b0570c699 Author: Derrick Brashear Date: Wed Jul 16 05:15:44 2008 +0000 volser-reclone-bring-online-before-giveback-20080716 LICENSE IPL10 FIXES 107258 when giving back a volume after reclone, make it inService to avoid a race between callers and the SetFlags RPC commit 447915ce6a6f07a84affc22611287fe00b057534 Author: Asanka Herath Date: Wed Jul 16 00:58:28 2008 +0000 windows-nsis-vs2008-runtime-20080715 LICENSE MIT Add support for VS2008 Use MSI runtime installation package instead of EXE package Cleanup runtime from the correct directory commit 66754898d93c1b7c2862dd78801f8b14b5e74e72 Author: Jeffrey Altman Date: Tue Jul 15 22:17:37 2008 +0000 windows-wix-html-cmdref-20080715 LICENSE MIT Add new files to the installer. commit 5c762d3b7672a88fcf4df85e919ac11be7946d4f Author: Tom Keiser Date: Mon Jul 14 14:37:58 2008 +0000 dafs-avoid-assert-while-moving-volumes-20080714 LICENSE IPL10 The volume state is perfectly consistent. FSYNC_NEEDVOLUME (and the other state in the pending_vol_op object) is perfectly normal -- it simply means the volser has exclusive access to the volume for the purposes of cloning. The bug is that during the DAFS development, I changed the semantics of the VGetVolume interface without updating the control logic in afsfileprocs accordingly: In 1_4_x: vp->specialstatus != 0 results in returning vp with nUsers incremented and *ec = vp->sepcialstatus In DAFS: V_AttachState(vp) == VOL_STATE_UNATTACHED results in returning a NULL vp. Since (vp->specialstatus != 0), *ec = vp->specialstatus. The net result is we need to modify the VBUSY logic in CheckVnode(). commit 03fb36bd534a1ff13340e8d322c1e13eeef8ef43 Author: Jeffrey Altman Date: Mon Jul 14 14:36:44 2008 +0000 windows-smb-misc-two-20080714 LICENSE MIT Fix the assignment of SMB_ATTR_DIRECTORY. Apply it to the correct field name. commit 077c788275bff6b17e5ba44d487135f74dbedaee Author: Jeffrey Altman Date: Mon Jul 14 14:10:19 2008 +0000 windows-smb-misc-20080714 LICENSE MIT Fix declaration of smb_ParseStringBuf to be consistent with the prototype. If the fileType of a cm_scache_t is unknown and if the vnode is odd, then set the SMB_ATTR_DIRECTORY flag when reporting the DOS Extended Attributes. Fix the log message in smb_FindCMUserByName() to indicate "found" instead of "not found". commit 33429756c14ed006566d01ad4ee070a4c040b424 Author: Jeffrey Altman Date: Mon Jul 14 13:59:48 2008 +0000 windows-btree-enum-bulk-stat-20080714 LICENSE MIT Refactor cm_TryBulkStat() to permit BulkStat RPCs to be executed for lists of entries obtained either from the cm_dir structures or a btree enumeration. Add cm_BPlusDirEnumBulkStat() which takes an enumeration object and performs a bulk status rpc on every entry in the enumeration without advancing the enumeration state. commit faeb953142a15866f0a35e908114a2443f0ac703 Author: Russ Allbery Date: Mon Jul 14 06:53:14 2008 +0000 readme-devel-doxygen-20080713 LICENSE IPL10 Document the preferred Doxygen comment style. commit f49395a30adef98cb0deaea128393448565d364f Author: Russ Allbery Date: Mon Jul 14 06:46:27 2008 +0000 readme-fix-demand-attach-spelling-20080713 LICENSE IPL10 Fix the punctuation of the --enable-demand-attach-fs option. commit 1ed9e36ffc34fa5ea41b72131a222d0ab8195b54 Author: Russ Allbery Date: Mon Jul 14 06:35:04 2008 +0000 readme-improvements-20080713 LICENSE IPL10 Significant improvements to README, including: - Add documentation of (nearly) all of the configure options. - Update the platform list to reflect current reality. - Update the HP-UX header download instructions for the current web site. - Fiddle with formatting and wording in a few places. commit db9f59e9be12f791c122c4b8c6a8b8ecca8ce239 Author: Russ Allbery Date: Mon Jul 14 05:12:46 2008 +0000 threaded-ubik-cvsignore-20080713 LICENSE BSD Add .cvsignore patterns for threaded ubik builds. commit 2b7d9ab5d7c7947b1a45974d9a3252ce7e203a3b Author: Russ Allbery Date: Mon Jul 14 05:05:46 2008 +0000 autoconf-help-text-20080713 LICENSE IPL10 Use AS_HELP_STRING for every AC_ARG_WITH invokation and add proper quoting to all of them. Based heavily on a patch by Simon Wilkinson, but with less indentation and more quoting. commit 6a322e4eb7e79896e3322e0ace16a6ed99668162 Author: Russ Allbery Date: Mon Jul 14 03:27:00 2008 +0000 man-page-html-index-underscores-20080713 LICENSE BSD Remove underscores from the anchor in the index for all section 5 manual pages. commit 2a92f43987cd08dc0134b775e0d118894d22d3e5 Author: Russ Allbery Date: Mon Jul 14 02:45:14 2008 +0000 man-page-html-generation-hack-20080713 LICENSE BSD Pod::Simple::Search ignores every POD file that doesn't "look right," which means it skips files containing a period (like krb.conf.pod) unless you set a search option. Pod::Simple::HTMLBatch has no way to set search options. Apply a truly horrible hack to get around this. commit 298fb5ce52f3f5296c24ed1300287b5fa5870a3c Author: Jason Edgecombe Date: Mon Jul 14 00:51:35 2008 +0000 docs-ticket-104110-20080713 LICENSE BSD FIXES 104110 add vos clone and vos shadow to overall list ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE BSD FIXES 104110 add krb.conf update CellServDB to discuss AFSDB DNS records commit c766e74fd63a58e714d7b15ef1abfbc48b2a5a85 Author: Jason Edgecombe Date: Mon Jul 14 00:33:59 2008 +0000 docs-max-part-size-20080713 LICENSE BSD FIXES 86677 remove discussion of max partition size now that 1.5 has a limit of 2^64 KB. add discussion of techinical nature of fs minidump on windows. ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE BSD FIXES 86677 update discussion of max partition size. commit df9f2455fbe34ac105179797f85aacc63a8b8da8 Author: Jeffrey Altman Date: Sat Jul 12 06:54:58 2008 +0000 man-page-fs-read-not-list-20080711 LICENSE MIT - fs diskfree - fs examine - fs listquota - fs quota require read permission not list for the root directory of the volume and list permission for the preceding path. commit 30ba65bc5c216f73f89acf2aa97a4287a4de1f1f Author: Jeffrey Altman Date: Fri Jul 11 23:25:21 2008 +0000 windows-cm_req-layer-purity-20080711 LICENSE MIT Ensure that the cm_req_t object is allocated and initialized at the SMB layer for all incoming requests. This is done for two reasons: 1. ensure that request start time is consistent across the lifetime of the request 2. permit the request object to be used to carry a flag indicating the source of the request. This will permit different timeout algorithms to be used for SMB vs RDR in the future. commit 5baf817a31e72d85415222af5c3dee70ed1f6bd3 Author: Todd DeSantis Date: Fri Jul 11 10:49:33 2008 +0000 butc-xbsa-update-20080711 LICENSE IPL10 update xbsa support for current tsm commit 4f5b808414c958e7629c83f93d610b57c54274ac Author: Jeffrey Altman Date: Thu Jul 10 19:17:44 2008 +0000 windows-install-loopback-ddk-20080710 LICENSE MIT Add support for dynamically determining which ddk include path should be used. The NTDDKDIR variable used to be set to the specific directory in which netcfgx.h was located. Now it is set to the top-level of the DDK install tree. The specific directory that contains netcfgx.h varies based upon whether the DDK is 3790.1830 or 6000. Test for file existence and specify the one that works. commit f52f1522367819712ea678b4e3cdf4644571fc57 Author: Tom Keiser Date: Thu Jul 10 19:14:40 2008 +0000 dafs-update-exclusive-states-20080710 LICENSE IPL10 VOL_STATE_SALVSYNC_REQ is a mutally exclusive state. don't allow other things to attempt to trigger that state when an exclusive state is already present commit 078f966e6293504dc7fd0a7c6b49997b6739be71 Author: Derrick Brashear Date: Mon Jul 7 18:14:58 2008 +0000 solaris-udp-modname-20080707 LICENSE IPL10 older solaris 10 lacked this commit acf76ac85f55e268e9a99d12dc89bad4b763038b Author: Dale Ghent Date: Mon Jul 7 18:14:26 2008 +0000 solaris-nevada-vfsdev-type-20080707 LICENSE IPL10 FIXES 105495 in nevada, struct vfsdev_v4 -> vfsdev_t. cope. commit 9f3629b018f9d25b205f911464789ed0a14103b4 Author: Chas Williams Date: Mon Jul 7 17:53:48 2008 +0000 linux-revalidate-renames-correctly-20080707 LICENSE IPL10 FIXES 74672 when renaming causes a dentry to be newer than its parent we handled it incorrectly. zero the d_time to force correct evaluation to happen. commit 9946c027a33b89cdf128748b9fd3000b31bee48f Author: Simon Wilkinson Date: Mon Jul 7 17:42:14 2008 +0000 rhel3-disable-fedorakmod-20080707 LICENSE IPL10 FIXES 102673 if we're building for 2.4.x we need to disable fedorakmod. do so here in our packaging. commit e5e9463568bcbf9aa574e15cf47d231fef44685b Author: Jeffrey Altman Date: Sat Jul 5 16:48:36 2008 +0000 windows-pioctl-debugging-20080705 LICENSE MIT FIXES 105867 Replace multiple calls to IoctlDebug() within the same function with a variable. Save/restore more errno values. commit 44cd9c4e4cf6ef468e7e5880c8cb71ed277085c7 Author: Jeffrey Altman Date: Sat Jul 5 07:33:38 2008 +0000 windows-pioctl-debugging-20080704 LICENSE MIT FIXES 105867 David Botsch reports that when IoctlDebug is active, failures of fprintf overwrite 'errno'. Save and restore 'errno' around the fprintf calls. commit 99471963b3a035898419ace7bfafb24de464714c Author: Jeffrey Altman Date: Sat Jul 5 07:26:22 2008 +0000 windows-afskfw-20080704 LICENSE MIT if ktc_GetToken() fails, do not switch to krb524, just fail commit a4e3fb21f0fd8f02ffd2c01b4d39ac55cd3474b1 Author: Benjamin Bennett Date: Thu Jul 3 21:32:49 2008 +0000 linux-probe-syscall-table-again-20080703 LICENSE IPL10 FIXES 105457 move the init_mm ifdef down far enough that it's effective and we actually probe to be able to hook syscall table commit be32aef3831529f30f59088be5ea2060b55a95f6 Author: Jeffrey Altman Date: Thu Jul 3 06:53:10 2008 +0000 windows-dead-vc-cleanup-take-two-20080703 LICENSE MIT Prevent an infinite recursion when attempting to cleanup a previously dead vc. commit 08974551cb5257caea7315bcf726e0dba1a4d052 Author: Jeffrey Altman Date: Thu Jul 3 02:24:54 2008 +0000 windows-config-ntmakefile-i386_w2k-codesign-20080702 LICENSE MIT no underscore prepending CODESIGN_USERLAND macro commit 41927c3cbf068f71c2ef5f880f21a459477c62a0 Author: Jeffrey Altman Date: Thu Jul 3 00:00:37 2008 +0000 windows-config-version-20080702 LICENSE MIT Add AFSPRODUCT_VERSION to the AFS_component_version_number.h files Update copyright info and add underscores to version strings in rc files commit 65bf7cdb6d20a1ff4e71c79347782aa3b5f1e3f8 Author: Jeffrey Altman Date: Wed Jul 2 13:41:07 2008 +0000 windows-code-signing-20080702 LICENSE MIT Add code signing with signtool.exe to the build process. If all three of the required CODESIGN_xxxx environment variables are defined, signtool will be used to sign each exe, dll, and installer as they are built. The three environment variables are: CODESIGN_DESC = CODESIGN_TIMESTAMP = CODESIGN_URL = The default signing certificate is the one that will be used by signtool. If these environment variables are not defined, code signing will be skipped. commit 1c96127e37c0ec41c7a30ea3e4aa68f3cc8a24f6 Author: Simon Wilkinson Date: Tue Jul 1 23:44:14 2008 +0000 linux-packaging-module-build-20080701 LICENSE IPL10 Add --with-linux-kernel-packaging configure flag which disables building multiple kernels for different MP flavors, sets the kernel module name to openafs.ko with no version, and installs the modules into the standard Linux location. commit c61a8f37c9957034961aed8abc2a1adb046247d3 Author: Andrew Deason Date: Tue Jul 1 23:28:26 2008 +0000 libuafs-fixes-20080701 LICENSE IPL10 FIXES 104698, 104699, 104305 make cellname get init'd right. correct startup argument order to match what afsd does. call lookupname correctly (when did this break?) at the same time, move the lookupname define out of afs_osi.h and into each osi_machdep.h commit 0d343077ac1ca8bd35921de2a2b19cac4eb75496 Author: Andrew Deason Date: Tue Jul 1 20:41:13 2008 +0000 redhat-build-updates-20080701 LICENSE IPL10 FIXES 105231 update specfile for new manpages. update patch for 1.5.x/head update makesrpm to quote some arguments to system so perl doesn't eat them some rewriting from shadow@dementia.org including the patch update commit 19551ae3a541644013f6e9e92d9354ec14cbc00e Author: Derrick Brashear Date: Tue Jul 1 19:33:26 2008 +0000 volutil-partitionname2-r-return-value-20080701 LICENSE IPL10 return 0 and not tbuffer on success since tbuffer is already returned via a pointer commit c733e2e07aeb0cc981d53d843a1ffb787f43ed64 Author: Russ Allbery Date: Tue Jul 1 19:06:41 2008 +0000 more-cpp-fixes-20080701 LICENSE BSD Use PATH_CPP instead of CPP everywhere and always redirect the output instead of assuming that it will write to a file. Hopefully this is the least common denominator across all systems, although it still isn't fully correct for systems that have no separate cpp binary. commit fb3490cdea7e45dbac4a8aa820f35bf1723af764 Author: Derrick Brashear Date: Tue Jul 1 18:45:01 2008 +0000 linux-nfstrans-updates-20080701 LICENSE IPL10 FIXES 105019 make libuafs also include afs_warn.c commit 5e1459f431fc046dfd3b25aca87709193ccca211 Author: Russ Allbery Date: Tue Jul 1 06:47:27 2008 +0000 pt_util-database-path-20080630 LICENSE BSD Use the dirpath functions to find the prdb database path in pt_util instead of hard-coding the default Transarc path. commit 7b3967db163a5c9f79cb0637883f8a6708796acc Author: Derrick Brashear Date: Tue Jul 1 05:58:38 2008 +0000 pinstall-collateral-damage-use-install-sh-usefully-20080701 LICENSE IPL10 this is gross. but ac_INSTALL wants things to begin with / and @ is not /. so we cheat and use /@abs_top_srcdir@/install-sh -c if INSTALL began with ./ commit daf6b1cf282c895bb7cd3cb090e5bee06648cd16 Author: Marc Dionne Date: Tue Jul 1 04:33:38 2008 +0000 linux-nfstrans-updates-20080630 LICENSE IPL10 FIXES 105109 exportfs - NFS translator: - The exportfs code is updated for the new export ops. The changes are made conditional on a new configure test that detects the new ops. fh_to_dentry() basically replaces decode_fh and uses our own get_dentry function instead of the now defunct find_exported_dentry. - A check for fh_len=4 is removed - in testing this value is always 6, possibly because of changes in the kernel code. - The check for authtab in osi_nfssrv.c assumes that an undefined weak symbol is 0. On my system, an unresolved weak symbol in a loaded module gets the value 0xfffffffe (-2 or -ENOENT) - again, probably a change on the kernel side. Check that the pointer is not an error constant using IS_ERR(). - In osi_vfsops.c, only use the export_ops bits if building the translator afspag: the problem here was dealing with unresolved symbols - afs_showflags is redefined in afs_pag_call.c so it's available for the afspag module - A new source file afs_warn.c gets the afs_warn* functions from afs_util.c. This allows the afspag module to get the afs_warnuser function without dragging in too many symbols. The new file is attached separately. other: - d_path() now takes a struct path argument - includes a new configure test - osi_vfsmnt -> osi_vfsmount in osi_misc.c Looked like a typo? - reorder the remove_proc_entry() calls - we need to remove the children before the parent (introduced with my earlier patch) commit e22a5cc8afe889d5d76ecf44a63860e12f1effbf Author: Thomas Galliano Date: Tue Jul 1 04:05:58 2008 +0000 ubik-lwp-createprocess-64-bit-20080630 LICENSE IPL10 FIXES 104732 use NULL and not (void *)0 to avoid issues on 64 bit platforms commit c0124d51796de2c7790b702cf7805b499ff28c99 Author: Derrick Brashear Date: Tue Jul 1 03:38:03 2008 +0000 revert-pinstall-collateral-damage-20080630 LICENSE IPL10 we'll fix this another way (with install-sh) commit 1ec104280d4a4b0a7544a99a7366f59cd3a2cc5f Author: Russ Allbery Date: Tue Jul 1 00:00:40 2008 +0000 cpp-fixes-20080630 LICENSE BSD When probing in configure for cpp, use the user's PATH first and then the /lib and /usr/ccs/lib directories. Set PATH_CPP instead of CPP, since the latter is just overwritten by Autoconf. Use PATH_CPP by preference in rxgen and when pre-processing assembly, since otherwise newer gcc will treat the input file as linker input and not do anything with it. Don't assume that cpp writes to the second argument; gcc apparently doesn't always do this. Instead, redirect standard output. commit 99c1e0beb1b7aebfe7f3f10b73da8b6795d11464 Author: Russ Allbery Date: Mon Jun 30 23:53:22 2008 +0000 disconnected-merge-conflict-20080630 LICENSE BSD Fix a disconnected-mode merge conflict with an older import of disconnected to HEAD that caused a duplicate definition of PDiscon. I believe this problem was only on HEAD. commit 9b61f58fa78259eb092350599a0a26d75ac14fa8 Author: Russ Allbery Date: Mon Jun 30 23:35:18 2008 +0000 man-page-html-index-20080630 LICENSE BSD Use the correct subcommand name (fs getacl instead of fs_getacl) on the HTML index page, even though we have to use the underscore in the NAME section of the actual POD documentation. commit 9f94f89a7a894651f18947ec7ac20959f9326478 Author: Russ Allbery Date: Mon Jun 30 21:50:23 2008 +0000 linux-ucontext-fixes-20080630 LICENSE BSD Use undef in the arch-specific param file to override UCONTEXT rather than adding a conditional in a generic file, making arm work the same as 32-bit SPARC. Disable UCONTEXT on parisc as well; glibc doesn't provide the ucontext functions on that architecture. commit d82169c51cc1d4db5de1c51dabeb1d6fe712fb79 Author: Russ Allbery Date: Mon Jun 30 20:55:40 2008 +0000 bozo-find-linux-core-files-20080630 LICENSE BSD Current Linux kernels always append a period and the PID to "core" when creating core files for multithreaded processes. Teach bosserver to scan the directory into which core files are deposited looking for such core files and treat them like any other core file if the PID matches the process that just died. This patch has been in the Debian OpenAFS packages for some time without problems. commit 6331d37125428956586610b8e514e1b304a16022 Author: Russ Allbery Date: Mon Jun 30 20:49:19 2008 +0000 man-page-vos-convertROtoRW-inode-20080630 LICENSE BSD vos convertROtoRW can now be used with an inode file server. Adjust the man page accordingly. commit 2b48a4c67acee5c25128d5f2fc9371fe0a89dd1f Author: Jeffrey Altman Date: Mon Jun 30 20:48:32 2008 +0000 windows-wix-cmdref-subdirs-20080630 LICENSE MIT Construct the directory hierarchy correctly. CmdRef/{1,5,8} commit cf816d535a60a7a5f7efa5564b647ee87e33b7d7 Author: Russ Allbery Date: Mon Jun 30 20:47:30 2008 +0000 man-page-readme-update-20080630 LICENSE BSD Add additional missing commands to the to-do list. Add a section on man page section numbers and their rationale. Document that embedding a license in the man page isn't required if it's one of the licenses in our LICENSE file. commit db13ad4de73814e90b108faa0d1246e224836ece Author: Tom Keiser Date: Mon Jun 30 18:28:35 2008 +0000 dafs-state-analyzer-setup-cursor-20080630 LICENSE IPL10 avoid an uninitialized cursor commit 1b98b43127e3286b7842de4c59ea50f5a7de4424 Author: Jeffrey Altman Date: Mon Jun 30 14:59:30 2008 +0000 windows-nsis-cmdref-subdirs-20080630 LICENSE MIT install and remove the subdirectories of the CmdRef commit 7460987e758fa299849d877633053c05cb431977 Author: Asanka Herath Date: Mon Jun 30 14:38:17 2008 +0000 windows-wix-install-idn-redist-20080630 LICENSE MIT Only install IDN redistributables on XP and 2003 commit fed6593bf343425807f425aeb8315886feeb8670 Author: Jeffrey Altman Date: Mon Jun 30 03:55:36 2008 +0000 windows-nsis-install-idn-redist-20080629 LICENSE MIT Install IDN on XP and 2003 only commit 5da4137cbe2574fc8602bd7ffaeaf8d85bd9e010 Author: Jeffrey Altman Date: Sun Jun 29 06:08:00 2008 +0000 windows-remove-ibm-docs-20080628 LICENSE MIT Remove (from the en_US distributions) the IBM Quick Guide and IBM Release Notes. Update references and installers. commit dff0d834a7c03d19d572d74849599ac89c2a058e Author: Chaskiel M Grundman Date: Sun Jun 29 04:38:59 2008 +0000 afs-blacklist-initialize-volume-ptr-always-20080628 LICENSE IPL10 always initialize this commit 618a180164c7f1f2772f722f40191e3d99028e90 Author: Jeffrey Altman Date: Sun Jun 29 02:48:18 2008 +0000 windows-generate-html-cmdref-makefile-argh-20080628 LICENSE MIT It would be nice if we added the file to the correct directory. Add Windows makefile to build the html cmdref files from the pod man-pages commit ee8a5d7019ca88114455412e58dab83b1bd1736b Author: Jeffrey Altman Date: Sun Jun 29 02:27:14 2008 +0000 windows-cmdref-20080628 LICENSE MIT Reference cmdref/index.html from the en_US documentation commit 4af6e48bdb69ceb8de8f2da7fd8a98944632ede9 Author: Jeffrey Altman Date: Sun Jun 29 02:21:10 2008 +0000 windows-install-new-cmdref-20080628 LICENSE MIT Install the new man pages as the OpenAFS Command Reference. Update both the nsis and wix installers. commit 6a34c5c4f6a77be71043fa3f4aecccf5f7051d93 Author: Jeffrey Altman Date: Sun Jun 29 00:41:00 2008 +0000 windows-build-doc-manpages-20080628 LICENSE MIT build the manpages for windows commit da989e5d95f1cfee9b0823b184b9aa6f86ed5a0c Author: Jeffrey Altman Date: Sun Jun 29 00:30:43 2008 +0000 windows-generate-html-cmdref-makefile-correct-20080628 LICENSE MIT commit the correct version of the NTMakefile commit d600d661ad495678423fd56a7fc2d5ee340a65ae Author: Jeffrey Altman Date: Sun Jun 29 00:23:48 2008 +0000 windows-generate-html-cmdref-makefile-20080628 LICENSE MIT Add a windows makefile to generate the html cmdref from the pod files. Requires perl on the build system. commit 62ffbc2a464521eeee4c244d2555c316dfae180f Author: Russ Allbery Date: Sat Jun 28 07:32:45 2008 +0000 remove-administration-reference-20080627 LICENSE IPL10 Purge the old AFS Administration Reference documentation. This has now been completely replaced by the manual pages. commit 3b273dd55291b28c698990001370a97c413c2673 Author: Russ Allbery Date: Sat Jun 28 06:19:22 2008 +0000 install-and-document-klog-krb5-20080627 LICENSE IPL10 Install the Kerberos v5 klog as klog.krb5 and install a man page for it. commit 49db6afe0aeb646d712a5319a7ea1a511f66f298 Author: Jeffrey Altman Date: Fri Jun 27 20:42:57 2008 +0000 windows-smb-dead-vc-gc-20080627 LICENSE MIT When an SMB virtual circuit is prematurely closed due to an error condition by one thread it is possible that there are still several other threads still using the VC which will determine that the VC is dead shortly. As a result we maintain a dead vc list to ensure that dead vcs are not destroyed while still in use. With the addition of locking though this causes a problem because the locks allocated to the virtual circuit are not freed until the vc is destroyed. This patch reworks the cleanup routine to make the freeing of resources the responsibility of the release routine when the refcount hits 0 and the VC is marked dead. commit e381e1d07822639ba4ce00c96ff483034104afb5 Author: Jason Edgecombe Date: Fri Jun 27 04:49:45 2008 +0000 man-page-afs-fixes-20080626 FIXES 104745 LICENSE BSD Fix several issues with the afs(1) man page. Based on the patch by Jason, but I also documented /vicepiv as the maximum, and /vicepiu as the maximum recommended, partition. commit d9dc7e28fe73b1e3ac2773fb1efd44e67de5e21d Author: Jason Edgecombe Date: Fri Jun 27 04:29:12 2008 +0000 man-page-vldb_convert-20080626 FIXES 104192 LICENSE BSD New man page for vldb_convert. commit fbe10c80860ce9f456a056e0d397a10411f22369 Author: Jason Edgecombe Date: Fri Jun 27 04:19:07 2008 +0000 man-page-vos-clone-20080626 FIXES 104110 LICENSE BSD Add man page for vos clone. commit 0e04d01891eb2269653a84f86b066ebe10eb8a54 Author: Asanka Herath Date: Fri Jun 27 03:04:12 2008 +0000 windows-wix-install-idn-redist-20080626 LICENSE MIT Install the Microsoft IDN Redistributables which are required for Unicode Normalization on XP and 2003. commit 149fd85b205911c2393a570eac6d5a811c9ffd72 Author: Asanka Herath Date: Fri Jun 27 02:58:36 2008 +0000 windows-nsis-install-idn-redist-20080626 LICENSE MIT Install the Microsoft IDN Redistributables which are required for Unicode Normalization on XP and 2003. commit c051bf547636be32372d5eb01afc0b1c55f25c43 Author: Jeffrey Altman Date: Thu Jun 26 18:04:04 2008 +0000 windows-vlserver-makefile-20080626 LICENSE MIT more consistency changes to get the make rules for headers right commit bc2836058afd44d237e602c1746d1d71c95951c5 Author: Jeffrey Altman Date: Thu Jun 26 17:46:35 2008 +0000 windows-nls-includes-20080626 LICENSE MIT Add include for cm_nls.h commit 3b41209be7a1470e186a87764621c9980ae7448a Author: Asanka Herath Date: Thu Jun 26 06:43:49 2008 +0000 windows-unicode-20080626 LICENSE MIT This patch is the second stage of the Unicode conversion. In this stage the cache manager has been converted from using 8-bit UTF8 C strings to 16-bit UTF16 C strings in the SMB, the DNLC, the B+ tree, and other directly related modules. The cm_cell, cm_volume, cm_scache, cm_buf, cm_dcache, and cm_dir modules are left 8-bit because their data is all 8-bit UTF8 since they work only on file server strings. The SMB layer accepts 16-bit UTF16, the B+ tree and DNLC use normalized strings as the key, and everything uses UTF8. Efforts have been made to minimize the number of transitions from UTF8 to UTF16 and back. For the most part strings are tagged with clientchar_t and normchar_t and fschar_t types in order to distinguish between the various types of strings that are in use. other changes include addition prototyping. commit ef58ff2ea67323e5260484597abe6bdfa63d8c72 Author: Asanka Herath Date: Tue Jun 24 14:41:13 2008 +0000 windows-osilog-safestring-unicode-20080624 LICENSE MIT convert to using microsoft safe string functions. add Unicode version of osi_LogSaveStringW. This is safe to use export even in none Unicode builds. Some reformatting. commit 9d1863dae7ee6675c77c7ecf398c6c4c4cc811c1 Author: Matt Benjamin Date: Tue Jun 24 13:58:10 2008 +0000 tubik-build-fix-20080624 LICENSE IPL10 add missing build dependencies commit 98b87a2ac1ce5673142b26ae5aad2ef640efe51f Author: Matt Benjamin Date: Mon Jun 23 18:50:06 2008 +0000 tubik-build-fix-20080623 LICENSE IPL10 add missing build dependencies commit e5f9eba38634c2b07da1d7b20fb45cfdd772a27c Author: Derrick Brashear Date: Mon Jun 23 04:40:56 2008 +0000 doc-nfs-translator-instructions-20080622 LICENSE IPL10 FIXES 103459 clarify instructions for the translator commit 583b267eb0025bd78e7dd325775428557e3934ad Author: Marc Dionne Date: Thu Jun 12 21:08:18 2008 +0000 linux-2626-updates-20080612 LICENSE IPL10 FIXES 102821 fixes which went into 1.4.x already commit bb617c649cd18c30db40f7e1976eeddf0ae1545b Author: Marc Dionne Date: Thu Jun 12 21:00:12 2008 +0000 cvsignore-updates-20080612 LICENSE IPL10 FIXES 102819 add missing things to cvsignore files commit a33cd20d1b19c8c8587a5850d1239900d02db3d7 Author: Marc Dionne Date: Thu Jun 12 20:58:23 2008 +0000 tubik-no-pinstall-on-head-20080612 LICENSE IPL10 FIXES 102819 no more pinstall on the head commit a7b33b55bb34027262fb5deb686a86fba1d2f832 Author: Tom Keiser Date: Thu Jun 12 20:12:06 2008 +0000 dafs-updates-20080612 LICENSE IPL10 pending changes from tom to avoid a deadlock issue commit e2ce8710efc93f7172b9d4daaf685c6f2669f7c3 Author: Derrick Brashear Date: Thu Jun 12 19:36:15 2008 +0000 ptserver-simple-corrupt-protection-20080612 LICENSE IPL10 protects against direct loops, which we have seen in the wild, but not more (yet) commit bc47951c9ec0845eafe0d1634f56b761cbf8b06f Author: Derrick Brashear Date: Thu Jun 12 18:24:25 2008 +0000 volume-limit-higher-20080612 LICENSE IPL10 allow more volume lookups to be cached commit 15ff831e4dfa8d2942536d002b86579f6128a5df Author: Jeffrey Altman Date: Thu Jun 12 17:04:38 2008 +0000 windows-buf-clean-access-denied-20080612 LICENSE MIT If the attempt to write the buffer returns access denied, store that in the cm_buf_t object so that the error can be propagated. commit d8c3a598184df6066c330769e49fb1e301464e52 Author: Jeffrey Altman Date: Thu Jun 12 15:54:23 2008 +0000 windows-pioctl-refactoring-20080612 LICENSE MIT Refactor the pioctl handling to provide a layer of abstraction between the smb server and the actual pioctl data processing. This will permit a redirector pioctl layer to be implemented on top of the core cm_ioctl interfaces. The general approach is that there is a new cm_ioctl_t object which is embedded withing a higher level abstraction object. This object maintains all of the pioctl state processing and removes any notion of file descriptors or other communication channel parameters. The cm_ioctl module maintains just about all of the core functional processing except for SetToken which needs further abstraction. Path processing is now performed at the higher layer and cm_ioctl functions accept cm_user_t, cm_scache_t, and cm_req_t objects from the higher layer. The smb_ioctl module performs all of the path translation using smb server knowledge and passes the necessary objects to the cm_ioctl module for processing. commit 52490d7968c2008912ab0887bdcde7fbba43b837 Author: Jeffrey Altman Date: Thu Jun 12 15:20:46 2008 +0000 windows-scache-deletion-and-lock-verification-20080612 LICENSE MIT Add lock assertions to various functions. Obtain a missing lock around a call to cm_RemoveSCacheFromHashTable(). Correct an abstraction layer violation. cm_scache_t objects should be marked deleted in cm_Unlink() and cm_RemoveDir() and not in smb_CloseFID(). Cleanup of deleted cm_scache_t objects should be performed in cm_ReleaseSCache() when the reference count hits zero. Prototype cm_AdjustScacheLRU() and re-implement it using osi_QAddH(). commit 3306c0887b62ca940808174906c2579b3b7d939a Author: Jeffrey Altman Date: Thu Jun 12 15:00:08 2008 +0000 windows-vnodeops-wrong-logfile-20080612 LICENSE MIT Use afsd_logp instead of smb_logp in osi_LogX() calls. Do not violate layer abstraction. commit ef48d6343d9ac929a4a2ae88184f7801ace1e3d1 Author: Jeffrey Altman Date: Thu Jun 12 14:33:36 2008 +0000 windows-scache-hash-tables-20080612 LICENSE MIT Prevent corruption of the cm_data.scacheHashTablep lists when removing and then re-adding entries to the hash table. The cm_scache_t nextp fields were not being reset to NULL which permitted loops to be created. commit bed3e31ca4da711649d6c6b9ab828515cd3418fc Author: Marc Dionne Date: Mon Jun 9 04:38:58 2008 +0000 linux-2626-support-20080608 LICENSE IPL10 FIXES 101091 add 2.6.26 support commit 0da0a9d4d2e5b2d39495e57b9840ce0acdd961e2 Author: Rainer Toebbicke Date: Mon Jun 9 04:30:11 2008 +0000 limit-mountpoint-symlink-abuse-20080608 LICENSE IPL10 FIXES 100836 official mountpoints end in a .; treat others as symlinks to avoid creating files which can't be removed commit ad05cdf649044dcc0b1db39aed8652338fb8c945 Author: Jeffrey Altman Date: Fri Jun 6 14:36:16 2008 +0000 windows-check-server-memleak-20080606 LICENSE MIT Found a memleak in the cm_CheckServers routine. Plug it. commit 39d2ac1438c5708dc64098e5de10cd55efd6e93b Author: Jeffrey Altman Date: Fri Jun 6 00:22:03 2008 +0000 windows-bpluss-memleak-20080605 LICENSE MIT when deleting entries from a directory for items with non-8.3 names memory for the longname field would be leaked. don't do that. commit 1473a8747a104af3938a14393f73da666149b114 Author: Russ Allbery Date: Thu Jun 5 21:19:10 2008 +0000 man-page-readme-fileserver-20080605 LICENSE BSD Remove the note about missing file server options. We think we got them all. commit 1fdfac7065b85feafcfa3f9fc382cfd90680d67f Author: Jason Edgecombe Date: Thu Jun 5 20:31:13 2008 +0000 man-page-pts-updates-20080605 LICENSE BSD Add documentation of foreign realm user registration and cross-realm PTS groups. Add documentation of missing ptserver flags. Add some additional to-do entries for the man pages. commit b5d888ed404840e5a25a26880daaf47ab415b282 Author: Jeffrey Altman Date: Wed Jun 4 09:02:21 2008 +0000 windows-btree-short-name-20080604 LICENSE MIT When constructing the shortname keyed entry in the tree, make sure that the original long name is preserved. commit 79b7b4eaded831a33d85f580e9e4155528fbd35f Author: Derrick Brashear Date: Tue Jun 3 03:53:54 2008 +0000 linux24-hlist-unhashed-configure-test-fix-20080602 LICENSE IPL10 make the hlist_unhashed test actually work commit 2b937b867f3420972b3f617710b44184df7bacc2 Author: Jeffrey Altman Date: Thu May 29 18:19:21 2008 +0000 windows-vlserver-remove-extraneous-make-targets-20080529 LICENSE MIT remove extraneous make targets commit 749ae65481ebc70f310fdd79d2cb0139a636f27e Author: Jeffrey Altman Date: Thu May 29 14:31:41 2008 +0000 rx-init-more-packets-20080529 LICENSE MIT It is frequently the case that rx_getAllAddr() is called before rx_Init() or rx_InitHost(). rx_getAllAddr() obtains the list of interfaces by using rx_GetIFInfo() which in turn computes and allocates the number of addition rx packets. Unfortunately, rxi_MorePackets() relies on the existence of an initialized mutex and the mutex is not initialized (on Windows) until the rx_InitHost() call. Therefore, we must delay the rxi_MorePackets() call until after rx_InitHost() if rx_getAllAddr() is called previously. Failure to do so results in a panic. commit 11350e8024c8413dab5f91cfcd2155d26356329f Author: Jeffrey Altman Date: Thu May 29 05:02:36 2008 +0000 strftime-portability-20080528 LICENSE MIT %T is not portable to Windows. Replace it with the equivalent %H:%M:%S format string. commit c5bce0f87dc11cfaf5a7fabe16fe7efd24a4d200 Author: Jeffrey Altman Date: Thu May 29 04:35:19 2008 +0000 rx-out-of-memory-20080528 LICENSE MIT in rxi_MorePackets() if osi_Alloc() fails to return the requested memory call osi_Assert() instead of permitting subsequent null pointer dereferences to corrupt the stack. commit 5ad08dc1662c9c7eeea10dadd39f7a1f793f761b Author: Jeffrey Altman Date: Wed May 28 19:37:09 2008 +0000 windows-vlserver-headers-20080528 LICENSE MIT make sure the headers are copied to the correct location by providing explicit rules commit dc835c2d5397cc2b310dea374b043032b779ee3a Author: Jeffrey Altman Date: Wed May 28 18:40:06 2008 +0000 windows-buf-redirector-20080528 LICENSE MIT Define new flag CM_BUF_REDIR for use with the redirector. When set, the flag indicates that the buffer is being held by the redirector and it should be left untouched by the cache manager. commit 5930abcbe169db3a8e676ebe558249af9ccdfa0f Author: Jeffrey Altman Date: Wed May 28 18:33:17 2008 +0000 windows-cpluscplus-compat-20080528 LICENSE MIT Do not use reserved keywords 'new' and 'delete'. Permit headers to be included by files compiled in cplusplus mode. commit 54c0f2f8370c129a01b99233c98a758ba0eb2f17 Author: Jeffrey Altman Date: Wed May 28 18:27:32 2008 +0000 windows-unused-var-20080528 LICENSE MIT remove unused var cm_CachePathLen commit 7b8c8a48a354a45ec34ed672aef1ea0255e4b4f1 Author: Jeffrey Altman Date: Wed May 28 18:21:33 2008 +0000 windows-btree-20080528 LICENSE MIT add cm_btree.h to afsd.h include list commit c5911d25f8772aa1bb9b28a6cd58b8b781b479c1 Author: Asanka Herath Date: Tue May 27 21:33:14 2008 +0000 windows-unicode-20080527 LICENSE MIT An incremental commit. This patch adds support for normalization of Unicode but we have concluded that the normalization rules are incorrect. Normalized strings should not be written to the file server or returned to the application. commit b1549f29a9515de09d4a64bfb28bf5afdfee2615 Author: Jeffrey Hutzelman Date: Fri May 23 15:55:29 2008 +0000 rx-client-keep-keepalives-20080523 LICENSE IPL10 FIXES 20727 not our bug, but, previous code refactoring broke rx. put back keepalives in cli ent rx connections while they are turned around. commit 18a36a3f624755fbcaee776102177f47e26711b7 Author: Simon Wilkinson Date: Fri May 23 15:57:18 2008 +0000 disconnected-20080523 LICENSE IPL10 add readonly disconnected support commit b26f133a56911c4a20e848cf85d40640aa37253a Author: Derrick Brashear Date: Thu May 22 22:03:16 2008 +0000 darwin-rc-common-does-set-minus-u-20080522 LICENSE IPL10 we need to cope with an unset variable commit c34822d6105cef7f68423e4ebbf485b2d11b9635 Author: Jeffrey Hutzelman Date: Thu May 22 19:28:37 2008 +0000 rx-client-keep-keepalives-20080522 LICENSE IPL10 FIXES 20727 not our bug, but, previous code refactoring broke rx. put back keepalives in client rx connections while they are turned around. commit 8450a1eb1da3e2b77f9ae86b5adee4aaa7136e14 Author: Derrick Brashear Date: Thu May 22 04:51:27 2008 +0000 dafs-volumestats-conflict-20080521 LICENSE IPL10 avoid symbol conflict in volume.h commit dcafea769a1cb70c7b1f8763ae4f7b7744b2a436 Author: Derrick Brashear Date: Wed May 21 21:15:41 2008 +0000 vos-sync-flag-voltype-properly-20080521 LICENSE IPL10 when adding a backup volume to a vldb entry, flag it as such. commit 1705bda53e4ca198cf78d70ff424fc7af69b1879 Author: Simon Wilkinson Date: Wed May 21 16:40:52 2008 +0000 tweak-regen-20080521 LICENSE IPL10 make regen quieter if you don't want man pages commit 30f65085f7a53ae073e2c4649a462a3a555ebb61 Author: Derrick Brashear Date: Wed May 21 14:51:56 2008 +0000 macos-tuning-20080521 LICENSE IPL10 be more aggressive to get better performance commit 1206e7538be86f073b21cd289266286b60a95d0a Author: Derrick Brashear Date: Wed May 21 05:22:13 2008 +0000 pmtu-and-prefetch-20080520 LICENSE IPL10 try hard to optimize using the wire for high latency connections commit c761f248397334400f8b4bb71cc4d01d3e4fc6ff Author: Derrick Brashear Date: Tue May 20 22:02:49 2008 +0000 linux-hlist-unhashed-opencoding-20080520 LICENSE IPL10 FIXES 93871 if we can't use hlist_unhashed (which is dumb) or we don't have it (less dumb) work around it. ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE IPL10 FIXES 93871 if we can't use hlist_unhashed (which is dumb) or we don't have it (less dumb) w ork around it. commit f00df529b79d9df64b77dd7b054eb362a92c279e Author: Matt Benjamin Date: Tue May 20 21:24:16 2008 +0000 rx-connection-clones-20080520 LICENSE IPL10 FIXES 89557 add connection clones to allow more than maxcalls per "connection" commit 3edb97360b7d971750e54471037584d7a9a74993 Author: Derrick Brashear Date: Tue May 20 20:48:34 2008 +0000 aix-unpin-after-free-20080520 LICENSE IPL10 FIXES 99456 in order that cleanup be safe we need to do it this way commit 090b2eebfa9fb48deea94bf7b511e693a251e041 Author: Jeffrey Altman Date: Wed May 14 05:14:57 2008 +0000 windows-smb-parse-string-20080513 LICENSE MIT if the input length is 0, smb_ParseString should return the NUL string not NULL. Do not permit unprotected DebugBreak() calls. commit 53cffb32ab7cc5a650d0bbaa66686a44ea206888 Author: Jeffrey Altman Date: Mon May 12 04:02:28 2008 +0000 windows-unicode-normalize-btree-20080511 LICENSE MIT Attempt to normalize afs directory strings before inserting them into the B+tree. commit 9e67c4f766892f7c0b79a2d6a1d8b96a7e4b7100 Author: Asanka Herath Date: Mon May 12 02:36:36 2008 +0000 windows-unicode-support-normalize-20080511 LICENSE MIT Actually normalize when normaliz.dll is present. commit 9d28d95151418189e8004734eca0edd498edd46b Author: Jeffrey Altman Date: Sun May 11 14:15:51 2008 +0000 windows-unicode-support-20080511 LICENSE MIT In NTCreateX a zero length name is permitted. This can occur when opening the root directory of a share. Change cm_NameEntries() to accept a size_t* instead of long* since that permits better type safety. commit b5dc1903a4bca5bae099beec0b95840df7282250 Author: Jeffrey Altman Date: Sat May 10 16:19:35 2008 +0000 udebug-display-lastyeshost-order-20080510 LICENSE MIT lastYesHost is already in network byte order. do not reorder it again when displaying it. commit c26dc0e6aaefedc55ed5c35a5744b5c01ba39ea1 Author: Derrick Brashear Date: Fri May 9 19:50:39 2008 +0000 server-meltdown-avoidance-20080509 LICENSE IPL10 if the server is melting down or otherwise unable to reply with data, it will cut itself off. commit a36ec90cff608c3805f524070eb21aacc118f9e2 Author: Asanka Herath Date: Fri May 9 15:49:36 2008 +0000 windows-unicode-support-20080509 LICENSE MIT This delta provides a fairly complete implementation of Unicode character set support for the Windows Cache Manager and supporting tools including fs.exe, symlink.exe, the pioctl library, and the explorer shell extension. New Build requirements: In order to build the Microsoft IDN Mitigation APIs SDK 1.1 is now required. This SDK provides the normalization.h header and the redistribution install packages required to install normaliz.dll. The AFSDEV_INCLUDE path must be modified to point to the directory containing normalization.h. There are no lib files for this package. Cache Manager: The CM SMB server has been modified to negotiate the use of UNICODE. By default it is on. The "fs smbunicode" command can be used to disable UNICODE at runtime. cm_utils now contains UNICODE normalization and conversion routines built on top of the IDN Mitigation APIs. All input strings are normalized with UNICODE Normalization Form C. The pioctl interface now supports UTF8 strings in addition to ANSI. UTF8 strings are prefixed with % 8 as per the ISO 2022 extension. Pioctl Library: New apps should use the pioctl_utf8() function instead of pioctl(). pioctl() is for ANSI strings and provides backward compatibility with third party apps. fs.exe and symlink.exe: Converted to Unicode applications. All strings are now communicated using UTF-8. Explorer Shell Extension: Converted to a Unicode DLL. All strings are now communicated using UTF-8. Fonts on U.S. Windows distributions are not fully populated. As a result not all of the characters can be displayed in all of the dialog boxes. Still to do: 1. Add Unicode normalization to AFS directory entries and mountpoint and symlink target strings. 2. Use the Unicode version of GetCurrentDirectory in fs_utils.c 3. Update the installers to install the IDN Mitigation APIs on XP and 2003. Vista already has them and they are not supported on pre XP SP2 releases. commit 048ae7c7e63e03af16925613aeec8243b45ffe70 Author: Jeffrey Altman Date: Fri May 9 04:53:08 2008 +0000 windows-have-snprintf-20080509 LICENSE MIT Visual Studio provides [v]snprintf. No need to define and export it. commit 3feee9278bc8d0a22630508f3aca10835bf52866 Author: Derrick Brashear Date: Thu May 8 22:24:52 2008 +0000 rx-retain-windowing-per-peer-20080508 LICENSE IPL10 we learned about the peer in a previous connection... retain the information and keep using it. widen the available window. makes rx perform better over high latency wans. needs to be present in both sides for maximal effect. commit e6c818f070022529c362e42dfed340f54b2fd26e Author: Jeffrey Altman Date: Thu May 8 22:17:49 2008 +0000 viced-avoid-infinite-loop-with-altaddr-unset-20080508 LICENSE IPL10 if we return leaving a non HOSTDELETED host while it does not have ALTADDR set, a loop can happen. avoid it by simply setting ALTADDR again when we're done, if we believe some addresses are still good this is fine. commit ef619db804d471fda3bf3f77d55e8cd4e4699b29 Author: Jeffrey Altman Date: Thu May 8 06:25:42 2008 +0000 windows-buf-invalidate-on-vnovnode-20080507 LICENSE MIT Once we know that an attempt to stablize a buffer has failed due to VNOVNODE, stop trying to Stablize future buffers and just invalidate all of them belonging to the same FID. commit c847fb4964c0ec24c404cf1fb353b08af81b5eac Author: Derrick Brashear Date: Tue May 6 16:01:05 2008 +0000 viced-large-more-threads-20080506 LICENSE IPL10 fileserver -L should imply -p 128, not -p 12 commit 98e658b7821f5020c67c05503f9e2c61c945554a Author: Jeffrey Altman Date: Fri May 2 20:29:43 2008 +0000 windows-server-retry-20080502 LICENSE MIT do not retry if there is no server available for the current attempt commit abff169b58764380650e6e162707be68d3aa9bf1 Author: Derrick Brashear Date: Fri May 2 01:59:27 2008 +0000 butc-xbsa-lwp-protoize-damage-20080501 LICENSE IPL10 make xbsa variant work again commit 7915302f28091dd0a6547f0f58fa5ceb581cc21a Author: Derrick Brashear Date: Thu May 1 20:00:00 2008 +0000 uuid-corrected-duplicate-check-20080501 LICENSE IPL10 apply check to chain, not input commit 0a2c144307d2471450c0660e141906a1f7b1ea36 Author: Derrick Brashear Date: Wed Apr 30 20:07:43 2008 +0000 client-idledeadtime-support-20080430 LICENSE IPL10 in the event a server is "melting down" and not responding with data to RPCs this adds the ability to time out the calls rather than letting keepalives effectively hang the client forever. does not mark the server down since... it's not down. Side effect: adds similar tracking for authentication errors so tokens need not be discarded if one server's clock has drifted. commit 888bc28b1886e994d430ddc61657e60a910208a6 Author: Derrick Brashear Date: Mon Apr 28 22:48:00 2008 +0000 ubik-recovery-swap-in-new-fd-20080428 LICENSE IPL10 when recovery is done, forcibly invalidate the old fd commit 668cd5331e4857a73ba1d849446e0dfcae97eadf Author: Hans-Werner Paulsen Date: Mon Apr 28 17:14:55 2008 +0000 tbutc-wrong-lp-getrwindex-20080428 LICENSE IPL10 FIXES 96575 The pthread butc crashes with SIGSEGV, when I restore to a volume which already exists. This does happen with OpenAFS 1.4.7pre4 on i386_linux26. Looking into the code I think butc is using the wrong function Lp_GetRwIndex (at volser/vsprocs.c:4394). It uses the one in the library lib/libvosadmin.a, but should use the function defined in volser/lockprocs.c. commit 25d9dbb6be970d54c4711890b2085c153eda15fa Author: Jeffrey Altman Date: Mon Apr 28 16:18:52 2008 +0000 udebug-64bit-time_t-vs-printf-20080428 LICENSE MIT 64-bit time_t values cannot be passed to printf() for evaluation by a %d variable. To avoid the problem we cast the value to int. commit 2f2d5fd8a7e80802fead9ee944e33c1a0c818abd Author: Jeffrey Altman Date: Mon Apr 28 16:04:38 2008 +0000 windows-rx-idle-timeout-20080428 LICENSE MIT Add "IdleDeadTimeout" registry value and call rx_SetConnIdleDeadTime() with it when creating new rx connections. This forces the Rx stack to return RX_CALL_TIMEOUT if the file server has returned VBUSY for longer than the IdleDeadTimeout. When RX_CALL_TIMEOUT is received, the cache manager will now attempt to find another server for the object that might be less busy. commit 7a6751c08800da5d49bf3def9175174499f6337e Author: Chaskiel M Grundman Date: Mon Apr 28 04:45:03 2008 +0000 kdump-install-fixups-20080427 LICENSE IPL10 FIXES 96465 The install rule: - installs the empty 'kdump-build' file instead of the binary on all platforms except irix - overwrites the selection script with the binary on linux and hpux - doesn't have an alpha_linux branch - installs the wrapper script as kdump32 and the binary as kdump on solaris (instead of vice-versa) The dest rule: - overwrites the selection script with the binary on alpha_linux and hpux commit c8f4d9f0079b7eeacf831061a0c39310aafaa045 Author: Derrick Brashear Date: Sun Apr 27 04:59:51 2008 +0000 redhat-cellservdb-update-20080423 LICENSE IPL10 take update from upstream commit 2aa615fed2b801a7ed3abf7da5aaa293a4f783bf Author: Derrick Brashear Date: Sun Apr 27 04:53:59 2008 +0000 zero-uio-len-when-trimming-20080426 LICENSE IPL10 make it match ufsread case. should change this later. commit b1bf96f7581e58137f49e2b685cf6e91ff4f7dda Author: David Botsch Date: Fri Apr 25 12:39:45 2008 +0000 macos-afscell-configurator-20080423 LICENSE IPL10 not ready for release, but, add a tool which installer can run to ask for a cell name AUTHOR LICENSE IPL10 ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE IPL10 not ready for release, but, add a tool which installer can run to ask for a cell name commit b87935a4c5f26357e29f1db46eff8b1cf9185f3b Author: Derrick Brashear Date: Thu Apr 24 23:44:01 2008 +0000 vos-move-avoid-spurious-unlock-20080424 LICENSE IPL10 lightly modified from what Bren Mills submitted; the second unlock call after mfail may be entirely useless. commit 088eb9158bf553d5b3dcea8f37d3bec439419d44 Author: Jeffrey Altman Date: Thu Apr 24 17:21:01 2008 +0000 windows-buf-refcount-20080424 LICENSE MIT Implement DEBUG_REFCOUNT refcount tracking code to debug refcount issues in the cm_buf module. Fix a refcount leak caused by buf_IncrSyncer() incorrectly removing cm_buf_t objects from the dirty list. Fix the dumping of the dirty list to actually dump the dirty list. commit 6143f2eb5c85f5c428578b60b3b8892321f7fbe1 Author: Jeffrey Hutzelman Date: Thu Apr 24 04:08:03 2008 +0000 windows-cellservdb-20080423 LICENSE IPL latest greatest CellServDB commit 6809ba29fadbd0d84ff6a9bf2ccd909b2f54b186 Author: Dan Hyde Date: Wed Apr 23 19:56:52 2008 +0000 vol-setaside-one-fd-per-thread-20080423 LICENSE IPL10 FIXES 87977 kids these days share badly. give each one their own fd otherwise they fight. commit d18f5104f57152dfb6d1125a2d3a8bf17a266f44 Author: Simon Wilkinson Date: Tue Apr 22 13:50:23 2008 +0000 linux-fedora9-packaging-updates-20080422 LICENSE IPL10 make build system able to cope with fedora 9 commit 8bf142ae2a979447b259b0945187379812883bee Author: Derrick Brashear Date: Mon Apr 21 20:40:22 2008 +0000 libadmin-vos-irix-fixes-20080421 LICENSE IPL10 irix is cranky about missing prototypes commit 92b5087b42653d5358433c06d60f3adc67a11015 Author: Derrick Brashear Date: Mon Apr 21 19:53:45 2008 +0000 dafs-irix-prec99-20080421 LICENSE IPL10 unless/until we build c99, irix needs this commit a6ef7fed731628a5e5b8af62f7e986d6f7ccf444 Author: Jeffrey Altman Date: Mon Apr 21 16:35:12 2008 +0000 windows-cache-version-20080421 LICENSE MIT increase the cache version because the cm_volume_t data structure was modified. commit 0caa578a05150451c706c2ec6c3d095c671a7043 Author: Simon Wilkinson Date: Sat Apr 19 22:55:02 2008 +0000 linux-fc9-20080419 LICENSE IPL10 add in needed changes for fc9 kernels commit 194067be89293d2f3ee4e791515c3ac020d3a551 Author: Derrick Brashear Date: Fri Apr 18 21:49:45 2008 +0000 klog-deal-with-aix-stupidity-20080418 LICENSE IPL10 aix krb5 is broken. deal. commit 2a0f8bfda8b00de429cb15481e3e20d5d140a81c Author: Derrick Brashear Date: Mon Apr 21 19:59:14 2008 +0000 ppc64-linux-26-thread-info-20080418 LICENSE IPL10 thread_info is dead commit c3eb805fc0309efca059a26b946eb4350417867e Author: Jeffrey Altman Date: Fri Apr 18 17:43:19 2008 +0000 windows-volume-status-20080418 LICENSE MIT A problem was discovered with cm_Analyze when serverRef instances are marked offline. cm_CheckOfflineVolume() was not resetting the serverRef state. cm_Analyze was also waiting in sleep calls when it was it is clear that waiting would not result in a change of state. cm_CheckOfflineVolume() was updated to always reset the serverRef state and indicate that the volume should be considered online for the purpose of retrying when the serverRef state is reset to srv_not_busy. The problems identified in the MIT dev.mit.edu stress test environment are resolved by these changes. commit f3056feadbd6866bddc20e040b5005baeb4c8cad Author: Derrick Brashear Date: Fri Apr 18 14:55:33 2008 +0000 klog-aix-missing-symbols-20080418 LICENSE IPL10 aix's krb5 isn't heimdal or mit. it has dangling symbols. yay! commit 8ea0eef2d6807d2ad51d29853335f115439e616c Author: Derrick Brashear Date: Fri Apr 18 14:54:30 2008 +0000 lwp-fix-protoize-20080418 LICENSE IPL10 make this cast correct. commit 5f6b59f4601e9892e082a145a75e5872818d2e06 Author: Rainer Toebbicke Date: Tue Apr 15 13:29:20 2008 +0000 linux-fakestat-avoid-mtpt-fillin-issue-20080415 LICENSE IPL10 FIXES 93898 "It is actually the detection of a "cell" in the mount point string which triggers the (loosely consistent) fakestat handling - it's treated like a foreign cell and the mount point is never "completely evaluated", i.e. logically replaced by the root directory of the volume in question. As a result, callbacks are ignored, as they go against the directory and not the mount point." commit 4440b9a61247a0da020042b4262695f0ef7d35de Author: Jeffrey Altman Date: Mon Apr 14 22:32:27 2008 +0000 windows-volume-20080414 LICENSE MIT 1. Convert cm_volume_t mutex to a rwlock (rw). 2. Don't hold cm_volume_t lock across RPCs 3. Add CM_VOLUMEFLAG_UPDATING_VL flag to prevent multiple threads from performing volume update calls at the same time on the same volume set. 4. Convert the .rw, .ro, and .bk cm_vol_state_t members of cm_volume_t to an array of cm_vol_state_t members indexed using the pre-existing RWVOL, ROVOL and BACKVOL preprocessor symbols. This will permit consolidation of code and make it easier to add new volume types to the volume set in the future. commit 7936739f44372458fffb86058b3279d53995bd8b Author: Derrick Brashear Date: Mon Apr 14 21:25:41 2008 +0000 volser-prototype-include-fix-20080414 LICENSE IPL10 so tvolser can build again commit 7bfe889eb2e900719c70cd9fd29f82569ef4c04c Author: Jeffrey Altman Date: Fri Apr 11 18:44:47 2008 +0000 windows-freelance-20080411 LICENSE MIT Do not set the DV on the rootSCachep because doing so disables the use of MergeStatus(). Do not remove the rootSCachep from the hash table because doing so makes causes a second cm_scache_t object for that fid to be created that is not the root. commit 40d41c191bdb64256d4ccf6a5f1bab8124249e63 Author: Jeffrey Altman Date: Thu Apr 10 18:50:49 2008 +0000 vos-noresolve-option-20080410 LICENSE MIT Add a -noresolve option to all vos commands. This permits the display of servers by IP address instead of DNS name. Very useful when 127.0.0.1 is registered as the server address or when trying to eliminate multi-homed addresses. commit fab6653cf714ee6121cd7a22857f22f86a969559 Author: Simon Wilkinson Date: Wed Apr 9 17:39:36 2008 +0000 void-return-casts-20080409 LICENSE IPL10 do apporpriate casts for void returns to placate irix cc commit 7faf596b439cce022cfa4b3174cd17a1f0a0901e Author: Jeffrey Hutzelman Date: Wed Apr 9 14:38:47 2008 +0000 linux-nfstrans-avoid-access-deadlock-20080409 LICENSE IPL10 avoid deadlocking in access while we're already holding locks as filldir is doing its work commit 494568ea929af96bf2b641e31b970cf695f13240 Author: Asanka Herath Date: Wed Apr 9 05:34:22 2008 +0000 windows-nsis-vs2005-20080409 LICENSE MIT Add support for building with VS2005 Runtime Libraries. For the release build use the vcredist_.exe package. For the debug build, build an msi from the merge modules and then install that package. commit 1495088e4168a2ddf35135db872777b9e51823b3 Author: Simon Wilkinson Date: Tue Apr 8 19:35:51 2008 +0000 redhat-spec-updates-20080408 LICENSE IPL10 FIXES 93616 update to correctly fill in specfile from source tree commit 0d2e36cac80d4c49db8e6b12988344107b7b1cd4 Author: Jeffrey Altman Date: Mon Apr 7 15:19:10 2008 +0000 windows-strlwr-cellname-20080407 LICENSE MIT cellnames are case insensitive and by convention they are lowercased. commit c108d606f59b6f5edcb863de3f3d9d7ecc44f04a Author: Jeffrey Altman Date: Mon Apr 7 15:16:48 2008 +0000 windows-freelance-three-20080407 LICENSE MIT deliver notification events to watchers when adding mount points or symlinks to the freelance root.afs volume. commit 8f57819a99273812c1d9ba7ec504689b05b83b14 Author: Jeffrey Altman Date: Mon Apr 7 07:00:16 2008 +0000 windows-freelance-two-20080407 LICENSE MIT do not add the scp into the hash table twice. commit a642541b960f601d7396c28ca08ee7fd32975ce6 Author: Jeffrey Altman Date: Mon Apr 7 06:42:44 2008 +0000 windows-freelance-20080407 LICENSE MIT When freelance symlinks and mountpoints were modified the target string value was not being updated and the old data was not being invalidated. commit c7ee4828e0d7c631fcd827d1a4c9af8bebb2fc2d Author: Marc Dionne Date: Mon Apr 7 04:48:45 2008 +0000 linux-no-syscall-probe-with-no-init-mm-20080406 LICENSE IPL10 FIXES 88000 no better idea for this, got to do something... push this for now commit ef19cea44c433ec7c1d214e8229b5fb4ea4b6ef6 Author: Jeffrey Altman Date: Sun Apr 6 14:33:12 2008 +0000 windows-fid-hash-20080406 LICENSE MIT 1. During the conversion to hash based FID comparisons the cm_GetSCache() lookups from the cm_ioctl.c (CM_IOCTL_QOPTS_HAVE_FID) and from FIDs returned by cm_LookupSearchProc() were broken. 2. In cm_LookupInternal(), ensure that an error is returned if rock.found is FALSE. A failure to return an error was resulting in cm_GetSCache() producing an object for FIDs with vnode=0,unique=0 3. cm_GetSCache(), remove the warning check for vnode=0,unique=0 4. reapply the synchronization logic to async store requests in cm_SyncOp(). The lack of synchronization is causing requests to complete out of order which is confusing the SMB redirector when under heavy load. commit 5dd7e65c6fd233e70d98b271cbf48ac2356efe0f Author: Derrick Brashear Date: Sat Apr 5 19:02:59 2008 +0000 revert-ubik-changes-20080405 LICENSE IPL10 these changes are unneeded; remove them commit 5640c4a1b5bea4e61ff2e6c2da02265c3e1ba612 Author: Kevin McBride Date: Fri Apr 4 20:58:35 2008 +0000 volser-preclude-alternate-partition-clones-20080404 LICENSE IPL10 patch based on work from shadow@dementia.org the idea is to preclude multiple copies of a volume replica on a server, as there's nothing to indicate which copy is correct and you can end up serving stale data when you think you've just released and are serving something good commit e62727e328c8fad2a5b7b305745a248d9aabe19a Author: Derrick Brashear Date: Fri Apr 4 16:39:53 2008 +0000 tubik-more-makefile-fun-20080404 LICENSE IPL10 kill off library name reuse commit ece59f688a8820e3ea0601f77ed1b99af7ae7cfd Author: Derrick Brashear Date: Thu Apr 3 17:58:11 2008 +0000 tubik-head-makefile-compat-20080403 LICENSE IPL10 match new style install stuff commit 65e701fee4968b17066bb81e25b7adaa4024d4f3 Author: Kevin McBride Date: Thu Apr 3 17:41:12 2008 +0000 tubik-vos-20080403 LICENSE IPL10 build pthreaded vos commit 5f67c569455f0597d42b5a2cccf89e470ed74c53 Author: Derrick Brashear Date: Thu Apr 3 15:20:41 2008 +0000 tubik-20080403 LICENSE IPL10 avoid bogus dependency here too commit bc1a7f1ee8fb12eeb7b54f89987e6f240627a579 Author: Derrick Brashear Date: Thu Apr 3 04:54:34 2008 +0000 tubik-one-more-20080402 LICENSE IPL10 handle the rest of the issues commit 33161360381d5ec67f884c087da26bd8009a0511 Author: Derrick Brashear Date: Thu Apr 3 02:20:25 2008 +0000 tubik-makefiles-fun-20080402 LICENSE IPL10 these fixes brought to you by delicious beer. commit ec02ff4342844c0d83ed3e9e5e27aef7c3af7204 Author: Derrick Brashear Date: Wed Apr 2 22:45:05 2008 +0000 tubik-makefile-fixes-20080402 LICENSE IPL10 don't use gmake macros. ick commit 9fbbc3f50cc6f04796a8a444bc06acc66a9c55a6 Author: Steven Jenkins Date: Wed Apr 2 20:47:27 2008 +0000 pthreaded-ubik-20080402 LICENSE IPL10 add pthreaded ubik and various binaries commit 93c326ef08cacc730470a7af75041d943825260b Author: Marc Dionne Date: Wed Apr 2 19:19:57 2008 +0000 linux-flush-compare-20080402 LICENSE IPL10 because i let this slip out like this. sigh. commit 31d06c78b2f8ea14877bebf05097b33cc7e233f2 Author: Harald Barth Date: Wed Apr 2 14:08:19 2008 +0000 linux-flush-unlock-20080402 LICENSE IPL10 because i let this slip out like this. sigh. commit 5fe4de574dba287b8197263028ac49014955a483 Author: Tom Keiser Date: Tue Apr 1 21:28:05 2008 +0000 salvageserver-init-handler-lock-20080401 LICENSE IPL10 init lock commit 0faa1e0412c4cb22e6820473fa60cdea5d516550 Author: Derrick Brashear Date: Tue Apr 1 21:15:46 2008 +0000 tsalvaged-clean-20080401 LICENSE IPL10 make clean target work here commit 48838bab91b50a5cf8cd3fb7d1902e6b7525bb86 Author: Derrick Brashear Date: Tue Apr 1 21:05:19 2008 +0000 vol-osi-assert-20080401 LICENSE IPL10 undo the old windows afs assert undoing commit 695d1aa896cf38cfe9856ba1c45b6b3cca7565a2 Author: Derrick Brashear Date: Tue Apr 1 19:15:29 2008 +0000 aklog-debug-text-dont-deref-null-ptr-20080401 LICENSE IPL10 yeah, this is sort of dumb commit 3f54c934b9c933d5f34644a096c821375db17d97 Author: Simon Wilkinson Date: Tue Apr 1 18:44:28 2008 +0000 aklog-tidyup-20080401 LICENSE IPL10 FIXES 92643 remove windows code (osolete) from unix branch do other minor cleanup commit 94aa281af8c9cb74561a32a34cb7cd5b5da97cdf Author: Derrick Brashear Date: Tue Apr 1 17:49:42 2008 +0000 vlserver-checksignal-returns-voidstar-20080401 LICENSE IPL10 FIXES 92662 CheckSignal returns void*, don't try to return an int directly. commit 9bdb8599c094821d0dfb29505cc63aa2a8460ae2 Author: Tom Keiser Date: Tue Apr 1 15:09:54 2008 +0000 synvageserver-no-rx-server-refs-20080401 LICENSE IPL10 FIXES 92648 remove reference to rx service mutex and thread tracking. we need to ensure there's nothing else either but this is true now commit 4bcb7d01b2a8aa6ce53cf1c0b093058b4e5072f1 Author: Jason Edgecombe Date: Tue Apr 1 07:50:28 2008 +0000 man-page-vos-shadow-20080331 LICENSE BSD Man page for vos shadow. commit a26d7f1403d7d41d51836442a7a4759f4fc2bfe4 Author: Mike Meffie Date: Mon Mar 31 16:54:14 2008 +0000 test-updates-20080331 LICENSE IPL10 update tests directory commit 99a29903c8b77e2e3260bf06d913367fadbc4fed Author: Jeffrey Altman Date: Sun Mar 30 17:19:01 2008 +0000 windows-aklog-cross-cell-20080330 LICENSE MIT report the new ID after a successful cross cell registration commit 2169423f6821672be5506ab388d6faa0ed37f0d0 Author: Jeffrey Altman Date: Sun Mar 30 15:10:05 2008 +0000 windows-aklog-robustness-20080330 LICENSE MIT Fix the order of parameters to strncpy ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE MIT Fix the order of parameters to strncpy Add error checking to all krb5 functions. Initialize the global ccache variable to NULL. commit aff582765a8af5ce8743e28ee4d33bf8e4396d63 Author: Jeffrey Altman Date: Sun Mar 30 05:16:17 2008 +0000 windows-vlserver-makefile-20080329 LICENSE MIT make references to INCFILEDIR consistent commit c6897cee01063d6d6ad302e6527794130f007d74 Author: Jeffrey Altman Date: Sun Mar 30 04:30:52 2008 +0000 windows-use-client-realm-for-tokens-20080329 LICENSE MIT Two recent changes to the AFS/Kerberos landscape have been causing problems for aklog and related modules. First, the support for multiple local realms for the cell has broken the pts auto-registration code when the realm used for the token acquisition does not match the realm belonging to the selected vldb server. Second, Kerberos referrals prevents detection of the realm of the vldb server. This commit adds a new method of searching for the afs service principal. The first attempt is for afs/@. If found, the is used as the realm of the cell. The patch adds error handling for KRB5_ERR_HOST_REALM_UNKNOWN which is returned when krb5_get_host_realm() can't determine the realm. Duplicate queries are also avoided and copy_realm_of_ticket() is properly employed. commit 07d806845e1bf790c8cbe8e6a711e99e0958235b Author: Tracy Di Marco White Date: Fri Mar 28 17:11:19 2008 +0000 nbsd-update-20080328 LICENSE IPL10 FIXES 92073 fix nbsd30 param file, add nbsd40 param file commit b2e3e6427522c92ce4132abf2ca08ce18599b16b Author: Jeffrey Altman Date: Fri Mar 28 14:01:03 2008 +0000 windows-freelance-20080328 LICENSE MIT 1. return CM_ERROR_NOSUCHFILE when attempting to remove a symlink or mount point that does not exist 2. When adding a new symlink or mountpoint, be sure to increment the number of local mount points 3. When re-initializing the fake root.cell the unique value is always one, not two. Use cm_FidCmp() to compare fids. The use of the value two prevented the invalidation of existing values because all of the directory entries are created with the unique set to one. commit be49dbe89161415a4a78f2f6b588fb94ee940ae9 Author: Derrick Brashear Date: Fri Mar 28 04:41:00 2008 +0000 pinstall-collateral-damage-20080327 LICENSE IPL10 it's really easy to get into install-sh relative path hell. work around it. commit e0021180665fa75af88c3ebf0d7f58f93918ceab Author: Douglas Engert Date: Thu Mar 27 18:48:22 2008 +0000 krb5-klog-solaris-krb-20080327 LICENSE IPL10 FIXES 91573 no krb5_mcc_ops on solaris krb5. cope commit 87e959e87df52e026ffcb2de8ecfcbf4889f7bd8 Author: Derrick Brashear Date: Thu Mar 27 18:39:57 2008 +0000 ptutil-swap-epoch-version-as-needed-20080327 LICENSE IPL10 FIXES 90869 do byteswapping of epoch and version so we print and compare sensibly commit 7c05046f1f097a6ded89a5928ea48aca224f520a Author: Derrick Brashear Date: Thu Mar 27 16:20:29 2008 +0000 volser-higher-thread-limit-20080327 LICENSE IPL10 with tvolser we can increase this and actually *see benefit*, so... commit 6c9647cc614cfdf9b2c9cc8adb7b3c6b741e1f4e Author: Alistair Ferguson Date: Thu Mar 27 16:16:02 2008 +0000 dafs-vshutdown-match-id-to-params-20080327 LICENSE IPL10 we track shutdown thread parms as index rather than device; deal correctly commit 1cf6c12a075cb0705cd8680291d78d215d4fe996 Author: Chas Williams Date: Wed Mar 26 04:16:51 2008 +0000 linux-dont-flush-writes-on-exec-20080326 LICENSE IPL10 FIXES 17509 because of when fds are NULL'd in file_table this should work except when one process has the same file open for read and for write in different FDs; otherwise, the last write fd to close collects the error. commit 3f8be40525ae84980f1519e60f4b9f73bd4cc676 Author: Marc Dionne Date: Wed Mar 26 04:10:26 2008 +0000 linux-restore-iget-cachemgr-20080326 LICENSE IPL10 FIXES 88000 restore the d_alloc_anon we need commit f3776341151ad2c9b439567411e908836b16d415 Author: Jeffrey Altman Date: Sun Mar 23 14:10:42 2008 +0000 windows-vlserver-include-path-20080323 LICENSE MIT Fix the INCFILEDIR definition so that the INCFILES actually exist commit 76494a572e504c426fe9dabc8e68115f7ee6a05c Author: Marc Dionne Date: Sun Mar 23 00:53:29 2008 +0000 linux-2625-update-20080322 LICENSE IPL10 FIXES 88000 update 2.6.25 patch to hopefully cover what we need better commit 887f2869e309d00dff095b033dabf59231ef3300 Author: Jeffrey Altman Date: Sat Mar 22 00:19:03 2008 +0000 windows-aklog-cleanup-20080321 LICENSE MIT make krb5_context global. wrap all calls to exit() in a new function, akexit(), which performs cleanup of the krb5_ccache and the krb5_context. commit 493afd1e59661e64120a8d655d6503ac396ca46b Author: Tom Keiser Date: Fri Mar 21 16:59:03 2008 +0000 aix-unix-sockets-fix-200803221 LICENSE IPL10 FIXES 88088 use aix's macro for the size of sockaddr_un commit 94f32208af8896e144e18aa34d80bf2924b4ac36 Author: Jeffrey Altman Date: Fri Mar 21 12:20:21 2008 +0000 windows-aklog-20080320 LICENSE MIT Windows Error Reports indicate that sometimes the krb5_cc_default() call must be failing because krb5_cc_principal is being called with a NULL ccache value. Perform error checking and cleanup that was not previously implemented. commit 77c1e986369c8151ec19e74dccbd2b40de6270d9 Author: Jeffrey Altman Date: Fri Mar 21 04:15:47 2008 +0000 windows-pioctl-disable-service-mgr-check-20080320 LICENSE MIT Adds HKLM\\Software\\OpenAFS\\Client DisableIoctlSMCheck For use in setting tokens when afsd_service.exe is started without use of the NT Service Manager. Permits profiling authenticated operations. commit edbde00d6c3be0228b1647505d8483632cceaf39 Author: Jeffrey Altman Date: Thu Mar 20 00:00:28 2008 +0000 windows-max-cells-20080319 LICENSE MIT Add CM_CONFIGDEFAULT_CELLS (1024) to cm_config.h and a "Cells" registry value that can be used to alter the limit at runtime. No longer tie the number of cells to the number of stat cache objects. 1024 should be more than sufficient. commit d24b177765f2955a7c54ecdc33744ecee069f25e Author: Jeffrey Altman Date: Wed Mar 19 20:17:04 2008 +0000 windows-volume-dotdotFid-20080319 LICENSE MIT The volume dotdotFid field should have moved into the cm_volstate_t object as there can be different parents for rw, ro, and bk volumes. commit b2667be49d31a26517f3c7a192091847434e6151 Author: Jeffrey Altman Date: Wed Mar 19 15:34:48 2008 +0000 windows-no-more-afsdifs-20080319 LICENSE MIT do not include a header that no longer exists commit e3f9fcdeaaf35363c0b3d3a8004892aa4ce9233f Author: Jeffrey Altman Date: Wed Mar 19 13:57:36 2008 +0000 windows-remove-umich-afsifs-20080319 LICENSE MIT The UMich AFS IFS code has never been made ready for production. An alternative approach is currently being worked on that will be. commit e6d7e165886122dc4cee850632ee2c1f55165258 Author: Jeffrey Altman Date: Wed Mar 19 13:22:02 2008 +0000 windows-parseacl-20080319 LICENSE MIT Protect against invalid data being passed into ParseAcl and corrupting the stack. This affects both fs.exe and the explorer shell extension. Windows Error Reporting in recent weeks has begun to report several instances of stack corruption in the explorer shell extension from Denmark and Germany. commit e7e2a3bd0691e3da78a36c8f3332577290f59a64 Author: Jeffrey Altman Date: Tue Mar 18 16:44:39 2008 +0000 windows-remove-umich-afsifs-20080318 LICENSE MIT The UMich AFS IFS code has never been made ready for production. An alternative approach is currently being worked on that will be. commit 6c81286368e17bdde543d4d6e5d19512cab62ba3 Author: Tom Keiser Date: Tue Mar 18 16:05:09 2008 +0000 dafs-kill-xcpu-dump-vlru-stats-20080318 LICENSE BSD this will dump the current dafs vlru state on kill -XCPU (just as we dump other fileserver state) that state is VLRU is a garbage collection facility which automatically offlines volumes in the background. The purpose of this facility is to proactively offline infrequently used volumes to improve shutdown and salvage times. The process of offlining a volume from the "attached" state to the "pre-attached" state is called soft detachment. VLRU works in a manner similar to a generational garbage collector. There are five queues on which volumes can reside: new, intermediate, old, held, and candidate: held: queue for volumes which are administratively barred from VLRU activity candidate: queue for volumes which have not been accessed recently, and are thus candidates for soft detachment new, intermediate, old: generational queues for active volumes; state transitions controlled by inactivity timers. State transition timeouts are as follows: candidate->new activity present new->candidate (1*vlruthresh) minutes since last transition; no activity new->mid (2*vlruthresh) minutes since last transition; activity present mid->old (4*vlruthresh) minutes since last transition; activity present old->mid (2*vlruthresh) minutes since last transition; no activity mid->new (1*vlruthresh) minutes since last transition; no activity commit db4c703131c4fe68e699d873525f1055845545f7 Author: Kevin McBride Date: Tue Mar 18 15:58:40 2008 +0000 pts-process-input-file-and-exit-20080318 LICENSE IPL10 The pts program has a command 'source' to read commands from a file. In the interactive "shell" mode, this command works, reading and executing commands until the end of the file and then returning to the command shell. This command is valid for use as a command line option, but does not work. It requires a valid filename as an argument, but does not process the file, instead just dropping the user into the interactive mode. When given as a command line option, pts source SHOULD read the file, execute the commands and then exit, according to the documentation. It does not currently do this and should be fixed. commit 7ffe6a97ff0453c2cae8b15a9d7e2084e3a864d4 Author: Chaskiel M Grundman Date: Mon Mar 17 18:07:36 2008 +0000 hpux1123-sysname-detection-20080317 LICENSE IPL10 FIXES 89125 add the 11.23 sysname commit 2c3cbd499ad4461511f2181e1ac0a0cfa6768821 Author: Chas Williams Date: Mon Mar 17 18:02:53 2008 +0000 afs-nostats-xstats-start-cmtime-noop-20080317 LICENSE IPL10 FIXES 90528 add missing noop so we can build with stats disabled commit eee60dd38d1be14be052178816aea36b2f8de3ff Author: Chas Williams Date: Mon Mar 17 17:56:38 2008 +0000 rx-nacks-increment-with-all-newacks-20080317 LICENSE IPL10 don't "lose" newacks, apply all of them to the ack count commit ec5a43b08686680b9d9c0552e3a912871dac4cc8 Author: Jeffrey Hutzelman Date: Mon Mar 17 17:48:35 2008 +0000 linux-nfstrans-readme-20080317 LICENSE IPL10 readme for linux nfs translator and extensions commit 449756f8a26f1b30147851f98ac67b2a2642abf8 Author: Derrick Brashear Date: Mon Mar 17 17:14:01 2008 +0000 volser-handle-malloc-failure-20080317 LICENSE IPL10 allocate memory for all rx OUT parameters in stubs to avoid crashes. commit 680123d70c98d7d9e5884e3d43ed5298d6aad11d Author: Mattias Pantzare Date: Mon Mar 17 16:51:55 2008 +0000 solaris11-update-20080317 LICENSE IPL10 update solaris 11. probably we should do configure tests instead for these things, since they're sort of "moving target" commit f776cb96f97e5995a3a58074f2bf913e8ea4be00 Author: Steven Jenkins Date: Mon Mar 17 16:39:03 2008 +0000 dafs-readme-20080317 LICENSE IPL10 update README to mention DAFS setup and build options commit c7bce5882a685fcc6ecac53fb54ec7047f21ec6c Author: Tom Keiser Date: Mon Mar 17 17:06:30 2008 +0000 dafs-accurately-track-inuse-20080317 LICENSE IPL10 keep accurate tabs on whether a volume is "in use" so we don't end up with volume state that's nonsensical. ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== LICENSE IPL10 keep accurate tabs on whether a volume is "in use" so we don't end up with volum e state that's nonsensical. ==================== LICENSE IPL10 keep accurate tabs on whether a volume is "in use" so we don't end up with volum e state that's nonsensical. commit 3a84b02172800e7c172e04718fb109d1f5f1c014 Author: Derrick Brashear Date: Mon Mar 17 15:38:15 2008 +0000 rx-clock-backward-detection-20080317 LICENSE IPL10 if the clock goes backwards, detect it and reset any rx events to run in a timely manner commit 8cad4305acb787500f9434949cfb3c6500f3287b Author: Steven Jenkins Date: Fri Mar 14 18:05:00 2008 +0000 demand-attach-docs-20080314 LICENSE IPL10 Additional documentation for the demand attach file server, plus a state diagram. commit 6fef8b74299e4ed75a1da45d7fdb948581ab2434 Author: Jeffrey Altman Date: Fri Mar 14 16:53:37 2008 +0000 windows-callback-20080314 LICENSE MIT Protect against a null volp commit 3a0fa5627bd5254f37aa5c2fb04ca7d27f0a06c1 Author: Jeffrey Altman Date: Fri Mar 14 16:16:14 2008 +0000 windows-max-volumes-20080314 LICENSE MIT Propagate the max volumes value into cm_memmap commit 53a57b79b567aed990eb27d0b4a24109a65a993e Author: Tom Keiser Date: Fri Mar 14 04:41:20 2008 +0000 vol-dafs-aix-fixes-20080313 LICENSE IPL10 FIXES 88087 * xlc doesn't support the inline keyword unless C99 is enabled * xlc won't parse enumerations with trailing commas commit 2d29c51167b50286e94bda35275e62cfc3c04dfd Author: Simon Wilkinson Date: Thu Mar 13 13:42:06 2008 +0000 lwp-fixprotos-20080313 LICENSE IPL10 FIXES 89857 make everything match, and make *ep take void and not a pointer commit e1fb328b9ae509316ce8fff81691f6b738929ee9 Author: Jeffrey Altman Date: Thu Mar 13 12:56:31 2008 +0000 rx-mutex-interlocked-macros-20080312 LICENSE IPL10 fix from sxw@inf.ed.ac.uk commit f9cc51fb40f1797b72ba5b05d7d0249b9a3b2e27 Author: Jeffrey Altman Date: Thu Mar 13 04:37:44 2008 +0000 windows-remove-scache-volp-20080312 LICENSE MIT The cm_scache structure has included a reference to the associated cm_volume_t, volp. By doing so the reference count on the cm_volume_t objects never hits zero unless all of the cm_scache_t objects in that volume have been reused. This prevents cm_volume object recycling. This commit removes the hard reference and instead adds a function cm_GetVolumeByFID which obtains a reference to the cm_volume that matches the cm_scache fid value as needed. A new "Volumes" registry value is added to permit explicit specification of the number of volume objects to be allocated. commit 5378bf47efdb9abb056a0111cf38b9b6c73c7bc8 Author: Marc Dionne Date: Thu Mar 13 02:23:57 2008 +0000 linux-2625-20080312 LICENSE IPL10 add missing bits commit f69a15c7a8e286ead1d7a3e444214a1553fa01e5 Author: Jeffrey Altman Date: Wed Mar 12 05:46:01 2008 +0000 windows-client-config-pt-20080311 LICENSE MIT typo in pt_BR language resource file commit 9cc4a8e02cd6b244c34f04ba9526183edd358bf7 Author: Jeffrey Altman Date: Wed Mar 12 05:12:54 2008 +0000 rx-no-interlockedadd-20080311 LICENSE IPL10 InterlockedAdd is only supported on Itanium commit 0e91773fd769f2c5ce69eef1e795993f963ab3ee Author: Steven Jenkins Date: Wed Mar 12 01:28:00 2008 +0000 man-page-fileserver-update-20080311 LICENSE IPL10 Update the fileserver documentation for demand-attach and add documentation of other missing options and notes where some options are only applicable with particular builds. commit c86ae86a53c8a8e5acc099e1ea437e3571b2e63d Author: Jeffrey Altman Date: Tue Mar 11 18:23:23 2008 +0000 rx-mutex-interlocked-macros-20080311 LICENSE IPL10 Introduce a new set of macros that can be used to permit either mutex based protection or Interlocked operation protection increments, decrements, or additions. rx_MutexIncrement(object, mutex) rx_MutexAdd(object, addend, mutex) rx_MutexDecrement(object, mutex) rx_MutexAdd1Increment2(object1, addend, object2, mutex) rx_MutexAdd1Decrement2(object1, addend, object2, mutex) For Windows these are implemented with the Interlocked operations for other platforms the existing mutex is relied upon. Only a subset of the rx_stats parameters have been transitioned at the current time. commit ff988ead4ee3986c1db9f983e4f25ba79469a4e4 Author: Simon Wilkinson Date: Tue Mar 11 17:46:58 2008 +0000 lwp-protoize-20080310 LICENSE IPL10 protoize lwp. make it match pthreads' idea of createprocess commit 9473128eb375b3ec31560613842220b934e07de6 Author: Jeffrey Altman Date: Tue Mar 11 17:00:18 2008 +0000 windows-lwp-proto-20080311 LICENSE IPL10 Fix breakage caused by recent lwp prototyping. commit cadbebc2e50aedea01475620a3add4c315c13faa Author: Derrick Brashear Date: Mon Mar 10 18:50:47 2008 +0000 linux-2625-20080310 LICENSE IPL10 adapted from marc dionne's patch, but works more directly like the darwin port, further, i'm guessing iget_locked will go away evewntually. maybe this is too conservative? commit 2cee2d88a8573f1b8eb336993d9acf6417cda4e2 Author: Jeffrey Altman Date: Mon Mar 10 18:16:29 2008 +0000 windows-client-config-misc-dlg-20080310 LICENSE MIT The Daemon and Server Threads fields were swapped. commit b7fb842b1cd11ceaa492201ad9a38052e424f6a8 Author: Simon Wilkinson Date: Mon Mar 10 16:44:16 2008 +0000 keyring-updated-20080310 LICENSE IPL10 revise keyring patch to avoid detection problems with keyring_type_key commit 9959232682d05f410dc0fae91f790b2ebed3273a Author: Derrick Brashear Date: Mon Mar 10 16:22:12 2008 +0000 hpux-param-updates-20080310 LICENSE IPL10 based on suggestion from cg2v@andrew.cmu.edu commit 5f6546ecbbe946f2275e07d87351968105c176a1 Author: Jeffrey Altman Date: Sun Mar 9 15:21:39 2008 +0000 windows-afs-execute-only-20080309 LICENSE MIT If we want to enforce the open for read flag in smb_ReadData we must also check for execute access. We map execute access to read access because AFS doesn't have a separate permission for that. commit 6e18cd4108e6367fe9766d5f2cfda48569c9ebbf Author: Jason Edgecombe Date: Sun Mar 9 05:57:29 2008 +0000 man-page-afsd-afsdb-20080308 LICENSE BSD FIXES 89288 89289 Reference RFC 1183 in the AFSDB documentation. commit 84a928ddd46b1b77c655b21ce7e9fc8d775b96db Author: Simon Wilkinson Date: Sun Mar 9 01:40:14 2008 +0000 pt-util-com-err-20080308 LICENSE IPL10 prototype afs_error_message() to ensure correct behavior on 64-bit systems with 32-bit int. commit cdd1e8b878c669927b7e2b8f06cd20b62f6bec51 Author: Jeffrey Altman Date: Sat Mar 8 23:38:08 2008 +0000 windows-installer-rxmaxmtu-setting-20080308 LICENSE MIT change the RxMaxMtu setting to 0 to restore default behavior (aka performance). The Cisco VPN 5.0.01.0600 client no longer requires a reduced mtu size for compatibility with AFS. commit f94e0d5688be0778d346711b6698e2ef567e1969 Author: Jeffrey Altman Date: Sat Mar 8 23:31:52 2008 +0000 windows-config-20080308 LICENSE MIT raise the daemon count to 4 now that we have a means of avoiding contention raise the tracebufsize to 10000 entries commit 801b670734e254665576dcb71756ea64a123abc9 Author: Jeffrey Altman Date: Sat Mar 8 23:23:48 2008 +0000 windows-syscfg-getifinfo-20080308 LICENSE MIT syscfg_GetIFInfo() obtains the current list of IP addresses. Its a really expensive operation. Call the function once and cache the data until the next IP address change instead of calling it everytime we receive a WhoAreYou or construct a new server object. Adds a new global rw lock, cm_syscfgLock commit 27008912ec2a0526e71f174b9e4e6d8dd1fc8f19 Author: Jeffrey Altman Date: Sat Mar 8 23:17:45 2008 +0000 windows-scache-20080308 LICENSE MIT do not discard data buffers we wish to keep commit c32f5466f0cf7150d8bbe286fa51834108dce63f Author: Jeffrey Altman Date: Sat Mar 8 23:15:54 2008 +0000 windows-performance-deadlock-20080308 LICENSE MIT correct a deadlock when calling HaveCallback commit 694202f29e5eafbcf0a07908ebdc2c67a2eecc3b Author: Jeffrey Altman Date: Sat Mar 8 15:43:45 2008 +0000 windows-cm-callback-remove-call-mutex-hold-20080308 LICENSE MIT Remove all of the code in #ifdef HOLD_CALL_MUTEX as we no longer use it. commit 526babc882364573be745b717c32fa1da29acaa2 Author: Jeffrey Altman Date: Sat Mar 8 14:15:43 2008 +0000 windows-eventlog-20080308 LICENSE MIT we need set privilege not query privilege commit fdcf6bba5546f2a09e972323be9469a49ce04c6f Author: Jeffrey Altman Date: Fri Mar 7 22:22:21 2008 +0000 windows-cm-performance-tuning-200803007 LICENSE MIT This is a first cut at a cache manager statistics monitor that can be used to determine the necessary cache parameters to support the working set. Off by default the performance package can be activated by setting "daemonPerformanceTuningInterval" in the service Parameters key. As with the other daemon interval values the unit is in seconds. At service start and each succeeding interval the cache manager will write statistics to %TEMP%\afsd_performance.txt showing the relative usage of cm_scache_t, cm_volume_t and cm_buf_t objects. The FID statistics keep track of all FIDs seen by the cache manager during the service session whether or not they are backed by any live object in the cache. These statistics are not stored in the cache file. commit 1f4ca0f488d765d5d09de9edf8a8fc4fbe6b09b1 Author: Jeffrey Altman Date: Fri Mar 7 22:14:41 2008 +0000 windows-cm-conn-20080307 LICENSE MIT Convert cm_conn_t reference counts to use Interlocked operations. This permits several cm_serverLock holds to be converted to read locks. Add string translation for VL errors to cm_Analyze(). Permit RXKAD errors other than RXKADEXPIRED to be treated as non-fatal. Instead immediately retry an alternate server if there is one. This will permit the client to continue to access replicated data from an alternate site if one of the file servers is misconfigured. commit 0479c650c17f35a4cf0de523cfc036b8d21629ce Author: Jeffrey Altman Date: Fri Mar 7 22:07:40 2008 +0000 windows-cm-server-interlocked-20080307 LICENSE MIT Convert cm_server_t reference counts to use Interlocked operations. This permits almost all of the cm_serverLock holds to be converted to read locks. Add missing cm_PutServerNoLock() calls in the multi_Rx version of cm_CheckServers(). (Thanks to Asanka) commit 757ee6da75123653dd094a6e1fdd374edf0c55f1 Author: Jeffrey Altman Date: Fri Mar 7 22:02:22 2008 +0000 windows-vl-noent-response-20080308 LICENSE MIT Prior to looking up a volume in the vldb the cm_volume_t object is constructed. If the response is VL_NOENT the cm_volume_t object should be removed and place at the head of the recycling list so that we do not recycle something we might actually care about. Convert more cm_volumeLock holds to read locks now that we are using Interlocked operations to manipulate the reference counts. commit 45200a26985678ccad051385f50f94321eb98256 Author: Jeffrey Altman Date: Fri Mar 7 17:44:40 2008 +0000 windows-scache-verification-20080307 LICENSE MIT Add a hash value verification check for stat cache entries commit 73c2fa385a6f61483189dc68c4a10a49d65c8bf5 Author: Jeffrey Altman Date: Fri Mar 7 17:37:35 2008 +0000 windows-rxstats-default-20080307 LICENSE MIT set the defaults for RxEnablePeerStats and RxEnableProcessStats back to 1 (on) so admins are not surprised. commit f637b6292d3723cd2cf672ecaba6f179813ab64b Author: Simon Wilkinson Date: Fri Mar 7 17:30:19 2008 +0000 fakestat-access-for-nautilus-20080307 LICENSE IPL10 in order that nautilus' .directory checks can work without stat()ing every damn thing, do what we do for the mac, basically. commit 5589875561e0062b2f06fc4ce0a8fad37a0d8eb5 Author: Jeffrey Altman Date: Fri Mar 7 15:35:38 2008 +0000 windows-smb-writedata-crash-20080307 LICENSE MIT FIXES 88731 If an application opens a file for read only and then attempts to write to it, we would attempt to release an scp mutex without having obtained either the scp or the mutex within smb_WriteData There was no check in smb_ReadData to ensure that the file was opened for reading. Add one. commit fb154e60e3cb6cf9e934f9a75c5ca67473ac36a2 Author: Jeffrey Altman Date: Fri Mar 7 01:03:45 2008 +0000 windows-interlocked-volume-refcount-20080306 LICENSE MIT Switch cm_volume_t objects to InterlockedIncrement/InterlockedDecrement for reference counting. Remove protections against null pointers being passed into cm_GetVolume() Instead, do not call cm_GetVolume() if the pointer is NULL. Fix a buffer data version comparison that should be bad version number instead of <= 0. commit 2137631fb44d934d51979850ebfcb6a50076b095 Author: Derrick Brashear Date: Thu Mar 6 16:54:33 2008 +0000 dafs-restarting-error-change-20080306 LICENSE IPL10 on VSALVAGE the client will correctly resort its list and fail over to other replicas, but only for RO where there is more than one replica, obviously; since in dafs we expect to only delay on salvage this is the most useful course of action commit f58e08baae0a5ee9be516e9e220a12b78e5bf414 Author: Derrick Brashear Date: Thu Mar 6 16:41:14 2008 +0000 pioctl-settoken-malloc-fail-check-20080206 LICENSE IPL10 avoid malloc failure panic (oops) commit 6a631075c478794e998ad67d90e33d304521fbd3 Author: Jeffrey Altman Date: Thu Mar 6 14:33:09 2008 +0000 windows-afsd-misc-20080306 LICENSE MIT (1) an attempt to make better use of bandwidth from the BkgDaemon threads by preventing the thread from blocking on a vnode that is already storing data in another thread (2) prevents CM_SCACHEFLAG_ASYNCSTORE from being reset on a write failure. (3) fixes cm_EvaluateSysName to avoid accessing uninitialized memory (4) prevents a lock leak if the symlink's mountpointstring is too long. (This could never actually happen but better to correct the code.) commit b651ece9bdb2ea9dc19907a5686e9d084f3c03d6 Author: Derrick Brashear Date: Wed Mar 5 21:51:19 2008 +0000 large-partition-support-20080305 LICENSE IPL10 FIXES 88811 support partitions over 2tb commit 69f9b46e69bb7c8c9356b062a8f4908fe38ad14b Author: Jeffrey Altman Date: Mon Mar 3 04:24:17 2008 +0000 windows-scache-mx-to-rw-20080302 LICENSE MIT Replace the cm_scache_t mutex with a rwlock permitting a small amount of additional parallelization in places where it is safe to use read locks instead of write locks. All functions that eventually call cm_SyncOp must use write locks. commit ba94313f4030184890194c84f8d5c2f3f69f52d1 Author: Jeffrey Altman Date: Sun Mar 2 21:53:42 2008 +0000 windows-cm_buf-20080302 LICENSE MIT remove unused constants, data structures and fields commit af2318cfde026f5dc6b479089689dba63f7b8abc Author: Jeffrey Altman Date: Sat Mar 1 18:58:54 2008 +0000 windows-asyncstore-again-20080301 LICENSE MIT must write the entire asyncstoresize otherwise dirty buffers are left for writing by buf_IncrSync thread. commit b47407ae72491a129fc9ed6990585e426fc2a223 Author: Jeffrey Altman Date: Sat Mar 1 18:56:23 2008 +0000 windows-buf-more-clean-vnode-speedups-20080301 LICENSE MIT do not call buf_CleanAsync if you know the buffer isn't dirty commit 7083ceec5c21e500f23110152dcc994c7ccfab92 Author: Jeffrey Altman Date: Sat Mar 1 17:43:16 2008 +0000 windows-freelance-20080301 LICENSE MIT when support for multiple valid buffer data versions was added forget to remove the force dv change from the freelance code. this broken automatic additions of new mount points. commit fb3f10f3297c08807c0a3f0b345d88cd19742726 Author: Jeffrey Altman Date: Sat Mar 1 16:28:53 2008 +0000 windows-buf-mx-20080301 LICENSE MIT further reductions in buffer mutex acquisition churn commit 3b5a1acef030ad9208111511813a0b69c6a0de99 Author: Jeffrey Altman Date: Sat Mar 1 15:59:07 2008 +0000 windows-eventlog2-20080301 LICENSE MIT set the registry values on each start. otherwise, we will never update the incorrect entries left over from previous installs. commit e4df679d1bcc6fb7e3c3eb4169e489c172910628 Author: Jeffrey Altman Date: Sat Mar 1 15:37:09 2008 +0000 windows-eventlog-20080301 LICENSE MIT somewhere along the way Microsoft stopped opening Event Message files explicitly. Instead they search the PATH environment variable for the specified file. I think this is broken but simply registering "afsd_service.exe" instead of the fully qualified path works. commit b8cacec96969b044c1cfdd1919ca9e2e36999243 Author: Jeffrey Altman Date: Sat Mar 1 04:29:17 2008 +0000 windows-smb-asyncstore-20080229 LICENSE MIT fix it commit 114de458ca7717cf0bcda90df61f24495fe8f922 Author: Jeffrey Altman Date: Fri Feb 29 22:50:54 2008 +0000 windows-cm-buf-misc-20080229 LICENSE MIT (1) Add an undocumented store behind mode for use in testing. Set EnableSMBAsyncStore to 2. When set all smb_WriteData calls are background writes, all calls to cm_FSync are skipped and file close operations do not block for dirty buffers to be written. This permits all writes to be performed in the buf_IncrSyncer thread. (2) Do not use I64 in osi_Log() format strings as all parameters are converted to size_t which is 32-bit on 32-bit Windows. (3) Reduce the number of times the cm_buf_t mutex is obtained, dropped, obtained, dropped in buf_IncrSyncer (4) In buf_CleanAsyncLocked, request that a full chunk be written instead of just the current buffer. cm_SetupStoreBIOD will stop at the first clean buffer. This reduces the overall number of RPCs that must be performed. (5) Define CM_BUF_VERSION_BAD and use it instead of -1. commit fccf05a96d038a1a911a95d309ecb08090d2c6a1 Author: Jeffrey Altman Date: Fri Feb 29 15:45:21 2008 +0000 windows-dnlc-20080229 LICENSE MIT even if dnlc is not going to be used, the data structures must still be initialized as they are in the cache file. commit 737c03a75c62b3cd0ec92b33aea84d33dc39c2e7 Author: Simon Wilkinson Date: Fri Feb 29 15:07:08 2008 +0000 configure-enable-warnings-20080228 LICENSE IPL10 add a switch to turn on warnings when using gcc commit 8ffc274282fa40c6e2d35ba861b9dc932afa032d Author: Kevin McBride Date: Fri Feb 29 04:41:50 2008 +0000 checkauth-unlock-before-return-20080228 LICENSE IPL10 only matters once you have pthreads, but... commit 502aca9e8ccff36d0c10203c66200e526d2273b3 Author: Jeffrey Altman Date: Fri Feb 29 01:26:45 2008 +0000 windows-libadmin-closesocket-20080228 LICENSE MIT On Windows close() does not apply to sockets, use closesocket() instead. commit 0546641c0da59289d03a9417984fe5f7e5636a75 Author: Jeffrey Altman Date: Thu Feb 28 18:21:53 2008 +0000 windows-buf-deadlock-20080228 LICENSE MIT avoid deadlock in buf_FlushCleanPages(). cannot obtain buffer mutex after a successful Stabilize call because the scp will be be locked and obtaining buffer mutex after scache mutex is a lock order violation. commit e9f7894e3576ef9e01234966f7869440f1823718 Author: Jeffrey Altman Date: Thu Feb 28 17:16:28 2008 +0000 windows-smb-lock-timeouts-20080228 LICENSE MIT Attempts to open files which are already write-locked by another client took forever to return a lock not granted error. This was because cm_Analyze() would retry the lock request for up to the RDRtimeout in response to the EAGAIN error. The problem was that cm_IntSetLock() was not setting the CM_REQ_NORETRY flag. While examining this issue, discovered two other things: (1) the infinite wait logic on lock request processing was broken (2) the cancel outstanding lock request logic wasn't implemented (3) cm_Analyze() would put the thread to sleep even when retries were not permitted. Also removed a number of compile time warnings. commit 023d3f3bae273d7af16d52fd0c468fc05653abe5 Author: Derrick Brashear Date: Wed Feb 27 22:26:31 2008 +0000 arm-lwp-adm-20080227 LICENSE IPL10 don't use ucontext lwp on arm linux commit 72687c02b6ee5ff3029937b0278733b252f14550 Author: Jeffrey Altman Date: Wed Feb 27 17:03:30 2008 +0000 windows-osi-convertRToW-and-logging-optimizations-20080227 LICENSE MIT Add lock_convertRToW which permits a read-lock to be upgraded to a write lock. If the caller is the only reader it permits a fast transition otherwise it adds the caller to the waiters queue. In the osi_Log macros, check to see if the log is enabled before making the function call. This avoids significant function call overhead. In the cache manager, make use of the above. commit 107899cefaeebe693f8025e9c0d88784facd2236 Author: Jeffrey Altman Date: Wed Feb 27 04:53:45 2008 +0000 windows-dnlc-20080226 LICENSE MIT Remove race conditions in the statistics code by switching to Interlocked functions. Speed up cm_dnlcEnter() by searching first with a read lock and then switching to a write lock if not found. Add HKLM\SOFTWARE\OpenAFS\Client registry values "UseDNLC" and "Debug"DNLC". I suspect with the B+tree code that the DNLC is unnecessary overhead but leave it on by default for now. commit 428cac5d6dfc287452af51c08eba0f0fca276864 Author: Jeffrey Altman Date: Tue Feb 26 04:13:16 2008 +0000 viced-cleanup-old-addresses-as-they-become-invalid-20080225 LICENSE IPL10 otherwise we can end up with stale addresses when a client uses then leaves an address never to return commit dd72e06bf11fccd70cba32c4b6411a5e6ff3914c Author: Jeffrey Altman Date: Mon Feb 25 22:19:49 2008 +0000 windows-force-anon-vldb-20080225 LICENSE MIT For organizations with krb5 aware file servers but transarc or old openafs vldb servers, add force anonymous vldb lookup option HKLM\SYSTEM\CurrentControlSet\Services\TransarcAFSDaemon\Parameters DWORD "ForceAnonVLDB" (default is 0) commit f4f7ac048c52f859000a0d42640f0a6d43cc942a Author: Jeffrey Hutzelman Date: Mon Feb 25 20:38:09 2008 +0000 threadquota-enforcement-fixes-20080225 LICENSE IPL10 FIXES 87416 correctly set and unset HWHO_INPROGRESS as we pass through host probing package. also, do not block on lock checking for HOSTDELETED. instead, return a null host and VBUSY; restructure code to allow returning a null host with prejudice. commit d8c932ed73039777f5e21e70d6850325061f8241 Author: Jeffrey Altman Date: Mon Feb 25 19:34:44 2008 +0000 windows-volume-logsavestring-20080225 LICENSE MIT remember to save the volume name when logging commit 704fddccd0f714c848b37ccee427f8eeded53bd6 Author: Jeffrey Altman Date: Mon Feb 25 15:31:21 2008 +0000 windows-smb-asyncstoresize-20080225 LICENSE MIT Further testing on the 115KB AT&T Edge connection shows that 128KB provides reasonably robust performance with six simultaneous copies of multi-MB files to AFS. commit f95915a55ae579bab4052f24f6fedca21d114567 Author: Jeffrey Altman Date: Mon Feb 25 05:33:54 2008 +0000 windows-smb-async-store-20080224 LICENSE MIT Add two new configuration knobs to control the behavior of smb_WriteData. HKLM\SOFTWARE\OpenAFS\Client DWORD EnableSMBAsyncStore (default: 1) DWORD SMBAsyncStoreSize (default: 32K) Instead of tying the async store size to either the chunksize (too large) or the buffer block size (too small) provide an intermediate value that can be independently controlled. In the future it would be desireable for the async store size to be dynamically determined based upon measurable characteristics of the network. In the meantime, 32KB is an acceptable performance compromise that should work well on 1Gbit networks and low-speed cellular networks. commit 27dc7b13aa6356ba76916e47c6ddb48aa4b99846 Author: Derrick Brashear Date: Mon Feb 25 04:57:47 2008 +0000 nulluuid-check-only-valid-input-20080224 LICENSE IPL10 as reported by jhutz@cmu.edu commit f52c6e1bc020a0985d2bc168d06b2c87fe7a2797 Author: Jeffrey Altman Date: Sun Feb 24 15:33:52 2008 +0000 windows-scache-clean-bufs-20080224 LICENSE MIT In MergeStatus, only remove clean buffers from the hash table. commit 9e41258fad54e3122a0722b3f1c24810590c8d0a Author: Jeffrey Altman Date: Sun Feb 24 06:31:54 2008 +0000 windows-buf-data-versions-20080224 LICENSE MIT An implementation of Asanka's idea. Avoid the need to update the data version number on each buffer associated with a scache when MergeStatus is called after a StoreData by maintaining a range of valid data versions as part of the cm_scache_t object. commit 812ac61cfd3601abb1373f6d3f9e4d52c2ff61b9 Author: Jeffrey Altman Date: Sun Feb 24 06:27:38 2008 +0000 windows-optimize-access-20080224 LICENSE MIT profiling shows large numbers of blocked calls in cm_HoldSCache from cm_HaveAccess... We can safely avoid the call so do so. commit c73b73ee33c37aee2c52051005a12ad36fde70d4 Author: Asanka Herath Date: Sat Feb 23 21:35:56 2008 +0000 windows-checkntopen-20080223 LICENSE MIT do not forget to call cm_SyncOpDone if cm_SyncOp succeeded commit 8bddb4892bb815076861507f8ae781ae2c3f3310 Author: Jeffrey Altman Date: Sat Feb 23 21:12:54 2008 +0000 windows-buf-createlock-20080223 LICENSE MIT Do not leak a read lock on the bufCreateLock Add logging to cm_CheckNTOpen[Done] commit 12c6cfd4435c5a491e613e6394fabeeed4d81447 Author: Jeffrey Altman Date: Sat Feb 23 07:27:17 2008 +0000 windows-buf-scache-interlock-20080222 LICENSE MIT Improve parallelism by using InterlockedIncrement and InterlockedDecrement to adjust the refCount fields of cm_buf_t and cm_scache_t objects. This permits read locks to be used for increments and decrements but requires a write-lock to perform any actions based upon the refCount hitting zero. Inline cm_FidCmp to further improve performance. Remove unused variables. commit dcef8fa4adc4c2cdc166494979d77d91c40c1f06 Author: Jeffrey Altman Date: Sat Feb 23 00:15:22 2008 +0000 windows-afsd-20080222 LICENSE MIT 1. Change RxEnableHotThread default to 'on' 2. Add a 'hash' value to the cm_fid_t structure in order to speed up cm_FidCmp(). Add cm_SetFid() for use in constructing a fid complete with the hash. 3. Redefine the BUF_HASH and BUF_FILEHASH in terms of the cm_fid_t hash which has a better distribution 4. Modify cm_ConsiderPrefetch to evaluate the amount of data in the most recent read request instead of the next chunkSize. cm_chunkSize can be dozens or hundreds of buffers. As a result too much time is spent performing the evaluation. 5. Fix the usage of cm_scache_t bufCreateLock. The purpose of this lock is to prevent the creation of new buffers while a truncation is being performed. All references to bufCreateLock have been removed except in two places: i. a write-lock surrounding the function that calls buf_Truncate() ii. a read-lock within buf_GetNewLocked() that actually allocates new buffers 6. Modify the CM_CONFIG_DATA_MAGIC value to include a CM_CONFIG_DATA_VERSION number which value be used to force the replacement of the cache file contents when incompatible changes are made between releases. 7. CM_SCACHESYNC_ASYNCSTORE should not be ordered by cm_SyncOpCheckContinue 8. Avoid calls to multi_Rx if nconns == 0 9. Modify smb_WriteData to perform background writes based upon the crossing of buf_blockSize boundaries instead of cm_chunkSize boundaries. This will slow down writes from the SMB interface but will avoid the risk of the CIFS client disconnecting from the AFS client SMB server. commit cd9ce022ee97bee809e840be8612aafb2cbfc6b8 Author: Derrick Brashear Date: Wed Feb 20 21:31:02 2008 +0000 debian-packaging-update-20080220 LICENSE IPL10 Russ' metadata, repacked into our tree commit 49d77d8d4b8c26a56143a3655d460a6495f7d57a Author: Derrick Brashear Date: Wed Feb 20 20:18:03 2008 +0000 vos-addsite-pod-error-20080220 LICENSE IPL10 Item is not item commit d5c32c97a01f02cd69e2167964b43d83c6d413fb Author: Derrick Brashear Date: Wed Feb 20 20:07:51 2008 +0000 urecovery-invalidate-without-truncate-20080220 LICENSE IPL10 critical to label the database invalid when we don't truncate so recovery finishes. issue in 84609 remains. commit d48e3d1e7a5a5d065a0046b9115043bed47510a7 Author: Jeffrey Altman Date: Wed Feb 20 17:35:45 2008 +0000 windows-smb-locking-20080220 LICENSE MIT minor improvements to smb_rctLock usage. commit dd4ecb4ca0467d9f5727de1bfe9082f195330b99 Author: Jeffrey Altman Date: Wed Feb 20 17:32:53 2008 +0000 windows-rx_enable_hot_thread-20080220 LICENSE MIT Add RxEnableHotThread registry option to permit rx_enable_hot_thread to be set. The default is off for the moment but turning it on does provide significant performance benefits. commit 5067e6786dc93b8760edf6b1b9d92c3999caea7e Author: Jeffrey Altman Date: Wed Feb 20 17:17:21 2008 +0000 rx-osi_socket-20080220 LICENSE MIT The portable type to be used for sockets is osi_socket not int. On 64-bit Windows this caused failures when hot threads were enabled. commit 897c36027476843db988b9d0625a8fc189c8716d Author: Jason Edgecombe Date: Tue Feb 19 15:25:17 2008 +0000 man-page-updates-20080219 LICENSE IPL10 FIXES 86677 note 2tb limit, add fs minidump document commit 4bd64596caebf79962db441782082d07c2de9e4e Author: Mike Meffie Date: Tue Feb 19 15:07:24 2008 +0000 s390x-not-s390-20080219 LICENSE IPL10 don't try to link multiple things to asm commit 19b829d21934d60ab0b1af3ef0c7eefb2cce17b6 Author: Rainer Toebbicke Date: Tue Feb 19 14:29:42 2008 +0000 viced-rmdir-fid-leak-20080219 LICENSE IPL10 FIXES 86786 commit c2de3a1623441f93b119dbdbd772bfa81973b230 Author: Derrick Brashear Date: Tue Feb 19 04:10:44 2008 +0000 windows-name-entries-20080218 LICENSE IPL10 restore the original behavior. Fixes smb_ReceiveTran2SearchDir(). commit 1e4c03deecee1671703af891dbaf11e11b0dd5c8 Author: Derrick Brashear Date: Tue Feb 19 03:39:06 2008 +0000 arm-linux26-syscall-missing-20080218 LICENSE IPL10 there's nothing non-political about this. whatever. commit 7421feda944d5fa05f5223528a69f23a7bb0b724 Author: Derrick Brashear Date: Mon Feb 18 19:19:12 2008 +0000 viced-qsort-cba-before-multibreakcallback-to-avoid-lockup-20080218 LICENSE IPL10 my code, though, this is a result of a problem reported by Chaskiel Grundman and analysis by him, Jeff Altman and myself. I'm just checking in my implementation. In any case, the issue this addresses is one where we can end up in makecall_waiting in rx on multiple connections when we multibreakcallback because the lists are sorted differently and each has "pending" calls on a different connection. by sorting by index we will not block on another caller while also holding what they're after commit 7a290f39ec303cb3473f63f7d9c634e767191279 Author: Jeffrey Altman Date: Mon Feb 18 17:33:45 2008 +0000 windows-do-not-discard-badtickets-20080218 LICENSE MIT The RXKADBADTICKET error is returned when a krb5 derived token is sent to a server that does not support them. In a mixed cell it is possible that some servers were not updated. Discarding the token does not make it possible to perform the request successfully and adversely affects the user experience because those servers that do support the token can no longer be accessed in an authenticated manner. Users can't determine what the cause is, all they see are their tokens disappearing and there is nothing they can do about it anyway. From now on return STATUS_NO_KERB_KEY and do not retry. commit 5fd85f53f26ba1f0649b8a8c68d3abb1c5159eb9 Author: Jeffrey Altman Date: Mon Feb 18 17:27:48 2008 +0000 rx-stats-optimization-20080218 LICENSE IPL10 Do not grab the peer mutex or the rpc stats mutex if we are not intending to collect stats. Doing so is a bottleneck. commit f5645ccffe05f2c1b44d5ba1adb32ba45e26aae8 Author: Jeffrey Altman Date: Mon Feb 18 14:13:59 2008 +0000 windows-afskfw-20080218 LICENSE MIT if we are going to insert the full ccache name then we must search by it as well. commit 72da5c434c8caef0cb81523091915738e7e930ed Author: Jeffrey Altman Date: Mon Feb 18 05:52:34 2008 +0000 windows-share-parse-20080217 LICENSE MIT add srvsvc and wkssvc to reserved names in smb_ShareParse. include slash in ipc$ reference in dfs referrals check. commit 55aa6f04dcfebae134b3459944e005599d06ef05 Author: Asanka Herath Date: Sun Feb 17 14:33:26 2008 +0000 windows-netidmgr-extension-sample-20080217 LICENSE MIT A sample template for constructing Network Identity Manager OpenAFS Provider Extensions for obtaining and identifying new token types. commit 38c2524bd16f1e535ea28f9d0788b7eaa8d26c3d Author: Jeffrey Altman Date: Sun Feb 17 05:58:13 2008 +0000 windows-invalidate-file-locks-vnovnode-20080217 LICENSE MIT Upon receiving a VNOVNODE error from a file server, be sure to invalidate any file locks. This prevents on-going attempts to extend the locks and will cause subsequent attempts to access the file to receive a invalid handle error. commit 33bed6296114e16914cecf312c762774d44386c8 Author: Jeffrey Altman Date: Sun Feb 17 05:26:51 2008 +0000 windows-buf-consistency-20080217 LICENSE MIT All calls to buf_Get() must be protected by a read lock on the cm_scache_t bufCreateLock When a MergeStatus results in the invalidation of buffers, do not remove buffers from the hash tables that have active references. commit 935c49a2a6efa476c327e8a24fc4895f0c8f623d Author: Jeffrey Altman Date: Fri Feb 15 03:31:04 2008 +0000 windows-check-offline-volumes-20080214 LICENSE MIT when checking offline volumes, update the cell vlserver info if required and don't perform a check if there are no servers in the list. commit 4aad2a7b6bcf97af384de36994af94b7b4b07f98 Author: Jeffrey Altman Date: Fri Feb 15 03:24:52 2008 +0000 windows-afsd-rx-extrapackets-20080214 LICENSE MIT Add support for specifying rx_extraPackets in the Windows client commit 9babb9f88f0e101d06f6b447a4b5ad4316fa2d07 Author: Simon Wilkinson Date: Thu Feb 14 19:26:39 2008 +0000 mockbuild-20080214 LICENSE BSD driver script for mock massbuilds commit 093433b981cd1917215a4ee6196c5a0a55352d92 Author: Jeffrey Altman Date: Fri Feb 15 03:23:44 2008 +0000 windows-volstat-vl-unknown-20080214 LICENSE MIT Add volumes in the vl_unknown state to the list of objects to be checked as offline or retried when an allbusy error is received in cm_Analyze. commit 1133cc441862f3f0d44f0ab380a7274ead672b0f Author: Jeffrey Altman Date: Thu Feb 14 19:19:38 2008 +0000 windows-vnovol-20080214 LICENSE MIT avoid a crash when logging VNOVOL errors returned from cm_CheckOfflineVolume commit 00bada9c5eb803c13a6b930e79684a470cf94278 Author: Jeffrey Altman Date: Fri Feb 15 03:18:42 2008 +0000 windows-osilog-savestring-20080214 LICENSE MIT When osi_Log is disabled, osi_LogSaveString will no longer copy the provided string into the circular log buffer. This saves a huge amount of time. commit 588a229110c92bd82b819916260ee9727759c4a0 Author: Jeffrey Altman Date: Wed Feb 13 05:57:27 2008 +0000 windows-smb-special-share-names-20080212 LICENSE MIT Treat srvsvc, wkssvc and ipc$ as pseudo files. Permit them to be opened and closed without actually existing. For now we treat them as equivalent to ioctls but this should eventually change. Fix RAP processing to not reject names that exist in the root.afs volume for GetInfo queries. commit 44c20384ed5c0fdb4bce737a2a3c2b9c0af4472b Author: Jeffrey Altman Date: Wed Feb 13 05:43:16 2008 +0000 windows-dfs-referrals-20080212 LICENSE MIT Add "ipc$" to the list of names that must not be automatically added as a share name. If the sharename is a partial match and therefore will not be added automatically to the share list, make sure that we return an error to the requestor. commit 31990decdef84adc1c9033944fcc59910720c834 Author: Derrick Brashear Date: Wed Feb 13 05:27:15 2008 +0000 redhat-openafs-kmodtool-20080213 LICENSE IPL10 rename to be specific to us. commit e9e1d1a39bfe047a38f153afdc2fe8951174135c Author: Jeffrey Altman Date: Tue Feb 12 14:00:41 2008 +0000 windows-no-wx-20080212 LICENSE MIT Warnings as errors are nice, but when different compiler versions stop building simply because a parameter is not being referenced in a meaningful way its time for the option to be turned off commit a5e5736c67cdf3d08bce548447bc7635b65329c2 Author: Jeffrey Altman Date: Tue Feb 12 13:29:36 2008 +0000 windows-no-more-rpcns4-dll-20080212 LICENSE MIT Remove all references to rpcns4.lib and its included functions RpcNsXXX. These APIs are no longer supported on Vista. Except for TaAfsAdmSvr they had been commented out for a long time but we still continued to link to the library. Loading the library generates a no longer supported error on Vista. So lets get rid of it. commit 512ec8f51880d4e9e1cc5564bd27991a2c2915d6 Author: Jeffrey Altman Date: Tue Feb 12 13:16:20 2008 +0000 windows-afscreds-username-20080212 LICENSE MIT Use GetUserNameEx to obtain the username instead of searching the registry. Try UserPrincipalName first and fallback to SamCompatible. commit 7a8d8da95f5bd23fbb97d93840f3a2c5a145a695 Author: Jeffrey Altman Date: Mon Feb 11 16:42:45 2008 +0000 windows-afscreds-vista-uac-20080211 LICENSE MIT FIXES 82701 Modifying the registry and the startup shortcuts is not permitted under Vista UAC. Generate an error dialog and notify the end user. commit 61bb3b7f096f3b10075dcb1403879e3ec518276b Author: Jeffrey Altman Date: Mon Feb 11 14:45:43 2008 +0000 windows-freelance-20080211 LICENSE MIT Do not return BAD_NETWORK_ERROR in response to attempts to create directories or files in the Freelance root.afs volume. Instead return ACCESS_DENIED. BAD_NETWORK_ERROR was being sent because the Freelance cell has no vldb servers. Short circuit the error by testing for freelance in CreateFile and MakeDir commit a5dbdd03b8187f0c2c146f330e9adc42e103432c Author: Derrick Brashear Date: Mon Feb 11 03:58:49 2008 +0000 magic-vnodes-20080210 LICENSE IPL10 add magic vnodes like the magic mounts we already have. you can now cons up any afs vnode if you know the cell and fid. commit b44afa839b7c5dd33ab83958f0871edac32fc7ac Author: Derrick Brashear Date: Mon Feb 11 03:42:40 2008 +0000 vos-syncv-dryrun-20080210 LICENSE IPL10 add a dryrun mode to vos syncvldb and syncserv commit c61712de68f6bcb59eac29cb59e9ae78d98cf179 Author: Tom Keiser Date: Mon Feb 11 03:35:43 2008 +0000 dafs-vol-updates-20080210 LICENSE IPL10 make sure status is consistent in vol package when doing dafs commit d7235b1493917250a163dc4336f8b6ac83c6a07e Author: Jeffrey Altman Date: Mon Feb 11 00:13:50 2008 +0000 windows-windows-pipes-20080210 LICENSE MIT do not search for cellnames that match srvsvc or wkssvc pipes commit cd82af9d4e50798e8fe5cf0f2f022f1f40e2b59e Author: Jeffrey Altman Date: Sat Feb 9 02:30:17 2008 +0000 windows-wow64-registry-20080208 LICENSE MIT Enable the 32-bit tools that are distributed for use in the WOW64 environment to access the 64-bit registry keys instead of the 32-bit versions. This will remove the need to support both 64-bit and 32-bit versions of the values. commit 0caf7c54dfac30c92587031af6a902f4d33b2e22 Author: Jeffrey Altman Date: Sat Feb 9 02:26:28 2008 +0000 windows-vnodeops-20080208 LICENSE MIT Add support for returning RANGE_NOT_LOCKED errors Do not attempt to add a mount point for share names of the form . Its just a big waste of time. DNS queries and CellServDB file searches are expensive. commit 607c0959f085a6d8283f78a9969c450930cab084 Author: Derrick Brashear Date: Fri Feb 8 21:19:02 2008 +0000 rx-kill-void-stupidity-20080208 LICENSE IPL10 remove VOID since it conflicts with this. and we shouldn't need it anymore anyway commit 629feb40c46658d08e5dc3e6dcd1114996b8c734 Author: Jeffrey Altman Date: Fri Feb 8 01:20:01 2008 +0000 windows-scache-locks-20080207 LICENSE MIT add lock assertions to ensure we are holding write locks when manipulating scache refcounts commit 1c0c38b91836db8e90c73f340dd302000950a539 Author: Jeffrey Altman Date: Thu Feb 7 21:40:08 2008 +0000 windows-fs-utils-20080207 LICENSE MIT Use ismeta() correctly when parsing integer strings. commit bb2dc54732c865f37b0e9c5b928c850daa795b4d Author: Jeffrey Altman Date: Thu Feb 7 21:20:02 2008 +0000 windows-scache-refcount-race-20080207 LICENSE MIT if we are going to call a NoLock function better be holding the lock commit f2be22f71001852d5d461b34ba2c13d3d53d5e10 Author: Jeffrey Altman Date: Thu Feb 7 20:27:47 2008 +0000 windows-multi-check-servers-20080207 LICENSE MIT for multi must compute the host string from the ip address for each server commit 1a95df210c51a4e1416e5996b99c5640e4265255 Author: Jeffrey Altman Date: Thu Feb 7 14:47:25 2008 +0000 windows-volstat-20080207 LICENSE MIT When updating the volume status do not introduce a deadlock by holding cm_serverLock commit 04cac1963a4716e57447b28c00629f0ef5a15258 Author: Jeffrey Altman Date: Thu Feb 7 06:13:11 2008 +0000 windows-volstat-20080206 LICENSE MIT Ensure that the volume status is always updated after a server_ref status change. commit 5d61f37949fd561f4c9d777cc67c5fd3db835e29 Author: Jeffrey Altman Date: Wed Feb 6 19:29:44 2008 +0000 windows-multi-check-servers-20080206 LICENSE MIT do not leak references remove signed vs unsigned warnings retry all RXGEN_OPCODE responses regardless of whether or not the entry had to be moved to consolidate the list. commit d78bff3dbd561f9d0f4976eeb264e601216a37c6 Author: Jeffrey Altman Date: Wed Feb 6 17:53:12 2008 +0000 windows-shell-add-symlink-20080206 LICENSE MIT No longer attempt to validate the target of the symlink. There is no method of doing so reliably. commit a0e454bd41ec8b363f7669d620d4ff3caa8caf1d Author: Jeffrey Altman Date: Wed Feb 6 16:45:29 2008 +0000 windows-vnovol-20080206 LICENSE MIT VNOVOL means the volume could not be attached which from the client perspective is the same as being offline. The VLDB should not be queried in response to this error. commit 0254b1a8810c3ef9692c0c77f9851b563ea70832 Author: Derrick Brashear Date: Wed Feb 6 12:20:07 2008 +0000 hpux-dafs-inline-functions-20080206 LICENSE IPL10 fix this for hpux commit 66d8633b460448d538178719206bf0b7b3989406 Author: Jeffrey Altman Date: Wed Feb 6 02:08:32 2008 +0000 windows-cleanup-head-20080205 LICENSE MIT cleanup junk that does not belong commit 8274eb91f1c0fd94f3982ae6f12d8dcb8f388f44 Author: Derrick Brashear Date: Wed Feb 6 01:23:50 2008 +0000 linux-rx-kernel-listener-kill-task-directly-20080205 LICENSE IPL10 as reported by cg2v@andrew.cmu.edu commit 9732b4bb94a921a2a6bff0f985e44d04afacebd9 Author: Jeffrey Altman Date: Wed Feb 6 01:13:47 2008 +0000 window-wix-dependencies-two-20080205 LICENSE MIT afsvosadmin.dll is required by translate_et.exe commit b85428263c75316ff8fd15c188617f4eb02670a8 Author: Jeffrey Altman Date: Tue Feb 5 20:48:30 2008 +0000 windows-pioctl-path-charset-translation-20080205 LICENSE MIT FIXES 84279 Do not translate the character set of the pioctl path data. These paths were not provided by the file system but by the end user. Therefore, they were not converted to the OEM character set. With this change the AFS shell context menu will be displayed for non-ASCII file names when ANSI file names are being used as well as the fs commands will work. commit df5cfb3de1deae455d264780d3987c7fa6f33d2c Author: Jeffrey Altman Date: Tue Feb 5 17:37:21 2008 +0000 windows-multi-checkservers-20080205 LICENSE MIT Instead of probing servers one at a time, use multi_rx versions of RXAFS_GetCapabilities, RXAFS_GetTime and VL_ProbeServer to permit simultaneous probing of servers in constant time regardless of the number of servers. commit 5c7dfcad135a1c34942d264be2b72196e3b96003 Author: Jeffrey Altman Date: Tue Feb 5 17:24:15 2008 +0000 multi-rx-calls-20080205 LICENSE MIT Add multi versions of RXAFS_GetCapabilities, RXAFS_GiveUpAllCallBacks, and VL_ProbeServer. commit 0088e5cb20c90a899aacb62cd13b57a7bbe13432 Author: Jeffrey Altman Date: Tue Feb 5 17:17:44 2008 +0000 rxgen-multi-prototypes-20080205 LICENSE MIT When 'multi' is applied to an RPC definition, rxgen produced split prototypes, Start and End, but failed to produce the prototype for the normal RPC call. commit ac614c7609f61394da1ea425940a09bf98fbc0ea Author: Jeffrey Altman Date: Tue Feb 5 17:10:34 2008 +0000 windows-down-time-20080205 LICENSE MIT use clock time instead of osi_Time() for server down time tracking for proper comparison with expiration times. commit db20cd6b718096530e8b2a5f7df7818c4a07783b Author: Jeffrey Altman Date: Tue Feb 5 17:07:13 2008 +0000 windows-check-offline-volumes-20080205 LICENSE MIT Do not hold the cm_volume_t mutex across the RPC commit 48fe8ad6ab68620dbfc26ad44f078c01ba5174c5 Author: Jeffrey Altman Date: Tue Feb 5 16:56:49 2008 +0000 windows-wix-translate_et-20080205 LICENSE MIT Install the dll dependencies for translate_et as part of the client component. commit 08ca5fc1e1c883a5fc6b55cb076540845585243f Author: Jeffrey Altman Date: Mon Feb 4 22:41:28 2008 +0000 dafs-windows-vnode-locking-20080204 LICENSE MIT allow Windows to build with dafs-vnode-locking-20080204 commit 496b5e4c978dec000c5f1e318968d74f8818d60b Author: Simon Wilkinson Date: Mon Feb 4 19:41:49 2008 +0000 pts-localauth-20080204 LICENSE IPL10 distilled from changes by mdw@umich.edu commit ed25934c1fe96b143715025b49104e75dce9a361 Author: Tom Keiser Date: Mon Feb 4 18:50:54 2008 +0000 dafs-vnode-locking-20080204 LICENSE IPL10 FIXES 84778 * Vnode package concurrency model was overhauled. Unlike the old model, where concurrency was controlled via reader/writer locks, the new model uses a per-vnode finite state automata. * add several new volume states to deal with volume vnode list operations * a new FSSYNC command code was added to allow volume utilities to close out a volume operation without causing the fileserver to mount the volume * a new FSSYNC command code was added to allow volume utilities to transition a volume into a hard error state * the salvageserver has been modified to keep volume group partition path data coherent with the fileserver (like many other parts of the volume package, this code assumes all members of the group are stored on the same vice partition) * make salvageserver correctly handle volume state when a child worker process terminates abnormally * update volume pre-attachment code to deal with move volumes across partitions on the same server * add volume state sanity checks to more volume package interfaces * original vos online patch introduced a race condition; rearchitect vos online/offline to eliminate race condition, and reduce i/o load caused by operation * unify duplicate code in volserver related to servicing vos examine and vos listvol requests * add doxygen formatted comment blocks to numerous volume package elements * various updates to fssync-debug to allow dumping vnode state, and updates to deal with added volume and vnode states * several 1.5-specific fixes related to fssync and salvsync commit 647bbb509ddf59b80ce9965e89ac13ea26952e0f Author: Jeffrey Altman Date: Mon Feb 4 04:05:00 2008 +0000 rx-xdr_rec-type-error-20080203 LICENSE MIT x_inline second parameter is unsigned commit f68eb88ac0af27371232903de837de57f0790056 Author: Jeffrey Altman Date: Mon Feb 4 03:56:13 2008 +0000 kauth-windows-handle-leak-20080203 LICENSE MIT close() does not close sockets on Windows commit 80fc057c4dc0b3373723a19eeb6a9fa12a71f301 Author: Jeffrey Altman Date: Mon Feb 4 03:50:05 2008 +0000 rxmaxmtu-printf-format-error-20080203 LICENSE MIT correct improper format string commit 270cb6a9c9903d92b9b6276a542968667056066a Author: Jeffrey Altman Date: Sat Feb 2 22:25:40 2008 +0000 windows-vista-resume-smb-binding-20080202 LICENSE MIT another plane trip, more tweaks to the logic for handling re-binding of the netbios name after a power management resume event. commit d52f19ca0aacdbfdf64bdeaae4153c1f2ec7f385 Author: Jeffrey Altman Date: Sat Feb 2 22:22:20 2008 +0000 windows-dfs-referrals-symlinks-20082002 LICENSE MIT another small tweak to ensure that we don't create a symlink for "fo" when a mountpoint or symlink for "foo" exists commit d094c65f14e674dfc334b9c6b3f5ac871e3dd1e6 Author: Jeffrey Altman Date: Sat Feb 2 13:38:50 2008 +0000 windows-cellservdb-location-20080202 LICENSE MIT Modify the search order for determining the location of CellServDB and other client configuration files. 1. AFSCONF environment variable 2. registry setting 3. NEW - use All Users\AppData\OpenAFS\Client only if CellServDB exists 4. use Program Files\OpenAFS\Client commit 753ba70cf257aded0fae158c556a25ca72243214 Author: Jeffrey Altman Date: Sat Feb 2 02:46:16 2008 +0000 windows-more-cellservdb-consolidation-20080201 LICENSE MIT Merge cellconfig.c and the afsreg library. Redefine the location of the client cellservdb directory in dirpath in terms of the cellservdb direction and not the install directory. (although they point at the same thing now by default.) Future changes to the location of the cellservdb directory should be made in afsreg. commit c9339265f7036dd465a4bbf8e762fc246f45d6a4 Author: Jeffrey Altman Date: Sat Feb 2 00:23:44 2008 +0000 windows-client-config-cellservdb-20080201 LICENSE MIT modify cellservdb.c to use cm_GetCellServDB() from libafsconf.dll. This results in both libadmin and the afs client control panel using the same CellServDB as the rest of the system. commit f224734230f6bfd27f1a1dfa159d1f38797c7999 Author: Jeffrey Altman Date: Sat Feb 2 00:18:27 2008 +0000 windows-build-system-20080201 LICENSE MIT re-order the building of directories so that libafsconf.dll is built before other directories that might want to use it. commit 0f41a173925407cc7f6a597477ba25691f73d119 Author: Jeffrey Altman Date: Fri Feb 1 21:42:17 2008 +0000 windows-refactor-cm_config-20080201 LICENSE MIT cm_config.c was a nightmare. there were several functions that each computed the location of the OpenAFS Client configuration directory in a slightly different way. Now there is a single exported function that determines the directory, and another that determines the name of the CellServDB file. All of the other functons in cm_config.c and throughout the src/WINNT/afsd directory now use those two functions. The new rule for determining the location of the OpenAFS Client configuration directory and hence the CellServDB file location is: 1. check the AFSCONF environment variable 2. check the HKLM\SOFTWARE\OpenAFS\Client CellServDBDir registry value 3. use AFSDIR_CLIENT_ETC_DIRPATH which currently refers to \Program Files\OpenAFS\Client commit 4fe2978f69f6314284d5689ea1d9169360155450 Author: Derrick Brashear Date: Fri Feb 1 21:31:32 2008 +0000 h-enumerate-less-heavyhanded-check-20080201 LICENSE IPL10 if hostCount is too small this is fine or at least not fatal commit 4ad35bd5aa431332bea866775278a6ae9d65a5e2 Author: Jeffrey Altman Date: Fri Feb 1 21:14:40 2008 +0000 windows-netidmgr-20080201 LICENSE MIT afs/stds.h before all others commit 43aa2bd2ba63e778f78d80b2a6a7d5ff991b0f97 Author: Simon Wilkinson Date: Fri Feb 1 15:25:52 2008 +0000 poll-drop-fsync-lock-20080201 LICENSE IPL10 update to drop fsync lock if we're using poll commit 462f1fb90defcb351657655442024f971705d945 Author: Derrick Brashear Date: Thu Jan 31 20:17:45 2008 +0000 solaris10-cleanup-friendliness-20080130 LICENSE IPL10 based on patch from mib@unimelb.edu.au clean up taskq after ourselves and don't leave ourself marked system processes commit 3d17e10e007ea3b4c3bd4a536a7e47c264d4701f Author: Jeffrey Altman Date: Thu Jan 31 16:09:56 2008 +0000 windows-noprobe-20080131 LICENSE MIT do not mark servers down if they are not probed. commit 03e72233178bf18a8978d62c3bcc4ebb743e6710 Author: Jeffrey Altman Date: Thu Jan 31 07:26:26 2008 +0000 windows-edquot-20080131 LICENSE MIT For Windows, EDQUOT == WSAEDQUOT. Define it in the right places so that in the end STATUS_OUT_OF_QUOTA can be returned to the application. commit 02a80e05a73d9df50fbd427e30ca862706afcbc1 Author: Jeffrey Altman Date: Thu Jan 31 05:47:34 2008 +0000 windows-fs-newcell-20080130 LICENSE MIT prevent the afs client service from crashing when fs newcell is executed commit 3d0ebe1f7841ac6ca9db593b587a13d85a950ac5 Author: Jeffrey Altman Date: Thu Jan 31 03:01:46 2008 +0000 windows-nsis-installer-20080130 LICENSE MIT move afslogon.dll, afscpcc.exe and afs_cpa.cpl to \Program Files\OpenAFS\Client\Program in order to get them out of the %windir% tree commit 9ce814aa99b6877843f38c7fdd8fde09cb2a743c Author: Jeffrey Altman Date: Thu Jan 31 00:25:59 2008 +0000 rx-edquot-20080130 LICENSE MIT Conditionalize error translation on the existence of EDQUOT not on platform macros commit 9751c68faaff4ab5e4fae7aaad082073ca4daebf Author: Simon Wilkinson Date: Wed Jan 30 17:30:23 2008 +0000 linux-keytype-exports-20080130 LICENSE IPL10 try to work even if key_type_keyring isn't exported commit c5afa335a8ffb86cf17c32173eb0e1c26500dd80 Author: Simon Wilkinson Date: Wed Jan 30 17:25:42 2008 +0000 linux-rx-kernel-listener-kill-task-directly-20080130 LICENSE IPL10 based on work from shadow@dementia.org since the tasklist lock and rcu stuff can/will be de-exported, and we don't need it anyway... commit 162cb95707f739170ab4a025a801a430c86ae70a Author: Jeffrey Altman Date: Wed Jan 30 14:53:44 2008 +0000 windows-ipaddr-change-server-deadlock-20080130 LICENSE MIT avoid a deadlock during server probes initiated by the ipaddr change daemon thread. (missed a case in DELTA windows-ipaddr-change-server-deadlock-20080106) commit 9023049040e5705ac5dc26800022973a1acefff2 Author: Alistair Ferguson Date: Tue Jan 29 20:39:31 2008 +0000 syncvl-fix-bogus-rw-update-20080129 LICENSE IPL10 pass in a ref to entry correctly commit 2542c5e07f52c89f25f290153f0b4669076ae654 Author: Jeffrey Altman Date: Tue Jan 29 00:20:33 2008 +0000 windows-lanahelper-20080128 LICENSE MIT The algorithms that were used to produce a Netbios name were broken. The name that was produced when the hostname was too long was in fact longer than the maximum permitted netbios name. Also, the "NetbiosName" value was not used as a suffix when the loopback adapter was not installed. The hardcoded string "AFS" was used instead. commit fffcc1dec3d4fc905239b2890cb4f960efdff4ba Author: Jeffrey Altman Date: Mon Jan 28 19:49:51 2008 +0000 windows-network-type-allocation-20080128 LICENSE MIT Microsoft has defined for us: #define WNNC_NET_OPENAFS 0x00390000 commit a0fd168db5e24fca5f08ccf67d53f58c6f05fa35 Author: Derrick Brashear Date: Mon Jan 28 19:29:49 2008 +0000 revert-linux-2624-rc5-updates-20080127 LICENSE IPL10 FIXES 83716 the generic 2.6.24 patch should address all this. commit 5a93678e3943fa2c71d51f25f84b4efd5f3700e6 Author: Marc Dionne Date: Mon Jan 28 19:13:46 2008 +0000 sysctl-table-checking-modpost-fun-fun-20080127 LICENSE IPL10 FIXES 83890 try again to do something sensible so we don't default wrong commit 36bdf1ccd859fb0039d8ae9abd04f9eea08d704d Author: Jeffrey Altman Date: Mon Jan 28 07:22:32 2008 +0000 windows-freelance-improved-dfs-handling-20080127 LICENSE MIT Cell names are published as share names. As a result they are searched for as part of the Dfs Referral evaluation. If share "foo" can not be reached, the CIFS client will fallback to searching for "fo" as well. Since the freelance client automatically adds a symlink for prefixes of the cell name, this results in both "foo" and "fo" being added to the freelance root.afs volume. This patch prevents that negative side effect. commit 3f3545024100f3efd7bb76925d3cb1b1c15ae3f4 Author: Jeffrey Altman Date: Mon Jan 28 07:12:09 2008 +0000 windows-afskfw-20080127 LICENSE MIT when tracking ccache names be sure to include the cache type prefix. commit 7526681ef5c57a4ffe0c343717c3ed65a9120768 Author: Derrick Brashear Date: Mon Jan 28 01:37:38 2008 +0000 afsdb-fix-20080126 LICENSE IPL10 pull bugfix from 1.4 commit 711dc57c7fa053efa58c02df8788da1a2c7889bf Author: Jason Edgecombe Date: Sun Jan 27 18:44:28 2008 +0000 macos-panic-decoder-20080127 LICENSE BSD panic log decoder from Jason. Still needs some work for Leopard but we should be able to make a go of this commit 7dc71d1154294cdc5f5aba4c3e58a00972318960 Author: Derrick Brashear Date: Thu Jan 24 23:55:02 2008 +0000 redhat-support-dkms-20080124 LICENSE IPL10 attempt to provide dkms support. this does work on my fc8 test host. it may not work in all cases. commit 80f7294490e1d1423a5f7482ed924dda8bab1ba8 Author: Mike Meffie Date: Thu Jan 24 23:44:38 2008 +0000 tests-update-20080124 LICENSE IPL10 update test scripting commit 89d93d9ad7862c5de0587a84d99c567bf5a61d14 Author: Jeffrey Altman Date: Thu Jan 24 16:05:58 2008 +0000 rxkad-v5-dot-check-20080124 LICENSE MIT Export rx_SetSecurityConfiguration on Windows commit d32156e5c1fb36994650754a11379df6ccc94909 Author: Jeffrey Altman Date: Thu Jan 24 15:29:56 2008 +0000 windows-get-volume-no-reset-flag-20080124 LICENSE MIT There are circumstances where a volume object is being accessed and the volume is marked indicating that the volume location information is out of date but where it is also pointless and perhaps dangerous to block waiting for the rpc to complete. One example is when processing the cmdebug requests. If we know that we are not going to use the volume object to contact a server, then we can now set the CM_GETVOL_FLAG_NO_RESET flag. commit 16a90b2f8dfe875991bca0dee516c531fcc3aeee Author: Jeffrey Altman Date: Thu Jan 24 15:17:57 2008 +0000 windows-symlink-dot-dot-20080124 LICENSE MIT when moving up in the directory tree we search the recorded fid list to find a matching fid that we have already crossed. we must also reset the fid count based upon what we discover. commit ef6fc588bcab9a59e54050899937407be962b074 Author: Derrick Brashear Date: Wed Jan 23 21:37:01 2008 +0000 redhat-spec-more-arches-20080123 LICENSE IPL10 support sprc, sparc64, ppc, ppc64, s390, s390x. we should be able to cope with all these. if not, fix it. commit 9a45a546747dad7a70b24b76b1a02bf398c22762 Author: Derrick Brashear Date: Wed Jan 23 13:47:23 2008 +0000 linux-key-type-detection-once-20080123 LICENSE IPL10 doubled configure test from 2 sources. commit 434c25fee15162dff64f2c18a971023b146d6118 Author: Simon Wilkinson Date: Wed Jan 23 05:29:03 2008 +0000 redhat-kmodtool-20080122 LICENSE IPL10 install simon's modified kmodtool commit 98a68f9b021a06d056fb3b97681b9cfc04873d55 Author: Simon Wilkinson Date: Wed Jan 23 04:13:55 2008 +0000 rxkad-v5-dot-check-20080122 LICENSE IPL10 FIXES 75101 give an option to not enforce the dotted principal check. document it. commit 0e8adf69538638b8caa56d9b1fa72beba74734bd Author: Derrick Brashear Date: Wed Jan 23 03:20:13 2008 +0000 viced-fsync-glock-creation-20080122 LICENSE IPL10 create fsync glock and cond before we initialize volume package. oops? commit 0fab6d9600769dd219fd6e968c4a6bae9ed5d497 Author: Derrick Brashear Date: Tue Jan 22 21:03:51 2008 +0000 redhat-packaging-keep-up-with-the-joneses-20080122 LICENSE IPL10 track new manpages commit e1c4e77d13122c2bb66d532ffd9dfc2e75318c04 Author: Derrick Brashear Date: Tue Jan 22 05:15:15 2008 +0000 vos-volser-enhancements-20080121 LICENSE IPL10 add option to addsite to allow adding a site where there is already a release- equivalent volume resident, where thus we don't want to mark unreleased (possible by dumping an existing RO and restoring with -readonly at the new site) add ability to vos clone to a readonly or backup with the correct ID and name add ability when restoring a RW to a new site to leave the volume at the old site intact all changes are internal to vos and can be used with any OpenAFS from 2006 or later (supporting changes in namei to not create volumes with bad parent id went in in December 2005) commit 1181ea034623541765fbc5c23df55ebaf577c083 Author: Mike Meffie Date: Mon Jan 21 21:04:35 2008 +0000 tests-update-20080121 LICENSE IPL10 update test scripting commit 82e389f56fe86f8db25c1ceb1f15df4070451538 Author: Evan Broder Date: Mon Jan 21 21:03:48 2008 +0000 macos-packaging-using-afs-conf-when-possible-20080121 LICENSE IPL10 FIXES 81825 switch to afs.conf as other ports use instead of afsd.options, when possible commit 6a7461e6f8dad79894c6d2ad11edfdba689c4c77 Author: Derrick Brashear Date: Mon Jan 21 18:36:02 2008 +0000 make-avoid-double-slash-20080121 LICENSE IPL10 avoid having double / in make commands commit fc91cf4314eb768a2f83f198645e553b5fa778de Author: Jeffrey Hutzelman Date: Mon Jan 21 17:34:00 2008 +0000 solaris-vfsroot-refcount-issue-20080121 LICENSE IPL10 fix issue with afs root vnode refcount dropping to 0 commit 75c10322ff3a3ef5e735d8821051678526e42275 Author: Simon Wilkinson Date: Mon Jan 21 17:08:22 2008 +0000 redhat-spec-update-20080121 LICENSE IPL10 update specfile to default to fedorakmod commit 9d22f7702e22d028e8c503cd96d26850ff617ba9 Author: Derrick Brashear Date: Mon Jan 21 14:18:11 2008 +0000 libafs-linux-dest-right-things-20080121 LICENSE IPL10 "duh" make it like the install rules commit 22c059a9138be33eeeed910badcac3ebfeea24b5 Author: Derrick Brashear Date: Mon Jan 21 14:04:34 2008 +0000 vos-restore-incrementals-no-orphans-really-20080121 LICENSE IPL10 FIXES 46937 based on comments from jhutz@cmu.edu; runnign thread in the ticket commit efba39ead059458d222f923db83c660f23c20b80 Author: Jason Edgecombe Date: Sun Jan 20 00:06:49 2008 +0000 man-page-fileserver-limits-20080119 LICENSE BSD Document the 2TB volume and partition limits and the -abortthreshold flag to the AFS fileserver. commit 88e915d8f976898e75a6afe8bc7b6d7c33b8a121 Author: Jeffrey Altman Date: Wed Jan 16 03:16:19 2008 +0000 windows-cm_ioctl_query_opts-20080115 LICENSE MIT The path ioctl operations have several issues: (1) the specified path for "fs examine, whereis, whichcell, flush" and so always has the follow symlinks and mount points semantics. This makes it impossible to determine what the FID of a symlink or mount point is. (2) "fs examine" out is not the result of a single pioctl operation but is actually the combined output of half a dozen operations. Path evaluation is an expensive operation. It would be faster if the caller could evaluate the FID first and then perform all of the rest of the operations by specifying the FID instead of the path. (3) fs output reports all objects as files. By adding a GetFileType pioctl more informative output can be provided that indicates what type of object the path evaluates to. (4) the Windows fs command includes a number of commands that do nothing but exist only because the Unix cache manager supports them. This delta adds a new extendible data structure cm_ioctl_query_opts_t which can be optionally specified with pioctls that do not already require input data. The first two fields of this structure are 'literal' and 'fid'. The literal field is used to indicate whether the last component of the path should be evaluated following symlinks and mount points. The fid field permits a fid to be specified. A new GetFileType pioctl has been added. The type of objects are now output. A new "-literal" option is available for "fs examine, flush, whereis, and whichcell. Unimplemented fs commands have been removed. commit 64ef3f518eee22b167ff5043b01dc1f3251f10bd Author: Derrick Brashear Date: Tue Jan 15 23:42:08 2008 +0000 redhat-makesrpm-deal-with-cellservdb-20080115 LICENSE IPL10 autofetch the CellServDB based on the spec or let one be provided commit c386499fbeab36f5292e196563a4887fa06068ac Author: Matt Benjamin Date: Tue Jan 15 06:04:49 2008 +0000 fbsd-70-updates-20080115 LICENSE IPL10 FIXES 82847 updates to make us build on freebsd 7.0 commit 08d71812fed3cc9f37d516d8f5d5b4ba9ccfb032 Author: Derrick Brashear Date: Tue Jan 15 05:20:49 2008 +0000 arm-linux-20080115 LICENSE IPL10 make an arm linux port. commit 110d5702ea51ce43fca6a5962d9ef8a0ec56d6eb Author: Jason Edgecombe Date: Mon Jan 14 04:55:21 2008 +0000 man-page-cmdebug-updates-20080113 LICENSE BSD Add -ctime and -cellservdb options to the cmdebug man page and improve example host names and SEE ALSO references. commit d5811091995b78d65e891b134aa0ad6955bbc30c Author: Jeffrey Altman Date: Sun Jan 13 15:32:24 2008 +0000 cmd-nname-20080113 LICENSE MIT Nname() is used to concatenate two strings and is frequently used with the first string being the name of the executable perhaps with a full path. The static buffer specified is too small for a full path and there was no protection against writing beyond the end of it. commit 84989e6584e3808ae3f1959330b267feff2661f6 Author: Jeffrey Altman Date: Sun Jan 13 14:37:04 2008 +0000 windows-pioctl-parse-path-20080113 LICENSE MIT Apply the desired "follow symlinks/mountpoints" semantics to the single component non-UNC case. commit 7a40c73476e270aac9d76663ff71e956bb630328 Author: Jeffrey Altman Date: Sat Jan 12 23:29:59 2008 +0000 windows-explorer-shell-symlinks-show-20080112 LICENSE MIT Add AFS->Symlnks->Show dialog to the explorer shell menu commit b3fe9727b3e775348561bcbe0cf0c14cff82e597 Author: Jeffrey Altman Date: Sat Jan 12 15:43:37 2008 +0000 cmdebug-cellservdb-20080112 LICENSE MIT Add -cellservdb option to the cmdebug command. This option will retrieve the volume location database information for all cells known to the cache manager and output the data in the format required by the CellServDB file. This functionality is supported by the UNIX cache managers and Windows cache managers 1.5.31 and later. commit bda66877dd88bcc78eba646b4f6a1131266e33d4 Author: Derrick Brashear Date: Fri Jan 11 22:38:48 2008 +0000 config-cvsignore-update-20080111 LICENSE IPL10 ignore generated Makefile.SYSNAME.in commit ae9dc9ad4ddd8313d24e457faf48bc15ccd2c86c Author: Jeffrey Altman Date: Fri Jan 11 19:09:20 2008 +0000 windows-callback-getcellservdb-20080111 LICENSE MIT Add support for RXAFS_GetCellServDB. Implemented by generalizing RXAFS_GetCellByNum and special casing the index values to do the right thing. Conditionalize grabbing the callp->lock in the callback functions. The race conditions in rx have long since been fixed and the potential for deadlocks are too great. Add a new flag CM_FLAG_NOPROBE for use in calls to cm_GetCell. When set the newly discovered servers will not be immediately probed. Useful when setting tokens, setting server preferences, or responding to cmdebug callbacks. commit 8b82cbeef760992c6e3d27f9f6ea1f4e0bb559ab Author: Jeffrey Altman Date: Thu Jan 10 23:48:02 2008 +0000 windows-smb-synchronization-20080110 LICENSE MIT 1. prevent stopping the smb_Listeners due to an ip addr change when the LANA is determined either by registry assignment or loopback detection 2. add synchronization logic to prevent smb_Listener restarts prior to smb_Listener thread stoppage 3. no longer permit panics from smb_Listener threads 4. move the probe logic from cm_IPAddrDaemon thread to the cm_Daemon thread in order to avoid the loss of ip addr change events. If an adapter stops and restarts fast enough there might not be anything for us to do. commit 8569f67aee8ee0de26259397818ab3af69f18007 Author: Matt Benjamin Date: Thu Jan 10 16:58:30 2008 +0000 linux-2624-rc5-updates-20080110 LICENSE IPL10 FIXES 80463 Include linux/key-type.h in osi_groups.c, if it exists. Fix do_sync_read test for recent kbuild (maybe break it for [some older 2.6]). commit 5011ea88badac8d393c4566a69e30f74c85e13ab Author: Simon Wilkinson Date: Wed Jan 9 19:36:59 2008 +0000 redhat-make-srpm-script-20080109 LICENSE IPL10 srpm builder script commit a1b7be4ac3f073a2d64f46649e54a1ff99d2567b Author: Jeffrey Altman Date: Wed Jan 9 15:25:07 2008 +0000 windows-smb-name-deleted-20080109 LICENSE MIT if the smb_Listener receives NRC_NAMERR (name deleted) it must be because an smb shutdown has occurred. do not panic. commit 845fb28de656d9886dd44cbf335833985ffc7d3b Author: Jeffrey Altman Date: Wed Jan 9 06:03:10 2008 +0000 windows-pioctl-follow-mountpoints-registry-20080108 LICENSE MIT Add a registry value "PioctlFollowMountPoint" to permit the use of the old pioctl path evaluation behavior that always followed mountpoints and symlinks. commit f2fd97bfb02d1d2ed46304b5864d71a8759892a4 Author: Jeffrey Altman Date: Tue Jan 8 22:28:39 2008 +0000 smb-even-less-chatty-20080108 LICENSE MIT remove the smb_RestartListeners message entirely commit 110f74bcb85928d274ad2608662434304ff4ffae Author: Jeffrey Altman Date: Tue Jan 8 22:03:12 2008 +0000 windows-daemon-20080108 LICENSE MIT sleep 10 seconds between cycles. should make this configurable. commit 05e5b9129f18fa717132dc1b0932acc1ed3f72c9 Author: Jeffrey Altman Date: Tue Jan 8 21:59:28 2008 +0000 windows-smb-logging-20080108 LICENSE MIT Be less chatty commit 69c9ab66a41236e987b44af9a3cb141adb1c2817 Author: Jeffrey Altman Date: Tue Jan 8 21:26:46 2008 +0000 windows-callback-missing-bang-20080108 LICENSE MIT Insert a missing bang that results in a null pointer dereference when processing a callback from an unrecognized server. commit a731801899b5f81314e4f4bf49aa55703d7a4ef4 Author: Jim Rees Date: Tue Jan 8 17:18:57 2008 +0000 obsd-more-stack-20080108 make stack bigger in volserver and fileserver eliminates overflow in k5 library commit 2927287f13f99c8453f64839d20877769d768264 Author: Jim Rees Date: Tue Jan 8 17:04:30 2008 +0000 obsd-lock-no-interlock-20080108 restore lock vnode op, but without vnode interlock for obsd 4.2 commit 521f139a89c2f078888b8bad37a495d23723a789 Author: Asanka Herath Date: Tue Jan 8 17:04:19 2008 +0000 windows-nim-afscred-identity-initialization-20080108 LICENSE MIT One of the challenges to deploying NIM has been the configuration of AFS token acquisition. This patch adds a new registry key hierarchy HKLM\SOFTWARE\OpenAFS\Client\Realms which is used to configure the AFS Provider for a new identity based upon the realm of the identity. The Realms key contains subkeys for each realm for which configuration data is being provided HKLM\SOFTWARE\OpenAFS\Client\Realms\"RealmName" "RealmName" contains one optional value, "AFSEnabled", and subkeys for each Cell that is to be added to the configuration. "AFSEnabled" defaults to 0x01. HKLM\SOFTWARE\OpenAFS\Client\Realms\"RealmName"\"CellName" In "CellName", there are two optional values, "Realm" and "MethodName". If the values are not specified, the automatic realm and method determination algorithms are used. These values can be added to an MSI transform or deployed via Group Policy. commit 5979a37e4e361bd9d2c52b6f6ef4bcce20a3124c Author: Jeffrey Altman Date: Tue Jan 8 07:04:51 2008 +0000 windows-smb-started-synchronization-20080108 LICENSE MIT Add a new mutex "smb_StartedMutex" which is used to protect the transitions between the various smb_ListenerState values. commit a05df915505ab3e77e46e39a5b232086c43fc8bf Author: Jeffrey Altman Date: Tue Jan 8 06:27:36 2008 +0000 windows-printf-format-string-protection-20080108 LICENSE MIT Do not pass strings generated from incoming network data to ??printf as the format string. Instead use a format string of "%s". This protects against %? expansions being inserted in the string. commit be4da54fa06c0a6f43c0be09e1339d29cc4b5e5a Author: Derrick Brashear Date: Mon Jan 7 20:22:10 2008 +0000 viced-hpr-error-handling-20080107 LICENSE IPL10 fix ubik reinit issue reported by jhutz@cs commit 777a2840878af313e062c4885ae7002bad62bdf4 Author: Derrick Brashear Date: Mon Jan 7 20:10:27 2008 +0000 sys-syscall-object-dependency-20080107 LICENSE IPL10 make syscall.o always be created, some makes don't deal with the implicit requirement commit 58efc5029c832e6b1456c36b599e7e33d62cd9c6 Author: Russ Allbery Date: Mon Jan 7 18:14:54 2008 +0000 linux-probe-warning-case-20080107 LICENSE MIT Some older Linux kernels prefix warnings with "Warning:" rather than "WARNING:", so do the grep case-insensitively when finding missing symbols. commit b19c56edfa5f0e3ff95f32b006b9403f53dd406f Author: Jeffrey Altman Date: Mon Jan 7 17:54:06 2008 +0000 windows-bkg-prefetch-buf-refcount-leak-20080107 LICENSE MIT Close a refcount leak in bkg prefetch. Do not stop prefetching simply because a buffer we want is already being fetched. Instead skip the buffer and try to fetch the next one we require. commit 049bc4a637334c6e94661a60067ff6a27e5ad481 Author: Jeffrey Altman Date: Sun Jan 6 23:11:01 2008 +0000 windows-ipaddr-change-server-deadlock-20080106 LICENSE MIT avoid a deadlock during server probes initiated by the ipaddr change daemon thread. commit 342595b2aa712ca7c0f2c160f9cba304dd27d574 Author: Derrick Brashear Date: Sun Jan 6 15:57:05 2008 +0000 viced-threadquota-release-holds-20080106 LICENSE IPL10 release a hold when we decline to service a host commit 6887c0e5b2b766b06c7e76a5ce28b84ed52df1d5 Author: Jeffrey Altman Date: Sun Jan 6 06:25:08 2008 +0000 windows-power-mgmt-20080105 LICENSE MIT Log more power mgmt events. Do not permit a smb reinitialization when in a suspended state Periodically check to see if the LAN adapter is -1. If so, try to reinitialize the smb stack. commit d27e82c8e2dcdf81ce8e8e6e849828881256f5fc Author: Jeffrey Altman Date: Sat Jan 5 22:19:12 2008 +0000 windows-follow-backup-path-20080105 LICENSE MIT parens are required in order to get the desired behavior commit f789f943f6967094f921b1b1b232be22925e3849 Author: Jeffrey Altman Date: Sat Jan 5 18:55:55 2008 +0000 windows-nim-afscred-referrals-two-20080105 LICENSE MIT compatibility with Visual Studio 2005/2008 commit f970985bc35ade50371a9299ad580d96ad04e979 Author: Jeffrey Altman Date: Sat Jan 5 17:55:20 2008 +0000 windows-vista-network-change-20080105 LICENSE MIT After a network change, test to see if the desired LAN adapter to bind the Netbios Name to has changed. If so, stop the Netbios Network and restart with the new LAN adapter. This can happen on Vista after a suspend if the service wakes up before the Loopback adapter re-initializes. commit 53acd2042d53d947b213ba4ee58378c89555a868 Author: Jeffrey Altman Date: Sat Jan 5 17:28:59 2008 +0000 windows-nim-afscred-referrals-20080105 LICENSE MIT If the requestd realm name is the empty string, copy the realm from the resulting ticket for use in pts registration. commit 8e3940c461f29483dcd71a5ba7cc59db89ea38e1 Author: Derrick Brashear Date: Sat Jan 5 16:59:56 2008 +0000 windows-aklog-referrals-20080105 LICENSE IPL10 If the realm name of the requested ticket is the empty string, decode the actual service ticket to determine the actual realm. Obtaining the actual realm prevents unnecessary pts registration failures. commit 2d15ac79349678e025f407b863f2911cd20e6f4e Author: Marc Horowitz Date: Sat Jan 5 04:43:09 2008 +0000 aklog-referral-support-20080104 LICENSE IPL10 with updates and configure support from Simon Wilkinson. make aklog able to cope with referrals. commit 02dc91892c41163f24c818615d13271b074df3ca Author: Derrick Brashear Date: Fri Jan 4 18:37:28 2008 +0000 pag-allocation-dont-throttle-when-time-reverses-20080104 LICENSE IPL10 avoid pag allocation throttling when time is set back by e.g. ntpd to avoid starving everyone. commit 5d453a987581158e9398061703d5a4b4b81e1dd3 Author: Jim Rees Date: Fri Jan 4 18:07:35 2008 +0000 xbsd-include-systmh-20080104 include systm.h for xbsd commit 034f698ebf21854c8dfb46567fc4ec2ac21457f0 Author: Jim Rees Date: Fri Jan 4 17:56:11 2008 +0000 obsd-resid-type-20080104 use correct type for resid when calling vn_rdwr() commit e192814db3a754aa5fe24acf10aa24030c57fa55 Author: Jim Rees Date: Fri Jan 4 17:39:05 2008 +0000 setuuid-return-20080104 return success (0) from setuuid() commit d2c62877ebd9b8481d7822fcd64f0803eaef9e9f Author: Jim Rees Date: Fri Jan 4 17:27:23 2008 +0000 obsd-time-20080104 update kernel time functions for OpenBSD 4.2 commit 068233cf4ab90a173e04de94605490e651d2f686 Author: Jeffrey Altman Date: Fri Jan 4 07:56:45 2008 +0000 windows-fs-test_volstat-20080103 LICENSE MIT Add a hidden command that can be used to test volume status handlers. fs test_volstat. commit 23318f425ca8ccdc9b67bfc1be0a28c0f724f52a Author: Jeffrey Altman Date: Fri Jan 4 07:51:31 2008 +0000 windows-fs-path-avail-20080103 LICENSE MIT fix the reporting of volume status as a result of the VIOC_PATH_AVAIL pioctl call. Switch on errno instead of the pioctl return value. commit d851dda5b7a84fa1acf5ccc93313df90922ce6b1 Author: Jeffrey Altman Date: Fri Jan 4 07:48:37 2008 +0000 windows-fs-prototype-20080103 LICENSE Fix types in prototypes to be consistent with function definitions commit 6034868e79f85e0143caa40669244cb8e442587b Author: Jeffrey Altman Date: Fri Jan 4 07:46:29 2008 +0000 windows-smb-20080103 LICENSE MIT ensure type consistency between 32-bit and 64-bit processes by replacing 'long' with 'afs_uint32' commit ae8e701952ae029672f2d7acfaf94cd44c1e4df4 Author: Jeffrey Altman Date: Fri Jan 4 07:44:10 2008 +0000 windows-volume-status-20080103 LICENSE MIT when performing offline volume status checks handle CM_ERROR_NOACCESS conditions by restoring the volume status to vl_unknown. commit 3a541eb11d1bc7bd05b85635315214218d3b5d6f Author: Derrick Brashear Date: Thu Jan 3 18:02:30 2008 +0000 aix-lam-aklog-update-20080103 LICENSE IPL10 make the aklog lam plugin work correctly in e.g. the CDE screenlocker, which is part of the long-running and not-run-by-user dtsession; this means we do wackiness to 1) not pag ourselves in that case 2) setuid to the user to set uid tokens if we got a username and are root 3) do not use pr_mumble get the the AFS ID to put in the tokens, as multiple initializations of Rx in the process space of dtsession crashes it commit dbb3f1d0b6e2e1e42b1f0ef4c29c21d8090e605a Author: Jim Rees Date: Thu Jan 3 17:46:08 2008 +0000 obsd-buf-fixes-20080103 use new b_data field in struct buf commit 7793d4e5183993f8c5fa01cf5c099405757fa183 Author: Jim Rees Date: Thu Jan 3 17:12:21 2008 +0000 obsd-lock-vnops-20080103 use generic vnops for lock/unlock (for obsd 4.2) commit b2a34dd35fc1e49918342e500a5bf8b74510e999 Author: Jim Rees Date: Thu Jan 3 17:11:22 2008 +0000 obsd-uvm-1-20080103 long overdue fixes for uvm on openbsd commit ff21ae91b248873ff1ac5347f84c180d0817a0b4 Author: Jim Rees Date: Thu Jan 3 02:28:29 2008 +0000 use-k5-klog-20080102 use k5 klog for OpenBSD commit 5baef6f6fe55ca81a28bc22023b06ee6c50d453d Author: Jeffrey Altman Date: Wed Jan 2 15:53:46 2008 +0000 windows-64bit-20080102 LICENSE MIT do not disable the signature verification of binaries when using large cache sizes on 64-bit systems cm_config_data values are unsigned and some are 64-bit. when logging them use the correct data format types. commit 558acfe359188e21f4956dcccdd7f7a4adbca3f1 Author: Derrick Brashear Date: Wed Jan 2 15:10:08 2008 +0000 redhat-spec-cvsignore-20080101 LICENSE IPL10 as reported by mdw@umich.edu commit d59d1db605280bfa9b2234f5272d61152ca7d7de Author: Jeffrey Altman Date: Wed Jan 2 14:58:35 2008 +0000 windows-nim-afscred-supports-krb4-20080102 LICENSE MIT Do not trust the registry to determine whether or not krb4 support is available. In a roaming profile the user data can say 'yes' even if the plug-in or the kerberos library does not exist. commit cfcaa0be3cc22fce97737ae4f6387a8200de770d Author: Jeffrey Altman Date: Wed Jan 2 07:06:58 2008 +0000 windows-nim-afs-krb524-20080102 LICENSE MIT Don't call krb524_convert_creds_kdc if it doesn't exist. 64-bit KFW doesn't support krb4 and the function isn't present. commit 2e135307b52b04003a22aa9985807a70b407accc Author: Derrick Brashear Date: Fri Dec 28 22:13:42 2007 +0000 vgetvnode-debuglog-vio-20071228 LICENSE IPL10 provide a way to log otherwise unlogged VIO error cause commit 4d2c1d532bb44320afcf4debfee9ded403647e1e Author: Jeffrey Altman Date: Fri Dec 28 15:46:05 2007 +0000 windows-syncop-20071228 LICENSE MIT avoid a race condition between cm_SyncOpCheckContinue and cm_SyncOpDone that can leave a request on an scp stuck in the waiting state even though there are no other requests to wake it up. commit 33aeecd83f8ce670269868145648ae6e277cf3cb Author: Jeffrey Altman Date: Fri Dec 28 07:24:48 2007 +0000 windows-get-buffer-20071228 LICENSE MIT cm_BkgPrefetch() contained two errors. First, the loop at the top of the function that ensures that a cm_buf_t is allocated for each of the offset positions failed to actually obtain the buffer for the specified offset. Instead, it repeatedly obtained the buffer for the starting base address. Second, cm_GetBuffer() would reserve all of the buffers associated with the cm_scache_t even in the case where we already have a callback and the existing buffer has the proper data version number. In that situation reserving the buffers simply wastes valuable time. commit d942d97ed82b9f4b86fdea8443912ec64b28dd96 Author: Jeffrey Altman Date: Fri Dec 28 07:11:59 2007 +0000 windows-cell-aliases-20071228 LICENSE MIT Fix the lookup of cell aliases to: 1. avoid re-reading CellServDB each time a cell alias is specified 2. avoid reconstructing the vlserver list for the cell each time an alias is specified 3. permit aliases to be used when AFSDB records were used previously with the full cell name commit 7a1253d1d180716f2aace6e8c115f845fbfe003d Author: Jeffrey Altman Date: Fri Dec 28 07:07:53 2007 +0000 windows-bkg-daemon-threads-20071228 LICENSE MIT Reduce the default number of background daemon threads used for prefetch and store operations to one. Given the current implementation when more than one thread is allocated they step on each other's toe while fighting over locks. A better model might be to divide up threads based upon cells or volumes as a means of preventing contention. commit 1e262e133d2fa0464d6419b1acc6fd2c075f9dbd Author: Jeffrey Altman Date: Thu Dec 27 20:58:49 2007 +0000 windows-default-chunksize-20071227 LICENSE MIT Drop the default chunksize to 18 (256KB) from 20 (1MB) due to the increased propensity to timeout reads on slow network connections. commit 56a82598b19e4232b0095c2b5778d4571c8aa9b2 Author: Jeffrey Altman Date: Wed Dec 26 16:18:37 2007 +0000 windows-callback-restore-multi-cell-servers-20071226 LICENSE MIT The case of openafs.org and grand.central.org is a hideous abuse of the AFS cell name space. There are many negatives associated with trying to support two different cell names pointing at overlapping vlserver lists: (1) The CM can store duplicate entries for all of the data simply because the cell name that was used is different (2) If the CM attempts to optimize the data storage by aliasing or otherwise combining the cell names as part of one cm_cell_t object, then future attempts to separate the two cell names will require the destruction of the cache. (3) If the CM does not associate a callback revoke with a particular cell, then the status data associated with any entry that matches the revoked AFSFid will be discarded. For volume callbacks this can have a serious impact because volume IDs are not unique across cells and discarding status data for readonly volumes that are in use can result in a significant number of FetchStatus requests being sent to the associated file server. There are other issues as well involving authentication. The case of openafs.org advertising the vlserver addresses of grand.central.org should be considered a hack; a hack that the Windows client will no longer ensure will work. Additional debugging messages have been added to assist individuals attempting to debug why callback revokes do not appear to take affect when two cell names share the same vlserver data. commit b41b3bb52eaba52bba8fda0c49083322d6959238 Author: Jeffrey Altman Date: Tue Dec 25 23:05:17 2007 +0000 windows-pthread-20071225 LICENSE MIT The pthread_cond_timedwait/wait implementations were broken. Not only did they return the wrong error values but more importantly, they did not always return with the mutex locked. commit 6b1537b246732e4f7f67661d8230d051db8f3f8d Author: Jeffrey Altman Date: Tue Dec 25 22:59:06 2007 +0000 rx-event-handler-20071225 LICENSE MIT Update event_handler() for Windows. The return code of pthread_cond_timedwait() is not limited to 0 and -1 because 'errno' cannot be set. Instead of setting 'errno' the error code is returned directly by the function as the return code. This patch is only for debugging purposes to track the number of success, timeout, and other errors experienced by the routine. commit 7dc4925cd35036e7f7b448d15a291791cd025e86 Author: Jason Edgecombe Date: Tue Dec 25 22:22:22 2007 +0000 man-page-license-change-20071225 LICENSE BSD Update man pages submitted by Jason Edgecombe to the BSD license. commit 84ef02b0f392c761211adc7d5876217ad835c6c0 Author: Jason Edgecombe Date: Tue Dec 25 22:15:07 2007 +0000 man-page-misc-updates-20071225 LICENSE BSD Add some additional cross-references, add some missing man pages, fix a few references to the OpenAFS manuals, document the -live flag to vos move, and add an example for rxdebug. commit 9f97c5cf74358116a109a4982588d61164456714 Author: Andrew Deason Date: Tue Dec 25 22:02:19 2007 +0000 man-page-fileserver-debug-20071225 LICENSE BSD The file server debug flag is -d, not -debug. commit 69d62d59689c7cd9758177f1f23d3b60df3a8a40 Author: Jeffrey Altman Date: Tue Dec 25 21:58:51 2007 +0000 windows-callback-revoke-multi-cell-servers-20071225 LICENSE MIT Remove the callback revoke optimization that prevents a (vol,vn,uniq) tupple from invalidating entries from multiple cells. We cannot reliably determine the cell from the server because the server might be identified as belonging to more than one cell. For example, openafs.org and grand.central.org. commit b0bae13aec9acb944d5d6a64c11df857ffc40eb3 Author: Jeffrey Altman Date: Mon Dec 24 05:29:15 2007 +0000 windows-hold-server-mutex-for-vol-list-20071223 LICENSE MIT When walking or modifying the cm_server_vols_t associated with a given cm_server_t the mutex must be held. Otherwise, races can occur. commit 8a923a199d91aae6d1fc9bb6a2f1856fe5dbcb07 Author: Jeffrey Altman Date: Mon Dec 24 05:23:28 2007 +0000 windows-daemon-threads-shutdown-sync-20071223 LICENSE MIT Windows Error Reporting received crashes caused by a failure to synchronize the shutdown of the AFS client service with the background daemon threads. The daemon threads (cm_Daemon, cm_BkgDaemon+, cm_IPAddrDaemon) could be accessing data structures as they were being freed or unmapped. Add synchronization mechanisms to signal the termination of the threads with the shutdown of the service. commit 815cd6f19ec37330e7829506c1208c9426b3a41f Author: Jeffrey Altman Date: Mon Dec 24 05:17:50 2007 +0000 windows-update-volume-status-20071223 LICENSE MIT Refactor cm_UpdateVolumeStatus. Revise behavior to treat volid 0 as update the volume status for all volumes in the volume group. commit 1b90fc5329dc7dd2055ab9150e3709b2b2cfac06 Author: Jeffrey Altman Date: Mon Dec 24 05:14:11 2007 +0000 windows-server-lock-error-20071224 LICENSE MIT The cm_serverLock must be write locked to modify the refCount commit 150919d690eca9ee00d3ce549554a058662c360c Author: Jeffrey Altman Date: Sun Dec 23 04:51:59 2007 +0000 windows-volstat-and-vista-dfs-support-20071222 LICENSE MIT This patch completes the implementation of smb_ReceiveTran2GetDFSReferral() which is called by Vista even if we do not advertise the support of DFS referrals. It also adds DFS link mapping notifications to the volstat interface which can be used by volstat plug-ins to redirect requests to the dfs target path. Other miscellaneous items: (1) return EAS_NOT_SUPPORTED instead of EA length 0 and silently accepting but not storing EA data (2) Call cm_VolStatus_Service_Started() before smb initialization instead of afterwards (3) During directory enumeration and link assembly push the UNC path into the lower levels by storing references to the tidPath and the relative paths within the cm_req_t object. (4) During directory enumeration make absolutely sure that we do not reference an unallocated cm_dirEntry_t object (5) publish a prototype for cm_FollowMountPoint() (6) return ERROR_RETRY instead of BAD_NETWORK_PATH if the server returns VBUSY (7) return PATH_NOT_COVERED instead of BADSHARENAME for DfsLinks when a volstat plugin is in use commit bb77b085ff420d8b13c1a71b3144b6b31258ad3d Author: Jeffrey Altman Date: Sun Dec 23 04:15:33 2007 +0000 windows-freelance-scache-20071222 LICENSE MIT (1) remove a race condition caused by holding and releasing the cm_Freelance_Lock while using a pointer into a private freelance data structure (2) do not reference a localMountPoint object that is not allocated (3) properly assign the DFSLINK file type (4) update the buffer data versions when we update the contents of the stat cache object and its buffers to match the registry contents commit 111fb3a0a9525bb9d618dfa23cd1df3eb8eb61c5 Author: Jeffrey Altman Date: Sun Dec 23 03:43:49 2007 +0000 windows-pioctl-listlink-20071222 LICENSE MIT In the error case (1) reference the mountPointString instead of the output of cm_AssembleLink() which was not generated and (2) do not free memory and objects that were not allocated nor reference counted. commit 0421cb2afcc19f05e83a2e415c3e93df8516da98 Author: Jeffrey Altman Date: Sun Dec 23 03:38:45 2007 +0000 windows-freelance-20071222 LICENSE MIT remove unused next field in cm_localMountPoint_t commit 89203eb7065d7bd4e2a40f2afd5fab979ddf1008 Author: Jeffrey Altman Date: Sun Dec 23 03:25:56 2007 +0000 windows-fix-cb-expiration-20071222 LICENSE MIT corrects cb expiration that was broken by the osi_Time() -> time() change in delta windows-readonly-volume-callbacks-20071109 commit f54187bfc59797fe955e779d432d155ab3792022 Author: Derrick Brashear Date: Wed Dec 19 20:56:23 2007 +0000 darwin-dont-assert-on-lock-state-in-remove-20071219 LICENSE IPL10 remove panic due to lock being grabbedin another thread can't be accurately covered with this test on darwin, as e.g. proc_selfthread() is not in the KPI commit b072deb257da24746e8c1ec2b01ff3b779e866c8 Author: Derrick Brashear Date: Tue Dec 18 15:16:20 2007 +0000 fix-verbose-vos-dump-20071217 LICENSE IPL10 fix verbose vos dump to not put garbage in the stream when dumping to stdout commit 49a968ab68c9f0014d3d5801893c280d00696940 Author: Chaskiel M Grundman Date: Mon Dec 17 21:12:45 2007 +0000 shlibafsrpc-export-more-20071217 LICENSE IPL10 shlibafsauthent uses these, export them commit c2da8a61dda3063fea2dedfa83a8db3e45c9622e Author: Derrick Brashear Date: Mon Dec 17 18:02:58 2007 +0000 put-relnotes-on-head-20071217 LICENSE IPL10 add 1.4.6 relnotes, put reast on head commit f72145f79a2f9b04a042de93940456a41cb6e8b0 Author: Adam Megacz Date: Fri Dec 14 21:33:56 2007 +0000 java-admin-interface-updates-20071214 LICENSE IPL10 pdate java admin interface including support for 1.5 commit 77c86d6fd39cb8e21f2028292e682155dd587803 Author: Jeffrey Altman Date: Fri Dec 14 13:33:57 2007 +0000 windows-make-cleanup-20071214 LICENSE MIT Modify the dependencies for building the cbd and file server resource files and delete the resource files as part of 'clean'. commit 059031b3c6ff61340daad288deb378dc48cbd43a Author: Jeffrey Altman Date: Fri Dec 14 13:06:48 2007 +0000 emulate-vsyslog-20071214 LICENSE IPL10 Do not include vsyslog on Windows. Include syslog.h for the syslog() prototype. commit bf26bc9486de7831ae298b11e9ca33ac14ed92a7 Author: Derrick Brashear Date: Thu Dec 13 23:04:54 2007 +0000 aix-lam-aklog-set-token-name-20071213 LICENSE IPL10 so we set an afs id in the tokens here also commit ea3d49eaea3d825e5b328e0fbb4382fe5b0249cd Author: Derrick Brashear Date: Thu Dec 13 22:41:11 2007 +0000 emulate-vsyslog-20071213 LICENSE IPL10 aix 5.3 lacks vsyslog. the fixed buffer is poor, but... commit af3a4e78523596427235b45fc1892725a29bd1d6 Author: Derrick Brashear Date: Thu Dec 13 21:21:56 2007 +0000 aix-curpag-redux-20071213 LICENSE IPL10 add curpag() support for aix, based on work by tom keiser commit fcc8aa021f6305209fb8cf638d5446206029f581 Author: Simon Wilkinson Date: Thu Dec 13 20:04:41 2007 +0000 redhat-rpm-mockable-20071213 LICENSE IPL10 make us able to autobuild with mock. (may need krb5-devel outside the if krb5support; if we do more thought will be involved) commit 51d6d9cbbc5971623097624a58e400cf8ab5e5ab Author: Derrick Brashear Date: Thu Dec 13 19:46:06 2007 +0000 vcache-track-maxvcount-accurately-20071213 LICENSE IPL10 if we can alloc more vnodes, and we are looking for vlru cycles, a legit vnode is not indicative of a cycle. commit b33fb96fff39c421064d03ff058dde76f2aeed8b Author: Derrick Brashear Date: Thu Dec 13 19:18:06 2007 +0000 shutdown-cleanup-20071213 LICENSE IPL10 get rid of cold_shutdown; it's in afs_prototypes.h. log when we don't clean up memory commit 8f84815d0d8c9cc0b49eb29bfceeb03a7ae7f04f Author: Jeffrey Altman Date: Wed Dec 12 04:24:26 2007 +0000 windows-afslogon-null-pointer-deref-20071211 LICENSE MIT 'tokenUser' can be dereferenced when NULL if GetTokenInformation() fails. commit 319ad227d12b8ab301d464c2460be74f7a44ec4d Author: Mike Meffie Date: Tue Dec 11 21:28:26 2007 +0000 afs-serveriprank-return-void-20071211 LICENSE IPL10 can't return 0 from void function commit 2e057314d957a8854ee3c912715a916c3f002863 Author: Mike Meffie Date: Tue Dec 11 20:42:34 2007 +0000 vldb-check-dont-return-int-from-void-20071211 LICENSE IPL10 void functions shouldn't return 0 commit bc70f0f0abcc0843c23a0f63ee6b2ad6b842983d Author: Derrick Brashear Date: Tue Dec 11 16:25:55 2007 +0000 butc-no-retval-in-void-func-20071211 LICENSE IPL10 fix the build again commit 96ea2c11b486ea947e69bd440782560a99c93086 Author: Derrick Brashear Date: Tue Dec 11 14:53:30 2007 +0000 revert-clean-felater-when-rechaining-20071211 LICENSE IPL10 revert this for now, put it in all in one piece when we commit the ifdef'd out test code. commit 0f9529171c37c4ef1e76156da111d83d04b38505 Author: Derrick Brashear Date: Mon Dec 10 22:45:42 2007 +0000 ubik-avoid-truncating-live-database-during-recovery-20071210 LICENSE IPL10 FIXES 77183 currently we can truncate the live database while we are doing recovery. address that. commit f5fde5736f333e284a244467641f08727481b4ae Author: Derrick Brashear Date: Mon Dec 10 22:41:22 2007 +0000 afs-shutdown-cleanup-20071210 LICENSE IPL10 FIXES 74479 clean up allocated resources when we shut down commit e26be7b8e3c8ca73e6ef6640c7d2b8d8200a0c65 Author: Mike Meffie Date: Mon Dec 10 22:24:55 2007 +0000 find-cpp-from-slash-20071210 LICENSE IPL10 find cpp using a full path, not the user's path, at least for now commit 649194188e4af21370faa1bf1217a887adae2572 Author: Jeffrey Altman Date: Mon Dec 10 20:43:58 2007 +0000 windows-remove-out-of-date-buffers-from-hash-tables-20071210 LICENSE MIT When a cm_MergeStatus operation determines that the current data buffers are out of date, remove them from the buffer hash tables in order to speed the lookup of valid data buffers. commit ef5e9a4dd7a4977d7d9f41266f2a0c491720e387 Author: Jeffrey Altman Date: Mon Dec 10 20:33:34 2007 +0000 windows-buffers-20071210 LICENSE MIT after removing cm_buf_t objects from the hash tables, clear the HT list pointers to make debugging easier. when modifying data version values in buf_ForceDataVersion() grab a read lock on buf_globalLock instead of a write lock. A write lock is only required if the hash table linked lists are being modified. The dataVersion itself is protected by the cm_scache_t mx mutex being held. commit c057063abea93733170c1b31c91b52050a150a98 Author: Carsten Jacobi Date: Mon Dec 10 18:26:30 2007 +0000 pam-expires-setting-should-be-32bit-20071210 LICENSE IPL10 store as a 32 bit value explicitly so 32 bit routines don't leave garbage around here. commit 8114be0c6a311007125d6c01b9e0ee7a16b71c29 Author: Mike Meffie Date: Mon Dec 10 18:20:50 2007 +0000 uss-lex-more-forward-decls-20071210 LICENSE IPL10 forward declare this so picky compilers will do their jobs. commit c6db6a90bee37f91c56d1aa1c4ed5657c353b3a0 Author: Derrick Brashear Date: Sun Dec 9 23:33:42 2007 +0000 cnvldb-prototypes-20071209 LICENSE IPL10 forward declare these commit 40307b60236c8e43321a31ab524ec6edd61cbabf Author: Derrick Brashear Date: Sun Dec 9 06:05:51 2007 +0000 aklog-no-dummy-write-on-aix5-20071209 LICENSE IPL10 don't do the dummy write on aix5. we are better off actually working commit c0a04c21cf36e4c8e25be9703f715f30d1bf55a6 Author: Derrick Brashear Date: Sat Dec 8 17:57:33 2007 +0000 writedcache-enforce-xdcache-writelock-20071208 LICENSE IPL10 FIXES 59136 in order that the writes to CacheItems not be addled, we need to *actually* hold a *write* lock when we write. not even just read as the comment says. and certainly not none as was happening in the dir package. commit 55e581824fceea149b9a48ee928aa76e97c009a8 Author: Derrick Brashear Date: Sat Dec 8 17:44:00 2007 +0000 linux24-kernel-configure-test-20071208 LICENSE IPL10 on linux 2.4 the try kbuild macro needs to try harder to notice what symbols we don't have commit 68021a6f2bf692e20044bb932501112934a09bac Author: Jeffrey Altman Date: Fri Dec 7 21:32:53 2007 +0000 windows-wix-afslogon-20071207 LICENSE MIT Move afslogon.dll and afscpcc.exe to the OpenAFS\Client\Program directory commit ab939a6216161cd6afab74e60ca87d376145651c Author: Jeffrey Altman Date: Fri Dec 7 16:03:56 2007 +0000 windows-follow-backup-path-20071207 LICENSE MIT Add a registry value, FollowBackupPath, that provides the Windows cache manager with functionality equivalent to the UNIX afsd -backuptree option. commit 974ad01826f39c817834c6377cf2872177fa7031 Author: Jeffrey Altman Date: Wed Dec 5 20:38:38 2007 +0000 viced-cbstuff-20071205 LICENSE IPL10 Keep track of AddCallBack calls in cbstuff. Increment cbstuff.DeleteCallBacks after holding H_LOCK commit 946f416577914aef5b31e398994fb8876b4ee5e9 Author: Jeffrey Altman Date: Wed Dec 5 20:31:56 2007 +0000 cbd-20071205 LICENSE IPL10 Windows requires open() to be called with O_BINARY otherwise Ctrl-Z means EOF which breaks dumpfile processing. Be consistent about writing/reading time as afs_uint32 instead of writing as afs_uint32 and reading as time_t since time_t can be 32-bit or 64-bit depending on the platform. commit d13cd42cb4e0b2fe3f91565eac37dc3f3e6d3270 Author: Derrick Brashear Date: Tue Dec 4 21:08:10 2007 +0000 largefile-avoid-wraparound-write-to-old-server-20071204 LICENSE IPL10 FIXES 73720 apply analogous check that's in fileserver to clients writing to old servers commit 58dd384ba4020c924604ab612276948803333549 Author: Derrick Brashear Date: Tue Dec 4 21:01:12 2007 +0000 inode-convertro-dont-include-volser-code-in-viced-20071204 LICENSE IPL10 FIXES 77574 viced isn't an fssync client; avoid the convert volser code there commit ebbd12f3ab83eafa0d8cd6978a45a4cc0b248334 Author: Derrick Brashear Date: Tue Dec 4 20:39:18 2007 +0000 linux-nfs-translator-dont-lose-nfs-pag-on-write-20071204 LICENSE IPL10 avoid issue where nfs writes through the translator could become unpag'd because a background daemon came into play commit a342c531a24544988e1a2c2ad1de6d555787989d Author: Derrick Brashear Date: Tue Dec 4 20:18:50 2007 +0000 afsdb-avoid-cross-task-stack-use-20071204 LICENSE IPL10 really for aix, but simplified code universally. commit 1c33df3870bffd4aa2eaf43d8ec56a75a1a3cd0f Author: Jeffrey Altman Date: Tue Dec 4 15:44:56 2007 +0000 windows-giveupallcallbacks-20071204 LICENSE IPL10 Add a registry value, GiveUpAllCallBacks, that can be used to enable/disable the use of the GiveUpAllCallBacks RPC. Due to the fact that calling this RPC can destablize pre-1.4.6 file servers since they do not include DELTA giveupallcallbacks-locking-20071121, the default is being set to disabled. We can re-enable the functionality by default only after sufficient time has been given for orgs to update their file servers. commit 1daa2c0b4fd25f959f6436a9d9eb9a45b7cab379 Author: Tracy Di Marco White Date: Sat Dec 1 05:40:51 2007 +0000 nbsd-new-version-20071201 LICENSE IPL10 FIXES 75602 add support for new version(s) of netbsd commit f9fddc03ec2f36528953f5264263458bf730506e Author: Derrick Brashear Date: Fri Nov 30 19:13:38 2007 +0000 aix-pin-small-allocs-20071130 LICENSE IPL10 we assume the small alloc pool is pinned. maybe we should pin it. commit 8070286d6c9f4f99b7d77627fa2fedf042e47451 Author: Hartmut Reuter Date: Thu Nov 29 21:37:00 2007 +0000 namei-allow-ufs-20071129 LICENSE IPL10 allow ufs again for namei. oops. commit e260ccde93009f7536d25ff6a42dcc1d126f08ec Author: Jeffrey Altman Date: Thu Nov 29 20:53:53 2007 +0000 windows-aklog-no-panic-if-no-kfw-20071129 LICENSE MIT commit a6fd54900e9ac9f5bf2a419338341ad355639034 Author: Jeffrey Altman Date: Thu Nov 29 19:25:04 2007 +0000 viced-drop-core-on-shutdownandcore-20071129 LICENSE IPL10 FIXES 74708 when we call ShutDownAndCore, actually drop a core. commit 7515efb9c390089b4ad4563b939785c5c05793c5 Author: Jeffrey Altman Date: Thu Nov 29 18:40:12 2007 +0000 clean-felater-when-rechaining-20071129 LICENSE IPL10 FIXES 74708 in order that this not be continually rechained, clear this here; we are handling it now. commit 262d1d1c70222b8378109674cd5090f602c52971 Author: Derrick Brashear Date: Thu Nov 29 18:32:29 2007 +0000 zero-uio-on-zero-read-20071127 LICENSE IPL10 avoid leaking random data in a read of a 0 length object. commit 7da027754463f7040c89b6a04c35d13d5fbe31d3 Author: Jeffrey Altman Date: Thu Nov 29 16:10:24 2007 +0000 windows-volstat-headers-20071129 move the enum volstat definition to cm_volstat.h from cm_volume.h. fix the copyright. commit ee839a167eea5c0b3e2a45bf1e47b268419dc04e Author: Jeffrey Altman Date: Thu Nov 29 16:06:48 2007 +0000 windows-smb-out-of-memory-20071129 It turns out that LsaCallAuthenticationPackage can succeed but still fail with an extended error. The one case that we have seen reported is STATUS_NO_MEMORY which would be produced when the paging file is full. This could be a transient error that will be resolved after Windows increases the paging file size. Instead of crashing under this condition we should force the authentication to fail and permit the client to retry. WER 567093715-1-0405174244 commit baef5ba97f4d042d75fe1ac8e11325be459a3d9a Author: Jeffrey Altman Date: Thu Nov 29 16:00:19 2007 +0000 windows-daemon-shutdown-20071129 The cm_Daemon() thread did not check after each operation whether or not the service is in the process of shutting down. As a result the thread could access data, locks, etc. that had been freed by other threads. WER 572098933-1-0407879071 commit 1ee37a57d3d343b8d7a1ab26b6783d396624c856 Author: Jason Edgecombe Date: Thu Nov 29 05:05:37 2007 +0000 man-page-symlink-20071128 Add man pages for all the symlink commands (Windows-only). commit 6cd96f678e12570205d2cbf532b86219b1737c49 Author: Russ Allbery Date: Thu Nov 29 04:57:05 2007 +0000 man-page-vos-convertrotorw-fix-20071128 Don't say that inode file servers are only available on Solaris and AIX. commit 3be37f4d1ca1e3fae238e58d07708577d5653ae2 Author: Jason Edgecombe Date: Thu Nov 29 04:17:10 2007 +0000 man-page-fs-sysname-improvements-20071128 Update the fs sysname man page to document the behavior of multiple @sys values. commit f78f007dc593ec6948bf904d7903223bd6046081 Author: Jason Edgecombe Date: Thu Nov 29 03:54:44 2007 +0000 man-page-fs-rxstatpeer-20071128 New man page for fs rxstatpeer. commit a7291b33490ce62a9ea5b93fab268e3c669a6051 Author: Steven Jenkins Date: Thu Nov 29 03:32:52 2007 +0000 man-page-fileserver-auditlog-20071128 Remove duplicate -auditlog in the fileserver synopsis. commit 2ecef5038e81386a002740f6b0112330117c4f6e Author: Jason Edgecombe Date: Thu Nov 29 03:30:41 2007 +0000 man-page-additions-20071128 Add new man pages for vos convertROtoRW, vos copy, and read_tape and add a troubleshooting section to the fileserver man page. commit 5743116d700ce279cde3a8dee962757df509d557 Author: Russ Allbery Date: Thu Nov 29 02:56:13 2007 +0000 man-fs-uuid-tweaks-20071128 Some minor capitalization and formatting tweaks to the fs uuid man page. commit 031369cd322d5dae4d1e8284c104e69a903c7995 Author: Derrick Brashear Date: Wed Nov 28 05:03:03 2007 +0000 getpag-prototype-20071127 forward declare this function ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== returns void, but, whatever commit eee1f81821656ed85720523750b312eaf0dd71b4 Author: Mike Meffie Date: Tue Nov 27 20:44:47 2007 +0000 linux-try-kbuild-deal-with-old-modpost-20071127 the pre 2.6.20.1 modpost issued warnings and not errors for unresolvable symbols. not overly useful. commit 746aab982ae3b7b6e1fb8109e5e9892a1821d6ec Author: Derrick Brashear Date: Tue Nov 27 20:01:00 2007 +0000 macos-no-read-on-directories-20071127 thanks to quentin@mit.edu for pointing this out. no read() on directories commit 89261e8b84697f3b5158e197ca9946c6fe9f45ed Author: Marc Dionne Date: Tue Nov 27 19:26:42 2007 +0000 linux-hash-inodes-for-mmap-20071127 FIXES 78544 inodes are only added to the superblock dirty list if hashed. do so. commit 4172d60820fdf3375091b0a451e8d25809019d8d Author: Asanka Herath Date: Tue Nov 27 17:28:44 2007 +0000 windows-nim-afscred-double-free-20071127 fix a double free on error condition commit 3c401f4724bea0b39baabfb3e38168886925e358 Author: Derrick Brashear Date: Mon Nov 26 22:19:02 2007 +0000 redhat-cleanup-authlibs-correctly-20071126 when not packaging authlibs, correctly discard them commit 4f98eb48fccde9dd70708b2dd6b0903745d16b7a Author: Derrick Brashear Date: Mon Nov 26 22:10:34 2007 +0000 volprocs-alloc-vnode-instead-of-using-stack-20071126 don't use stack here; alloc memory for short term use commit 48bcb88ddc8fe7baa7a2b0f8decee7e704ad32ef Author: Rainer Toebbicke Date: Mon Nov 26 21:47:00 2007 +0000 namei-avoid-spurious-emfile-20071126 FIXES 77531 before we did not handle the fd cache runnign dry. "oops" commit da18bb147b25e62ed69c6f88fa6331161018d9fb Author: Christof Hanke Date: Mon Nov 26 21:03:31 2007 +0000 assorted-warning-cleanup-20071126 add missignheader files, missing return values, correct a few calls to printf commit 5d8c44bc09fde707dc6aaaf037b2c8805cce0ed1 Author: Christof Hanke Date: Mon Nov 26 20:38:14 2007 +0000 kauth-ubik-wrap-pad-requisite-args-out-20071126 of course, if Date is larger than 32 bits, the wrapper is broken anyway. we should really get rid of the wrapper commit b776352e3b824d7c733ef05a71eac85c025b290b Author: Derrick Brashear Date: Fri Nov 23 14:29:51 2007 +0000 enhance-afsdb-debugging-20071123 allow cmdebug to show locks on cells. add fstrace event for afsdb commit aa5c3518df8d73c2b0aa625e77179f33df97c2af Author: Sean O'Malley Date: Fri Nov 23 13:55:49 2007 +0000 krb5-klog-solaris-20071123 FIXES 77575 make this work on solaris commit af7cf697ef8c0a416251d3fbfd516738e14c290b Author: Marc Dionne Date: Fri Nov 23 13:37:24 2007 +0000 linux-2624-20071123 FIXES 77370 support linux 2.6.24 commit dda101f22d4690f2c7c8731740fd9676f2a85c66 Author: Derrick Brashear Date: Fri Nov 23 13:00:42 2007 +0000 macos-buildpkg-cleanup-cruft-20071123 don't leave the old dmg around since it makes a new one bomb commit b0b3565b69b0b8fda46b25e7bd73c5116b32d83e Author: Jeffrey Altman Date: Wed Nov 21 19:30:51 2007 +0000 giveupallcallbacks-locking-20071121 FIXES 74708 Hold H_LOCK across calls into GiveUpAllCallbacks_r commit 5d84c50e5eb754eb33de0e53eab3fd64d170bb36 Author: Jeffrey Altman Date: Wed Nov 14 17:18:25 2007 +0000 windows-dv-logging-20071114 64-bit data version logging updates commit 5d245327f057389950c30bb36af6d12f6f96c73a Author: Jeffrey Altman Date: Wed Nov 14 06:22:04 2007 +0000 windows-64bit-data-version-20071114 Add support for 64-bit AFSFetchStatus data version values commit 473b0345210c98a44cffb8c5de1d0da5980969f4 Author: Derrick Brashear Date: Wed Nov 14 04:34:53 2007 +0000 dafs-inode-convert-20071113 the dafs version of this commit b98b51185dbd46ef6d9ef0249b032bbc49d13bfb Author: Derrick Brashear Date: Tue Nov 13 22:15:03 2007 +0000 inode-convert-ro-to-rw-20071113 so this functionality works with inode fileserver, also. corrected abstraction from previous versions so vol and volser have correct bits. commit 524f749430e78edab581ad84978d13870911b6f8 Author: Derrick Brashear Date: Tue Nov 13 00:46:09 2007 +0000 redhat-spec-no-strip-20071112 suggested by simon. debuginfo support in rpmbuild strips for us. deal here. commit 606ce43066bf1d818a990982f9704a973371c456 Author: Simon Wilkinson Date: Tue Nov 13 00:29:31 2007 +0000 redhat-reunrevert-fedora-build-change-20071112 "oops" commit 9f284c66a9ad685eab201e480372633d538938b3 Author: Derrick Brashear Date: Tue Nov 13 00:00:57 2007 +0000 redhat-packaging-updates-20071112 FIXES 76890 various updates to deal with fedora 8 and remove obsolete stuff commit d284c0e7c11e8ee4755ac152e5e47d4abf304afc Author: Jeffrey Altman Date: Mon Nov 12 19:03:15 2007 +0000 viced-accurately-track-file-callbacks-20071112 FIXES 74708 this should fix the issue with cbfree being corrupted. a more exhaustive pointer-blunting patch should probably be pulled in, but, this is simple and obvious commit 8593c52c2787587110865287937750e51c48afa5 Author: Kevin McBride Date: Mon Nov 12 18:25:54 2007 +0000 autoconf-strip-debug-options-sanity-20071112 To prevent stripping, specify the '--disable-strip-binaries' option on the ./configure command line. fileserver and volserver are never stripped. When --enable-debug is specified, binaries will not be stripped by default. commit cd8311641fd32328dd1d8a07b1318ecb53726bd1 Author: Tom Keiser Date: Mon Nov 12 18:17:43 2007 +0000 dafs-optimize-shutdown-20071112 optimize shutdown case as is done elsewhere, for dafs. commit f2bff0e675a2ca0b583264d59d288c62636a06b8 Author: Jeffrey Altman Date: Mon Nov 12 03:24:59 2007 +0000 windows-readonly-volume-callbacks-20071111 disable the option by default. require the daemonCheckVolCBInterval registry value be set in order to activate it. do not renew .readonly volumes whose callbacks are less than 30 minutes old. commit e61efde3236b9cd09a09cb9e869b27a14b68c4ac Author: Russ Allbery Date: Mon Nov 12 00:12:28 2007 +0000 man-page-name-underscore-more-20071111 Missed fs apropos when fixing NAME entries to eliminate spaces. commit 6ef9f3933595e4fef5c4af334ab580dbb08212c3 Author: Russ Allbery Date: Sun Nov 11 22:54:56 2007 +0000 man-page-name-underscore-20071111 The NAME heading for man pages can't contain a space in the program side or the man pages won't index with some man implementations. commit b5935d47fb5b06c4f1c74c3671af4b1a481b8ab3 Author: Jeffrey Altman Date: Sat Nov 10 22:50:44 2007 +0000 windows-readonly-volume-callbacks-20071110 avoid a deadlock commit dd1535d31509d48d961085809c132b398edd80ff Author: Simon Wilkinson Date: Sat Nov 10 20:13:27 2007 +0000 libafsrpc-makefile-fix-20071110 FIXES 76836 fix double / in makefile commit 76c886b574b7d21db2557872be8af8e6ca549f34 Author: Dan Hyde Date: Sat Nov 10 00:33:41 2007 +0000 viced-missing-lock-20071109 FIXES 76713 Add missing lock that needs to protect an in use 'host' from having HOSTDELETED added to the hostFlags and HWNO_INPROGRESS removed. commit 578e0d957547e4ac7f39b0559e166fd9eea5f150 Author: Jeffrey Altman Date: Sat Nov 10 00:18:11 2007 +0000 cmdebug-human-readable-expiration-time-20071109 add -ctime parameter which produces human readable expiration times. Doesn't work with OpenAFS for Windows prior to 1.5.28 because time() was not used in those versions for tracking expiration times. commit b43d778e9342dd19c010354cf6db854fdf1f7d22 Author: Jeffrey Altman Date: Sat Nov 10 00:14:26 2007 +0000 windows-readonly-volume-callbacks-20071109 A .readonly volume callback applies to the entire volume. Track it in the cm_volume_t cbExpiresRO field and apply it to all cm_scache_t objects with valid callbacks that are associated with that volume upon each daemon callback check. This will prevent premature callback expiration. Also, attempt to automatically refresh the callbacks every 30 minutes by obtaining a callback on the volume root. This value is configurable with the "daemonCheckVolCBInterval" registry value. Change from osi_Time() to time() for expiration values in order to permit conversion to human readable values in cmdebug. commit 15a52f254b8c079a1e640e18ce90508861ec5d96 Author: Derrick Brashear Date: Fri Nov 9 20:15:46 2007 +0000 clean-platform-20071109 clean platform dir commit 10ff33e6092a63107600b3b58c44c8d15849bbe6 Author: Derrick Brashear Date: Fri Nov 9 19:47:18 2007 +0000 macos-packaging-updates-20071109 make the readme correct. make dmgs which have a useful name commit 757bdb092ec4e1db9c7dc949499cc761982bd105 Author: Derrick Brashear Date: Fri Nov 9 19:18:49 2007 +0000 hpux11-thread-lock-tracking-20071109 do this for hpux also commit bb900e97df905c9805d9e7dc53a9303c671cf819 Author: Derrick Brashear Date: Thu Nov 8 14:38:48 2007 +0000 darwin-vfs-context-pullback-20071108 again, commit fix we have in 1.4 commit 7f8f251c3f252e352096f972e71c93db5cd9d3d9 Author: Derrick Brashear Date: Thu Nov 8 14:26:47 2007 +0000 reconvert-aklog-to-afs-com-err-20071108 make this match what we're shipping in 1.4 commit 277c37f48c8126ba9cb986ffc7361fcb98e2bbf2 Author: Derrick Brashear Date: Thu Nov 8 14:21:06 2007 +0000 aix5-revert-kcred-20071108 pull this back to 1.5 and head commit 044b90beb46177691fd05e08d552a37a48ad2ac8 Author: Derrick Brashear Date: Wed Nov 7 04:23:47 2007 +0000 shutdown-cleanup-not-yet-20071106 commit ad30730abd77fa489a6d3777e26621357724af9f Author: Jeffrey Altman Date: Wed Nov 7 04:01:36 2007 +0000 linux-nsec-timestamp-zero-20071106 don't leave garbage in nsec commit 1951d7d6c773aead0ea6e9d120e23d15fee4a29f Author: Anders Kaseorg Date: Tue Nov 6 18:30:19 2007 +0000 linux-splice-support-20071106 support splice in kernels new enough to support it (sendfile is deprecated) commit e06a144f33347bcac29131cd450d828c2803b9c0 Author: Derrick Brashear Date: Mon Nov 5 22:09:12 2007 +0000 aklog-no-kimpersonate-in-more-cases-20071105 aix's NAS kerberos can't support kimpersonate. deal commit bf7787ba99d5cae9a9413ba59dd4c01996a6d557 Author: Derrick Brashear Date: Mon Nov 5 21:43:00 2007 +0000 krb5-klog-no-err-table-yet-20071105 right now we don't have this everywhere, until we reorder libraries, and test usefully with configure, forget it. commit 564be8601c1447b85984eb3773b48ccaa22b4343 Author: Thomas Mueller Date: Mon Nov 5 20:27:24 2007 +0000 cbd-use-callback-size-for-callbacks-20071105 FIXES 76408 cast correctly commit 55149d5e2b69cd6dfa7f6fd3d02e0d488b3fd69d Author: Jeffrey Altman Date: Mon Nov 5 18:25:33 2007 +0000 windows-bplus-tree-20071105 Migrate search key into thread local storage commit 981f984b2dd675bab31d5d0374592c9e0fa12bbb Author: Jeffrey Altman Date: Mon Nov 5 18:23:30 2007 +0000 windows-afsd-notification-20071105 fidp->cell is not a pointer commit 89ac3ec2f68db045cf719d619eea1fb97a6364a3 Author: Jeffrey Altman Date: Mon Nov 5 00:23:54 2007 +0000 windows-afsd-notification-20071104 the difference between osi_assert() and osi_assertx() is whether or not a description is specified as part of the call. When no message is specified afsd_notifier() is called with a NULL msgp parameter. This results in a null pointer dereference during the EventLog() call. As a result, none of the information describing the assertion is written to the log file. This commit sets a default message for use when no other message is provided and it replaces all calls to osi_assert with osi_assertx and adds descriptions. commit bc7a0be8eb24f5347b8a5b51067b15270aa84691 Author: Jeffrey Altman Date: Mon Nov 5 00:16:58 2007 +0000 windows-osi-lock-assert-msg-20071104 modify lock_AssertXXX macros to call osi_assertx() and provide a descriptive message. commit 45e2d81aa3f62927adc85e4e23daf511478829e4 Author: Asanka Herath Date: Sat Nov 3 16:31:50 2007 +0000 windows-scache-syncop-waiters-20071103 One of the issues that has become a serious problem since the addition of the local directory updates is that although cm_SyncOp synchronizes operations, it does not preserve the order of requests. This has always been a problem in that it has been possible for a request to fail to complete due to its worker thread's bad luck. When a request takes longer than the Windows SMB Redirector's timeout, the SMB Redirector tears down the SMB virtual circuit. When using the local directory updates it is really important that the directory update operations complete in the order that they were sent to the file server. If they don't, then the local directory state and the file server state will not match and the local directory state must be discarded which in turn forces a new read of the entire directory contents over the network. This patch adds a new cm_scache_waiter_t object that is used to store the current thread, buffer, and syncop flags within a waiters queue on each cm_scache_t object. If a thread is forced to sleep in cm_SyncOp, upon waking it will check to see if there are any other threads waiting that are attempting to perform a similar task ahead of it in the queue. If yes, the thread goes back to sleep. If not, it goes ahead and enters the cm_SyncOp conflict resolution block. This patch has the additional side effect of reducing the number of competing threads that must obtain the cm_scache_t mutex and process the cm_SyncOp conflict resolution block. As a result, the overall CPU utilization of the service and the clock time associated with processing requests will be reduced. commit 2c45d9ec9fc888c2c6eed46538fe4a9c440e3c8c Author: Jeffrey Altman Date: Sat Nov 3 16:18:14 2007 +0000 windows-dir-20071103 Reorganize the locking for cm_BeginDirOp and cm_EndDirOp. There are a number of locations where locks are obtained, dropped, and reobtained. This reorganization attempts to accomplish several things: (1) be optimistic for the most common case so it will be fast (2) add consistency checks after each location where locks are dropped and re-obtained. If we lose a race in cm_BeginDirOp and the bplus tree is out of date, retry until we get to a consistent state that we can use. (3) Ensure that all operations take place with the correct locks. commit ef6684d005b3858dd6a1a94deee48b4bbd167932 Author: Jeffrey Altman Date: Sat Nov 3 16:08:03 2007 +0000 windows-buf-20071103 assert that the cm_scache_t mutex is held when calling buf_ForceDataVersion(). commit e4ddca6854f7bd4b4ce153b2377bb6ca31f44b8f Author: Jeffrey Altman Date: Sat Nov 3 16:05:43 2007 +0000 windows-bplus-tree-20071103 rename findNode to leafNode in bplus_Lookup replace all OutputDebugString calls with osi_LogX calls modify bestMatch to special case the return values for leaf nodes. If an entry is above or below the values available in the leaf node return BTLOWER or BTUPPER instead of BTERROR. In insert and delete operations check for BTLOWER/BTUPPER and isleaf, if true convert to either slot 0 or Max and perform the insertion. This produces easier to read code when performing lookups. commit a08f0f4dc05890147eb58d8420ada45d2bf69864 Author: Jeffrey Hutzelman Date: Sat Nov 3 15:59:12 2007 +0000 windows-cellservdb-20071103 GCO Public CellServDB 25 Oct 2007 commit 75729fa4ae564f1c5e9efb6f387840ab4b24263f Author: Jeffrey Altman Date: Sat Nov 3 01:05:53 2007 +0000 windows-install-des-prototypes-20071102 required by auth-getkey-prototyping-20071102 commit 32828680ae0342b91bea9fc2c4ecceb25510d7f3 Author: Derrick Brashear Date: Fri Nov 2 18:01:32 2007 +0000 auth-getkey-prototyping-20071102 make this sane commit 6b5146db5b111aca5ab0b3f6423f67fb01303627 Author: Ken Raeburn Date: Thu Nov 1 19:12:38 2007 +0000 viced-new-host-reup-h-lock-20071101 FIXES 69384 don't leave lock dropped commit 20a837c5cc0a093b3c74622056cca9f3f561bd6b Author: Dale Ghent Date: Thu Nov 1 17:05:33 2007 +0000 solaris-cc-deal-with-new-64-bit-arch-specifier-20071101 FIXES 75908 switch from -xmarch=amd64 to -m64 commit 7a0df48baf351eb2aaa2b6c4da0054d111facdb9 Author: Dale Ghent Date: Thu Nov 1 16:57:26 2007 +0000 solaris-nevada-update-20071101 FIXES 75896 update for current solaris nevada commit 089a02bcbc9df2090c275e5620248f478be1e286 Author: Simon Wilkinson Date: Thu Nov 1 16:09:22 2007 +0000 auth-cleanup-20071101 kill warnings in auth directory commit 8b8e0935e474cc2f79638b97134fa9e2d55adee8 Author: Simon Wilkinson Date: Thu Nov 1 15:58:59 2007 +0000 rxgen-ansi-again-20071101 another look at lettign rxgen do ansification commit eea1cb08145b2669384b2380e0878067f826d3dd Author: Tom Keiser Date: Thu Nov 1 14:59:38 2007 +0000 dafs-salvage-deal-with-clones-20071101 FIXES 75591 cope with trying to salvage a clone correctly commit c5678a4af78305cac2246480cc0c038655db324d Author: Chaskiel M Grundman Date: Thu Nov 1 03:23:09 2007 +0000 linux-afs-unlinked-file-dentry-flagging-20071031 fix case: perl -e 'open FOO, ">foo"; unlink(foo); @stat = stat(FOO); print "inode for foo(unlinked) is $stat[1]\n"; system("/bin/ls -ali | grep $stat[1]");' commit 8214014855be3fb99c00c23400a2a3325b2b4a57 Author: Simon Wilkinson Date: Wed Oct 31 22:31:38 2007 +0000 more-anonymous-pointer-cleanup-20071031 more char*->void* conversion commit 27ce37c7a0ea23c46c72484719697a900ac0a714 Author: Jeffrey Altman Date: Wed Oct 31 15:33:27 2007 +0000 windows-btree-20071031 Add additional validation and error handling code after each call to getSlot(). If an invalid slot is returned, return NONODE. If the invalid slot is returned when extracting a data node, invalidate the tree. Modify compareKeys() to always perform a case-insensitive comparison and only perform a case sensistive comparison if the case-insensitive one matches. This ensures the ordering is consistently reported. Add lock assertions to ensure that all calls are being performed with the correct locks being held. There have been some crash reports that provide stack data that does not appear to be possible unless there is a race. However, there are no obvious locations where the race is taking place and the test suite indicates that all of the correct locks are being held. We shall see what happens in the field. For consistency replace all calls to findKey in which the range is (1,numentries) with calls to getSlot(). Optimize the depth search loop by testing the slot value in the for statement instead of forcing the loop to be broken later. commit cf0d1393f4df2c0a8840aa00db05de7bd221c275 Author: Jeffrey Altman Date: Wed Oct 31 15:23:42 2007 +0000 windows-begindirop-20071031 Avoid a race condition in cm_BeginDirOp() caused by the failure to hold the cm_scache_t mutex while copying status data from the scp to the dirop commit ff4c519c789af1c4b126d926dd94f3efab1ebd14 Author: Jeffrey Altman Date: Wed Oct 31 15:20:14 2007 +0000 windows-cm_analyze-ewouldblock-20071031 Add support for EWOULDBLOCK to cm_Analyze. If the file server returns EWOULDBLOCK, retry the request every two seconds for up to the RDRtimeout. commit d16d5c031274e05ea27f12965e094ae42d8af9e5 Author: Jeffrey Altman Date: Wed Oct 31 15:18:10 2007 +0000 windows-uaewouldblock-20071031 Reorganize the order of the includes to ensure that EWOULDBLOCK is not assigned the same value as EIO. commit 3e1646fed23cb58a7220e622aeb8afd519bb9840 Author: Simon Wilkinson Date: Wed Oct 31 12:36:33 2007 +0000 util-cleanup-20071031 kill the warnings in src/util commit 3f449eb48eb0f4069062401a6a27f7481c0e88d3 Author: Simon Wilkinson Date: Wed Oct 31 04:20:33 2007 +0000 openafs-bozo-varargs-20071031 convert bozo to be prototypable commit 855e6442615ad2c42ca8f485d8a7efbcdb8f2105 Author: Simon Wilkinson Date: Wed Oct 31 04:05:27 2007 +0000 openafs-void-star-pointers-20071031 convert anonymous pointers from char* to void* commit 7d05bd439e144aa3bc5fd68908d1a359182897b0 Author: Simon Wilkinson Date: Tue Oct 30 15:10:37 2007 +0000 openafs-string-header-cleanup-20071030 include only what we need commit 7fe8131c049186e8340890a1effdf109d87f0611 Author: Simon Wilkinson Date: Tue Oct 30 03:53:08 2007 +0000 redhat-packaging-update-20071029 update rpm packaging stuff for what shipped in 1.4.5 commit 5a0dfa46f0a02f2c23fc187ab71745fa5cf21964 Author: Jim Rees Date: Fri Oct 26 17:41:54 2007 +0000 update-bsd-readme-20071026 Update build info for Open/FreeBSD. commit 1b3ecae23c87a0d97b561169ca33a6e7eca449ee Author: Simon Wilkinson Date: Fri Oct 26 17:20:22 2007 +0000 redhat-fedora-build-driver-20071026 driver script for fedora builds commit 2ced26c8badb79a81152523bbfb4ef2cc476cb03 Author: Derrick Brashear Date: Fri Oct 26 17:09:40 2007 +0000 redhat-spec-fix-hugemem-modpath-20071026 make this match other kernsls commit ed42d1f71a9c4b2f1dd74227fafce763d5e30ea9 Author: Derrick Brashear Date: Thu Oct 25 06:19:17 2007 +0000 release-notes-1-4-5-20071025 release notes for 1.4.5 commit fb7595ad1d31c5ccafa18de854f2bf8bc8c067de Author: Jeffrey Altman Date: Thu Oct 25 05:47:23 2007 +0000 windows-aclent-remove-extraneous-code-20071024 Microsoft provided a dump showing cm_data.aclLRUEndp == NULL in GetFreeACLEnt(). Couldn't find any reason why that would be true. However, there is extraneous code that manipulates the value of aclLRUEndp when it should be left to osi_QRemoveHT() to update the pointer values. Also add an additional explicit test for aclLRUEndp == NULL in GetFreeACLEnt(). commit 511aed14e0d18aa8c3a9a3742d79443912a4d9ff Author: Derrick Brashear Date: Thu Oct 25 04:42:07 2007 +0000 macos-installer-crap-20071025 put it back the way it was commit d78b844133549b530273fc7ad1ea376d582985d9 Author: Simon Wilkinson Date: Wed Oct 24 16:44:26 2007 +0000 linux-nfstrans-20071024 FIXES 75233 better track changes so we can build an nfstranslator module for new linux kernels commit 1d9ba682a5533bb720ef033287f78cff467aac11 Author: Dan Hyde Date: Wed Oct 24 16:33:31 2007 +0000 cblater-bitmask-bug-20071024 FIXES 75304 add missing () commit 3973d822379ca3af99db43d34d8d3468740cf5a7 Author: Derrick Brashear Date: Wed Oct 24 06:40:12 2007 +0000 darwin-allow-finder-to-unlink-rsrc-files-20071024 finder tries hard to clean up resource fork files it creates when you drop something in a dropbox that don't then get updates. let it think it won commit f814c8a9636b2939da9d0f17de4d71c6fd23ae6c Author: Chaskiel M Grundman Date: Wed Oct 24 06:25:46 2007 +0000 finder-and-tiger-cp-deal-with-dropboxes-20071024 FIXES 69363 this way copying finishes commit 57b28bb8eed956e1fe27cef81efd4cb30e63837d Author: Jeffrey Altman Date: Wed Oct 24 04:49:07 2007 +0000 windows-wix-nsis-uninstall-20071023 At somepoint windows installer broke the use of the 'file' RegistrySearch type. Instead of returning the full file name path we are only getting the directory. Switch to using the 'raw' type since we know we aren't prefixing the file name with a hash. commit 15f6e3170ce8e0c6f8e92f1fe046e2293cf8e833 Author: Mike Meffie Date: Tue Oct 23 23:36:06 2007 +0000 afs-shutdown-free-resources-20071023 try hard to free resources commit 3b3ccef28eb19079e73f78779e2778d3aa44bb83 Author: Derrick Brashear Date: Tue Oct 23 18:37:58 2007 +0000 darwin-uio-64-20071023 use the 64 bit awareness in the KPI commit 66a19a512e2a015b39089343288881a108b8d637 Author: Jason Edgecombe Date: Tue Oct 23 17:59:16 2007 +0000 pod-man-fs-uuid-20071023 FIXES 75175 add man page for fs uuid commit 4526c6a4f7e6f627249580cac0ba9373735ae667 Author: Derrick Brashear Date: Tue Oct 23 15:28:22 2007 +0000 darwin-afsd-cleanup-power-notification-nicely-20071023 don't drop a core on shutdown commit 79e51892fe1d6fe115a9ae6301f4553e6b6dc07c Author: Derrick Brashear Date: Tue Oct 23 15:19:07 2007 +0000 vos-restore-check-doesnt-apply-to-pipes-20071023 as pointed out by hung pham commit 6aaca73002214ff8b7a757322a9bffa3d5af0e3e Author: Derrick Brashear Date: Tue Oct 23 01:30:03 2007 +0000 darwin-modify-cp-workaround-20071022 more work will be needed to fool finder into just copying the d**n file, since it's checking too hard. commit 4456aa773929fa959e998058bfafc14d6309ff49 Author: Derrick Brashear Date: Tue Oct 23 01:02:39 2007 +0000 change-default-probeint-for-rfc4787-20071022 an RFC compliant port mapping device guarantees less time than we previously probed. commit d0285a2193de9868024eb0f432a495bd1802663f Author: Simon Wilkinson Date: Mon Oct 22 18:29:28 2007 +0000 fssync-poll-interface-20071022 FIXES 74708 support a poll interface otherwise, the fd setsize can screw with us commit e25e21e909c5684025a1c6066dedaffa2666c3c7 Author: Simon Wilkinson Date: Mon Oct 22 14:21:26 2007 +0000 cpp-avoid-cc-E-20071022 finding the right cpp is good. having it not be cc -E is better commit fd1bf06004bc698242d8ceec88126384bba8f30f Author: Jeffrey Altman Date: Mon Oct 22 04:32:09 2007 +0000 windows-ntstatus-warnings-20071021 suppress warnings caused by multiple definitions of NTSTATUS values commit f90153625efee1e5589df5e6b66a1162e07ddbfa Author: Jeffrey Altman Date: Mon Oct 22 04:27:14 2007 +0000 windows-del-symlink-20071021 The cmd.exe "del" command operates by opening a file and then setting the file disposition to delete on close followed by closing the file. When the filename is a symlink, the smb_fid_t scp refers to the final destination object and not the symlink. In smb_CloseFid() the correct object would be removed from the directory by name, but the wrong cm_scache_t would be marked deleted. This would result in subsequent references to the target file being considered invalid. Fix it by looking up the cm_scache_t of the symlink prior to performing the deletion. commit 20cfc16e3d6d874a6a21f6ed68ff904dd45142d5 Author: Jeffrey Altman Date: Sat Oct 20 04:58:40 2007 +0000 windows-registry-OfflineReadOnlyIsValid-20071019 Add registry value "OfflineReadOnlyIsValid" option. When set to non-zero value, an offline or down read only volume will be treated as if it has a valid callback even if it doesn't. commit 6122c757e1902baabc35d0ce0f6de336c2576b22 Author: Arno Schuring Date: Sat Oct 20 01:20:51 2007 +0000 cpp-autoconf-located-20071019 let autoconf find cpp commit 7e752ba085729991101782fe40f9db8c6f384734 Author: Derrick Brashear Date: Fri Oct 19 21:37:15 2007 +0000 darwin80-dnlc-dont-return-deadvnodes-20071019 FIXES 41550 obvious. if we are going to be like GetVCache, we should commit 05ee11d3155489bf28ca35b8b1ea4f32c97bf76b Author: Jeffrey Altman Date: Fri Oct 19 05:25:39 2007 +0000 windows-pioctl-parse-path-20071018 cm_ParseIoctlPath() moves the ioctlp->inDatap past the ioctl path to the next data value if there is one. Make sure we move the pointer before we alter the contents of the buffer. Otherwise, the caller uses the wrong string for its next data blob. commit 53baa78733c01dfcf842a7d8339bc3e8c55d517e Author: Jeffrey Altman Date: Thu Oct 18 23:06:35 2007 +0000 windows-pioctl-error-codes-20071018 add knowledge of new cm error codes commit 91855b82c75f7a9d840eb7e47663dd2c41eb561b Author: Jeffrey Altman Date: Thu Oct 18 06:27:40 2007 +0000 windows-freelance-symlink-20071018 More tweaking of the IoctlPathParsing code. Add special handling for many more pioctl operations performed on the Freelance root.afs volume. Add informative error values for symlink freelance operations. commit 8598b81a6904e4a7d3436d5545fdfd7f1ee99890 Author: Jeffrey Altman Date: Thu Oct 18 06:24:39 2007 +0000 windows-smb-20071018 refactoring, suppression of duplicate status value definition warnings, and removal of old pattern matching code commit deced1c9328ee5451c7f6927afb5b08b5d9e4ed4 Author: Jeffrey Altman Date: Thu Oct 18 06:20:08 2007 +0000 windows-afskfw-20071018 Add SOFTWARE\OpenAFS\Client AcceptDottedPrincipalNames registry value to control whether the use of Kerberos v5 principal names with dots in the first component are permitted. commit 930f1d7ad79b9fbc6f329eb85d84a7263b8908d6 Author: Derrick Brashear Date: Thu Oct 18 05:11:16 2007 +0000 redhat-spec-require-bison-flex-20071018 require everything we need to build commit bc1cc5a65b4096d8d489c1d20e0cb3a6f8b5b556 Author: Derrick Brashear Date: Thu Oct 18 05:02:42 2007 +0000 redhat-packaging-updates-20071018 make the buildall script know centos and new fedora; make the spec file include it commit d8faa623f7ae0c26efd9923953f10b80eaed8042 Author: Derrick Brashear Date: Wed Oct 17 21:32:38 2007 +0000 darwin-fsref-other-races-20071017 FIXES 41550 not clear this is exactly correct but testing seems to vet it. commit 49630f29571b5d602e8d57aa1b48e3fe710e2a53 Author: Chaskiel M Grundman Date: Wed Oct 17 18:16:19 2007 +0000 darwin-finalizevnode-get-vnode-inside-lock-20071017 FIXES 41550 the ovp initialization should happen while we have the vnode locked, regardless. commit eac13cbb48a95170a310dedb5d7efd1eeb4350b3 Author: Derrick Brashear Date: Wed Oct 17 15:32:50 2007 +0000 afs-shutdown-free-resources-20071017 try hard to free resources commit 30193a043e0b3d965139ec92227f73ce31f24403 Author: Derrick Brashear Date: Wed Oct 17 04:46:19 2007 +0000 darwin90-disk-cache-20071016 FIXES 43303 don't break memcache, also commit 62689b013451c38843d369ae86e46ab37099648a Author: Douglas Engert Date: Tue Oct 16 22:55:38 2007 +0000 translator-sysnamelist-bugfix-20071016 FIXES 74478 fix sysname list support bug when the list is empty commit 89c8d7e125a5b46f57081000fcbc698eba9e5daa Author: Jeffrey Altman Date: Tue Oct 16 18:24:31 2007 +0000 windows-fs-uuid-20071016 do not require afs client administrator access to display the current Uuid value. commit 7b2fc6e8d53d1ca8f111cd757e723ab27e9a31d9 Author: Jason Edgecombe Date: Tue Oct 16 18:18:28 2007 +0000 fs-uuid-20071016 FIXES 74473 Change "fs uuid" to "fs uuid -generate" where "-generate" is a required parameter. This command requires root access to execute it. Unlike the Windows variant, the UNIX version does not yet support displaying the current UUID to the user. When this functionality is added, "-generate" should become an optional parameter. commit b8ecf28e22b24cf220bbae8042ca3c2d16c7e080 Author: Jeffrey Altman Date: Tue Oct 16 17:55:10 2007 +0000 restore-20071016 FIXES 74531 afs_com_err() was called without specifying the error code. commit 38719a218c44dd78300afe179bf051e3fbd08e0f Author: Derrick Brashear Date: Mon Oct 15 20:19:03 2007 +0000 darwin-access-avoid-confusing-cp-20071015 FIXES 69363 it wants EPERM; EACCES, and it just retries forever. "no means no. now go away" commit d66f71cc08fe1d992e4354938a8968cae03d1ce0 Author: Derrick Brashear Date: Mon Oct 15 18:23:54 2007 +0000 darwin-install-fstrace-catalog-20071015 fstrace needs the message catalog to be useful. install it. commit 38a653ea0d4d3ba8307f50c1ba6637b10d90d176 Author: Derrick Brashear Date: Mon Oct 15 18:00:58 2007 +0000 redhat-spec-no-kdump-really-20071015 make really, really sure it's not there commit 14e71a12b6da596880debc21c224b94c33a5b6f2 Author: Rainer Toebbicke Date: Mon Oct 15 15:13:42 2007 +0000 volser-return-extended-stats-to-callers-20071015 FIXES 74398 make sure when we roll over stats we return the new values commit 707c164a6fb30dad05333c7346cc7d3970270445 Author: Jeffrey Altman Date: Mon Oct 15 04:18:30 2007 +0000 windows-clean-eventlog-20071014 delete AFS_component_version_number.h in the lang subdirectory commit 8a50a53fdf1ec2374bb5b68cfa42b6a3aa3ee84c Author: Jeffrey Altman Date: Mon Oct 15 03:32:12 2007 +0000 windows-pioctl-two-20071014 Two more locations where an intermediary path of length zero should be ignored. commit 7504c664028a3df8bbf5ba682c8b39a8fc05aae2 Author: Jeffrey Altman Date: Sun Oct 14 06:54:06 2007 +0000 windows-pioctl-20071014 do not parse an intermediary path if the path length is 0 commit b6cfa8d6c8e193edafc607a34e338cc62c386a51 Author: Derek Atkins Date: Fri Oct 12 05:28:55 2007 +0000 rpm-kmodule-patch-20071012 install the openafs module in the kernel module area, in rpms commit 7832148ae0e8c9f17a2ac2eb879c7b2fdf69403e Author: Marc Dionne Date: Thu Oct 11 18:44:53 2007 +0000 gcc42-integer-overflow-fix-20071007 fix issue where gcc 4.2 compiled kernel modules were breaking on linux ==================== This delta was composed from multiple commits as part of the CVS->Git migration. The checkin message with each commit was inconsistent. The following are the additional commit messages. ==================== with fix from Hans-Werner Pulsen ==================== with fix from Hans-Werner Pulsen commit e1b1f4655f537427369c996b22816b0e5426da82 Author: Derrick Brashear Date: Thu Oct 11 17:51:56 2007 +0000 macos-version-generation-20071011 make release time simpler commit c4ad02b69aae927f1444f7386c040d48ee7abc17 Author: Simon Wilkinson Date: Thu Oct 11 17:38:56 2007 +0000 rpm-files-update-20071011 updates for the specfile and rpm generation commit 4a80289db728d5a4c41144fd7ef8a567f30263d2 Author: Jeffrey Altman Date: Wed Oct 10 19:50:25 2007 +0000 windows-freelance-pioctl-two-20071010 explicitly process the last component of the path separately and do not follow symlinks or chase mountpoints on the last component. commit 63e1761b992e25fa305e6d621b31bd1113f5cbe7 Author: Derrick Brashear Date: Wed Oct 10 18:38:45 2007 +0000 darwin90-disk-cache-20071010 FIXES 43303 support disk cache in darwin90 commit b7030276f7f3a2df538e40b842f04219b23b2ee4 Author: Jeffrey Altman Date: Wed Oct 10 17:05:47 2007 +0000 windows-build-xstat-20071010 build xstat directory commit 9991a731e01426909fed050c1e292bb8a859978c Author: Jeffrey Altman Date: Wed Oct 10 16:43:30 2007 +0000 windows-clean-eventlog-20071010 clean eventlog/lang/AFS_component_version_number.h commit 58627b15ebae4ecd6e574d11e1848fab53ffc2d1 Author: Jeffrey Altman Date: Wed Oct 10 16:37:25 2007 +0000 windows-installer-wix-20071010 Later versions of the wix toolset require that all variables be defined with a value. commit fae48bb39bbcb2366bc4087d7a67126c9d21c525 Author: Jeffrey Altman Date: Wed Oct 10 16:20:29 2007 +0000 windows-freelance-pioctl-20071010 pioctl commands were failing with CM_ERROR_NOSUCHCELL because the Freelance cell object was not being added to the Cell Name and ID hash tables. ParseIoctlPath was not consistently returning the FID of the specified symlink or mount point object. The was still one more case in which CM_FLAG_FOLLOW was being specified left over from windows-parse-ioctl-path-20070629. Changed the use of CM_FLAG_FOLLOW into a 'follow' variable to ease testing and permit easy migration to adding a 'follow' parameter to the function. RXAFS_GetVolumeStatus is always going to fail for Freelance volumes. Fake the response data. UpdateVolume() was performing the wrong test for Freelance volumes. Freelance volumes should not be marked offline even though they have no servers. commit 604838e7d43f4cd65d4eb70208bea57db2e93026 Author: Derrick Brashear Date: Tue Oct 9 22:28:18 2007 +0000 darwin90-debug-harder-20071009 stab the stabs commit 9240a1e2525971e6eb419e5be2ea98a16342b657 Author: Derrick Brashear Date: Tue Oct 9 22:26:24 2007 +0000 taking-rx-back-into-the-20th-century-20061228 ken's patch is now on the ipv6 branch commit b4b2b74d145140fb785170dfbab5ca50ef24f045 Author: Derrick Brashear Date: Tue Oct 9 16:58:47 2007 +0000 darwin90-dsym-and-ppc-cputype-support-20071009 build for all ppc cputypes. also, support dsym debug info instead of stabs, when appropriate commit e4adbbc79b016b3fa4e83ad0e261a4c47aad55a5 Author: Derrick Brashear Date: Fri Oct 5 23:16:36 2007 +0000 sol10-abstraction-20071005 abstract things as needed commit f6e59be4dc203f4662d723ab42ed7f07c3367678 Author: Tom Keiser Date: Fri Oct 5 04:30:19 2007 +0000 dafs-listen-after-restoring-state-20071004 don't start rx server until the previous state has been loaded commit 409a3457033c4fe00074f22def3b29f630367dad Author: Derrick Brashear Date: Fri Oct 5 04:22:27 2007 +0000 vol-salvager-avoid-logging-to-nothing-20071004 check for logFile before using commit 127cebfacdaf84292fc1ecfd64c0e8d259aba474 Author: Marc Dionne Date: Fri Oct 5 04:07:27 2007 +0000 linux-2623-support-20071004 FIXES 70773 update for support for 2.6.23 commit 4ac01ec1ed2ce588185c055acfa3d73095a5b444 Author: Dale Ghent Date: Fri Oct 5 03:22:11 2007 +0000 solaris10-network-updates-20071004 FIXES 72759 This patch removes use of the non-Public ILL structures by OpenAFS to gather network interface information in order to make RX packet size and server locality decisions. commit 3c216378cba651dcb6519d7e615be37b534b56c8 Author: Jeffrey Altman Date: Thu Oct 4 15:11:07 2007 +0000 windows-btree-rename-case-only-20071004 Attempts to rename by case only would fail when there are more than one ambiguous matches. The list of data nodes would be corrupted and future tree manipulations could result in a crash. commit a7abca15b09561a0d9fda11c0cb99c9edd535d1d Author: Jeffrey Altman Date: Wed Oct 3 16:27:53 2007 +0000 libadmin-minimize-dns-lookups-20071003 Some cells have a large number of servers listed in the vldb that no longer exist and/or do not have PTR records in DNS. The algorithm used to obtain the "server names" from IP addresses involves opening a cell handle, creating an iterator of all servers, and then iterating over them until a match is found for the IP address. This is done for every server reference. Each time the iterator was constructed the vldb would be queried and gethostbyaddr() would be called on every listed ip address. This patch stores a copy of the server list in the cell handle along with an expiration time generated from a 10 minute TTL. This significant reduces but does not eliminate the number of times that the caller is blocked on reverse dns lookups. commit a4b995b61811ccfbe0586ad8ab3c096cf817d9b7 Author: Jeffrey Altman Date: Wed Oct 3 16:17:43 2007 +0000 windows-tviced-resfile-20071003 Add explicit build rules for TVICEDRES since we do not build the non-threaded file server on Windows commit 6cc29578b0a7d3ba06003070dce7e1df6cfeb327 Author: Tom Keiser Date: Tue Oct 2 01:14:08 2007 +0000 dafs-cbstate-tracking-fix-20071001 fix this the rest of the places it happens commit 7890ce9eade282398c06c00166b43e7d23151944 Author: Jeffrey Altman Date: Mon Oct 1 21:02:03 2007 +0000 windows-lanahelper-20071001 uninitialized variable in lana_IsLoopback commit aecaddba376c5e2f15a7cb52f1777b07546695d4 Author: Dan Hyde Date: Fri Sep 28 00:15:30 2007 +0000 vollistpart-init-error-20070927 FIXES 72144 correct an initialization failure in VolListPartitions commit 29d5a11a1fad9d93baab18409faed02547df5a63 Author: Tom Keiser Date: Thu Sep 27 17:30:32 2007 +0000 dafs-avoid-volhdr-leak-20070927 when there's an error don't leak the loaded header; release it commit 0ef8174a29d8963eee46b9deddc9cc465925ae88 Author: Jeffrey Altman Date: Thu Sep 20 12:56:54 2007 +0000 readme-nt-20070920 update wix and nsis instructions commit c984f03a9185e5b1b69e182ad891caa83541d08c Author: Jeffrey Altman Date: Thu Sep 20 12:44:23 2007 +0000 windows-version-info-20070920 add version info to the threaded version of butc.exe that we ship commit a0fa3b559836d134c44eae20cbd6d7d1d04a0d10 Author: Derrick Brashear Date: Thu Sep 20 05:52:23 2007 +0000 krb5-aklog-kimpersonate-conditionalize-20070920 make kimpersonate conitional commit 1aad009863a20306faae2996523a7a4c5efab18b Author: Derrick Brashear Date: Thu Sep 20 05:01:44 2007 +0000 dafs-loadvolumeheader-before-we-need-it-20070920 make sure we have a header instead of potentially dereffing null commit 87d87d33ea0b38cfa11ded288e6c24a1db7f13b1 Author: Jeffrey Altman Date: Thu Sep 20 04:54:14 2007 +0000 windows-fs-memdump-20070919 add directory lookup stats to "fs memdump" output commit a186b0d65c00a338995ad1f6379ef232742ab224 Author: Jeffrey Altman Date: Wed Sep 19 22:27:53 2007 +0000 windows-hex-dump-20070919 remove the broken percent quoting from OutputDebugHexDump as it is not required. We never use the resulting string as a print format string. commit feab12b929564a27a77bb84278291493003b605f Author: Jeffrey Altman Date: Wed Sep 19 18:55:55 2007 +0000 windows-version-info-20070919 FIXES 71397 Many of the OpenAFS binaries that are installed on end user machines did not have version information. This is problematic as it is impossible to determine which version of a binary the crash report was filed against when a report is received by Microsoft Windows Error Reporting service. commit b8abf04a45a82cc880d2ad59d3bbf2217fa08c11 Author: Jeffrey Altman Date: Tue Sep 18 17:57:31 2007 +0000 windows-vnovnode-while-file-in-use-20070918 Discovered another case where VNOVNODE errors were not being handled. If there are dirty buffers and a VNOVNODE error is received while writing the buffer, the buffer would be left in the dirty buffers queue. This caused a couple problems: (1) any attempt to flush the file, volume, or cache would fail because there were unflushed dirty buffers that could not be flushed. (2) shutdown of the service would hang because the buffers could not be flushed. In addition, while a VNOVNODE error would result in the cm_scache_t being marked CM_SCACHEFLAG_DELETED, this state was not being checked at the SMB la